@codeyam/codeyam-cli 0.1.0-staging.596f0eb → 0.1.0-staging.6e699e5

package/analyzer-template/packages/ai/src/lib/astScopes/astScopeAnalyzer.ts

@@ -5,7 +5,9 @@ import {
   AnalysisIssue,
   AstScopeAnalysisResult,
   CompletenessInfo,
+  CompoundConditional,
   ConditionalUsage,
+  DerivedVariableInfo,
 } from './types';
 import { PatternHandler } from './patterns/patternHandler';
 import { VariableDeclarationHandler } from './patterns/variableDeclarationHandler';
@@ -103,6 +105,17 @@ export class ASTScopeAnalyzer {
   private equivalentVariables: Record<string, string> = {};
   private environmentVariables: string[] = [];
   private conditionalUsages: Record<string, ConditionalUsage[]> = {};
+  private compoundConditionals: CompoundConditional[] = [];
+  private conditionalEffects: import('./types').ConditionalEffect[] = [];
+  private childBoundaryGatingConditions: Record<string, ConditionalUsage[]> =
+    {};
+  private jsxRenderingUsages: import('./types').JsxRenderingUsage[] = [];
+  /**
+   * Tracks derived boolean variables and their source expressions.
+   * Maps variable name to derivation info.
+   * Example: { hasAnalysis: { sourcePath: 'analysis', operation: 'notNull' } }
+   */
+  private derivedVariables: Record<string, DerivedVariableInfo> = {};
   private sourceFile: ts.SourceFile;
   private statementInfo: StatementInfo;
   private issues: AnalysisIssue[] = [];
@@ -203,6 +216,11 @@ export class ASTScopeAnalyzer {
       equivalentVariables: this.equivalentVariables,
       environmentVariables: this.environmentVariables,
       conditionalUsages: this.conditionalUsages,
+      compoundConditionals: this.compoundConditionals,
+      conditionalEffects: this.conditionalEffects,
+      derivedVariables: this.derivedVariables,
+      childBoundaryGatingConditions: this.childBoundaryGatingConditions,
+      jsxRenderingUsages: this.jsxRenderingUsages,
       isComplete:
         completeness.equivalences === 'full' &&
         completeness.structures === 'full',
@@ -245,7 +263,20 @@ export class ASTScopeAnalyzer {
         processExpression({ node, context, targetPath }),
       addConditionalUsage: (usage) => this.addConditionalUsage(usage),
       getConditionalUsages: () => this.conditionalUsages,
+      addChildBoundaryGatingCondition: (childName, condition) =>
+        this.addChildBoundaryGatingCondition(childName, condition),
+      getChildBoundaryGatingConditions: () =>
+        this.childBoundaryGatingConditions,
+      addDerivedVariable: (variableName, derivationInfo) =>
+        this.addDerivedVariable(variableName, derivationInfo),
+      addCompoundConditional: (compound) =>
+        this.addCompoundConditional(compound),
+      getCompoundConditionals: () => this.compoundConditionals,
       updateSchemaType: (path, newType) => this.updateSchemaType(path, newType),
+      addConditionalEffect: (effect) => this.addConditionalEffect(effect),
+      getConditionalEffects: () => this.conditionalEffects,
+      addJsxRenderingUsage: (usage) => this.addJsxRenderingUsage(usage),
+      getJsxRenderingUsages: () => this.jsxRenderingUsages,
     };
     return context;
   }
@@ -576,6 +607,17 @@ export class ASTScopeAnalyzer {
     const rightSideStr = rightSide?.toRightHandSideString();
 
     if (leftSideStr && rightSideStr && leftSideStr !== rightSideStr) {
+      const existingValue = this.equivalentVariables[leftSideStr];
+      // Don't overwrite a meaningful value with 'undefined' or 'null'.
+      // This is critical for ternary conditionals like `const x = cond ? func() : undefined`
+      // or `const x = items.find(...) || null` where we want to preserve
+      // the equivalency to the more meaningful value (func()'s return value, items[]).
+      if (
+        existingValue &&
+        (rightSideStr === 'undefined' || rightSideStr === 'null')
+      ) {
+        return;
+      }
       this.equivalentVariables[leftSideStr] = rightSideStr;
     }
   }
@@ -607,11 +649,39 @@ export class ASTScopeAnalyzer {
     }
   }
 
+  /**
+   * Record a derived variable and its source expression.
+   * Called when we see patterns like:
+   * - const hasAnalysis = analysis !== null
+   * - const isLoading = status === 'loading'
+   * - const isBusy = isRunning || isQueued
+   */
+  private addDerivedVariable(
+    variableName: string,
+    derivationInfo: DerivedVariableInfo,
+  ): void {
+    this.derivedVariables[variableName] = derivationInfo;
+  }
+
+  /**
+   * Get derivation info for a variable if it was derived from another expression.
+   */
+  private getDerivedVariableInfo(
+    variableName: string,
+  ): DerivedVariableInfo | undefined {
+    return this.derivedVariables[variableName];
+  }
+
   /**
    * Add a conditional usage for key attribute detection
-   * Groups usages by path for easy lookup
+   * Groups usages by path for easy lookup.
+   * Also enriches the usage with derivation info if the variable is derived.
    */
   private addConditionalUsage(usage: ConditionalUsage): void {
+    // Note: Derivation info enrichment now happens in analyzeScope.ts after all
+    // statements are processed, so derived variables from earlier statements can
+    // be used to enrich usages from later statements.
+
     if (!this.conditionalUsages[usage.path]) {
       this.conditionalUsages[usage.path] = [];
     }
@@ -628,6 +698,73 @@ export class ASTScopeAnalyzer {
     }
   }
 
+  /**
+   * Add a gating condition for a child component.
+   * Called when we see patterns like: {hasAnalysis && <ChildComponent />}
+   * Groups conditions by child component name.
+   */
+  private addChildBoundaryGatingCondition(
+    childComponentName: string,
+    gatingCondition: ConditionalUsage,
+  ): void {
+    if (!this.childBoundaryGatingConditions[childComponentName]) {
+      this.childBoundaryGatingConditions[childComponentName] = [];
+    }
+    // Avoid duplicates with same path and conditionType
+    const exists = this.childBoundaryGatingConditions[childComponentName].some(
+      (existing) =>
+        existing.path === gatingCondition.path &&
+        existing.conditionType === gatingCondition.conditionType &&
+        existing.isNegated === gatingCondition.isNegated,
+    );
+    if (!exists) {
+      this.childBoundaryGatingConditions[childComponentName].push(
+        gatingCondition,
+      );
+    }
+  }
+
+  /**
+   * Add a compound conditional for key attribute dependency detection
+   */
+  private addCompoundConditional(compound: CompoundConditional): void {
+    // Avoid duplicates by expression and location (chainId is generated each time)
+    const exists = this.compoundConditionals.some(
+      (existing) =>
+        existing.expression === compound.expression &&
+        existing.sourceLocation.lineNumber ===
+          compound.sourceLocation.lineNumber,
+    );
+    if (!exists) {
+      this.compoundConditionals.push(compound);
+    }
+  }
+
+  /**
+   * Add a conditional effect (setter call inside a conditional)
+   */
+  private addConditionalEffect(
+    effect: import('./types').ConditionalEffect,
+  ): void {
+    this.conditionalEffects.push(effect);
+  }
+
+  /**
+   * Add a JSX rendering usage (array.map() or text interpolation)
+   * Deduplicates by path and rendering type
+   */
+  private addJsxRenderingUsage(
+    usage: import('./types').JsxRenderingUsage,
+  ): void {
+    // Deduplicate: don't add if we already have the same path + renderingType
+    const exists = this.jsxRenderingUsages.some(
+      (u) => u.path === usage.path && u.renderingType === usage.renderingType,
+    );
+    if (!exists) {
+      this.jsxRenderingUsages.push(usage);
+    }
+  }
+
   /**
    * Updates the schema type for a path, typically used when switch statements
    * reveal the valid values for a parameter (creating a union type like "'a' | 'b' | 'c'")