@codeyam/codeyam-cli 0.1.0-staging.1 → 0.1.0-staging.596f0eb

package/analyzer-template/packages/ai/src/lib/astScopes/processExpression.ts

@@ -2,7 +2,7 @@ import ts from 'typescript';
 import { AnalysisContext, ConditionalUsage } from './types';
 import { StructuredPath } from './paths';
 import { nodeToSource } from './nodeToSource';
-import { methodRegistry } from './methodSemantics';
+import { methodRegistry, ArrayPushSemantics } from './methodSemantics';
 import {
   isArithmeticOperator,
   isAssignmentOperator,
@@ -15,6 +15,47 @@ import {
 } from './sharedPatterns';
 import { processBindingPattern } from './processBindings';
 
+/**
+ * Checks if an expression is likely an array type.
+ * Uses TypeScript's type checker when available, falls back to heuristics.
+ */
+function isLikelyArrayType(
+  expr: ts.Expression,
+  typeChecker: ts.TypeChecker | undefined,
+): boolean {
+  if (typeChecker) {
+    try {
+      const type = typeChecker.getTypeAtLocation(expr);
+      const typeString = typeChecker.typeToString(type);
+      // Check for common array type patterns:
+      // - T[] syntax (includes any[], string[], etc.)
+      // - Array<T> syntax
+      // - ReadonlyArray<T> syntax
+      // - readonly T[] syntax (starts with "readonly " and ends with "[]")
+      if (
+        typeString.includes('[]') ||
+        typeString.startsWith('Array<') ||
+        typeString.startsWith('ReadonlyArray<')
+      ) {
+        return true;
+      }
+      // Check if it's a tuple or array literal type via TypeScript's type flags
+      if (type.getFlags() & ts.TypeFlags.Object) {
+        const objectType = type as ts.ObjectType;
+        if (
+          objectType.objectFlags & ts.ObjectFlags.Tuple ||
+          objectType.objectFlags & ts.ObjectFlags.ArrayLiteral
+        ) {
+          return true;
+        }
+      }
+    } catch {
+      // Type checking can fail in some edge cases, fall through to false
+    }
+  }
+  return false;
+}
+
 /**
  * Marks variables used in truthiness checks as potentially undefined.
  * When code checks `if (x)` or `x && ...`, it indicates x might be falsy (null/undefined).
@@ -326,6 +367,46 @@ export function processExpression({
     if (targetPath) {
       context.addEquivalence(targetPath, nodePath);
       context.addType(targetPath, inferredNodeType);
+
+      // Propagate sub-properties from the identifier to the targetPath
+      // This handles cases like: dataItem={{ structure: completeDataStructure }}
+      // where completeDataStructure was defined as { 'Function Arguments': dataStructure.arguments }
+      // We need to propagate completeDataStructure['Function Arguments'] to
+      // ChildComponent().signature[0].dataItem.structure['Function Arguments']
+      const nodePathStr = nodePath.toString();
+      const equivalentVariables = context.getEquivalentVariables();
+      const structure = context.getStructure();
+
+      // Propagate existing equivalencies for sub-properties
+      for (const [key, value] of Object.entries(equivalentVariables)) {
+        // Check if this equivalency is for a sub-property of the identifier
+        // e.g., completeDataStructure['Function Arguments'] or completeDataStructure.foo
+        if (
+          key.startsWith(nodePathStr + '.') ||
+          key.startsWith(nodePathStr + '[')
+        ) {
+          const subPath = key.substring(nodePathStr.length);
+          const newTargetPath = StructuredPath.fromBase(
+            targetPath.toString() + subPath,
+          );
+          const valuePath = StructuredPath.fromBase(value);
+          context.addEquivalence(newTargetPath, valuePath);
+        }
+      }
+
+      // Propagate existing structure entries for sub-properties
+      for (const [key, value] of Object.entries(structure)) {
+        if (
+          key.startsWith(nodePathStr + '.') ||
+          key.startsWith(nodePathStr + '[')
+        ) {
+          const subPath = key.substring(nodePathStr.length);
+          const newTargetPath = StructuredPath.fromBase(
+            targetPath.toString() + subPath,
+          );
+          context.addType(newTargetPath, value);
+        }
+      }
     }
     context.addType(nodePath, inferredNodeType);
     return true;
@@ -756,6 +837,9 @@ export function processExpression({
         } else {
           resultType = rightType || 'unknown';
         }
+        // For || and ??, create an equivalence to the left side
+        // This ensures the equivalency chain is preserved through fallback expressions
+        // e.g., `const tab = segments[0] || 'default'` should trace tab back to segments[0]
         if (operatorKind === ts.SyntaxKind.QuestionQuestionToken) {
           // specifically for ?? we create an equivalence to the left side
           if (targetPath) {
@@ -774,6 +858,17 @@ export function processExpression({
               context.sourceFile,
             );
           }
+        } else if (operatorKind === ts.SyntaxKind.BarBarToken) {
+          // For ||, also create an equivalence to the left side
+          // This enables data flow tracing through fallback expressions
+          if (targetPath) {
+            resultPath = StructuredPath.fromNode(
+              unwrappedNode.left,
+              context.sourceFile,
+            );
+          }
+          // Note: Unlike ??, we don't set targetPath when there's no target
+          // because || is often used in boolean contexts where the full expression matters
         }
       } else if (operatorKind === ts.SyntaxKind.InstanceOfKeyword) {
         resultType = 'boolean';
@@ -885,10 +980,19 @@ export function processExpression({
         );
 
         if (sourcePath) {
-          // Apply method semantics
-          semantics.addEquivalences(callPath, sourcePath, context);
-          returnType = semantics.getReturnType();
-          handledBySemantics = true;
+          // For array-specific semantics (like push), verify the source is actually an array
+          // This prevents router.push() from being mistakenly treated as Array.push()
+          const isArraySemantics = semantics instanceof ArrayPushSemantics;
+          const shouldApply =
+            !isArraySemantics ||
+            isLikelyArrayType(sourceExpr, context.typeChecker);
+
+          if (shouldApply) {
+            // Apply method semantics
+            semantics.addEquivalences(callPath, sourcePath, context);
+            returnType = semantics.getReturnType();
+            handledBySemantics = true;
+          }
         }
       }
     }
@@ -911,10 +1015,18 @@ export function processExpression({
         );
 
         if (sourcePath) {
-          // Apply method semantics
-          semantics.addEquivalences(callPath, sourcePath, context);
-          returnType = semantics.getReturnType();
-          handledBySemantics = true;
+          // For array-specific semantics (like push), verify the source is actually an array
+          const isArraySemantics = semantics instanceof ArrayPushSemantics;
+          const shouldApply =
+            !isArraySemantics ||
+            isLikelyArrayType(sourceExpr, context.typeChecker);
+
+          if (shouldApply) {
+            // Apply method semantics
+            semantics.addEquivalences(callPath, sourcePath, context);
+            returnType = semantics.getReturnType();
+            handledBySemantics = true;
+          }
         }
       }
     }
@@ -1009,24 +1121,27 @@ export function processExpression({
           context.addType(valuePath, valueType);
         } else if (ts.isSpreadAssignment(property)) {
           // Handle spread: { ...obj }
-          // Process the spread expression first (without targetPath for now)
-          processExpression({ node: property.expression, context });
-
           // Create a path for this spread source
           let spreadSourcePath: StructuredPath | null = null;
 
           // Handle simple identifier spread: { ...obj }
           if (ts.isIdentifier(property.expression)) {
+            // Process the spread expression first
+            processExpression({ node: property.expression, context });
+
             spreadSourcePath = StructuredPath.fromBase(
               property.expression.text,
             );
             // Establish equivalence between the target and the spread source
             context.addEquivalence(targetPath, spreadSourcePath);
-            // and we kow obj is an object
+            // and we know obj is an object
             context.addType(spreadSourcePath, 'object');
           }
           // Handle property access spread: { ...obj.prop }
           else if (ts.isPropertyAccessExpression(property.expression)) {
+            // Process the spread expression first
+            processExpression({ node: property.expression, context });
+
             spreadSourcePath = StructuredPath.fromNode(
               property.expression,
               context.sourceFile,
@@ -1035,8 +1150,55 @@ export function processExpression({
               context.addEquivalence(targetPath, spreadSourcePath);
             }
           }
+          // Handle object literal spread: { ...{ key: value } }
+          // This propagates sub-properties from the spread object to the target
+          else if (ts.isObjectLiteralExpression(property.expression)) {
+            // Recursively process the spread object literal WITH targetPath
+            // This ensures sub-properties like { args: x } become targetPath.args = x
+            processExpression({
+              node: property.expression,
+              context,
+              targetPath,
+            });
+          }
+          // Handle conditional spread: { ...(x ? {...} : {}) }
+          else if (ts.isParenthesizedExpression(property.expression)) {
+            // Unwrap parentheses and process
+            const unwrapped = property.expression.expression;
+
+            // Handle conditional expression inside parens: (x ? {...} : {})
+            if (ts.isConditionalExpression(unwrapped)) {
+              // Process both branches - whenTrue and whenFalse
+              // For tracing, we care about non-empty branches
+              if (ts.isObjectLiteralExpression(unwrapped.whenTrue)) {
+                processExpression({
+                  node: unwrapped.whenTrue,
+                  context,
+                  targetPath,
+                });
+              } else {
+                processExpression({ node: unwrapped.whenTrue, context });
+              }
+
+              if (ts.isObjectLiteralExpression(unwrapped.whenFalse)) {
+                processExpression({
+                  node: unwrapped.whenFalse,
+                  context,
+                  targetPath,
+                });
+              } else {
+                processExpression({ node: unwrapped.whenFalse, context });
+              }
+            } else {
+              // Other parenthesized expression - just process normally
+              processExpression({ node: property.expression, context });
+            }
+          }
           // Handle other expression types
           else {
+            // Process the spread expression
+            processExpression({ node: property.expression, context });
+
             // For complex expressions, use their source representation
             spreadSourcePath = nodeToSource(
               property.expression,
@@ -1563,6 +1725,24 @@ export function processExpression({
     return true;
   }
 
+  // Handle Void Expression: void x, void 0, void func()
+  if (ts.isVoidExpression(unwrappedNode)) {
+    // Process the inner expression for side effects
+    processExpression({ node: unwrappedNode.expression, context });
+
+    // void always returns undefined
+    if (targetPath) {
+      const voidPath = StructuredPath.createLiteralPath(
+        'undefined',
+        'undefined',
+      );
+      context.addEquivalence(targetPath, voidPath);
+      context.addType(targetPath, 'undefined');
+    }
+
+    return true;
+  }
+
   // Handle Prefix Unary Expressions: ++x, --y, !z, -a
   if (ts.isPrefixUnaryExpression(unwrappedNode)) {
     // Process the operand
@@ -1779,8 +1959,9 @@ export function processExpression({
       }
     }
 
-    // Register component as 'function' type (not 'JSX')
-    context.addType(componentPath, 'function');
+    // Register component as 'jsx-component' type to distinguish from regular function calls
+    // This allows downstream code to identify JSX components and not treat them as method chains
+    context.addType(componentPath, 'jsx-component');
 
     // If targetPath is provided (e.g., in variable assignment), establish equivalence to hardcoded "JSX"
     if (targetPath) {
@@ -1960,6 +2141,25 @@ export function processExpression({
     return result;
   }
 
+  // Handle yield expressions in generator functions
+  if (ts.isYieldExpression(unwrappedNode)) {
+    // yield returns whatever is yielded, or undefined if no expression
+    if (unwrappedNode.expression) {
+      // Process the yielded expression
+      const result = processExpression({
+        node: unwrappedNode.expression,
+        context,
+        targetPath,
+      });
+      return result;
+    }
+    // yield with no expression returns undefined
+    if (targetPath) {
+      context.addType(targetPath, 'undefined');
+    }
+    return true;
+  }
+
   if (ts.isRegularExpressionLiteral(unwrappedNode)) {
     // Regular expressions are treated as string literals
     const regexPath = StructuredPath.createLiteralPath(

package/analyzer-template/packages/ai/src/lib/astScopes/types.ts

@@ -317,4 +317,8 @@ export interface AnalysisContext {
 
   // Get all conditional usages
   getConditionalUsages(): Record<string, ConditionalUsage[]>;
+
+  // Update a schema type, typically used when switch statements reveal
+  // the valid values for a parameter (creating a union type)
+  updateSchemaType(path: string | StructuredPath, newType: string): void;
 }

package/analyzer-template/packages/ai/src/lib/checkAllAttributes.ts

@@ -1,7 +1,5 @@
 export default function checkAllAttributes(data: { [key: string]: unknown }) {
-  if (data === null) return data;
-
-  for (const key of Object.keys(data)) {
+  for (const key of Object.keys(data || {})) {
     try {
       if (data[key] === undefined) {
         delete data[key];