@charcoal-ui/react 3.3.0 → 3.5.0

package/src/components/TextField/index.tsx

@@ -2,11 +2,11 @@ import { useTextField } from '@react-aria/textfield'
 import { useVisuallyHidden } from '@react-aria/visually-hidden'
 import { ReactNode, useCallback, useEffect, useRef, useState } from 'react'
 import * as React from 'react'
-import styled from 'styled-components'
+import styled, { css } from 'styled-components'
 import FieldLabel, { FieldLabelProps } from '../FieldLabel'
 import { countCodePointsInString, mergeRefs } from '../../_lib'
-import { theme } from '../../styled'
 import { ReactAreaUseTextFieldCompat } from '../../_lib/compat'
+import { useFocusWithClick } from './useFocusWithClick'
 
 type DOMProps = Omit<
   React.InputHTMLAttributes<HTMLInputElement>,
@@ -64,13 +64,9 @@ const TextField = React.forwardRef<HTMLInputElement, TextFieldProps>(
 
     const { visuallyHiddenProps } = useVisuallyHidden()
     const ariaRef = useRef<HTMLInputElement>(null)
-    const prefixRef = useRef<HTMLSpanElement>(null)
-    const suffixRef = useRef<HTMLSpanElement>(null)
     const [count, setCount] = useState(
       countCodePointsInString(props.value ?? '')
     )
-    const [prefixWidth, setPrefixWidth] = useState(0)
-    const [suffixWidth, setSuffixWidth] = useState(0)
 
     const nonControlled = props.value === undefined
     const handleChange = useCallback(
@@ -106,26 +102,9 @@ const TextField = React.forwardRef<HTMLInputElement, TextFieldProps>(
         ariaRef
       )
 
-    useEffect(() => {
-      const prefixObserver = new ResizeObserver((entries) => {
-        setPrefixWidth(entries[0].contentRect.width)
-      })
-      const suffixObserver = new ResizeObserver((entries) => {
-        setSuffixWidth(entries[0].contentRect.width)
-      })
-
-      if (prefixRef.current !== null) {
-        prefixObserver.observe(prefixRef.current)
-      }
-      if (suffixRef.current !== null) {
-        suffixObserver.observe(suffixRef.current)
-      }
-
-      return () => {
-        suffixObserver.disconnect()
-        prefixObserver.disconnect()
-      }
-    }, [])
+    const containerRef = useRef(null)
+
+    useFocusWithClick(containerRef, ariaRef)
 
     return (
       <TextFieldRoot className={className} isDisabled={disabled}>
@@ -137,25 +116,29 @@ const TextField = React.forwardRef<HTMLInputElement, TextFieldProps>(
           {...labelProps}
           {...(!showLabel ? visuallyHiddenProps : {})}
         />
-        <StyledInputContainer>
-          <PrefixContainer ref={prefixRef}>
-            <Affix>{prefix}</Affix>
-          </PrefixContainer>
+        <StyledInputContainer
+          ref={containerRef}
+          invalid={invalid}
+          aria-disabled={disabled === true ? true : undefined}
+          hasPrefix={prefix != null}
+          hasSuffix={suffix != null || showCount}
+        >
+          {prefix && <PrefixContainer>{prefix}</PrefixContainer>}
           <StyledInput
             ref={mergeRefs(forwardRef, ariaRef)}
             invalid={invalid}
-            extraLeftPadding={prefixWidth}
-            extraRightPadding={suffixWidth}
             {...inputProps}
           />
-          <SuffixContainer ref={suffixRef}>
-            <Affix>{suffix}</Affix>
-            {showCount && (
-              <SingleLineCounter>
-                {maxLength !== undefined ? `${count}/${maxLength}` : count}
-              </SingleLineCounter>
-            )}
-          </SuffixContainer>
+          {(suffix || showCount) && (
+            <SuffixContainer>
+              {suffix}
+              {showCount && (
+                <SingleLineCounter>
+                  {maxLength !== undefined ? `${count}/${maxLength}` : count}
+                </SingleLineCounter>
+              )}
+            </SuffixContainer>
+          )}
         </StyledInputContainer>
         {assistiveText != null && assistiveText.length !== 0 && (
           <AssistiveText
@@ -179,44 +162,69 @@ const TextFieldRoot = styled.div<{ isDisabled: boolean }>`
   ${(p) => p.isDisabled && { opacity: p.theme.elementEffect.disabled.opacity }}
 `
 
-const TextFieldLabel = styled(FieldLabel)`
-  ${theme((o) => o.margin.bottom(8))}
+export const TextFieldLabel = styled(FieldLabel)`
+  margin-bottom: 8px;
 `
 
-const StyledInputContainer = styled.div`
-  height: 40px;
+const StyledInputContainer = styled.div<{
+  invalid: boolean
+  hasPrefix: boolean
+  hasSuffix: boolean
+}>`
   display: grid;
-  position: relative;
+  grid-template-columns: ${(p) =>
+    [p.hasPrefix && 'auto', '1fr', p.hasSuffix && 'auto']
+      .filter(Boolean)
+      .join(' ')};
+  height: 40px;
+  transition: 0.2s background-color, 0.2s box-shadow;
+  color: var(--charcoal-text2);
+  background-color: var(--charcoal-surface3);
+  border-radius: 4px;
+  gap: 4px;
+  padding: 0 8px;
+  line-height: 22px;
+  font-size: 14px;
+
+  :not(:disabled):not([aria-disabled]):hover,
+  [aria-disabled='false']:hover {
+    background-color: var(--charcoal-surface3-hover);
+  }
+
+  :not(:disabled):not([aria-disabled]):active,
+  [aria-disabled='false']:active {
+    outline: none;
+    box-shadow: 0 0 0 4px
+      ${(p) => (p.invalid ? `rgba(255,43,0,0.32)` : `rgba(0, 150, 250, 0.32);`)};
+  }
+
+  :focus-within {
+    outline: none;
+    box-shadow: 0 0 0 4px
+      ${(p) => (p.invalid ? `rgba(255,43,0,0.32)` : `rgba(0, 150, 250, 0.32);`)};
+  }
+
+  ${(p) =>
+    p.invalid &&
+    css`
+      box-shadow: 0 0 0 4px rgba(255, 43, 0, 0.32);
+    `}
 `
 
-const PrefixContainer = styled.span`
-  position: absolute;
-  top: 50%;
-  left: 8px;
-  transform: translateY(-50%);
-  z-index: 1;
+const PrefixContainer = styled.div`
+  display: flex;
+  padding-left: 8px;
+  align-items: center;
 `
 
 const SuffixContainer = styled.span`
-  position: absolute;
-  top: 50%;
-  right: 8px;
-  transform: translateY(-50%);
-
   display: flex;
+  align-items: center;
   gap: 8px;
 `
 
-const Affix = styled.span`
-  user-select: none;
-
-  ${theme((o) => [o.typography(14).preserveHalfLeading, o.font.text2])}
-`
-
 const StyledInput = styled.input<{
   invalid: boolean
-  extraLeftPadding: number
-  extraRightPadding: number
 }>`
   border: none;
   box-sizing: border-box;
@@ -230,36 +238,30 @@ const StyledInput = styled.input<{
   height: calc(100% / 0.875);
   font-size: calc(14px / 0.875);
   line-height: calc(22px / 0.875);
-  padding-left: calc((8px + ${(p) => p.extraLeftPadding}px) / 0.875);
-  padding-right: calc((8px + ${(p) => p.extraRightPadding}px) / 0.875);
+  padding-left: 0;
+  padding-right: 0;
   border-radius: calc(4px / 0.875);
 
   /* Display box-shadow for iOS Safari */
   appearance: none;
+  background: transparent;
 
-  ${(p) =>
-    theme((o) => [
-      o.bg.surface3.hover,
-      o.outline.default.focus,
-      p.invalid && o.outline.assertive,
-      o.font.text2,
-    ])}
-
+  color: var(--charcoal-text2);
   &::placeholder {
-    ${theme((o) => o.font.text3)}
+    color: var(--charcoal-text3);
   }
 `
 
 const SingleLineCounter = styled.span`
-  ${theme((o) => [o.typography(14).preserveHalfLeading, o.font.text3])}
+  line-height: 22px;
+  font-size: 14px;
+  color: var(--charcoal-text3);
 `
 
-const AssistiveText = styled.p<{ invalid: boolean }>`
-  ${(p) =>
-    theme((o) => [
-      o.typography(14),
-      o.margin.top(8),
-      o.margin.bottom(0),
-      o.font[p.invalid ? 'assertive' : 'text1'],
-    ])}
+export const AssistiveText = styled.p<{ invalid: boolean }>`
+  font-size: 14px;
+  line-height: 22px;
+  margin-top: 4px;
+  margin-bottom: -4px;
+  color: ${(p) => `var(--charcoal-${p.invalid ? `assertive` : `text2`})`};
 `

package/src/components/TextField/useFocusWithClick.tsx

@@ -0,0 +1,22 @@
+import { useEffect } from 'react'
+import * as React from 'react'
+
+export function useFocusWithClick(
+  containerRef: React.RefObject<HTMLDivElement>,
+  inputRef: React.RefObject<HTMLInputElement | HTMLTextAreaElement>
+) {
+  useEffect(() => {
+    const el = containerRef.current
+    if (el) {
+      const handleDown = (e: MouseEvent) => {
+        if (e.target !== inputRef.current) {
+          inputRef.current?.focus()
+        }
+      }
+      el.addEventListener('click', handleDown)
+      return () => {
+        el.removeEventListener('click', handleDown)
+      }
+    }
+  })
+}

package/dist/components/Button/index.test.d.ts

@@ -1,4 +0,0 @@
-import 'jest-styled-components';
-import renderer from 'react-test-renderer';
-export declare function render(children: JSX.Element): renderer.ReactTestRendererJSON | renderer.ReactTestRendererJSON[] | null;
-//# sourceMappingURL=index.test.d.ts.map

package/dist/components/Button/index.test.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"index.test.d.ts","sourceRoot":"","sources":["../../../src/components/Button/index.test.tsx"],"names":[],"mappings":"AAAA,OAAO,wBAAwB,CAAA;AAG/B,OAAO,QAAQ,MAAM,qBAAqB,CAAA;AAI1C,wBAAgB,MAAM,CAAC,QAAQ,EAAE,GAAG,CAAC,OAAO,4EAI3C"}

package/src/components/Button/index.test.tsx

@@ -1,24 +0,0 @@
-import 'jest-styled-components'
-
-import Button from '.'
-import renderer from 'react-test-renderer'
-import { ThemeProvider } from 'styled-components'
-import { light } from '@charcoal-ui/theme'
-
-export function render(children: JSX.Element) {
-  return renderer
-    .create(<ThemeProvider theme={light}>{children}</ThemeProvider>)
-    .toJSON()
-}
-
-describe('Basic', () => {
-  test('<Button>Hello</Button>', () => {
-    expect(render(<Button>Hello</Button>)).toMatchSnapshot()
-  })
-})
-
-describe('Link', () => {
-  test('<Button to="#">Hello</Button>', () => {
-    expect(render(<Button to="#">Hello</Button>)).toMatchSnapshot()
-  })
-})