@cesium/engine 22.2.0 → 22.3.0

package/Source/Scene/CumulusCloud.js

@@ -31,7 +31,7 @@ import defined from "../Core/defined.js";
  * @internalConstructor
  * @class
  *
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Cloud%20Parameters.html|Cesium Sandcastle Cloud Parameters Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=cloud-parameters|Cesium Sandcastle Cloud Parameters Demo}
  */
 function CumulusCloud(options, cloudCollection) {
   options = options ?? Frozen.EMPTY_OBJECT;

package/Source/Scene/DynamicEnvironmentMapManager.js

@@ -33,7 +33,7 @@ import ConvolveSpecularMapVS from "../Shaders/ConvolveSpecularMapVS.js";
  * @typedef {object} DynamicEnvironmentMapManager.ConstructorOptions
  * Options for the DynamicEnvironmentMapManager constructor
  * @property {boolean} [enabled=true] If true, the environment map and related properties will continue to update.
- * @property {number} [mipmapLevels=7] The number of mipmap levels to generate for specular maps. More mipmap levels will produce a higher resolution specular reflection.
+ * @property {number} [mipmapLevels=7] The maximum desired number of mipmap levels to generate for specular maps. More mipmap levels will produce a higher resolution specular reflection. The actual number of mipmaps used will be bounded by the cubemap texture size supported on the client machine. The number of mipmaps must be at least one for the environment map to be generated.
  * @property {number} [maximumSecondsDifference=3600] The maximum amount of elapsed seconds before a new environment map is created.
  * @property {number} [maximumPositionEpsilon=1000] The maximum difference in position before a new environment map is created, in meters. Small differences in position will not visibly affect results.
  * @property {number} [atmosphereScatteringIntensity=2.0] The intensity of the scattered light emitted from the atmosphere. This should be adjusted relative to the value of {@link Scene.light} intensity.
@@ -81,14 +81,21 @@ function DynamicEnvironmentMapManager(options) {
 
   options = options ?? Frozen.EMPTY_OBJECT;
 
-  const mipmapLevels = Math.min(
-    options.mipmapLevels ?? 7,
-    Math.log2(ContextLimits.maximumCubeMapSize),
+  const mipmapLevels = Math.max(
+    Math.floor(
+      Math.min(
+        options.mipmapLevels ?? 7,
+        Math.log2(ContextLimits.maximumCubeMapSize),
+      ),
+    ),
+    0,
   );
 
   this._mipmapLevels = mipmapLevels;
+
+  const arrayLength = Math.max(mipmapLevels - 1, 0) * 6;
   this._radianceMapComputeCommands = new Array(6);
-  this._convolutionComputeCommands = new Array((mipmapLevels - 1) * 6);
+  this._convolutionComputeCommands = new Array(arrayLength);
   this._irradianceComputeCommand = undefined;
 
   this._radianceMapFS = undefined;
@@ -97,7 +104,7 @@ function DynamicEnvironmentMapManager(options) {
   this._va = undefined;
 
   this._radianceMapTextures = new Array(6);
-  this._specularMapTextures = new Array((mipmapLevels - 1) * 6);
+  this._specularMapTextures = new Array(arrayLength);
   this._radianceCubeMap = undefined;
   this._irradianceMapTexture = undefined;
 
@@ -105,7 +112,7 @@ function DynamicEnvironmentMapManager(options) {
     DynamicEnvironmentMapManager.DEFAULT_SPHERICAL_HARMONIC_COEFFICIENTS.slice();
 
   this._lastTime = new JulianDate();
-  const width = Math.pow(2, mipmapLevels - 1);
+  const width = Math.max(Math.pow(2, mipmapLevels - 1), 1);
   this._textureDimensions = new Cartesian2(width, width);
 
   this._radiiAndDynamicAtmosphereColor = new Cartesian3();
@@ -621,6 +628,28 @@ function updateSpecularMaps(manager, frameState) {
   const context = frameState.context;
 
   let facesCopied = 0;
+  const checkComplete = () => {
+    // All faces for each mipmap level have been copied
+    const length = manager._specularMapTextures.length;
+    if (facesCopied >= length) {
+      manager._irradianceCommandDirty = true;
+
+      if (mipmapLevels > 1) {
+        radianceCubeMap.sampler = new Sampler({
+          minificationFilter: TextureMinificationFilter.LINEAR_MIPMAP_LINEAR,
+        });
+
+        manager._shouldRegenerateShaders = true;
+
+        // Cleanup shared resources
+        manager._va.destroy();
+        manager._va = undefined;
+        manager._convolveSP.destroy();
+        manager._convolveSP = undefined;
+      }
+    }
+  };
+
   const getPostExecute = (command, index, texture, face, level) => () => {
     if (manager.isDestroyed() || command.canceled) {
       DynamicEnvironmentMapManager._activeComputeCommandCount--;
@@ -638,22 +667,7 @@ function updateSpecularMaps(manager, frameState) {
     texture.destroy();
     manager._specularMapTextures[index] = undefined;
 
-    // All faces for each mipmap level have been copied
-    const length = manager._specularMapTextures.length;
-    if (facesCopied >= length) {
-      manager._irradianceCommandDirty = true;
-      radianceCubeMap.sampler = new Sampler({
-        minificationFilter: TextureMinificationFilter.LINEAR_MIPMAP_LINEAR,
-      });
-
-      manager._shouldRegenerateShaders = true;
-
-      // Cleanup shared resources
-      manager._va.destroy();
-      manager._va = undefined;
-      manager._convolveSP.destroy();
-      manager._convolveSP = undefined;
-    }
+    checkComplete();
   };
 
   let index = 0;
@@ -721,6 +735,7 @@ function updateSpecularMaps(manager, frameState) {
     width /= 2;
     height /= 2;
   }
+  checkComplete();
 }
 
 const irradianceTextureDimensions = new Cartesian2(3, 3); // 9 coefficients
@@ -839,9 +854,9 @@ function updateSphericalHarmonicCoefficients(manager, frameState) {
 DynamicEnvironmentMapManager.prototype.update = function (frameState) {
   const mode = frameState.mode;
   const isSupported =
-    // A FrameState type works here because the function only references the context parameter.
-    // @ts-ignore
-    DynamicEnvironmentMapManager.isDynamicUpdateSupported(frameState);
+    // @ts-expect-error A FrameState type works here because the function only references the context parameter.
+    DynamicEnvironmentMapManager.isDynamicUpdateSupported(frameState) &&
+    this._mipmapLevels >= 1;
 
   if (
     !isSupported ||

package/Source/Scene/Fog.js

@@ -8,7 +8,7 @@ import SceneMode from "./SceneMode.js";
  * Blends the atmosphere to geometry far from the camera for horizon views. Allows for additional
  * performance improvements by rendering less geometry and dispatching less terrain requests.
  *
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Fog.html|Cesium Sandcastle Fog Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=fog|Cesium Sandcastle Fog Demo}
  *
  * @alias Fog
  * @constructor

package/Source/Scene/GaussianSplatPrimitive.js

@@ -788,7 +788,7 @@ GaussianSplatPrimitive.buildGSplatDrawCommand = function (
     cull: renderStateOptions.cull.enabled,
     pass: Pass.GAUSSIAN_SPLATS,
     count: renderResources.count,
-    owner: this,
+    owner: primitive,
     instanceCount: renderResources.instanceCount,
     primitiveType: PrimitiveType.TRIANGLE_STRIP,
     debugShowBoundingVolume: tileset.debugShowBoundingVolume,

package/Source/Scene/Globe.js

@@ -723,14 +723,7 @@ Globe.prototype.pickWorldCoordinates = function (
   const sphereIntersections = scratchArray;
   sphereIntersections.length = 0;
 
-  const tilesToRender = this._surface._tilesToRender;
-  let length = tilesToRender.length;
-
-  let tile;
-  let i;
-
-  for (i = 0; i < length; ++i) {
-    tile = tilesToRender[i];
+  for (const tile of this._surface._tilesRenderedThisFrame) {
     const surfaceTile = tile.data;
 
     if (!defined(surfaceTile)) {
@@ -776,8 +769,8 @@ Globe.prototype.pickWorldCoordinates = function (
   sphereIntersections.sort(createComparePickTileFunction(ray.origin));
 
   let intersection;
-  length = sphereIntersections.length;
-  for (i = 0; i < length; ++i) {
+  const length = sphereIntersections.length;
+  for (let i = 0; i < length; ++i) {
     intersection = sphereIntersections[i].pick(
       ray,
       scene.mode,

package/Source/Scene/GltfLoader.js

@@ -1811,6 +1811,16 @@ function loadMaterial(loader, gltfMaterial, frameState) {
   material.alphaCutoff = gltfMaterial.alphaCutoff;
   material.doubleSided = gltfMaterial.doubleSided;
 
+  // BENTLEY_materials_point_style extension
+  const pointStyleExtension = extensions.BENTLEY_materials_point_style;
+  if (defined(pointStyleExtension) && defined(pointStyleExtension.diameter)) {
+    const diameter = pointStyleExtension.diameter;
+    // The spec requires a positive integer, but we floor non-integers as a best effort.
+    if (diameter >= 1) {
+      material.pointDiameter = Math.floor(diameter);
+    }
+  }
+
   return material;
 }
 

package/Source/Scene/ImageBasedLighting.js

@@ -162,7 +162,7 @@ Object.defineProperties(ImageBasedLighting.prototype, {
    * @memberof ImageBasedLighting.prototype
    *
    * @type {Cartesian3[]}
-   * @demo {@link https://sandcastle.cesium.com/index.html?src=Image-Based Lighting.html|Sandcastle Image Based Lighting Demo}
+   * @demo {@link https://sandcastle.cesium.com/index.html?id=image-based-lighting|Sandcastle Image Based Lighting Demo}
    * @see {@link https://graphics.stanford.edu/papers/envmap/envmap.pdf|An Efficient Representation for Irradiance Environment Maps}
    */
   sphericalHarmonicCoefficients: {
@@ -187,7 +187,7 @@ Object.defineProperties(ImageBasedLighting.prototype, {
    * A URL to a KTX2 file that contains a cube map of the specular lighting and the convoluted specular mipmaps.
    *
    * @memberof ImageBasedLighting.prototype
-   * @demo {@link https://sandcastle.cesium.com/index.html?src=Image-Based Lighting.html|Sandcastle Image Based Lighting Demo}
+   * @demo {@link https://sandcastle.cesium.com/index.html?id=image-based-lighting|Sandcastle Image Based Lighting Demo}
    * @type {string}
    * @see ImageBasedLighting#sphericalHarmonicCoefficients
    */

package/Source/Scene/ImageryLayerCollection.js

@@ -13,8 +13,8 @@ import ImageryLayer from "./ImageryLayer.js";
  * @constructor
  * @see {@link Scene#imageryLayers} for manipulating imagery layers on the globe.
  * @see {@link Cesium3DTileset#imageryLayers} for manipulating imagery layers on a 3D tileset.
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Imagery%20Adjustment.html|Cesium Sandcastle Imagery Adjustment Demo}
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Imagery%20Layers%20Manipulation.html|Cesium Sandcastle Imagery Manipulation Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=imagery-adjustment|Cesium Sandcastle Imagery Adjustment Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=imagery-layers-manipulation|Cesium Sandcastle Imagery Manipulation Demo}
  */
 function ImageryLayerCollection() {
   this._layers = [];

package/Source/Scene/ImageryProvider.js

@@ -39,8 +39,8 @@ import Resource from "../Core/Resource.js";
  * @see WebMapServiceImageryProvider
  * @see WebMapTileServiceImageryProvider
  *
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Imagery%20Layers.html|Cesium Sandcastle Imagery Layers Demo}
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Imagery%20Layers%20Manipulation.html|Cesium Sandcastle Imagery Manipulation Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=imagery-layers|Cesium Sandcastle Imagery Layers Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=imagery-layers-manipulation|Cesium Sandcastle Imagery Manipulation Demo}
  */
 function ImageryProvider() {
   DeveloperError.throwInstantiationError();

package/Source/Scene/Label.js

@@ -134,7 +134,7 @@ function parseFont(label) {
  * @see LabelCollection
  * @see LabelCollection#add
  *
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Labels.html|Cesium Sandcastle Labels Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=labels|Cesium Sandcastle Labels Demo}
  */
 function Label(options, labelCollection) {
   options = options ?? Frozen.EMPTY_OBJECT;

package/Source/Scene/LabelCollection.js

@@ -604,7 +604,7 @@ function destroyLabel(labelCollection, label) {
  * @see Label
  * @see BillboardCollection
  *
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Labels.html|Cesium Sandcastle Labels Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=labels|Cesium Sandcastle Labels Demo}
  *
  * @example
  * // Create a label collection with two labels

package/Source/Scene/Material.js

@@ -250,7 +250,7 @@ import WaterMaterial from "../Shaders/Materials/Water.js";
  * @exception {DeveloperError} strict: shader source does not use material.
  *
  * @see {@link https://github.com/CesiumGS/cesium/wiki/Fabric|Fabric wiki page} for a more detailed options of Fabric.
- * @demo {@link https://sandcastle.cesium.com/index.html?src=Materials.html|Cesium Sandcastle Materials Demo}
+ * @demo {@link https://sandcastle.cesium.com/index.html?id=materials|Cesium Sandcastle Materials Demo}
  *
  * @example
  * // Create a color material with fromType:

package/Source/Scene/MaterialAppearance.js

@@ -29,7 +29,7 @@ import Material from "./Material.js";
      * @param {object} [options.renderState] Optional render state to override the default render state.
      *
      * @see {@link https://github.com/CesiumGS/cesium/wiki/Fabric|Fabric}
-     * @demo {@link https://sandcastle.cesium.com/index.html?src=Materials.html|Cesium Sandcastle Material Appearance Demo}
+     * @demo {@link https://sandcastle.cesium.com/index.html?id=materials|Cesium Sandcastle Material Appearance Demo}
      *
      * @example
      * const primitive = new Cesium.Primitive({