@cat-factory/app 0.227.0 → 0.228.0

package/README.md

@@ -181,6 +181,15 @@ hoc where it can be avoided:
   control, editable, as soon as any value it edits is set (`false` included: a tri-state
   `false` is a choice, not absence), so basic mode can never conceal a setting a run will
   actually use.
+- **The tier may also change which of two routes to the same thing LEADS**, and that is not a
+  hidden capability: a `pr_ready` task card offers the outcome summary in both tiers and drops
+  the raw pull-request chip in basic, because the card the button opens carries that same link
+  at the top. What basic mode may never do is remove the only route (the rule above); ordering
+  two routes by which one a tier's reader wants first is what the tier is for. **Write the
+  condition as that INVARIANT, not as `isAdvanced` alone** (`TaskCard`'s `showPrChip`: keep the
+  chip wherever the outcome card is not offered), because the surface that carries the hidden
+  half is itself conditional, and two predicates that must agree by coincidence eventually do
+  not: the day the leading route hides, `isAdvanced` alone takes the last route with it.
 
 ## Agent tiers (basic / intermediate / advanced)
 
@@ -700,6 +709,22 @@ example ships in [`deploy/frontend`](../../deploy/frontend) (the `acme:security`
   additionally leads with `TaskReviewTarget`, linking the pull request it reviews:
   distinct from the execution panel's link to the PR a run PRODUCED, which a review
   task never has.
+- **Outcome summary** (`components/outcome`): the run-keyed result window, and what
+  the board card and the inspector open to "read the result". It renders the reduction
+  in `utils/runOutcome.ts` (requirement coverage joined to the service spec, the
+  tester's verdict, the captured views, the recorded checks) and keeps the pull request
+  at the top, so the diff stays one click away rather than being the starting point.
+  The only result window keyed by a RUN rather than a step: it opens with
+  `stepIndex: null` and composes from the whole instance, which is also why it passes
+  no `stepRef` to the shell (there is no step to restart from). Available in both
+  interface tiers; what `basic` changes is which affordance leads (see
+  [interface modes](#interface-modes-basic--advanced)).
+  Two rules bind anything added to it. Every entry point gates on `hasOutcomeToShow`
+  from the same reduction, so the card is never offered onto sections that all read
+  "nothing here". And the window is BLOCK-keyed with the run riding along: a block
+  naming a run the store never hydrated is a distinct fact from a task that never ran
+  (`RunUnavailableGap`), so a new section reports that case rather than composing from
+  the empty step list, which would read as a pipeline that produced nothing.
 - **Pipeline builder** (`components/pipeline`): assemble/edit agent chains and
   watch `PipelineProgress`. `PipelinePicker` (+ its `PipelinePreview` pane) is the
   single way a pipeline is chosen anywhere (add-task, run settings, the recurring

package/app/components/board/nodes/TaskCard.vue

@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import type { Block } from '~/types/domain'
 import { STATUS_META, MODULE_META, taskTypeMeta } from '~/utils/catalog'
+import { composeRunOutcome, hasOutcomeToShow } from '~/utils/runOutcome'
 import AgentFailureCard from '~/components/board/AgentFailureCard.vue'
 import TaskPipelineMini from './TaskPipelineMini.vue'
 
@@ -72,6 +73,40 @@ const prLabel = computed(() =>
   pr.value?.number ? t('board.task.prNumber', { number: pr.value.number }) : t('board.task.pr'),
 )
 
+/**
+ * Reading the result starts at the OUTCOME summary (what changed in product terms, with the
+ * captured evidence), and the pull request is one click inside it. In BASIC mode that replaces
+ * the card's raw PR chip: the diff is still exactly as reachable, through a surface that says
+ * what the diff is about first. Advanced mode keeps both, since a reader who wants the diff
+ * directly is the reader that tier is for.
+ *
+ * Offered only where there is something to read, asked of the SAME reduction the window renders
+ * and the inspector's button gates on: a card that offered "read the result" on a task whose
+ * every section says "nothing here" would teach people the surface is empty. A task marked done
+ * by hand, with no pull request and no run, is that task.
+ */
+const uiMode = useUiModeStore()
+const outcomeReadable = computed(() => {
+  const block = task.value
+  if (!block) return false
+  return hasOutcomeToShow(
+    composeRunOutcome({ block, instance: execution.getInstance(block.executionId) ?? null }),
+  )
+})
+/**
+ * The card's raw pull-request chip, which basic mode drops in favour of the outcome card
+ * carrying the same link at the top. Written as the INVARIANT ("the diff never stops being
+ * reachable from this card") rather than as `isAdvanced` alone, so the tier can only ever
+ * reorder two routes and never remove the last one: where the outcome card is not offered,
+ * the chip stays in both tiers.
+ */
+const showPrChip = computed(
+  () => Boolean(pr.value) && (uiMode.isAdvanced || !outcomeReadable.value),
+)
+function openOutcome() {
+  ui.openOutcome(props.taskId, task.value?.executionId ?? null)
+}
+
 // This task's current agent run (if any). A failed run must surface the shared
 // failure banner + retry — NOT a stuck progress bar — so the card never looks
 // like it's still working after the run has terminated.
@@ -402,8 +437,20 @@ function selectTask() {
 
       <template v-if="task.status === 'pr_ready'">
         <UButton
-          v-if="pr"
-          :to="pr.url"
+          v-if="outcomeReadable"
+          color="primary"
+          variant="soft"
+          size="xs"
+          icon="i-lucide-clipboard-check"
+          :title="t('board.task.readOutcomeHint')"
+          data-testid="task-open-outcome"
+          @click.stop="openOutcome"
+        >
+          {{ t('board.task.readOutcome') }}
+        </UButton>
+        <UButton
+          v-if="showPrChip"
+          :to="pr?.url"
           target="_blank"
           rel="noopener"
           external
@@ -436,12 +483,25 @@ function selectTask() {
         </UButton>
       </template>
 
-      <span
-        v-else-if="task.status === 'done'"
-        class="inline-flex items-center gap-1 text-[9px] text-emerald-400"
-      >
-        <UIcon name="i-lucide-check-check" class="h-3 w-3" /> {{ t('board.task.implemented') }}
-      </span>
+      <!-- A merged task is the one people come back to READ, so its result stays openable
+           rather than collapsing to a tick the moment it lands. -->
+      <template v-else-if="task.status === 'done'">
+        <span class="inline-flex items-center gap-1 text-[9px] text-emerald-400">
+          <UIcon name="i-lucide-check-check" class="h-3 w-3" /> {{ t('board.task.implemented') }}
+        </span>
+        <UButton
+          v-if="outcomeReadable"
+          color="neutral"
+          variant="ghost"
+          size="xs"
+          icon="i-lucide-clipboard-check"
+          :title="t('board.task.readOutcomeHint')"
+          data-testid="task-open-outcome"
+          @click.stop="openOutcome"
+        >
+          {{ t('board.task.readOutcome') }}
+        </UButton>
+      </template>
     </div>
 
     <!-- structural metadata: assigned module -->