@btc-vision/transaction 1.8.0-beta.3 → 1.8.0-beta.4

package/build/keypair/Address.js

@@ -1,16 +1,5 @@
-var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (receiver, state, value, kind, f) {
-    if (kind === "m") throw new TypeError("Private method is not writable");
-    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a setter");
-    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
-    return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
-};
-var __classPrivateFieldGet = (this && this.__classPrivateFieldGet) || function (receiver, state, kind, f) {
-    if (kind === "a" && !f) throw new TypeError("Private accessor was defined without a getter");
-    if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot read private member from an object whose class did not declare it");
-    return kind === "m" ? f : kind === "a" ? f.call(receiver) : f ? f.value : state.get(receiver);
-};
-var _Address_p2tr, _Address_p2op, _Address_network, _Address_originalPublicKey, _Address_keyPair, _Address_uncompressed, _Address_tweakedUncompressed, _Address_p2wda, _Address_mldsaPublicKey, _Address_cachedBigInt, _Address_cachedBigIntTweaked, _Address_cachedUint64Array, _Address_originalMDLSAPublicKey, _Address_mldsaLevel, _Address_pendingLegacyKey, _Address_legacyProcessed, _Address_legacyPublicKey;
-import { decompressPublicKey, toXOnly } from '@btc-vision/bitcoin';
+import { decompressPublicKey, fromHex, toHex, toXOnly, } from '@btc-vision/bitcoin';
+import {} from '@btc-vision/ecpair';
 import { ADDRESS_BYTE_LENGTH } from '../utils/lengths.js';
 import { AddressVerificator } from './AddressVerificator.js';
 import { EcKeyPair } from './EcKeyPair.js';
@@ -19,72 +8,119 @@ import { BitcoinUtils } from '../utils/BitcoinUtils.js';
 import { TimeLockGenerator } from '../transaction/mineable/TimelockGenerator.js';
 import { P2WDADetector } from '../p2wda/P2WDADetector.js';
 import { sha256 } from '@noble/hashes/sha2.js';
+import { MLDSASecurityLevel } from '@btc-vision/bip32';
+// ML-DSA-44 (Level 2): 1312 bytes public key
+// ML-DSA-65 (Level 3): 1952 bytes public key
+// ML-DSA-87 (Level 5): 2592 bytes public key
+const validMLDSALengths = [1312, 1952, 2592];
+/**
+ * Objects of type "Address" represent hashed ML-DSA (quantum) public keys (using SHA256 of quantum keys) and maintain classical public keys separately.
+ * This class supports a hybrid quantum-classical architecture, allowing conversion to different address formats and management of both key types.
+ *
+ * The Address internally stores the SHA256 hash of the ML-DSA public key as its primary content, while maintaining
+ * the classical public key in a separate field. This enables quantum-resistant addressing while preserving
+ * compatibility with traditional Bitcoin cryptography.
+ *
+ * @category KeyPair
+ */
 export class Address extends Uint8Array {
+    #p2tr;
+    #p2op;
+    #network;
+    #originalPublicKey;
+    #keyPair;
+    #uncompressed;
+    #tweakedUncompressed;
+    #p2wda;
+    #mldsaPublicKey;
+    #cachedBigInt;
+    #cachedBigIntTweaked;
+    #cachedUint64Array;
+    #originalMDLSAPublicKey;
+    #mldsaLevel;
+    // Lazy loading state - defers expensive EC operations until actually needed
+    #pendingLegacyKey;
+    #legacyProcessed = false;
+    // After processing, this is 32-byte tweaked x-only (same as original behavior)
+    #tweakedPublicKey;
     constructor(mldsaPublicKey, publicKeyOrTweak) {
         super(ADDRESS_BYTE_LENGTH);
-        _Address_p2tr.set(this, void 0);
-        _Address_p2op.set(this, void 0);
-        _Address_network.set(this, void 0);
-        _Address_originalPublicKey.set(this, void 0);
-        _Address_keyPair.set(this, void 0);
-        _Address_uncompressed.set(this, void 0);
-        _Address_tweakedUncompressed.set(this, void 0);
-        _Address_p2wda.set(this, void 0);
-        _Address_mldsaPublicKey.set(this, void 0);
-        _Address_cachedBigInt.set(this, void 0);
-        _Address_cachedBigIntTweaked.set(this, void 0);
-        _Address_cachedUint64Array.set(this, void 0);
-        _Address_originalMDLSAPublicKey.set(this, void 0);
-        _Address_mldsaLevel.set(this, void 0);
-        _Address_pendingLegacyKey.set(this, void 0);
-        _Address_legacyProcessed.set(this, false);
-        _Address_legacyPublicKey.set(this, void 0);
         if (!mldsaPublicKey) {
             return;
         }
         if (publicKeyOrTweak) {
+            // Validate length immediately (cheap check), defer EC operations
             const validLengths = [ADDRESS_BYTE_LENGTH, 33, 65];
             if (!validLengths.includes(publicKeyOrTweak.length)) {
                 throw new Error(`Invalid public key length ${publicKeyOrTweak.length}`);
             }
-            __classPrivateFieldSet(this, _Address_pendingLegacyKey, new Uint8Array(publicKeyOrTweak.length), "f");
-            __classPrivateFieldGet(this, _Address_pendingLegacyKey, "f").set(publicKeyOrTweak);
+            // Store but don't process yet - defer EC operations
+            this.#pendingLegacyKey = new Uint8Array(publicKeyOrTweak.length);
+            this.#pendingLegacyKey.set(publicKeyOrTweak);
         }
         this.setMldsaKey(mldsaPublicKey);
     }
+    /**
+     * Prevent TypedArray methods (subarray, slice, etc.) from creating Address
+     * instances. Without this, @noble/hashes and other libraries that call
+     * subarray() on an Address would invoke the Address constructor that recomputes
+     * everything leading to bad performance.
+     */
+    static get [Symbol.species]() {
+        return Uint8Array;
+    }
     get mldsaLevel() {
-        return __classPrivateFieldGet(this, _Address_mldsaLevel, "f");
+        return this.#mldsaLevel;
     }
     set mldsaLevel(level) {
-        __classPrivateFieldSet(this, _Address_mldsaLevel, level, "f");
+        this.#mldsaLevel = level;
     }
     get originalMDLSAPublicKey() {
-        return __classPrivateFieldGet(this, _Address_originalMDLSAPublicKey, "f");
+        return this.#originalMDLSAPublicKey;
     }
     set originalMDLSAPublicKey(key) {
-        __classPrivateFieldSet(this, _Address_originalMDLSAPublicKey, new Uint8Array(key), "f");
+        this.#originalMDLSAPublicKey = key ? new Uint8Array(key) : undefined;
     }
+    /**
+     * If available, this will return the original public key associated with the address.
+     * @returns {Uint8Array} The original public key used to create the address.
+     */
     get originalPublicKey() {
         this.ensureLegacyProcessed();
-        return __classPrivateFieldGet(this, _Address_originalPublicKey, "f");
+        return this.#originalPublicKey;
     }
     get mldsaPublicKey() {
-        return __classPrivateFieldGet(this, _Address_mldsaPublicKey, "f");
+        return this.#mldsaPublicKey;
     }
+    /**
+     * Get the legacy public key (32-byte tweaked x-only after processing).
+     * Triggers lazy processing if not yet done.
+     */
     get legacyPublicKey() {
         this.ensureLegacyProcessed();
-        return __classPrivateFieldGet(this, _Address_legacyPublicKey, "f");
+        return this.#tweakedPublicKey;
     }
+    /**
+     * Get the key pair for the address
+     * @description This is only for internal use. Please use address.tweakedBytes instead.
+     */
     get keyPair() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_keyPair, "f")) {
+        if (!this.#keyPair) {
             throw new Error('Legacy public key not set for address');
         }
-        return __classPrivateFieldGet(this, _Address_keyPair, "f");
+        return this.#keyPair;
     }
     static dead() {
-        return Address.fromString('0x0000000000000000000000000000000000000000000000000000000000000000', '0x04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f');
-    }
+        return Address.fromString('0x0000000000000000000000000000000000000000000000000000000000000000', // DEAD ADDRESS
+        '0x04678afdb0fe5548271967f1a67130b7105cd6a828e03909a67962e0ea1f61deb649f6bc3f4cef38c4f35504e51ec112de5c384df7ba0b8d578a4c702b6bf11d5f');
+    }
+    /**
+     * Create an address from a hex string
+     * @param {string} mldsaPublicKey The ml-dsa public key in hex format
+     * @param {string} legacyPublicKey The classical public key in hex format
+     * @returns {Address} The address
+     */
     static fromString(mldsaPublicKey, legacyPublicKey) {
         if (!mldsaPublicKey) {
             throw new Error('Invalid public key');
@@ -103,10 +139,15 @@ export class Address extends Uint8Array {
             if (!BitcoinUtils.isValidHex(legacyPublicKey)) {
                 throw new Error('You must only pass classical public keys in hexadecimal format. If you have an address such as bc1q... you must convert it to a public key first. Please refer to await provider.getPublicKeyInfo("bc1q..."). If the public key associated with the address is not found, you must force the user to enter the destination public key. It looks like: 0x020373626d317ae8788ce3280b491068610d840c23ecb64c14075bbb9f670af52c.');
             }
-            classicBuffer = Buffer.from(legacyPublicKey, 'hex');
+            classicBuffer = fromHex(legacyPublicKey);
         }
-        return new Address(Buffer.from(mldsaPublicKey, 'hex'), classicBuffer);
+        return new Address(fromHex(mldsaPublicKey), classicBuffer);
     }
+    /**
+     * Create an address from a public key
+     * @returns {Address} The address
+     * @param {ArrayLike<number>} bytes The public key
+     */
     static wrap(bytes) {
         return new Address(bytes);
     }
@@ -114,16 +155,85 @@ export class Address extends Uint8Array {
         const buffer = Uint8Array.from(publicKey);
         const x = buffer.slice(1, 33);
         const y = buffer.slice(33);
-        const compressed = Buffer.alloc(33);
+        const compressed = new Uint8Array(33);
         compressed[0] = 0x02 + (y[y.length - 1] & 0x01);
         compressed.set(x, 1);
         return compressed;
     }
+    [Symbol.dispose]() {
+        // Zero the base Uint8Array (hashed ML-DSA public key)
+        this.fill(0);
+        // Clear all cached / derived state
+        this.#p2tr = undefined;
+        this.#p2op = undefined;
+        this.#network = undefined;
+        this.#originalPublicKey = undefined;
+        this.#keyPair = undefined;
+        this.#uncompressed = undefined;
+        this.#tweakedUncompressed = undefined;
+        this.#p2wda = undefined;
+        this.#mldsaPublicKey?.fill(0);
+        this.#mldsaPublicKey = undefined;
+        this.#cachedBigInt = undefined;
+        this.#cachedBigIntTweaked = undefined;
+        this.#cachedUint64Array = undefined;
+        this.#originalMDLSAPublicKey?.fill(0);
+        this.#originalMDLSAPublicKey = undefined;
+        this.#mldsaLevel = undefined;
+        this.#legacyProcessed = false;
+        this.#tweakedPublicKey = undefined;
+    }
+    /**
+     * Creates an Address instance from a BigInt value.
+     *
+     * Converts a 256-bit unsigned integer into a 32-byte address by splitting it
+     * into four 64-bit chunks and writing them in big-endian format using DataView.
+     * This is the inverse operation of toBigInt().
+     *
+     * @param {bigint} value - The 256-bit unsigned integer to convert (0 to 2^256-1)
+     * @param {bigint} [tweakedValue] - Optional tweaked public key as a 256-bit unsigned integer
+     * @returns {Address} A new Address instance containing the converted value
+     *
+     * @throws {RangeError} If the value is negative or exceeds 2^256-1
+     *
+     * @example
+     * ```typescript
+     * const bigIntValue = 12345678901234567890n;
+     * const address = Address.fromBigInt(bigIntValue);
+     * console.log(address.toHex()); // 0x0000000000000000000000000000000000000000000000000000abc123...
+     * ```
+     */
     static fromBigInt(value, tweakedValue) {
         const address = Address.bigintToUint8Array(value);
         const legacyAddress = tweakedValue !== undefined ? Address.bigintToUint8Array(tweakedValue) : undefined;
         return new Address(address, legacyAddress);
     }
+    /**
+     * Creates an Address instance from four 64-bit unsigned integers.
+     *
+     * Constructs a 32-byte address by combining four 64-bit big-endian unsigned integers.
+     * This is the inverse operation of toUint64Array() and provides an efficient way
+     * to create addresses from word-aligned data.
+     *
+     * @param {bigint} w0 - Most significant 64 bits (bytes 0-7)
+     * @param {bigint} w1 - Second 64 bits (bytes 8-15)
+     * @param {bigint} w2 - Third 64 bits (bytes 16-23)
+     * @param {bigint} w3 - Least significant 64 bits (bytes 24-31)
+     * @returns {Address} A new Address instance containing the combined value
+     *
+     * @throws {RangeError} If any value exceeds 64 bits (2^64-1)
+     *
+     * @example
+     * ```typescript
+     * const address = Address.fromUint64Array(
+     *     0x0123456789abcdefn,
+     *     0xfedcba9876543210n,
+     *     0x1111222233334444n,
+     *     0x5555666677778888n
+     * );
+     * console.log(address.toHex());
+     * ```
+     */
     static fromUint64Array(w0, w1, w2, w3) {
         const buffer = new Uint8Array(32);
         const view = new DataView(buffer.buffer);
@@ -142,19 +252,41 @@ export class Address extends Uint8Array {
         view.setBigUint64(24, value & 0xffffffffffffffffn, false);
         return buffer;
     }
+    /**
+     * Converts the address to four 64-bit unsigned integers.
+     *
+     * Splits the 32-byte (256-bit) address into four 64-bit big-endian unsigned integers.
+     * This representation is useful for efficient storage, comparison operations, or
+     * interfacing with systems that work with 64-bit word sizes.
+     *
+     * @returns {[bigint, bigint, bigint, bigint]} An array of four 64-bit unsigned integers
+     *          representing the address from most significant to least significant bits
+     *
+     * @example
+     * ```typescript
+     * const address = Address.fromString('0x0123456789abcdef...');
+     * const [w0, w1, w2, w3] = address.toUint64Array();
+     * console.log(w0); // Most significant 64 bits
+     * console.log(w3); // Least significant 64 bits
+     * ```
+     */
     toUint64Array() {
-        if (__classPrivateFieldGet(this, _Address_cachedUint64Array, "f") !== undefined) {
-            return __classPrivateFieldGet(this, _Address_cachedUint64Array, "f");
+        if (this.#cachedUint64Array !== undefined) {
+            return this.#cachedUint64Array;
         }
         const view = new DataView(this.buffer, this.byteOffset, 32);
-        __classPrivateFieldSet(this, _Address_cachedUint64Array, [
+        this.#cachedUint64Array = [
             view.getBigUint64(0, false),
             view.getBigUint64(8, false),
             view.getBigUint64(16, false),
             view.getBigUint64(24, false),
-        ], "f");
-        return __classPrivateFieldGet(this, _Address_cachedUint64Array, "f");
+        ];
+        return this.#cachedUint64Array;
     }
+    /**
+     * Check if the address is the dead address
+     * @returns {boolean}
+     */
     isDead() {
         for (let i = 0; i < ADDRESS_BYTE_LENGTH; i++) {
             if (this[i] !== 0) {
@@ -163,85 +295,135 @@ export class Address extends Uint8Array {
         }
         return true;
     }
+    /**
+     * Converts the address to a hex string
+     * @returns {string} The hex string
+     */
     toHex() {
-        return '0x' + Buffer.from(this).toString('hex');
+        return '0x' + toHex(this);
     }
+    /**
+     * Converts the classical public key to a hex string
+     * @returns {string} The hex string
+     */
     tweakedToHex() {
         const key = this.legacyPublicKey;
         if (!key) {
             throw new Error('Legacy public key not set');
         }
-        return '0x' + Buffer.from(key).toString('hex');
+        return '0x' + toHex(key);
     }
+    /**
+     * Converts the address content (SHA256 hash of ML-DSA public key) to a Uint8Array
+     * @returns {Uint8Array} The Uint8Array containing the hashed ML-DSA public key
+     */
     toBuffer() {
-        return Buffer.from(this);
+        return new Uint8Array(this);
     }
+    /**
+     * Converts the classical public key to a Uint8Array
+     * @returns {Uint8Array} The Uint8Array
+     */
     tweakedPublicKeyToBuffer() {
         const key = this.legacyPublicKey;
         if (!key) {
             throw new Error('Legacy public key not set');
         }
-        return Buffer.from(key);
+        return new Uint8Array(key);
     }
     toUncompressedHex() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_uncompressed, "f")) {
+        if (!this.#uncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return '0x' + __classPrivateFieldGet(this, _Address_uncompressed, "f").uncompressed.toString('hex');
+        return '0x' + toHex(this.#uncompressed.uncompressed);
     }
     toUncompressedBuffer() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_uncompressed, "f")) {
+        if (!this.#uncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return __classPrivateFieldGet(this, _Address_uncompressed, "f").uncompressed;
+        return this.#uncompressed.uncompressed;
     }
     toHybridPublicKeyHex() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_uncompressed, "f")) {
+        if (!this.#uncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return '0x' + __classPrivateFieldGet(this, _Address_uncompressed, "f").hybrid.toString('hex');
+        return '0x' + toHex(this.#uncompressed.hybrid);
     }
     toHybridPublicKeyBuffer() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_uncompressed, "f")) {
+        if (!this.#uncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return __classPrivateFieldGet(this, _Address_uncompressed, "f").hybrid;
+        return this.#uncompressed.hybrid;
     }
     originalPublicKeyBuffer() {
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_originalPublicKey, "f")) {
+        if (!this.#originalPublicKey) {
             throw new Error('Legacy public key not set');
         }
-        return Buffer.from(__classPrivateFieldGet(this, _Address_originalPublicKey, "f"));
-    }
+        return new Uint8Array(this.#originalPublicKey);
+    }
+    /**
+     * Converts the address to a BigInt representation.
+     *
+     * This method uses an optimized DataView approach to read the 32-byte address
+     * as four 64-bit big-endian unsigned integers, then combines them using bitwise
+     * operations. This is approximately 10-20x faster than string-based conversion.
+     *
+     * @returns {bigint} The address as a 256-bit unsigned integer
+     *
+     * @example
+     * ```typescript
+     * const address = Address.fromString('0x0123456789abcdef...');
+     * const bigIntValue = address.toBigInt();
+     * console.log(bigIntValue); // 123456789...n
+     * ```
+     */
     toBigInt() {
-        if (__classPrivateFieldGet(this, _Address_cachedBigInt, "f") !== undefined) {
-            return __classPrivateFieldGet(this, _Address_cachedBigInt, "f");
+        if (this.#cachedBigInt !== undefined) {
+            return this.#cachedBigInt;
         }
         const view = new DataView(this.buffer, this.byteOffset, 32);
-        __classPrivateFieldSet(this, _Address_cachedBigInt, (view.getBigUint64(0, false) << 192n) |
-            (view.getBigUint64(8, false) << 128n) |
-            (view.getBigUint64(16, false) << 64n) |
-            view.getBigUint64(24, false), "f");
-        return __classPrivateFieldGet(this, _Address_cachedBigInt, "f");
-    }
+        this.#cachedBigInt =
+            (view.getBigUint64(0, false) << 192n) |
+                (view.getBigUint64(8, false) << 128n) |
+                (view.getBigUint64(16, false) << 64n) |
+                view.getBigUint64(24, false);
+        return this.#cachedBigInt;
+    }
+    /**
+     * Converts the tweaked public key to a BigInt representation.
+     *
+     * This method uses an optimized DataView approach to read the 32-byte address
+     * as four 64-bit big-endian unsigned integers, then combines them using bitwise
+     * operations. This is approximately 10-20x faster than string-based conversion.
+     *
+     * @returns {bigint} The address as a 256-bit unsigned integer
+     *
+     * @example
+     * ```typescript
+     * const address = Address.fromString('0x0123456789abcdef...', '0xtweaked...');
+     * const bigIntValue = address.tweakedToBigInt();
+     * console.log(bigIntValue); // 123456789...n
+     * ```
+     */
     tweakedToBigInt() {
         if (!this.legacyPublicKey) {
             throw new Error('Legacy public key not set');
         }
-        if (__classPrivateFieldGet(this, _Address_cachedBigIntTweaked, "f") !== undefined) {
-            return __classPrivateFieldGet(this, _Address_cachedBigIntTweaked, "f");
+        if (this.#cachedBigIntTweaked !== undefined) {
+            return this.#cachedBigIntTweaked;
         }
         const view = new DataView(this.legacyPublicKey.buffer, this.byteOffset, 32);
-        __classPrivateFieldSet(this, _Address_cachedBigIntTweaked, (view.getBigUint64(0, false) << 192n) |
-            (view.getBigUint64(8, false) << 128n) |
-            (view.getBigUint64(16, false) << 64n) |
-            view.getBigUint64(24, false), "f");
-        return __classPrivateFieldGet(this, _Address_cachedBigIntTweaked, "f");
+        this.#cachedBigIntTweaked =
+            (view.getBigUint64(0, false) << 192n) |
+                (view.getBigUint64(8, false) << 128n) |
+                (view.getBigUint64(16, false) << 64n) |
+                view.getBigUint64(24, false);
+        return this.#cachedBigIntTweaked;
     }
     equals(a) {
         const b = this;
@@ -255,65 +437,110 @@ export class Address extends Uint8Array {
         }
         return true;
     }
+    /**
+     * Check if the address is bigger than another address
+     * @returns {boolean} If bigger
+     */
     lessThan(a) {
         const b = this;
         for (let i = 0; i < ADDRESS_BYTE_LENGTH; i++) {
             const thisByte = b[i];
             const aByte = a[i];
             if (thisByte < aByte) {
-                return true;
+                return true; // this is less than a
             }
             else if (thisByte > aByte) {
-                return false;
+                return false; // this is greater than or equal to a
             }
         }
         return false;
     }
+    /**
+     * Check if the address is smaller than another address
+     * @returns {boolean} If smaller
+     */
     greaterThan(a) {
+        // Compare the two addresses byte-by-byte, treating them as big-endian uint256
         const b = this;
         for (let i = 0; i < ADDRESS_BYTE_LENGTH; i++) {
             const thisByte = b[i];
             const aByte = a[i];
             if (thisByte > aByte) {
-                return true;
+                return true; // this is greater than a
             }
             else if (thisByte < aByte) {
-                return false;
+                return false; // this is less than or equal to a
             }
         }
         return false;
     }
+    /**
+     * Set the public key
+     * @param {ArrayLike<number>} mldsaPublicKey ML-DSA public key
+     * @returns {void}
+     */
     set(mldsaPublicKey) {
+        // Legacy key processing is now deferred via ensureLegacyProcessed()
         this.setMldsaKey(mldsaPublicKey);
     }
+    /**
+     * Check if the public key is valid
+     * @param {Network} network The network
+     * @returns {boolean} If the public key is valid
+     */
     isValidLegacyPublicKey(network) {
         const key = this.legacyPublicKey;
         if (!key) {
             throw new Error(`Legacy key not set.`);
         }
-        return AddressVerificator.isValidPublicKey(Buffer.from(key).toString('hex'), network);
+        return AddressVerificator.isValidPublicKey(toHex(key), network);
     }
+    /**
+     * Get the public key as address
+     */
     p2pk() {
         return this.toHex();
     }
+    /**
+     * Get the address in p2wpkh format
+     * @param {Network} network The network
+     */
     p2wpkh(network) {
         return EcKeyPair.getP2WPKHAddress(this.keyPair, network);
     }
+    /**
+     * Get the address in p2pkh format
+     * @param {Network} network The network
+     */
     p2pkh(network) {
         return EcKeyPair.getLegacyAddress(this.keyPair, network);
     }
+    /**
+     * Get the address in p2sh-p2wpkh format
+     * @param {Network} network The network
+     */
     p2shp2wpkh(network) {
         return EcKeyPair.getLegacySegwitAddress(this.keyPair, network);
     }
+    /**
+     * Convert the address to a string
+     */
     toString() {
         return this.toHex();
     }
+    /**
+     * Convert the address to a JSON string
+     */
     toJSON() {
         return this.toHex();
     }
+    /**
+     * Get the address in p2tr format
+     * @param {Network} network The network
+     */
     p2tr(network) {
-        if (__classPrivateFieldGet(this, _Address_p2tr, "f") && __classPrivateFieldGet(this, _Address_network, "f") === network) {
-            return __classPrivateFieldGet(this, _Address_p2tr, "f");
+        if (this.#p2tr && this.#network === network) {
+            return this.#p2tr;
         }
         const key = this.legacyPublicKey;
         if (!key) {
@@ -321,28 +548,50 @@ export class Address extends Uint8Array {
         }
         const p2trAddy = EcKeyPair.tweakedPubKeyBufferToAddress(key, network);
         if (p2trAddy) {
-            __classPrivateFieldSet(this, _Address_network, network, "f");
-            __classPrivateFieldSet(this, _Address_p2tr, p2trAddy, "f");
+            this.#network = network;
+            this.#p2tr = p2trAddy;
             return p2trAddy;
         }
         throw new Error('Legacy public key not set');
     }
+    /**
+     * Generate a P2WDA (Pay-to-Witness-Data-Authentication) address
+     *
+     * P2WDA addresses are a special type of P2WSH address that allows embedding
+     * authenticated data directly in the witness field, achieving 75% cost reduction
+     * through Bitcoin's witness discount.
+     *
+     * The witness script pattern is: (OP_2DROP * 5) <pubkey> OP_CHECKSIG
+     * This allows up to 10 witness data fields (5 * 2 = 10), where each field
+     * can hold up to 80 bytes of data due to relay rules.
+     *
+     * @param {Network} network - The Bitcoin network to use
+     * @returns {IP2WSHAddress} The P2WDA address
+     * @throws {Error} If the public key is not set or address generation fails
+     *
+     * @example
+     * ```typescript
+     * const address = Address.fromString('0x02...');
+     * const p2wdaAddress = address.p2wda(networks.bitcoin);
+     * console.log(p2wdaAddress); // bc1q...
+     * ```
+     */
     p2wda(network) {
-        if (__classPrivateFieldGet(this, _Address_p2wda, "f") && __classPrivateFieldGet(this, _Address_network, "f") === network) {
-            return __classPrivateFieldGet(this, _Address_p2wda, "f");
+        if (this.#p2wda && this.#network === network) {
+            return this.#p2wda;
         }
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_originalPublicKey, "f")) {
+        if (!this.#originalPublicKey) {
             throw new Error('Cannot create P2WDA address: public key not set');
         }
-        const publicKeyBuffer = Buffer.from(__classPrivateFieldGet(this, _Address_originalPublicKey, "f"));
+        const publicKeyBuffer = new Uint8Array(this.#originalPublicKey);
         if (publicKeyBuffer.length !== 33) {
             throw new Error('P2WDA requires a compressed public key (33 bytes)');
         }
         try {
             const p2wdaInfo = P2WDADetector.generateP2WDAAddress(publicKeyBuffer, network);
-            __classPrivateFieldSet(this, _Address_network, network, "f");
-            __classPrivateFieldSet(this, _Address_p2wda, p2wdaInfo, "f");
+            this.#network = network;
+            this.#p2wda = p2wdaInfo;
             return {
                 address: p2wdaInfo.address,
                 witnessScript: p2wdaInfo.witnessScript,
@@ -352,37 +601,82 @@ export class Address extends Uint8Array {
             throw new Error(`Failed to generate P2WDA address: ${error.message}`);
         }
     }
+    /**
+     * Generate a P2WSH address with CSV (CheckSequenceVerify) time lock
+     * The resulting address can only be spent after the specified number of blocks
+     * have passed since the UTXO was created.
+     *
+     * @param {bigint | number | string} duration - The number of blocks that must pass before spending (1-65535)
+     * @param {Network} network - The Bitcoin network to use
+     * @returns {IP2WSHAddress} The timelocked address and its witness script
+     * @throws {Error} If the block number is out of range or public key is not available
+     */
     toCSV(duration, network) {
         const n = Number(duration);
+        // First, let's validate the block number to ensure it's within the valid range
+        // CSV uses sequence numbers, which have special encoding for block-based locks
         if (n < 1 || n > 65535) {
             throw new Error('CSV block number must be between 1 and 65535');
         }
+        // We need the original public key in compressed format for the script
+        // Your class stores this in #originalPublicKey when a key is set
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_originalPublicKey, "f")) {
+        if (!this.#originalPublicKey) {
             throw new Error('Cannot create CSV address: public key not set');
         }
-        const publicKeyBuffer = Buffer.from(__classPrivateFieldGet(this, _Address_originalPublicKey, "f"));
+        // Convert the public key to Uint8Array format that TimeLockGenerator expects
+        const publicKeyBuffer = new Uint8Array(this.#originalPublicKey);
+        // Now we can use your TimeLockGenerator to create the timelocked address
+        // Converting bigint to number is safe here because we've already validated the range
         return TimeLockGenerator.generateTimeLockAddress(publicKeyBuffer, network, n);
     }
+    /**
+     * Generate a P2TR address with CSV (CheckSequenceVerify) time lock
+     * The resulting address can only be spent after the specified number of blocks
+     * have passed since the UTXO was created.
+     *
+     * @param {bigint | number | string} duration - The number of blocks that must pass before spending (1-65535)
+     * @param {Network} network - The Bitcoin network to use
+     * @returns {IP2WSHAddress} The timelocked address and its witness script
+     * @throws {Error} If the block number is out of range or public key is not available
+     */
     toCSVTweaked(duration, network) {
         const n = Number(duration);
+        // First, let's validate the block number to ensure it's within the valid range
+        // CSV uses sequence numbers, which have special encoding for block-based locks
         if (n < 1 || n > 65535) {
             throw new Error('CSV block number must be between 1 and 65535');
         }
+        // We need the original public key in compressed format for the script
+        // Your class stores this in #originalPublicKey when a key is set
         this.ensureLegacyProcessed();
-        if (!__classPrivateFieldGet(this, _Address_originalPublicKey, "f")) {
+        if (!this.#originalPublicKey) {
             throw new Error('Cannot create CSV address: public key not set');
         }
+        // Now we can use your TimeLockGenerator to create the timelocked address
+        // Converting bigint to number is safe here because we've already validated the range
         return TimeLockGenerator.generateTimeLockAddressP2TR(this.tweakedPublicKeyToBuffer(), network, n);
     }
+    /**
+     * Returns the OPNet address encoded in bech32m format, derived from the SHA256 hash of the ML-DSA public key
+     * (which is what the Address internally stores).
+     *
+     * This method generates a P2OP (Pay-to-OPNet) address using witness version 16, suitable for
+     * quantum-resistant transactions on the OPNet protocol.
+     *
+     * @param network - The Bitcoin network to use (mainnet, testnet, regtest)
+     * @returns The P2OP address in bech32m format
+     */
     p2op(network) {
-        if (__classPrivateFieldGet(this, _Address_p2op, "f") && __classPrivateFieldGet(this, _Address_network, "f") === network) {
-            return __classPrivateFieldGet(this, _Address_p2op, "f");
+        if (this.#p2op && this.#network === network) {
+            return this.#p2op;
         }
+        // p2op only uses the MLDSA hash (this Uint8Array), no legacy key processing needed.
+        // This is the HOT PATH for parsing - stays fast without triggering EC operations.
         const p2opAddy = EcKeyPair.p2op(this, network);
         if (p2opAddy) {
-            __classPrivateFieldSet(this, _Address_network, network, "f");
-            __classPrivateFieldSet(this, _Address_p2op, p2opAddy, "f");
+            this.#network = network;
+            this.#p2op = p2opAddy;
             return p2opAddy;
         }
         throw new Error('ML-DSA public key not set');
@@ -390,83 +684,107 @@ export class Address extends Uint8Array {
     toTweakedHybridPublicKeyHex() {
         this.ensureLegacyProcessed();
         this.ensureTweakedUncompressed();
-        if (!__classPrivateFieldGet(this, _Address_tweakedUncompressed, "f")) {
+        if (!this.#tweakedUncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return '0x' + __classPrivateFieldGet(this, _Address_tweakedUncompressed, "f").toString('hex');
+        return '0x' + toHex(this.#tweakedUncompressed);
     }
     toTweakedHybridPublicKeyBuffer() {
         this.ensureLegacyProcessed();
         this.ensureTweakedUncompressed();
-        if (!__classPrivateFieldGet(this, _Address_tweakedUncompressed, "f")) {
+        if (!this.#tweakedUncompressed) {
             throw new Error('Legacy public key not set');
         }
-        return __classPrivateFieldGet(this, _Address_tweakedUncompressed, "f");
+        return this.#tweakedUncompressed;
     }
+    /**
+     * Lazily generates the tweaked uncompressed/hybrid key from the legacy public key.
+     * Only called when toTweakedHybridPublicKey* methods are accessed.
+     */
     ensureTweakedUncompressed() {
-        if (__classPrivateFieldGet(this, _Address_tweakedUncompressed, "f"))
+        if (this.#tweakedUncompressed)
             return;
-        const key = __classPrivateFieldGet(this, _Address_legacyPublicKey, "f");
+        const key = this.#tweakedPublicKey;
         if (!key)
             return;
-        if (key.length === ADDRESS_BYTE_LENGTH && !__classPrivateFieldGet(this, _Address_originalPublicKey, "f")) {
+        // Only attempt hybrid key generation for 32-byte keys that weren't processed through autoFormat
+        if (key.length === ADDRESS_BYTE_LENGTH && !this.#originalPublicKey) {
             try {
-                const buf = Buffer.alloc(ADDRESS_BYTE_LENGTH);
-                buf.set(key);
-                __classPrivateFieldSet(this, _Address_tweakedUncompressed, ContractAddress.generateHybridKeyFromHash(buf), "f");
+                this.#tweakedUncompressed = ContractAddress.generateHybridKeyFromHash(key);
             }
             catch {
+                // Hybrid key generation may fail for keys that aren't valid EC points
+                // (e.g., zero addresses). Leave #tweakedUncompressed undefined.
             }
         }
     }
+    /**
+     * Sets the MLDSA key portion of the address.
+     * @param {ArrayLike<number>} mldsaPublicKey - The MLDSA public key or its hash
+     */
     setMldsaKey(mldsaPublicKey) {
+        // THIS is the SHA256(ORIGINAL_ML_DSA_PUBLIC_KEY)
         if (mldsaPublicKey.length === ADDRESS_BYTE_LENGTH) {
             const buf = new Uint8Array(ADDRESS_BYTE_LENGTH);
             buf.set(mldsaPublicKey);
             super.set(buf);
         }
         else {
-            const validMLDSALengths = [1312, 1952, 2592];
+            // Validate ML-DSA public key lengths according to BIP360 and FIPS 204
             if (!validMLDSALengths.includes(mldsaPublicKey.length)) {
                 throw new Error(`Invalid ML-DSA public key length: ${mldsaPublicKey.length}. ` +
                     `Expected 1312 (ML-DSA-44/LEVEL2), 1952 (ML-DSA-65/LEVEL3), or 2592 (ML-DSA-87/LEVEL5) bytes.`);
             }
-            __classPrivateFieldSet(this, _Address_mldsaPublicKey, new Uint8Array(mldsaPublicKey.length), "f");
-            __classPrivateFieldGet(this, _Address_mldsaPublicKey, "f").set(mldsaPublicKey);
+            // Store the original ML-DSA public key
+            this.#mldsaPublicKey = new Uint8Array(mldsaPublicKey.length);
+            this.#mldsaPublicKey.set(mldsaPublicKey);
+            // Hash the ML-DSA public key to get the 32-byte address
             const hashedPublicKey = sha256(new Uint8Array(mldsaPublicKey));
             const buf = new Uint8Array(ADDRESS_BYTE_LENGTH);
             buf.set(hashedPublicKey);
             super.set(buf);
         }
     }
+    /**
+     * Lazy processing of legacy key - defers expensive EC operations until actually needed.
+     * Does the EXACT same logic as the original set() method did for legacy keys.
+     */
     ensureLegacyProcessed() {
-        if (__classPrivateFieldGet(this, _Address_legacyProcessed, "f"))
+        if (this.#legacyProcessed)
             return;
-        __classPrivateFieldSet(this, _Address_legacyProcessed, true, "f");
-        const pending = __classPrivateFieldGet(this, _Address_pendingLegacyKey, "f");
+        this.#legacyProcessed = true;
+        const pending = this.#pendingLegacyKey;
         if (!pending)
             return;
+        // Length validation already done in constructor
         if (pending.length === ADDRESS_BYTE_LENGTH) {
-            __classPrivateFieldSet(this, _Address_legacyPublicKey, pending, "f");
+            this.#tweakedPublicKey = pending;
         }
         else {
+            // 33 or 65 bytes: full autoFormat processing with EC operations
             this.autoFormat(pending);
         }
     }
+    /**
+     * Processes a 33 or 65 byte public key, performing EC operations.
+     * Sets #tweakedPublicKey to 32-byte tweaked x-only (same as original behavior).
+     */
     autoFormat(publicKey) {
         const firstByte = publicKey[0];
         if (firstByte === 0x03 || firstByte === 0x02) {
+            // do nothing
         }
         else if (firstByte === 0x04 || firstByte === 0x06 || firstByte === 0x07) {
+            // uncompressed
             publicKey = Address.uncompressedToCompressed(publicKey);
         }
-        __classPrivateFieldSet(this, _Address_originalPublicKey, Uint8Array.from(publicKey), "f");
-        __classPrivateFieldSet(this, _Address_keyPair, EcKeyPair.fromPublicKey(__classPrivateFieldGet(this, _Address_originalPublicKey, "f")), "f");
-        __classPrivateFieldSet(this, _Address_uncompressed, decompressPublicKey(__classPrivateFieldGet(this, _Address_originalPublicKey, "f")), "f");
-        const tweakedBytes = toXOnly(EcKeyPair.tweakPublicKey(Buffer.from(__classPrivateFieldGet(this, _Address_originalPublicKey, "f"))));
-        __classPrivateFieldSet(this, _Address_tweakedUncompressed, ContractAddress.generateHybridKeyFromHash(tweakedBytes), "f");
-        __classPrivateFieldSet(this, _Address_legacyPublicKey, new Uint8Array(ADDRESS_BYTE_LENGTH), "f");
-        __classPrivateFieldGet(this, _Address_legacyPublicKey, "f").set(tweakedBytes);
+        this.#originalPublicKey = Uint8Array.from(publicKey);
+        this.#keyPair = EcKeyPair.fromPublicKey(this.#originalPublicKey);
+        this.#uncompressed = decompressPublicKey(this.#originalPublicKey);
+        const tweakedBytes = toXOnly(EcKeyPair.tweakPublicKey(this.#originalPublicKey));
+        this.#tweakedUncompressed = ContractAddress.generateHybridKeyFromHash(tweakedBytes);
+        this.#tweakedPublicKey = new Uint8Array(ADDRESS_BYTE_LENGTH);
+        this.#tweakedPublicKey.set(tweakedBytes);
     }
 }
-_Address_p2tr = new WeakMap(), _Address_p2op = new WeakMap(), _Address_network = new WeakMap(), _Address_originalPublicKey = new WeakMap(), _Address_keyPair = new WeakMap(), _Address_uncompressed = new WeakMap(), _Address_tweakedUncompressed = new WeakMap(), _Address_p2wda = new WeakMap(), _Address_mldsaPublicKey = new WeakMap(), _Address_cachedBigInt = new WeakMap(), _Address_cachedBigIntTweaked = new WeakMap(), _Address_cachedUint64Array = new WeakMap(), _Address_originalMDLSAPublicKey = new WeakMap(), _Address_mldsaLevel = new WeakMap(), _Address_pendingLegacyKey = new WeakMap(), _Address_legacyProcessed = new WeakMap(), _Address_legacyPublicKey = new WeakMap();
+//# sourceMappingURL=Address.js.map