@browserless.io/browserless 2.18.0 → 2.19.0

package/src/browsers/index.ts

@@ -255,12 +255,16 @@ export class BrowserManager {
         },
       });
       if (response.ok) {
+        const externalUrl = new URL(serverAddress);
+        const protocol = externalUrl.protocol === 'https:' ? 'wss' : 'ws';
         const body = await response.json();
         for (const page of body) {
+          const devtoolsFrontendUrl = `/devtools/inspector.html?${protocol}=${externalUrl.host}${externalUrl.pathname}/devtools/page/${page.id}`;
           sessions.push({
             ...sessions[0],
             ...page,
             browserWSEndpoint: wsEndpoint,
+            devtoolsFrontendUrl,
           });
         }
       }
@@ -299,8 +303,8 @@ export class BrowserManager {
         global.setTimeout(() => {
           const session = this.browsers.get(browser);
           if (session) {
-            this.log.trace(`Timer hit for "${session.id}"`),
-              this.close(browser, session);
+            this.log.trace(`Timer hit for "${session.id}"`);
+            this.close(browser, session);
           }
         }, timeout),
       );

package/src/limiter.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 import {
   Config,
   Hooks,

package/src/routes/chrome/tests/content.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 import {
   Browserless,
   Config,

package/src/routes/chrome/ws/page.ts

@@ -4,6 +4,7 @@ import { default as Page, QuerySchema } from '../../../shared/page.ws.js';
 export default class ChromePageWebSocketRoute extends Page {
   name = BrowserlessRoutes.ChromePageWebSocketRoute;
   browser = ChromeCDP;
+  auth = false;
 }
 
 export { QuerySchema };

package/src/server.ts

@@ -415,7 +415,10 @@ export class HTTPServer extends EventEmitter {
   public async shutdown(): Promise<void> {
     this.logger.info(`HTTP Server is shutting down`);
     await new Promise((r) => this.server.close(r));
-    this.server && this.server.removeAllListeners();
+
+    if (this.server) {
+      this.server.removeAllListeners();
+    }
 
     // @ts-ignore garbage collect this reference
     this.server = null;

package/src/shared/json-version.http.ts

@@ -45,6 +45,7 @@ export default class ChromiumJSONVersionGetRoute extends HTTPRoute {
       }
       return jsonResponse(res, 200, this.cachedJSON);
     } catch (err) {
+      logger.warn(`Error handling request`, err);
       return writeResponse(
         res,
         500,

package/src/shared/utils/performance/main.ts

@@ -38,7 +38,7 @@ export default async ({
     const close = (pid?: number) => {
       if (closed) return;
       if (pid) process.kill(pid, 'SIGINT');
-      timeoutId && clearTimeout(timeoutId);
+      if (timeoutId) clearTimeout(timeoutId);
       closed = true;
       timeoutId = null;
     };