@browserless.io/browserless 2.18.0 → 2.19.0

package/CHANGELOG.md

@@ -1,6 +1,13 @@
-# [Latest](https://github.com/browserless/chrome/compare/v2.18.0...main)
+# [Latest](https://github.com/browserless/chrome/compare/v2.19.0...main)
 - Dependency updates.
 
+# [v2.19.0](https://github.com/browserless/chrome/compare/v2.18.0...v2.19.0)
+- Dependency updates.
+- Drop `sort-keys` for eslint integrations.
+- Fix devtools URLs when `PROXY` is set and contains a path.
+- Disable `auth` when using Chrome's internal `/page` APIs.
+- Small fixes for new eslint rules.
+
 # [v2.18.0](https://github.com/browserless/chrome/compare/v2.17.0...v2.18.0)
 - Dependency updates.
 - Supports `puppeteer-core@23.1.1`.

package/build/browsers/index.js

@@ -167,12 +167,16 @@ export class BrowserManager {
                 },
             });
             if (response.ok) {
+                const externalUrl = new URL(serverAddress);
+                const protocol = externalUrl.protocol === 'https:' ? 'wss' : 'ws';
                 const body = await response.json();
                 for (const page of body) {
+                    const devtoolsFrontendUrl = `/devtools/inspector.html?${protocol}=${externalUrl.host}${externalUrl.pathname}/devtools/page/${page.id}`;
                     sessions.push({
                         ...sessions[0],
                         ...page,
                         browserWSEndpoint: wsEndpoint,
+                        devtoolsFrontendUrl,
                     });
                 }
             }
@@ -198,8 +202,8 @@ export class BrowserManager {
             this.timers.set(session.id, global.setTimeout(() => {
                 const session = this.browsers.get(browser);
                 if (session) {
-                    this.log.trace(`Timer hit for "${session.id}"`),
-                        this.close(browser, session);
+                    this.log.trace(`Timer hit for "${session.id}"`);
+                    this.close(browser, session);
                 }
             }, timeout));
         }

package/build/limiter.spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 import { Config, Hooks, Limiter, Metrics, Monitoring, WebHooks, sleep, } from '@browserless.io/browserless';
 import Sinon, { spy } from 'sinon';
 import { expect } from 'chai';

package/build/routes/chrome/http/content.post.body.json

@@ -438,14 +438,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@12081": {
+                "__@toStringTag@14083": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@12081",
+                "__@toStringTag@14083",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -480,13 +480,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@12081": {
+        "__@toStringTag@14083": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@12081",
+        "__@toStringTag@14083",
         "byteLength"
       ]
     },
@@ -496,18 +496,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@12119": {
+        "__@species@14121": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@12081": {
+        "__@toStringTag@14083": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@12119",
-        "__@toStringTag@12081",
+        "__@species@14121",
+        "__@toStringTag@14083",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/pdf.post.body.json

@@ -583,14 +583,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@83982": {
+                "__@toStringTag@111971": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@83982",
+                "__@toStringTag@111971",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -625,13 +625,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@83982": {
+        "__@toStringTag@111971": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@83982",
+        "__@toStringTag@111971",
         "byteLength"
       ]
     },
@@ -641,18 +641,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@84020": {
+        "__@species@112009": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@83982": {
+        "__@toStringTag@111971": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@84020",
-        "__@toStringTag@83982",
+        "__@species@112009",
+        "__@toStringTag@111971",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/scrape.post.body.json

@@ -485,14 +485,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@108126": {
+                "__@toStringTag@154304": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@108126",
+                "__@toStringTag@154304",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -527,13 +527,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@108126": {
+        "__@toStringTag@154304": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@108126",
+        "__@toStringTag@154304",
         "byteLength"
       ]
     },
@@ -543,18 +543,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@108164": {
+        "__@species@154342": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@108126": {
+        "__@toStringTag@154304": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@108164",
-        "__@toStringTag@108126",
+        "__@species@154342",
+        "__@toStringTag@154304",
         "byteLength"
       ]
     },

package/build/routes/chrome/http/screenshot.post.body.json

@@ -528,14 +528,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@120375": {
+                "__@toStringTag@140130": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@120375",
+                "__@toStringTag@140130",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -570,13 +570,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@120375": {
+        "__@toStringTag@140130": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@120375",
+        "__@toStringTag@140130",
         "byteLength"
       ]
     },
@@ -586,18 +586,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@120413": {
+        "__@species@140168": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@120375": {
+        "__@toStringTag@140130": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@120413",
-        "__@toStringTag@120375",
+        "__@species@140168",
+        "__@toStringTag@140130",
         "byteLength"
       ]
     },

package/build/routes/chrome/tests/content.spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-expressions */
 import { Browserless, Config, Metrics, sleep, } from '@browserless.io/browserless';
 import { expect } from 'chai';
 describe('/chrome/content API', function () {

package/build/routes/chrome/ws/page.d.ts

@@ -3,5 +3,6 @@ import { default as Page, QuerySchema } from '../../../shared/page.ws.js';
 export default class ChromePageWebSocketRoute extends Page {
     name: string;
     browser: typeof ChromeCDP;
+    auth: boolean;
 }
 export { QuerySchema };

package/build/routes/chrome/ws/page.js

@@ -3,4 +3,5 @@ import { default as Page } from '../../../shared/page.ws.js';
 export default class ChromePageWebSocketRoute extends Page {
     name = BrowserlessRoutes.ChromePageWebSocketRoute;
     browser = ChromeCDP;
+    auth = false;
 }

package/build/routes/chromium/http/content.post.body.json

@@ -438,14 +438,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@132534": {
+                "__@toStringTag@168531": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@132534",
+                "__@toStringTag@168531",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -480,13 +480,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@132534": {
+        "__@toStringTag@168531": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@132534",
+        "__@toStringTag@168531",
         "byteLength"
       ]
     },
@@ -496,18 +496,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@132572": {
+        "__@species@168569": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@132534": {
+        "__@toStringTag@168531": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@132572",
-        "__@toStringTag@132534",
+        "__@species@168569",
+        "__@toStringTag@168531",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/pdf.post.body.json

@@ -583,14 +583,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@228360": {
+                "__@toStringTag@252426": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@228360",
+                "__@toStringTag@252426",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -625,13 +625,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@228360": {
+        "__@toStringTag@252426": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@228360",
+        "__@toStringTag@252426",
         "byteLength"
       ]
     },
@@ -641,18 +641,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@228398": {
+        "__@species@252464": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@228360": {
+        "__@toStringTag@252426": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@228398",
-        "__@toStringTag@228360",
+        "__@species@252464",
+        "__@toStringTag@252426",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/scrape.post.body.json

@@ -485,14 +485,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@264678": {
+                "__@toStringTag@294540": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@264678",
+                "__@toStringTag@294540",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -527,13 +527,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@264678": {
+        "__@toStringTag@294540": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@264678",
+        "__@toStringTag@294540",
         "byteLength"
       ]
     },
@@ -543,18 +543,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@264716": {
+        "__@species@294578": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@264678": {
+        "__@toStringTag@294540": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@264716",
-        "__@toStringTag@264678",
+        "__@species@294578",
+        "__@toStringTag@294540",
         "byteLength"
       ]
     },

package/build/routes/chromium/http/screenshot.post.body.json

@@ -528,14 +528,14 @@
                 "length": {
                   "type": "number"
                 },
-                "__@toStringTag@252509": {
+                "__@toStringTag@308788": {
                   "type": "string",
                   "const": "Uint8Array"
                 }
               },
               "required": [
                 "BYTES_PER_ELEMENT",
-                "__@toStringTag@252509",
+                "__@toStringTag@308788",
                 "buffer",
                 "byteLength",
                 "byteOffset",
@@ -570,13 +570,13 @@
         "byteLength": {
           "type": "number"
         },
-        "__@toStringTag@252509": {
+        "__@toStringTag@308788": {
           "type": "string"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@toStringTag@252509",
+        "__@toStringTag@308788",
         "byteLength"
       ]
     },
@@ -586,18 +586,18 @@
         "byteLength": {
           "type": "number"
         },
-        "__@species@252547": {
+        "__@species@308826": {
           "$ref": "#/definitions/SharedArrayBuffer"
         },
-        "__@toStringTag@252509": {
+        "__@toStringTag@308788": {
           "type": "string",
           "const": "SharedArrayBuffer"
         }
       },
       "additionalProperties": false,
       "required": [
-        "__@species@252547",
-        "__@toStringTag@252509",
+        "__@species@308826",
+        "__@toStringTag@308788",
         "byteLength"
       ]
     },

package/build/server.js

@@ -241,7 +241,9 @@ export class HTTPServer extends EventEmitter {
     async shutdown() {
         this.logger.info(`HTTP Server is shutting down`);
         await new Promise((r) => this.server.close(r));
-        this.server && this.server.removeAllListeners();
+        if (this.server) {
+            this.server.removeAllListeners();
+        }
         // @ts-ignore garbage collect this reference
         this.server = null;
         this.logger.info(`HTTP Server shutdown complete`);

package/build/shared/json-version.http.js

@@ -25,6 +25,7 @@ export default class ChromiumJSONVersionGetRoute extends HTTPRoute {
             return jsonResponse(res, 200, this.cachedJSON);
         }
         catch (err) {
+            logger.warn(`Error handling request`, err);
             return writeResponse(res, 500, 'There was an error handling your request', contentTypes.text);
         }
     }

package/build/shared/utils/performance/main.js

@@ -20,7 +20,8 @@ export default async ({ browser, context, logger, timeout, }) => {
                 return;
             if (pid)
                 process.kill(pid, 'SIGINT');
-            timeoutId && clearTimeout(timeoutId);
+            if (timeoutId)
+                clearTimeout(timeoutId);
             closed = true;
             timeoutId = null;
         };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@browserless.io/browserless",
-  "version": "2.18.0",
+  "version": "2.19.0",
   "license": "SSPL",
   "description": "The browserless platform",
   "author": "browserless.io",
@@ -56,13 +56,13 @@
     "gradient-string": "^2.0.0",
     "http-proxy": "^1.18.1",
     "lighthouse": "^12.2.0",
-    "micromatch": "^4.0.7",
+    "micromatch": "^4.0.8",
     "playwright-1.41": "npm:playwright-core@1.41.2",
     "playwright-1.42": "npm:playwright-core@1.42.1",
     "playwright-1.43": "npm:playwright-core@1.43.1",
     "playwright-1.44": "npm:playwright-core@1.44.1",
     "playwright-core": "^1.46.1",
-    "puppeteer-core": "^23.1.1",
+    "puppeteer-core": "^23.2.1",
     "puppeteer-extra": "^3.3.6",
     "puppeteer-extra-plugin-stealth": "^2.11.2",
     "queue": "^7.0.0",
@@ -70,16 +70,16 @@
     "tar-fs": "^3.0.6"
   },
   "optionalDependencies": {
-    "@types/chai": "^4.3.17",
+    "@types/chai": "^4.3.18",
     "@types/debug": "^4.1.12",
     "@types/gradient-string": "^1.1.6",
     "@types/http-proxy": "^1.17.15",
     "@types/micromatch": "^4.0.9",
     "@types/mocha": "^10.0.7",
-    "@types/node": "^22.5.0",
+    "@types/node": "^22.5.2",
     "@types/sinon": "^17.0.3",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.4.0",
+    "@typescript-eslint/parser": "^8.4.0",
     "assert": "^2.0.0",
     "chai": "^5.1.1",
     "cross-env": "^7.0.3",
@@ -87,10 +87,9 @@
     "esbuild": "^0.23.1",
     "esbuild-plugin-polyfill-node": "^0.3.0",
     "eslint": "^8.57.0",
-    "eslint-plugin-typescript-sort-keys": "^3.2.0",
     "extract-zip": "^2.0.1",
     "gunzip-maybe": "^1.4.2",
-    "marked": "^14.0.0",
+    "marked": "^14.1.0",
     "mocha": "^10.7.3",
     "move-file": "^3.1.0",
     "prettier": "^3.3.3",
@@ -111,32 +110,23 @@
     "root": true,
     "parser": "@typescript-eslint/parser",
     "plugins": [
-      "@typescript-eslint",
-      "typescript-sort-keys"
+      "@typescript-eslint"
     ],
     "extends": [
       "eslint:recommended",
       "plugin:@typescript-eslint/eslint-recommended",
-      "plugin:@typescript-eslint/recommended",
-      "plugin:typescript-sort-keys/recommended"
+      "plugin:@typescript-eslint/recommended"
     ],
     "ignorePatterns": [
       "node_modules/*",
+      "static/*",
+      "**.spec.ts",
       "build/*",
       ".DS_Store",
       ".no-git/*",
       "*.log"
     ],
     "rules": {
-      "sort-keys": [
-        "error",
-        "asc",
-        {
-          "caseSensitive": true,
-          "natural": false,
-          "minKeys": 2
-        }
-      ],
       "semi": [
         2,
         "always"