@brightbeamai/chap-coordinator 0.2.12 → 0.2.13

package/dist/index.js

@@ -1747,6 +1747,7 @@ function reply(env, body) {
   else out.result = body.result;
   return out;
 }
+var REVIEW_REQUEST_STOPPED = ["cancelled", "superseded", "paused"];
 var Coordinator = class {
   workspaces = /* @__PURE__ */ new Map();
   options;
@@ -2422,6 +2423,12 @@ var Coordinator = class {
     if (!legal[task.state]?.includes(newState)) {
       return { error: rpcError(E.PARAMS, `Illegal transition ${task.state} -> ${newState}`) };
     }
+    if (newState === "completed" && task.review_required) {
+      return { error: rpcError(
+        E.PARAMS,
+        "This task requires review. Submit the output with task.complete, which opens the review; a reviewer decision completes it."
+      ) };
+    }
     task.state = newState;
     task.updated_at = this.now();
     task.history.push({
@@ -2447,11 +2454,11 @@ var Coordinator = class {
       task.pending_artefact = p.output;
       if (!task.review) {
         const producer = p.from;
-        const eligible = [...ws.members.keys()].filter((uri) => uri !== producer && uri !== task.assignee);
+        const eligible = [...ws.members.entries()].filter(([uri, member]) => uri !== producer && uri !== task.assignee && member.type === "human").map(([uri]) => uri);
         if (eligible.length === 0) {
           return { error: rpcError(
             E.NOT_AUTHORISED,
-            "Task requires review but has no eligible reviewer (needs a member other than its assignee and completer)"
+            "Task requires review but has no eligible human reviewer (needs a human member other than its assignee and completer)"
           ) };
         }
         task.review = { requested_at: now, requested_to: eligible, rule: "any_one_approves", decisions: [] };
@@ -2512,11 +2519,15 @@ var Coordinator = class {
     if (notMember) return notMember;
     const task = ws.tasks.get(p.task_id);
     if (!task) return { error: rpcError(E.PARAMS, "Unknown task") };
+    if (REVIEW_REQUEST_STOPPED.includes(task.state)) {
+      return { error: rpcError(E.NOT_REVIEWABLE, `Cannot request review for task in state: ${task.state}`) };
+    }
     const to = p.to;
     const reviewers = Array.isArray(to) ? to : typeof to === "string" ? [to] : [];
     if (!reviewers.length) return { error: rpcError(E.PARAMS, "review.request needs 'to'") };
     const now = this.now();
-    const rule = p.rule || "any_one_approves";
+    const declaredRule = p.rule;
+    const rule = declaredRule || "any_one_approves";
     if (!reviewRuleSupported(rule)) {
       return { error: rpcError(E.PARAMS, `Unsupported review rule ${JSON.stringify(rule)}: review/1.0 supports any_one_approves, all_approve, quorum:<n>`) };
     }
@@ -2527,7 +2538,7 @@ var Coordinator = class {
           "A review is already open on this task with different content. Decide, abstain, escalate or cancel it before requesting review of a new artefact."
         ) };
       }
-      if (rule !== task.review.rule) {
+      if (declaredRule !== void 0 && declaredRule !== task.review.rule) {
         return { error: rpcError(
           E.REVIEW_ALREADY_OPEN,
           `Cannot change the decision rule of an open review (currently ${task.review.rule})`