@brightbeamai/chap-coordinator 0.2.12 → 0.2.13

package/README.md

@@ -13,8 +13,9 @@ surface, so the two interoperate on the same JSON-RPC 2.0 wire.
 npm install @brightbeamai/chap-coordinator
 ```
 
-Node 20+ required. Zero external runtime dependencies; uses Node's
-built-in `crypto` for Ed25519 and JCS.
+Node 20+ required. No required runtime dependencies; uses Node's built-in
+`crypto` for Ed25519 and JCS. `better-sqlite3` is an optional dependency,
+needed only for `SqliteStore`.
 
 ## Companion packages
 
@@ -85,7 +86,7 @@ console.log(resp.result);  // { task_id: "tsk_...", state: "created" }
 
 | Profile               | Methods (per profile spec)                                                                |
 |-----------------------|-------------------------------------------------------------------------------------------|
-| `core/1.0`            | `workspace.create`, `workspace.describe`, `workspace.set_profiles`, `participant.join`, `participant.leave`, `task.create`, `task.update`, `task.complete`, `audit.read` |
+| `core/1.0`            | `workspace.create`, `workspace.describe`, `workspace.set_profiles`, `participant.join`, `participant.leave`, `task.create`, `task.update`, `task.complete`, `audit.read`; a task created with `review_required` completes only on a reviewer decision |
 | `review/1.0`          | `review.request`, `decide.approve`, `decide.reject`, `decide.override`, `abstain.declare`, `escalate.raise` |
 | `whisper/1.0`         | `whisper.ask`, `whisper.answer`; lapse hook via `coord.checkWhisperLapses(workspaceId, now?)` |
 | `deliberation/1.0`    | `deliberate.open`, `deliberate.comment`, `deliberate.vote`, `deliberate.close` |
@@ -100,6 +101,15 @@ console.log(resp.result);  // { task_id: "tsk_...", state: "created" }
 
 **39 method handlers in total**, matching the Python reference exactly.
 
+**The review gate.** A task carrying `review_required` does not complete on
+`task.complete`. The call opens a review, holding the submitted output as the
+artefact under review, and only a `decide.*` reaches `completed`. `task.update`
+cannot complete such a task either, and answers `-32602` naming the route
+through. Where no reviewer was named, the set is the human members other than
+the completer and the assignee; a workspace with no eligible human refuses the
+completion rather than opening a review nobody can decide. Under `modes/1.0` a
+trial-mode task has `review_required` set for it.
+
 ## Architecture
 
 The coordinator is transport-agnostic, persistence-agnostic, and
@@ -171,7 +181,7 @@ Key lifecycle:
 - `participant.revoke_key` is an admin operation; envelopes signed
   with the revoked key after revocation are rejected.
 
-Helpers exported from `@brightbeamai/chap-coordinator/crypto`:
+Helpers exported from `@brightbeamai/chap-coordinator`:
 
 ```typescript
 import {

package/dist/index.cjs

@@ -1795,6 +1795,7 @@ function reply(env, body) {
   else out.result = body.result;
   return out;
 }
+var REVIEW_REQUEST_STOPPED = ["cancelled", "superseded", "paused"];
 var Coordinator = class {
   workspaces = /* @__PURE__ */ new Map();
   options;
@@ -2470,6 +2471,12 @@ var Coordinator = class {
     if (!legal[task.state]?.includes(newState)) {
       return { error: rpcError(E.PARAMS, `Illegal transition ${task.state} -> ${newState}`) };
     }
+    if (newState === "completed" && task.review_required) {
+      return { error: rpcError(
+        E.PARAMS,
+        "This task requires review. Submit the output with task.complete, which opens the review; a reviewer decision completes it."
+      ) };
+    }
     task.state = newState;
     task.updated_at = this.now();
     task.history.push({
@@ -2495,11 +2502,11 @@ var Coordinator = class {
       task.pending_artefact = p.output;
       if (!task.review) {
         const producer = p.from;
-        const eligible = [...ws.members.keys()].filter((uri) => uri !== producer && uri !== task.assignee);
+        const eligible = [...ws.members.entries()].filter(([uri, member]) => uri !== producer && uri !== task.assignee && member.type === "human").map(([uri]) => uri);
         if (eligible.length === 0) {
           return { error: rpcError(
             E.NOT_AUTHORISED,
-            "Task requires review but has no eligible reviewer (needs a member other than its assignee and completer)"
+            "Task requires review but has no eligible human reviewer (needs a human member other than its assignee and completer)"
           ) };
         }
         task.review = { requested_at: now, requested_to: eligible, rule: "any_one_approves", decisions: [] };
@@ -2560,11 +2567,15 @@ var Coordinator = class {
     if (notMember) return notMember;
     const task = ws.tasks.get(p.task_id);
     if (!task) return { error: rpcError(E.PARAMS, "Unknown task") };
+    if (REVIEW_REQUEST_STOPPED.includes(task.state)) {
+      return { error: rpcError(E.NOT_REVIEWABLE, `Cannot request review for task in state: ${task.state}`) };
+    }
     const to = p.to;
     const reviewers = Array.isArray(to) ? to : typeof to === "string" ? [to] : [];
     if (!reviewers.length) return { error: rpcError(E.PARAMS, "review.request needs 'to'") };
     const now = this.now();
-    const rule = p.rule || "any_one_approves";
+    const declaredRule = p.rule;
+    const rule = declaredRule || "any_one_approves";
     if (!reviewRuleSupported(rule)) {
       return { error: rpcError(E.PARAMS, `Unsupported review rule ${JSON.stringify(rule)}: review/1.0 supports any_one_approves, all_approve, quorum:<n>`) };
     }
@@ -2575,7 +2586,7 @@ var Coordinator = class {
           "A review is already open on this task with different content. Decide, abstain, escalate or cancel it before requesting review of a new artefact."
         ) };
       }
-      if (rule !== task.review.rule) {
+      if (declaredRule !== void 0 && declaredRule !== task.review.rule) {
         return { error: rpcError(
           E.REVIEW_ALREADY_OPEN,
           `Cannot change the decision rule of an open review (currently ${task.review.rule})`