@brainervirus/workit-core 0.6.0 → 0.7.0

package/src/core/youtrack.ts

@@ -1,9 +1,8 @@
 import fs from "node:fs";
 import path from "node:path";
-import { spawnSync } from "node:child_process";
 import { readTemplate } from "./templates";
 import { resolveWorkspaceRoot } from "./scripts";
-import { configDir } from "./config";
+import { configDir, isConfigObject } from "./config";
 
 const ISSUE_RE = /^[A-Z]+-\d+$/;
 const TOKEN_PLACEHOLDER = "YOUR_TOKEN_HERE";
@@ -11,8 +10,7 @@ const TOKEN_PLACEHOLDER = "YOUR_TOKEN_HERE";
 // Port of scripts/youtrack/config.sh chain: WORKFLOW_YOUTRACK_CONFIG ->
 // configDir() (XDG_CONFIG_HOME / HOME .config + workit).
 export const youTrackConfigPath = (): string =>
-  process.env.WORKFLOW_YOUTRACK_CONFIG ??
-  path.join(configDir(), "youtrack.json");
+  process.env.WORKFLOW_YOUTRACK_CONFIG ?? path.join(configDir(), "youtrack.json");
 
 const youTrackTokenModeOk = (p: string): boolean => {
   if (process.platform === "win32") return true;
@@ -20,27 +18,51 @@ const youTrackTokenModeOk = (p: string): boolean => {
   return mode === 0o600;
 };
 
-function readYouTrackConfig(required: boolean): { config: Record<string, any>; path: string } | { error: string } {
+// AR-07/CA-37: the shared shape rule applies here too — a parseable non-object
+// youtrack.json (null, scalar, array) is malformed with the exact path, never
+// missing/unconfigured, never silently defaulted.
+function readYouTrackConfig(
+  required: boolean,
+): { config: Record<string, any>; path: string } | { error: string; path: string } {
   const cfgPath = youTrackConfigPath();
   if (!fs.existsSync(cfgPath)) {
-    return required ? { error: "ERROR: missing youtrack.json" } : { config: {}, path: cfgPath };
+    return required
+      ? { error: "ERROR: missing youtrack.json", path: cfgPath }
+      : { config: {}, path: cfgPath };
   }
+  let parsed: unknown;
   try {
-    const config = JSON.parse(fs.readFileSync(cfgPath, "utf8")) as Record<string, any>;
-    return { config, path: cfgPath };
+    parsed = JSON.parse(fs.readFileSync(cfgPath, "utf8"));
   } catch {
-    return { error: "invalid youtrack.json" };
+    return { error: `${cfgPath} is not valid JSON`, path: cfgPath };
   }
+  if (!isConfigObject(parsed)) {
+    return { error: `${cfgPath} is not a JSON object`, path: cfgPath };
+  }
+  return { config: parsed as Record<string, any>, path: cfgPath };
 }
 
+// RL-01: typed load result — malformed carries {ok:false, error, configPath}
+// mirroring vcsConfig, so risky consumers stop on the exact path.
+export type YouTrackConfigResult =
+  | { data: Record<string, any> }
+  | { error: string }
+  | { ok: false; error: string; configPath: string };
+
 /** Load + redact youtrack.json; validates the token file like youtrack/config.sh load. */
-export function youTrackConfigLoad(): { data: Record<string, any> } | { error: string } {
+export function youTrackConfigLoad(): YouTrackConfigResult {
   const loaded = readYouTrackConfig(true);
-  if ("error" in loaded) return loaded;
+  if ("error" in loaded) {
+    // RL-01: malformed (parse failure or non-object) fails closed with the exact
+    // path, mirroring vcsConfig's {ok:false,error,configPath} shape.
+    return { ok: false, error: loaded.error, configPath: loaded.path };
+  }
   const cfgPath = loaded.path;
   const tokenFile = String(loaded.config.tokenFile ?? "");
   const tokenPath = tokenFile
-    ? (path.isAbsolute(tokenFile) ? path.resolve(tokenFile) : path.resolve(process.cwd(), tokenFile))
+    ? path.isAbsolute(tokenFile)
+      ? path.resolve(tokenFile)
+      : path.resolve(process.cwd(), tokenFile)
     : "";
   if (!tokenPath || !fs.existsSync(tokenPath)) {
     return { error: "missing youtrack.token" };
@@ -60,20 +82,47 @@ export function youTrackConfigLoad(): { data: Record<string, any> } | { error: s
   return { data: redacted };
 }
 
-function tzParts(date: Date, tz: string): { y: string; m: string; d: string; hour: string; minute: string } {
+function tzParts(
+  date: Date,
+  tz: string,
+): { y: string; m: string; d: string; hour: string; minute: string } {
   const parts = new Intl.DateTimeFormat("en-GB", {
-    timeZone: tz, year: "numeric", month: "2-digit", day: "2-digit",
-    hour: "2-digit", minute: "2-digit", hourCycle: "h23",
+    timeZone: tz,
+    year: "numeric",
+    month: "2-digit",
+    day: "2-digit",
+    hour: "2-digit",
+    minute: "2-digit",
+    hourCycle: "h23",
   }).formatToParts(date);
   const map = Object.fromEntries(parts.map((p) => [p.type, p.value]));
   return { y: map.year, m: map.month, d: map.day, hour: map.hour, minute: map.minute };
 }
 
 /** Port of scripts/youtrack/greeting.sh. */
-export function youTrackGreeting(configOverride?: string): { stdout: string; exitCode: number; stderr: string } {
+export function youTrackGreeting(configOverride?: string): {
+  stdout: string;
+  exitCode: number;
+  stderr: string;
+} {
   const cfgPath = configOverride ?? youTrackConfigPath();
+  let parsed: unknown;
+  try {
+    parsed = JSON.parse(fs.readFileSync(cfgPath, "utf8"));
+  } catch {
+    return {
+      stdout: "",
+      exitCode: 1,
+      stderr: fs.existsSync(cfgPath)
+        ? `${cfgPath} is not valid JSON`
+        : `missing youtrack.json: ${cfgPath}`,
+    };
+  }
+  if (!isConfigObject(parsed)) {
+    return { stdout: "", exitCode: 1, stderr: `${cfgPath} is not a JSON object` };
+  }
+  const config = parsed as Record<string, any>;
   try {
-    const config = JSON.parse(fs.readFileSync(cfgPath, "utf8")) as Record<string, any>;
     const tz = String(config.timezone ?? "America/Santiago");
     const now = new Date();
     const { y, m, d, hour, minute } = tzParts(now, tz);
@@ -81,20 +130,29 @@ export function youTrackGreeting(configOverride?: string): { stdout: string; exi
     const cutoffHour = Number(cutoff[0]);
     const cutoffMinute = Number(cutoff[1] ?? 0);
     const greetings = (config.greetings ?? {}) as Record<string, string>;
-    const isMorning = Number(hour) < cutoffHour || (Number(hour) === cutoffHour && Number(minute) < cutoffMinute);
+    const isMorning =
+      Number(hour) < cutoffHour || (Number(hour) === cutoffHour && Number(minute) < cutoffMinute);
     const greeting = isMorning
-      ? greetings.morning ?? "buenos días"
-      : greetings.afternoon ?? "buenas tardes";
+      ? (greetings.morning ?? "buenos días")
+      : (greetings.afternoon ?? "buenas tardes");
     const mention = String(config.defaultMention ?? "Alejandra.Flores");
-    void y; void m; void d;
+    void y;
+    void m;
+    void d;
     return { stdout: `@${mention} Hola, ${greeting}.\n`, exitCode: 0, stderr: "" };
   } catch (err) {
-    return { stdout: "", exitCode: 1, stderr: err instanceof Error ? err.message : "greeting failed" };
+    return {
+      stdout: "",
+      exitCode: 1,
+      stderr: err instanceof Error ? err.message : "greeting failed",
+    };
   }
 }
 
 /** Port of scripts/youtrack/parse-duration.sh. */
-export function youTrackParseDuration(text: string): { data: { minutes: number; text: string } } | { error: string } {
+export function youTrackParseDuration(
+  text: string,
+): { data: { minutes: number; text: string } } | { error: string } {
   const lower = String(text).toLowerCase().trim();
   let total = 0;
   for (const match of lower.matchAll(/(\d+)\s*h/g)) total += Number(match[1]) * 60;
@@ -105,13 +163,26 @@ export function youTrackParseDuration(text: string): { data: { minutes: number;
 }
 
 /** Port of scripts/youtrack/work-date-ms.sh — resolve work-item date as epoch ms. */
-export function youTrackWorkDateMs(dateRaw: string): { data: { dateMs: number; timezone: string; localDate: string } } | { error: string } {
+export function youTrackWorkDateMs(
+  dateRaw: string,
+): { data: { dateMs: number; timezone: string; localDate: string } } | { error: string } {
   const cfgPath = youTrackConfigPath();
   let tz = "America/Santiago";
-  try {
-    const config = JSON.parse(fs.readFileSync(cfgPath, "utf8")) as Record<string, any>;
-    tz = String(config.timezone ?? "America/Santiago");
-  } catch { /* defaults */ }
+  // Missing file is a legitimate unconfigured state (reader: "missing" keeps
+  // defaults); a parseable non-object is malformed and must propagate the
+  // exact-path error instead of silently defaulting the timezone.
+  if (fs.existsSync(cfgPath)) {
+    let parsed: unknown;
+    try {
+      parsed = JSON.parse(fs.readFileSync(cfgPath, "utf8"));
+    } catch {
+      return { error: `${cfgPath} is not valid JSON` };
+    }
+    if (!isConfigObject(parsed)) {
+      return { error: `${cfgPath} is not a JSON object` };
+    }
+    tz = String((parsed as Record<string, any>).timezone ?? "America/Santiago");
+  }
   const raw = dateRaw || "auto";
   try {
     if (raw === "auto" || !raw) {
@@ -128,7 +199,13 @@ export function youTrackWorkDateMs(dateRaw: string): { data: { dateMs: number; t
     const [y, m, d] = raw.split("-").map(Number);
     const iso = `${y}-${String(m).padStart(2, "0")}-${String(d).padStart(2, "0")}T00:00:00`;
     const dateMs = Math.floor(Date.parse(iso) / 86400000) * 86400000;
-    return { data: { dateMs, timezone: tz, localDate: `${y}-${String(m).padStart(2, "0")}-${String(d).padStart(2, "0")}` } };
+    return {
+      data: {
+        dateMs,
+        timezone: tz,
+        localDate: `${y}-${String(m).padStart(2, "0")}-${String(d).padStart(2, "0")}`,
+      },
+    };
   } catch (err) {
     return { error: err instanceof Error ? err.message : "could not resolve date" };
   }
@@ -139,63 +216,106 @@ const youTrackToken = (): { token: string; base: string } | { error: string } =>
   if ("error" in loaded) return loaded;
   const tokenFile = String(loaded.config.tokenFile ?? "");
   const tokenPath = tokenFile
-    ? (path.isAbsolute(tokenFile) ? path.resolve(tokenFile) : path.resolve(process.cwd(), tokenFile))
+    ? path.isAbsolute(tokenFile)
+      ? path.resolve(tokenFile)
+      : path.resolve(process.cwd(), tokenFile)
     : "";
   if (!tokenPath || !fs.existsSync(tokenPath)) return { error: "missing youtrack.token" };
   if (!youTrackTokenModeOk(tokenPath)) return { error: "youtrack.token mode must be 0600" };
   const token = fs.readFileSync(tokenPath, "utf8").trim();
   if (!token) return { error: "empty token file" };
   if (token === TOKEN_PLACEHOLDER || token.startsWith(TOKEN_PLACEHOLDER)) {
-    return { error: "token file still has placeholder YOUR_TOKEN_HERE — edit the file locally, then run /wk-status" };
+    return {
+      error:
+        "token file still has placeholder YOUR_TOKEN_HERE — edit the file locally, then run /wk-status",
+    };
   }
   const base = String(loaded.config.baseUrl ?? "").replace(/\/+$/, "");
   if (!base) return { error: "baseUrl missing in config" };
   return { token, base };
 };
 
-function youTrackCurl(args: string[]): { status: number; stdout: string; stderr: string } {
-  const result = spawnSync("curl", ["-fsS", ...args], { encoding: "utf8" });
-  return { status: result.status ?? 1, stdout: result.stdout ?? "", stderr: result.stderr ?? "" };
+// fetch replaces the previous curl -fsS request helper: check res.ok,
+// surface HTTP errors without a token-bearing body, parse JSON on success.
+async function youTrackRequest(
+  url: string,
+  init: { method: string; token: string; body?: unknown },
+): Promise<{ status: number; stdout: string; stderr: string }> {
+  const headers: Record<string, string> = {
+    Authorization: `Bearer ${init.token}`,
+    Accept: "application/json",
+  };
+  let body: string | undefined;
+  if (init.body !== undefined) {
+    headers["Content-Type"] = "application/json";
+    body = JSON.stringify(init.body);
+  }
+  try {
+    const res = await fetch(url, { method: init.method, headers, body });
+    const text = await res.text();
+    if (!res.ok) {
+      return { status: res.status, stdout: "", stderr: text.slice(0, 200) };
+    }
+    return { status: 0, stdout: text, stderr: "" };
+  } catch (err) {
+    return { status: 1, stdout: "", stderr: err instanceof Error ? err.message : "network error" };
+  }
 }
 
 /** Port of scripts/youtrack/api.sh — log-time / post-comment with the WORKFLOW_YT_WRITE guard. */
-export function youTrackApi(args: string[], writeFlag = process.env.WORKFLOW_YT_WRITE ?? ""): { data: Record<string, any> } | { error: string } {
+export async function youTrackApi(
+  args: string[],
+  writeFlag = process.env.WORKFLOW_YT_WRITE ?? "",
+): Promise<{ data: Record<string, any> } | { error: string }> {
   const cmd = args[0];
   if (cmd === "log-time" || cmd === "post-comment") {
     if (writeFlag !== "1") {
-      return { error: "YouTrack write operations require WORKFLOW_YT_WRITE=1 (refusing to mutate production)" };
+      return {
+        error:
+          "YouTrack write operations require WORKFLOW_YT_WRITE=1 (refusing to mutate production)",
+      };
     }
   }
   const creds = youTrackToken();
   if ("error" in creds) return creds;
   const { token, base } = creds;
-  const auth = ["-H", `Authorization: Bearer ${token}`, "-H", "Accept: application/json"];
 
   if (cmd === "log-time") {
     const [issue, minutesRaw, text, dateArg] = args.slice(1);
     const minutes = Number(minutesRaw);
     const dateMs = youTrackWorkDateMs(dateArg ?? "auto");
     if ("error" in dateMs) return dateMs;
-    const body = JSON.stringify({ duration: { minutes }, text, date: dateMs.data.dateMs });
-    const out = youTrackCurl([
-      ...auth, "-H", "Content-Type: application/json", "-d", body,
+    const out = await youTrackRequest(
       `${base}/api/issues/${issue}/timeTracking/workItems?fields=id,idReadable`,
-    ]);
+      {
+        method: "POST",
+        token,
+        body: { duration: { minutes }, text, date: dateMs.data.dateMs },
+      },
+    );
     if (out.status !== 0) return { error: "YouTrack HTTP request failed" };
     try {
       const created = JSON.parse(out.stdout) as Record<string, any>;
-      return { data: { ok: true, issueId: issue, workItemId: created.id, dateMs: dateMs.data.dateMs, minutes } };
+      return {
+        data: {
+          ok: true,
+          issueId: issue,
+          workItemId: created.id,
+          dateMs: dateMs.data.dateMs,
+          minutes,
+        },
+      };
     } catch {
       return { error: "invalid JSON from YouTrack API" };
     }
   }
   if (cmd === "post-comment") {
     const [issue, text] = args.slice(1);
-    const body = JSON.stringify({ text });
-    const out = youTrackCurl([
-      ...auth, "-H", "Content-Type: application/json", "-d", body,
-      `${base}/api/issues/${issue}/comments`,
-    ]);
+    const out = await youTrackRequest(`${base}/api/issues/${issue}/comments`, {
+      method: "POST",
+      token,
+      body: { text },
+    });
     if (out.status !== 0) return { error: "YouTrack HTTP request failed" };
     return { data: { ok: true, issueId: issue } };
   }
@@ -203,18 +323,24 @@ export function youTrackApi(args: string[], writeFlag = process.env.WORKFLOW_YT_
 }
 
 /** Port of scripts/youtrack/verify-token.sh — read-only GET /api/users/me. */
-export function youTrackVerifyToken(): { data: Record<string, any> } | { error: string; http_status?: number; path?: string } {
+export async function youTrackVerifyToken(): Promise<
+  { data: Record<string, any> } | { error: string; http_status?: number; path?: string }
+> {
   const cfgPath = youTrackConfigPath();
   if (!fs.existsSync(cfgPath)) return { error: "missing youtrack.json" };
   const creds = youTrackToken();
   if ("error" in creds) return { error: creds.error };
   const { token, base } = creds;
 
-  const me = youTrackCurl(["-H", `Authorization: Bearer ${token}`, "-H", "Accept: application/json",
-    `${base}/api/users/me?fields=id,login,name,email`]);
+  const me = await youTrackRequest(`${base}/api/users/me?fields=id,login,name,email`, {
+    method: "GET",
+    token,
+  });
   if (me.status !== 0) {
-    const body = me.stderr.trim() || me.stdout.trim();
-    const err = me.status === 22 ? "authentication failed (401/403)" : `HTTP error: ${body.slice(0, 200)}`;
+    const err =
+      me.status === 401 || me.status === 403
+        ? "authentication failed (401/403)"
+        : `HTTP error: ${me.stderr.slice(0, 200)}`;
     return { error: err, http_status: me.status };
   }
   let user: Record<string, any>;
@@ -224,21 +350,30 @@ export function youTrackVerifyToken(): { data: Record<string, any> } | { error:
     return { error: "invalid JSON from YouTrack /api/users/me" };
   }
   const result: Record<string, any> = {
-    ok: true, method: "GET /api/users/me", baseUrl: base,
-    login: user.login, name: user.name, email: user.email, id: user.id,
+    ok: true,
+    method: "GET /api/users/me",
+    baseUrl: base,
+    login: user.login,
+    name: user.name,
+    email: user.email,
+    id: user.id,
   };
   const meeting = readYouTrackConfig(false);
   const meetingIssue = "config" in meeting ? meeting.config.meetingIssue : undefined;
   if (meetingIssue) {
-    const issue = youTrackCurl(["-H", `Authorization: Bearer ${token}`, "-H", "Accept: application/json",
-      `${base}/api/issues/${meetingIssue}?fields=id,idReadable,summary`]);
+    const issue = await youTrackRequest(
+      `${base}/api/issues/${meetingIssue}?fields=id,idReadable,summary`,
+      { method: "GET", token },
+    );
     if (issue.status === 0) {
       try {
         const parsed = JSON.parse(issue.stdout) as Record<string, any>;
         result.meetingIssue = meetingIssue;
         result.meetingIssueReadable = true;
         result.meetingIssueSummary = parsed.summary;
-      } catch { /* unreadable */ }
+      } catch {
+        /* unreadable */
+      }
     } else {
       result.meetingIssue = meetingIssue;
       result.meetingIssueReadable = false;
@@ -252,14 +387,20 @@ export function youTrackVerifyToken(): { data: Record<string, any> } | { error:
 export function youTrackTokenCreateUrl(): { data: Record<string, any> } {
   const tokenName = process.env.WORKFLOW_YT_TOKEN_NAME ?? "workit";
   const loaded = readYouTrackConfig(false);
-  const config = loaded && "config" in loaded ? loaded.config : {};
-  const cfgPath = loaded && "config" in loaded ? loaded.path : youTrackConfigPath();
+  if ("error" in loaded) {
+    return { data: { error: loaded.error } };
+  }
+  const config = loaded.config;
   const defaults = (config.tokenDefaults ?? {}) as Record<string, any>;
   const name = String(defaults.name ?? tokenName);
-  const desc = String(defaults.description ?? "OpenCode workit — /wk-issue-update and /wk-meetings");
+  const desc = String(
+    defaults.description ?? "OpenCode workit — /wk-issue-update and /wk-meetings",
+  );
   const scopes = Array.isArray(defaults.scopes) ? defaults.scopes : ["YouTrack"];
   const base = String(config.baseUrl ?? "https://enghouseamg.youtrack.cloud").replace(/\/+$/, "");
-  const tokenFile = String(config.tokenFile ?? path.join(path.dirname(cfgPath), "youtrack.token"));
+  const tokenFile = String(
+    config.tokenFile ?? path.join(path.dirname(loaded.path), "youtrack.token"),
+  );
   const tab = String(defaults.profileTab ?? "account-security");
   const createUrl = `${base}/users/me?${new URLSearchParams({ tab })}`;
   const docsUrl = "https://www.jetbrains.com/help/youtrack/cloud/manage-permanent-token.html";
@@ -284,7 +425,9 @@ export function youTrackTokenCreateUrl(): { data: Record<string, any> } {
 }
 
 /** Parse bare id (NSR-40) or YouTrack URL into issue id. */
-export function parseIssueRef(input: unknown): { issueId: string; source: string } | { error: string } {
+export function parseIssueRef(
+  input: unknown,
+): { issueId: string; source: string } | { error: string } {
   const trimmed = String(input ?? "").trim();
   if (!trimmed) return { error: "empty issue reference" };
 
@@ -309,7 +452,7 @@ export type YouTrackScripts = {
   config(): Record<string, any>;
   greeting(): { stdout: string; exitCode: number; stderr: string };
   parseDuration(text: string): Record<string, any>;
-  api(args: string[]): Record<string, any>;
+  api(args: string[]): Record<string, any> | Promise<Record<string, any>>;
 };
 
 const defaultScripts: YouTrackScripts = {
@@ -319,11 +462,17 @@ const defaultScripts: YouTrackScripts = {
   api: (args) => youTrackApi(args, process.env.WORKFLOW_YT_WRITE ?? ""),
 };
 
-export function verifyYouTrackToken(scripts: YouTrackScripts = defaultScripts): Record<string, any> {
+export function verifyYouTrackToken(
+  scripts: YouTrackScripts = defaultScripts,
+): Record<string, any> {
   return scripts.config();
 }
 
-function resolveYouTrackFromPaths(spec_path: string | undefined, plan_path: string | undefined, workspace_root: string): string | null {
+function resolveYouTrackFromPaths(
+  spec_path: string | undefined,
+  plan_path: string | undefined,
+  workspace_root: string,
+): string | null {
   const root = resolveWorkspaceRoot(workspace_root);
   for (const rel of [spec_path, plan_path].filter(Boolean) as string[]) {
     const full = path.isAbsolute(rel) ? rel : path.join(root, rel);
@@ -358,7 +507,26 @@ function meetingOptionsFromConfig(cfg: any): Record<string, any>[] {
   ];
 }
 
-export function context({ spec_path, plan_path, issue_id, issue_url, issue_ref, mode, workspace_root }: { spec_path?: string; plan_path?: string; issue_id?: string; issue_url?: string; issue_ref?: string; mode?: string; workspace_root: string }, scripts: YouTrackScripts = defaultScripts): Record<string, any> {
+export function context(
+  {
+    spec_path,
+    plan_path,
+    issue_id,
+    issue_url,
+    issue_ref,
+    mode,
+    workspace_root,
+  }: {
+    spec_path?: string;
+    plan_path?: string;
+    issue_id?: string;
+    issue_url?: string;
+    issue_ref?: string;
+    mode?: string;
+    workspace_root: string;
+  },
+  scripts: YouTrackScripts = defaultScripts,
+): Record<string, any> {
   const cfg = scripts.config();
   if (cfg.error) return { error: cfg.error };
 
@@ -390,7 +558,8 @@ export function context({ spec_path, plan_path, issue_id, issue_url, issue_ref,
   if (!issue) issue = resolveYouTrackFromPaths(spec_path, plan_path, workspace_root) ?? undefined;
   if (!issue || !ISSUE_RE.test(issue)) {
     return {
-      error: "invalid or missing issue id — pass issue_url, issue_id, or spec/plan with **YouTrack:**",
+      error:
+        "invalid or missing issue id — pass issue_url, issue_id, or spec/plan with **YouTrack:**",
       requiresIssueInput: true,
     };
   }
@@ -411,39 +580,86 @@ export function context({ spec_path, plan_path, issue_id, issue_url, issue_ref,
   };
 }
 
-export function parseDuration(text: string, _workspace_root: string, scripts: YouTrackScripts = defaultScripts): Record<string, any> {
+export function parseDuration(
+  text: string,
+  _workspace_root: string,
+  scripts: YouTrackScripts = defaultScripts,
+): Record<string, any> {
   const out = scripts.parseDuration(text);
   if (out.error) return { error: out.error };
   return out.data;
 }
 
-export function logTime({ issueId, minutes, text, date, dateMs, workspace_root }: { issueId: string; minutes: number; text?: string; date?: string; dateMs?: number; workspace_root: string }, scripts: YouTrackScripts = defaultScripts): Record<string, any> {
+export async function logTime(
+  {
+    issueId,
+    minutes,
+    text,
+    date,
+    dateMs,
+    workspace_root: _workspace_root,
+  }: {
+    issueId: string;
+    minutes: number;
+    text?: string;
+    date?: string;
+    dateMs?: number;
+    workspace_root: string;
+  },
+  scripts: YouTrackScripts = defaultScripts,
+): Promise<Record<string, any>> {
   if (!issueId || !ISSUE_RE.test(issueId)) return { error: "invalid issueId" };
   if (!minutes || minutes <= 0) return { error: "minutes must be positive" };
   const workText = text ?? "workit";
   const dateArg =
-    dateMs != null
-      ? String(dateMs)
-      : date && /^\d+$/.test(String(date))
-        ? String(date)
-        : "auto";
-  const out = scripts.api(["log-time", issueId, String(minutes), workText, dateArg]);
+    dateMs != null ? String(dateMs) : date && /^\d+$/.test(String(date)) ? String(date) : "auto";
+  const out = await scripts.api(["log-time", issueId, String(minutes), workText, dateArg]);
   if (out.error) return { error: out.error };
   return { issueId, minutes, text: workText, ...out.data, ok: true };
 }
 
-
-export function buildDraft({ issueId, projectName, userNotes, greeting, facts, includeProjectOpener, includeFacts }: { issueId: string; projectName?: string; userNotes?: string; greeting?: string; facts?: any; includeProjectOpener?: boolean; includeFacts?: boolean }): Record<string, any> {
+export function buildDraft({
+  issueId,
+  projectName,
+  userNotes,
+  greeting,
+  facts,
+  includeProjectOpener,
+  includeFacts,
+}: {
+  issueId: string;
+  projectName?: string;
+  userNotes?: string;
+  greeting?: string;
+  facts?: any;
+  includeProjectOpener?: boolean;
+  includeFacts?: boolean;
+}): Record<string, any> {
   const tpl = readTemplate("issue-update").content;
   const para = (value: string): string => (value ? `\n\n${value}` : "");
   const filled = tpl
     .replaceAll("{{greetingSection}}", para(greeting ? `${greeting}` : ""))
-    .replaceAll("{{projectSection}}", para(includeProjectOpener && projectName ? `Hoy estuve full con ${projectName}.` : ""))
+    .replaceAll(
+      "{{projectSection}}",
+      para(includeProjectOpener && projectName ? `Hoy estuve full con ${projectName}.` : ""),
+    )
     .replaceAll("{{userNotesSection}}", para((userNotes ?? "").trim()))
-    .replaceAll("{{progressSection}}", para(includeFacts && facts?.progress_excerpt?.length
-      ? facts.progress_excerpt.map((l: string) => `- ${l}`).join("\n") : ""))
-    .replaceAll("{{gitCommitsSection}}", para(includeFacts && facts?.git_commits?.length
-      ? facts.git_commits.map((c: string) => `- ${c}`).join("\n") : ""));
+    .replaceAll(
+      "{{progressSection}}",
+      para(
+        includeFacts && facts?.progress_excerpt?.length
+          ? facts.progress_excerpt.map((l: string) => `- ${l}`).join("\n")
+          : "",
+      ),
+    )
+    .replaceAll(
+      "{{gitCommitsSection}}",
+      para(
+        includeFacts && facts?.git_commits?.length
+          ? facts.git_commits.map((c: string) => `- ${c}`).join("\n")
+          : "",
+      ),
+    );
   const collapsed = filled.replace(/\n{3,}/g, "\n\n").trimEnd();
   // Bare draft keeps the header's trailing blank line (matches legacy output);
   // drafts with sections end right after the last one.
@@ -451,20 +667,37 @@ export function buildDraft({ issueId, projectName, userNotes, greeting, facts, i
   return { issueId, markdown };
 }
 
-export function postUpdate({ confirmed, issueId, markdown, minutes, workspace_root }: { confirmed: boolean; issueId: string; markdown: string; minutes?: number; workspace_root?: string }, operations?: Record<string, any>): Record<string, any> {
+export async function postUpdate(
+  {
+    confirmed,
+    issueId,
+    markdown,
+    minutes,
+    workspace_root,
+  }: {
+    confirmed: boolean;
+    issueId: string;
+    markdown: string;
+    minutes?: number;
+    workspace_root?: string;
+  },
+  operations?: Record<string, any>,
+): Promise<Record<string, any>> {
   operations ??= {};
   if (!confirmed) return { error: "confirmed: true required" };
   if (!issueId || !ISSUE_RE.test(issueId)) return { error: "invalid issueId" };
   if (!markdown?.trim()) return { error: "markdown required" };
 
-  const postComment = operations.postComment ?? ((id: string, text: string, root: string) =>
-    youTrackApi(["post-comment", id, text], process.env.WORKFLOW_YT_WRITE ?? ""));
+  const postComment =
+    operations.postComment ??
+    ((id: string, text: string, _root: string) =>
+      youTrackApi(["post-comment", id, text], process.env.WORKFLOW_YT_WRITE ?? ""));
   const logTimeOperation = operations.logTime ?? logTime;
-  const comment = postComment(issueId, markdown, workspace_root);
+  const comment = await postComment(issueId, markdown, workspace_root);
   if (comment.error) return { error: comment.error };
 
   if (minutes && minutes > 0) {
-    const time = logTimeOperation({
+    const time = await logTimeOperation({
       issueId,
       minutes,
       text: "workit update",