@bongos/core 1.24.92 → 1.24.94

package/tests/room_kinds_seam.mjs

@@ -0,0 +1,68 @@
+// tests/room_kinds_seam.mjs — ADR 0404 (task 1005220): rooms register as kinds
+// through the 'room.kinds' CONTRIBUTION POINT, because several modules own a kind
+// (lifecycle: party, chain, scoping; government: decision) and a port is
+// single-provider. Pins that choice: two kinds from two modules register side by
+// side and the boot check still passes, while the same pair as a port is refused.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const seams = require(path.join(ROOT, 'src', 'module-seams.js'));
+
+function kind(name, owner, members) {
+  return {
+    kind: name,
+    owner,
+    cap: name === 'party' ? 8 : 40,
+    members: async () => members,
+    isMember: async (_roomId, builderId) => members.some((m) => m.builderId === builderId),
+  };
+}
+
+test('two kinds from two modules both register, and the boot check passes', async () => {
+  seams._reset();
+  seams.contribute('room.kinds', kind('scoping', 'lifecycle', [{ builderId: 1, joinedAt: 't' }]));
+  seams.contribute('room.kinds', kind('decision', 'government', [{ builderId: 2, joinedAt: 't' }]));
+
+  const kinds = seams.contributions('room.kinds');
+  assert.deepEqual(kinds.map((k) => k.kind), ['scoping', 'decision']);
+  assert.deepEqual(kinds.map((k) => k.owner), ['lifecycle', 'government']);
+
+  // a consumer finds a kind by name and calls it — it never reads the owner's tables
+  const decision = kinds.find((k) => k.kind === 'decision');
+  assert.equal(await decision.isMember('r1', 2), true);
+  assert.equal(await decision.isMember('r1', 1), false);
+
+  // the modules' manifests declare no port for rooms, so the boot check is clean
+  const manifests = [
+    { key: 'lifecycle', provides: [], consumes: [] },
+    { key: 'government', provides: [], consumes: [] },
+  ];
+  assert.deepEqual(seams.verifyPortsSatisfied(manifests), { ok: true, errors: [] });
+  seams._reset();
+});
+
+test('the rejected design: the same pair as one port is refused at boot and at registration', () => {
+  seams._reset();
+  const manifests = [
+    { key: 'lifecycle', provides: ['room.members'], consumes: [] },
+    { key: 'government', provides: ['room.members'], consumes: [] },
+  ];
+  const res = seams.verifyPortsSatisfied(manifests);
+  assert.equal(res.ok, false);
+  assert.match(res.errors.join('\n'), /room\.members.*more than one enabled module/);
+
+  seams.registerProvider('room.members', async () => []);
+  assert.throws(() => seams.registerProvider('room.members', async () => []));
+  seams._reset();
+});
+
+test('an instance with no room owners has no rooms, and nothing throws', () => {
+  seams._reset();
+  assert.deepEqual(seams.contributions('room.kinds'), []);
+  seams._reset();
+});