@bongos/core 1.24.92 → 1.24.94

package/modules/hall-ui/public/home-gallery.js

@@ -122,6 +122,29 @@
     var room = root.querySelector('.hg-room'), track = root.querySelector('.hg-track'), salon = root.querySelector('.hg-salon');
     var prev = root.querySelector('.hg-prev'), next = root.querySelector('.hg-next'), count = root.querySelector('.hg-count');
     var wayAll = root.querySelector('.hg-way-all'), empty = root.querySelector('.hg-empty');
+    var fsbtn = root.querySelector('.hg-fsbtn'), studio = root.querySelector('a.hg-way');
+    // task 1005211 (ADR 0403): in game mode the gallery's tabs, ways, arrows and full-screen
+    // button are the visor's (home-gallery.css hides them under html.visor-on). These are
+    // their rows, each pressing the gallery's own control, in the control's own words; Home
+    // (home-city.js) registers them as the scene's actions and asks again when they change.
+    var changed = function () {};
+    function visorActions() {
+      if (root.hidden) return [];
+      var all = room.classList.contains('is-all');
+      var out = [{ label: wayAll.firstChild.textContent.trim(), key: 'g', bind: true, lead: true, run: function () { wayAll.click(); room.focus(); } }];
+      root.querySelectorAll('.hg-sort button').forEach(function (b) {
+        out.push({ label: b.textContent + (b.getAttribute('aria-pressed') === 'true' ? ' · on' : ' · off'), run: function () { b.click(); } });
+      });
+      // the wall's own keys answer once the room has the keyboard, so a row hands it over
+      if (!all && list.length) {
+        out.push({ label: prev.getAttribute('aria-label'), key: '←', run: function () { prev.click(); room.focus(); } });
+        out.push({ label: next.getAttribute('aria-label'), key: '→', run: function () { next.click(); room.focus(); } });
+        out.push({ label: 'Full screen', key: 'F', run: function () { fsbtn.click(); room.focus(); } });
+      }
+      var href = studio.getAttribute('href');
+      out.push({ label: studio.firstChild.textContent.trim(), run: function () { window.location.assign(href); } });
+      return out;
+    }
     room.setAttribute('aria-label', ROOM_LABEL);
 
     function hang(w, i) {
@@ -239,6 +262,7 @@
       wayAll.firstChild.textContent = on ? 'Back to the bench ' : 'The full gallery ';
       room.setAttribute('aria-label', on ? ALL_LABEL : ROOM_LABEL);
       if (on) renderSalon();
+      changed();
     }
 
     // ---- full screen: the art alone, with its signature and heart ----
@@ -264,6 +288,7 @@
         if (order === b.dataset.order) return;
         order = b.dataset.order;
         root.querySelectorAll('.hg-sort button').forEach(function (x) { x.setAttribute('aria-pressed', String(x === b)); });
+        changed();
         load();
       });
     });
@@ -327,6 +352,7 @@
         if (mine !== asking) return;
         list = res && res.ok && res.data && Array.isArray(res.data.works) ? res.data.works.filter(function (w) { return w && w.id && w.artist; }) : [];
         render();
+        changed();
         if (first) { first = false; arrive(); }
       }, function () { if (mine === asking) { list = []; render(); } });
     }
@@ -348,7 +374,11 @@
         root.hidden = !on;
         if (on && !loaded) load();
         if (!on && isFs()) setFs(false);
+        changed();
       },
+      // task 1005211: the rows the visor shows for the gallery, and a hook for when they change
+      visorActions: visorActions,
+      onChange: function (fn) { changed = typeof fn === 'function' ? fn : function () {}; },
     };
   }
 

package/modules/hall-ui/public/sky-interaction.js

@@ -13,7 +13,7 @@
 // `filed_via` exists on at least one thought; until then it is hidden and
 // every thought shows (the README's "must not ship" row).
 //
-// Keys: L the list, ? the tour, 0 fit, / the composer, Escape closes, arrows
+// Keys: L the list, ? the tour, 0 fit, / the composer (J jumps, from the visor in game mode), Escape closes, arrows
 // pan, + and - zoom.
 
 (() => {
@@ -75,11 +75,11 @@
   // An Escape the sky USED (the tour, the menu, a pick) calls preventDefault, so
   // the shell's full-screen switch leaves that press alone (task 1004327).
   addEventListener('keydown', (e) => {
-    if (e.target && (e.target.tagName === 'INPUT' || e.target.tagName === 'TEXTAREA')) { if (e.key === 'Escape') e.target.blur(); return; }
+    if (e.target && (e.target.tagName === 'INPUT' || e.target.tagName === 'TEXTAREA')) { if (e.key === 'Escape') { e.target.blur(); if (e.target.id === 'thought' || e.target.id === 'jump') { e.preventDefault(); if (SKY.closeField) SKY.closeField(e.target.id, true); } } return; }
     const { cam } = S; const step = 60 / cam.k;
     if (e.key === 'ArrowLeft') { cam.x -= step; S.dirty = true; } else if (e.key === 'ArrowRight') { cam.x += step; S.dirty = true; } else if (e.key === 'ArrowUp') { cam.y -= step; S.dirty = true; } else if (e.key === 'ArrowDown') { cam.y += step; S.dirty = true; }
     else if (e.key === '+' || e.key === '=') { cam.k = clamp(cam.k * 1.3, .015, 9); S.dirty = true; } else if (e.key === '-') { cam.k = clamp(cam.k / 1.3, .015, 9); S.dirty = true; }
-    else if (e.key === '0') SKY.fitAll(); else if (e.key === 'Escape') { if (!$('tour').hidden) { e.preventDefault(); SKY.endTour(); } else if (!menu.hidden) { e.preventDefault(); hideMenu(); } else { if (S.picked || !$('panel').hidden) e.preventDefault(); pick(null); } } else if (e.key === '/') { e.preventDefault(); $('thought').focus(); }
+    else if (e.key === '0') SKY.fitAll(); else if (e.key === 'Escape') { if (!$('tour').hidden) { e.preventDefault(); SKY.endTour(); } else if (!menu.hidden) { e.preventDefault(); hideMenu(); } else { if (S.picked || !$('panel').hidden) e.preventDefault(); pick(null); } } else if (e.key === '/') { e.preventDefault(); if (SKY.openField) SKY.openField('thought'); else $('thought').focus(); }
     else if (e.key === '?') SKY.startTour(); else if (e.key.toLowerCase() === 'l') SKY.toggleRoom(); else return;
   });
   function pick(h, fly) { if (h && h.kind === 'ltask') { SKY.renderPanel({ kind: 'ltask', ref: h.ref }); S.dirty = true; return; } S.picked = h; SKY.renderPanel(S.picked); SKY.renderRoom(); S.dirty = true; if (fly && S.picked && S.lens !== 'simple') { if (S.picked.kind === 'goal') SKY.fitGoal(S.picked.ref); else if (S.picked.kind === 'idea') SKY.fitThought(S.picked.ref); } }
@@ -148,10 +148,5 @@
 
   Object.assign(SKY, { card, menu, glyphHtml, ideaTitle, sizeWords, showCard, showMenu, hideMenu, pick, setLens, togglePill, updateStats, altText, TAU, hash });
 
-  // task 1005148: the sky as the visor's scene (ADR 0399 §2.2). The visor owns no camera:
-  // "Back to centre" is the camera's own fitAll, and the keys listed are the ones bound above.
-  window.__visorScene = { name: 'sky', place: '', // the sky's own heading names the place
-    actions: [{ label: 'Back to centre', key: '0', run: () => SKY.fitAll() }],
-    keys: [{ label: 'Look around', key: 'drag' }, { label: 'List view', key: 'L' }, { label: 'Search', key: '/' }, { label: 'Take the tour', key: '?' }] };
-  if (window.OTBVisor) window.OTBVisor.scene(window.__visorScene);
+  // task 1005148 / 1005210: the sky as the visor's scene lives in sky-visor.js, after this file.
 })();

package/modules/hall-ui/public/sky-visor.js

@@ -0,0 +1,96 @@
+// modules/hall-ui/public/sky-visor.js — THE SKY as the visor's scene (task 1005148; task
+// 1005210, ADR 0403). Loaded after sky-interaction.js on /goal-map and /thinking.
+//
+// The visor owns no camera (ADR 0399 §2.2): every action here presses one of the sky's own
+// controls or opens one of its own fields, so a pill does exactly what it did in classic mode.
+(() => {
+  'use strict';
+
+  const SKY = window.OTBSky; const S = SKY.S;
+  const { $, on } = SKY;
+
+  // task 1005210 (ADR 0403): in game mode the visor is the control and the sky is the view. Its
+  // top row (the lens switch and every pill), the jump field and the thought composer leave the
+  // scene (thinking.css, html.visor-on) and come back as visor actions: writing a thought is the
+  // lead action, on the sky's own "/"; jumping is J; each pill is a row in the Actions sheet
+  // that presses the pill itself, so a pill does exactly what it did. The rows are read off the
+  // page's own buttons (their words, their pressed state, whether this lens shows them), and the
+  // scene registers again whenever one of those changes. Panning, zooming and picking a star
+  // stay in the sky. In classic mode nothing here shows or moves.
+  const FIELDS = ['thought', 'jump'];
+  function fieldWrap(id) { const el = $(id); return el && el.closest ? el.closest('.composer, .jump') : null; }
+  function openField(id) {
+    for (const other of FIELDS) if (other !== id) closeField(other, true);
+    const wrap = fieldWrap(id); if (wrap) wrap.classList.add('is-open');
+    $(id).focus();
+  }
+  // A field closes when it is left with nothing in it, or on Escape (its words are kept).
+  // The composer stays while a full idea is being asked or a receipt waits to be read.
+  function closeField(id, force) {
+    const wrap = fieldWrap(id); if (!wrap || !wrap.classList.contains('is-open')) return;
+    if (!force) {
+      if (wrap.contains(document.activeElement)) return;
+      if ($(id).value.trim()) return;
+      if (id === 'thought' && (!$('fullSteps').hidden || !$('receipt').hidden)) return;
+    }
+    wrap.classList.remove('is-open');
+  }
+  for (const id of FIELDS) {
+    const wrap = fieldWrap(id); if (!wrap) continue;
+    wrap.addEventListener('focusout', () => setTimeout(() => closeField(id), 0));
+  }
+  on('receiptX', 'click', () => setTimeout(() => closeField('thought'), 0));
+  // the sky binds these keys itself (sky-interaction.js); the rest are rows in the sheet
+  const OWN_KEYS = { roomBtn: 'L', tourBtn: '?', fitBtn: '0' };
+  function visible(el) { return !!el && !el.hidden && !(el.closest && el.closest('[hidden]')); }
+  function rowFor(b) {
+    const words = (b.textContent || '').trim();
+    const name = words.length > 1 ? words : (b.getAttribute('aria-label') || b.getAttribute('title') || '');
+    const pressed = b.getAttribute('aria-pressed');
+    const label = name.charAt(0).toUpperCase() + name.slice(1) + (pressed == null ? '' : pressed === 'true' ? ' · on' : ' · off');
+    return { label, key: OWN_KEYS[b.id] || '', run: () => b.click() };
+  }
+  // The foot's clock and legend are the sky's too: in game mode each shows only while the visor
+  // has it open (thinking.css), so the scene carries none of their buttons until asked.
+  function footOpen(id) { const el = $(id); return !!el && el.classList.contains('is-open'); }
+  function footRow(id, name) {
+    return { label: name + (footOpen(id) ? ' · on' : ' · off'), key: '', run: () => {
+      const el = $(id); if (!el) return;
+      const open = !el.classList.contains('is-open');
+      el.classList.toggle('is-open', open);
+      // a clock classic mode was told to hide comes back through its own pill
+      if (open && el.hidden && id === 'time') $('clockBtn').click();
+    } };
+  }
+  function skyScene() {
+    const actions = [{ label: 'Write a thought', key: '/', lead: true, run: () => openField('thought') }];
+    if (visible(fieldWrap('jump'))) actions.push({ label: 'Jump to a goal or a thought', key: 'j', bind: true, run: () => openField('jump') });
+    document.querySelectorAll('#lensGroup button, #tools button').forEach((b) => {
+      if (!visible(b)) return;
+      // the clock pill keeps classic mode's remembered choice; in game mode the clock opens from here
+      if (b.id === 'clockBtn') { actions.push(footRow('time', 'Clock')); return; }
+      actions.push(rowFor(b));
+    });
+    if (visible($('legend'))) actions.push(footRow('legend', 'Legend'));
+    return { name: 'sky', place: '', // the sky's own heading names the place
+      actions, keys: [{ label: 'Look around', key: 'drag' }, { label: 'Zoom', key: '+ −' }] };
+  }
+  let sceneSig = null;
+  function registerScene() {
+    const next = skyScene();
+    const sig = next.actions.map((a) => a.label + '|' + a.key).join('\n');
+    if (sig === sceneSig) return;
+    sceneSig = sig;
+    window.__visorScene = next;
+    if (window.OTBVisor) window.OTBVisor.scene(next);
+  }
+  // a pill's pressed state or a lens's set of pills changed: the sheet follows
+  if (typeof MutationObserver === 'function') {
+    const watch = new MutationObserver(registerScene);
+    for (const id of ['tools', 'lensGroup']) { const el = $(id); if (el) watch.observe(el, { subtree: true, attributes: true, attributeFilter: ['aria-pressed', 'hidden'] }); }
+    const jump = fieldWrap('jump'); if (jump) watch.observe(jump, { attributes: true, attributeFilter: ['hidden'] });
+    for (const id of ['time', 'legend']) { const el = $(id); if (el) watch.observe(el, { attributes: true, attributeFilter: ['class', 'hidden'] }); }
+  }
+  Object.assign(SKY, { openField, closeField, skyScene });
+  registerScene();
+})();

package/modules/hall-ui/public/thinking.css

@@ -315,3 +315,11 @@ html.visor-on .composer, html.visor-on .jump { top: calc(140px + env(safe-area-i
 html.visor-on .panel, html.visor-on .room { top: calc(204px + env(safe-area-inset-top, 0px)); bottom: calc(200px + env(safe-area-inset-bottom, 0px)); }
 html.visor-on .foot { padding-bottom: calc(132px + env(safe-area-inset-bottom, 0px)); }
 html.visor-on .tour, html.visor-on .start { bottom: calc(210px + env(safe-area-inset-bottom, 0px)); }
+/* task 1005210 (ADR 0403): with the visor up the sky carries no control of its own. The top
+   row's lens switch and pills are rows in the visor's Actions sheet; the composer and the jump
+   field open from the visor ("Write a thought" on /, "Jump" on J) and close again when left
+   empty (sky-interaction.js openField / closeField). The brand and its figures stay, as words. */
+html.visor-on .top .tools, html.visor-on .top .lens { display: none; }
+html.visor-on .composer:not(.is-open), html.visor-on .jump:not(.is-open) { display: none; }
+html.visor-on .jump.is-open:not([hidden]) { display: block; }
+html.visor-on .time:not(.is-open), html.visor-on .legend:not(.is-open) { display: none; }

package/modules/hall-ui/public/thinking.html

@@ -159,5 +159,7 @@
 <script src="/builders/sky-panel.js?v=2026-09-30-uat1"></script>
 <script src="/builders/sky-composer.js?v=2026-09-27-split"></script>
 <script src="/builders/sky-tour.js?v=2026-09-27-split"></script>
+<!-- task 1005210: the sky as the visor's scene (ADR 0403), after every other sky file -->
+<script src="/builders/sky-visor.js"></script>
 </body>
 </html>

package/modules/hall-ui/public/visor.js

@@ -274,7 +274,8 @@
     sheet.setAttribute('role', 'dialog');
     sheet.setAttribute('aria-labelledby', 'visor-sheet-title');
     sheet.innerHTML = sheetHtml(id);
-    sheet.addEventListener('click', onClick);
+    // no listener of its own: the sheet sits inside #visor, whose click listener already
+    // sees its rows (a second one ran every row twice, so a toggle undid itself; task 1005210)
     root.appendChild(sheet);
     var btn = root.querySelector('[data-visor-sheet]');
     if (btn) { btn.setAttribute('aria-expanded', 'true'); btn.hidden = true; }

package/modules/hall-ui/records/visor.md

@@ -1,16 +1,30 @@
 # The visor — the first-person HUD over every scene (task 1005148, BONGOS-V3 R08; ADR 0399)
 
-Covers: `visor.js` + `visor.css`, loaded on Home, `/city`, `/goal-map` and `/thinking`, and the three scene registrations (`sky-interaction.js`, `city.js`, `home-city.js`). Spec: `docs/specs/bongos-v3-game-conversion.md` C2 `you-are-a-character-in-first-person`. Game mode itself is in `game-mode.md`.
+Covers: `visor.js` + `visor.css`, loaded on Home, `/city`, `/goal-map` and `/thinking`, and the three scene registrations (`sky-visor.js`, `city.js`, `home-city.js`). Spec: `docs/specs/bongos-v3-game-conversion.md` C2 `you-are-a-character-in-first-person`. Game mode itself is in `game-mode.md`.
 
 ## The rule every game page keeps (ADR 0403, owner 2026-11-11)
 
-The visor is the control and the scene is the view: every main call to action in game mode is on the glass (the accent button, the key hints, the Actions sheet), and a scene carries none of its own. A scene that has something to do registers it with `OTBVisor.scene({ actions, keys })`. ADR 0403 §3 lists the scenes that do not keep it yet; the Governor City keeps it since task 1005209 (below).
+The visor is the control and the scene is the view: every main call to action in game mode is on the glass (the accent button, the key hints, the Actions sheet), and a scene carries none of its own. A scene that has something to do registers it with `OTBVisor.scene({ actions, keys })`. ADR 0403 §3 lists the scenes that do not keep it yet; the Governor City keeps it since task 1005209 the sky since task 1005210, and Home's gallery since task 1005211 (below).
 
 ## A place's own buttons on the glass (task 1005209, the Governor City first)
 
 - **The scene contract grew two flags.** A scene action's `key` is still a key the scene binds itself, shown beside it in the sheet. With `bind: true` the visor binds that key instead, after the character's keys (a clash goes to the character), for a scene button that had no key of its own. With `lead: true` the action is also the first quiet key hint on the glass (`.visor__hint--place`). Every scene action is still a row under "This place" in the sheet.
 - **The glass binds keys in game mode only.** `onKey` now returns unless `html[data-game="on"]`: the glass was never drawn outside game mode, so its keys no longer act there either (before, a held character's letter keys still ran on a classic page).
-- **The Governor City keeps ADR 0403.** In game mode (`html.visor-on`) the door's button (`#cityStart`) and the archived Street links leave the scene (`city.css`). The door is the lead action, on D, in the door's own words ("Decide 37 in a row", or "Start governing"); it re-registers only when those words change. The archived links are rows in the sheet ("Archived: Street", "Archived: Building Level Views"), read off the page's own archived line so the words and the addresses cannot drift; reached by A and the keyboard. The city line stays on the scene as words, raised to `bottom: 224px` because the extra hint wraps the hints onto a second line at a desk width and the centred accent button rises with it. A building's card is a pop-up, not the scene, and keeps its own buttons and keys. Classic mode is as it was.
+- **The Governor City keeps ADR 0403.** In game mode (`html.visor-on`) the door's button (`#cityStart`) and the archived Street links leave the scene (`city.css`). The door is the lead action, on D, in the door's own words and case ("decide 37 in a row", or "start governing"; lowercase is the door's, task 1005210); it re-registers only when those words change. The archived links are rows in the sheet ("Archived: Street", "Archived: Building Level Views"), read off the page's own archived line so the words and the addresses cannot drift; reached by A and the keyboard. The city line stays on the scene as words, raised to `bottom: 224px` because the extra hint wraps the hints onto a second line at a desk width and the centred accent button rises with it. A building's card is a pop-up, not the scene, and keeps its own buttons and keys. Classic mode is as it was.
+
+## The sky on the glass (task 1005210)
+
+- **What left the sky in game mode** (`thinking.css`, under `html.visor-on`): the top row's lens switch and every pill, the jump field, the thought composer, and the foot's clock and legend. The brand line and its figures stay, as words. A building-like pop-up (the panel, the list, the start dialog, the tour) is not the scene and keeps its buttons.
+- **Where it went** (`sky-visor.js`, loaded after every other sky file; the registration moved out of `sky-interaction.js`). "Write a thought" is the lead action, on the sky's own `/`; "Jump to a goal or a thought" is J (bound by the visor). Each visible pill is a row in the sheet, in its own words with "· on" / "· off" for a toggle, and pressing the row presses the pill, so it does exactly what it did; List, the tour and Fit keep the sky's own L, ? and 0. "Clock" and "Legend" open the foot's two parts. The rows are read off the page's buttons and the scene registers again when a pill's pressed state, a pill's presence (the lens decides it) or the foot changes.
+- **The fields open and close.** A field opens with `is-open` (one at a time) and closes when focus leaves it empty, or on Escape, which keeps its words and is spent there (no options menu). The composer stays open while a full idea is being asked or a receipt waits.
+- **A visor fix that came with it.** The sheet had a click listener of its own inside `#visor`'s, so every row ran twice; a toggle row undid itself. The sheet's listener is gone.
+- **Not done:** the tour still spots the pills it explains, which are off the glass in game mode. Tests: `tests/hall_sky_visor.mjs` (both pages' own markup, the real visor and sheets, in a real browser).
+
+## Home's gallery on the glass (task 1005211)
+
+- **What left the gallery in game mode** (`home-gallery.css`, under `html.visor-on`): the order tabs (Most popular, Latest), the ways (The full gallery, Your studio), the two arrows and the full-screen button. A work's label, its heart and a piece in the full gallery stay: they are looking at the art, not leaving it.
+- **Where they went.** `home-gallery.js` gives Home its rows (`visorActions()`, and `onChange()` for when they change), each pressing the gallery's own control in its own words: the full gallery (or "Back to the bench") is the lead on G; the two tabs with "· on/off"; Previous work ←, Next work →, Full screen F, which hand the wall the keyboard so its own keys answer next; Your studio. `home-city.js` registers them as Home's scene, and none in a craft whose Home is not the gallery.
+- **Not done:** the attention cards and the Artist's idea box on Home are not the gallery's and still sit on the scene in game mode.
 
 ## The minimal visor (Helm look 3, task 1005195)
 

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.92",
+  "version": "1.24.94",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.24.92",
+      "version": "1.24.94",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.24.92",
+  "version": "1.24.94",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/release-notes.json

@@ -11657,5 +11657,25 @@
       "id": "1005206",
       "text": "The screen you land on after signing in, where you pick Game or Classic, now looks like the V3 game start menu: your usual choice is the bright salmon bar with its Enter key, the other a quiet row."
     }
+  ],
+  "1.24.93": [
+    {
+      "id": "1005210",
+      "text": "In game mode the sky (Goals and Thinking) no longer has buttons of its own: \"Write a thought\" is on the visor (press /), jumping is J, and the lens switch, the pills, the clock and the legend are rows in the visor's Actions li"
+    }
+  ],
+  "1.24.94": [
+    {
+      "id": "1005247",
+      "text": "The V3 game plan now records the owner's eight answers from the task cleanup, so new work is written against them."
+    },
+    {
+      "id": "1005211",
+      "text": "In game mode the Artist's Home gallery no longer has tabs, links or arrows of its own: the full gallery is on the visor (press G), and the order tabs, previous/next work, full screen and Your studio are rows in the visor's Act"
+    },
+    {
+      "id": "1005220",
+      "text": "The game's parties now have one agreed design: any group that plays together gets the same voice channel, member list and chat, whether it's a party you form, a quest party or a meeting room."
+    }
   ]
 }

package/src/module-api.js

@@ -81,7 +81,7 @@ const { sleep } = require('./sleep');
 // MAJOR (see allowBoxScope below): passes the request through untouched.
 function deprecatedNoopMiddleware(_req, _res, next) { next(); }
 
-const CORE_VERSION = '1.24.92'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.24.94'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('discord'); log.info('mounted');

package/src/module-seams.js

@@ -190,6 +190,9 @@ function listEvents() {
 //                         the slices merge into the GET /api/bongos/me payload.
 //                         (The client settings-panel seam is its browser twin,
 //                          window.OTB.contributeSettingsPanel in dom-utils.js.)
+//   • 'room.kinds'      — one plain object per kind of room (party, chain, scoping,
+//                         decision), contributed by the module that owns the group;
+//                         read with contributions('room.kinds'). ADR 0404.
 
 const contributors = new Map(); // point -> [contribution, ...] (registration order)
 

package/tests/hall_city.mjs

@@ -514,7 +514,7 @@ test("game mode: the door is the visor's lead action on D, and the archived link
   const last = scenes[scenes.length - 1];
   assert.equal(last.place, 'Governor city');
   const [lead, street, views] = last.actions;
-  assert.equal(lead.label, 'Start governing', 'what the door says, before the living city reads who it waits on (hall_city_living pins the count)');
+  assert.equal(lead.label, 'start governing', 'what the door says, before the living city reads who it waits on (hall_city_living pins the count)');
   assert.deepEqual([lead.key, lead.bind, lead.lead], ['d', true, true], 'it is on the glass, and D (which nothing else binds) presses it');
   assert.deepEqual([street.label, views.label], ['Archived: Street', 'Archived: Building Level Views'], "the line's own words, read off the page");
   assert.ok(!street.lead && !views.lead && !street.bind && !views.bind, 'the archived links are rows in the sheet, reached by A then the keyboard');

package/tests/hall_sky_visor.mjs

@@ -0,0 +1,150 @@
+// tests/hall_sky_visor.mjs — the sky as the visor's scene in game mode (task 1005210; ADR 0403).
+//
+// In game mode the visor is the control and the sky is the view: the sky's top row, its jump
+// field, its thought composer and its foot's clock and legend leave the scene and come back as
+// visor actions (sky-visor.js, thinking.css). Driven in a real browser over the page's OWN
+// markup (goal-map.html's and thinking.html's <main>, word for word) with the real visor and
+// the hall's real sheets. The pills are wired here the way sky-interaction.js wires them (a
+// press flips aria-pressed), because what is under test is the visor's side: that each pill is
+// a row, that a row presses its pill exactly once, and that the rows follow the pills.
+import assert from 'node:assert/strict';
+import { test, after } from 'node:test';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const HALL = path.join(ROOT, 'modules/hall-ui/public');
+const read = (f) => fs.readFileSync(path.join(HALL, f), 'utf8');
+
+test('source: both sky pages load sky-visor.js after every other sky file', () => {
+  for (const p of ['goal-map.html', 'thinking.html']) {
+    const html = read(p);
+    const at = html.indexOf('/builders/sky-visor.js');
+    assert.ok(at > 0, `${p} loads it`);
+    for (const f of ['sky-interaction.js', 'sky-panel.js', 'sky-composer.js', 'sky-tour.js']) assert.ok(html.indexOf('/builders/' + f) < at, `${p}: after ${f}`);
+  }
+  assert.doesNotMatch(read('sky-interaction.js'), /window\.__visorScene = /, 'one registration, in sky-visor.js');
+});
+
+test('source: the sky keeps its controls in classic mode; in game mode they open from the visor', () => {
+  const css = read('thinking.css');
+  for (const rule of [
+    'html.visor-on .top .tools, html.visor-on .top .lens { display: none; }',
+    'html.visor-on .composer:not(.is-open), html.visor-on .jump:not(.is-open) { display: none; }',
+    'html.visor-on .time:not(.is-open), html.visor-on .legend:not(.is-open) { display: none; }',
+  ]) assert.ok(css.includes('\n' + rule), rule);
+});
+
+// ---------- in a browser ----------
+const lib = require(path.join(ROOT, 'modules', 'ui-design', 'kit', 'lib.js'));
+let browser = null;
+try { browser = await lib.launchBrowser(); } catch (e) { if (!(e instanceof lib.NoBrowserError)) throw e; }
+after(() => browser && browser.close());
+const skip = !browser && 'no system Edge or Chrome';
+
+const ORIGIN = 'http://hall.test';
+const TYPES = { '.js': 'text/javascript', '.css': 'text/css', '.png': 'image/png' };
+const mainOf = (page) => { const html = read(page); return html.slice(html.indexOf('<main'), html.indexOf('</main>') + 7); };
+// The sky's own wiring, as far as the visor needs it: SKY.$ / on / S, and a press that flips.
+const STUB = `<script>
+  window.OTB = { escapeHtml: (s) => String(s) };
+  window.OTBCraftMode = { character() { return 'artist'; }, current() { return null; }, me() { return { builder: { total_credits: 10 } }; }, spriteSrc() { return ''; }, openTool() {} };
+  const $ = (id) => document.getElementById(id);
+  window.OTBSky = { $, on: (id, ev, fn) => { const el = $(id); if (el) el.addEventListener(ev, fn); }, S: { clockHidden: false } };
+  window.presses = {};
+  document.querySelectorAll('#tools button, #lensGroup button').forEach((b) => b.addEventListener('click', () => {
+    window.presses[b.id] = (window.presses[b.id] || 0) + 1;
+    if (b.hasAttribute('aria-pressed')) b.setAttribute('aria-pressed', String(b.getAttribute('aria-pressed') !== 'true'));
+  }));
+</script>`;
+const PAGE = (page, game) => `<!doctype html><html data-theme="dark" data-faces="helm"${game ? ' data-game="on"' : ''}><head><meta charset="utf-8">
+<link rel="stylesheet" href="/builders/style.css"><link rel="stylesheet" href="/builders/visor.css"><link rel="stylesheet" href="/builders/thinking.css"></head>
+<body data-page="${page.replace('.html', '')}">${mainOf(page)}${STUB}
+<script src="/builders/shell-game.js"></script><script src="/builders/visor.js"></script><script src="/builders/sky-visor.js"></script></body></html>`;
+
+async function open(page, { game = true } = {}) {
+  const ctx = await browser.newContext({ viewport: { width: 1280, height: 800 } });
+  await ctx.route(ORIGIN + '/**', (route) => {
+    const p = new URL(route.request().url()).pathname;
+    if (p === '/') return route.fulfill({ contentType: 'text/html', body: PAGE(page, game) });
+    const f = path.join(HALL, p.replace(/^\/builders\//, ''));
+    if (p.startsWith('/builders/') && TYPES[path.extname(p)] && fs.existsSync(f)) return route.fulfill({ contentType: TYPES[path.extname(p)], body: fs.readFileSync(f) });
+    return route.fulfill({ status: 404, body: '' });
+  });
+  const pg = await ctx.newPage();
+  const errors = [];
+  pg.on('pageerror', (e) => errors.push(String(e.message)));
+  await pg.addInitScript((g) => { try { localStorage.setItem('hall-game', g ? 'on' : 'off'); } catch (_) { /* none */ } }, game);
+  await pg.goto(ORIGIN + '/');
+  await pg.waitForFunction(() => !!window.OTBVisor && !!window.__visorScene);
+  return { ctx, page: pg, errors };
+}
+// every button and field on the sky a person can see (dialogs and side panels are pop-ups)
+const sceneControls = () => [...document.querySelectorAll('.sky-stage button, .sky-stage input')]
+  .filter((e) => e.getClientRects().length && !e.closest('#start, #tour, #panel, #room, #menu')).map((e) => e.id || e.className);
+const labels = () => window.__visorScene.actions.map((a) => a.label + (a.key ? ' [' + a.key + ']' : ''));
+
+test('game mode, the project sky: no control of its own, and every one is a visor action', { skip }, async () => {
+  const { ctx, page, errors } = await open('goal-map.html');
+  assert.deepEqual(await page.evaluate(sceneControls), [], 'the sky shows no button or field');
+  assert.deepEqual(await page.evaluate(labels), [
+    'Write a thought [/]', 'Jump to a goal or a thought [j]', 'List · off [L]', 'Explore · on', 'My ideas · off',
+    'Clock · off', 'How to read the sky [?]', 'Fit the whole sky [0]', 'Legend · off',
+  ]);
+  assert.equal(await page.textContent('.visor__hint--place'), '/Write a thought', 'writing a thought is the lead, on the glass');
+  assert.deepEqual(errors, []);
+  await ctx.close();
+});
+
+test('game mode, your sky: the lens switch and its own pills are rows too', { skip }, async () => {
+  const { ctx, page } = await open('thinking.html');
+  assert.deepEqual(await page.evaluate(sceneControls), []);
+  const got = await page.evaluate(labels);
+  for (const want of ['Simple · off', 'Your thinking · on', 'My influence · off', 'Claude layer · off', 'What if · off']) assert.ok(got.includes(want), want);
+  await ctx.close();
+});
+
+test('a row presses its pill once, and the row follows the pill', { skip }, async () => {
+  const { ctx, page } = await open('goal-map.html');
+  await page.keyboard.press('a');
+  await page.click('.visor__sheet [data-visor-scene] >> text=My ideas · off');
+  assert.deepEqual(await page.evaluate(() => [window.presses.ideasBtn, document.getElementById('ideasBtn').getAttribute('aria-pressed')]), [1, 'true'], 'one press, not two');
+  await page.waitForFunction(() => window.__visorScene.actions.some((a) => a.label === 'My ideas · on'));
+  await ctx.close();
+});
+
+test('J opens the jump field and / is the composer; each closes again when left empty', { skip }, async () => {
+  const { ctx, page } = await open('goal-map.html');
+  await page.keyboard.press('j');
+  assert.deepEqual(await page.evaluate(() => [getComputedStyle(document.querySelector('.jump')).display, document.activeElement.id]), ['block', 'jump']);
+  await page.evaluate(() => window.__visorScene.actions[0].run());
+  assert.deepEqual(await page.evaluate(() => [getComputedStyle(document.querySelector('.jump')).display, getComputedStyle(document.getElementById('composerWrap')).display, document.activeElement.id]), ['none', 'flex', 'thought'], 'one field at a time');
+  await page.keyboard.type('half a thought');
+  await page.evaluate(() => document.activeElement.blur());
+  await page.waitForTimeout(20);
+  assert.equal(await page.evaluate(() => getComputedStyle(document.getElementById('composerWrap')).display), 'flex', 'words in it: it stays');
+  await page.evaluate(() => { document.getElementById('thought').value = ''; document.getElementById('thought').focus(); document.activeElement.blur(); });
+  await page.waitForTimeout(20);
+  assert.equal(await page.evaluate(() => getComputedStyle(document.getElementById('composerWrap')).display), 'none', 'left empty: it closes');
+  await ctx.close();
+});
+
+test('the clock and the legend open from the visor', { skip }, async () => {
+  const { ctx, page } = await open('goal-map.html');
+  const shown = () => page.evaluate(() => ['time', 'legend'].map((id) => getComputedStyle(document.getElementById(id)).display));
+  assert.deepEqual(await shown(), ['none', 'none']);
+  await page.evaluate(() => { for (const a of window.__visorScene.actions) if (/^(Clock|Legend)/.test(a.label)) a.run(); });
+  assert.deepEqual(await shown(), ['flex', 'flex']);
+  await page.waitForFunction(() => window.__visorScene.actions.some((a) => a.label === 'Clock · on'));
+  await ctx.close();
+});
+
+test('classic mode: the sky keeps its own top row, fields and foot', { skip }, async () => {
+  const { ctx, page } = await open('goal-map.html', { game: false });
+  const ids = await page.evaluate(sceneControls);
+  for (const id of ['roomBtn', 'exploreBtn', 'ideasBtn', 'jump', 'thought', 'fileGo', 'play', 'clock']) assert.ok(ids.includes(id), id);
+  await ctx.close();
+});

package/tests/hall_visor.mjs

@@ -120,7 +120,7 @@ test('source: the visor loads after the shell on every scene page, with its shee
     assert.ok(at('/builders/visor.js') > at('/builders/shell.js?') && at('/builders/shell.js?') > at('/builders/shell-game.js'), `${f}: shell-game, shell, then the visor`);
     assert.match(html, /<link rel="stylesheet" href="\/builders\/visor\.css/, `${f}: links visor.css`);
   }
-  for (const f of ['sky-interaction.js', 'city.js', 'home-city.js']) assert.match(read(f), /window\.__visorScene = /, `${f} registers its scene`);
+  for (const f of ['sky-visor.js', 'city.js', 'home-city.js']) assert.match(read(f), /window\.__visorScene = /, `${f} registers its scene`);
   assert.doesNotMatch(VISOR, /cam\.(x|y|k)\s*=/, 'the visor writes no camera (ADR 0399 §2.2)');
   assert.doesNotMatch(VISOR, /setAttribute\('hidden'|\.hidden = true;[^\n]*nav/, 'it hides nothing but itself');
   assert.match(read('visor.css'), /html\[data-game="on"\] \.visor/, 'game mode only');

package/tests/home_gallery_widget.mjs

@@ -218,3 +218,46 @@ test('Home is the gallery only in Artist: the city\'s widget switches on the cra
   assert.equal(art.hidden, false);
   assert.notEqual(back, 'none', 'and comes back in another craft');
 });
+
+// ---- task 1005211 (ADR 0403): in game mode the gallery's controls are the visor's ----
+test("the gallery's rows for the visor: each in its control's own words, each pressing that control", { skip }, async () => {
+  const { ctx, page } = await boot();
+  const rows = () => page.evaluate(() => window.__g.visorActions().map((a) => [a.label, a.key || '', !!a.lead, !!a.bind]));
+  assert.deepEqual(await rows(), [
+    ['The full gallery', 'g', true, true], ['Most popular · on', '', false, false], ['Latest · off', '', false, false],
+    ['Previous work', '←', false, false], ['Next work', '→', false, false], ['Full screen', 'F', false, false], ['Your studio', '', false, false],
+  ], 'the full gallery is the lead, on G; the wall keeps its own arrow keys and F');
+  await page.evaluate(() => { window.__changes = 0; window.__g.onChange(() => { window.__changes += 1; }); });
+  await page.evaluate(() => window.__g.visorActions().find((a) => a.label === 'Next work').run());
+  assert.equal((await state(page)).count, `2 of ${N}`);
+  assert.equal(await page.evaluate(() => document.activeElement.className), 'hg-room', 'a row hands the wall the keyboard, so the arrows answer next');
+  await page.keyboard.press('ArrowRight');
+  assert.equal((await state(page)).count, `3 of ${N}`);
+  await page.evaluate(() => window.__g.visorActions()[0].run());
+  assert.deepEqual((await rows()).map((r) => r[0]), ['Back to the bench', 'Most popular · on', 'Latest · off', 'Your studio'], 'in the full gallery there is no wall to walk');
+  assert.ok(await page.evaluate(() => window.__changes) >= 1, 'Home is told the rows changed');
+  await page.evaluate(() => window.__g.visorActions().find((a) => a.label === 'Latest · off').run());
+  await page.waitForFunction(() => window.__g.visorActions().some((a) => a.label === 'Latest · on'));
+  await ctx.close();
+});
+
+test('game mode: the tabs, the ways, the arrows and full screen leave the wall; classic mode keeps them', { skip }, async () => {
+  const { ctx, page } = await boot();
+  const shown = () => page.evaluate(() => ['.hg-sort', '.hg-ways', '.hg-prev', '.hg-next', '.hg-fsbtn'].map((s) => getComputedStyle(document.querySelector(s)).display !== 'none'));
+  assert.deepEqual(await shown(), [true, true, true, true, true], 'classic');
+  await page.evaluate(() => document.documentElement.classList.add('visor-on'));
+  assert.deepEqual(await shown(), [false, false, false, false, false], 'with the visor up');
+  assert.ok(await page.evaluate(() => getComputedStyle(document.querySelector('.hg-heart')).display !== 'none'), 'a heart is the work\'s, and stays');
+  await ctx.close();
+});
+
+test('Home registers the gallery\'s rows as its scene in Artist, and none in another craft', { skip }, async () => {
+  const { ctx, page } = await boot({ city: true });
+  await page.evaluate(() => { window.__scenes = []; window.OTBVisor = { scene: (s) => window.__scenes.push(s) }; window.__widget.mount(document.getElementById('home-city')); });
+  await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
+  assert.deepEqual(await page.evaluate(() => window.__visorScene.actions.length), 0, 'the builder\'s Home: no gallery rows');
+  await page.evaluate(() => { document.documentElement.dataset.craft = 'artist'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artist' } })); });
+  await page.waitForFunction(() => window.__visorScene.actions.length > 0 && window.__visorScene.actions[0].label === 'The full gallery');
+  assert.equal(await page.evaluate(() => window.__visorScene.place), 'Home');
+  await ctx.close();
+});