@bongos/core 1.24.78 → 1.24.80

package/tests/help_requests.mjs

@@ -43,11 +43,15 @@ test('an unknown craft is refused', () => {
   assert.ok(reasons({ needs_craft: 'wizard', what_is_stuck: 'help' }).includes('unknown_craft'));
 });
 
-test('the crafts are ADR 0174\'s three, plus the ui craft the ui-design module contributes', () => {
+test('the crafts are the two working characters, plus the ui craft the ui-design module contributes', () => {
   // 'ui' joined the vocabulary with task 1003487, which made the discipline
-  // selectable everywhere a builder chooses work. The DB CHECK is widened in
-  // lockstep by modules/lifecycle/migrations/lifecycle_006_help_requests_ui_craft.sql.
-  assert.deepEqual(help.helpCrafts().sort(), ['artist', 'builder', 'ideator', 'ui']);
+  // selectable everywhere a builder chooses work. Since task 1005141 (BONGOS-V3)
+  // the help craft IS the discipline word: artisan (was 'builder'/'engineer') and
+  // artist (which absorbed 'ideator'). The DB CHECK is widened in lockstep by
+  // modules/lifecycle/migrations/lifecycle_021_crafts_artisan_artist.sql.
+  assert.deepEqual(help.helpCrafts().sort(), ['artisan', 'artist', 'ui']);
+  assert.ok(!help.helpCrafts().includes('builder'), "the old 'builder' help spelling is not offered");
+  assert.ok(!help.helpCrafts().includes('ideator'), 'ideator folded into artist');
   assert.equal(help.disciplineForCraft('ui'), 'ui', 'ui is spelled the same on both sides of the seam');
   assert.equal(help.craftForDiscipline('ui'), 'ui');
 });
@@ -57,23 +61,46 @@ test('every craft the app offers is permitted by the help_requests CHECK', () =>
   // a compiled-in CHECK, and widening one without the other is invisible until an
   // INSERT fails in production as a 500 on a feature that reads as supported.
   const sql = fs.readFileSync(
-    path.join(ROOT, 'modules', 'lifecycle', 'migrations', 'lifecycle_006_help_requests_ui_craft.sql'), 'utf8');
-  const m = sql.match(/needs_craft IN \(([^)]*)\)/);
+    path.join(ROOT, 'modules', 'lifecycle', 'migrations', 'lifecycle_021_crafts_artisan_artist.sql'), 'utf8');
+  // The CHECK's list, not the UPDATE's WHERE that renames the old rows above it.
+  const m = sql.match(/CHECK \(needs_craft IS NULL OR needs_craft IN \(([^)]*)\)/);
   assert.ok(m, 'the migration states the permitted craft list');
   const allowed = m[1].split(',').map((x) => x.trim().replace(/^'|'$/g, ''));
   for (const c of help.helpCrafts()) {
     assert.ok(allowed.includes(c), `craft '${c}' is offered by helpCrafts() but the CHECK forbids it`);
   }
+  // A rolled-back release still writes the old spellings, so the CHECK keeps them.
+  for (const old of ['builder', 'ideator']) {
+    assert.ok(allowed.includes(old), `the CHECK still admits the pre-1005141 spelling '${old}'`);
+  }
 });
 
-test('THE VOCABULARY SEAM: builder maps to the discipline spelled engineer', () => {
-  // builders.preferred_disciplines spells this craft 'engineer'. If C02 re-derives
-  // the mapping instead of consuming disciplineForCraft, the two spellings drift
-  // and a builder silently matches nothing.
-  assert.equal(help.disciplineForCraft('builder'), 'engineer');
+test('THE VOCABULARY SEAM is closed: the help craft and the discipline are one word', () => {
+  // Before task 1005141 the engineering craft was 'builder' here and 'engineer' in
+  // builders.preferred_disciplines. Now both say 'artisan'. If C02 re-derives the
+  // mapping instead of consuming disciplineForCraft, a builder silently matches nothing.
+  assert.equal(help.disciplineForCraft('artisan'), 'artisan');
   assert.equal(help.disciplineForCraft('artist'), 'artist');
-  assert.equal(help.disciplineForCraft('ideator'), 'ideator');
   assert.equal(help.disciplineForCraft('wizard'), null);
+  // Old spellings are read as today's craft, on both sides of the seam.
+  assert.equal(help.disciplineForCraft('builder'), 'artisan', "the old help spelling 'builder' still resolves");
+  assert.equal(help.disciplineForCraft('ideator'), 'artist', 'ideator folded into artist');
+  assert.equal(help.craftForDiscipline('engineer'), 'artisan', 'a stored engineer discipline is the artisan craft');
+  assert.equal(help.craftForDiscipline('ideator'), 'artist', 'a stored ideator discipline is the artist craft');
+  assert.equal(help.craftForDiscipline('artisan'), 'artisan');
+});
+
+test("an OLD craft spelling validates and is stored as today's", async () => {
+  // An old CLI or a bookmarked form still posts needs_craft 'builder'/'ideator'.
+  assert.deepEqual(reasons({ needs_craft: 'builder', what_is_stuck: 'help' }), []);
+  assert.deepEqual(reasons({ needs_craft: 'ideator', what_is_stuck: 'help' }), []);
+  assert.deepEqual(reasons({ needs_craft: 'engineer', what_is_stuck: 'help' }), []);
+  const calls = [];
+  const pool = { query: async (sql, params) => { calls.push(params); return { rows: [{ id: 1 }] }; } };
+  await help.createHelpRequest({ requestedBy: 1, needsCraft: 'builder', whatIsStuck: 'x' }, { pool });
+  await help.createHelpRequest({ requestedBy: 1, needsCraft: 'ideator', whatIsStuck: 'x' }, { pool });
+  assert.equal(calls[0][1], 'artisan', "'builder' is stored as 'artisan'");
+  assert.equal(calls[1][1], 'artist', "'ideator' is stored as 'artist'");
 });
 
 // ---- what is stuck --------------------------------------------------------
@@ -98,7 +125,7 @@ test('a request may name a task OR a goal, never both', () => {
 });
 
 test('context is optional', () => {
-  assert.deepEqual(reasons({ needs_craft: 'ideator', what_is_stuck: 'a shape question' }), []);
+  assert.deepEqual(reasons({ needs_craft: 'artist', what_is_stuck: 'a shape question' }), []);
 });
 
 // ---- the schema keeps the same promises -----------------------------------
@@ -106,7 +133,10 @@ test('the CHECK constraints mirror the validator, so neither is the only guard',
   // The validator exists so a refusal names the field; the constraints are the
   // authority. Both must exist or one of the two promises is unkept.
   const sql = read('modules', 'lifecycle', 'migrations', 'lifecycle_004_help_requests.sql');
+  // lifecycle_004 is history (its vocabulary was ADR 0174's); the live CHECK is lifecycle_021's.
   assert.match(sql, /needs_craft IN \('artist', 'builder', 'ideator'\)/);
+  assert.match(read('modules', 'lifecycle', 'migrations', 'lifecycle_021_crafts_artisan_artist.sql'),
+    /needs_craft IN \('artisan', 'artist'/, 'the renamed CHECK names the new crafts');
   assert.match(sql, /\(needs_craft IS NOT NULL\) <> \(needs_builder_id IS NOT NULL\)/, 'exactly-one-addressee');
   assert.match(sql, /NOT \(task_id IS NOT NULL AND goal_id IS NOT NULL\)/, 'at most one context');
   assert.match(sql, /length\(btrim\(what_is_stuck\)\) > 0/, 'non-empty description');
@@ -350,9 +380,11 @@ test('the /me read is IN the fan-out, not a serialized await before it', () => {
 test('the count is ONE query, and its craft map is generated from the JS map', () => {
   // Two sequential queries on a hot path is a cost every builder pays on every
   // open. The SQL CASE is generated from DISCIPLINE_TO_CRAFT so the two spellings
-  // of 'engineer' cannot drift apart.
+  // of a craft cannot drift apart — and a stored old discipline still maps.
   const sql = help.craftMapSql('d');
-  assert.match(sql, /WHEN 'engineer' THEN 'builder'/);
+  assert.match(sql, /WHEN 'artisan' THEN 'artisan'/);
+  assert.match(sql, /WHEN 'engineer' THEN 'artisan'/, 'a legacy engineer discipline still counts');
+  assert.match(sql, /WHEN 'ideator' THEN 'artist'/, 'a legacy ideator discipline still counts');
   for (const craft of help.helpCrafts()) {
     const disc = help.disciplineForCraft(craft);
     assert.ok(sql.includes(`WHEN '${disc}' THEN '${craft}'`), `${disc}->${craft} is in the SQL map`);

package/tests/helpers.mjs

@@ -540,11 +540,11 @@ const PROFILE_CRAFTS_JS = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/publi
 //
 // `roles` is the profile's roles.shown, main first (task 1004435): one Activity
 // tab each. The default leads with the ideator, so the trail is the first tab
-// and a suite that reads it needs no switch; switchCraft('engineer') opens the
+// and a suite that reads it needs no switch; switchCraft('artisan') opens the
 // works and goals, switchCraft('artist') the approved pages.
 // `search` is the page's ?query (task 1005050: ?id= decides whose profile it is), and
 // `withOwn` also loads profile-own.js, the "Just you" screen drawn on your own profile.
-export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator', 'engineer'], artistPages = [], search = '', withOwn = false } = {}) {
+export function bootProfilePage({ signedIn = true, trail = [], roles = ['artist', 'artisan'], artistPages = [], search = '', withOwn = false } = {}) {
   const els = new Map();
   const makeEl = () => ({
     dataset: {}, style: {}, textContent: '', hidden: false, _html: '',
@@ -579,7 +579,7 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
       }
       if (url.includes('/activity?')) {
         const isGoals = url.includes('section=goals');
-        return { status: 200, ok: true, data: { rows: isGoals ? [{ id: 7, title: 'A goal', disciplines: ['artist'], task_shipped: 1, task_total: 2 }] : [{ id: 42, title: 'A work', discipline: 'engineer', shipped_at: '2026-08-01T00:00:00Z' }], total: 1 } };
+        return { status: 200, ok: true, data: { rows: isGoals ? [{ id: 7, title: 'A goal', disciplines: ['artist'], task_shipped: 1, task_total: 2 }] : [{ id: 42, title: 'A work', discipline: 'artisan', shipped_at: '2026-08-01T00:00:00Z' }], total: 1 } };
       }
       if (url.includes('/copy-desk/artists/')) {
         return { status: 200, ok: true, data: { rows: artistPages, total: artistPages.length } };
@@ -632,7 +632,7 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
       // the same reason categoryChip is: an undefined helper throws mid-render.
       roleAxisLabel: () => 'Role',
       roleLabel: (d) => (!d ? '' : d === 'unclassified' ? 'No role yet' : d === 'ui' ? 'UI' : d.charAt(0).toUpperCase() + d.slice(1)),
-      roleOptions: () => [{ value: '', label: '— any —' }, { value: 'engineer', label: 'Engineer' }, { value: 'artist', label: 'Artist' }],
+      roleOptions: () => [{ value: '', label: '— any —' }, { value: 'artisan', label: 'Artisan' }, { value: 'artist', label: 'Artist' }],
       roleIsUnset: (d) => !d || d === 'unclassified',
       ROLE_UNSET: 'unclassified',
       escapeHtml: realOTB().escapeHtml, // the real one (task 1004876)

package/tests/home_city.mjs

@@ -419,16 +419,18 @@ await test('on the builder\'s Home the core and the museum are faded; a craft\'s
   assert.match(css, /\.hc-quiet:hover,\s*\.hc-svg \.hc-quiet:focus-visible\s*\{[^}]*filter:\s*none/, 'back to colour under the pointer or the keyboard');
 });
 
-await test('a building opens its goal; the museum and the band of stars are doors to the artist\'s and the ideator\'s Home', () => {
+await test('a building opens its goal; the museum and the band of stars are both doors to the artist\'s Home (the ideator folded in, task 1005141)', () => {
   const m = Draw.cityModel(FIXTURE);
   const ls = linksOf(all(Draw.citySvg(m, m.W - 1, { mode: 'dark', gov: Gov }).nodes));
   const towers = ls.filter((n) => n.attrs.class === 'hc-tower');
   assert.equal(towers.length, m.areas.length);
   towers.forEach((n) => assert.match(n.attrs.href, /^\/goals#\/goal\/\d+$/));
   assert.ok(m.areas.every((a) => towers.some((n) => n.attrs.href === `/goals#/goal/${a.id}`)), 'each area links to its own goal');
-  assert.equal(ls.find((n) => /hc-museum/.test(n.attrs.class)).attrs['data-craft-door'], 'artistry');
+  assert.equal(ls.find((n) => /hc-museum/.test(n.attrs.class)).attrs['data-craft-door'], 'artist');
   const sky = ls.find((n) => /hc-sky/.test(n.attrs.class));
-  assert.equal(sky.attrs['data-craft-door'], 'ideating');
+  assert.equal(sky.attrs['data-craft-door'], undefined, 'the stars switch no mode');
+  assert.equal(sky.attrs.href, '/thinking', 'they open the sky itself, the old ideator room');
+  assert.ok(ls.every((n) => !/^(artistry|ideating|governing|building)$/.test(n.attrs['data-craft-door'] || '')), 'no door names a pre-rename mode');
   assert.ok(ls.every((n) => n.attrs['aria-label']), 'every door is named for a screen reader');
   const stars = all([sky]).filter((n) => n.tag === 'circle');
   const box = Draw.viewBoxOf(m);
@@ -536,7 +538,7 @@ await test('outlines never show through a nearer building, and the three doors l
   const group = (k) => hits.filter((h) => h.attrs['data-group'] === k);
   assert.ok(group('area').every((h) => h.attrs.href === '/goals'), 'Building opens the goals');
   assert.ok(group('civic').every((h) => h.attrs.href === Gov.STREET_HREF), 'Government opens the street');
-  assert.ok(group('museum').every((h) => h.attrs['data-craft-door'] === 'artistry'), 'Art switches to Artistry');
+  assert.ok(group('museum').every((h) => h.attrs['data-craft-door'] === 'artist'), 'Art switches to Artist');
   ['area', 'civic', 'museum'].forEach((k) => {
     const g = group(k);
     assert.ok(g.length > 0);

package/tests/home_city_widget.mjs

@@ -154,31 +154,33 @@ test('with reduced motion nothing glides: every control jumps straight to where
   assert.equal(s.t, 0);
 });
 
-test('the museum and the band of stars switch the craft; the core and a building are plain links', { skip }, async () => {
+test('the museum switches the craft to Artist; the band of stars, the core and a building are plain links (the stars open Your thinking since task 1005141)', { skip }, async () => {
   const { ctx, page } = await boot();
   await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
-  await page.evaluate(() => { document.querySelector('.hc-svg a.hc-museum').dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true })); document.querySelector('.hc-svg a.hc-sky').dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true })); });
-  const r = await page.evaluate(() => ({ chosen: window.__chosen, core: document.querySelector('.hc-svg a.hc-core').getAttribute('href'), tower: document.querySelector('.hc-svg a.hc-tower').getAttribute('href') }));
+  await page.evaluate(() => { document.querySelector('.hc-svg a.hc-museum').dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true })); });
+  const r = await page.evaluate(() => ({ chosen: window.__chosen, sky: document.querySelector('.hc-svg a.hc-sky').getAttribute('href'), skyDoor: document.querySelector('.hc-svg a.hc-sky').getAttribute('data-craft-door'), core: document.querySelector('.hc-svg a.hc-core').getAttribute('href'), tower: document.querySelector('.hc-svg a.hc-tower').getAttribute('href') }));
   await ctx.close();
-  assert.deepEqual(r.chosen, ['artistry', 'ideating']);
+  assert.deepEqual(r.chosen, ['artist'], 'the museum opens the artist home');
+  assert.equal(r.sky, '/thinking', 'the stars open the sky itself');
+  assert.equal(r.skyDoor, null, 'and switch no craft');
   assert.equal(r.core, '/builders/street');
   assert.match(r.tower, /^\/goals#\/goal\/\d+$/);
 });
 
-test('the governor\'s Home is the street: Governing on Home goes there, opened or chosen; other crafts stay', { skip }, async () => {
-  const opened = await boot({ craft: 'governing' });
+test('the governor\'s Home is the street: Patron on Home goes there, opened or chosen; other crafts stay', { skip }, async () => {
+  const opened = await boot({ craft: 'patron' });
   const onOpen = await opened.page.evaluate(() => ({ hops: window.__hops, asked: window.__asked, built: !!document.querySelector('.hc-svg') }));
   await opened.ctx.close();
-  assert.deepEqual(onOpen.hops, ['/builders/street'], 'Home opened with Governing chosen goes to the street');
+  assert.deepEqual(onOpen.hops, ['/builders/street'], 'Home opened with Patron chosen goes to the street');
   assert.deepEqual(onOpen.asked, [], 'and asks the server for nothing on the way');
   assert.equal(onOpen.built, false, 'and builds no city it is leaving');
 
   const { ctx, page } = await boot();
   await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
   const flip = (m) => page.evaluate((mode) => { document.documentElement.dataset.craft = mode; window.__craft = mode; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode } })); return window.__hops.slice(); }, m);
-  assert.deepEqual(await flip('artistry'), [], 'Artistry stays on Home');
-  assert.deepEqual(await flip('ideating'), [], 'Ideating stays on Home');
-  assert.deepEqual(await flip('governing'), ['/builders/street'], 'choosing Governing on Home goes to the street');
+  assert.deepEqual(await flip('artist'), [], 'Artist stays on Home');
+  assert.deepEqual(await flip('artisan'), [], 'Artisan stays on Home');
+  assert.deepEqual(await flip('patron'), ['/builders/street'], 'choosing Patron on Home goes to the street');
   await ctx.close();
 });
 
@@ -201,6 +203,23 @@ test('a phone width scrolls nothing sideways', { skip }, async () => {
 });
 
 // ---- the ideator's sky (task 1005059) ----
+// Since task 1005141 no craft lands on the sky: Ideating folded into Artist, and craft-mode.js
+// reads a stored 'ideating' as 'artist' (tests/craft_mode.mjs). The sky view stays in
+// home-city.js behind one switch so it can come back as its own view, so the cases below
+// still drive it by handing the widget a raw 'ideating' — a craft the real switch never
+// returns any more. The first case pins the new truth: every real craft draws the city.
+
+test('NO CRAFT LANDS ON THE SKY (task 1005141): Artist, Artisan and no mode all draw the city', { skip }, async () => {
+  for (const craft of ['artist', 'artisan', null]) {
+    const { ctx, page } = await boot({ craft });
+    await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
+    const r = await page.evaluate(() => ({ sky: document.getElementById('home-city').classList.contains('hc-is-sky'), towers: document.querySelectorAll('.hc-tower').length, hits: document.querySelectorAll('.hc-hit').length }));
+    await ctx.close();
+    assert.equal(r.sky, false, `${craft}: no sky`);
+    assert.ok(r.towers > 0, `${craft}: the city's towers`);
+    assert.equal(r.hits, 0, `${craft}: no skyline hit groups`);
+  }
+});
 
 // a point inside the hit group that the group itself takes (a nearer building may cover part of it)
 const pointOf = (page, group) => page.evaluate((g) => {
@@ -215,7 +234,7 @@ const pointOf = (page, group) => page.evaluate((g) => {
 }, group);
 const lit = (page) => page.evaluate(() => Object.fromEntries(['area', 'civic', 'museum'].map((g) => [g, [...document.querySelectorAll('.hc-ol-' + g)].every((o) => Number(getComputedStyle(o).strokeOpacity) > 0.5)])));
 
-test('in Ideating, Home draws the sky over the skyline from the same one read, and the ladder ranks ideators', { skip }, async () => {
+test('the dormant sky view, handed a raw ideating, draws the sky over the skyline from the same one read, and the ladder ranks ideators', { skip }, async () => {
   const { ctx, page } = await boot({ craft: 'ideating' });
   await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
   const r = await page.evaluate(() => ({
@@ -251,7 +270,7 @@ test('hovering the skyline outlines exactly one whole group: Building, Governmen
   assert.deepEqual(rest, { area: false, civic: false, museum: false });
 });
 
-test('each group is one door: the goals, the street, and the artist\'s Home', { skip }, async () => {
+test('in the dormant sky, each group is one door: the goals, the street, and the artist\'s Home', { skip }, async () => {
   const { ctx, page } = await boot({ craft: 'ideating' });
   await page.waitForFunction(() => document.querySelectorAll('.hc-hit').length > 0);
   await page.evaluate(() => document.querySelector('.hc-hit[data-group="museum"]').dispatchEvent(new MouseEvent('click', { bubbles: true, cancelable: true })));
@@ -263,7 +282,7 @@ test('each group is one door: the goals, the street, and the artist\'s Home', {
     small: [...document.querySelectorAll('.hc-hit')].map((a) => a.getBoundingClientRect()).filter((b) => b.height < 24).length,
   }));
   await ctx.close();
-  assert.deepEqual(r.chosen, ['artistry']);
+  assert.deepEqual(r.chosen, ['artist']);
   assert.deepEqual(r.area, ['/goals']);
   assert.deepEqual(r.civic, ['/builders/street']);
   assert.deepEqual(r.stops.sort(), ['area', 'civic', 'museum']);
@@ -273,7 +292,7 @@ test('each group is one door: the goals, the street, and the artist\'s Home', {
 test('switching the craft swaps the sky and the city in place, with no second read', { skip }, async () => {
   const { ctx, page } = await boot({ craft: 'ideating' });
   await page.waitForFunction(() => document.querySelectorAll('.hc-hit').length > 0);
-  await page.evaluate(() => { window.__craft = 'building'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'building' } })); });
+  await page.evaluate(() => { window.__craft = 'artisan'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artisan' } })); });
   const r = await page.evaluate(() => ({ asked: window.__asked.length, sky: document.getElementById('home-city').classList.contains('hc-is-sky'), towers: document.querySelectorAll('.hc-tower').length, hits: document.querySelectorAll('.hc-hit').length }));
   await ctx.close();
   assert.deepEqual(r, { asked: 1, sky: false, towers: 10, hits: 0 });

package/tests/home_gallery_widget.mjs

@@ -3,7 +3,7 @@
 //
 // Runs modules/hall-ui/public/home-gallery.js (and, for the craft switch, the city's
 // three files) in a real page with the reads stubbed by the hall-preview fixture: the
-// wall is asked for once, only in Artistry, Most popular first; the arrows and keys walk
+// wall is asked for once, only in Artist (Artistry until task 1005141), Most popular first; the arrows and keys walk
 // it; the label opens closer on a click; the heart is the viewer's own, given and taken
 // back, and never changes size; Latest asks again in that order; full screen keeps the
 // signature and heart and drops the label; the full gallery hangs every work and a click
@@ -199,17 +199,17 @@ test('at phone width the gallery fits: nothing scrolls sideways and every contro
   assert.deepEqual(m.small, []);
 });
 
-test('Home is the gallery only in Artistry: the city\'s widget switches on the craft and asks for the wall only then', { skip }, async () => {
+test('Home is the gallery only in Artist: the city\'s widget switches on the craft and asks for the wall only then', { skip }, async () => {
   const { ctx, page } = await boot({ city: true });
   await page.evaluate(() => window.__widget.mount(document.getElementById('home-city')));
   await page.waitForFunction(() => document.querySelectorAll('.hc-rung').length > 0);
   const building = await page.evaluate(() => ({ asked: window.__asked.slice(), gallery: getComputedStyle(document.querySelector('.hg')).display, stage: getComputedStyle(document.querySelector('.hc-stage')).display }));
   assert.deepEqual(building.asked, ['GET /api/bongos/home/city?weeks=10'], 'the builder\'s Home never asks for the wall');
   assert.equal(building.gallery, 'none');
-  await page.evaluate(() => { document.documentElement.dataset.craft = 'artistry'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artistry' } })); });
+  await page.evaluate(() => { document.documentElement.dataset.craft = 'artist'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artist' } })); });
   await page.waitForFunction(() => document.querySelectorAll('.hg-hang').length > 0);
   const art = await page.evaluate(() => ({ asked: window.__asked.slice(), gallery: getComputedStyle(document.querySelector('.hg')).display, stage: getComputedStyle(document.querySelector('.hc-stage')).display, hidden: document.getElementById('home-city').hidden }));
-  await page.evaluate(() => { document.documentElement.dataset.craft = 'building'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'building' } })); });
+  await page.evaluate(() => { document.documentElement.dataset.craft = 'artisan'; document.dispatchEvent(new CustomEvent('otb:craft', { detail: { mode: 'artisan' } })); });
   const back = await page.evaluate(() => getComputedStyle(document.querySelector('.hc-stage')).display);
   await ctx.close();
   assert.deepEqual(art.asked.slice(1), ['GET /api/bongos/home/gallery?order=popular']);

package/tests/home_idea_box.mjs

@@ -2,11 +2,11 @@
 // goal 1000095, the owner's work-first hall).
 //
 // Runs modules/hall-ui/public/home-idea-box.js with the city's three files in a real
-// page, the reads stubbed by the hall-preview fixture: the box shows only in Ideating
+// page, the reads stubbed by the hall-preview fixture: the box shows only in the artist's Home
 // and sits above the sky; it is ONE box and a button (owner, 2026-11-05); filing is
 // POST /inbox with { title, body_md: '', kind: 'feature' }; an empty line files
 // nothing; a refused filing keeps the words and says why; a filed one clears and links
-// to Your thinking; the box shows in Ideating even when the sky could not be read; at
+// to Your thinking; the box shows in the artist's Home even when the sky could not be read; at
 // phone width nothing scrolls sideways. The pure halves run in node. Skips the browser
 // cases where no system Edge or Chrome is installed.
 //
@@ -45,7 +45,7 @@ const stubs = (craft, { city = true, refuse = false } = {}) => `
   window.OTBCraftMode = { iconHtml: () => '', choose: () => {}, current: () => document.documentElement.dataset.craft || null };
   window.OTB = { contributeHallWidget(w) { window.__widget = w; } };`;
 
-async function boot({ craft = 'ideating', width = 1440, ...opts } = {}) {
+async function boot({ craft = 'artist', width = 1440, ...opts } = {}) {
   const ctx = await browser.newContext({ viewport: { width, height: 900 }, reducedMotion: 'reduce' });
   const page = await ctx.newPage();
   await page.setContent(`<!doctype html><html data-theme="dark"${craft ? ` data-craft="${craft}"` : ''}><head><style>${CSS}</style></head><body><section id="welcome-scroll" class="scroll">setup guide</section><section id="home-city" class="scroll home-city" hidden></section></body></html>`);
@@ -65,7 +65,7 @@ test('the pure halves: the first line is the title and the rest the details; a r
   assert.match(Box.explain(null), /Nothing was saved/);
 });
 
-test('in Ideating the box is the first thing in the section, ONE box and a button, and the setup guide is hidden', { skip }, async () => {
+test('in the Artist Home the box is the first thing in the section, ONE box and a button, and the setup guide is hidden', { skip }, async () => {
   const { ctx, page } = await boot();
   await page.waitForFunction(() => document.querySelector('.hc-svg').childElementCount > 0);
   const s = await page.evaluate(() => {
@@ -92,7 +92,7 @@ test('in Ideating the box is the first thing in the section, ONE box and a butto
 });
 
 test('in any other craft, or none, there is no box and the setup guide shows', { skip }, async () => {
-  for (const craft of ['building', null]) {
+  for (const craft of ['artisan', null]) {
     const { ctx, page } = await boot({ craft });
     const s = await page.evaluate(() => ({ hidden: document.querySelector('.hib').hidden, guide: getComputedStyle(document.getElementById('welcome-scroll')).display }));
     await ctx.close();
@@ -159,7 +159,7 @@ test('a refused filing keeps the words and says why', { skip }, async () => {
   assert.equal(s.link, false);
 });
 
-test('the box shows in Ideating even when the sky could not be read', { skip }, async () => {
+test('the box shows in the Artist Home even when the sky could not be read', { skip }, async () => {
   const { ctx, page } = await boot({ city: false });
   const s = await page.evaluate(() => ({ host: document.getElementById('home-city').hidden, box: document.querySelector('.hib').hidden }));
   await ctx.close();

package/tests/hub_community_page.mjs

@@ -205,7 +205,7 @@ const find = (n, cls) => {
   return null;
 };
 
-const ROW = (place, handle, credits, extra = {}) => ({ place, handle, github_login: handle, display_name: handle.toUpperCase(), avatar_url: `https://avatars.example/${handle}`, credits, tasks_shipped: 2, karma: 1, disciplines: ['engineer'], ...extra });
+const ROW = (place, handle, credits, extra = {}) => ({ place, handle, github_login: handle, display_name: handle.toUpperCase(), avatar_url: `https://avatars.example/${handle}`, credits, tasks_shipped: 2, karma: 1, disciplines: ['artisan'], ...extra });
 const WEEK = () => ({ week: { start: '2026-10-19', end: '2026-10-26' },
   winner: { week_start: '2026-10-19', handle: 'ana', github_login: 'ana', display_name: 'Ana <i>L</i>', avatar_url: 'https://avatars.example/ana', credits: 1240, tasks_shipped: 1 },
   past: [{ week_start: '2026-10-12', handle: 'bo', github_login: 'bo', display_name: null, avatar_url: 'data:x', credits: 300, tasks_shipped: 2 },
@@ -229,7 +229,7 @@ const READS = () => ({
   '/community/leaderboard?window=all': { status: 200, body: { window: 'all', count: 99, results: [ROW(26, 'ana', 1200), ROW(27, 'bo', 1500, { tasks_shipped: 1, karma: 0, avatar_url: 'javascript:alert(1)', display_name: null })] } },
   '/community/leaderboard?window=30d': { status: 200, body: { window: '30d', results: [ROW(1, 'cy', 40)] } },
   '/community/leaderboard?window=all&discipline=artist': { status: 200, body: { window: 'all', results: [] } },
-  '/community/search?q=pri': { status: 200, body: { results: [{ handle: 'priya', github_login: 'priyan', display_name: 'Priya', avatar_url: null, disciplines: ['engineer', 'ui'] }, { handle: 'pri-hidden', github_login: 'ph', display_name: 'Pri <b>H</b>', avatar_url: null, disciplines: null }] } },
+  '/community/search?q=pri': { status: 200, body: { results: [{ handle: 'priya', github_login: 'priyan', display_name: 'Priya', avatar_url: null, disciplines: ['artisan', 'ui'] }, { handle: 'pri-hidden', github_login: 'ph', display_name: 'Pri <b>H</b>', avatar_url: null, disciplines: null }] } },
   '/community/search?q=pri&discipline=artist': { status: 200, body: { results: [] } },
   '/scouting': { status: 403, body: { error: { code: 'forbidden' } } },
 });
@@ -465,7 +465,7 @@ test('find: nothing read on arrival; too short is refused before any read; a hid
   assert.equal(ui.gets().pop(), '/api/bongos/community/search?q=pri');
   assert.equal(ui.$('findStatus').textContent, '2 builders found.');
   const [priya, hidden] = kids(ui.$('findList'));
-  assert.equal(find(priya, 'mineRow__hint').textContent, 'engineer · designer');
+  assert.equal(find(priya, 'mineRow__hint').textContent, 'artisan · designer');
   assert.equal(find(hidden, 'mineRow__name').textContent, 'Pri <b>H</b>', 'textContent: a name is never markup');
   assert.equal(find(hidden, 'mineRow__hint'), null, 'disciplines null (hidden numbers): nothing said about their craft');
   assert.equal(ui.$('findBtn').disabled, false);