@bongos/core 1.24.42 → 1.24.43

package/modules/hall-ui/public/hall-render.js

@@ -2,9 +2,10 @@
 //
 // Carved out of builders.js by task 1003206 (goal 1000079, the R03 de-monolith
 // plan): that file was 2,558 lines, the largest first-party file left over the
-// 1,500-line ratchet. This holds the view painters — landing, profile, welcome,
-// onboarding, recent ships, the AI-dev curve, the nav and hall
-// widgets — plus the helpers and view state only they touch.
+// 1,500-line ratchet. This holds the view painters — landing, the Standing
+// chip, the shipped count, the nav and hall widgets — plus the helpers and view
+// state only they touch. (The Accomplishments view and its curve, reviews and
+// feeds moved to profile-own.js in task 1005050.)
 //
 // WHY A FACTORY, and not a flat namespace like goals-lib.js. goals-lib.js can be
 // flat because everything in it is pure. These renderers are not: they need the
@@ -22,7 +23,7 @@
   'use strict';
 
   window.OTBHallRender = function createHallRender(ctx) {
-    const { API, RANK_ORDER, api, brandWorld, curLabel, emptyRow, fmtDate, getJSON, mins, normalizeRank, pct, postJSON, rankLabel, rankWeight, signClasses, toast, usd } = ctx;
+    const { API, RANK_ORDER, api, brandWorld, curLabel, normalizeRank, postJSON, rankLabel, rankWeight, toast } = ctx;
     const { escapeHtml, $, fmtNum, moduleOn } = window.OTB;
 
   const RANK_UNLOCKS = {
@@ -49,66 +50,6 @@
   };
   let rankTipSeq = 0;
 
-  // "Where you stand" (task 1005046): the personal half of the retired Ranks
-  // page, now a card on Accomplishments. The ladder itself — every rank and what
-  // it unlocks — is the Primer's rank-ladder chapter, written once; this card
-  // says only what is true for the VIEWER: their rank, what it is, the rank
-  // above, and how they reach it. Moved from ranks.js with the page.
-  const RANK_TITLE = {
-    xenos: 'The newcomer',
-    thetes: 'The proven builder',
-    metic: 'The trusted builder',
-    archon: 'The steward',
-  };
-  const RANK_BLURB = {
-    xenos: 'A newcomer with a deliberately small surface: onboarding, safe starter tasks, and your own standing.',
-    thetes: 'A builder who has shipped their first work — the day-to-day surfaces are open.',
-    metic: 'A trusted builder: triage, reviews, planning sessions, and security reporting are open.',
-    archon: 'The steward of the whole system — approvals, the roster, budgets, and the Archon pages.',
-  };
-  // How a builder rises FROM their current rank. NB: these strings contain
-  // markup (<strong>) and are injected via innerHTML without escaping, which is
-  // safe only because they are author-controlled constants. Never source them
-  // from server or user data without switching the render site to escapeHtml.
-  const RISE_FROM = {
-    xenos:
-      `Claim and ship the newcomer-friendly tasks an Archon has opened to newcomers. Each clean ship earns ${curLabel()}; each ratified idea earns karma. On your <strong>third</strong> clean ship you are promoted automatically to <strong>Thetes</strong>, out of the newcomer sandbox with the whole queue open to you. No fee, no application; the third ship does it.`,
-    thetes:
-      'You have the run of the queue. Promotion to <strong>Metic</strong> (triage, blockers, planning, the shaping of work) is granted by a standing Archon alone, to a builder whose judgement has earned the project’s trust. Keep shipping; rank is granted, never bought.',
-    metic:
-      'The <strong>Archon</strong> rank is granted rarely, by a standing Archon alone, to a Metic who has shaped the project’s direction and earned its deepest trust. There is no checklist, only the weight of what you have built.',
-    archon:
-      'You hold the highest rank. There is no rank above it, only the care of everything below.',
-  };
-  // The rank one rung up, read off the injected tier map rather than a second
-  // copy of the ladder (tests/rank_tier_single_source.mjs).
-  function nextRank(rank) {
-    const want = (RANK_ORDER[rank] || 0) + 1;
-    return Object.keys(RANK_ORDER).find((r) => RANK_ORDER[r] === want) || null;
-  }
-  // Intentionally not on the factory's return object: renderProfile is its one
-  // caller, so it repaints whenever the band does, from the same /me payload.
-  function renderRankStanding(builder) {
-    const host = document.getElementById('rank-standing-body');
-    if (!host) return;
-    const rank = normalizeRank(builder && builder.rank);
-    const next = nextRank(rank);
-    // At the top there is no rung to name; RISE_FROM says so in its own words,
-    // so the line is left out rather than said twice.
-    const nextLine = next
-      ? `<p class="ranks-standing__next">The rank above yours is ${renderRankBadge(next)}.</p>`
-      : '';
-    host.innerHTML = `
-      <div class="ranks-standing">
-        <div class="ranks-standing__badge">${renderRankBadge(rank)}</div>
-        <p class="ranks-standing__title">${escapeHtml(RANK_TITLE[rank] || rankLabel(rank))}</p>
-        <p class="ranks-standing__blurb">${escapeHtml(RANK_BLURB[rank] || '')}</p>
-        ${nextLine}
-      </div>
-      <p class="ranks-rise__body">${RISE_FROM[rank] || RISE_FROM.xenos}</p>
-      <p class="card-foot"><a href="/primer#the-rank-ladder">Every rank and what it unlocks, in the Primer →</a></p>`;
-  }
-
   function renderRankBadge(rank, opts = {}) {
     const label = escapeHtml(rankLabel(rank));
     const ariaLabel = rank ? `Rank: ${rankLabel(rank)}` : 'Rank not yet recorded';
@@ -151,33 +92,10 @@
   // #zone-leaderboard mount it named.
   const VIEW_CONTAINERS = {
     home: 'zone-home-main',
-    standing: 'zone-standing',
   };
-  const STANDING_GROUPS = [
-    { key: 'work', label: 'Work' },
-    { key: 'karma', label: 'Karma' },
-    { key: 'progress', label: 'Progress' },
-    { key: 'achievements', label: 'Achievements' },
-  ];
-  const standingGroupId = (key) => `standing-${key}`;
-  function ensureStandingGroups() {
-    const zone = document.getElementById('zone-standing');
-    if (!zone || document.getElementById(standingGroupId(STANDING_GROUPS[0].key))) return;
-    for (const g of STANDING_GROUPS) {
-      const el = document.createElement('div');
-      el.id = standingGroupId(g.key);
-      el.className = 'standing-group';
-      zone.appendChild(el);
-    }
-  }
   function widgetHost(wgt) {
     const zone = wgt.zone ? document.getElementById(`zone-${wgt.zone}`) : null;
     if (zone) return zone;
-    if (wgt.group) {
-      ensureStandingGroups();
-      const group = document.getElementById(standingGroupId(wgt.group));
-      if (group) return group;
-    }
     const viewId = VIEW_CONTAINERS[wgt.view || 'home'] || VIEW_CONTAINERS.home;
     return document.getElementById(viewId) || document.querySelector('main');
   }
@@ -247,14 +165,12 @@
     // label]/[data-currency-tmpl] cells show the instance's unit, not the fallback.
     window.OTBBranding?.applyCurrencyLabels?.(main);
   }
-  let standingRail = null;
 
   // task 1723: the old sticky chip strip is gone. renderNav now settles the
   // three nav surfaces the shell owns or hosts:
   //   1. the sidebar's gated entries, via window.OTBShell.applyAccess (cosmetic —
   //      the server enforces every page + endpoint regardless, ADR 0016);
   function renderNav(builder, onboarding) {
-    const isArchon = (builder?.rank || '').toLowerCase() === 'archon';
     const graduated = !!(onboarding && onboarding.graduated);
     // #833: for a newcomer the Work entry surfaces only once the "ship three"
     // stage is current — before then the path reads one action at a time.
@@ -291,31 +207,6 @@
       setup: (onboarding && onboarding.setup) || null,
       builder,
     });
-
-    // Standing section rail: one link per group with a visible member.
-    const rail = document.getElementById('standing-rail');
-    if (rail) {
-      const shown = new Set(
-        window.OTB.hallWidgets()
-          .filter((wgt) => {
-            if (!wgt.group) return false;
-            if (wgt.archonOnly && !isArchon) return false;
-            const el = document.getElementById(wgt.id);
-            return !!el && !el.hidden;
-          })
-          .map((wgt) => wgt.group),
-      );
-      // An empty group would otherwise leave a gap in the panel column.
-      for (const g of STANDING_GROUPS) {
-        const el = document.getElementById(standingGroupId(g.key));
-        if (el) el.hidden = !shown.has(g.key);
-      }
-      const items = STANDING_GROUPS
-        .filter((g) => shown.has(g.key))
-        .map((g) => ({ id: standingGroupId(g.key), label: g.label }));
-      if (standingRail) standingRail.refresh(items);
-      else standingRail = window.OTBKit.makeSectionRail({ mount: rail, items, mode: 'scrollspy' });
-    }
   }
   // The project's door, as the platform pushed it into this instance's pack
   // (window.__BRANDING__.project.joinability, task 1003044): what a stranger is
@@ -363,28 +254,6 @@
           </details>`;
   }
 
-  // task 1002835: a karma vote on a peer's ship was a vote on a title alone.
-  // The two facts the ship already recorded — what the grader scored it and
-  // what it cost — turn it into an informed one. ABSENCE IS NOT ZERO: an
-  // ungraded ship says so, and so does an unlogged cost, because "0.0" and
-  // "$0.00" would read as measurements that were never taken.
-  function acclaimEvidenceHtml(t) {
-    const score = t.grade_score == null ? null : Number(t.grade_score);
-    const grade = score == null || !Number.isFinite(score)
-      ? '<span class="ledger__verdict--none">not graded</span>'
-      : `<span class="${t.grade_passed ? 'ledger__verdict--ok' : 'ledger__verdict--danger'}">${score.toFixed(1)} / 10</span>`;
-    // Three states, not two. The route OMITS cost_usd for a builder who may not
-    // vote, and that is not the same fact as a logged cost of nothing: a reader
-    // who is shown no figure is told nothing, never "no cost logged".
-    const parts = [grade];
-    if (Object.prototype.hasOwnProperty.call(t, 'cost_usd')) {
-      const usd = t.cost_usd == null ? null : Number(t.cost_usd);
-      parts.push(usd == null || !Number.isFinite(usd)
-        ? '<span class="ledger__verdict--none">no cost logged</span>'
-        : `<span class="acclaim__cost">$${usd.toFixed(2)}</span>`);
-    }
-    return `<span class="acclaim__evidence">${parts.join(' · ')}</span>`;
-  }
   // The sign-in itself — the card's one primary control, in every mode, so a
   // returning builder never hunts for it below a form (task 1002851's intent).
   function returningDoorHtml() {
@@ -541,44 +410,24 @@
       }
     });
   }
+  // renderProfile(builder) — the Home surfaces fed by the /me payload: the
+  // Standing chip's card, the welcome line and the system notices. The full
+  // Accomplishments band it also painted went with the view in task 1005050:
+  // your numbers are the Profile page now.
   function renderProfile(builder) {
-    const karma = ctx.lastKarmaState;
     const cost = ctx.lastCostState;
     const needs = ctx.lastNeedsState;
     const rebase = ctx.lastRebaseState;
-    const avatar = builder.avatar_url
-      ? `<img class="profile__avatar" src="${escapeHtml(builder.avatar_url)}" alt="">`
-      : `<div class="profile__avatar" aria-hidden="true"></div>`;
-
     const prefs = Array.isArray(builder.preferred_disciplines) ? builder.preferred_disciplines : [];
 
-    const rankBadge = builder.rank
-      ? renderRankBadge(normalizeRank(builder.rank), { tip: true })
-      : renderRankBadge(builder.rank, { title: 'No rank recorded yet' });
-
     // #757: this builder's place on the Roll. Null until the leaderboard rows
-    // load (they're fetched async after the Standing card's first paint; the
-    // card re-renders once they arrive) — when null the stat simply omits.
+    // load (they're fetched async after the card's first paint; the card
+    // re-renders once they arrive) — when null the stat simply omits.
     const rollPlace = leaderboardPlace(builder.github_login);
-
-    // V3.R26 (#246): karma badge + 30-day delta. Drachmae and karma are two
-    // separate counters — drachmae = work shipped, karma = good citizenship
-    // (peer recognition + Archon ratifications). The tooltip on each badge
-    // spells the distinction out so a new builder can tell them apart.
     const karmaTotal = Number(builder.karma) || 0;
-    const karma30d = karma ? Number(karma.delta_30d) || 0 : 0;
-    const karmaTrendText = karma30d > 0
-      ? `+${fmtNum(karma30d)} in 30d`
-      : (karma30d < 0 ? `${fmtNum(karma30d)} in 30d` : '±0 in 30d');
-    const karmaTrend = `<span class="karma-badge__trend ${signClasses(karma30d, 'karma-badge__trend')}">${karmaTrendText}</span>`;
-    const karmaTooltip = `Karma = peer recognition and approvals. ${curLabel(true)} = everything earned. The two counters move independently — see the karma feed for the audit trail.`;
-    const drachmaeTooltip = `${curLabel(true)} = everything earned: shipped work, approved pages and ideas. Karma is a separate counter for peer recognition and approvals.`;
 
-    // task 1004826: the budget, rebase-owed and needs banners no longer stack on
-    // the Accomplishments band — Home's attention cards carry all three
-    // (renderSystemNotices, below), so here they only repeated it. `need`,
-    // `actionNeeds` and `rebaseTasks` are still computed for that call.
-    // The highest-priority `needs` item that isn't satisfied (ADR 0073).
+    // The highest-priority `needs` item that isn't satisfied (ADR 0073); Home's
+    // attention cards carry it (renderSystemNotices, below).
     const need = (needs && Array.isArray(needs.items))
       ? needs.items.find((n) => n && n.state !== 'satisfied')
       : null;
@@ -592,35 +441,6 @@
       : [];
     // ADR 0120 part 5: un-landed confirmed tasks (Home's "Rebase owed" line).
     const rebaseTasks = Array.isArray(rebase) ? rebase.filter((t) => t && t.id != null) : [];
-    $('#profile-body').innerHTML = `
-      ${avatar}
-      <div>
-        <div class="profile__name-row">
-          <p class="profile__name">${escapeHtml(builder.display_name || builder.github_login || 'Builder')}</p>
-          ${rankBadge}
-        </div>
-        <p class="profile__handle">@${escapeHtml(builder.github_login || 'unknown')}</p>
-        <div class="profile__stats">
-          <span>Member since ${fmtDate(builder.created_at)}</span>
-          <span title="${escapeHtml(karmaTooltip)}">${karmaTrend.replace(' in 30d', ' karma in 30d')}</span>
-          ${rollPlace ? `<span title="Your place on the leaderboard (top ${rollPlace.total}), ranked by ${curLabel()}.">#${rollPlace.place} on the leaderboard</span>` : ''}
-          ${rolePlaceText(rollPlace) ? `<span title="Your place among the ${rollPlace.role.total} builders shown as ${ROLE_AS[rollPlace.role.craft]}, ranked by the ${curLabel()} that role earned.">${rolePlaceText(rollPlace)}</span>` : ''}
-        </div>
-        <div class="profile__disciplines">
-          <span class="profile__disc-label">Preferred work:</span>
-          <span class="profile__disc-value">${prefs.length ? escapeHtml(prefs.join(', ')) : PREFS_EMPTY}</span>
-          <a class="profile__disc-edit" href="/settings">Change in Settings →</a>
-        </div>
-      </div>
-      <div class="profile__credits">
-        <span class="profile__credits-num" title="${escapeHtml(drachmaeTooltip)}">${fmtNum(builder.total_credits)}</span>
-        <span class="profile__credits-label">${(window.OTBBranding?.currencyLabel?.() ?? 'credits')}</span>
-        <span class="profile__karma" title="${escapeHtml(karmaTooltip)}">
-          <span class="profile__karma-num">${fmtNum(karmaTotal)}</span>
-          <span class="profile__karma-label">karma</span>
-        </span>
-      </div>
-    `;
     const welcomeLine = $('#welcome-line');
     if (welcomeLine) {
       welcomeLine.textContent = `Welcome back, ${builder.display_name || builder.github_login || 'builder'}.`;
@@ -658,7 +478,7 @@
             <div><dt>${escapeHtml(curLabel(true))}</dt><dd>${fmtNum(builder.total_credits)}</dd></div>
             <div><dt>Karma</dt><dd>${fmtNum(karmaTotal)}</dd></div>
             <div><dt>Shipped</dt><dd id="standing-shipped">${shipState.seen ? fmtNum(shipState.total) : '—'}</dd></div>
-            <div><dt>Leaderboard place</dt><dd>${place}</dd></div>
+            <div><dt>Leaderboard place</dt><dd>${place}${rolePlaceText(rollPlace) ? `<span title="Your place among the ${rollPlace.role.total} builders shown as ${ROLE_AS[rollPlace.role.craft]}, ranked by the ${curLabel()} that role earned."> · ${rolePlaceText(rollPlace)}</span>` : ''}</dd></div>
           </dl>
           <dl class="home-facts">
             <div><dt>Preferred work</dt><dd>${prefs.length ? escapeHtml(prefs.join(', ')) : PREFS_EMPTY}</dd></div>
@@ -672,12 +492,10 @@
     // hover it widens left to show the name while .hall-standing__more drops down.
     const standingChip = document.getElementById('hall-standing');
     if (standingChip && !ctx.newcomerGated) standingChip.hidden = false;
-    renderRankStanding(builder);
     renderSystemNotices({ rebaseTasks, need, actionNeeds, cost });
   }
 
-  // The ONE string for "no preferred work chosen" — the mock's copy — on both
-  // Standing surfaces (the Home card and the full view), so they cannot drift.
+  // The ONE string for "no preferred work chosen" — the mock's copy.
   const PREFS_EMPTY = 'Not set yet';
 
   const ordinal = (n) => {
@@ -689,8 +507,7 @@
   // task 1003464: the three system notices as inbox LINES on Home (the
   // placement rule in modules/hall-ui/CLAUDE.md: an action awaiting the builder
   // is a line item in Needs-attention, never a card). Only what awaits the
-  // builder lands here — a "we cover it" note is information, and stays on the
-  // full Standing view with the other two, where the banners still render.
+  // builder lands here — a "we cover it" note is information, not an action.
   function renderSystemNotices({ rebaseTasks, need, actionNeeds, cost }) {
     const box = document.getElementById('attention-system');
     if (!box) return;
@@ -749,340 +566,22 @@
       h1.textContent = `${greetingWord(new Date().getHours())}, ${builder.display_name || builder.github_login || 'builder'}`;
     }
   }
-  // task 1004854: Home shows the newest few ships and a count, so loadAll (on
-  // every load AND every live refresh) asks for HOME_SHIPS_LIMIT rows plus the
-  // server's `total`. Only the Accomplishments ledger — its window/version
-  // filters, credits sort and pager work over the whole record — needs every
-  // ship, so `all` is fetched when that view is open, and fetched again only
-  // when the newest ships or the count have moved since (`recentSig`).
+  // task 1004854: Home asks for only the newest HOME_SHIPS_LIMIT ships plus the
+  // server's `total` — on every load AND every live refresh. The count rides the
+  // Standing chip's card. The whole ledger was Accomplishments', which folded into
+  // the Profile page in task 1005050 (its Works ledger reads its own record).
   const HOME_SHIPS_LIMIT = 5;
-  const shipState = { recent: [], total: 0, all: null, versions: [], seen: false, recentSig: null, ledgerSig: null, ledgerLoading: null };
+  const shipState = { recent: [], total: 0, seen: false };
   function setRecentShips(payload) {
     shipState.recent = (payload && payload.ships) || [];
     shipState.total = Number.isFinite(payload && payload.total) ? payload.total : shipState.recent.length;
-    shipState.recentSig = JSON.stringify([shipState.total,
-      shipState.recent.map((s) => [s.id, s.title, s.value_summary, s.credits_awarded, s.visual_url])]);
-    if (!shipState.seen) {
-      // Opening Accomplishments later is what asks for the ledger.
-      document.addEventListener('otbshell:view', (e) => {
-        if (e.detail && e.detail.view === 'standing') loadShipLedger();
-      });
-      shipState.seen = true;
-    }
+    shipState.seen = true;
     renderRecentShips();
-    if (window.OTBShell && window.OTBShell.currentView && window.OTBShell.currentView() === 'standing') loadShipLedger();
-  }
-  function loadShipLedger() {
-    // Never before loadAll has run (a signed-out page must not fetch), never twice at once.
-    if (!shipState.seen || shipState.ledgerSig === shipState.recentSig) return Promise.resolve();
-    if (shipState.ledgerLoading) return shipState.ledgerLoading;
-    const sig = shipState.recentSig;
-    shipState.ledgerLoading = (async () => {
-      try {
-        const data = await getJSON(`${API}/me/recent-ships?limit=all`);
-        shipState.all = (data && data.ships) || [];
-        shipState.ledgerSig = sig;
-        populateShipVersionFilter();
-        renderRecentShips();
-      } catch (err) {
-        console.warn('[builders] ship ledger failed', err && err.message ? err.message : err);
-        const tbody = $('#recent-ships tbody');
-        if (tbody) tbody.innerHTML = emptyRow(4, 'Your work history could not be loaded.');
-      } finally {
-        shipState.ledgerLoading = null;
-      }
-    })();
-    return shipState.ledgerLoading;
-  }
-  // The ledger's version filter: the catalog versions this builder has shipped
-  // to, so it never offers an empty option. Rebuilt (not appended to) on each
-  // call, keeping the reader's pick, so a live refresh cannot duplicate options.
-  function populateShipVersionFilter(versions) {
-    if (versions) shipState.versions = versions;
-    const sel = $('#f-ships-version');
-    if (!sel || !shipState.all) return;
-    const picked = sel.value;
-    const seen = new Set(shipState.all.map((s) => s.version_id).filter(Boolean));
-    while (sel.options.length > 1) sel.remove(1);
-    for (const v of shipState.versions) {
-      if (!seen.has(v.id)) continue;
-      const opt = document.createElement('option');
-      opt.value = v.id;
-      opt.textContent = v.id;
-      if (v.name && v.name !== v.id) opt.title = v.name;
-      sel.appendChild(opt);
-    }
-    sel.value = [...sel.options].some((o) => o.value === picked) ? picked : '';
-  }
-  const shipsPager = window.OTBKit.makePager('ships', 'otb.standing.shipsPerPage', { defaultPerPage: 10 });
-  function filterShips(ships) {
-    const win = $('#f-ships-window')?.value || 'all';
-    const ver = $('#f-ships-version')?.value || '';
-    let cutoff = null;
-    if (win !== 'all') {
-      const days = Number(win);
-      if (Number.isFinite(days) && days > 0) {
-        cutoff = Date.now() - days * 24 * 60 * 60 * 1000;
-      }
-    }
-    return ships.filter((s) => {
-      if (ver && s.version_id !== ver) return false;
-      if (cutoff !== null) {
-        const t = s.shipped_at ? new Date(s.shipped_at).getTime() : 0;
-        if (!t || t < cutoff) return false;
-      }
-      return true;
-    });
-  }
-  function shipCredit(s) {
-    return Number(window.OTBBranding?.taskCreditValue?.(s) ?? s.credits_reward) || 0;
-  }
-  function sortShips(ships, mode) {
-    const copy = ships.slice();
-    if (mode === 'oldest') {
-      copy.sort((a, b) => new Date(a.shipped_at || 0) - new Date(b.shipped_at || 0));
-    } else if (mode === 'drachmae-high') {
-      copy.sort((a, b) => shipCredit(b) - shipCredit(a));
-    } else if (mode === 'drachmae-low') {
-      copy.sort((a, b) => shipCredit(a) - shipCredit(b));
-    } else {
-      // default: most recent first
-      copy.sort((a, b) => new Date(b.shipped_at || 0) - new Date(a.shipped_at || 0));
-    }
-    return copy;
   }
   function renderRecentShips() {
-    const tbody = $('#recent-ships tbody');
-    const countEl = $('#ships-count');
-    const pagerEl = $('#ships-pager');
-
     // task 1004774: the Standing hover card carries the shipped count.
     const standingShipped = document.getElementById('standing-shipped');
     if (standingShipped) standingShipped.textContent = fmtNum(shipState.total);
-
-    // The ledger waits for its own fetch (loadShipLedger); until then it keeps its placeholder.
-    const all = shipState.all;
-    if (!all || !tbody) return;
-    const filtered = filterShips(all);
-    const mode = $('#f-ships-sort')?.value || 'recent';
-    const sorted = sortShips(filtered, mode);
-
-    if (countEl) {
-      const total = all.length;
-      const shown = sorted.length;
-      countEl.textContent = total
-        ? (shown === total
-            ? `${fmtNum(total)} work${total === 1 ? '' : 's'} shipped`
-            : `${fmtNum(shown)} of ${fmtNum(total)} in view`)
-        : '';
-    }
-
-    if (!sorted.length) {
-      tbody.innerHTML = all.length
-        ? emptyRow(4, 'No work matches these filters. Widen the window or pick another version.')
-        : emptyRow(4, 'Nothing shipped yet. Claim a task on the Work board to get started.');
-      if (pagerEl) pagerEl.hidden = true;
-      return;
-    }
-
-    const slice = window.OTBKit.paginate(sorted, shipsPager);
-
-    tbody.innerHTML = slice.map((s) => `
-      <tr>
-        <td class="ledger__num">#${s.id}</td>
-        <td>
-          <div>${escapeHtml(s.title)}</div>
-          ${s.value_summary ? `<div style="color:var(--ink-soft);font-size:0.88rem;font-style:italic;margin-top:2px">${escapeHtml(s.value_summary)}</div>` : ''}
-          ${s.visual_url && window.OTBVisual ? `<div style="margin-top:6px">${window.OTBVisual.shipVisualThumbHtml(s)}</div>` : ''}
-        </td>
-        <td class="ledger__drachmae">${fmtNum(window.OTBBranding?.taskCreditValue?.(s) ?? s.credits_reward)}</td>
-        <td class="ledger__date">${fmtDate(s.shipped_at)}</td>
-      </tr>
-    `).join('');
-  }
-  // No `isArchon` here: the curve's scope was rank-gated until task 1004005, and
-  // the field is gone rather than left write-only — a state flag nothing reads is
-  // how a removed gate quietly grows back.
-  //
-  // `kind` is the active filter (null = all work). `kinds` is the picker's source
-  // — the UNFILTERED fingerprint, held separately because a filtered payload's
-  // top_kinds would otherwise shrink to the one kind selected and strand the
-  // reader there with no way back.
-  const analyticsState = { builderId: null, scope: 'self', kind: null, kinds: [], self: null, eco: null };
-  // The line drawing moved to OTBKit.sparklineHtml (task 1003445) — it was one
-  // of four chart implementations in this surface. This wrapper keeps the
-  // Curve's own default colour, which is NOT the kit's: these four charts each
-  // spend a different accent, and --accent-deep is the first one's.
-  function sparkline(values, opts = {}) {
-    return window.OTBKit.sparklineHtml(values, { color: 'var(--accent-deep)', ...opts });
-  }
-  function statCard(label, value, sub) {
-    return `<div class="curve__stat">
-      <div class="curve__stat-value">${escapeHtml(String(value))}</div>
-      <div class="curve__stat-label">${escapeHtml(label)}</div>
-      ${sub ? `<div class="curve__stat-sub">${escapeHtml(sub)}</div>` : ''}
-    </div>`;
-  }
-  // `overlay` is the ecosystem benchmark for this same chart, or null. When it is
-  // present the card also carries a legend — two lines with no key cannot be
-  // read. The legend is built here rather than inside sparklineHtml because the
-  // NAMES are this page's ("You" / "All builders"), not the kit's.
-  function chartCard(title, values, color, footer, overlay) {
-    const has = Array.isArray(values) && values.length > 0;
-    const hasOverlay = Array.isArray(overlay) && overlay.length > 0;
-    const body = has
-      ? sparkline(values, hasOverlay ? { color, overlay, overlayLabel: 'all builders' } : { color })
-      : '';
-    const legend = has && hasOverlay
-      ? window.OTBKit.chartLegendHtml([
-        { label: 'You', color },
-        { label: 'All builders', color: 'var(--ink-soft)' },
-      ])
-      : '';
-    return window.OTBKit.chartCardHtml(title, body ? body + legend : '', footer);
-  }
-  // The kind picker (task 1004005) — "how am I doing at THIS kind of work".
-  //
-  // Built from analyticsState.kinds, the UNFILTERED fingerprint captured on the
-  // first load, NOT from the current payload's top_kinds. Under a filter the
-  // payload would list only the selected kind, so a picker built from it would
-  // lose every other option the moment one was chosen — the reader could narrow
-  // once and never move again.
-  //
-  // A <select> rather than a row of chips: the kind list is open-ended (it is a
-  // free-text column with an 'unspecified' bucket), so the control has to cope
-  // with more options than fit on a line, and a native select is also the one
-  // that arrives keyboard- and screen-reader-correct with no work.
-  function kindFilterHtml() {
-    const kinds = Array.isArray(analyticsState.kinds) ? analyticsState.kinds : [];
-    if (kinds.length < 2) return ''; // one kind of work is not a choice
-    const cur = analyticsState.kind;
-    const opt = (value, label, n) => {
-      const sel = (value === null ? cur === null : cur === value) ? ' selected' : '';
-      const count = n === undefined ? '' : ` (${n})`;
-      return `<option value="${escapeHtml(value === null ? '' : value)}"${sel}>${escapeHtml(label)}${escapeHtml(count)}</option>`;
-    };
-    return `<span class="curve__filter">`
-      + `<label class="curve__filter-label" for="curve-kind">Kind of work</label>`
-      + `<select id="curve-kind" class="curve__filter-select">`
-      + opt(null, 'All work')
-      + kinds.map((k) => opt(k.kind, k.kind, k.n)).join('')
-      + `</select></span>`;
-  }
-
-  function renderCurveBody() {
-    const headlineEl = $('#curve-headline');
-    const gridEl = $('#curve-grid');
-    const kindsEl = $('#curve-kinds');
-    const emptyEl = $('#curve-empty');
-    const noteEl = $('#curve-scope-note');
-    if (!headlineEl || !gridEl || !kindsEl) return;
-
-    const isEco = analyticsState.scope === 'eco';
-    const data = isEco ? analyticsState.eco : analyticsState.self;
-
-    // The controls — scope toggle and kind filter.
-    //
-    // WRITTEN BEFORE EVERY EARLY RETURN BELOW, and that ordering is the whole
-    // reason they are here. A kind with nothing shipped in the window is an
-    // ordinary, reachable state, and it takes the `totalShipped === 0` branch —
-    // which blanks the headline, the grid and the bars. If the filter that
-    // caused the empty view were drawn after that return, the reader would be
-    // left looking at "no data" with no control on screen to undo it, and the
-    // only way out would be a page reload.
-    //
-    // The scope toggle is no longer Archon-gated (task 1004005): the feed behind
-    // "All builders" is a public, identity-stripped aggregate, so the gate
-    // withheld the comparison rather than protecting anything.
-    if (noteEl) {
-      noteEl.innerHTML =
-        `<span class="curve__scope" role="group" aria-label="Analytics scope">` +
-        `<button type="button" class="curve__scope-btn${!isEco ? ' is-active' : ''}" data-scope="self">You</button>` +
-        `<button type="button" class="curve__scope-btn${isEco ? ' is-active' : ''}" data-scope="eco">All builders</button>` +
-        `</span>` +
-        kindFilterHtml();
-    }
-
-    if (!data) { gridEl.innerHTML = ''; headlineEl.innerHTML = ''; kindsEl.innerHTML = ''; return; }
-
-    // Under a kind filter the server cannot answer cost at all (cost_log has no
-    // kind), and says so in `unavailable` rather than sending a misleading zero.
-    const costUnavailable = Array.isArray(data.unavailable) && data.unavailable.includes('cost_trend');
-
-    const totalShipped = data.headline?.total_shipped || 0;
-    if (totalShipped === 0) {
-      if (emptyEl) emptyEl.style.display = '';
-      headlineEl.innerHTML = ''; gridEl.innerHTML = ''; kindsEl.innerHTML = '';
-      return;
-    }
-    if (emptyEl) emptyEl.style.display = 'none';
-
-    // Headline stat cards.
-    const h = data.headline;
-    const cards = [];
-    cards.push(statCard(isEco ? 'Works shipped' : 'Works shipped', totalShipped, `last ${data.window_days}d`));
-    if (isEco) {
-      cards.push(statCard('Active builders', h.active_builders ?? 0));
-      cards.push(statCard('Avg time / work', mins(h.avg_duration_min)));
-    } else {
-      // '—', never usd(null) → "$0.00". Zero is a measurement; this is the
-      // absence of one, and printing a price here would be a false statement.
-      cards.push(costUnavailable
-        ? statCard('Cost / work', '—', 'not tracked per kind')
-        : statCard('Cost / work', usd(h.cost_per_task)));
-      cards.push(statCard('Avg time / work', mins(h.avg_duration_min)));
-      cards.push(statCard('Confirmation rate', pct(h.confirmation_rate), `${h.resolved_claims || 0} claims`));
-      cards.push(statCard('Grade pass rate', pct(h.grade_pass_rate), `${h.graded_n || 0} graded`));
-    }
-    headlineEl.innerHTML = cards.join('');
-
-    // Sparkline charts.
-    //
-    // THE OVERLAY ONLY EVER RIDES ON THE 'self' VIEW, and only where the
-    // ecosystem publishes the SAME series. Overlaying the benchmark on the
-    // benchmark would draw one line twice; and the ecosystem feed carries only
-    // ship-rate and duration (grade and cost have their own public feeds and are
-    // not part of that payload), so those two are the only charts that CAN
-    // compare. A chart with no counterpart simply draws one line, as before.
-    const eco = (!isEco && analyticsState.eco) ? analyticsState.eco : null;
-    const ecoOf = (rows, pick) => (eco && Array.isArray(eco[rows]) ? eco[rows].map(pick) : null);
-    const charts = [];
-    charts.push(chartCard('Works shipped / day', (data.ship_rate || []).map((r) => r.n), 'var(--accent-deep)',
-      `${(data.ship_rate || []).reduce((s, r) => s + Number(r.n), 0)} over ${data.window_days}d`,
-      ecoOf('ship_rate', (r) => r.n)));
-    charts.push(chartCard('Time / work (min)', (data.duration_trend || []).map((r) => r.avg_actual), 'var(--sea)',
-      'actual minutes per shipped work',
-      ecoOf('duration_trend', (r) => r.avg_actual)));
-    if (!isEco) {
-      // COST IS NOT ANSWERABLE PER KIND — cost_log has no kind and reaches tasks
-      // only through a mostly-NULL task_id, so the server returns cost_trend: []
-      // and names it in `unavailable` rather than plotting a near-zero line that
-      // would read as "this kind of work is cheap". Say so where the chart was.
-      if (costUnavailable) {
-        charts.push(window.OTBKit.chartCardHtml('Cost / work ($)', '',
-          '', 'not tracked per kind of work — clear the filter to see cost'));
-      } else {
-        charts.push(chartCard('Cost / work ($)', (data.cost_trend || []).map((r) => r.per_work), 'var(--terracotta)',
-          `total ${usd(h.total_cost_usd)}`));
-      }
-      // n counts quality-graded rows only (task 1002652); a day whose grades
-      // were all outages has n=0 and must not plot as a 0% dip.
-      charts.push(chartCard('Grade pass rate', (data.grade_trend || []).filter((r) => Number(r.n) > 0).map((r) => r.n_passed / r.n), 'var(--accent)',
-        'share of work passing review'));
-    }
-    gridEl.innerHTML = charts.join('');
-
-    // Top kinds — horizontal bars.
-    const kinds = (data.top_kinds || []).slice(0, 8);
-    if (kinds.length) {
-      kindsEl.innerHTML =
-        `<div class="kit-chart__title">Kinds of work shipped</div>` +
-        window.OTBKit.barSeriesHtml(
-          kinds.map((k) => ({ label: k.kind, value: k.n })),
-        );
-    } else {
-      kindsEl.innerHTML = '';
-    }
   }
   // The Roll’s rows, kept ONLY for leaderboardPlace() below — the Standing
   // card’s "#N on the leaderboard" stat. sortBy/sortDir went to /roster with
@@ -1120,6 +619,6 @@
   }
 
 
-    return { acclaimEvidenceHtml, analyticsState, lbState, mountHallWidgets, renderCurveBody, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderProfile, renderRecentShips, HOME_SHIPS_LIMIT, loadShipLedger, populateShipVersionFilter, setRecentShips, shipState, shipsPager };
+    return { lbState, mountHallWidgets, renderGreeting, renderLanding, renderSessionRefused, renderNav, renderProfile, renderRecentShips, HOME_SHIPS_LIMIT, setRecentShips, shipState };
   };
 })();