@bongos/core 1.24.42 → 1.24.43

package/tests/helpers.mjs

@@ -542,7 +542,9 @@ const PROFILE_CRAFTS_JS = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/publi
 // tab each. The default leads with the ideator, so the trail is the first tab
 // and a suite that reads it needs no switch; switchCraft('engineer') opens the
 // works and goals, switchCraft('artist') the approved pages.
-export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator', 'engineer'], artistPages = [] } = {}) {
+// `search` is the page's ?query (task 1005050: ?id= decides whose profile it is), and
+// `withOwn` also loads profile-own.js, the "Just you" screen drawn on your own profile.
+export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator', 'engineer'], artistPages = [], search = '', withOwn = false } = {}) {
   const els = new Map();
   const makeEl = () => ({
     dataset: {}, style: {}, textContent: '', hidden: false, _html: '',
@@ -617,6 +619,8 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
       return { active: () => current, activate(id) { current = id; onChange(id); }, setCount() {} };
     },
     shipVisualThumbHtml: () => '',
+    // profile-own.js's peer-recognition pager (task 1005050).
+    paginate: (rows) => rows, wirePager() {}, pagerBarHtml: () => '',
   };
 
   const windowObj = {
@@ -638,7 +642,7 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
       rankLabel: (r) => r,
       toast() {},
     },
-    location: { hostname: 'builders.cloudbongos.com', search: '', pathname: '/profile' },
+    location: { hostname: 'builders.cloudbongos.com', search, pathname: '/profile' },
     localStorage: { getItem: () => null, setItem() {} },
     addEventListener() {},
     matchMedia: () => ({ matches: false }),
@@ -655,6 +659,7 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
   vm.runInContext(PROFILE_ROLES_JS, sandbox, { filename: 'profile-roles.js' });
   vm.runInContext(IDEA_OBJECTS_JS, sandbox, { filename: 'idea-objects.js' });
   vm.runInContext(PROFILE_CRAFTS_JS, sandbox, { filename: 'profile-crafts.js' });
+  if (withOwn) vm.runInContext(fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/profile-own.js'), 'utf8'), sandbox, { filename: 'profile-own.js' });
   vm.runInContext(PROFILE_JS, sandbox, { filename: 'profile.js' });
 
   const htmlFor = (mountId) => {
@@ -666,6 +671,7 @@ export function bootProfilePage({ signedIn = true, trail = [], roles = ['ideator
     htmlFor,
     switchCraft: (id) => { if (tabsOnChange) tabsOnChange(id); },
     el: (id) => documentObj.getElementById(id),
+    window: windowObj,
   };
 }
 

package/tests/leaderboard_roles.mjs

@@ -236,7 +236,7 @@ function extract(src, start, end) {
 
 await test('the standing card adds the place inside the builder\'s main role, only when it says something new', () => {
   const src = read('modules/hall-ui/public/hall-render.js');
-  const code = extract(src, 'const lbState = { rows: [] };', '    return { acclaimEvidenceHtml');
+  const code = extract(src, 'const lbState = { rows: [] };', '    return { lbState');
   const sandbox = { rows: FIX.leaderboard };
   vm.createContext(sandbox);
   vm.runInContext(`${code}; lbState.rows = rows; this.place = leaderboardPlace; this.text = rolePlaceText;`, sandbox);

package/tests/module_contributions.mjs

@@ -314,11 +314,13 @@ test('hall-widget registry: placement rules reject bad registrations, accept goo
     assert.ok(reg({ id: 'e', view: 'home', zone: 'home-main', summary: true }));
     assert.ok(reg({ id: 'f', view: 'home', zone: 'home-main', collapsedByDefault: true }));
     assert.ok(reg({ id: 'g', view: 'home', zone: 'home-main', core: true }));
-    // a non-Home view needs no zone (Standing widgets carry `group` instead)
-    assert.ok(reg({ id: 'h', view: 'standing', group: 'work' }));
+    // task 1005050: 'standing' (Accomplishments) left the views with the view
+    // itself — it folded into the Profile page — so a widget naming it is refused.
+    assert.equal(reg({ id: 'h', view: 'standing', group: 'work' }), null);
+    assert.match(errors.at(-1), /unknown view "standing"/);
 
-    // only the accepted four reached the registry
-    assert.deepEqual(OTB.hallWidgetIds(), ['e', 'f', 'g', 'h']);
+    // only the accepted three reached the registry
+    assert.deepEqual(OTB.hallWidgetIds(), ['e', 'f', 'g']);
   } finally {
     console.error = realError;
     delete global.window;

package/tests/nav_permission_atoms.mjs

@@ -97,8 +97,9 @@ test('the hall-preview fixture carries every atom /me resolves', () => {
 // core-update banner; task 1005045: the Market Watch settings item left (one sidebar item);
 // task 1005046: Ranks, Economy and Diagrams left Docs (one reading room, the Primer);
 // task 1005049: Sessions and Autobongos left the sidebar (tabs on Watch);
-// task 1005076: the setup flow's holdForSetup.
-const SHELL_SHA = '248d104831bae0de';
+// task 1005076: the setup flow's holdForSetup;
+// task 1005050: Accomplishments left it (folded into Profile; its hashes redirect).
+const SHELL_SHA = '050dbf4ceac560dc';
 
 test('shell.js has not changed without its cache-bust being bumped', () => {
   const actual = crypto.createHash('sha256').update(SHELL).digest('hex').slice(0, 16);

package/tests/page_tweak_artist.mjs

@@ -195,7 +195,8 @@ await test('the status page and the acclaim feed render the helper', () => {
   const status = readFileSync(new URL('../modules/status-ui/public/status.js', import.meta.url), 'utf8');
   assert.match(status, /t\.helper_display_name \|\| t\.helper_login/);
   assert.match(status, /with help from \$\{helper\}/);
-  const hall = readFileSync(new URL('../modules/hall-ui/public/builders.js', import.meta.url), 'utf8');
+  // task 1005050: the acclaim feed moved with Accomplishments to the profile's "Just you" screen.
+  const hall = readFileSync(new URL('../modules/hall-ui/public/profile-own.js', import.meta.url), 'utf8');
   assert.match(hall, /with help from \$\{escapeHtml\(helperName\)\}/, 'escaped before it reaches innerHTML');
   const feed = readFileSync(new URL('../modules/lifecycle/routes/tasks.js', import.meta.url), 'utf8');
   assert.match(feed, /helper\.helper_login, helper\.helper_display_name/, 'the acclaim feed carries the helper');

package/tests/rank_tier_single_source.mjs

@@ -93,6 +93,9 @@ const STATIC_LADDER_FILES = [
   'modules/discord/discord-channels.js',
   'modules/memory/search.js',
   'modules/hall-ui/public/profile.js',
+  // task 1005050: Where you stand moved with Accomplishments to the profile's "Just
+  // you" screen and reads the rung above yours off this ladder.
+  'modules/hall-ui/public/profile-own.js',
   // task 1005048: the rank <select> on each roster row moved from watch.js to the
   // Builders page with the roster itself; the copy moved with it.
   'modules/hall-ui/public/roster.js',

package/tests/task_visuals.mjs

@@ -280,7 +280,9 @@ await t('the callers reach for OTBVisual, and no longer for the kit', () => {
     assert.ok(!/OTBKit(\.|\[')?\s*(shipVisualThumbHtml|taskVisualFigureHtml|isTaskVisualUrl)/.test(src),
       `${f} still reads a visual renderer off OTBKit`);
   }
-  assert.ok(HALL('hall-render.js').includes('window.OTBVisual.shipVisualThumbHtml'));
+  // task 1005050: Home's ship ledger (the one hall-render.js thumbnail) left with
+  // Accomplishments; the Profile's Works ledger is the ship-thumbnail caller now.
+  assert.ok(HALL('profile.js').includes('window.OTBVisual.shipVisualThumbHtml'));
   assert.ok(HALL('studio.js').includes('vis.taskVisualFigureHtml('));
 });