@bongos/core 1.21.4 → 1.21.6

package/tests/wizard_physics.mjs

@@ -1,11 +1,12 @@
 // tests/wizard_physics.mjs — planet physics, questions 1 to 4, in the create wizard
-// (task 1004418 / BV2.PS07, goal 1000121).
+// (task 1004418 / BV2.PS07, goal 1000121; regrouped by task 1004504).
 //
-// Done-when: the four questions and their branches work end to end (state incl. the
-// existing-project branch and the stop screen; geography; ages with the guardian
-// tiers; entity, intent when new and legal type when it exists), the planet states
-// match the canvas, answers save through the create's `detail`, and the options the
-// soft-limit table hides or greys show their reason (spec D6).
+// Done-when: the questions and their branches work end to end (geography; ages with
+// the guardian tiers; entity, intent when new and legal type when it exists; the stop
+// screen), answers save through the create's `detail`, and the options the soft-limit
+// table hides or greys show their reason (spec D6). Since task 1004504 geography, ages
+// and entity are the "few quick checks" screen and the project's state is the review's
+// Code row; the forming planet left with the rail (the night room replaced it).
 //
 // Three layers, all RUN: the server's pre-create check over a mounted router; the
 // page's vocabularies against planet-physics.js (a page cannot require a module, so
@@ -93,28 +94,41 @@ test('a builder who loops the check is slowed down, and another builder is not',
 });
 
 // ── the page's vocabularies are the server's ─────────────────────────────────
-// questions 5 to 7 joined the same region (task 1004419, tests/wizard_physics_more.mjs)
-const SCRIPT = HUB.slice(HUB.indexOf('/* ── planet physics, questions 1 to 7 (tasks 1004418 and 1004419, BV2.PS07 + PS11) ──'),
-  HUB.indexOf('    /* per-panel validation on Next */'));
+// questions 5 to 7 joined the same region (task 1004419, tests/wizard_physics_more.mjs);
+// the region runs to the row checks the old steps made on Next (task 1004504)
+const START = '/* ── planet physics (tasks 1004418 and 1004419, BV2.PS07 + PS11; regrouped by task 1004504) ──';
+const END = '    /* ── checks the old steps made on Next, now made by their rows ── */';
+assert.ok(HUB.indexOf(START) > -1, 'the physics region opens with its sentinel comment');
+assert.ok(HUB.indexOf(END, HUB.indexOf(START)) > HUB.indexOf(START), 'and closes where the row checks begin');
+const SCRIPT = HUB.slice(HUB.indexOf(START), HUB.indexOf(END, HUB.indexOf(START)));
 
 test('the page carries the server\'s countries, regions and entity forms, exactly', () => {
   assert.ok(SCRIPT.length > 1000, 'the physics controller was found');
+  assert.ok(SCRIPT.includes('function checksAdvance()'), 'and it carries the quick checks\' Continue');
   const box = {};
   vm.createContext(box);
-  vm.runInContext(SCRIPT.slice(0, SCRIPT.indexOf('    var PHYS_LAST')).replace(/\bvar /g, 'this.'), box);
+  vm.runInContext(SCRIPT.slice(0, SCRIPT.indexOf('    var physLimits = [];')).replace(/\bvar /g, 'this.'), box);
   const plain = (v) => JSON.parse(JSON.stringify(v)); // values born in the vm
   assert.deepEqual(plain(box.PHYS_COUNTRIES), [...physics.COUNTRY_CODES]);
   assert.deepEqual(Object.keys(box.PHYS_REGIONS).sort(), [...physics.REGION_CODES].sort());
   assert.deepEqual(plain(box.PHYS_ENTITY_FORMS), [...physics.ENTITY_FORMS]);
-  for (const k of Object.keys(box.PHYS_MATERIAL)) {
+  // every entity the page has words for is an entity answer (PHYS_MATERIAL, the plates
+  // per entity, left with the forming planet in task 1004504)
+  assert.equal(box.PHYS_MATERIAL, undefined, 'the per-entity plates are gone');
+  for (const k of Object.keys(box.PHYS_SAY.entity)) {
     assert.notEqual(physics.canonicalAnswer(physics.PLANET_PHYSICS_QUESTIONS.entity, k), undefined, `${k} is an entity answer`);
   }
 });
 
 test('every choice the questions offer is an answer the server accepts', () => {
-  const panel = HUB.slice(HUB.indexOf('id="panel-physics"'), HUB.indexOf('<!-- step 4 · name'));
+  // the quick checks, and the rows of the review that host the rest (task 1004504)
+  const panel = HUB.slice(HUB.indexOf('<section id="view-new"'), HUB.indexOf('<!-- 5 · a look, then Create'));
+  const checks = HUB.slice(HUB.indexOf('id="panel-checks"'), HUB.indexOf('<!-- 4 · check what we set up'));
+  assert.deepEqual([...new Set([...checks.matchAll(/data-phys="([a-z_]+)"/g)].map((m) => m[1]))], ['builder_geography', 'minors_on_board', 'entity'],
+    'the quick checks ask where builders will be, about under-18s and who is behind it');
+  assert.match(checks, /<select id="physCountry">/, 'and where you are');
   const seen = [...panel.matchAll(/data-phys="([a-z_]+)" data-val="([^"]+)"/g)];
-  assert.ok(seen.length >= 20, 'the four questions\' choices');
+  assert.ok(seen.length >= 20, 'the questions\' choices');
   for (const [, key, raw] of seen) {
     const one = raw === 'true' ? true : raw === 'false' ? false : raw;
     // a list question's choice is one member of the list it sends (task 1004419)
@@ -128,9 +142,10 @@ test('every choice the questions offer is an answer the server accepts', () => {
 });
 
 test('the age tiers are described, never claimed as enforced (spec D6)', () => {
-  const ages = HUB.slice(HUB.indexOf('id="physAges"'), HUB.indexOf('<div class="physQ" data-q="4"'));
+  const ages = HUB.slice(HUB.indexOf('id="physAges"'), HUB.indexOf('id="physIntent"'));
+  assert.ok(ages.length > 100, 'the age tiers sit between the under-18 question and who is behind it');
   assert.match(ages, /13 to 15<\/dt><dd>Non-monetary tracks only/);
-  assert.match(ages, /the platform does not check ages for you yet/);
+  assert.match(ages, /[Tt]he platform does not check ages for you yet/);
   assert.doesNotMatch(ages, /apply automatically|enforced/i);
 });
 
@@ -157,11 +172,13 @@ function boot({ checkAnswer = { stop: false, soft_limits: { limits: [] } } } = {
   const $ = (id) => (els[id] = els[id] || new El(id));
   const shown = [];
   const fetched = [];
-  const state = { description: '', teamShape: null, physics: null };
+  const state = { description: '', teamShape: null, physics: null, mode: 'greenfield', confirmed: {} };
   const sandbox = {
     $, state, API: '/api/bongos', document: { createElement: () => new El('opt') },
     root: { querySelectorAll: () => [], querySelector: () => null },
     saveDraft() {}, show(n) { shown.push(n); }, Intl,
+    // the review's machinery lives outside this region (tests/wizard_physics_more.mjs runs it)
+    paintSetup() {}, unconfirm() {}, setMode(m) { state.mode = m; }, authKnown: true,
     fetch: async (url, opts) => { fetched.push({ url, body: opts && opts.body && JSON.parse(opts.body) }); return { ok: true, json: async () => (url.includes('physics-check') ? checkAnswer : []) }; },
   };
   vm.createContext(sandbox);
@@ -170,51 +187,56 @@ function boot({ checkAnswer = { stop: false, soft_limits: { limits: [] } } } = {
 }
 const tick = () => new Promise((r) => setTimeout(r, 0));
 
-test('Continue walks the questions and moves the wizard on only after the last', async () => {
-  const w = boot();
+test('Continue on the quick checks asks for each answer, then the server, and only then moves on', async () => {
+  const w = boot({ checkAnswer: { stop: false, soft_limits: { limits: [{ option: 'equity', effect: 'note', reason: 'r' }] } } });
   const a = () => w.state.physics.answers;
-  assert.equal(w.run('physAdvance()'), false, 'the step never says yes itself');
-  assert.equal(w.state.physics.q, 1, 'from the start screen to question 1');
-  w.run('physAdvance()');
-  assert.equal(w.state.physics.q, 1, 'question 1 unanswered: it stays');
-  assert.match(w.$('h-phys').textContent, /new or existing/);
-  a().project_state = 'existing';
-  w.run('physAdvance()');
-  assert.match(w.$('h-phys').textContent, /what already exists/i, 'an existing planet must say what exists');
-  a().existing_work = ['code', 'digital-files']; a().main_work = 'code';
-  w.state.description = 'A co-op farming game.';
-  w.run('physAdvance()');
-  await tick(); await tick();
-  assert.equal(w.state.physics.q, 2, 'the screen passed it, on to geography');
-  assert.deepEqual(w.fetched.at(-1).body, { description: 'A co-op farming game.', detail: { project_state: 'existing', existing_work: ['code', 'digital-files'], main_work: 'code' } });
-  w.run('physAdvance()');
-  assert.equal(w.state.physics.q, 2, 'no country: it stays');
-  a().home_country = 'US'; a().home_region = 'US-CA'; a().builder_geography = 'us-eu';
-  w.run('physAdvance()');
-  assert.equal(w.state.physics.q, 3);
+  assert.equal(w.run('checksAdvance()'), false, 'the screen never says yes itself');
+  assert.match(w.$('h-phys').textContent, /Pick your country/);
+  a().home_country = 'US'; a().home_region = 'US-CA';
+  w.run('checksAdvance()');
+  assert.match(w.$('h-phys').textContent, /where builders will be/);
+  a().builder_geography = 'us-eu';
+  w.run('checksAdvance()');
+  assert.match(w.$('h-phys').textContent, /under 18/);
   a().minors_on_board = true;
-  w.run('physAdvance()');
-  assert.equal(w.state.physics.q, 4);
-  w.run('physAdvance()');
-  assert.deepEqual(w.shown, [], 'no entity: still here');
+  w.run('checksAdvance()');
+  assert.match(w.$('h-phys').textContent, /who’s behind it/);
+  assert.equal(w.fetched.length, 0, 'nothing is asked of the server until every answer is given');
   a().entity = 'for-profit';
-  w.run('physAdvance()');
+  w.state.description = 'A co-op farming game.';
+  w.run('checksAdvance()');
+  w.run('checksAdvance()');
   await tick(); await tick();
-  // task 1004419: questions 5 to 7 and the summary follow inside the same step
-  // (walked to the name step in tests/wizard_physics_more.mjs)
-  assert.equal(w.state.physics.q, 5, 'on to question 5');
-  assert.deepEqual(w.shown, [], 'and the wizard has not moved on');
+  assert.equal(w.fetched.length, 1, 'a second Continue while the first is out asks nothing more');
+  assert.equal(w.fetched[0].url, '/api/bongos/provisioning/physics-check');
+  // the review's prefills are written on the way: a new project, one person, all managed
+  assert.deepEqual(w.fetched[0].body, { description: 'A co-op farming game.', detail: {
+    project_state: 'new', home_country: 'US', home_region: 'US-CA', builder_geography: 'us-eu', minors_on_board: true, entity: 'for-profit',
+    builders_at_start: 1, builders_expected: 1, framing: 'managed', voice: 'professional' } });
+  assert.equal(w.state.teamShape, 'solo', 'one person is a solo team shape');
+  assert.equal(w.$('h-phys').textContent, ' ', 'the ask clears');
+  assert.deepEqual(w.shown, [4], 'the screen passed it: on to the review');
+  assert.equal(JSON.stringify(w.run('physLimits')), JSON.stringify([{ option: 'equity', effect: 'note', reason: 'r' }]), 'and its soft limits shape the review');
 });
 
-test('a stopped description lands on the stop screen with the server\'s words', async () => {
+test('a stopped description lands on the stop screen with the server\'s words, and Start over clears it all', async () => {
   const w = boot({ checkAnswer: { stop: true, message: STOP_MESSAGE, soft_limits: { limits: [] } } });
-  w.run('physAdvance()');
-  w.state.physics.answers.project_state = 'new';
+  w.run('phys()');
+  Object.assign(w.state.physics.answers, { home_country: 'NL', builder_geography: 'global', minors_on_board: false, entity: 'intent-solo' });
   w.state.description = 'ransomware';
-  w.run('physAdvance()');
+  w.run('checksAdvance()');
   await tick(); await tick();
-  assert.equal(w.state.physics.q, 'stop');
   assert.equal(w.$('physStopMsg').textContent, STOP_MESSAGE);
+  assert.equal(w.$('checksStop').hidden, false, 'the stop screen shows');
+  assert.equal(w.$('checksMain').hidden, true, 'in place of the questions');
+  assert.deepEqual(w.shown, [], 'and nothing moves on: nothing exists to undo');
+  w.state.confirmed = { code: true };
+  w.$('physStartOver').listeners.click();
+  assert.equal(w.state.description, '');
+  assert.equal(JSON.stringify(w.state.physics.answers), '{}', 'every answer goes');
+  assert.equal(JSON.stringify(w.state.confirmed), '{}', 'and every confirmed row');
+  assert.deepEqual(w.shown, [2], 'back to "What are you making?"');
+  assert.equal(w.$('checksMain').hidden, false, 'with the questions back in place');
 });
 
 test('the create sends the answers as detail: existing work only for an existing planet, the team shape beside them', () => {
@@ -223,49 +245,45 @@ test('the create sends the answers as detail: existing work only for an existing
   Object.assign(w.state.physics.answers, { project_state: 'new', existing_work: ['code'], main_work: 'code', home_country: 'NL', builder_geography: 'global', minors_on_board: false, entity: 'intent-solo' });
   w.state.teamShape = 'solo';
   assert.deepEqual(JSON.parse(JSON.stringify(w.run('createDetail()'))), {
-    project_state: 'new', home_country: 'NL', builder_geography: 'global', minors_on_board: false, entity: 'intent-solo', voice: 'planet', team_shape: 'solo',
-  });
+    project_state: 'new', home_country: 'NL', builder_geography: 'global', minors_on_board: false, entity: 'intent-solo', voice: 'professional', team_shape: 'solo',
+  }, 'one plain voice since task 1004504: an individual is sent the professional voice too');
+  w.state.physics.answers.entity = 'for-profit';
+  assert.equal(w.run('createDetail()').voice, 'professional', 'and so is an organization');
+  w.state.physics.answers.project_state = 'existing';
+  assert.deepEqual(JSON.parse(JSON.stringify(w.run('createDetail()'))).existing_work, ['code'], 'an existing planet sends what exists');
+  w.state.demo = { people: 3, hours_each: 4 };
+  assert.deepEqual(JSON.parse(JSON.stringify(w.run('createDetail()'))), { team_shape: 'solo' }, 'a demo sends only its team shape');
+  w.state.demo = null;
   w.state.physics.answers = {}; w.state.teamShape = null;
   assert.equal(w.run('createDetail()'), undefined, 'nothing answered: the detail is omitted, as before');
 });
 
-test('the planet forms from the answers: a seed, a formed planet, the protective ring, the core material', () => {
-  const w = boot();
-  w.run('phys()');
-  const src = () => w.$('physPlanet').getAttribute('src');
-  w.state.physics.q = 1; w.state.physics.answers.project_state = 'new';
-  w.run('physPaintStage()');
-  assert.equal(src(), '/assets/world/r2-chrome-blob-one-cut.webp', 'a seed');
-  w.state.physics.answers.project_state = 'existing';
-  w.run('physPaintStage()');
-  assert.equal(src(), '/assets/world/r2-chrome-blobs-set-cut.webp', 'terrain already formed');
-  assert.equal(w.$('physGuard').hidden, true);
-  w.state.physics.q = 3; w.state.physics.answers.minors_on_board = true;
-  w.run('physPaintStage()');
-  assert.equal(w.$('physGuard').hidden, false, 'the protective ring');
-  w.state.physics.q = 4;
-  for (const [entity, plate] of [['intent-solo', 'r3-frost-blob-cut'], ['for-profit', 'r3-gold-blob-cut'], ['nonprofit', 'r3-obsidian-blob-cut']]) {
-    w.state.physics.answers.entity = entity;
-    w.run('physPaintStage()');
-    assert.equal(src(), `/assets/world/${plate}.webp`, entity);
-  }
-  for (const plate of ['r3-frost-blob-cut', 'r3-gold-blob-cut', 'r3-obsidian-blob-cut', 'r2-chrome-blob-one-cut', 'r2-chrome-blobs-set-cut']) {
-    assert.ok(fs.existsSync(path.join(LANDING, 'assets', 'world', `${plate}.webp`)), `${plate} is a world plate`);
+test('the forming planet is gone: the night room stands behind the wizard instead (task 1004504)', () => {
+  for (const gone of ['physPaintStage', 'PHYS_MATERIAL', 'PHYS_CORE_WORD', 'PHYS_ORBIT', 'physAdvance', 'physNextQ', 'physPrevQ', 'physSummaryRows']) {
+    assert.ok(!HUB.includes(gone), `${gone} is gone`);
   }
+  assert.doesNotMatch(HUB, /id="(physPlanet|physGuard|physStage|panel-physics|physSummary)"/, 'and so is its markup');
+  assert.match(HUB, /<div class="wizRoom" id="wizRoom" data-screen="fork" aria-hidden="true">/, 'the room is decoration only');
+  const seed = HUB.match(/<span class="rmSeed"><img src="\/assets\/world\/([a-z0-9-]+)\.webp" alt=""><\/span>/);
+  assert.ok(seed, 'the room\'s seed is a world plate');
+  assert.ok(fs.existsSync(path.join(LANDING, 'assets', 'world', `${seed[1]}.webp`)), `${seed[1]} exists`);
 });
 
 test('a limit the table puts on an option shows its reason beside it, and a grey one is disabled', () => {
   const w = boot();
   const why = new El('why');
   const btn = new El('btn');
+  const fieldset = new El('physExisting');
   w.sandbox.root.querySelector = (sel) => (sel.includes('data-why="existing_work"') ? why : null);
-  w.sandbox.root.querySelectorAll = (sel) => (sel.includes('data-phys="entity"][data-val="intent-solo"') ? [btn] : []);
+  w.sandbox.root.querySelectorAll = (sel) => (sel.includes('data-phys="entity"][data-val="intent-solo"') ? [btn]
+    : sel.includes('[data-limit="existing_work"]') ? [fieldset] : []);
   w.run(`physLimits = [
     { option: 'existing_work', effect: 'hide', reason: 'Your planet is new, so there is nothing built yet to describe.' },
     { option: 'entity:intent-solo', effect: 'grey', reason: 'Because.' }
   ]; physApplyLimits();`);
   assert.equal(why.hidden, false);
   assert.match(why.textContent, /nothing built yet/);
+  assert.equal(fieldset.hidden, true, 'a question the table hides is hidden in place');
   assert.equal(btn.disabled, true);
   assert.equal(btn.title, 'Because.');
 });