@bongos/core 1.21.4 → 1.21.6

package/tests/hub_craft_rollup.mjs

@@ -0,0 +1,350 @@
+// tests/hub_craft_rollup.mjs — task 1004440 (WA6.RP10, goal 1000095, criterion
+// wa6-roles-read-true-in-public): the hub profile shows each craft's own work.
+//
+// The cross-project rollup used to carry one ship count (with no status filter)
+// and "Roles" from the declared preference alone, so on the hub an artist with
+// forty approved pages, or an ideator the board ratified, read as an engineer
+// with nothing shipped. Three halves, each driven through its real code:
+//
+//   1. THE SENDER (core auth-admission.js reportActivityRollup) counts SHIPPED
+//      works only, sends each EARNED craft's counts (the ledger split decides,
+//      as on the local profile), derives `disciplines` from that evidence with
+//      the declared preference as the fallback, and — because the hub validates
+//      the body strictly — re-sends once without `crafts` when an older hub
+//      refuses the field, so the totals are never lost.
+//   2. THE HUB ROUTE + upsertActivity accept `crafts` and bind only the
+//      sanitised shape: three crafts, named counts, integers or null. Nothing a
+//      sender writes can carry text through it.
+//   3. getRollupForBuilder sums each craft over EVERY project row — named or
+//      not, exactly as the totals are (the aggregate is not the leak, the name
+//      is) — and the profile page draws a tile per craft from that sum.
+//
+// DB-free: the hub_recent_ships.mjs / activity_rollup_as_of.mjs idioms (pinned
+// require.cache, stubbed fetch, a recording fake pool).
+//
+// Run:  node tests/hub_craft_rollup.mjs
+
+import { strict as assert } from 'node:assert';
+import { createRequire } from 'node:module';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+
+let passed = 0, failed = 0;
+async function t(name, fn) {
+  try { await fn(); passed++; console.log(`  ok  ${name}`); }
+  catch (e) { failed++; console.error(`  FAIL ${name}\n       ${e.message}`); }
+}
+
+function mockPool(answer = () => ({ rows: [] })) {
+  const calls = [];
+  const query = async (text, params = []) => {
+    calls.push({ text: String(text), params });
+    return answer(String(text), params) || { rows: [] };
+  };
+  return {
+    calls, query,
+    connect: async () => ({ query, release: () => {} }),
+    find: (re) => calls.find((c) => re.test(c.text)),
+  };
+}
+const pin = (rel, exports) => {
+  const p = require.resolve(rel);
+  require.cache[p] = { id: p, filename: p, loaded: true, exports };
+};
+
+// ---- 1. the sender ----------------------------------------------------------
+
+console.log('\n1. the instance sends each earned craft, and shipped means shipped:');
+
+const seams = require('../src/module-seams.js');
+
+// One rollup through the real sender. `byCraft` is economy's ledger split for
+// builder 7 (null = no economy module); `ports` the craft stats; `statuses` the
+// HTTP status each successive send answers.
+async function sendRollup({ byCraft = null, preferred = ['engineer'], ports = {}, statuses = [200] } = {}) {
+  seams._reset();
+  if (byCraft) {
+    seams.registerProvider('reward', {
+      creditsByCraft: async (ids) => new Map(ids.map((id) => [String(id), byCraft])),
+      craftForPreference: (d) => (d === 'ui' ? 'artist' : ['engineer', 'artist', 'ideator'].includes(d) ? d : null),
+    });
+  }
+  for (const [k, fn] of Object.entries(ports)) seams.registerProvider(k, fn);
+  const senderPool = mockPool((sql) => {
+    if (/FROM builders WHERE id/.test(sql)) {
+      return { rows: [{ github_id: 42, total_credits: 900, karma: 2, rank: 'thetes', preferred_disciplines: preferred }] };
+    }
+    if (/count\(\*\)/.test(sql)) return { rows: [{ n: 5 }] };
+    return { rows: [] };
+  });
+  pin('../src/bongos/pool.js', { pool: senderPool });
+  pin('../src/bongos/auth-config.js', {
+    loadIdpConfig: () => ({ origin: 'https://hub.example', clientId: 'c1', clientSecret: 's' }),
+  });
+  delete require.cache[require.resolve('../src/bongos/auth-admission.js')];
+  const { reportActivityRollup } = require('../src/bongos/auth-admission.js');
+  const sent = [];
+  const realFetch = globalThis.fetch;
+  globalThis.fetch = async (url, opts) => {
+    sent.push(JSON.parse(opts.body));
+    const status = statuses[Math.min(sent.length - 1, statuses.length - 1)];
+    return { ok: status < 300, status, json: async () => ({}) };
+  };
+  try { await reportActivityRollup({ builderId: 7 }); } finally { globalThis.fetch = realFetch; seams._reset(); }
+  return { sent, senderPool };
+}
+
+const ARTIST_STATS = async () => ({ pages_approved: 42, pages: 30, surfaces_touched: 3, credits: 1100, this_week: 12, surfaces: [{ label: 'Landing', line: 'secret wording' }] });
+const IDEATOR_STATS = async () => ({ filed: 12, ignited: 4, full_ideas: 2, ratified: 1, size: { total: 9 }, alive: { share: 0.5 } });
+
+await t('the ship count asks for SHIPPED works only (the missing status filter)', async () => {
+  const { senderPool } = await sendRollup();
+  const q = senderPool.find(/count\(\*\)/);
+  assert.ok(q, 'the ship count ran');
+  assert.match(q.text, /shipped_by = \$1/);
+  assert.match(q.text, /status = 'shipped'/, 'a count without the status filter also counts work handed back after shipping');
+});
+
+await t('an artist who is also an ideator sends both crafts\' counts, and only counts', async () => {
+  const { sent } = await sendRollup({
+    byCraft: { engineer: 0, artist: 1100, ideator: 160, other: 0, total: 1260 },
+    preferred: ['ui'],
+    ports: { 'copy-desk.artistStats': ARTIST_STATS, 'ideas.ideatorStats': IDEATOR_STATS },
+  });
+  assert.equal(sent.length, 1);
+  const body = sent[0];
+  assert.deepEqual(body.crafts, {
+    artist: { pages_approved: 42, credits: 1100 },
+    ideator: { filed: 12, full_ideas: 2, ratified: 1, credits: 160 },
+  }, 'exactly the named counts — no surface line, no size, no wording');
+  assert.ok(!JSON.stringify(body).includes('secret wording'), 'no page wording leaves the instance');
+  assert.deepEqual(body.disciplines, ['artist', 'ideator'], 'crafts from evidence of work, in preferred order (ui → artist)');
+  assert.equal(body.tasks_shipped, 5, 'CONTROL: the totals still ride');
+});
+
+await t('an unearned craft sends nothing, and its stats port is never asked', async () => {
+  let asked = 0;
+  const { sent } = await sendRollup({
+    byCraft: { engineer: 900, artist: 0, ideator: 0, other: 0, total: 900 },
+    preferred: ['artist', 'engineer'],
+    ports: { 'copy-desk.artistStats': async () => { asked++; return {}; } },
+  });
+  assert.deepEqual(sent[0].crafts, { engineer: { shipped: 5, credits: 900 } });
+  assert.deepEqual(sent[0].disciplines, ['engineer'], 'a declared but unearned role is not shown once work exists elsewhere');
+  assert.equal(asked, 0, 'a craft that will not be sent is not read');
+});
+
+await t('nothing earned, or no economy to ask → the declared preference, and no crafts field', async () => {
+  const none = await sendRollup({ byCraft: { engineer: 0, artist: 0, ideator: 0, other: 0, total: 0 }, preferred: ['ideator'] });
+  assert.deepEqual(none.sent[0].disciplines, ['ideator'], 'the fallback is the preference');
+  assert.ok(!('crafts' in none.sent[0]), 'no crafts field, so an older hub never sees one');
+  const vanilla = await sendRollup({ byCraft: null, preferred: ['engineer', 'ui'] });
+  assert.deepEqual(vanilla.sent[0].disciplines, ['engineer', 'ui']);
+  assert.ok(!('crafts' in vanilla.sent[0]));
+});
+
+await t('a craft whose port cannot be asked sends null counts, never 0', async () => {
+  const { sent } = await sendRollup({ byCraft: { engineer: 0, artist: 50, ideator: 0, other: 0, total: 50 }, preferred: [] });
+  assert.deepEqual(sent[0].crafts, { artist: { pages_approved: null, credits: 50 } });
+});
+
+await t('an older hub refusing `crafts` (400) gets the report again without it — once', async () => {
+  const { sent } = await sendRollup({
+    byCraft: { engineer: 0, artist: 1100, ideator: 0, other: 0, total: 1100 },
+    ports: { 'copy-desk.artistStats': ARTIST_STATS },
+    statuses: [400, 200],
+  });
+  assert.equal(sent.length, 2, 'one retry');
+  assert.ok('crafts' in sent[0]);
+  assert.ok(!('crafts' in sent[1]), 'the retry drops only the new field');
+  assert.equal(sent[1].tasks_shipped, 5, 'the totals still land');
+  assert.deepEqual(sent[1].disciplines, ['artist'], 'the evidence-derived crafts ride the retry too');
+});
+
+await t('a 400 on a report WITHOUT crafts is not retried (nothing to drop)', async () => {
+  const { sent } = await sendRollup({ statuses: [400] });
+  assert.equal(sent.length, 1);
+});
+
+// ---- 2. the hub route + upsert ---------------------------------------------
+
+console.log('\n2. the hub accepts crafts and binds only the sanitised shape:');
+
+const SECRET = 'craft-secret';
+function hubRoute() {
+  const pi = require('../modules/platform-identity/platform-identity.js');
+  const rollupPool = mockPool((sql) => {
+    if (/FROM platform_identity_sso_clients/.test(sql)) {
+      return { rows: [{ client_id: 'c1', secret_hash: pi.sha256hex(SECRET), status: 'active', origin: 'https://p.example' }] };
+    }
+    if (/FROM platform_identity_project_memberships/.test(sql)) {
+      return { rows: [{ id: 1, client_id: 'c1', github_id: 42, membership_kind: 'member', signin_verified_at: '2026-08-29T00:00:00.000Z' }] };
+    }
+    return { rows: [{ id: 1 }] };
+  });
+  const helpers = require('../src/bongos/routes/_helpers.js');
+  const realApi = require('../src/module-api.js');
+  pin('../src/module-api.js', {
+    pool: rollupPool,
+    validateOrRespond: helpers.validateOrRespond,
+    resolveSession: async () => null,
+    logger: () => ({ info() {}, warn() {}, error() {} }),
+    LIVE_RANK_LADDER: realApi.LIVE_RANK_LADDER,
+    withTx: realApi.withTx,
+    corsPublicGet: () => (_q, _s, next) => next(),
+    on: () => () => {},
+    hasProvider: () => false,
+    registerProvider: () => {},
+  });
+  delete require.cache[require.resolve('../modules/platform-identity/routes/sso.js')];
+  const router = require('../modules/platform-identity/routes/sso.js')();
+  const layer = router.stack.find((l) => l.route && l.route.path === '/sso/activity/rollup');
+  return { handle: layer.route.stack[0].handle, rollupPool };
+}
+async function postRollup(extra) {
+  const { handle, rollupPool } = hubRoute();
+  const res = { body: null, failure: null };
+  res.json = (b) => { res.body = b; return res; };
+  res.fail = (code, ...rest) => { res.failure = { code, rest }; return res; };
+  const req = {
+    get: () => undefined,
+    body: { client_id: 'c1', client_secret: SECRET, github_id: 42, credits: 10, tasks_shipped: 2, karma: 1, ...extra },
+  };
+  await handle(req, res, () => {});
+  const insert = rollupPool.find(/INSERT INTO platform_identity_builder_project_activity/);
+  return { res, insert };
+}
+
+await t('a report carrying crafts is accepted and binds the craft counts', async () => {
+  const { res, insert } = await postRollup({ crafts: { artist: { pages_approved: 42, credits: 1100 } } });
+  assert.equal(res.failure, null, JSON.stringify(res.failure));
+  assert.match(insert.text, /reported_as_of, crafts\)/, 'the upsert writes the crafts column');
+  assert.match(insert.text, /crafts = EXCLUDED\.crafts/, 'and a later report replaces it');
+  assert.deepEqual(JSON.parse(insert.params[9]), { artist: { pages_approved: 42, credits: 1100 } });
+});
+
+await t('the hub keeps only the three crafts and their named integer counts', async () => {
+  const { insert } = await postRollup({
+    crafts: {
+      artist: { pages_approved: 'forty', credits: -3, title: '<script>' },
+      ideator: { filed: 1.5, full_ideas: 99_000_000, ratified: 2, credits: 7, idea_title: 'A secret plan' },
+      governor: { laws: 4 },
+      engineer: 'lots',
+    },
+  });
+  const bound = JSON.parse(insert.params[9]);
+  assert.deepEqual(bound, {
+    artist: { pages_approved: null, credits: null },
+    ideator: { filed: null, full_ideas: null, ratified: 2, credits: 7 },
+  });
+  assert.ok(!insert.params[9].includes('secret') && !insert.params[9].includes('script'), 'no text survives');
+});
+
+await t('a report with no crafts (an older instance) binds the empty object', async () => {
+  const { res, insert } = await postRollup({});
+  assert.deepEqual(res.body, { ok: true });
+  assert.equal(insert.params[9], '{}');
+});
+
+await t('CONTROL: the body is still strict — an unknown field is refused', async () => {
+  const { res } = await postRollup({ rolez: {} });
+  assert.ok(res.failure, 'a strict body is what makes the sender\'s retry necessary');
+});
+
+// ---- 3. the aggregate + the page ----------------------------------------------
+
+console.log('\n3. the profile sums each craft over every project, and draws it:');
+
+await t('getRollupForBuilder sums each craft over EVERY project row, named or not', async () => {
+  // pin the doorway back to something with a pool the domain can take.
+  const pi = require('../modules/platform-identity/platform-identity.js');
+  const pool = mockPool((sql) => {
+    if (/WITH agg AS/.test(sql)) {
+      return { rows: [{ projects: 2, credits: 1300, works_shipped: 44, karma: 3, last_active: null, disciplines: ['artist'] }] };
+    }
+    if (/recent_ships/.test(sql)) {
+      return { rows: [
+        { name: 'Pub', origin: 'https://pub.example', rank_held: 'metic', recent_ships: [], is_public: true,
+          crafts: { artist: { pages_approved: 40, credits: 1000 } } },
+        { name: 'Hidden', origin: 'https://priv.example', rank_held: 'xenos', recent_ships: [], is_public: false,
+          crafts: { artist: { pages_approved: 2, credits: null }, ideator: { filed: 5, full_ideas: 1, ratified: null, credits: 60 } } },
+        { name: 'Old', origin: 'https://old.example', rank_held: null, recent_ships: [], is_public: true, crafts: {} },
+      ] };
+    }
+    return { rows: [] };
+  });
+  const r = await pi.getRollupForBuilder(42, { pool });
+  assert.match(pool.find(/recent_ships/).text, /a\.crafts/, 'the per-project read carries crafts');
+  assert.deepEqual(r.crafts, {
+    artist: { pages_approved: 42, credits: 1000 },
+    ideator: { filed: 5, full_ideas: 1, ratified: null, credits: 60 },
+  }, 'a private project is counted, as its totals are; a count nobody reported stays null');
+  assert.deepEqual(r.projects.map((p) => p.name), ['Pub', 'Old'], 'CONTROL: the private project is still not NAMED');
+  assert.ok(!JSON.stringify(r.projects).includes('pages_approved'), 'per-project numbers never cross, only the sum');
+});
+
+// The page: the real profile.js in the tests/profile_ui_cross_project.mjs stub.
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/profile.js'), 'utf8');
+const ROLES_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/profile-roles.js'), 'utf8');
+async function renderXp(crossProject) {
+  const els = new Map();
+  const makeEl = () => ({ hidden: false, textContent: '', _html: '', set innerHTML(v) { this._html = String(v); }, get innerHTML() { return this._html; } });
+  const $ = (sel) => { if (!els.has(sel)) els.set(sel, makeEl()); return els.get(sel); };
+  const escapeHtml = (s) => String(s).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
+  const profile = {
+    builder: { id: 7, github_login: 'b7', display_name: 'Builder 7', rank: 'thetes', total_credits: 1, karma: 0, created_at: '2026-01-01T00:00:00.000Z', preferred_disciplines: [] },
+    shipped_count: 0, recent_ships: [], achievements: [], cross_project: crossProject,
+  };
+  const api = { async request(_m, url) {
+    if (url === '/api/bongos/me') return { status: 200, ok: true, data: { builder: { id: 99 } } };
+    if (/\/builders\/[^/]+\/profile$/.test(url)) return { status: 200, ok: true, data: profile };
+    return { status: 404, ok: false, data: null };
+  } };
+  const sandbox = { location: { search: '?id=7' }, URLSearchParams, console, window: {
+    __BRANDING__: {}, BongosClient: { createClient: () => api },
+    OTB: { roleAxisLabel: () => 'Role', roleLabel: (d) => d.charAt(0).toUpperCase() + d.slice(1), roleOptions: () => [], roleIsUnset: (d) => !d,
+      ROLE_UNSET: 'unclassified', $, escapeHtml, fmtNum: (n) => String(Number(n) || 0), fmtDate: (d) => String(d).slice(0, 10), rankLabel: (r) => r, toast() {} },
+  } };
+  sandbox.globalThis = sandbox;
+  vm.createContext(sandbox);
+  vm.runInContext(ROLES_SRC, sandbox, { filename: 'profile-roles.js' });
+  vm.runInContext(SRC, sandbox, { filename: 'profile.js' });
+  for (let i = 0; i < 4; i++) await new Promise((r) => setImmediate(r));
+  return $('#xp-body').innerHTML;
+}
+const CP = (crafts) => ({ totals: { projects: 1, credits: 10, works_shipped: 0, karma: 0 }, disciplines: [], crafts, last_active: null, projects: [], more_projects: 0 });
+const tileOf = (html, label) => {
+  const m = html.match(new RegExp(`${label}</span>\\s*<span class="stat-tile__num">([^<]*)</span>`));
+  return m ? m[1] : null;
+};
+
+await t('an artist\'s and an ideator\'s tiles show their own craft\'s numbers', async () => {
+  const html = await renderXp(CP({ artist: { pages_approved: 42, credits: 1100 }, ideator: { filed: 12, full_ideas: 2, ratified: 1, credits: 160 } }));
+  assert.equal(tileOf(html, 'Pages approved'), '42');
+  assert.equal(tileOf(html, 'Thoughts filed'), '12');
+  assert.equal(tileOf(html, 'Full Ideas'), '2');
+  assert.match(html, /1 ratified by the board/);
+  assert.match(html, /stat-row--craft/);
+  assert.equal(tileOf(html, 'Works shipped'), '0', 'CONTROL: the totals band is unchanged');
+});
+
+await t('a count no project could report is a dash, never 0', async () => {
+  const html = await renderXp(CP({ artist: { pages_approved: null, credits: 50 } }));
+  assert.equal(tileOf(html, 'Pages approved'), '—');
+});
+
+await t('no crafts (an engineer, or an older hub) → no craft band at all', async () => {
+  for (const crafts of [undefined, {}, { engineer: { shipped: 3, credits: 9 } }]) {
+    const html = await renderXp(CP(crafts));
+    assert.ok(!html.includes('stat-row--craft'), `no craft band for ${JSON.stringify(crafts)}`);
+    assert.equal((html.match(/stat-tile__num/g) || []).length, 4);
+  }
+});
+
+console.log(`\n${passed} passed, ${failed} failed`);
+if (failed) process.exit(1);

package/tests/onboard.mjs

@@ -81,10 +81,16 @@ test('every form OFFERS the optional step and names what skipping costs — skil
   assert.match(cli, /Press Enter to skip/, 'the terminal form offers the skip in the prompt itself');
   assert.match(cli, /off the public map/, 'and says what a missing description means');
 
-  // the web form
-  const hub = read('modules/public-landing/public/projects.html');
-  assert.match(hub, /id="panel-detail"/, 'the wizard ships the panel');
-  assert.match(hub, /id="skipDetail"/, 'with a skip control of its own');
+  // the web form — since task 1004504 the optional step is no panel of its own: the
+  // sentence is an optional field on "What are you making?" whose label names what
+  // leaving it empty costs, and the team shape is the review's Team size row
+  const hub = read('modules/public-landing/public/projects.html').replace(/\r\n/g, '\n');
+  const what = (hub.match(/<section class="panel" id="panel-what"[\s\S]*?\n {10}<\/section>/) || [''])[0];
+  assert.ok(what, 'the wizard ships the screen that carries the sentence');
+  assert.match(what, /<label class="wizField"><span>In a sentence <small>\(optional — puts it on the public map\)<\/small><\/span>\s*<input type="text" id="f-desc"/,
+    'the sentence is offered as optional, and its label says what skipping costs');
+  assert.match(hub, /<div class="setRow" data-row="team">[\s\S]*?id="teamCards"/, 'the team shape rides the review\'s Team size row');
+  assert.doesNotMatch(hub, /id="panel-detail"|id="skipDetail"/, 'the old About panel and its skip control are gone');
 
   // the route that receives it
   const route = read('modules/provisioning/routes/provisioning.js');

package/tests/platform_boot.mjs

@@ -147,7 +147,7 @@ test('/create redirects into the hub wizard, seed intact (task 1002763)', async
   assert.equal(hub.status, 200);
   assert.match(hub.headers['content-type'] || '', /text\/html/);
   assert.match(hub.body, /window\.__BRANDING__=/);
-  assert.match(hub.body, /Create a project/);
+  assert.match(hub.body, /<h1 id="gate-h">Make something\.<\/h1>/);   // the wizard's sign-in screen (task 1004504)
   // the wizard files the request against the provisioning API, nothing else
   assert.match(hub.body, /provisioning\/instances/);
 });

package/tests/profile_rollup_consent.mjs

@@ -102,6 +102,8 @@ try {
   await q(migrationSql('platform_identity_022_activity_snapshots.sql'));
   // upsertActivity also writes reported_as_of (026, task 1004268): 42703 without it.
   await q(migrationSql('platform_identity_026_activity_reported_as_of.sql'));
+  // ...and crafts (029, task 1004440), which getRollupForBuilder also reads.
+  await q(migrationSql('platform_identity_029_activity_crafts.sql'));
   await cleanup();
 
   // CONSENT IS TWO COLUMNS (ADR 0213, task 1002913): profile_state='active' AND

package/tests/profile_route.mjs

@@ -108,13 +108,22 @@ function stubPublicProfileExtras() {
   return {
     totals: { projects: 2, credits: 150, works_shipped: 7, karma: 4 },
     disciplines: ['engineer', 'ui'],
+    crafts: { artist: { pages_approved: 3, credits: 40 } },
     last_active: '2026-08-01T00:00:00.000Z',
     projects: named,
     more_projects: CROSS_PROJECT_ROWS.length - named.length,
   };
 }
 // The key contract for the cross_project object + its project rows.
-const CP_PUBLIC_KEYS = ['totals', 'disciplines', 'last_active', 'projects', 'more_projects'];
+// crafts (task 1004440) is each craft's summed counts — always present, {} when
+// no project reported any — so it belongs in the exact list too.
+const CP_PUBLIC_KEYS = ['totals', 'disciplines', 'crafts', 'last_active', 'projects', 'more_projects'];
+// The only shape crafts may take: the three crafts, each a block of counts.
+const CP_ROLE_FIELDS = {
+  engineer: ['credits', 'shipped'],
+  artist: ['credits', 'pages_approved'],
+  ideator: ['credits', 'filed', 'full_ideas', 'ratified'],
+};
 // recent_ships rides the project row (task 1002803) and is ALWAYS present —
 // getRollupForBuilder defaults it to [] — so it belongs in the exact key list.
 const CP_PROJECT_ROW_KEYS = ['name', 'origin', 'rank_held', 'recent_ships'];
@@ -129,6 +138,11 @@ const CP_SENTINELS = [SECRET_CLIENT_ID, SECRET_PROJECT_NAME, SECRET_EMAIL, SECRE
 function assertCrossProjectContract(cp, text) {
   assert.deepEqual(Object.keys(cp).sort(), [...CP_PUBLIC_KEYS].sort(), 'cross_project keys are exactly the contract');
   assert.deepEqual(Object.keys(cp.totals).sort(), ['credits', 'karma', 'projects', 'works_shipped']);
+  for (const [craft, block] of Object.entries(cp.crafts)) {
+    assert.ok(CP_ROLE_FIELDS[craft], `crafts carries only the three crafts — found "${craft}"`);
+    assert.deepEqual(Object.keys(block).sort(), CP_ROLE_FIELDS[craft], `${craft} carries only its named counts`);
+    for (const v of Object.values(block)) assert.ok(v === null || Number.isInteger(v), 'a craft count is a number or null, never text');
+  }
   for (const row of cp.projects) {
     assert.deepEqual(Object.keys(row).sort(), [...CP_PROJECT_ROW_KEYS].sort(), 'project rows carry only the whitelisted keys');
   }
@@ -619,7 +633,7 @@ await t('R06.5 no PARTIAL numbers survive the hide (a count beside a hidden tota
   await pi.setAccountHideStats({ githubId: HUB_GITHUB_ID, githubLogin: 'jaxri', hide: true }, { pool: engine });
   const r = await get(port, '/api/bongos/builders/95/profile');
   assert.equal(r.json.cross_project, null);
-  for (const key of ['totals', 'works_shipped', 'more_projects', 'last_active', 'rank_held']) {
+  for (const key of ['totals', 'works_shipped', 'more_projects', 'last_active', 'rank_held', 'pages_approved']) {
     assert.ok(!r.text.includes(key), `nothing derived from the rollup may survive — found "${key}"`);
   }
   const digits = [sumOf('credits'), sumOf('tasks_shipped'), sumOf('karma'),