@bongos/core 1.21.175 → 1.21.177

package/tests/run_routine_two_root.mjs

@@ -23,7 +23,7 @@ import { skipUnlessPresent } from './helpers.mjs';
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 const REPO = path.resolve(__dirname, '..'); // the core root (this repo), fixed by resolveCoreRoot()
-const RUN_ROUTINE = path.join(REPO, 'scripts', 'gds', 'run-routine.js');
+const RUN_ROUTINE = path.join(REPO, 'scripts', 'bongos', 'run-routine.js');
 const CORE_RESOLVE = path.join(REPO, '.claude', 'hooks', '_core-resolve.js');
 skipUnlessPresent('.claude/hooks/_core-resolve.js');
 
@@ -38,7 +38,7 @@ function test(name, fn) {
 const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'rr-two-root-'));
 const inst = path.join(tmp, 'instance');
 try {
-  const coreLibDir = path.join(inst, 'node_modules', '@bongos', 'core', 'scripts', 'gds');
+  const coreLibDir = path.join(inst, 'node_modules', '@bongos', 'core', 'scripts', 'bongos');
   fs.mkdirSync(coreLibDir, { recursive: true });
   fs.writeFileSync(path.join(coreLibDir, 'fake-core-lib.js'), 'module.exports = { ping: () => "CORE_OK" };\n');
 
@@ -55,8 +55,8 @@ try {
       '  - command: node .claude/scheduled-tasks/demo/run.js', '    sink: none', '---', 'body', ''].join('\n'));
   fs.writeFileSync(path.join(rtDir, 'run.js'),
     "const { requireCore, coreModulePath } = require('../../hooks/_core-resolve.js');\n" +
-    "const { ping } = requireCore('scripts/gds/fake-core-lib.js');\n" +
-    "console.log('RESOLVED=' + coreModulePath('scripts/gds/fake-core-lib.js'));\n" +
+    "const { ping } = requireCore('scripts/bongos/fake-core-lib.js');\n" +
+    "console.log('RESOLVED=' + coreModulePath('scripts/bongos/fake-core-lib.js'));\n" +
     "console.log(ping());\n");
 
   test('dispatch finds the routine under resolveInstanceRoot() and runs it; companion resolves core from node_modules', () => {
@@ -68,7 +68,7 @@ try {
       env: { ...process.env, OTB_INSTANCE_ROOT: inst, CLAUDE_PROJECT_DIR: inst },
     });
     assert.match(out, /CORE_OK/, 'companion step should have run and printed its core lib output');
-    assert.match(out, /RESOLVED=.*node_modules[/\\]@bongos[/\\]core[/\\]scripts[/\\]gds[/\\]fake-core-lib\.js/,
+    assert.match(out, /RESOLVED=.*node_modules[/\\]@bongos[/\\]core[/\\]scripts[/\\](?:gds|bongos)[/\\]fake-core-lib\.js/,
       'the core lib must resolve from node_modules/@bongos/core, proving two-root (not single-root) resolution');
   });
 } finally {

package/tests/runner_drift.mjs

@@ -10,7 +10,7 @@
 
 import { strict as assert } from 'node:assert';
 import { readFileSync } from 'node:fs';
-import { effectiveUnit, runnerScriptPath, coreVersionFor, installedCoreVersion, assessRunnerUnit, parseUnitList, runnerBanner } from '../scripts/gds/runner-drift.js';
+import { effectiveUnit, runnerScriptPath, coreVersionFor, installedCoreVersion, assessRunnerUnit, parseUnitList, runnerBanner } from '../scripts/bongos/runner-drift.js';
 
 let passed = 0, failed = 0;
 function t(name, fn) {
@@ -24,13 +24,13 @@ const LIVE_CAT = `# /etc/systemd/system/selfhost-provision-intent-runner.service
 Type=oneshot
 WorkingDirectory=/home/lars/cloudbongos
 EnvironmentFile=/etc/cloudbongos/box.env
-ExecStart=/usr/bin/env bash infra/core-node.sh scripts/gds/provision.js run-intents --apply
+ExecStart=/usr/bin/env bash infra/core-node.sh scripts/bongos/provision.js run-intents --apply
 
 # /etc/systemd/system/selfhost-provision-intent-runner.service.d/override.conf
 [Service]
 WorkingDirectory=/home/lars/cloudbongos-instance
 ExecStart=
-ExecStart=/usr/bin/node node_modules/@bongos/core/scripts/gds/provision.js run-intents --apply
+ExecStart=/usr/bin/node node_modules/@bongos/core/scripts/bongos/provision.js run-intents --apply
 `;
 
 // A fake fs: path → file body. Only readFileSync + existsSync are used.
@@ -53,7 +53,7 @@ const boxFs = (installed, runnerPkg = installed) => fakeFs({
 t('effectiveUnit: a drop-in WorkingDirectory wins, and an empty ExecStart= resets the base one', () => {
   assert.deepEqual(effectiveUnit(LIVE_CAT), {
     workingDirectory: INSTANCE,
-    execStarts: ['/usr/bin/node node_modules/@bongos/core/scripts/gds/provision.js run-intents --apply'],
+    execStarts: ['/usr/bin/node node_modules/@bongos/core/scripts/bongos/provision.js run-intents --apply'],
   });
 });
 
@@ -67,7 +67,7 @@ t('effectiveUnit: with no drop-in the base file stands (the pre-hotfix shape)',
 
 t('assessRunnerUnit: a drop-in that ADDS an ExecStart without clearing leaves the stale base command running — never ok', () => {
   const cat = LIVE_CAT.replace('ExecStart=\nExecStart=/usr/bin/node', 'ExecStart=/usr/bin/node')
-    .replace('ExecStart=/usr/bin/env bash infra/core-node.sh scripts/gds/provision.js run-intents --apply', 'ExecStart=/usr/bin/node /home/lars/cloudbongos/scripts/gds/provision.js run-intents --apply');
+    .replace('ExecStart=/usr/bin/env bash infra/core-node.sh scripts/bongos/provision.js run-intents --apply', 'ExecStart=/usr/bin/node /home/lars/cloudbongos/scripts/bongos/provision.js run-intents --apply');
   assert.equal(effectiveUnit(cat).execStarts.length, 2);
   const r = assessRunnerUnit({ name: 'x', catText: cat, instanceRoot: INSTANCE, fsImpl: boxFs('1.19.831') });
   assert.equal(r.status, 'drift', r.reason);
@@ -75,20 +75,20 @@ t('assessRunnerUnit: a drop-in that ADDS an ExecStart without clearing leaves th
 });
 
 t('runnerScriptPath: node + a relative script resolves against WorkingDirectory; a wrapper resolves to null', () => {
-  assert.equal(runnerScriptPath({ workingDirectory: INSTANCE, execStart: '/usr/bin/node node_modules/@bongos/core/scripts/gds/provision.js run-intents --apply' }),
-    `${INSTANCE}/node_modules/@bongos/core/scripts/gds/provision.js`);
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env node /abs/core/scripts/gds/provision.js run-intents' }), '/abs/core/scripts/gds/provision.js');
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '-/usr/bin/node scripts/gds/provision.js' }), '/w/scripts/gds/provision.js', 'systemd exec prefixes are stripped');
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env NODE_ENV=production node --max-old-space-size=512 scripts/gds/provision.js' }), '/w/scripts/gds/provision.js', 'env assignments and node flags are skipped');
-  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env bash infra/core-node.sh scripts/gds/provision.js' }), null,
+  assert.equal(runnerScriptPath({ workingDirectory: INSTANCE, execStart: '/usr/bin/node node_modules/@bongos/core/scripts/bongos/provision.js run-intents --apply' }),
+    `${INSTANCE}/node_modules/@bongos/core/scripts/bongos/provision.js`);
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env node /abs/core/scripts/bongos/provision.js run-intents' }), '/abs/core/scripts/bongos/provision.js');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '-/usr/bin/node scripts/bongos/provision.js' }), '/w/scripts/bongos/provision.js', 'systemd exec prefixes are stripped');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env NODE_ENV=production node --max-old-space-size=512 scripts/bongos/provision.js' }), '/w/scripts/bongos/provision.js', 'env assignments and node flags are skipped');
+  assert.equal(runnerScriptPath({ workingDirectory: '/w', execStart: '/usr/bin/env bash infra/core-node.sh scripts/bongos/provision.js' }), null,
     'a shell wrapper decides at runtime which core it loads — the gate must not guess');
 });
 
 t('coreVersionFor: an installed package reads its package.json; a source checkout reads CORE_VERSION', () => {
   const fs = boxFs('1.19.831');
-  assert.equal(coreVersionFor(`${INSTANCE}/node_modules/@bongos/core/scripts/gds/provision.js`, { fsImpl: fs }), '1.19.831');
-  assert.equal(coreVersionFor('/home/lars/cloudbongos/scripts/gds/provision.js', { fsImpl: fs }), '1.19.2');
-  assert.equal(coreVersionFor('/nowhere/scripts/gds/provision.js', { fsImpl: fs }), null);
+  assert.equal(coreVersionFor(`${INSTANCE}/node_modules/@bongos/core/scripts/bongos/provision.js`, { fsImpl: fs }), '1.19.831');
+  assert.equal(coreVersionFor('/home/lars/cloudbongos/scripts/bongos/provision.js', { fsImpl: fs }), '1.19.2');
+  assert.equal(coreVersionFor('/nowhere/scripts/bongos/provision.js', { fsImpl: fs }), null);
 });
 
 t('installedCoreVersion: reads <root>/node_modules/@bongos/core; null when absent', () => {
@@ -103,7 +103,7 @@ t('assessRunnerUnit: the live drop-in shape is ok', () => {
 });
 
 t('assessRunnerUnit: a unit running a source clone on another core is DRIFT, naming both versions', () => {
-  const cat = LIVE_CAT.replace(/ExecStart=\/usr\/bin\/node node_modules[^\n]*/, 'ExecStart=/usr/bin/node /home/lars/cloudbongos/scripts/gds/provision.js run-intents --apply');
+  const cat = LIVE_CAT.replace(/ExecStart=\/usr\/bin\/node node_modules[^\n]*/, 'ExecStart=/usr/bin/node /home/lars/cloudbongos/scripts/bongos/provision.js run-intents --apply');
   const r = assessRunnerUnit({ name: 'x.service', catText: cat, instanceRoot: INSTANCE, fsImpl: boxFs('1.19.831') });
   assert.equal(r.status, 'drift');
   assert.match(r.reason, /1\.19\.2/);
@@ -130,7 +130,7 @@ t('runnerBanner: names the runner core + path, and flags a differing instance co
   assert.equal(runnerBanner({ runnerVersion: null, runnerRoot: '/r', instanceVersion: null, instanceRoot: '/i' }), 'runner core ? from /r (no installed core at /i)');
 });
 
-const { runnerDriftRows } = await import('../scripts/gds/doctor.js');
+const { runnerDriftRows } = await import('../scripts/bongos/doctor.js');
 
 t('doctor maps each verdict to a row: ok → ok, drift → FAIL with the fix, unresolved → warn', () => {
   const rows = runnerDriftRows([
@@ -147,7 +147,7 @@ t('doctor maps each verdict to a row: ok → ok, drift → FAIL with the fix, un
 });
 
 t('doctor runs the runner-drift probe', () => {
-  const src = readFileSync(new URL('../scripts/gds/doctor.js', import.meta.url), 'utf8');
+  const src = readFileSync(new URL('../scripts/bongos/doctor.js', import.meta.url), 'utf8');
   assert.match(src.slice(src.indexOf('require.main === module')), /checkRunnerDrift\(\)/);
 });
 

package/tests/sandbox_stage.mjs

@@ -1,6 +1,6 @@
 // tests/sandbox_stage.mjs
 //
-// Hermetic unit smoke for scripts/gds/sandbox-stage.js — the sandbox-first
+// Hermetic unit smoke for scripts/bongos/sandbox-stage.js — the sandbox-first
 // review step (#927, ADR 0046) that ship.js runs before resolving a claim on a
 // local full clone (task 1056). Covers: previewable-surface matching, the
 // decideShipGate decision table, resolvePreviewContext (local/none), marker
@@ -18,8 +18,8 @@ import path from 'node:path';
 import { execFileSync } from 'node:child_process';
 
 const require = createRequire(import.meta.url);
-const sbx = require('../scripts/gds/sandbox-stage.js');
-const { sameContent } = require('../scripts/gds/gen-freshness.js');
+const sbx = require('../scripts/bongos/sandbox-stage.js');
+const { sameContent } = require('../scripts/bongos/gen-freshness.js');
 
 let passed = 0, failed = 0;
 function t(name, fn) {
@@ -36,14 +36,14 @@ t('isPreviewableFile: game surfaces yes, internal surfaces no', () => {
   for (const f of ['modules/game/public/game/main.js', 'modules/game/world/terrain.js', 'modules/game/rooms/WorldRoom.js', 'server.js']) {
     assert.equal(sbx.isPreviewableFile(f), true, `${f} should be previewable`);
   }
-  for (const f of ['scripts/gds/ship.js', 'modules/lifecycle/routes/tasks.js', 'docs/adr/0046.md', 'modules/status-ui/public/index.html', 'modules/hall-ui/public/hall.js', 'migrations/075.sql', 'tests/sandbox_stage.mjs', 'server.js.bak']) {
+  for (const f of ['scripts/bongos/ship.js', 'modules/lifecycle/routes/tasks.js', 'docs/adr/0046.md', 'modules/status-ui/public/index.html', 'modules/hall-ui/public/hall.js', 'migrations/075.sql', 'tests/sandbox_stage.mjs', 'server.js.bak']) {
     assert.equal(sbx.isPreviewableFile(f), false, `${f} should NOT be previewable`);
   }
 });
 
 t('anyPreviewable: mixed diff counts as previewable; empty/none does not', () => {
   assert.equal(sbx.anyPreviewable(['docs/x.md', 'modules/game/public/game/a.js']), true);
-  assert.equal(sbx.anyPreviewable(['docs/x.md', 'scripts/gds/y.js']), false);
+  assert.equal(sbx.anyPreviewable(['docs/x.md', 'scripts/bongos/y.js']), false);
   assert.equal(sbx.anyPreviewable([]), false);
   assert.equal(sbx.anyPreviewable(null), false);
 });

package/tests/scope_map_guard.mjs

@@ -18,7 +18,7 @@ import { createRequire } from 'node:module';
 
 const require = createRequire(import.meta.url);
 const { checkDevsecopsOwnsItsChecks, siblingRequires, checkEveryModuleDirIsScoped, moduleDirsOnDisk,
-        checkNoNewUnownedRoot, trackedRoots, rootIsTouched } = require('../scripts/gds/scope-map-guard.js');
+        checkNoNewUnownedRoot, trackedRoots, rootIsTouched } = require('../scripts/bongos/scope-map-guard.js');
 const fs = require('node:fs');
 const os = require('node:os');
 const path = require('node:path');
@@ -38,8 +38,8 @@ test('siblingRequires extracts the real require shape, deduped and sorted', () =
     "const e = require('../../src/module-api');",
   ].join('\n');
   assert.deepEqual(siblingRequires(src), [
-    'scripts/gds/doc-cli-guard.js',
-    'scripts/gds/role-pack-guard.js',
+    'scripts/bongos/doc-cli-guard.js',
+    'scripts/bongos/role-pack-guard.js',
   ], 'only ./sibling.js requires, deduped — not node: builtins and not cross-tree requires');
 });
 
@@ -49,13 +49,13 @@ test('an EXTENSION-LESS require is extracted — the gap that shipped green', ()
   // four check files stayed unowned while the guard reported the set clean — this guard
   // committing the exact failure it exists to end.
   assert.deepEqual(siblingRequires("require('./run-routine'); require('./skill-lint')"), [
-    'scripts/gds/run-routine.js',
-    'scripts/gds/skill-lint.js',
+    'scripts/bongos/run-routine.js',
+    'scripts/bongos/skill-lint.js',
   ]);
 });
 
 test('both spellings of ONE file collapse to a single entry', () => {
-  assert.deepEqual(siblingRequires("require('./a'); require('./a.js')"), ['scripts/gds/a.js']);
+  assert.deepEqual(siblingRequires("require('./a'); require('./a.js')"), ['scripts/bongos/a.js']);
 });
 
 test('a hyphenated and a dotted filename both survive extraction', () => {
@@ -63,7 +63,7 @@ test('a hyphenated and a dotted filename both survive extraction', () => {
   // the first hyphen would silently shorten the set.
   assert.deepEqual(
     siblingRequires("require('./fitness-checks-write-validation.js'); require('./a.b.js')"),
-    ['scripts/gds/a.b.js', 'scripts/gds/fitness-checks-write-validation.js'],
+    ['scripts/bongos/a.b.js', 'scripts/bongos/fitness-checks-write-validation.js'],
   );
 });
 

package/tests/scouting_owner_access_and_reach.mjs

@@ -777,7 +777,7 @@ seams._reset();
 console.log('\ncoverage:');
 
 await t('this proof runs in the DB-free unit lane (not parked as integration or known-failing)', () => {
-  const runner = fs.readFileSync(path.join(repo, 'scripts', 'gds', 'run-unit-tests.js'), 'utf8');
+  const runner = fs.readFileSync(path.join(repo, 'scripts', 'bongos', 'run-unit-tests.js'), 'utf8');
   assert.ok(!/scouting_owner_access_and_reach/.test(runner),
     'named in run-unit-tests.js it would be parked into a lane CI does not run — and a proof that never runs is not a gate (task 1002282)');
 });

package/tests/scripts_gds_forwarders.mjs

@@ -0,0 +1,224 @@
+// tests/scripts_gds_forwarders.mjs — the scripts/gds/ -> scripts/bongos/ move keeps every old
+// caller working (task 1004848, criterion C3 of goal 1000073).
+//
+// WHY. The real scripts moved, but systemd units already installed on a box, cron routines, and a
+// hosted project's hooks and skills before its next core upgrade still run `node scripts/gds/<x>.js`
+// by literal path. A green CI run proves nothing about them: CI was rewritten to the new path in the
+// same commit. So this file calls the OLD path for real and asserts it still runs, still returns the
+// real exit status, and warns once. It also pins the two codemod properties the two lost attempts
+// (tasks 1003705, 1003965) had to discover the hard way:
+//   - a forwarder is recognised as one, so a second codemod run never "moves" ~350 two-line stubs
+//     over the real scripts they point at;
+//   - the rewrite is idempotent and leaves look-alikes, history markers and relative paths that
+//     mean something else alone.
+//
+// Nothing here writes to the repo: the shell cases build their own tree in a temp dir.
+import assert from 'node:assert/strict';
+import { test } from 'node:test';
+import { createRequire } from 'node:module';
+import { spawnSync } from 'node:child_process';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const require = createRequire(import.meta.url);
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const OLD = path.join(ROOT, 'scripts', 'gds');
+const NEW = path.join(ROOT, 'scripts', 'bongos');
+const { forward, warningText, WARNED_ENV } = require(path.join(NEW, 'forwarder.js'));
+const codemod = require(path.join(NEW, 'codemod-rename-scripts-gds.js'));
+
+const cleanEnv = () => {
+  const env = { ...process.env };
+  delete env[WARNED_ENV];
+  return env;
+};
+
+// ---------- 1. the old path, run for real ----------
+
+test('running an OLD path runs the real script, with identical output, and warns once', () => {
+  const rel = 'gen-interaction-posture.js';
+  const viaNew = spawnSync(process.execPath, [path.join(NEW, rel), '--print'], { cwd: ROOT, env: cleanEnv(), encoding: 'utf8' });
+  const viaOld = spawnSync(process.execPath, [path.join(OLD, rel), '--print'], { cwd: ROOT, env: cleanEnv(), encoding: 'utf8' });
+  assert.equal(viaNew.status, 0, viaNew.stderr);
+  assert.equal(viaOld.status, 0, viaOld.stderr);
+  assert.equal(viaOld.stdout, viaNew.stdout);
+  assert.ok(viaOld.stdout.length > 0);
+  assert.equal(viaOld.stderr.split(warningText(rel)).length - 1, 1, 'exactly one warning');
+  assert.match(viaOld.stderr, /scripts\/bongos\/gen-interaction-posture\.js/, 'the warning names the new path');
+  assert.equal(viaNew.stderr.includes('[bongos] scripts/gds/'), false, 'the new path does not warn');
+});
+
+test('a forwarder reached from inside another forwarder does not warn twice', () => {
+  const rel = 'gen-interaction-posture.js';
+  const r = spawnSync(process.execPath, [path.join(OLD, rel), '--print'], {
+    cwd: ROOT, env: { ...cleanEnv(), [WARNED_ENV]: '1' }, encoding: 'utf8',
+  });
+  assert.equal(r.status, 0);
+  assert.equal(r.stderr.includes(warningText(rel)), false);
+});
+
+test('a non-zero exit from the real script comes back out of the OLD path', () => {
+  // api.js with no arguments prints its usage and exits 2 — no network, no session needed.
+  const direct = spawnSync(process.execPath, [path.join(NEW, 'api.js')], { cwd: ROOT, env: cleanEnv(), encoding: 'utf8' });
+  const viaOld = spawnSync(process.execPath, [path.join(OLD, 'api.js')], { cwd: ROOT, env: cleanEnv(), encoding: 'utf8' });
+  assert.equal(direct.status, 2);
+  assert.equal(viaOld.status, 2);
+});
+
+// ---------- 2. forward() itself: status, signal, spawn failure, require ----------
+
+function fakeProc() {
+  return { execPath: '/node', execArgv: ['--flag'], argv: ['/node', '/x', 'a', 'b'], pid: 42, exitCode: undefined, killed: null, kill(pid, sig) { this.killed = [pid, sig]; } };
+}
+
+test('forward() passes argv and node flags through and returns the status', () => {
+  const mod = {};
+  const proc = fakeProc();
+  let seen;
+  const out = [];
+  forward(mod, 'x.js', {
+    mainModule: mod, proc, env: {}, stderr: { write: (s) => out.push(s) },
+    spawn: (cmd, args, opts) => { seen = { cmd, args, opts }; return { status: 7 }; },
+  });
+  assert.equal(seen.cmd, '/node');
+  assert.deepEqual(seen.args, ['--flag', path.join(NEW, 'x.js'), 'a', 'b']);
+  assert.equal(seen.opts.stdio, 'inherit');
+  assert.equal(seen.opts.env[WARNED_ENV], '1');
+  assert.equal(proc.exitCode, 7);
+  assert.equal(out.length, 1);
+});
+
+test('forward() re-raises a signal and reports a spawn failure as exit 1', () => {
+  const mod = {};
+  const sig = fakeProc();
+  forward(mod, 'x.js', { mainModule: mod, proc: sig, env: { [WARNED_ENV]: '1' }, stderr: { write() {} }, spawn: () => ({ status: null, signal: 'SIGTERM' }) });
+  assert.deepEqual(sig.killed, [42, 'SIGTERM']);
+  const err = fakeProc();
+  forward(mod, 'x.js', { mainModule: mod, proc: err, env: { [WARNED_ENV]: '1' }, stderr: { write() {} }, spawn: () => ({ error: new Error('ENOENT') }) });
+  assert.equal(err.exitCode, 1);
+});
+
+test('requiring an OLD path returns the very module the new path returns, silently', () => {
+  const viaOld = require(path.join(OLD, 'surface.js'));
+  const viaNew = require(path.join(NEW, 'surface.js'));
+  assert.equal(viaOld, viaNew);
+  const mod = {};
+  const out = [];
+  const r = forward(mod, 'surface.js', { mainModule: {}, stderr: { write: (s) => out.push(s) } });
+  assert.equal(r.mode, 'require');
+  assert.equal(mod.exports, viaNew);
+  assert.deepEqual(out, []);
+});
+
+// ---------- 3. the shim is complete and current ----------
+
+function walk(dir, base = dir) {
+  return fs.readdirSync(dir, { withFileTypes: true }).flatMap((e) => {
+    const abs = path.join(dir, e.name);
+    return e.isDirectory() ? walk(abs, base) : [path.relative(base, abs).split(path.sep).join('/')];
+  });
+}
+
+test('every executable under scripts/bongos/ has a current forwarder, and no forwarder points nowhere', () => {
+  const real = walk(NEW);
+  let n = 0;
+  for (const rel of real) {
+    const want = codemod.forwarderFor(rel, fs.readFileSync(path.join(NEW, rel), 'utf8'));
+    if (want == null) continue;
+    n++;
+    const p = path.join(OLD, rel);
+    assert.ok(fs.existsSync(p), `scripts/gds/${rel} is missing — re-run scripts/bongos/codemod-rename-scripts-gds.js`);
+    assert.equal(fs.readFileSync(p, 'utf8'), want, `scripts/gds/${rel} is stale — re-run the codemod`);
+  }
+  assert.ok(n > 300, `expected the whole CLI to be forwarded, saw ${n}`);
+  for (const rel of walk(OLD)) {
+    if (rel === 'README.md') continue;
+    assert.ok(codemod.isForwarder(fs.readFileSync(path.join(OLD, rel), 'utf8')), `scripts/gds/${rel} is a real file, not a forwarder`);
+    assert.ok(fs.existsSync(path.join(NEW, rel)), `scripts/gds/${rel} forwards to a script that does not exist`);
+  }
+});
+
+// ---------- 4. the codemod's two hard-won properties ----------
+
+test('a forwarder is recognised as one, so a second run never moves stubs over real scripts', () => {
+  const fwd = codemod.forwarderFor('ship.js', "#!/usr/bin/env node\n'use strict';\n");
+  assert.equal(codemod.isForwarder(fwd), true);
+  assert.equal(codemod.isForwarder(fs.readFileSync(path.join(NEW, 'ship.js'), 'utf8')), false);
+  assert.equal(codemod.forwarderFor('discipline-modes.json', '{}'), null, 'data files get no forwarder');
+  assert.equal(codemod.forwarderFor('forwarder.js', ''), null);
+});
+
+test('the rewrite covers every reference shape and is idempotent', () => {
+  const cases = [
+    ['a.md', 'run `node scripts/gds/ship.js 12`', 'run `node scripts/bongos/ship.js 12`'],
+    ['a.js', "path.join(ROOT, 'scripts', 'gds', 'x.js')", "path.join(ROOT, 'scripts', 'bongos', 'x.js')"],
+    ['a.js', 'const RE = /^scripts\\/gds\\/x/;', 'const RE = /^scripts\\/(?:gds|bongos)\\/x/;'],
+    ['a.js', 'const RE = /scripts[/\\\\]gds[/\\\\]x/;', 'const RE = /scripts[/\\\\](?:gds|bongos)[/\\\\]x/;'],
+    ['a.ps1', 'node scripts\\gds\\api.js', 'node scripts\\bongos\\api.js'],
+    ['a.mjs', "'C:\\\\repo\\\\scripts\\\\gds\\\\x.js'", "'C:\\\\repo\\\\scripts\\\\bongos\\\\x.js'"],
+    ['scripts/hall-preview/x.js', "require('../gds/cli-lib')", "require('../bongos/cli-lib')"],
+    ['scripts/top.js', "require('./gds/cli-lib')", "require('./bongos/cli-lib')"],
+  ];
+  for (const [rel, before, after] of cases) {
+    const once = codemod.rewriteText(rel, before);
+    assert.equal(once.text, after, `${rel}: ${before}`);
+    assert.ok(once.n > 0);
+    const twice = codemod.rewriteText(rel, once.text);
+    assert.equal(twice.text, after, `${rel}: second run changed it`);
+    assert.equal(twice.n, 0);
+  }
+});
+
+test('the rewrite leaves look-alikes, kept lines, foreign relative paths and history alone', () => {
+  const untouched = [
+    ['a.js', 'scripts/gdsx/y and scripts/gds-client'],
+    ['a.js', "t.startsWith('scripts/gds/') // rename-keep: recorded touches[]"],
+    ['a.json', '{ "glob": "scripts/gds/", "why": "the @bongos-forwarder files" }'],
+    ['src/x.js', "require('../gds/y')"],
+    ['modules/m/x.js', "require('./gds/y')"],
+  ];
+  for (const [rel, text] of untouched) assert.equal(codemod.rewriteText(rel, text).text, text, `${rel}: ${text}`);
+  for (const rel of ['docs/adr/0001-x.md', 'docs/session-logs/x.md', 'limitations/v1-shipped.md',
+    'migrations/019_rename_pms_v3_to_gds_v3.sql', 'modules/economy/migrations/x.sql', 'scripts/gds/ship.js',
+    'modules/lifecycle/executed-closure.js']) {
+    assert.equal(codemod.isRewritable(rel), false, rel);
+  }
+  assert.equal(codemod.isRewritable('docs/recipes/x.md'), true);
+});
+
+// ---------- 5. the shell, PowerShell and cmd forwarders ----------
+
+test('.ps1 and .cmd forwarders are CRLF and pure ASCII', () => {
+  for (const rel of ['api.ps1', 'autobongos-service.cmd']) {
+    const text = codemod.forwarderFor(rel, '');
+    assert.equal(/[^\x00-\x7f]/.test(text), false, `${rel} has a non-ASCII byte`);
+    assert.equal(text.split('\r\n').length, text.split('\n').length, `${rel} is not CRLF throughout`);
+  }
+});
+
+test('a .sh forwarder execs the real script with its args and exit status; a sourced one sources it', { skip: process.platform === 'win32' }, () => {
+  const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'gds-fwd-'));
+  try {
+    fs.mkdirSync(path.join(tmp, 'gds'));
+    fs.mkdirSync(path.join(tmp, 'bongos'));
+    const realRun = '#!/usr/bin/env bash\necho "ran $*"\nexit 3\n';
+    const realLib = '#!/usr/bin/env bash\nlib_hello() { echo "hello from lib"; }\n';
+    fs.writeFileSync(path.join(tmp, 'bongos', 'run.sh'), realRun);
+    fs.writeFileSync(path.join(tmp, 'bongos', 'lib.sh'), realLib);
+    fs.writeFileSync(path.join(tmp, 'gds', 'run.sh'), codemod.forwarderFor('run.sh', realRun));
+    fs.writeFileSync(path.join(tmp, 'gds', 'lib.sh'), codemod.forwarderFor('lib.sh', realLib));
+
+    const run = spawnSync('bash', [path.join(tmp, 'gds', 'run.sh'), 'x', 'y'], { env: cleanEnv(), encoding: 'utf8' });
+    assert.equal(run.status, 3);
+    assert.equal(run.stdout, 'ran x y\n');
+    assert.ok(run.stderr.includes(warningText('run.sh')));
+
+    const sourced = spawnSync('bash', ['-c', `source "${path.join(tmp, 'gds', 'lib.sh')}" && lib_hello`], { env: cleanEnv(), encoding: 'utf8' });
+    assert.equal(sourced.status, 0, sourced.stderr);
+    assert.equal(sourced.stdout, 'hello from lib\n');
+  } finally {
+    fs.rmSync(tmp, { recursive: true, force: true });
+  }
+});

package/tests/scrubber_corpus.mjs

@@ -25,7 +25,7 @@ import { createRequire } from 'node:module';
 const require = createRequire(import.meta.url);
 const {
   scrubSecrets, shannonEntropy, looksHighEntropySecret, collectEnvSecrets,
-} = require('../scripts/gds/ship.js');
+} = require('../scripts/bongos/ship.js');
 
 let passed = 0;
 let failed = 0;
@@ -174,7 +174,7 @@ function negatives() {
     'claimed task 540 and shipped the fix',
     'the cat sat on the mat today',
     'ran 57 tasks across 4 criteria in 2 days',
-    'node scripts/gds/session-digest.js --transcript path',
+    'node scripts/bongos/session-digest.js --transcript path',
     'internationalization is a long english word',
     'see docs/adr/0022-secrets-policy.md for the policy',
     'merge-mode swept the confirmed queue and deployed',

package/tests/seam_wiring_guard.mjs

@@ -23,7 +23,7 @@ import { fileURLToPath } from 'node:url';
 
 const require = createRequire(import.meta.url);
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
-const guard = require(path.join(ROOT, 'scripts', 'gds', 'seam-wiring-guard.js'));
+const guard = require(path.join(ROOT, 'scripts', 'bongos', 'seam-wiring-guard.js'));
 const { scanSeamWiring, SEAM_CONSUMERS, declaredEntries, entryLabel } = guard;
 
 // A synthetic module. `dir` is a bare key — the scanner only ever hands it to

package/tests/search_ingest.mjs

@@ -14,7 +14,7 @@ import { createRequire } from 'node:module';
 import { fileURLToPath } from 'node:url';
 
 const require = createRequire(import.meta.url);
-const ingest = require('../scripts/gds/search-ingest-md.js');
+const ingest = require('../scripts/bongos/search-ingest-md.js');
 const { minRankForDoc, collectMarkdown, chunkFile, SENSITIVE_DOC_GLOBS } = ingest;
 
 let passed = 0;
@@ -65,7 +65,7 @@ test('CLAUDE.md is xenos (write-protected but READ-PUBLIC — the carve-out)', (
 // (minRankForDoc returns 'metic'); this one states the list's INTENT, which is the
 // half that was under-described.
 //
-// Keep it in sync with scripts/gds/publish-manifest.js:185, where SENSITIVE_DOC_EXCLUDE
+// Keep it in sync with scripts/bongos/publish-manifest.js:185, where SENSITIVE_DOC_EXCLUDE
 // is derived from this same array by filtering to docs/security + docs/audits — a
 // silent addition here changes the PUBLISH boundary too.
 test('SENSITIVE_DOC_GLOBS is the curated source of truth (exhaustive pin)', () => {

package/tests/search_ingest_db.mjs

@@ -12,7 +12,7 @@ import { strict as assert } from 'node:assert';
 import { createRequire } from 'node:module';
 
 const require = createRequire(import.meta.url);
-const ingest = require('../scripts/gds/search-ingest-db.js');
+const ingest = require('../scripts/bongos/search-ingest-db.js');
 const { buildRows, recentCommitRows, SOURCES } = ingest;
 
 let passed = 0;

package/tests/search_ingest_nul.mjs

@@ -100,7 +100,7 @@ test('the guard lives at the SHARED funnel, so both ingesters inherit it', () =>
   // The first fix of this bug class (task 1002507) was local to ship.js and left
   // every other path exposed. Assert structurally that neither ingester relies
   // on its own private guard: both must reach the sanitizer through chunkMarkdown.
-  for (const rel of ['scripts/gds/search-ingest-md.js', 'scripts/gds/search-ingest-db.js']) {
+  for (const rel of ['scripts/bongos/search-ingest-md.js', 'scripts/bongos/search-ingest-db.js']) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     assert.match(src, /chunkMarkdown\(/, `${rel} must chunk through the shared funnel`);
   }
@@ -109,7 +109,7 @@ test('the guard lives at the SHARED funnel, so both ingesters inherit it', () =>
 });
 
 test('chunkFile (the md ingester\'s row builder) emits NUL-free rows', () => {
-  const ingest = require('../scripts/gds/search-ingest-md.js');
+  const ingest = require('../scripts/bongos/search-ingest-md.js');
   const tmp = fs.mkdtempSync(path.join(ROOT, '.tmp-nul-'));
   try {
     const f = path.join(tmp, 'poisoned.md');
@@ -132,7 +132,7 @@ test('chunkFile (the md ingester\'s row builder) emits NUL-free rows', () => {
 test('both ingesters scope a transaction PER SOURCE, not one per run', () => {
   // This is the "rolls back the entire re-index" half of the bug. A single BEGIN
   // before the loop is what turned one bad byte into a total outage.
-  for (const rel of ['scripts/gds/search-ingest-md.js', 'scripts/gds/search-ingest-db.js']) {
+  for (const rel of ['scripts/bongos/search-ingest-md.js', 'scripts/bongos/search-ingest-db.js']) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     // Anchor on the loop that actually WRITES (the one calling ingestFile /
     // ingestRows), not the first `for (const f of ...)` in the file — the
@@ -152,7 +152,7 @@ test('a skipped source is named and forces a non-zero exit', () => {
   // The deploy/cron step runs these best-effort, so the exit code is the only
   // signal that reaches a log a human reads. "Some files were skipped" is what
   // let this hide for weeks — every casualty must be named.
-  for (const rel of ['scripts/gds/search-ingest-md.js', 'scripts/gds/search-ingest-db.js']) {
+  for (const rel of ['scripts/bongos/search-ingest-md.js', 'scripts/bongos/search-ingest-db.js']) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     assert.match(src, /failures\.push\(/, `${rel}: collects casualties`);
     assert.match(src, /FAILED and were skipped/, `${rel}: reports them as a group`);
@@ -165,7 +165,7 @@ test('the vanished-source prune is SKIPPED after any failure', () => {
   // present/presentRefs is the list we MEANT to write. Pruning against it on a
   // partial run would delete chunks for a source that only failed transiently —
   // turning a recoverable skip into data loss.
-  for (const rel of ['scripts/gds/search-ingest-md.js', 'scripts/gds/search-ingest-db.js']) {
+  for (const rel of ['scripts/bongos/search-ingest-md.js', 'scripts/bongos/search-ingest-db.js']) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     assert.match(src, /failures\.length === 0/, `${rel}: prune is gated on a clean run`);
     assert.match(src, /prune SKIPPED/, `${rel}: and says so when it skips`);
@@ -177,7 +177,7 @@ test('the driver error text reaching a log is bounded and single-line', () => {
   // embed row content (a constraint violation quotes the offending key), and
   // these are deploy/cron log sinks. The DB corpus makes it matter more — its
   // prose is session-log/memory-derived text the file treats as scrub-sensitive.
-  for (const rel of ['scripts/gds/search-ingest-md.js', 'scripts/gds/search-ingest-db.js']) {
+  for (const rel of ['scripts/bongos/search-ingest-md.js', 'scripts/bongos/search-ingest-db.js']) {
     const src = fs.readFileSync(path.join(ROOT, rel), 'utf8');
     assert.match(src, /const ERR_LOG_MAX = \d+;/, `${rel}: declares a cap`);
     assert.match(src, /function errLine\(e\)/, `${rel}: has the single formatter`);

package/tests/seed_verify_criteria.mjs

@@ -5,7 +5,7 @@
 // wide instead of per-goal, learning 1000188) and still printed success. The
 // mislink was only caught by a manual GET /goals rollup, after the fact.
 //
-// scripts/gds/seed-verify-criteria.js is the fix: every seed script tallies
+// scripts/bongos/seed-verify-criteria.js is the fix: every seed script tallies
 // the criterion_ids it actually POSTed, then diffs that plan against
 // GET /api/gds/goals/<id>'s real linked_tasks counts — loud and non-zero-exit
 // on any mismatch, zero included. This file pins the pure diff/tally
@@ -23,7 +23,7 @@ const {
   expectedCriterionCounts,
   baselineSeedCriteria,
   verifySeedCriteriaLinks,
-} = require('../scripts/gds/seed-verify-criteria.js');
+} = require('../scripts/bongos/seed-verify-criteria.js');
 
 let passed = 0;
 let failed = 0;
@@ -226,7 +226,7 @@ test('a fully re-run seed (every create a replay) plans nothing and verifies OK'
 });
 
 test('the baselined reference seed skips replays when it tallies', () => {
-  const src = readFileSync(new URL('../scripts/gds/seed-bv2-ideator-surface-tasks.js', import.meta.url), 'utf8');
+  const src = readFileSync(new URL('../scripts/bongos/seed-bv2-ideator-surface-tasks.js', import.meta.url), 'utf8');
   assert.match(src, /baselineSeedCriteria\(/, 'it takes a baseline');
   assert.match(src, /if \(!r\.json\.idempotent\) criterionIdListsPerTask\.push\(t\.crit\);/, 'and tallies only created tasks');
 });

package/tests/sequence.mjs

@@ -20,7 +20,7 @@ const {
   fetchGoalTaskRows,
   declaredSurfaceExcludesMigrations,
   GOAL_PAGE,
-} = require('../scripts/gds/sequence.js');
+} = require('../scripts/bongos/sequence.js');
 
 let passed = 0, failed = 0;
 const t = (n, f) => { try { f(); passed++; console.log(`  PASS  ${n}`); } catch (e) { failed++; console.log(`  FAIL  ${n}\n        ${e.message}`); } };
@@ -433,8 +433,8 @@ await ta('needs_migration no longer halts on the word alone (task 1003697\'s sha
   const t1003697 = task({
     id: 1003697,
     needs_migration: true,
-    touches: ['config/rename-history-baseline.json', 'scripts/gds/gds-literal-scan.js',
-      'scripts/gds/rename-history-check.js', 'tests/rename_history_restraint.mjs'],
+    touches: ['config/rename-history-baseline.json', 'scripts/bongos/gds-literal-scan.js',
+      'scripts/bongos/rename-history-check.js', 'tests/rename_history_restraint.mjs'],
     description: `${SPEC} see migrations/163_goal_dep_trigger.sql — DO NOT change any migration`,
   });
   assert.ok(declaredSurfaceExcludesMigrations(t1003697));