@bongos/core 1.21.113 → 1.21.115

package/tests/watch_applications_queue.mjs

@@ -470,6 +470,29 @@ await test('NO profile is not an error — the row renders exactly as it always
   assert.match(row.textContent, /octocat/);
 });
 
+// The handle the vouch carried (ADR 0333 D5, task 1004673): when the hub is down the
+// live profile is null, and the stored handle is what the queue can still call them.
+await test('a vouched row with NO profile names the platform handle its vouch carried', async () => {
+  const h = await boot({ rows: { pending: withProfile(null, { applicant_handle: 'mona-h' }), invited: [], dismissed: [] } });
+  const facts = h.rows()[0].querySelector('.ov-row__facts');
+  assert.match(facts.textContent, /On the platform as @mona-h/);
+  assert.equal(facts.querySelectorAll('a').length, 0, 'plain text: the hub has no person page to point at');
+});
+
+await test('the handle stays off a row that drew its profile, and off an unvouched row', async () => {
+  const drew = await boot({ rows: { pending: withProfile(PUBLIC_PROFILE, { applicant_handle: 'mona-h' }), invited: [], dismissed: [] } });
+  assert.doesNotMatch(drew.rows()[0].textContent, /On the platform as/, 'the live record is shown instead');
+  const unvouched = await boot({ rows: { pending: withProfile(null, { vouched: false, applicant_handle: 'mona-h' }), invited: [], dismissed: [] } });
+  assert.doesNotMatch(unvouched.rows()[0].textContent, /On the platform as/, 'a name anyone could type has no vouched handle');
+});
+
+await test('the vouched handle is escaped', async () => {
+  const h = await boot({ rows: { pending: withProfile(null, { applicant_handle: '<b>x</b>' }), invited: [], dismissed: [] } });
+  const facts = h.rows()[0].querySelector('.ov-row__facts');
+  assert.equal(facts.querySelectorAll('b').length, 0);
+  assert.match(facts.textContent, /@<b>x<\/b>/);
+});
+
 await test('an unrecognised view shape draws nothing rather than guessing', async () => {
   const h = await boot({ rows: { pending: withProfile({ view: 'everything', account: { bio: 'x' } }), invited: [], dismissed: [] } });
   assert.equal(h.rows()[0].querySelector('.ov-row__profile'), null,

package/tests/wizard_physics.mjs

@@ -126,7 +126,7 @@ test('every choice the questions offer is an answer the server accepts', () => {
   const checks = HUB.slice(HUB.indexOf('id="checksMain"'), HUB.indexOf('id="checksStop"'));
   assert.deepEqual([...new Set([...checks.matchAll(/data-phys="([a-z_]+)"/g)].map((m) => m[1]))], ['minors_on_board', 'builder_geography', 'entity'],
     'the quick checks ask about under-18s, where builders will be and who is behind it in the mockup’s order');
-  assert.match(checks, /<select id="physCountry">/, 'and where you are');
+  assert.match(checks, /<select id="physCountry" aria-labelledby="physCountryLbl">/, 'and where you are (the select the searchable list picks for, task 1004671)');
   const seen = [...panel.matchAll(/data-phys="([a-z_]+)" data-val="([^"]+)"/g)];
   assert.ok(seen.length >= 20, 'the questions\' choices');
   for (const [, key, raw] of seen) {

package/tests/wizard_physics_more.mjs

@@ -608,3 +608,136 @@ test('the address is on every path, the demo\'s too: never a fixed row, always c
     assert.equal(w.run('firstInvalidRow()'), null, `${label}: then Create goes on`);
   }
 });
+
+// ── "Where are you?" as a searchable list (task 1004671) ─────────────────────
+// The combobox only picks for the hidden select, so everything that reads the select
+// (the region, the screen, the draft, the fill, what Create sends) is the same path.
+const key = (k) => ({ key: k, preventDefault() {}, stopPropagation() {} });
+function typeCountry(w, text) {
+  w.$('physCountryIn').value = text;
+  w.$('physCountryIn').listeners.input();
+}
+const shownCodes = (w) => plain(w.run('cboxShown.map(function (i) { return i.code; })'));
+
+test('the country starts at the United States, in a combobox in front of the select', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  assert.equal(w.a().home_country, 'US', 'the default answer is the United States');
+  assert.equal(w.$('physCountry').value, 'US', 'on the select everything reads');
+  assert.equal(w.$('physCountryIn').value, 'United States', 'and said by name in the field');
+  assert.equal(w.$('physRegionField').hidden, false, 'so the state field is there from the start');
+  assert.equal(w.$('physCountry').hidden, true, 'the script hides the plain select');
+  assert.equal(w.$('physCountryBox').hidden, false, 'and shows the searchable field');
+  const input = w.$('physCountryIn'), list = w.$('physCountryList');
+  assert.equal(input.getAttribute('role'), 'combobox');
+  assert.equal(input.getAttribute('aria-controls'), 'physCountryList');
+  assert.equal(input.getAttribute('aria-expanded'), 'false');
+  assert.equal(list.getAttribute('role'), 'listbox');
+  assert.equal(list.hidden, true, 'closed until asked');
+  // a choice taken back stays taken back, and the last project's answers still win
+  const cleared = boot();
+  cleared.run('phys().answers.home_country = null; physDefaults();');
+  assert.equal(cleared.a().home_country, null);
+  const filled = boot({ draft: {} });
+  filled.run('phys(); physDefaults(); physAccountAnswers = { home_country: "NL" };');
+  filled.$('physFromAccount').click();
+  assert.equal(filled.a().home_country, 'NL', 'the fill replaces the default');
+  assert.equal(filled.$('physCountryIn').value, 'Netherlands');
+});
+
+test('typing filters the list, ignoring case and accents, the closest names first', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  w.$('physCountryIn').listeners.click();
+  assert.equal(w.$('physCountryList').hidden, false, 'a click opens the whole list');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-expanded'), 'true');
+  assert.ok(shownCodes(w).length > 200, 'every country');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-activedescendant'), 'physCountryOpt-US', 'on the one already chosen');
+  typeCountry(w, 'NETH');
+  assert.deepEqual(shownCodes(w), ['NL', 'BQ'], 'case does not matter; the name that starts with it first, then Caribbean Netherlands');
+  typeCountry(w, 'cote');
+  assert.deepEqual(shownCodes(w), ['CI'], 'nor accents (Côte d’Ivoire)');
+  typeCountry(w, 'curacao');
+  assert.deepEqual(shownCodes(w), ['CW']);
+  typeCountry(w, 'ger');
+  assert.equal(shownCodes(w)[0], 'DE', 'a name that starts with it leads');
+  assert.ok(shownCodes(w).includes('NG') && shownCodes(w).includes('DZ'), 'then names with it inside');
+  typeCountry(w, 'usa');
+  assert.equal(shownCodes(w)[0], 'US');
+  typeCountry(w, 'zzz');
+  assert.deepEqual(shownCodes(w), []);
+  assert.equal(w.$('physCountryNone').hidden, false, 'nothing matches, and it says so');
+  assert.equal(w.$('physCountryIn').getAttribute('aria-activedescendant'), null);
+  // every option is a node with its name as text, never markup
+  const opts = w.$('physCountryList').children.filter((c) => c.getAttribute('data-code'));
+  assert.ok(opts.length > 200);
+  const nl = opts.find((c) => c.getAttribute('data-code') === 'NL');
+  assert.equal(nl.textContent, 'Netherlands');
+  assert.equal(nl.getAttribute('role'), 'option');
+  assert.equal(nl.getAttribute('id'), 'physCountryOpt-NL');
+  assert.doesNotMatch(SCRIPT.slice(SCRIPT.indexOf('function cboxFold('), SCRIPT.indexOf('function physCountryChanged(')), /innerHTML/);
+});
+
+test('arrow keys move through the list, Enter picks, Escape puts the country back', () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  const input = w.$('physCountryIn');
+  typeCountry(w, 'ger');
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  input.listeners.keydown(key('ArrowDown'));
+  const second = shownCodes(w)[1];
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-' + second);
+  input.listeners.keydown(key('ArrowUp'));
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  input.listeners.keydown(key('Enter'));
+  assert.equal(w.a().home_country, 'DE', 'Enter picks');
+  assert.equal(w.$('physCountry').value, 'DE');
+  assert.equal(input.value, 'Germany');
+  assert.equal(w.$('physCountryList').hidden, true, 'and closes the list');
+  assert.equal(input.getAttribute('aria-expanded'), 'false');
+  typeCountry(w, 'fra');
+  input.listeners.keydown(key('Escape'));
+  assert.equal(w.a().home_country, 'DE', 'Escape changes nothing');
+  assert.equal(input.value, 'Germany', 'and puts the chosen name back');
+  assert.equal(w.$('physCountryList').hidden, true);
+  input.listeners.keydown(key('ArrowDown'));
+  assert.equal(w.$('physCountryList').hidden, false, 'ArrowDown opens it again');
+  assert.equal(input.getAttribute('aria-activedescendant'), 'physCountryOpt-DE');
+  typeCountry(w, 'France');
+  input.listeners.blur();
+  assert.equal(w.a().home_country, 'FR', 'leaving with a whole name typed picks it');
+  typeCountry(w, 'fr');
+  input.listeners.blur();
+  assert.equal(w.a().home_country, 'FR', 'leaving half way keeps the country');
+  assert.equal(input.value, 'France');
+});
+
+test('a country picked from the list runs the select\'s own path: the region, the screen and what Create sends', async () => {
+  const w = boot();
+  w.run('physDefaults(); paintChecks();');
+  w.a().home_region = 'US-CA';
+  typeCountry(w, 'canada');
+  const ca = w.$('physCountryList').children.find((c) => c.getAttribute('data-code') === 'CA');
+  ca.click();
+  assert.equal(w.a().home_country, 'CA');
+  assert.equal(w.a().home_region, null, 'a state of another country is dropped');
+  assert.equal(w.$('physRegionField').hidden, false, 'a country with provinces asks for one');
+  assert.ok(w.$('physRegion').children.some((o) => o.value === 'CA-ON'));
+  typeCountry(w, 'netherlands');
+  w.$('physCountryList').children.find((c) => c.getAttribute('data-code') === 'NL').click();
+  assert.equal(w.$('physRegionField').hidden, true, 'and one without does not');
+  await w.settle();
+  const asked = w.fetched.filter((f) => f.url.includes('physics-check')).map((f) => f.body.detail.home_country);
+  assert.deepEqual(asked, ['CA', 'NL'], 'each pick asks the table again, with the code');
+  // the same code the select path sends
+  const viaSelect = boot();
+  viaSelect.run('physDefaults(); paintChecks();');
+  viaSelect.$('physCountry').value = 'NL';
+  viaSelect.$('physCountry').listeners.change();
+  assert.deepEqual(plain(w.run('createDetail()')), plain(viaSelect.run('createDetail()')), 'Create sends exactly what the select sends');
+  assert.equal(plain(w.run('createDetail()')).home_country, 'NL');
+  // and untouched, Create sends the default
+  const untouched = boot();
+  untouched.run('physDefaults(); paintChecks();');
+  assert.equal(plain(untouched.run('createDetail()')).home_country, 'US');
+});