@bongos/core 1.19.280 → 1.19.282

package/tests/goal_criterion_confirm_ui.mjs

@@ -37,6 +37,9 @@ const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-page.j
 // the REAL file in the same context rather than stubbing it — stubbing would let
 // the extraction rot without this, the only test that executes either board.
 const TASK_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/task-lib.js'), 'utf8');
+// task 1003135: the page's pure presentational helpers moved to goals-lib.js
+// (window.OTBGoalsLib) — run the REAL file too, same reasoning as task-lib above.
+const GOALS_LIB_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-lib.js'), 'utf8');
 
 const { test, summary } = makeRunner();
 
@@ -132,6 +135,7 @@ async function render({ rank = 'metic', goalStatus = 'open', criteria = Object.v
   sandbox.globalThis = sandbox;
   vm.createContext(sandbox);
   vm.runInContext(TASK_LIB_SRC, sandbox, { filename: 'task-lib.js' });
+  vm.runInContext(GOALS_LIB_SRC, sandbox, { filename: 'goals-lib.js' });
   vm.runInContext(SRC, sandbox, { filename: 'goals-page.js' });
 
   // Let boot()'s promise chain settle (me → goals → details → route → render).

package/tests/goals_card_view.mjs

@@ -0,0 +1,61 @@
+// tests/goals_card_view.mjs — the Goals page list|cards toggle (task 1003136).
+//
+// Source-contract pins over goals-page.js: the DONE-WHEN properties that a DOM
+// harness can't cheaply hold are exactly the ones that rot silently — the two
+// views sharing one fact source, the drag landmine staying DELIBERATELY dead,
+// and the view choice persisting off-URL. The interactive render itself is
+// exercised by tests/goal_criterion_confirm_ui.mjs, which runs the real page.
+//
+// Run:  node tests/goals_card_view.mjs
+
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { makeRunner } from './helpers.mjs';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-page.js'), 'utf8');
+const CSS = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals.css'), 'utf8');
+const { test, summary } = makeRunner();
+
+await test('both views render from ONE fact source (goalRenderFacts) so they cannot drift', () => {
+  assert.match(SRC, /function goalRenderFacts\(/, 'the shared fact fn must exist');
+  const rowBody = SRC.slice(SRC.indexOf('function goalRowHtml'), SRC.indexOf('function goalCardHtml'));
+  assert.match(rowBody, /goalRenderFacts\(g/, 'the row must consume the shared facts');
+  const cardBody = SRC.slice(SRC.indexOf('function goalCardHtml'));
+  assert.match(cardBody.slice(0, 1200), /goalRenderFacts\(g/, 'the card must consume the shared facts');
+});
+
+await test('renderList forks on the f-goal-view toggle AFTER grouping/filter/sort (both views share them)', () => {
+  const body = SRC.slice(SRC.indexOf('function renderList'), SRC.indexOf('drag-to-reorder: RETIRED'));
+  assert.match(body, /#f-goal-view/, 'the fork reads the toggle');
+  const sortIdx = body.indexOf('sortGoals(');
+  const forkIdx = body.indexOf('#f-goal-view');
+  assert.ok(sortIdx >= 0 && forkIdx > sortIdx, 'grouping/sort must run before the view fork');
+  assert.match(body, /goalCardHtml/, 'cards view renders goalCardHtml');
+  assert.match(body, /goalRowHtml/, 'list view still renders goalRowHtml');
+  assert.match(body, /<div class="goal-grid">/, 'cards nest an id-less .goal-grid so the block override does not flatten them');
+});
+
+await test('the view choice persists via localStorage (otb.goals.view), never the URL', () => {
+  assert.match(SRC, /GOAL_VIEW_PREF = 'otb\.goals\.view'/);
+  assert.match(SRC, /setItem\(GOAL_VIEW_PREF/, 'onChange writes the pref');
+  assert.match(SRC, /getItem\(GOAL_VIEW_PREF\)/, 'boot reads the pref back');
+});
+
+await test('drag-to-reorder is deliberately retired: no listener, no draggable cards, decision stated', () => {
+  assert.ok(!/function wireDragReorder/.test(SRC), 'wireDragReorder must stay deleted');
+  assert.ok(!/addEventListener\('drag/.test(SRC), 'no drag listeners anywhere on the page');
+  const cardBody = SRC.slice(SRC.indexOf('function goalCardHtml'), SRC.indexOf('function renderList'));
+  assert.ok(!/draggable/.test(cardBody), 'goalCardHtml must not emit a draggable attribute');
+  assert.match(SRC, /RETIRED \(task 1003136/, 'the retirement decision is stated where the code lived');
+});
+
+await test('goals.css: the block override stays id-scoped so inner .goal-grid card grids survive', () => {
+  assert.match(CSS, /#goal-grid\.goal-grid \{ display: block/, 'the outer flatten must stay id-selected');
+  assert.match(CSS, /\.goal-grid \{ display: grid; grid-template-columns: repeat\(auto-fill/, 'the card grid rule must survive');
+  assert.ok(!/goal-card__handle|goal-card--dragging/.test(CSS), 'the drag affordance CSS is gone with the listener');
+});
+
+summary();

package/tests/goals_lib.mjs

@@ -0,0 +1,70 @@
+// tests/goals_lib.mjs — the Goals page's extracted pure helpers (goals-lib.js,
+// task 1003135). Pins (a) that the lib loads standalone in a bare window — it
+// must not silently grow a dependency on the page's IIFE state, which is the
+// whole reason it could move out of the oversized goals-page.js — and (b) the
+// behaviour of the helpers the page destructures.
+//
+// Run:  node tests/goals_lib.mjs
+
+import { strict as assert } from 'node:assert';
+import fs from 'node:fs';
+import path from 'node:path';
+import vm from 'node:vm';
+import { fileURLToPath } from 'node:url';
+import { makeRunner } from './helpers.mjs';
+
+const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
+const SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/goals-lib.js'), 'utf8');
+const { test, summary } = makeRunner();
+
+const windowObj = {};
+const sandbox = { window: windowObj, Set, Map, Math, Number, String, Array, Object, Date, JSON };
+sandbox.globalThis = sandbox;
+vm.createContext(sandbox);
+vm.runInContext(SRC, sandbox, { filename: 'goals-lib.js' });
+const lib = windowObj.OTBGoalsLib;
+
+await test('loads standalone in a bare window (no page-state dependency) and exports the full surface', () => {
+  assert.ok(lib, 'window.OTBGoalsLib must be set');
+  for (const k of ['DONE_STATUSES', 'CUT_STATUSES', 'isTodoStatus', 'ring', 'memberName',
+    'readinessOf', 'EMPTY_ROLLUP', 'goalRollLine', 'matchesTodoSearch', 'msOf', 'taskActivityMs']) {
+    assert.ok(k in lib, `missing export: ${k}`);
+  }
+});
+
+await test('readinessOf buckets match the task-1002439 rules', () => {
+  assert.equal(lib.readinessOf({ status: 'shipped' }), 'done');
+  assert.equal(lib.readinessOf({ status: 'abandoned' }), 'cut');
+  assert.equal(lib.readinessOf({ status: 'active' }), 'active');
+  assert.equal(lib.readinessOf({ status: 'ready' }), 'ready');
+  assert.equal(lib.readinessOf({ status: 'backlog', blocked_by: [{ satisfied: false }] }), 'blocked');
+  assert.equal(lib.readinessOf({ status: 'backlog' }), 'backlog');
+});
+
+await test('matchesTodoSearch: bare number, #N and title fragments all match (task 1003135 search semantics)', () => {
+  const t = { id: 1002163, title: 'Show the goal id on the row' };
+  assert.ok(lib.matchesTodoSearch(t, ''));
+  assert.ok(lib.matchesTodoSearch(t, '1002163'));
+  assert.ok(lib.matchesTodoSearch(t, '#1002163'));
+  assert.ok(lib.matchesTodoSearch(t, '2163'), 'substring id match');
+  assert.ok(lib.matchesTodoSearch(t, 'goal id'));
+  assert.ok(!lib.matchesTodoSearch(t, 'zzz'));
+  assert.ok(lib.matchesTodoSearch(t, '#'), 'a lone # narrows nothing');
+});
+
+await test('goalRollLine renders only non-zero buckets; ring is well-formed SVG', () => {
+  const line = lib.goalRollLine({ ready: 2, active: 0, blocked: 1, backlog: 0 });
+  assert.match(line, /<b>2<\/b> ready/);
+  assert.match(line, /<b>1<\/b> blocked/);
+  assert.ok(!line.includes('in progress'), 'zero buckets are omitted');
+  assert.equal(lib.goalRollLine({ ready: 0, active: 0, blocked: 0, backlog: 0 }), '');
+  assert.match(lib.ring(2, 5, false), /aria-label="2 of 5 criteria satisfied"/);
+});
+
+await test('memberName label idiom: display name, then @login, then builder #id', () => {
+  assert.equal(lib.memberName({ display_name: 'A', github_login: 'a', builder_id: 1 }), 'A');
+  assert.equal(lib.memberName({ github_login: 'a', builder_id: 1 }), '@a');
+  assert.equal(lib.memberName({ builder_id: 1 }), 'builder #1');
+});
+
+summary();