@bongos/core 1.19.280 → 1.19.282

package/modules/hall-ui/public/goals-lib.js

@@ -0,0 +1,99 @@
+// goals-lib.js — the Goals page's PURE presentational helpers, exposed as
+// window.OTBGoalsLib. Carved out of the oversized goals-page.js (task 1003135;
+// the fitness excess-lines ratchet). Everything here is a pure function over
+// its arguments (or a constant) — no `state`, no DOM reads — so it can move
+// without dragging the page's IIFE state along. Loaded by goals.html BEFORE
+// goals-page.js (the task-lib.js / hall-kit.js pattern, tasks 1002463 / 2171).
+(function () {
+  'use strict';
+
+  // Settled task statuses (paid or awaiting land) vs terminal "deliberately
+  // cut" states — neither work-to-do nor done. CUT is excluded from the todo
+  // list and the conflict scan the same way migration 017 keeps them out of
+  // version_progress ("abandoned is a terminal state (deliberately cut), not
+  // pending work"). Without this, an abandoned task shows up under a goal's
+  // "Work to do" as if it were still queued.
+  const DONE_STATUSES = new Set(['completed', 'confirmed', 'shipped']);
+  const CUT_STATUSES = new Set(['abandoned', 'dropped']);
+  // Genuinely-open work under a goal: not done, not cut → {backlog, ready,
+  // active, blocked}.
+  const isTodoStatus = (s) => !DONE_STATUSES.has(s) && !CUT_STATUSES.has(s);
+
+  // The criteria progress ring (satisfied/total), green once achieved.
+  function ring(satisfied, total, achieved, size = 42) {
+    const pct = total > 0 ? satisfied / total : (achieved ? 1 : 0);
+    const r = 16;
+    const circ = 2 * Math.PI * r;
+    const dash = (pct * circ).toFixed(1);
+    const gap = (circ - pct * circ).toFixed(1);
+    const stroke = achieved ? 'var(--ok)' : 'var(--accent)';
+    return `<svg class="goal-ring" width="${size}" height="${size}" viewBox="0 0 42 42" role="img" aria-label="${satisfied} of ${total} criteria satisfied">
+        <circle cx="21" cy="21" r="${r}" fill="none" stroke="var(--rule-soft)" stroke-width="4"></circle>
+        <circle cx="21" cy="21" r="${r}" fill="none" stroke="${stroke}" stroke-width="4" stroke-linecap="round" stroke-dasharray="${dash} ${gap}" transform="rotate(-90 21 21)"></circle>
+        <text x="21" y="25" text-anchor="middle" class="goal-ring__label">${satisfied}/${total}</text>
+      </svg>`;
+  }
+
+  function memberName(m) {
+    return m.display_name || (m.github_login ? `@${m.github_login}` : `builder #${m.builder_id}`);
+  }
+
+  // ---- task-readiness rollup (hall redesign task 1002439) -------------------
+  // Dependencies are a TASK property; a goal is only "blocked" in the derived
+  // sense that all its actionable tasks wait on upstream tasks (the Tasks page,
+  // not this one, owns the actual task→task graph). So the Goals page rolls each
+  // goal's tasks into these buckets:
+  //   done     — settled (shipped/confirmed/completed)
+  //   active   — a live claim ("in progress")
+  //   ready    — claimable now (deps met + promoted)
+  //   blocked  — backlog with ≥1 unshipped dependency
+  //   backlog  — backlog, no unmet deps (just not started/promoted)
+  function readinessOf(t) {
+    const s = t.status;
+    if (DONE_STATUSES.has(s)) return 'done';
+    if (CUT_STATUSES.has(s)) return 'cut';
+    if (s === 'active') return 'active';
+    if (s === 'ready') return 'ready';
+    if (s === 'backlog' && (t.blocked_by || []).some((d) => !d.satisfied)) return 'blocked';
+    return 'backlog';
+  }
+  const EMPTY_ROLLUP = { done: 0, active: 0, ready: 0, blocked: 0, backlog: 0, cut: 0, total: 0, nextReady: null };
+
+  // task 1002439 — a goal row's readiness rollup line (only the non-zero buckets).
+  const ROLL_DOTS = [
+    ['ready', 'ready', 'var(--ok)'],
+    ['active', 'in progress', 'var(--info)'],
+    ['blocked', 'blocked', 'var(--terracotta)'],
+    ['backlog', 'backlog', 'var(--ink-faint)'],
+  ];
+  function goalRollLine(r) {
+    const parts = ROLL_DOTS.filter(([k]) => r[k] > 0)
+      .map(([k, label, c]) => `<span class="gr-d"><i style="background:${c}"></i><b>${r[k]}</b> ${label}</span>`);
+    return parts.length ? `<div class="gr-roll">${parts.join('')}</div>` : '';
+  }
+
+  // Free-text search over a goal's todo list (work.js:261-274, minus the
+  // goal-title match — a single goal makes that redundant). '#N', 'N' and a
+  // bare number all match the id.
+  function matchesTodoSearch(t, q) {
+    if (!q) return true;
+    const needle = q.replace(/^#/, '');
+    if (!needle) return true;
+    if (String(t.id).includes(needle)) return true;
+    if ((t.title || '').toLowerCase().includes(needle)) return true;
+    return false;
+  }
+
+  // ms helpers for the goal ordering (task 1002965): updated_at moves on every
+  // task write, shipped_at folded in because a ship path can stamp it without
+  // touching updated_at.
+  const msOf = (iso) => { const t = iso ? Date.parse(iso) : NaN; return Number.isNaN(t) ? 0 : t; };
+  const taskActivityMs = (t) => Math.max(msOf(t.updated_at), msOf(t.shipped_at));
+
+  window.OTBGoalsLib = {
+    DONE_STATUSES, CUT_STATUSES, isTodoStatus,
+    ring, memberName,
+    readinessOf, EMPTY_ROLLUP, goalRollLine,
+    matchesTodoSearch, msOf, taskActivityMs,
+  };
+})();

package/modules/hall-ui/public/goals-page.js

@@ -35,13 +35,18 @@
   // empty/skeleton states — adopted here by task 2171.
   const { makePager, paginate, wirePager, pagerBarHtml, makeTabs, makeFilterBar,
     emptyStateHtml, skeletonRows } = window.OTBKit;
+  // This page's pure presentational helpers (goals-lib.js, task 1003135 — carved
+  // out of this oversized file; the fitness excess-lines ratchet). Destructured
+  // so every call site below reads exactly as before.
+  const { DONE_STATUSES, CUT_STATUSES, isTodoStatus, ring, memberName,
+    readinessOf, EMPTY_ROLLUP, goalRollLine, matchesTodoSearch,
+    msOf, taskActivityMs } = window.OTBGoalsLib;
   const API = '/api/bongos';
   // Generated typed client (task 1996 / R09), served as window.BongosClient by
   // /lib/bongos-client.js. baseUrl:'' passes the full same-origin paths this file
   // builds through unchanged; result-mode ({ status, ok, data }) preserves control flow 1:1.
   const api = window.BongosClient.createClient({ baseUrl: '', credentials: 'same-origin', throwOnError: false });
 
-  const DONE_STATUSES = new Set(['completed', 'confirmed', 'shipped']);
   // task 1888 — the Work tables and the conflicts list render capped; the pager
   // under each expands to the full set.
   const CONFLICT_CAP = 3;
@@ -59,15 +64,6 @@
     todo: makePager('goal-todo', 'otb.goals.todoPerPage'),
     done: makePager('goal-done', 'otb.goals.donePerPage'),
   };
-  // Terminal "deliberately cut" states — neither work-to-do nor done. Excluded
-  // from the todo list and the conflict scan the same way migration 017 keeps
-  // them out of version_progress ("abandoned is a terminal state (deliberately
-  // cut), not pending work"). Without this, an abandoned task shows up under a
-  // goal's "Work to do" as if it were still queued.
-  const CUT_STATUSES = new Set(['abandoned', 'dropped']);
-  // Genuinely-open work under a goal: not done, not cut → {backlog, ready,
-  // active, blocked}.
-  const isTodoStatus = (s) => !DONE_STATUSES.has(s) && !CUT_STATUSES.has(s);
   // Record deep-links (#/task|idea|blocker/N) are owned by the shared overlay
   // (task-detail.js). This page must NOT treat them as a route change (Bug 2).
   const DEEPLINK_RE = /^#\/(?:task|idea|blocker)\/\d+$/;
@@ -148,44 +144,7 @@
     return `<span class="goal-badge ${cls}">${escapeHtml(status)}</span>`;
   }
 
-  function ring(satisfied, total, achieved, size = 42) {
-    const pct = total > 0 ? satisfied / total : (achieved ? 1 : 0);
-    const r = 16;
-    const circ = 2 * Math.PI * r;
-    const dash = (pct * circ).toFixed(1);
-    const gap = (circ - pct * circ).toFixed(1);
-    const stroke = achieved ? 'var(--ok)' : 'var(--accent)';
-    return `<svg class="goal-ring" width="${size}" height="${size}" viewBox="0 0 42 42" role="img" aria-label="${satisfied} of ${total} criteria satisfied">
-        <circle cx="21" cy="21" r="${r}" fill="none" stroke="var(--rule-soft)" stroke-width="4"></circle>
-        <circle cx="21" cy="21" r="${r}" fill="none" stroke="${stroke}" stroke-width="4" stroke-linecap="round" stroke-dasharray="${dash} ${gap}" transform="rotate(-90 21 21)"></circle>
-        <text x="21" y="25" text-anchor="middle" class="goal-ring__label">${satisfied}/${total}</text>
-      </svg>`;
-  }
-
-  function memberName(m) {
-    return m.display_name || (m.github_login ? `@${m.github_login}` : `builder #${m.builder_id}`);
-  }
-
-  // ---- task-readiness rollup (hall redesign task 1002439) --------------------
-  // Dependencies are a TASK property; a goal is only "blocked" in the derived
-  // sense that all its actionable tasks wait on upstream tasks (the Tasks page,
-  // not this one, owns the actual task→task graph). So the Goals page rolls each
-  // goal's tasks into these buckets:
-  //   done     — settled (shipped/confirmed/completed)
-  //   active   — a live claim ("in progress")
-  //   ready    — claimable now (deps met + promoted)
-  //   blocked  — backlog with ≥1 unshipped dependency
-  //   backlog  — backlog, no unmet deps (just not started/promoted)
-  function readinessOf(t) {
-    const s = t.status;
-    if (DONE_STATUSES.has(s)) return 'done';
-    if (CUT_STATUSES.has(s)) return 'cut';
-    if (s === 'active') return 'active';
-    if (s === 'ready') return 'ready';
-    if (s === 'backlog' && (t.blocked_by || []).some((d) => !d.satisfied)) return 'blocked';
-    return 'backlog';
-  }
-  const EMPTY_ROLLUP = { done: 0, active: 0, ready: 0, blocked: 0, backlog: 0, cut: 0, total: 0, nextReady: null };
+  // ring / memberName / readinessOf / EMPTY_ROLLUP → goals-lib.js (task 1003135).
   const rollupOf = (goalId) => state.rollups.get(String(goalId)) || EMPTY_ROLLUP;
 
   // ---- goal ordering (task 1002965) -----------------------------------------
@@ -197,8 +156,6 @@
   //              falling back to the goal row's own updated_at when the goal
   //              has no tasks at all, so a task-less goal still orders sanely
   //              instead of sinking to the bottom forever.
-  const msOf = (iso) => { const t = iso ? Date.parse(iso) : NaN; return Number.isNaN(t) ? 0 : t; };
-  const taskActivityMs = (t) => Math.max(msOf(t.updated_at), msOf(t.shipped_at));
   const goalCreatedMs = (g) => msOf(g.created_at);
   const goalActivityMs = (g) => state.activity.get(String(g.id)) || msOf(g.updated_at);
 
@@ -211,6 +168,8 @@
     active: { label: 'recently active', cmp: (a, b) => goalActivityMs(b) - goalActivityMs(a), stamp: (g) => ({ label: 'last work', ms: goalActivityMs(g) }) },
   };
   const GOAL_SORT_PREF = 'otb.goals.sort';
+  // task 1003136 — the list|cards view choice, persisted like the sort above.
+  const GOAL_VIEW_PREF = 'otb.goals.view';
   const currentGoalSort = () => GOAL_SORTS[$('#f-goal-order')?.value] || GOAL_SORTS.priority;
 
   // Stable: filteredGoals already returns the server's priority order, and
@@ -271,11 +230,44 @@
     }
   }
 
-  // task 1760 — priority is a WITHIN-version ordering, so the drag affordance
-  // only makes sense once the grid is narrowed to exactly one version (the
-  // "any" filter mixes versions and dragging across them would be meaningless).
-  // Priority is always visible in that state; only an Archon gets the handle —
-  // the server-side rank gate on POST /goals/reorder is the real enforcement.
+  // task 1003135 — the Owner dropdown. 'Goal owner' is goals.created_by (the
+  // fixed authority, migration 160), returned by GET /goals as a raw builder id;
+  // labels come from the directory the page already lazily caches (loadDirectory,
+  // task 1877), same label idiom as the invite dropdown. created_by is NULLABLE
+  // (system-attributed — e.g. the migration-160 '<version> — general' catch-alls),
+  // hence the explicit 'system / unattributed' option. Mirrors
+  // populateVersionFilter above; fired after boot's fetch resolves (async because
+  // of the directory fetch — fire-and-forget, the select fills when ready).
+  async function populateOwnerFilter() {
+    const sel = $('#f-goal-owner');
+    if (!sel) return;
+    const ownerIds = Array.from(new Set(
+      state.goals.filter((g) => g.created_by != null).map((g) => String(g.created_by))));
+    const hasSystem = state.goals.some((g) => g.created_by == null);
+    const dir = ownerIds.length ? await loadDirectory() : [];
+    const byId = new Map((dir || []).map((b) => [String(b.id), b]));
+    const label = (id) => {
+      const b = byId.get(id);
+      return b ? (b.display_name || '@' + b.github_login) : `builder #${id}`;
+    };
+    for (const id of ownerIds.sort((a, b) => label(a).localeCompare(label(b)))) {
+      const opt = document.createElement('option');
+      opt.value = id;
+      opt.textContent = label(id);
+      sel.appendChild(opt);
+    }
+    if (hasSystem) {
+      const opt = document.createElement('option');
+      opt.value = 'none';
+      opt.textContent = 'system / unattributed';
+      sel.appendChild(opt);
+    }
+  }
+
+  // Archon check for the detail view's manage/visibility affordances (the
+  // server-side rank gates are the real enforcement). The task-1760 drag-reorder
+  // affordance this once also served is retired — see the note where
+  // wireDragReorder used to live (task 1003136).
   const isArchon = () => (state.me?.builder?.rank || '').toLowerCase() === 'archon';
 
   // task 1002164 — confirming a criterion is Metic+ (POST /done-when/:id/satisfy,
@@ -292,6 +284,18 @@
     const ver = $('#f-goal-version')?.value || '';
     const status = $('#f-goal-status')?.value || '';
     const mineOnly = $('#f-goal-mine')?.value === 'mine';
+    // task 1003135 — free-text search (goal title OR id; '#N', 'N' and a bare
+    // number all match — the id is already rendered on the row, task 1002163)
+    // and the Owner dropdown ('none' = created_by NULL, system-attributed).
+    // Reads the DOM ids directly, matching this function's existing style.
+    const q = ($('#f-goals-search')?.value || '').trim().toLowerCase();
+    const needle = q.replace(/^#/, '');
+    const owner = $('#f-goal-owner')?.value || '';
+    const matchesSearch = (g) => !needle
+      || String(g.id).includes(needle)
+      || (g.title || '').toLowerCase().includes(needle);
+    const matchesOwner = (g) => !owner
+      || (owner === 'none' ? g.created_by == null : String(g.created_by) === owner);
     const myId = selfId();
     const iAmMember = (g) => {
       const d = state.details.get(String(g.id));
@@ -300,22 +304,11 @@
     return state.goals.filter((g) =>
       (!ver || g.version_id === ver) &&
       (!status || g.status === status) &&
+      matchesSearch(g) &&
+      matchesOwner(g) &&
       (!mineOnly || iAmMember(g)));
   }
 
-  // task 1002439 — a goal row's readiness rollup line (only the non-zero buckets).
-  const ROLL_DOTS = [
-    ['ready', 'ready', 'var(--ok)'],
-    ['active', 'in progress', 'var(--info)'],
-    ['blocked', 'blocked', 'var(--terracotta)'],
-    ['backlog', 'backlog', 'var(--ink-faint)'],
-  ];
-  function goalRollLine(r) {
-    const parts = ROLL_DOTS.filter(([k]) => r[k] > 0)
-      .map(([k, label, c]) => `<span class="gr-d"><i style="background:${c}"></i><b>${r[k]}</b> ${label}</span>`);
-    return parts.length ? `<div class="gr-roll">${parts.join('')}</div>` : '';
-  }
-
   // task 1002439 — one goal, rendered as a rollup row: criteria ring · title +
   // meta + readiness rollup · one next action (claim the next ready task, drill
   // into what's blocking, or a review/achieved note).
@@ -329,13 +322,16 @@
     return ` · ${escapeHtml(label)} ${escapeHtml(ms ? fmtDate(new Date(ms).toISOString()) : '—')}`;
   }
 
-  function goalRowHtml(g) {
+  // The facts a goal row/card renders, computed ONCE so the two views (task
+  // 1003136) can't drift: ring, meta line, roll line, and the single
+  // next-action ladder (achieved → criteria-met → claim-next → drill → quiet).
+  function goalRenderFacts(g, ringSize) {
     const d = state.details.get(String(g.id));
     const crit = d ? (d.criteria || []) : [];
     const sat = crit.filter((c) => c.satisfied).length;
     const r = rollupOf(g.id);
     const achieved = g.status === 'achieved';
-    const ringHtml = crit.length ? ring(sat, crit.length, achieved, 44)
+    const ringHtml = crit.length ? ring(sat, crit.length, achieved, ringSize)
       : `<span class="gr-crit-none" aria-hidden="true">—</span>`;
     const goalHref = `#/goal/${escapeHtml(String(g.id))}`;
     let right;
@@ -351,6 +347,12 @@
     } else {
       right = `<span class="gr-quiet">No tasks yet</span>`;
     }
+    const metaHtml = `#${escapeHtml(String(g.id))} · ${escapeHtml(g.version_id || '')}${(achieved || g.status === 'open') ? '' : ' · ' + escapeHtml(g.status)}${goalStampHtml(g)}`;
+    return { r, achieved, ringHtml, goalHref, right, metaHtml };
+  }
+
+  function goalRowHtml(g) {
+    const { r, achieved, ringHtml, goalHref, right, metaHtml } = goalRenderFacts(g, 44);
     // NOTE: a rollup row nests real links (title → goal, Claim → task overlay,
     // drill → goal), so the row itself is a <div>, not an <a> — nested anchors
     // are invalid. Only the explicit links navigate.
@@ -358,13 +360,31 @@
       <div class="gr-ringcol">${ringHtml}</div>
       <div class="gr-main">
         <a class="gr-title" href="${goalHref}">${escapeHtml(g.title || 'Untitled goal')}</a>
-        <div class="gr-meta">#${escapeHtml(String(g.id))} · ${escapeHtml(g.version_id || '')}${(achieved || g.status === 'open') ? '' : ' · ' + escapeHtml(g.status)}${goalStampHtml(g)}</div>
+        <div class="gr-meta">${metaHtml}</div>
         ${achieved ? '' : goalRollLine(r)}
       </div>
       <div class="gr-right">${right}</div>
     </div>`;
   }
 
+  // task 1003136 — the same goal as a CARD: identical facts as the row via
+  // goalRenderFacts, so nothing is lost switching views. Reuses the surviving
+  // .goal-card* CSS (goals.css — task 1002439 neutralised it, never deleted it).
+  // Deliberately emits NO draggable attribute: drag-to-reorder is retired, see
+  // the note where wireDragReorder used to live.
+  function goalCardHtml(g) {
+    const { r, achieved, ringHtml, goalHref, right, metaHtml } = goalRenderFacts(g, 36);
+    return `<div class="goal-card" data-goal-id="${escapeHtml(String(g.id))}">
+      <div class="goal-card__head">
+        <div class="gr-ringcol">${ringHtml}</div>
+        <a class="goal-card__title gr-title" href="${goalHref}">${escapeHtml(g.title || 'Untitled goal')}</a>
+      </div>
+      <div class="goal-card__meta">${metaHtml}</div>
+      ${achieved ? '' : goalRollLine(r)}
+      <div class="goal-card__foot">${right}</div>
+    </div>`;
+  }
+
   // task 1002439 — the Goals page, reorganised around momentum: a task-readiness
   // summary, then goals grouped Active (has ready/in-progress work) · Blocked
   // (only waiting-on-upstream tasks) · Achieved. "Blocked" here is a DERIVED
@@ -407,7 +427,15 @@
     </div>`;
 
     const sec = (label, n) => `<div class="gr-sec"><b>${label}</b><span class="gr-sec__n">${n}</span></div>`;
-    const listOf = (arr) => `<div class="gr-list">${arr.map(goalRowHtml).join('')}</div>`;
+    // task 1003136 — the list|cards toggle swaps how the open groups render;
+    // grouping, filters, and sort run above the fork so both views share them.
+    // Achieved/archived pills stay pills (already the compact form). The inner
+    // div is class-only .goal-grid on purpose: task 1002439's block override
+    // targets #goal-grid.goal-grid, so the original card-grid CSS applies here.
+    const cardsView = ($('#f-goal-view')?.value || 'list') === 'cards';
+    const listOf = cardsView
+      ? (arr) => `<div class="goal-grid">${arr.map(goalCardHtml).join('')}</div>`
+      : (arr) => `<div class="gr-list">${arr.map(goalRowHtml).join('')}</div>`;
     // task 1002965 — an achieved/archived goal is a compact pill, so its sort
     // date rides as its own muted span (the row's `gr-meta` equivalent). The
     // pills row already wraps, so the extra text can't widen the page.
@@ -426,63 +454,14 @@
       + (archived.length ? sec('Archived', archived.length) + `<div class="gr-pills gr-pills--muted">${archived.map(pill).join('')}</div>` : '');
   }
 
-  // ---- drag-to-reorder (task 1760, Archon-only, one version at a time) ------
-  let dragEl = null;
-
-  function wireDragReorder() {
-    const grid = $('#goal-grid');
-    if (!grid) return;
-    grid.addEventListener('dragstart', (e) => {
-      const el = e.target.closest('.goal-card');
-      if (!el || !el.hasAttribute('draggable')) return;
-      dragEl = el;
-      el.classList.add('goal-card--dragging');
-      e.dataTransfer.effectAllowed = 'move';
-    });
-    grid.addEventListener('dragover', (e) => {
-      if (!dragEl) return;
-      const over = e.target.closest('.goal-card');
-      if (!over || over === dragEl || !grid.contains(over)) return;
-      e.preventDefault();
-      const rect = over.getBoundingClientRect();
-      const after = (e.clientX - rect.left) > rect.width / 2;
-      grid.insertBefore(dragEl, after ? over.nextSibling : over);
-    });
-    grid.addEventListener('drop', (e) => { if (dragEl) e.preventDefault(); });
-    grid.addEventListener('dragend', async () => {
-      if (!dragEl) return;
-      const el = dragEl;
-      el.classList.remove('goal-card--dragging');
-      dragEl = null;
-      const ver = $('#f-goal-version')?.value || '';
-      if (!ver) return;
-      // task 1932 — with pagination the grid shows only the current PAGE, so the
-      // reorder must submit the FULL version order: the goals before this page +
-      // the page's cards in their new DOM order + the goals after it. Without
-      // this, POSTing only the visible page's ids would corrupt the priorities
-      // of the goals on other pages. Priority numbers reflect the global
-      // position (start + i + 1).
-      const filtered = filteredGoals();
-      const start = (pagers.list.page - 1) * pagers.list.perPage;
-      const cards = [...grid.querySelectorAll('.goal-card')];
-      cards.forEach((card, i) => {
-        const num = card.querySelector('.goal-card__priority');
-        if (num) num.textContent = String(start + i + 1);
-      });
-      const pageIds = cards.map((card) => Number(card.dataset.goalId));
-      const beforeIds = filtered.slice(0, start).map((g) => Number(g.id));
-      const afterIds = filtered.slice(start + pageIds.length).map((g) => Number(g.id));
-      const orderedIds = [...beforeIds, ...pageIds, ...afterIds];
-      try {
-        await postJSON(`${API}/goals/reorder`, { version_id: ver, ordered_ids: orderedIds });
-        toast('Priority order saved.');
-      } catch (err) {
-        toast((err && err.data && err.data.message) || 'Could not save the new order — reloading.');
-        state.goals = (await getJSON(`${API}/goals`).catch(() => ({ goals: state.goals }))).goals || state.goals;
-        renderList();
-      }
-    });
-  }
+  // ---- drag-to-reorder: RETIRED (task 1003136; was task 1760) ---------------
+  // wireDragReorder() lived here, dead since task 1002439's grouped rollup (its
+  // .goal-card selector matched nothing). The card view revives .goal-card
+  // markup, so the decision is now DELIBERATE: the listener is DELETED — both
+  // views render grouped, sorted, filtered sets, so DOM order no longer
+  // expresses the version priority the old dragend POSTed to /goals/reorder;
+  // re-enabling it would submit a corrupted order. Cards emit no draggable
+  // attribute. POST /goals/reorder itself is untouched (Archon, pinned).
 
   /* ---------------- detail view ---------------- */
 
@@ -515,15 +494,6 @@
     const el = $('#f-goal-search');
     return el ? el.value.trim().toLowerCase() : '';
   }
-  function matchesTodoSearch(t, q) {
-    if (!q) return true;
-    const needle = q.replace(/^#/, '');
-    if (!needle) return true;
-    if (String(t.id).includes(needle)) return true;
-    if ((t.title || '').toLowerCase().includes(needle)) return true;
-    return false;
-  }
-
   // Copy-prompt (work.js:454-503). deHashRefs stops a bare #NNN autolinking to
   // GitHub in a pasted session; the prompt points the builder at the hall task URL.
   async function copyPromptForTask(taskId, btn) {
@@ -1810,6 +1780,9 @@
       const gres = await getJSON(`${API}/goals`);
       state.goals = gres.goals || [];
       populateVersionFilter();
+      // task 1003135 — fire-and-forget: the Owner options fill when the (cached)
+      // directory resolves; boot never waits on a label lookup.
+      populateOwnerFilter().catch(() => {});
       // Prefetch details (ring + members on the cards). Sequentially-parallel,
       // failure-tolerant: a card without detail still renders.
       // task 1002439 — also fold in per-goal task-readiness rollups (one request
@@ -1836,7 +1809,12 @@
   // reads it, so keeping the pref off the URL leaves deep links shareable and
   // unchanged. Private-mode writes throw — swallowed, the pref is a nicety.
   const onListFilterChange = () => {
-    try { window.localStorage.setItem(GOAL_SORT_PREF, $('#f-goal-order')?.value || 'priority'); } catch (_) { /* private mode */ }
+    try {
+      window.localStorage.setItem(GOAL_SORT_PREF, $('#f-goal-order')?.value || 'priority');
+      // task 1003136 — the list|cards view choice survives reload, same
+      // precedent (localStorage, never the URL).
+      window.localStorage.setItem(GOAL_VIEW_PREF, $('#f-goal-view')?.value || 'list');
+    } catch (_) { /* private mode */ }
     pagers.list.page = 1;
     renderList();
   };
@@ -1847,17 +1825,36 @@
   // task 1002965 adds Sort (f-goal-order — NOT f-goal-sort, which is already
   // taken by the goal-detail To-do bar further down this file).
   let savedGoalSort = null;
-  try { savedGoalSort = window.localStorage.getItem(GOAL_SORT_PREF); } catch (_) { /* private mode */ }
+  let savedGoalView = null;
+  try {
+    savedGoalSort = window.localStorage.getItem(GOAL_SORT_PREF);
+    savedGoalView = window.localStorage.getItem(GOAL_VIEW_PREF);
+  } catch (_) { /* private mode */ }
+  // task 1003135 — Search declared on the kit spec (live 'input' listener comes
+  // free, hall-kit.js:273; no debounce needed, the match is pure client-side over
+  // the already-loaded state.goals). Id is f-goals-search — f-goal-search is
+  // already taken by the goal-detail To-do bar further down this file. Owner
+  // options are filled after boot's fetch (populateOwnerFilter), the
+  // populateVersionFilter pattern. No URL riding (url defaults off here and this
+  // page is deliberately url:false — it owns the #/goal/N hash route).
   makeFilterBar({
     mount: $('#goals-filters'),
+    search: { id: 'f-goals-search', label: 'Search', placeholder: 'goal # or name…' },
     primary: [
       { id: 'f-goal-version', label: 'Version', options: [{ value: '', label: '— any —' }] },
       { id: 'f-goal-status', label: 'Status', options: [{ value: '', label: '— any —' }, 'open', 'achieved', 'archived'] },
       { id: 'f-goal-mine', label: 'Membership', options: [{ value: '', label: 'All goals' }, { value: 'mine', label: 'My goals' }] },
+      { id: 'f-goal-owner', label: 'Owner', options: [{ value: '', label: '— any —' }] },
       { id: 'f-goal-order',
         label: 'Sort',
         value: GOAL_SORTS[savedGoalSort] ? savedGoalSort : undefined,
         options: Object.entries(GOAL_SORTS).map(([value, { label }]) => ({ value, label })) },
+      // task 1003136 — list|cards toggle; renderList forks its group renderer
+      // on this. Persisted via GOAL_VIEW_PREF, never the URL.
+      { id: 'f-goal-view',
+        label: 'View',
+        value: savedGoalView === 'cards' ? 'cards' : undefined,
+        options: [{ value: 'list', label: 'list' }, { value: 'cards', label: 'cards' }] },
     ],
     onChange: onListFilterChange,
   });
@@ -1986,7 +1983,6 @@
     if (denyBtn) { respondToJoinRequest(state.current, denyBtn.dataset.denyReq, 'deny', denyBtn); return; }
   });
   window.addEventListener('hashchange', route);
-  wireDragReorder();
 
   boot();
 })();

package/modules/hall-ui/public/goals.css

@@ -6,10 +6,12 @@
    are in style.css's hall-kit section. Everything derives from the shared
    design tokens so instance packs reskin this page along with the rest. */
 
-/* ---- goal-card grid (list view) ----
+/* ---- goal-card grid (the CARDS view) ----
    task 2171 density pass: minmax 300→230 (four across at desktop width),
-   tighter gaps/padding/type — the grid holds ~26 goals, so card height is
-   what sets the page height. */
+   tighter gaps/padding/type. Retired by task 1002439's grouped rollup, REVIVED
+   by task 1003136 as the list|cards toggle's card view: renderList nests
+   id-less .goal-grid wrappers per group, which this rule styles — the
+   #goal-grid override further down only flattens the OUTER container. */
 .goal-grid { display: grid; grid-template-columns: repeat(auto-fill, minmax(230px, 1fr)); gap: 10px; }
 .goal-card {
   display: flex; flex-direction: column; gap: 7px;
@@ -19,16 +21,9 @@
 }
 a.goal-card:hover { text-decoration: none; border-color: var(--border-strong); background: var(--surface-2); }
 .goal-card__head { display: flex; align-items: flex-start; gap: 9px; }
-/* task 1760 — priority (visible once narrowed to one version) + Archon
-   drag-to-reorder handle (server enforces the write; this is the affordance). */
-.goal-card__handle { flex: none; cursor: grab; color: var(--ink-faint); font-size: 14px; line-height: 1.2; touch-action: none; }
-.goal-card__handle:active { cursor: grabbing; }
-.goal-card__priority {
-  flex: none; min-width: 1.4em; text-align: center;
-  font-size: 11.5px; font-weight: 600; color: var(--ink-faint);
-  font-variant-numeric: tabular-nums;
-}
-.goal-card--dragging { opacity: 0.45; }
+/* task 1003136: the task-1760 drag handle/priority/dragging rules that lived
+   here are deleted with wireDragReorder (see goals-page.js) — the revived
+   cards deliberately carry no drag affordance. */
 /* task 1761: a goal blocked by an unachieved prerequisite is dimmed + hue-shifted. */
 .goal-card--blocked { opacity: 0.62; border-style: dashed; }
 .goal-card--blocked:hover { opacity: 0.85; }
@@ -209,8 +204,10 @@ a.goal-card:hover { text-decoration: none; border-color: var(--border-strong); b
    tasks up into ready/in-progress/blocked; the task→task dependency
    graph itself lives on the Tasks page. Uses the shared style.css tokens.
    ============================================================ */
-/* The list container used to be an auto-fill CARD grid; the rollup renders
-   grouped full-width blocks into it, so flip it to normal block flow. */
+/* The OUTER container renders grouped full-width blocks (summary + section
+   heads), so flip it to normal block flow. Id-selected on purpose: the cards
+   view (task 1003136) nests id-less .goal-grid wrappers per group, which keep
+   the real card grid above. */
 #goal-grid.goal-grid { display: block; gap: 0; }
 .gr-summary { display: flex; flex-wrap: wrap; gap: 22px; margin: 6px 0 20px; }
 .gr-sm { display: flex; align-items: baseline; gap: 8px; font-size: 13px; color: var(--ink-soft); }

package/modules/hall-ui/public/goals.html

@@ -198,6 +198,7 @@
 <script src="/builders/task-lib.js"></script>
 <script src="/builders/task-detail.js?v=2026-07-03-taskdetail"></script>
 <script src="/builders/brand-apply.js?v=2026-06-27-r75"></script>
-<script src="/builders/goals-page.js?v=2026-07-10-goals5"></script>
+<script src="/builders/goals-lib.js?v=2026-08-21-goalslib1"></script>
+<script src="/builders/goals-page.js?v=2026-08-21-goals7"></script>
 </body>
 </html>

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.280",
+  "version": "1.19.282",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@bongos/core",
-      "version": "1.19.280",
+      "version": "1.19.282",
       "license": "AGPL-3.0-or-later",
       "dependencies": {
         "express": "^4.21.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bongos/core",
-  "version": "1.19.280",
+  "version": "1.19.282",
   "description": "Cloud Bongos — the AI-first build platform core (GDS + platform surfaces + module system), installed as a versioned dependency (ADR 0108).",
   "license": "AGPL-3.0-or-later",
   "main": "src/platform-server.js",

package/src/module-api.js

@@ -987,8 +987,12 @@ const { validateOrRespond, LIMITS, parseId, asyncHandler, corsPublicGet, parsePa
 //         landed since 1.19.278 with no explicit bump. run 32521664476. (task 1002620)
 //   1.19.280 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
 //         landed since 1.19.279 with no explicit bump. run 32523185119. (task 1002620)
+//   1.19.281 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.280 with no explicit bump. run 32525071763. (task 1002620)
+//   1.19.282 — CI auto-patch (publish-on-merge, ADR 0161): carrier for merges
+//         landed since 1.19.281 with no explicit bump. run 32526392955. (task 1002620)
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.280'; // CI auto-patch carrier (ADR 0161); see changelog above
+const CORE_VERSION = '1.19.282'; // CI auto-patch carrier (ADR 0161); see changelog above
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');