@bongos/core 1.19.1040 → 1.19.1042

package/tests/main_audit_attestation.mjs

@@ -0,0 +1,238 @@
+// tests/main_audit_attestation.mjs — the main audit's attestation pass (task 1001433).
+//
+// The pass ties every permission-sensitive commit on main to the pull request that
+// brought it in, and requires that PR's head to carry the server's `gate-author-trust`
+// status, posted by the server's own GitHub identity. The author NAME the older pass
+// reads is typed text; the status creator is not. FLAG-ONLY by the owner's ruling
+// (2026-09-26): findings are 'review', never 'blocker'.
+//
+// Everything here runs on injected git + fetch seams — no repository, no network.
+//
+// Run:  node --test tests/main_audit_attestation.mjs
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const audit = require('../scripts/gds/main-audit.js');
+const {
+  ATTEST_CONTEXT, mapIntroducingHeads, isAttested, analyzeAttestation, attestationConfig,
+  fetchAttestations, runAttestationPass,
+} = audit;
+
+const sha = (c) => c.repeat(40);
+const PROTECTED = 'src/bongos/auth.js';  // floored in the real registry
+const PLAIN = 'docs/notes.md';           // not a protected surface
+const status = (login, state = 'success', context = ATTEST_CONTEXT) => ({ context, state, creator: { login } });
+
+// A tiny history. Mainline: R (release) ← M (merges PR head H over base B).
+// The PR carried two commits: A (protected) then H (the head, plain).
+const B = sha('b'); const A = sha('a'); const H = sha('h'); const M = sha('m'); const D = sha('d');
+const commitA = { sha: A, authorName: 'somemetic', parents: [B], files: [PROTECTED] };
+const commitH = { sha: H, authorName: 'somemetic', parents: [A], files: [PLAIN] };
+const mergeM = { sha: M, authorName: 'Lars', parents: [B, H], isMerge: true, files: [] };
+// D: a protected commit pushed straight onto main (no merge brought it in).
+const directD = { sha: D, authorName: 'IAMMASTERQUA', parents: [M], files: [PROTECTED] };
+const revRanges = { [`${B}..${H}`]: [H, A] };
+const revList = (r) => revRanges[r] || [];
+
+test('the real registry still floors the fixture paths the way these tests assume', () => {
+  const ppc = require('../src/bongos/permission-path-check.js');
+  assert.ok(ppc.matchProtected([PROTECTED]).length > 0, `${PROTECTED} must be protected`);
+  assert.equal(ppc.matchProtected([PLAIN]).length, 0, `${PLAIN} must not be protected`);
+});
+
+// ---- mapIntroducingHeads ----
+
+test('a mainline merge vouches for every commit its PR brought in, via its SECOND parent', () => {
+  const headOf = mapIntroducingHeads([mergeM], revList);
+  assert.equal(headOf.get(A), H);
+  assert.equal(headOf.get(H), H, 'a PR head vouches for itself');
+  assert.equal(headOf.has(D), false, 'a direct push has no introducing merge');
+});
+
+test('a commit keeps the FIRST merge that claims it; single-parent commits are ignored', () => {
+  const other = { sha: sha('n'), parents: [sha('x'), sha('y')] };
+  const headOf = mapIntroducingHeads([mergeM, other, commitA], (r) => (r === `${sha('x')}..${sha('y')}` ? [A] : revList(r)));
+  assert.equal(headOf.get(A), H);
+});
+
+// ---- isAttested: the creator is the part that cannot be faked ----
+
+test('a success from the trusted account attests; the login match ignores case', () => {
+  assert.equal(isAttested([status('owner-acct')], 'Owner-Acct'), true);
+});
+
+test('FORGERY: the same context posted by any other account attests nothing', () => {
+  assert.equal(isAttested([status('IAMMASTERQUA')], 'owner-acct'), false);
+  assert.equal(isAttested([status('github-actions[bot]')], 'owner-acct'), false);
+});
+
+test("only the trusted account's NEWEST status for the context decides", () => {
+  // newest first, as GitHub returns them
+  assert.equal(isAttested([status('owner-acct', 'failure'), status('owner-acct', 'success')], 'owner-acct'), false, 'a later failure withdraws');
+  assert.equal(isAttested([status('owner-acct', 'success'), status('owner-acct', 'failure')], 'owner-acct'), true, 'a later success restores');
+  // another account can neither attest nor revoke
+  assert.equal(isAttested([status('mallory', 'failure'), status('owner-acct', 'success')], 'owner-acct'), true);
+});
+
+test('another context, a pending state, or no trusted login attests nothing', () => {
+  assert.equal(isAttested([status('owner-acct', 'success', 'unit-report')], 'owner-acct'), false);
+  assert.equal(isAttested([status('owner-acct', 'pending')], 'owner-acct'), false);
+  assert.equal(isAttested([status('owner-acct')], ''), false);
+  assert.equal(isAttested(null, 'owner-acct'), false);
+});
+
+// ---- analyzeAttestation ----
+
+test('an attested PR head clears every protected commit it brought in', () => {
+  const headOf = mapIntroducingHeads([mergeM], revList);
+  const r = analyzeAttestation([commitA, commitH], { headOf, attested: new Set([H]), trustedLogin: 'owner-acct' });
+  assert.equal(r.checked, 1, 'only the protected commit is checked');
+  assert.deepEqual(r.findings, []);
+});
+
+test('an unattested PR head is a REVIEW finding naming the head — never a blocker', () => {
+  const headOf = mapIntroducingHeads([mergeM], revList);
+  const r = analyzeAttestation([commitA], { headOf, attested: new Set(), trustedLogin: 'owner-acct' });
+  assert.equal(r.findings.length, 1);
+  const f = r.findings[0];
+  assert.equal(f.severity, 'review', 'flag-only: the owner ruled this pass must not gate');
+  assert.equal(f.kind, 'unattested');
+  assert.equal(f.head, H);
+  assert.match(f.summary, /pull request that brought it in \(head hhhhhhhhh\)/);
+  assert.match(f.summary, /gate-author-trust' status from 'owner-acct'/);
+});
+
+test('a direct push to main is flagged as having no pull request at all', () => {
+  const r = analyzeAttestation([directD], { headOf: new Map(), attested: new Set(), trustedLogin: 'owner-acct' });
+  assert.equal(r.findings.length, 1);
+  assert.equal(r.findings[0].severity, 'review');
+  assert.equal(r.findings[0].head, D);
+  assert.match(r.findings[0].summary, /without passing through a pull request/);
+});
+
+test('a ONE-commit pull request (head === the commit) still reads as a pull request', () => {
+  const lone = { sha: H, authorName: 'somemetic', parents: [B], files: [PROTECTED] };
+  const r = analyzeAttestation([lone], { headOf: new Map([[H, H]]), attested: new Set(), trustedLogin: 'owner-acct' });
+  assert.match(r.findings[0].summary, /pull request that brought it in/);
+  assert.doesNotMatch(r.findings[0].summary, /without passing through a pull request/);
+});
+
+test('a direct push that carries the attestation ITSELF is cleared', () => {
+  const r = analyzeAttestation([directD], { headOf: new Map(), attested: new Set([D]), trustedLogin: 'owner-acct' });
+  assert.deepEqual(r.findings, []);
+});
+
+// ---- attestationConfig ----
+
+test('config: Actions env first, GH_TOKEN as the laptop fallback, owner as the default login', () => {
+  assert.deepEqual(attestationConfig({ env: { GITHUB_TOKEN: 't1', GITHUB_REPOSITORY: 'owner-acct/core' } }),
+    { token: 't1', repo: 'owner-acct/core', trustedLogin: 'owner-acct' });
+  assert.equal(attestationConfig({ env: { GH_TOKEN: 't2' } }).token, 't2');
+  assert.equal(attestationConfig({ env: {} }).token, null);
+});
+
+test('config: the repo is read from the origin remote without ever capturing a credential in it', () => {
+  const https = attestationConfig({ env: {}, remoteUrl: 'https://x-access-token:SECRET@github.com/owner/repo.git' });
+  assert.equal(https.repo, 'owner/repo');
+  assert.ok(!JSON.stringify(https).includes('SECRET'));
+  assert.equal(attestationConfig({ env: {}, remoteUrl: 'git@github.com:owner/repo.git' }).repo, 'owner/repo');
+  assert.equal(attestationConfig({ env: {}, remoteUrl: 'https://example.com/x/y.git' }).repo, null);
+});
+
+test('config: --attest-login overrides the owner default (an App-posting instance)', () => {
+  const c = attestationConfig({ env: { GITHUB_REPOSITORY: 'o/r' }, loginArg: 'bongos-app[bot]' });
+  assert.equal(c.trustedLogin, 'bongos-app[bot]');
+});
+
+// ---- fetchAttestations ----
+
+function stubFetch(bySha) {
+  const calls = [];
+  const impl = async (url, init) => {
+    calls.push({ url, init });
+    const s = Object.keys(bySha).find((k) => url.includes(`/commits/${k}/`));
+    const r = bySha[s];
+    if (r instanceof Error) throw r;
+    if (typeof r === 'number') return { ok: false, status: r, json: async () => ({}) };
+    return { ok: true, status: 200, json: async () => r };
+  };
+  return { impl, calls };
+}
+
+test('fetch: reads each head once, keeps only the trusted attestations, sends the token', async () => {
+  const { impl, calls } = stubFetch({ [H]: [status('owner-acct')], [D]: [status('mallory')] });
+  const r = await fetchAttestations([H, D, H], { repo: 'o/r', token: 'tok', trustedLogin: 'owner-acct', fetchImpl: impl });
+  assert.deepEqual([...r.attested], [H]);
+  assert.deepEqual(r.unreadable, []);
+  assert.equal(calls.length, 2, 'a head shared by several commits is read once');
+  assert.equal(calls[0].url, `https://api.github.com/repos/o/r/commits/${H}/statuses?per_page=100`);
+  assert.equal(calls[0].init.headers.Authorization, 'Bearer tok');
+});
+
+test('fetch: an unreadable head is reported, never counted as attested or unattested', async () => {
+  const { impl } = stubFetch({ [H]: 404, [D]: new Error('network down') });
+  const r = await fetchAttestations([H, D], { repo: 'o/r', token: 'tok', trustedLogin: 'owner-acct', fetchImpl: impl });
+  assert.equal(r.attested.size, 0);
+  assert.deepEqual(r.unreadable.map((u) => u.reason), ['HTTP 404', 'network down']);
+});
+
+// ---- runAttestationPass: the whole pass on fake git + fetch ----
+
+function fakeGit({ mainline, ranges, remote = 'https://github.com/o/r.git' }) {
+  return (args) => {
+    if (args === 'remote get-url origin') return `${remote}\n`;
+    if (args.startsWith('rev-list --first-parent ')) return mainline.join('\n');
+    if (args.startsWith('rev-list ')) return (ranges[args.slice('rev-list '.length)] || []).join('\n');
+    throw new Error(`unexpected git ${args}`);
+  };
+}
+const history = [directD, mergeM, commitH, commitA];
+const gitImpl = fakeGit({ mainline: [D, M], ranges: revRanges });
+
+test('pass: nothing protected in range → it ran, checked nothing, needed no token', async () => {
+  const r = await runAttestationPass([commitH], 'x..y', { env: {}, gitImpl: () => { throw new Error('git must not be called'); } });
+  assert.deepEqual(r, { ran: true, checked: 0, findings: [] });
+});
+
+test('pass: no token → DID NOT RUN with the reason, never a clean pass', async () => {
+  const r = await runAttestationPass(history, 'x..y', { env: {}, gitImpl });
+  assert.equal(r.ran, false);
+  assert.match(r.reason, /no GitHub token/);
+});
+
+test('pass: end to end — the attested PR clears, the direct push is flagged', async () => {
+  const { impl } = stubFetch({ [H]: [status('o')], [D]: [] });
+  const r = await runAttestationPass(history, 'x..y', { env: { GH_TOKEN: 'tok' }, gitImpl, fetchImpl: impl });
+  assert.equal(r.ran, true);
+  assert.equal(r.checked, 2);
+  assert.deepEqual(r.findings.map((f) => f.sha), [D]);
+  assert.equal(r.trustedLogin, 'o', 'the owner of the origin remote');
+});
+
+test('pass: a FORGED mark on the PR head (right name, wrong account) is flagged', async () => {
+  const { impl } = stubFetch({ [H]: [status('IAMMASTERQUA')], [D]: [status('o')] });
+  const r = await runAttestationPass(history, 'x..y', { env: { GH_TOKEN: 'tok' }, gitImpl, fetchImpl: impl });
+  assert.deepEqual(r.findings.map((f) => f.sha), [A]);
+  assert.ok(r.findings.every((f) => f.severity === 'review'));
+});
+
+test('pass: a head it could not read makes the whole pass DID NOT RUN', async () => {
+  const { impl } = stubFetch({ [H]: 502, [D]: [status('o')] });
+  const r = await runAttestationPass(history, 'x..y', { env: { GH_TOKEN: 'tok' }, gitImpl, fetchImpl: impl });
+  assert.equal(r.ran, false);
+  assert.match(r.reason, /could not read the commit statuses of 1 pull-request head/);
+});
+
+test('pass: a merge INSIDE a pull request never vouches — only mainline merges do', async () => {
+  // I: a branch's "merge main into me" whose second parent is a main commit P.
+  const P = sha('p'); const I = sha('i');
+  const inner = { sha: I, authorName: 'x', parents: [A, P], isMerge: true, files: [] };
+  const mainP = { sha: P, authorName: 'x', parents: [B], files: [PROTECTED] };
+  const g = fakeGit({ mainline: [P], ranges: { [`${A}..${P}`]: [P] } });
+  const { impl } = stubFetch({ [P]: [] });
+  const r = await runAttestationPass([inner, mainP], 'x..y', { env: { GH_TOKEN: 'tok' }, gitImpl: g, fetchImpl: impl });
+  assert.equal(r.findings.length, 1);
+  assert.equal(r.findings[0].head, P, 'P answers for itself; the inner merge did not claim it');
+});

package/tests/module_api.mjs

@@ -56,6 +56,7 @@ const PUBLISHED_SURFACE = [
   'buildInfo', 'validateOrRespond', 'LIMITS', 'parseId', 'asyncHandler', 'corsPublicGet', // parseId added 1.8.0 (BV1.R78); asyncHandler + corsPublicGet added 1.12.0 (BV1.R86; lifecycle routes)
   'parsePagination', 'pageMeta', 'PAGINATION', // R14 (#2001, 1.17.0): shared pagination contract for module list routes (ADR 0119)
   'responsibilityFor', 'ROLE_RESPONSIBILITIES', // added by task 1003732 (ADR 0275; criterion wa6-written-responsibilities): the ONE source for the sentence each craft is answerable for. It rides the doorway because two modules need the same text — grading judges role-shaped work against it, the hall shows it to the person being judged — and modules never import each other. Declared here deliberately: this list is what makes adding to the doorway a decision rather than a side effect
+  'readPackageRegistry', // added by task 1004296 (ADR 0340 D5): the npm registry reader moved into the core, because Settings → Software update needs it in every hall; the module that publishes a package reads the same answer and cache through here rather than keeping a second copy
   'logger',
 ];
 

package/tests/nav_permission_atoms.mjs

@@ -87,7 +87,7 @@ test('the hall-preview fixture carries every atom /me resolves', () => {
 // the file and left the query alone, so a returning browser kept the cached copy —
 // a fix that reaches nobody looks identical to a fix that does not work.
 
-const SHELL_SHA = '983282a83fd5aa71';
+const SHELL_SHA = 'ff2017aa9bbbc507';
 
 test('shell.js has not changed without its cache-bust being bumped', () => {
   const actual = crypto.createHash('sha256').update(SHELL).digest('hex').slice(0, 16);

package/tests/npm_release_page.mjs

@@ -22,6 +22,8 @@ const DEPLOY_SRC = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/deplo
 const FIXTURE = JSON.parse(fs.readFileSync(path.join(ROOT, 'scripts/hall-preview/fixtures/npm-release__work.json'), 'utf8'));
 
 const escapeHtml = (s) => String(s).replace(/[&<>"']/g, (c) => ({ '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' }[c]));
+// Voice rule V4: quoted data renders with its dashes as commas (docs/voice.md).
+const unDash = (raw) => String(raw == null ? '' : raw).replace(/\s*[—–]\s*/g, ', ').replace(/,\s*,/g, ',').trim();
 
 function makeEl() {
   return { hidden: true, _html: '', set innerHTML(v) { this._html = String(v); }, get innerHTML() { return this._html; } };
@@ -67,7 +69,7 @@ test('every recent task is named, by title, linked to its page', async () => {
     // Stages longer than the fold show their first rows; the rest sit behind "Show all".
     for (const t of rows.slice(0, 8)) {
       assert.ok(html.includes(`href="/task/${t.id}"`), `${stage}: task ${t.id} is linked`);
-      assert.ok(html.includes(escapeHtml(t.title)), `${stage}: task ${t.id} is named`);
+      assert.ok(html.includes(escapeHtml(unDash(t.title))), `${stage}: task ${t.id} is named`);
     }
   }
   assert.match(html, /Show all 15/);
@@ -171,3 +173,11 @@ test('the deploy page loads the module script only for its own view, and only wi
   assert.deepEqual(bootDeploy({ modules: undefined }), [], 'no module record at all');
   assert.deepEqual(bootDeploy({ modules: on, search: '?project=mercury' }), [], 'another project\'s view is not this package\'s');
 });
+
+test('a task title and a note line are quoted ledger data: their dashes render as commas (V4)', async () => {
+  const stages = { ...FIXTURE.stages, not_merged: [{ ...FIXTURE.stages.not_merged[0], title: 'Deploy page — where the work is – phase 1' }] };
+  const b = bootWork(() => ok({ ...FIXTURE, stages }));
+  await b.settle();
+  assert.ok(b.work().innerHTML.includes('>Deploy page, where the work is, phase 1</a>'));
+  assert.doesNotMatch(b.work().innerHTML, /Deploy page [—–]/);
+});

package/tests/npm_release_work.mjs

@@ -15,9 +15,8 @@
 import assert from 'node:assert/strict';
 import { test } from 'node:test';
 import { createRequire } from 'node:module';
-import { EventEmitter } from 'node:events';
-import { Readable } from 'node:stream';
-import zlib from 'node:zlib';
+
+import { npmTarball, npmPackument, fakeHttpsGet } from './helpers.mjs';
 
 const require = createRequire(import.meta.url);
 const { readWork } = require('../modules/npm-release/work.js');
@@ -26,90 +25,6 @@ const buildRouter = require('../modules/npm-release/routes/work.js');
 const ORIGIN = 'https://registry.npmjs.org';
 const PKG = '@bongos/core';
 
-// ---- a real tarball, built by hand ---------------------------------------------------
-
-function tarHeader(name, size, type = '0') {
-  const h = Buffer.alloc(512, 0);
-  h.write(name.slice(0, 100), 0, 'utf8');
-  h.write('0000644\0', 100, 'ascii');
-  h.write('0000000\0', 108, 'ascii');
-  h.write('0000000\0', 116, 'ascii');
-  h.write(`${size.toString(8).padStart(11, '0')}\0`, 124, 'ascii');
-  h.write('00000000000\0', 136, 'ascii');
-  h.write('        ', 148, 'ascii');
-  h.write(type, 156, 'ascii');
-  h.write('ustar\0', 257, 'ascii');
-  h.write('00', 263, 'ascii');
-  let sum = 0;
-  for (const b of h) sum += b;
-  h.write(`${sum.toString(8).padStart(6, '0')}\0 `, 148, 'ascii');
-  return h;
-}
-function tarEntry(name, data, type = '0') {
-  const body = Buffer.isBuffer(data) ? data : Buffer.from(data);
-  const pad = Buffer.alloc((512 - (body.length % 512)) % 512, 0);
-  return Buffer.concat([tarHeader(name, body.length, type), body, pad]);
-}
-function paxEntry(path) {
-  // A pax record is "<len> <key>=<value>\n", where <len> counts its own digits too.
-  const rec = (k, v) => {
-    const body = ` ${k}=${v}\n`;
-    let n = body.length + 1;
-    while (String(n).length + body.length !== n) n = String(n).length + body.length;
-    return `${n}${body}`;
-  };
-  return tarEntry('PaxHeader/x', rec('path', path), 'x');
-}
-/** A gzipped npm-shaped tarball. `notes` null leaves release-notes.json out. */
-function tarball({ notes, padBytes = 40000, pax = false } = {}) {
-  const parts = [
-    tarEntry('package/package.json', JSON.stringify({ name: PKG })),
-    // A large file BEFORE the notes, so the reader has to skip across many chunks.
-    tarEntry('package/big.js', Buffer.alloc(padBytes, 97)),
-  ];
-  if (notes) {
-    const json = JSON.stringify(notes);
-    if (pax) parts.push(paxEntry('package/release-notes.json'), tarEntry('package/SHORTNAME', json));
-    else parts.push(tarEntry('package/release-notes.json', json));
-  }
-  parts.push(Buffer.alloc(1024, 0));
-  return zlib.gzipSync(Buffer.concat(parts));
-}
-
-// ---- a fake registry -----------------------------------------------------------------
-
-function packument({ versions, latest, times }) {
-  const doc = { name: PKG, 'dist-tags': { latest }, versions: {}, time: {} };
-  for (const v of versions) {
-    doc.versions[v] = { version: v, dist: { tarball: `${ORIGIN}/@bongos/core/-/core-${v}.tgz` } };
-    doc.time[v] = times[v];
-  }
-  return doc;
-}
-
-/** `get` answering from `routes` (url → { status, body }), recording every URL asked for. */
-function fakeGet(routes) {
-  const asked = [];
-  const get = (url, opts, cb) => {
-    asked.push(url);
-    const req = new EventEmitter();
-    req.destroy = () => {};
-    setImmediate(() => {
-      const r = routes[url];
-      if (!r) { req.emit('error', new Error(`no route for ${url}`)); return; }
-      const body = Buffer.isBuffer(r.body) ? r.body : Buffer.from(typeof r.body === 'string' ? r.body : JSON.stringify(r.body));
-      // Small chunks, so a tar header lands across a chunk boundary.
-      const chunks = [];
-      for (let i = 0; i < body.length; i += 777) chunks.push(body.subarray(i, i + 777));
-      const res = Readable.from(chunks);
-      res.statusCode = r.status || 200;
-      cb(res);
-    });
-    return req;
-  };
-  return { get, asked };
-}
-
 function fakePool(tasks, titles = {}) {
   const queries = [];
   return {
@@ -153,13 +68,13 @@ const TASKS = [
   row('23', 'shipped', '2026-09-24T08:00:00.000Z', { value_summary: 'A hand-landed change nobody numbered.' }),
 ];
 
-function setup({ latest = '1.0.5', tgz = tarball({ notes: NOTES }), pkStatus = 200, tgzStatus = 200, installed = INSTALLED_TO_103, tasks = TASKS, titles = {} } = {}) {
+function setup({ latest = '1.0.5', tgz = npmTarball({ notes: NOTES }), pkStatus = 200, tgzStatus = 200, installed = INSTALLED_TO_103, tasks = TASKS, titles = {} } = {}) {
   const versions = Object.keys(TIMES);
   const routes = {
-    [`${ORIGIN}/@bongos%2fcore`]: { status: pkStatus, body: pkStatus === 200 ? packument({ versions, latest, times: TIMES }) : 'nope' },
+    [`${ORIGIN}/@bongos%2fcore`]: { status: pkStatus, body: pkStatus === 200 ? npmPackument({ versions, latest, times: TIMES }) : 'nope' },
     [`${ORIGIN}/@bongos/core/-/core-1.0.5.tgz`]: { status: tgzStatus, body: tgz },
   };
-  const fg = fakeGet(routes);
+  const fg = fakeHttpsGet(routes);
   const pool = fakePool(tasks, titles);
   const store = freshStore();
   const read = (over = {}) => readWork({ pool, pkg: PKG, live: '1.0.3', get: fg.get, store, installedNotes: installed, now: () => Date.parse('2026-09-26T13:00:00Z'), ...over });
@@ -223,7 +138,7 @@ test('notes past the installed copy are read out of the newest package', async (
 });
 
 test('a pax long-name header is followed to the notes file', async () => {
-  const d = await setup({ tgz: tarball({ notes: NOTES, pax: true }) }).read();
+  const d = await setup({ tgz: npmTarball({ notes: NOTES, pax: true }) }).read();
   assert.equal(d.notes.covers_to, '1.0.5');
   assert.deepEqual(ids(d.stages.not_live), ['15']);
 });
@@ -236,7 +151,7 @@ test('when the installed notes already reach the newest version, nothing is down
 });
 
 test('a package without notes is an error, not an empty history', async () => {
-  const d = await setup({ tgz: tarball({ notes: null }) }).read();
+  const d = await setup({ tgz: npmTarball({ notes: null }) }).read();
   assert.match(d.notes.error, /without release notes/);
   // The installed copy stands in: the work up to 1.0.3 is still placed.
   assert.deepEqual(d.notes.source, { from: 'installed', version: '1.0.3' });
@@ -262,9 +177,9 @@ test('a registry that does not answer is reported, and the installed notes still
 
 test('the package download is only ever followed on the registry\'s own origin', async () => {
   const versions = Object.keys(TIMES);
-  const doc = packument({ versions, latest: '1.0.5', times: TIMES });
+  const doc = npmPackument({ versions, latest: '1.0.5', times: TIMES });
   doc.versions['1.0.5'].dist.tarball = 'https://evil.example/core.tgz';
-  const fg = fakeGet({ [`${ORIGIN}/@bongos%2fcore`]: { body: doc } });
+  const fg = fakeHttpsGet({ [`${ORIGIN}/@bongos%2fcore`]: { body: doc } });
   const d = await readWork({ pool: fakePool(TASKS), pkg: PKG, live: '1.0.3', get: fg.get, store: freshStore(), installedNotes: INSTALLED_TO_103 });
   assert.ok(!fg.asked.some((u) => u.includes('evil.example')));
   assert.match(d.notes.error, /no download/);