@bongos/core 1.19.1040 → 1.19.1042

package/src/bongos/software-update.js

@@ -0,0 +1,127 @@
+'use strict';
+
+// src/bongos/software-update.js — Settings → Software update (task 1004296): this project's
+// running core, the newest release its update channel lets it take, and what is in the
+// versions between the two.
+//
+// The owner, 2026-09-25: "each builders hall settings has a version description where they
+// can pull the latest release. Just like iOS does." So this is the one place any project —
+// the platform included — reads its version and what an update would bring. It is the CORE's,
+// not a module's, because every project installs releases.
+//
+// WHAT'S NEW COMES FROM THE PACKAGE'S OWN RELEASE NOTES, never from the changelog. Every CI
+// version's changelog line reads "carrier for merges landed since X", which names no work;
+// release-notes.json (scripts/gds/release-notes.js, task 1004218) is the one per-version
+// list of what landed, and the newest package carries the whole history. The running core's
+// own copy stops at its own version, so an update's notes always come off the registry
+// (package-registry.js: streamed, cached, fail-soft).
+//
+// THE CHANNEL RULE IS NOT RESTATED HERE, as in core-update.js: `resolveChannelTarget` is the
+// upgrade runner's own function, so this never offers a version the runner would refuse.
+// No channel is passed, exactly as the banner passes none: an instance does not store its
+// own channel, and the runner's default is what it would get.
+//
+// A READING, NEVER A GUESS. `reading` is 'ok' only when the registry answered; "up to date"
+// is `offered: null` on an ok reading and nothing else. Notes that could not be read say so,
+// and a version whose notes are missing is shown as missing rather than as empty.
+
+const {
+  CORE_PKG,
+  DEFAULT_CHANNEL,
+  normalizeChannel,
+  resolveChannelTarget,
+  compareSemver,
+} = require('../../scripts/gds/update-channel.js');
+const { readRegistry } = require('./package-registry');
+
+const VERSION_RE = /^\d+\.\d+\.\d+$/;
+// The same bound the deploy page puts on a line: a release note is a sentence, and one that
+// came off the network is re-checked before it is drawn.
+const TEXT_MAX = 400;
+// A project months behind can be hundreds of versions short. The panel lists the newest
+// ones and counts the rest; every one of them is still in the update.
+const VERSIONS_MAX = 40;
+
+function boundText(text) {
+  const t = String(text || '').trim();
+  return t.length > TEXT_MAX ? `${t.slice(0, TEXT_MAX - 1)}…` : t;
+}
+
+/** One version's entries, re-checked; null when the notes do not list the version at all. */
+function entriesFor(notes, version) {
+  const list = notes && Object.prototype.hasOwnProperty.call(notes, version) ? notes[version] : undefined;
+  if (!Array.isArray(list)) return null;
+  const out = [];
+  for (const e of list) {
+    const text = boundText(e && e.text);
+    if (!text) continue;
+    const id = e && /^\d{1,12}$/.test(String(e.id == null ? '' : e.id)) ? String(e.id) : null;
+    out.push({ id, text });
+  }
+  return out;
+}
+
+/**
+ * The panel's whole answer, from one registry reading. PURE — no clock, no I/O.
+ *
+ * `registry` and `notes` are package-registry.js's `readRegistry` result. Versions in the
+ * update are the published ones above `running` and at or below `offered`, newest first.
+ */
+function softwareUpdateVerdict({ running, channel, registry, notes, checkedAt }) {
+  const ch = normalizeChannel(channel == null ? DEFAULT_CHANNEL : channel);
+  const base = { checked_at: checkedAt, running: running || null, channel: ch };
+  if (!running || !VERSION_RE.test(String(running))) {
+    return { ...base, reading: 'no_answer', error: 'this project could not name the version it runs', offered: null, newest: null, whats_new: null };
+  }
+  if (!registry || !registry.ok) {
+    return { ...base, reading: 'no_answer', error: (registry && registry.error) || 'the registry could not be read', offered: null, newest: null, whats_new: null };
+  }
+  const offered = resolveChannelTarget({ installed: running, channel: ch, available: registry.versions }) || null;
+  const published = registry.published || {};
+  const answer = {
+    ...base,
+    reading: 'ok',
+    error: null,
+    offered,
+    offered_published_at: offered ? published[offered] || null : null,
+    newest: registry.newest || null,
+    whats_new: null,
+  };
+  if (!offered) return answer;
+
+  const inUpdate = registry.versions
+    .filter((v) => compareSemver(v, running) > 0 && compareSemver(v, offered) <= 0)
+    .sort((a, b) => compareSemver(b, a));
+  const shown = inUpdate.slice(0, VERSIONS_MAX);
+  const ok = !!(notes && notes.ok);
+  answer.whats_new = {
+    ok,
+    error: ok ? null : ((notes && notes.error) || 'the release notes could not be read'),
+    count: inUpdate.length,
+    more: inUpdate.length - shown.length,
+    versions: shown.map((version) => ({
+      version,
+      published_at: published[version] || null,
+      entries: ok ? entriesFor(notes.notes, version) : null,
+    })),
+  };
+  return answer;
+}
+
+/**
+ * What GET /api/bongos/software-update answers — and this file's one export.
+ *
+ * `get`/`now`/`store` pass through to the registry reader, so a test drives the real
+ * packument parsing, the real tarball stream and the real cache rather than a stub.
+ */
+async function readSoftwareUpdate({ running, channel, get, now = Date.now, store } = {}) {
+  const t = now();
+  const { registry, notes } = await readRegistry({
+    pkg: CORE_PKG, get, now, store,
+    // Nothing to describe when nothing newer is published: skip the download.
+    haveNotesFor: (newest) => !VERSION_RE.test(String(running || '')) || compareSemver(newest, running) <= 0,
+  });
+  return softwareUpdateVerdict({ running, channel, registry, notes, checkedAt: new Date(t).toISOString() });
+}
+
+module.exports = { readSoftwareUpdate };

package/src/module-api.js

@@ -71,7 +71,7 @@ const { responsibilityFor, ROLE_RESPONSIBILITIES } = require('./role-responsibil
 // there. scripts/gds/bump-version.js still rewrites the literal below; it appends
 // the entry to that file. Look for a version's history there, not here.
 // ---------------------------------------------------------------------------
-const CORE_VERSION = '1.19.1040'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
+const CORE_VERSION = '1.19.1042'; // CI auto-patch carrier (ADR 0161); changelog: docs/module-api-changelog.md
 
 // A namespaced logger so a module's log lines are attributable + consistent.
 // Usage: const log = api.logger('dev-box'); log.info('mounted');
@@ -494,6 +494,15 @@ module.exports = {
   responsibilityFor,
   ROLE_RESPONSIBILITIES,
 
+  // --- readPackageRegistry({ pkg, haveNotesFor, get, now, store }) — what the npm
+  //     registry says about a package: its versions, their publish dates, the
+  //     `latest` label, and the release notes the newest version was packed with
+  //     (task 1004296). The core owns it because Settings → Software update needs
+  //     it in every hall; a module that publishes a package reads the same answer
+  //     and the same process-local cache through here. Fail-soft: it resolves
+  //     `{ registry, notes }` with `ok:false` and a sentence, never a throw.
+  readPackageRegistry: (...a) => require('./bongos/package-registry').readRegistry(...a),
+
   // --- logging
   logger,
 };

package/tests/core_upgrade_owner_door.mjs

@@ -342,8 +342,9 @@ await t('deploy_url is the hub origin plus this project\'s slug, and null withou
 const SHELL = fs.readFileSync(path.join(ROOT, 'modules/hall-ui/public/shell.js'), 'utf8');
 
 // The real shell.js in a DOM stub (the tests/core_update_banner.mjs harness), with the
-// /core-update answer carrying a deploy_url and elements that remember their attributes.
-function boot({ provisioning, deployUrl }) {
+// /core-update answer optionally carrying a deploy_url — an older server still sends one —
+// and elements that remember their attributes.
+function boot({ provisioning, deployUrl, pathname = '/settings', hash = '' }) {
   const els = new Map();
   const inserted = [];
   const makeEl = () => ({
@@ -372,7 +373,7 @@ function boot({ provisioning, deployUrl }) {
     addEventListener() {}, dispatchEvent() {},
     get cookie() { return ''; }, set cookie(_v) {},
   };
-  const location = { hostname: 'h', origin: 'https://h', pathname: '/settings', hash: '', assign() {}, replace() {} };
+  const location = { hostname: 'h', origin: 'https://h', pathname, hash, assign() {}, replace() {} };
   const update = { running: '1.19.871', latest: '1.19.1033', behind: true, reading: 'ok' };
   const windowObj = {
     __BRANDING__: {}, __MODULES__: { enabled: { provisioning } },
@@ -401,40 +402,48 @@ function boot({ provisioning, deployUrl }) {
 const settle = () => new Promise((r) => setTimeout(r, 0));
 const HUB = 'https://cloudbongos.com/deploy?project=hoodify-finance';
 
-await t('on a hosted project, the banner\'s Upgrade goes to the hub door for THIS project', async () => {
+// Task 1004296 moved the hand-off: a hall without a door of its own sends its owner to
+// Settings → Software update, whose Update button carries the hub address (GET
+// /software-update's `door`). The banner and the rail no longer link off-site.
+await t('on a hosted project, the banner\'s Upgrade goes to Settings → Software update, not off-site', async () => {
   const b = boot({ provisioning: false, deployUrl: HUB });
   await settle();
   assert.ok(b.banner(), 'the banner renders');
-  assert.ok(b.banner().innerHTML.includes(`href="${HUB}"`), 'Upgrade links to the hub');
-  assert.doesNotMatch(b.banner().innerHTML, /href="\/deploy"/, 'never the dead local page');
+  assert.match(b.banner().innerHTML, /href="\/settings#software-update"/, 'Upgrade opens the Software update panel');
+  assert.ok(!b.banner().innerHTML.includes(HUB), 'never the hub address directly, even when an older server sends one');
+  assert.doesNotMatch(b.banner().innerHTML, /href="\/deploy"/, 'never the local /deploy, which this hall no longer has');
 });
 
-await t('on a hosted project, the rail\'s Deploy item is re-pointed at the hub', async () => {
+await t('on a hosted project, the rail\'s Deploy item stays hidden — it is the platform hall\'s page', async () => {
   const b = boot({ provisioning: false, deployUrl: HUB });
   await settle();
   const item = b.deployItem();
-  assert.equal(item.getAttribute('href'), HUB);
-  assert.equal('module' in item.dataset, false, 'its module gate is lifted so the access loop stops hiding it');
-  assert.equal(item.hidden, false, 'an Archon on their own project sees it');
+  assert.equal(item.getAttribute('href'), null, 'not re-pointed at the hub');
+  assert.equal(item.dataset.module, 'provisioning', 'its module gate stays, so a hall without the door hides it');
 });
 
-await t('a hosted project with no hub, or a hub address that is not plain http(s), offers no link', async () => {
-  for (const url of [null, 'javascript:alert(1)', 'https://x.test/"><img src=x onerror=alert(1)>', 42]) {
+await t('a hall with no door of its own and no hub still links to Software update', async () => {
+  for (const url of [null, 'javascript:alert(1)', 42]) {
     const b = boot({ provisioning: false, deployUrl: url });
     await settle();
-    assert.ok(b.banner(), 'the news is still told');
-    assert.doesNotMatch(b.banner().innerHTML, /core-update-notice__action/, `no action for ${JSON.stringify(url)}`);
-    const item = b.deployItem();
-    assert.equal(item.getAttribute('href'), null, `the rail is not re-pointed for ${JSON.stringify(url)}`);
-    assert.equal(item.dataset.module, 'provisioning', 'and it keeps its module gate, so a hosted project still hides it');
+    assert.match(b.banner().innerHTML, /href="\/settings#software-update"/, `Software update for ${JSON.stringify(url)}`);
+    assert.doesNotMatch(b.banner().innerHTML, /javascript:/);
   }
 });
 
-await t('on the platform, the local door wins: the hub address is ignored', async () => {
+await t('on the Software update panel itself, the banner points rather than linking to the page it is on', async () => {
+  const b = boot({ provisioning: false, pathname: '/settings', hash: '#software-update' });
+  await settle();
+  assert.doesNotMatch(b.banner().innerHTML, /core-update-notice__action/, 'no link to where you already are');
+  assert.match(b.banner().innerHTML, /core-update-notice__hint/);
+});
+
+await t('on the platform, the local door wins: the banner links /deploy and the rail keeps it', async () => {
   const b = boot({ provisioning: true, deployUrl: HUB });
   await settle();
   assert.match(b.banner().innerHTML, /href="\/deploy"/);
   assert.ok(!b.banner().innerHTML.includes(HUB));
+  assert.ok(!b.banner().innerHTML.includes('software-update'), 'the platform takes its update at its own door');
   const item = b.deployItem();
   assert.notEqual(item.getAttribute('href'), HUB, 'the rail keeps the local /deploy');
   assert.equal(item.dataset.module, 'provisioning', 'and its module gate, which the platform satisfies');

package/tests/grade_model_provider.mjs

@@ -74,7 +74,7 @@ test('the Claude spawn is the default provider, with the identical argv', { skip
     const r = await subagent.runSubagent({ prompt: 'hi', opts: { claudeBin: bin, model: 'claude-sonnet-5', cwd: dir } });
     const argv = JSON.parse(subagent.extractAssistantResult(r.stdout));
     const perm = typeof process.getuid === 'function' && process.getuid() === 0 ? 'acceptEdits' : 'bypassPermissions';
-    assert.deepEqual(argv, ['-p', '--print', '--model', 'claude-sonnet-5', '--output-format', 'json', '--tools', 'Read', '--disable-slash-commands', '--permission-mode', perm]);
+    assert.deepEqual(argv, ['-p', '--print', '--model', 'claude-sonnet-5', '--output-format', 'json', '--tools', 'Read', '--strict-mcp-config', '--disable-slash-commands', '--permission-mode', perm]);
     assert.equal(r.cost_usd, 0.5);
     const d = await subagent.runSubagent({ prompt: 'hi', opts: { claudeBin: bin, cwd: dir } });
     assert.equal(JSON.parse(subagent.extractAssistantResult(d.stdout))[3], 'claude-sonnet-5', 'no model → the default grader model, as before');

package/tests/grader_reviewer_isolation.mjs

@@ -0,0 +1,68 @@
+// tests/grader_reviewer_isolation.mjs — a grader reviewer sees the Read tool and
+// NOTHING the host happens to have connected (task 1000380, re-scoped 2026-09-26).
+//
+// THE GAP THIS PINS. Every panel worker is a `claude -p` session reading a diff that
+// someone else wrote, launched with permission prompts off (bypassPermissions, or
+// acceptEdits as root — task 1003574). `--tools Read` limits the BUILT-IN tools only.
+// It says nothing about MCP servers, so without `--strict-mcp-config` a reviewer
+// inherits every server the host has configured — the user's settings, the project's
+// .mcp.json, and the claude.ai connectors. Measured on the owner's Mac on 2026-09-26
+// with the reviewer's exact flags: 22 tools (Read + 21 MCP tools, among them a docs
+// connector that can create and delete documents); with `--strict-mcp-config`, 1.
+// A diff that smuggles instructions to its reviewer had those 21 tools to reach for,
+// with nothing to prompt for approval.
+//
+// `--strict-mcp-config` with no `--mcp-config` beside it loads zero servers, which is
+// the whole intent: a reviewer needs no MCP server to read files.
+//
+// Run:  node --test tests/grader_reviewer_isolation.mjs
+import { test } from 'node:test';
+import assert from 'node:assert/strict';
+import fs from 'node:fs';
+import os from 'node:os';
+import path from 'node:path';
+import { createRequire } from 'node:module';
+
+const require = createRequire(import.meta.url);
+const subagent = require('../modules/grading/grader-subagent.js');
+
+// A stand-in `claude` that answers with the argv it was launched with, in the
+// result envelope the real CLI uses — so the test reads what was ACTUALLY passed
+// to the spawn, not what the source text looks like.
+async function spawnArgv(opts = {}) {
+  const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'grader-isolation-'));
+  const bin = path.join(dir, 'claude');
+  fs.writeFileSync(bin, '#!/usr/bin/env node\nprocess.stdin.resume(); process.stdin.on("end", () => process.stdout.write(JSON.stringify({ type: "result", result: JSON.stringify(process.argv.slice(2)) })));\n');
+  fs.chmodSync(bin, 0o755);
+  try {
+    const r = await subagent.runSubagent({ prompt: 'review this', opts: { claudeBin: bin, cwd: dir, ...opts } });
+    return JSON.parse(subagent.extractAssistantResult(r.stdout));
+  } finally {
+    fs.rmSync(dir, { recursive: true, force: true });
+  }
+}
+
+const skip = process.platform === 'win32' && 'the stand-in CLI is a shebang script';
+
+test('a reviewer is launched with --strict-mcp-config, so no host MCP server loads', { skip }, async () => {
+  const argv = await spawnArgv();
+  assert.ok(argv.includes('--strict-mcp-config'),
+    `every reviewer spawn must ignore the host's MCP configuration; argv was ${JSON.stringify(argv)}`);
+  // Strict mode with no config file is what makes the server list EMPTY. Handing it
+  // a config would re-open exactly the door the flag closes.
+  assert.ok(!argv.includes('--mcp-config'), 'no MCP config is supplied to a reviewer');
+});
+
+test('the flag holds for every model the panel runs, not only the default', { skip }, async () => {
+  for (const model of ['claude-sonnet-5', 'claude-opus-5-5', 'claude-haiku-4-5-20251001']) {
+    const argv = await spawnArgv({ model });
+    assert.ok(argv.includes('--strict-mcp-config'), `missing for ${model}`);
+  }
+});
+
+test('the built-in tool list is still Read alone — the two limits work together', { skip }, async () => {
+  const argv = await spawnArgv();
+  const i = argv.indexOf('--tools');
+  assert.ok(i >= 0, '--tools is passed');
+  assert.equal(argv[i + 1], 'Read', 'the only built-in tool is Read');
+});

package/tests/helpers.mjs

@@ -73,6 +73,9 @@ import { fileURLToPath } from 'node:url';
 import { createRequire } from 'node:module';
 import { execFileSync } from 'node:child_process';
 import vm from 'node:vm';
+import zlib from 'node:zlib';
+import { EventEmitter } from 'node:events';
+import { Readable } from 'node:stream';
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..');
 
@@ -1012,3 +1015,92 @@ export function macShapedTools(binDir) {
     '',
   ].join('\n'), { mode: 0o755 });
 }
+
+// ---- a fake npm registry (task 1002622; shared since task 1004296) -------------------
+//
+// A real gzipped tar built by hand, a packument, and an `https.get` stand-in that answers
+// in 777-byte chunks — so a reader under test runs its real gunzip, tar walk and JSON parse,
+// with headers landing across chunk boundaries. Used by tests/npm_release_work.mjs and
+// tests/software_update.mjs.
+
+function tarHeader(name, size, type = '0') {
+  const h = Buffer.alloc(512, 0);
+  h.write(name.slice(0, 100), 0, 'utf8');
+  h.write('0000644\0', 100, 'ascii');
+  h.write('0000000\0', 108, 'ascii');
+  h.write('0000000\0', 116, 'ascii');
+  h.write(`${size.toString(8).padStart(11, '0')}\0`, 124, 'ascii');
+  h.write('00000000000\0', 136, 'ascii');
+  h.write('        ', 148, 'ascii');
+  h.write(type, 156, 'ascii');
+  h.write('ustar\0', 257, 'ascii');
+  h.write('00', 263, 'ascii');
+  let sum = 0;
+  for (const b of h) sum += b;
+  h.write(`${sum.toString(8).padStart(6, '0')}\0 `, 148, 'ascii');
+  return h;
+}
+function tarEntry(name, data, type = '0') {
+  const body = Buffer.isBuffer(data) ? data : Buffer.from(data);
+  const pad = Buffer.alloc((512 - (body.length % 512)) % 512, 0);
+  return Buffer.concat([tarHeader(name, body.length, type), body, pad]);
+}
+function paxEntry(path) {
+  // A pax record is "<len> <key>=<value>\n", where <len> counts its own digits too.
+  const rec = (k, v) => {
+    const body = ` ${k}=${v}\n`;
+    let n = body.length + 1;
+    while (String(n).length + body.length !== n) n = String(n).length + body.length;
+    return `${n}${body}`;
+  };
+  return tarEntry('PaxHeader/x', rec('path', path), 'x');
+}
+/** A gzipped npm-shaped tarball. `notes` null leaves release-notes.json out. */
+export function npmTarball({ notes, padBytes = 40000, pax = false, pkg = '@bongos/core' } = {}) {
+  const parts = [
+    tarEntry('package/package.json', JSON.stringify({ name: pkg })),
+    // A large file BEFORE the notes, so the reader has to skip across many chunks.
+    tarEntry('package/big.js', Buffer.alloc(padBytes, 97)),
+  ];
+  if (notes) {
+    const json = JSON.stringify(notes);
+    if (pax) parts.push(paxEntry('package/release-notes.json'), tarEntry('package/SHORTNAME', json));
+    else parts.push(tarEntry('package/release-notes.json', json));
+  }
+  parts.push(Buffer.alloc(1024, 0));
+  return zlib.gzipSync(Buffer.concat(parts));
+}
+
+// ---- a fake registry -----------------------------------------------------------------
+
+export function npmPackument({ versions, latest, times, pkg = '@bongos/core', origin = 'https://registry.npmjs.org' }) {
+  const doc = { name: pkg, 'dist-tags': { latest }, versions: {}, time: {} };
+  for (const v of versions) {
+    doc.versions[v] = { version: v, dist: { tarball: `${origin}/${pkg}/-/${pkg.split('/').pop()}-${v}.tgz` } };
+    doc.time[v] = times[v];
+  }
+  return doc;
+}
+
+/** `get` answering from `routes` (url → { status, body }), recording every URL asked for. */
+export function fakeHttpsGet(routes) {
+  const asked = [];
+  const get = (url, opts, cb) => {
+    asked.push(url);
+    const req = new EventEmitter();
+    req.destroy = () => {};
+    setImmediate(() => {
+      const r = routes[url];
+      if (!r) { req.emit('error', new Error(`no route for ${url}`)); return; }
+      const body = Buffer.isBuffer(r.body) ? r.body : Buffer.from(typeof r.body === 'string' ? r.body : JSON.stringify(r.body));
+      // Small chunks, so a tar header lands across a chunk boundary.
+      const chunks = [];
+      for (let i = 0; i < body.length; i += 777) chunks.push(body.subarray(i, i + 777));
+      const res = Readable.from(chunks);
+      res.statusCode = r.status || 200;
+      cb(res);
+    });
+    return req;
+  };
+  return { get, asked };
+}