@bobfrankston/rmfmail 1.2.303 → 1.2.305

package/client/app.js

@@ -1774,18 +1774,53 @@ function popUndo() {
     }
     return null;
 }
-/** Route a "delete the selection" action (Delete key, Ctrl+D, top trash
- *  button) to whichever pane has a selection. Tasks take priority — if
- *  any task rows are selected, delete those; otherwise fall through to
- *  messages. The previous behavior was to always delete messages, which
- *  surprised users who'd just selected a few tasks and hit Delete. */
+/** Which pane the user last acted in. Delete / Ctrl+D / the trash buttons are
+ *  app-wide gestures, so before they can act on "the selection" they have to
+ *  know WHOSE selection is meant, and the honest answer is the pane the user
+ *  was last working in — not a fixed priority order.
+ *
+ *  Capture phase, pointerdown: it must land before any handler that stops
+ *  propagation, and before focus moves. The toolbar buttons themselves are in
+ *  neither pane, so clicking one leaves this exactly as the user's last real
+ *  interaction set it. */
+let lastActionPane = "messages";
+document.addEventListener("pointerdown", (e) => {
+    const t = e.target;
+    if (!t?.closest)
+        return;
+    if (t.closest("#cal-side-tasks"))
+        lastActionPane = "tasks";
+    else if (t.closest(".message-list, .message-viewer, #ml-body, #message-viewer"))
+        lastActionPane = "messages";
+}, true);
+/** Route a "delete the selection" action (Delete key, Ctrl+D, either trash
+ *  button) to the pane the user was last working in.
+ *
+ *  2026-09-05 — Claude Code (Opus 5), at Bob's direction ("I press del and the
+ *  message is not deleted whether I'm in the letter or summary and trashcan is
+ *  not working"). This used to give tasks an unconditional priority: any
+ *  non-empty task selection swallowed every delete gesture in the app. A task
+ *  selection is set by a single click on a task row, is never cleared by
+ *  anything the user does in the mail panes, and has no indicator outside the
+ *  sidebar — so one stray click on a task disabled Delete and both trash
+ *  buttons for messages, indefinitely, with no symptom other than nothing
+ *  happening. That is invisible modal state deciding what a destructive action
+ *  means, which is the same fault as a filter that reads as a selection.
+ *
+ *  Routing on the last-touched pane keeps the behaviour the priority rule was
+ *  written for (select some tasks, press Delete, the tasks go) and drops the
+ *  part that was never intended. Acting on messages also clears any leftover
+ *  task selection, so the sidebar stops showing rows as chosen when the
+ *  gesture has plainly moved on. */
 async function deleteSelection() {
     try {
         const sidebar = await import("./components/calendar-sidebar.js");
-        if (sidebar.getSelectedTaskUuids().length > 0) {
+        if (lastActionPane === "tasks" && sidebar.getSelectedTaskUuids().length > 0) {
             await sidebar.deleteSelectedTasks();
             return;
         }
+        if (sidebar.getSelectedTaskUuids().length > 0)
+            sidebar.clearTaskSelection();
     }
     catch { /* sidebar module not loaded yet — fall through to messages */ }
     await deleteSelectedMessages();