@bobfrankston/rmfmail 1.2.303 → 1.2.305

package/.commitmsg

@@ -1,47 +1,40 @@
-The phone's star filter was never asked for, and the chip announcing it landed in a 28px column
+One click on a task disabled Delete for the whole app
 
-"it then says no flagged messages. but there are message flagged" (Bob
-2026-09-04, on Android, with the screenshot). There are 260 — 257 in bobma's
-INBOX alone, and the desktop's own SQL finds every one of them.
+"I press del and the message is not deleted whether I'm in the letter or
+summary and trashcan is not working" (Bob 2026-09-05).
 
-`WebMailxService.getUnifiedInbox` took two parameters. api-client has always
-called it with four: `(page, pageSize, flaggedOnly, dateBasis)`. `getMessages`
-took seven and is called with nine, `flaggedOnly` at position 8. The extras
-fell off the end and JavaScript said nothing — and neither did TypeScript,
-because an implementation with FEWER parameters satisfies an interface
-declaring more. Both dropped arguments are on `MessageQuery`, documented, and
-honoured by the desktop store.
+`deleteSelection()` — the one route for the Delete key, Ctrl+D, and both trash
+buttons — gave tasks an unconditional priority: if `getSelectedTaskUuids()` was
+non-empty it deleted tasks and returned, whatever the user was actually looking
+at. A task selection is set by a single click on a task row in the sidebar, is
+never cleared by anything done in the mail panes, and has no indicator outside
+the sidebar. So one stray click on a task turned off Delete and both trash
+buttons for messages, indefinitely, and the only symptom was nothing happening.
+Invisible modal state deciding what a destructive gesture means — the same
+fault as a filter that reads as a selection.
 
-What was left on the phone was the client's `.flagged-only` CSS rule, which
-hides unflagged rows in the loaded page. That is precisely the arrangement the
-desktop comment has warned about since 2026-06-05: a paginated list whose
-newest 50 messages happen to carry no star shows nothing at all, and every
-starred message deeper in the mailbox is unreachable. The overlay then counted
-the rows it was hiding and reported the truth from where it stood — "A 'flagged
-only' filter is hiding 50 messages" — while the filter that could have found
-the other 260 had never run.
+The daemon log shows it exactly: at the moment of the attempt there is a
+getMessage and an updateFlags and no trashMessages at all. Nothing was slow or
+failing; the gesture never left the client.
 
-Both parameters are now threaded through, and the `\Flagged` predicate lives in
-one named constant matching desktop's character for character: two backslashes
-in the SQL literal, because `flags_json` is JSON and the flag is stored
-escaped. `dateBasis` was dropped by the same omission on the same line, so the
-phone has been ordering by arrival time while the desktop ordered by the Date:
-header; it now honours what it is handed. That is a visible change to list
-order on the phone, and it is the order the client has been asking for all
-along — say so if you want it left as it was.
+Routing now follows the pane the user last acted in, tracked on capture-phase
+pointerdown so it lands before any handler that stops propagation and before
+focus moves. The toolbar buttons sit in neither pane, so clicking one leaves
+that reading as the user's last real interaction set it — which is the point,
+since the button is how you act on what you were just doing. Select tasks and
+press Delete and the tasks still go, which is what the priority rule was
+written for; the part that was never intended is gone. A delete routed to
+messages also clears any leftover task selection, so the sidebar stops showing
+rows as chosen after the gesture has moved on.
 
-Three tests assert the threading, which is where the bug was. They use a spy
-db, since the failure was an argument that never arrived, not SQL that got it
-wrong.
+I made this worse yesterday and should say so. Before v1.2.304 the swallowed
+delete at least put up the native confirm — misplaced and late, but visible, so
+"my delete went to the tasks" was discoverable. Moving that question to a menu
+anchored over the task pane made the misrouting completely silent whenever the
+sidebar was collapsed or scrolled away. The routing bug was already there; my
+change removed the last evidence of it.
 
-**The chip, separately.** `#ml-filter-chip` said `display: block; width: 100%`
-and never said `grid-column: 1 / -1`. `.message-list` is a five-column grid,
-every other full-width child declares the span, and this one auto-placed into
-column 1 — the 28px avatar track — so "Showing flagged (★) messages only —
-click to show everything" came out one word per line down the left edge of the
-header. `width: 100%` cannot help there; inside a grid it means 100% of a 28px
-track.
-
-Not changed: the ★ button sits in the search row, next to Server and
-Trash/Spam, which is why reaching for search found a list filter. That is a
-placement judgement, not a bug, so it is yours to call.
+Also guarded, from the same cause: the batch confirm measured its anchor with
+getBoundingClientRect on a possibly-hidden sidebar, which is 0x0 at 0,0 — it
+now falls back to the middle of the window rather than asking in a corner
+nobody is looking at.

package/client/app.bundle.js

@@ -1015,6 +1015,7 @@ var init_edit_menu = __esm({
 var context_menu_exports = {};
 __export(context_menu_exports, {
   closeContextMenu: () => closeContextMenu,
+  confirmAt: () => confirmAt,
   showContextMenu: () => showContextMenu
 });
 function closeSubmenu() {
@@ -1029,6 +1030,11 @@ function closeContextMenu() {
     activeMenu.remove();
     activeMenu = null;
   }
+  if (closeHandler) {
+    const fn = closeHandler;
+    closeHandler = null;
+    fn();
+  }
   if (dismissListener) {
     document.removeEventListener("pointerdown", dismissListener, true);
     dismissListener = null;
@@ -1079,6 +1085,7 @@ function openSubmenu(parentRow, items) {
 }
 function showContextMenu(x, y, items, opts = {}) {
   closeContextMenu();
+  closeHandler = opts.onClose ?? null;
   if (opts.editTarget !== void 0 || opts.editEngine) {
     const edit = editMenuItems({ target: opts.editTarget, engine: opts.editEngine }, { onError: opts.onEditError });
     if (edit.length > 0) {
@@ -1168,7 +1175,29 @@ function showContextMenu(x, y, items, opts = {}) {
     document.addEventListener("keydown", escapeListener, true);
   });
 }
-var activeMenu, dismissListener, escapeListener, activeSubmenu;
+function confirmAt(x, y, confirmLabel, opts = {}) {
+  return new Promise((resolve) => {
+    let settled = false;
+    const done = (v) => {
+      if (!settled) {
+        settled = true;
+        resolve(v);
+      }
+    };
+    showContextMenu(x, y, [
+      { label: confirmLabel, action: () => done(true), emphasized: true, tooltip: opts.tooltip },
+      { label: "Cancel", action: () => done(false) }
+    ], {
+      // An item's click calls closeContextMenu() BEFORE item.action(), so
+      // onClose always runs first. Defer the "cancelled" answer by one
+      // microtask: the action is synchronous and finishes within this
+      // task, so by the time the microtask drains, a chosen item has
+      // already settled the promise and this call is a no-op.
+      onClose: () => queueMicrotask(() => done(false))
+    });
+  });
+}
+var activeMenu, dismissListener, escapeListener, activeSubmenu, closeHandler;
 var init_context_menu = __esm({
   "client/components/context-menu.js"() {
     "use strict";
@@ -1177,6 +1206,7 @@ var init_context_menu = __esm({
     dismissListener = null;
     escapeListener = null;
     activeSubmenu = null;
+    closeHandler = null;
     document.addEventListener("scroll", closeContextMenu, true);
     document.addEventListener("contextmenu", () => {
     });
@@ -6512,6 +6542,7 @@ var init_outbox_view = __esm({
 // client/components/calendar-sidebar.js
 var calendar_sidebar_exports = {};
 __export(calendar_sidebar_exports, {
+  clearTaskSelection: () => clearTaskSelection,
   deleteSelectedTasks: () => deleteSelectedTasks,
   getSelectedTaskUuids: () => getSelectedTaskUuids,
   hideCalendarSidebar: () => hideCalendarSidebar,
@@ -6619,6 +6650,12 @@ async function renderCalendarList() {
   if (lastEvents.length > 0)
     renderEvents(lastEvents);
 }
+function clearTaskSelection() {
+  if (selectedTaskUuids.size === 0)
+    return;
+  selectedTaskUuids.clear();
+  void renderTasks();
+}
 function getSelectedTaskUuids() {
   return [...selectedTaskUuids];
 }
@@ -6626,7 +6663,11 @@ async function deleteSelectedTasks() {
   const uuids = [...selectedTaskUuids];
   if (uuids.length === 0)
     return;
-  if (!confirm(`Delete ${uuids.length} task${uuids.length === 1 ? "" : "s"}? This removes ${uuids.length === 1 ? "it" : "them"} from Google Tasks \u2014 to mark done, use the checkbox instead.`))
+  const anchorEl = document.querySelector(".cal-side-task.selected") || document.getElementById("cal-side-tasks");
+  const rect = anchorEl?.getBoundingClientRect();
+  const r = rect && rect.width > 0 && rect.height > 0 ? rect : { left: window.innerWidth / 2 - 60, bottom: window.innerHeight / 3 };
+  const label = uuids.length === 1 ? `Delete "${document.querySelector(".cal-side-task.selected .cal-side-task-title")?.textContent || "this task"}"` : `Delete ${uuids.length} tasks`;
+  if (!await confirmAt(r.left + 24, r.bottom, label, { tooltip: TASK_DELETE_NOTE }))
     return;
   selectedTaskUuids.clear();
   for (const uuid of uuids) {
@@ -6914,7 +6955,7 @@ async function renderTasks(prefetched) {
     row.querySelector(".cal-side-task-delete")?.addEventListener("click", async (e) => {
       e.stopPropagation();
       const title = tasks.find((t) => t.uuid === uuid)?.title || "this task";
-      if (!confirm(`Delete task "${title}"? This removes it from Google Tasks \u2014 to mark done, use the checkbox instead.`))
+      if (!await confirmAt(e.clientX, e.clientY, `Delete "${title}"`, { tooltip: TASK_DELETE_NOTE }))
         return;
       await deleteTask(uuid);
       selectedTaskUuids.delete(uuid);
@@ -6941,9 +6982,9 @@ async function renderTasks(prefetched) {
         { label: "View in Google Tasks", action: () => openInBrowser("https://tasks.google.com/") },
         { label: "", action: () => {
         }, separator: true },
-        { label: "Delete task", action: async () => {
+        { label: "Delete task", tooltip: TASK_DELETE_NOTE, action: async () => {
           const title = tasks.find((t) => t.uuid === uuid)?.title || "this task";
-          if (!confirm(`Delete task "${title}"? This removes it from Google Tasks \u2014 to mark done, use the checkbox instead.`))
+          if (!await confirmAt(e.clientX, e.clientY, `Delete "${title}"`, { tooltip: TASK_DELETE_NOTE }))
             return;
           await deleteTask(uuid);
           renderTasks();
@@ -7296,7 +7337,7 @@ function initCalendarSidebar() {
     }
   }
 }
-var SIDEBAR_PREF, SHOW_RECURRING_PREF, SHOW_DONE_PREF, HORIZON_DAYS_PREF, HORIZON_DEFAULT_DAYS, HOLIDAY_HORIZON_MS, viewYear, viewMonth, viewDay, lastEvents, lastOverdueTasks, calById, calendarList, hiddenCalendars, selectedTaskUuids;
+var SIDEBAR_PREF, SHOW_RECURRING_PREF, SHOW_DONE_PREF, HORIZON_DAYS_PREF, HORIZON_DEFAULT_DAYS, HOLIDAY_HORIZON_MS, viewYear, viewMonth, viewDay, lastEvents, lastOverdueTasks, calById, calendarList, hiddenCalendars, selectedTaskUuids, TASK_DELETE_NOTE;
 var init_calendar_sidebar = __esm({
   "client/components/calendar-sidebar.js"() {
     "use strict";
@@ -7317,6 +7358,7 @@ var init_calendar_sidebar = __esm({
     calendarList = [];
     hiddenCalendars = /* @__PURE__ */ new Set();
     selectedTaskUuids = /* @__PURE__ */ new Set();
+    TASK_DELETE_NOTE = "Removes it from Google Tasks. To mark it done instead, use the checkbox.";
   }
 });
 
@@ -10554,13 +10596,21 @@ function popUndo() {
   }
   return null;
 }
+var lastActionPane = "messages";
+document.addEventListener("pointerdown", (e) => {
+  const t = e.target;
+  if (!t?.closest) return;
+  if (t.closest("#cal-side-tasks")) lastActionPane = "tasks";
+  else if (t.closest(".message-list, .message-viewer, #ml-body, #message-viewer")) lastActionPane = "messages";
+}, true);
 async function deleteSelection() {
   try {
     const sidebar = await Promise.resolve().then(() => (init_calendar_sidebar(), calendar_sidebar_exports));
-    if (sidebar.getSelectedTaskUuids().length > 0) {
+    if (lastActionPane === "tasks" && sidebar.getSelectedTaskUuids().length > 0) {
       await sidebar.deleteSelectedTasks();
       return;
     }
+    if (sidebar.getSelectedTaskUuids().length > 0) sidebar.clearTaskSelection();
   } catch {
   }
   await deleteSelectedMessages();