@bevel-software/platform-core-frontend 0.4.0 → 0.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (326) hide show
  1. package/package.json +5 -3
  2. package/src/core/CoreAppShell.tsx +195 -56
  3. package/src/core/__tests__/AppChrome.test.tsx +125 -0
  4. package/src/core/__tests__/ShellRoutes.test.tsx +130 -95
  5. package/src/core/__tests__/bootstrap.test.ts +63 -0
  6. package/src/core/bootstrap.ts +73 -0
  7. package/src/core/events.ts +12 -0
  8. package/src/core/registry.ts +58 -9
  9. package/src/index.css +100 -11
  10. package/src/index.ts +24 -23
  11. package/src/lib/utils.ts +114 -138
  12. package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
  13. package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
  14. package/src/modules/access/api.ts +49 -0
  15. package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
  16. package/src/modules/access/hooks/useFileAccess.ts +1 -1
  17. package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
  18. package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +172 -156
  19. package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
  20. package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
  21. package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
  22. package/src/modules/admin/components/UserAccountsPage.tsx +361 -353
  23. package/src/modules/admin/state/admin.context.tsx +15 -6
  24. package/src/modules/auth/components/AccountPage.tsx +11 -11
  25. package/src/modules/auth/components/LoginScreen.tsx +12 -12
  26. package/src/modules/auth/services/sso.ts +47 -1
  27. package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
  28. package/src/modules/change-requests/__tests__/author.test.ts +48 -0
  29. package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
  30. package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
  31. package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
  32. package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
  33. package/src/modules/change-requests/change-requests.css +22 -0
  34. package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
  35. package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
  36. package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
  37. package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
  38. package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
  39. package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
  40. package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
  41. package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
  42. package/src/modules/change-requests/services/change-requests.api.ts +45 -0
  43. package/src/modules/change-requests/services/propose.api.ts +162 -0
  44. package/src/modules/change-requests/utils/author.ts +47 -0
  45. package/src/modules/change-requests/utils/conflict.ts +38 -0
  46. package/src/modules/change-requests/utils/diff.ts +80 -0
  47. package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
  48. package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
  49. package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
  50. package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
  51. package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
  52. package/src/modules/git/components/BranchSwitcher.tsx +68 -31
  53. package/src/modules/git/components/DiffView.tsx +4 -4
  54. package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
  55. package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
  56. package/src/modules/git/components/PullNeededBanner.tsx +6 -13
  57. package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
  58. package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
  59. package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
  60. package/src/modules/git/hooks/useGitState.ts +15 -14
  61. package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
  62. package/src/modules/git/services/error-messages.ts +7 -7
  63. package/src/modules/git/services/git.api.ts +17 -11
  64. package/src/modules/git/services/pr-prompts.ts +2 -2
  65. package/src/modules/git/state/git.context.ts +10 -1
  66. package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
  67. package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
  68. package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
  69. package/src/modules/layout/breakpoints.ts +6 -0
  70. package/src/modules/layout/components/AppLayout.tsx +17 -5
  71. package/src/modules/layout/components/DemoBanner.tsx +10 -1
  72. package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -104
  73. package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
  74. package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
  75. package/src/modules/layout/components/SidebarFrame.tsx +317 -0
  76. package/src/modules/layout/components/SidebarToggle.tsx +86 -0
  77. package/src/modules/layout/components/SlideOverlay.tsx +1 -1
  78. package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
  79. package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
  80. package/src/modules/layout/state/sidebar.ts +200 -0
  81. package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
  82. package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
  83. package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
  84. package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
  85. package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
  86. package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
  87. package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
  88. package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
  89. package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
  90. package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
  91. package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
  92. package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
  93. package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
  94. package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
  95. package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
  96. package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
  97. package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
  98. package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
  99. package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
  100. package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
  101. package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
  102. package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
  103. package/src/modules/library/__tests__/auth-harness.tsx +37 -0
  104. package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
  105. package/src/modules/library/__tests__/status.test.ts +210 -117
  106. package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
  107. package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
  108. package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
  109. package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
  110. package/src/modules/library/components/ChangeRequestDock.tsx +71 -47
  111. package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
  112. package/src/modules/library/components/GroupIndexRow.tsx +63 -0
  113. package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
  114. package/src/modules/library/components/GroupPage.tsx +373 -0
  115. package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
  116. package/src/modules/library/components/GroupsSidebar.tsx +338 -0
  117. package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
  118. package/src/modules/library/components/LibraryCard.tsx +153 -132
  119. package/src/modules/library/components/LibraryLayout.tsx +344 -0
  120. package/src/modules/library/components/LibraryPage.tsx +138 -254
  121. package/src/modules/library/components/LockGlyph.tsx +31 -0
  122. package/src/modules/library/components/LockedGroupView.tsx +159 -0
  123. package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
  124. package/src/modules/library/components/NewGroupDialog.tsx +112 -0
  125. package/src/modules/library/components/NewSkillPanel.tsx +151 -0
  126. package/src/modules/library/components/PageActions.tsx +156 -0
  127. package/src/modules/library/components/PendingSkillReview.tsx +63 -0
  128. package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
  129. package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
  130. package/src/modules/library/components/StatusDot.tsx +25 -0
  131. package/src/modules/library/components/ToolLogo.tsx +171 -0
  132. package/src/modules/library/components/group-page-parts.tsx +419 -0
  133. package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
  134. package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
  135. package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
  136. package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
  137. package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
  138. package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
  139. package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
  140. package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
  141. package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
  142. package/src/modules/library/hooks/useJoinRequests.ts +114 -0
  143. package/src/modules/library/hooks/useLibraryData.ts +134 -119
  144. package/src/modules/library/hooks/useSkillDetail.ts +119 -74
  145. package/src/modules/library/hooks/useToolPage.ts +145 -0
  146. package/src/modules/library/library.css +108 -320
  147. package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
  148. package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
  149. package/src/modules/library/routes/library-paths.ts +191 -0
  150. package/src/modules/library/services/groups.api.ts +189 -0
  151. package/src/modules/library/services/library.api.ts +291 -164
  152. package/src/modules/library/services/tools.api.ts +60 -0
  153. package/src/modules/library/state/library-context.ts +22 -0
  154. package/src/modules/library/state/library-data.tsx +223 -0
  155. package/src/modules/library/state/toast.context.ts +32 -0
  156. package/src/modules/library/state/toast.tsx +84 -42
  157. package/src/modules/library/utils/clipboard.ts +33 -0
  158. package/src/modules/library/utils/group-summary.ts +68 -0
  159. package/src/modules/library/utils/names.ts +30 -0
  160. package/src/modules/library/utils/navigate-external.ts +15 -0
  161. package/src/modules/library/utils/oauth-fragment.ts +32 -0
  162. package/src/modules/library/utils/personal-group.ts +36 -0
  163. package/src/modules/library/utils/status.ts +199 -116
  164. package/src/modules/library/utils/toast-duration.ts +16 -0
  165. package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
  166. package/src/modules/onboarding/agent-clients.ts +48 -0
  167. package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
  168. package/src/modules/onboarding/components/RootLanding.tsx +54 -0
  169. package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
  170. package/src/modules/onboarding/paths.ts +9 -0
  171. package/src/modules/onboarding/state/onboarding.ts +191 -0
  172. package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
  173. package/src/modules/pr/services/pr-approvals.api.ts +19 -0
  174. package/src/modules/pr/services/pr-cancel.api.ts +11 -0
  175. package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
  176. package/src/modules/review/components/DiffViewer.tsx +4 -4
  177. package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
  178. package/src/modules/review/components/ReviewFileRow.tsx +10 -10
  179. package/src/modules/review/components/ReviewPanel.tsx +49 -17
  180. package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
  181. package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
  182. package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
  183. package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
  184. package/src/modules/secrets-vault/components/SecretsPage.tsx +313 -276
  185. package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
  186. package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +82 -51
  187. package/src/modules/secrets-vault/services/connect.api.ts +24 -3
  188. package/src/modules/settings/components/DeploymentPage.tsx +90 -0
  189. package/src/modules/settings/components/SettingsLayout.tsx +135 -0
  190. package/src/modules/settings/components/SettingsNav.tsx +114 -0
  191. package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
  192. package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
  193. package/src/modules/settings/settings-nav-items.tsx +166 -0
  194. package/src/modules/setup/__tests__/setup.test.tsx +540 -0
  195. package/src/modules/setup/components/SetupGate.tsx +67 -0
  196. package/src/modules/setup/components/SetupScreen.tsx +573 -0
  197. package/src/modules/setup/services/setup.api.ts +106 -0
  198. package/src/modules/setup/utils/git-host.ts +34 -0
  199. package/src/modules/toolbar/components/AppSwitcher.tsx +131 -108
  200. package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -548
  201. package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
  202. package/src/modules/toolbar/components/Toolbar.tsx +56 -54
  203. package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
  204. package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
  205. package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
  206. package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
  207. package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
  208. package/src/modules/workspace/components/EditorTabs.tsx +82 -50
  209. package/src/modules/workspace/components/FileExplorer.tsx +1292 -1068
  210. package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
  211. package/src/modules/workspace/components/FileRoute.tsx +89 -84
  212. package/src/modules/workspace/components/FileViewer.tsx +1312 -906
  213. package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
  214. package/src/modules/workspace/components/KbFileRail.tsx +128 -0
  215. package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
  216. package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
  217. package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
  218. package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
  219. package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
  220. package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
  221. package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
  222. package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
  223. package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
  224. package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
  225. package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
  226. package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
  227. package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
  228. package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
  229. package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
  230. package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
  231. package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
  232. package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
  233. package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
  234. package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
  235. package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
  236. package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
  237. package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
  238. package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
  239. package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
  240. package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
  241. package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
  242. package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
  243. package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
  244. package/src/modules/workspace/components/renderers/index.ts +78 -2
  245. package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
  246. package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
  247. package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
  248. package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
  249. package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
  250. package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
  251. package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
  252. package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
  253. package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
  254. package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
  255. package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
  256. package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
  257. package/src/modules/workspace/services/workspace.api.ts +9 -2
  258. package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
  259. package/src/modules/workspace/state/open-change-requests.tsx +185 -0
  260. package/src/modules/workspace/state/workspace.context.ts +9 -0
  261. package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
  262. package/src/modules/workspace/utils/diff.ts +130 -53
  263. package/src/modules/workspace/utils/fileTree.ts +182 -179
  264. package/src/modules/workspace/workspace.css +28 -0
  265. package/src/shared/components/Badge.tsx +62 -0
  266. package/src/shared/components/Banner.tsx +58 -0
  267. package/src/shared/components/Button.tsx +90 -0
  268. package/src/shared/components/Dialog.tsx +6 -6
  269. package/src/shared/components/Field.tsx +45 -0
  270. package/src/shared/components/IconButton.tsx +74 -0
  271. package/src/shared/components/ListRow.tsx +96 -0
  272. package/src/shared/components/Menu.tsx +88 -0
  273. package/src/shared/components/PageShell.tsx +54 -51
  274. package/src/shared/components/Surface.tsx +86 -0
  275. package/src/shared/components/__tests__/primitives.test.tsx +333 -0
  276. package/src/shared/components/index.ts +48 -0
  277. package/src/shared/components/useDismissableMenu.ts +71 -0
  278. package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
  279. package/src/shared/theme/index.css +12 -0
  280. package/src/shared/theme/measure.ts +64 -0
  281. package/src/shared/theme/shadows.css +34 -0
  282. package/src/shared/theme/tokens.css +193 -0
  283. package/src/test-setup.ts +9 -0
  284. package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
  285. package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
  286. package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
  287. package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
  288. package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
  289. package/src/modules/library/__tests__/diff.test.ts +0 -62
  290. package/src/modules/library/__tests__/loadout.test.tsx +0 -72
  291. package/src/modules/library/components/CompareView.tsx +0 -357
  292. package/src/modules/library/components/DetailDialog.tsx +0 -566
  293. package/src/modules/library/components/GearIcon.tsx +0 -12
  294. package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
  295. package/src/modules/library/components/StatusGem.tsx +0 -21
  296. package/src/modules/library/components/SuggestChange.tsx +0 -171
  297. package/src/modules/library/components/particles.ts +0 -50
  298. package/src/modules/library/state/loadout.tsx +0 -129
  299. package/src/modules/library/utils/diff.ts +0 -102
  300. package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
  301. package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
  302. package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
  303. package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
  304. package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
  305. package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
  306. package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
  307. package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
  308. package/src/modules/pr/components/PrCancelButton.tsx +0 -99
  309. package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
  310. package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
  311. package/src/modules/pr/components/PrCommentThread.tsx +0 -168
  312. package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
  313. package/src/modules/pr/components/PrDiffPane.tsx +0 -425
  314. package/src/modules/pr/components/PrFileRow.tsx +0 -164
  315. package/src/modules/pr/components/PrFilesList.tsx +0 -53
  316. package/src/modules/pr/components/PrHeader.tsx +0 -45
  317. package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
  318. package/src/modules/pr/components/PrMergeButton.tsx +0 -268
  319. package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
  320. package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
  321. package/src/modules/pr/components/PrViewer.tsx +0 -364
  322. package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
  323. package/src/modules/pr/state/pr-viewer.context.ts +0 -34
  324. package/src/modules/pr/utils/bucketize-comments.ts +0 -55
  325. package/src/modules/pr/utils/parsePatch.ts +0 -57
  326. package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
@@ -0,0 +1,260 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
3
+ import type { ToolVarStatus } from '../../secrets-vault/services/tool-secrets.api';
4
+
5
+ /**
6
+ * The per-variable state matrix, one case per row of the spec table.
7
+ *
8
+ * Two rules are worth more than the rest and get their own cases: the
9
+ * `adminConfigured` overload (on an OAuth variable it describes the OWNER's
10
+ * setup, not a shared value) and the `oauth-auto` suppression (an
11
+ * auto-registered PKCE client has no secret, so offering to save one would
12
+ * clobber the discovered provider).
13
+ */
14
+
15
+ const secretsMock = vi.hoisted(() => ({
16
+ setAdminVar: vi.fn(),
17
+ setUserVar: vi.fn(),
18
+ deleteAdminVar: vi.fn(),
19
+ setOAuthClientSecret: vi.fn(),
20
+ }));
21
+ vi.mock('../../secrets-vault/services/tool-secrets.api', () => secretsMock);
22
+
23
+ const connectMock = vi.hoisted(() => ({ startToolOAuth: vi.fn() }));
24
+ vi.mock('../../secrets-vault/services/connect.api', () => connectMock);
25
+
26
+ // External navigation behind a spy-able module — never assign
27
+ // window.location.href in a test.
28
+ const navMock = vi.hoisted(() => ({ navigateExternal: vi.fn() }));
29
+ vi.mock('../utils/navigate-external', () => navMock);
30
+
31
+ import { ToolVarRow } from '../components/tool-page/ToolVarRow';
32
+
33
+ const RETURN_TO = '/skills-and-tools/tools/github';
34
+
35
+ function variable(over: Partial<ToolVarStatus>): ToolVarStatus {
36
+ return {
37
+ name: 'API_KEY',
38
+ scope: 'admin',
39
+ label: null,
40
+ key: 'github_API_KEY',
41
+ adminConfigured: false,
42
+ userConfigured: false,
43
+ ...over,
44
+ };
45
+ }
46
+
47
+ function renderRow(
48
+ v: ToolVarStatus,
49
+ opts: { canWrite?: boolean; setupKind?: 'open' | 'oauth-auto' | 'oauth-manual' | null } = {},
50
+ ) {
51
+ const onChanged = vi.fn();
52
+ const onError = vi.fn();
53
+ render(
54
+ <ToolVarRow
55
+ slug="github"
56
+ variable={v}
57
+ canWrite={opts.canWrite ?? false}
58
+ setupKind={opts.setupKind ?? null}
59
+ returnTo={RETURN_TO}
60
+ onChanged={onChanged}
61
+ onError={onError}
62
+ />,
63
+ );
64
+ return { onChanged, onError };
65
+ }
66
+
67
+ beforeEach(() => {
68
+ secretsMock.setAdminVar.mockReset().mockResolvedValue(undefined);
69
+ secretsMock.setUserVar.mockReset().mockResolvedValue(undefined);
70
+ secretsMock.deleteAdminVar.mockReset().mockResolvedValue(undefined);
71
+ secretsMock.setOAuthClientSecret.mockReset().mockResolvedValue(undefined);
72
+ connectMock.startToolOAuth.mockReset().mockResolvedValue('https://provider.example/authorize');
73
+ navMock.navigateExternal.mockReset();
74
+ });
75
+
76
+ describe('ToolVarRow: admin scope', () => {
77
+ it('shows the Set by an Admin chip and no controls to a non-writer', () => {
78
+ renderRow(variable({ adminConfigured: true }));
79
+ expect(screen.getByText('Set by an Admin')).toBeInTheDocument();
80
+ expect(screen.getByText('One value for the whole team. Already handled')).toBeInTheDocument();
81
+ expect(screen.queryByRole('button', { name: 'Replace' })).toBeNull();
82
+ expect(screen.queryByRole('button', { name: 'Remove' })).toBeNull();
83
+ });
84
+
85
+ it('offers Replace and Remove to a writer, and Remove deletes then reports', async () => {
86
+ const { onChanged } = renderRow(variable({ adminConfigured: true }), { canWrite: true });
87
+ expect(screen.getByRole('button', { name: 'Replace' })).toBeInTheDocument();
88
+
89
+ fireEvent.click(screen.getByRole('button', { name: 'Remove' }));
90
+ await waitFor(() => expect(secretsMock.deleteAdminVar).toHaveBeenCalledWith('github', 'API_KEY'));
91
+ await waitFor(() => expect(onChanged).toHaveBeenCalled());
92
+ });
93
+
94
+ it('shows the Not set chip to a non-writer when nothing is stored', () => {
95
+ renderRow(variable({}));
96
+ expect(screen.getByText('Not set')).toBeInTheDocument();
97
+ // The "— already handled" tail is dropped when unset: it would contradict
98
+ // the chip right next to it.
99
+ expect(screen.getByText('One value for the whole team')).toBeInTheDocument();
100
+ expect(screen.queryByRole('button', { name: 'Set key' })).toBeNull();
101
+ });
102
+
103
+ it('lets a writer set the key, with Save disabled until a value is typed', async () => {
104
+ const { onChanged } = renderRow(variable({}), { canWrite: true });
105
+ fireEvent.click(screen.getByRole('button', { name: 'Set key' }));
106
+
107
+ const input = screen.getByLabelText('Value for API_KEY');
108
+ expect(input).toHaveAttribute('type', 'password');
109
+ expect(screen.getByRole('button', { name: 'Save' })).toBeDisabled();
110
+
111
+ fireEvent.change(input, { target: { value: 'ghp_secret' } });
112
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
113
+
114
+ await waitFor(() =>
115
+ expect(secretsMock.setAdminVar).toHaveBeenCalledWith('github', 'API_KEY', 'ghp_secret'),
116
+ );
117
+ await waitFor(() => expect(onChanged).toHaveBeenCalled());
118
+ // Editor closes and the typed value goes with it.
119
+ await waitFor(() => expect(screen.queryByLabelText('Value for API_KEY')).toBeNull());
120
+ });
121
+
122
+ it('closes the editor on Cancel without saving', () => {
123
+ renderRow(variable({}), { canWrite: true });
124
+ fireEvent.click(screen.getByRole('button', { name: 'Set key' }));
125
+ fireEvent.change(screen.getByLabelText('Value for API_KEY'), { target: { value: 'x' } });
126
+ fireEvent.click(screen.getByRole('button', { name: 'Cancel' }));
127
+ expect(screen.queryByLabelText('Value for API_KEY')).toBeNull();
128
+ expect(secretsMock.setAdminVar).not.toHaveBeenCalled();
129
+ });
130
+ });
131
+
132
+ describe('ToolVarRow: user scope, typed value', () => {
133
+ it('shows Connected when the caller has their own value', () => {
134
+ renderRow(variable({ scope: 'user', userConfigured: true }));
135
+ expect(screen.getByText('Connected')).toBeInTheDocument();
136
+ expect(screen.getByText('Each person sets their own')).toBeInTheDocument();
137
+ });
138
+
139
+ it('offers Add key and saves it to the per-user tier', async () => {
140
+ const { onChanged } = renderRow(variable({ scope: 'user' }));
141
+ fireEvent.click(screen.getByRole('button', { name: 'Add key' }));
142
+ fireEvent.change(screen.getByLabelText('Value for API_KEY'), { target: { value: 'mine' } });
143
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
144
+
145
+ await waitFor(() =>
146
+ expect(secretsMock.setUserVar).toHaveBeenCalledWith('github', 'API_KEY', 'mine'),
147
+ );
148
+ await waitFor(() => expect(onChanged).toHaveBeenCalled());
149
+ });
150
+ });
151
+
152
+ describe('ToolVarRow: oauth', () => {
153
+ const signin = (over: Partial<ToolVarStatus> = {}) =>
154
+ variable({
155
+ name: 'SIGNIN',
156
+ scope: 'user',
157
+ label: 'GitHub sign-in',
158
+ oauth: true,
159
+ adminConfigured: true,
160
+ ...over,
161
+ });
162
+
163
+ it('shows Connected once authorized', () => {
164
+ renderRow(signin({ authorized: true }));
165
+ expect(screen.getByText('GitHub sign-in')).toBeInTheDocument();
166
+ expect(screen.getByText('Connected')).toBeInTheDocument();
167
+ });
168
+
169
+ it('asks for a fresh sign-in when the token is under-scoped', () => {
170
+ renderRow(signin({ authorized: true, needsReauth: true }));
171
+ expect(screen.getByRole('button', { name: 'Sign in again' })).toBeInTheDocument();
172
+ expect(screen.queryByText('Connected')).toBeNull();
173
+ });
174
+
175
+ it('starts the flow with a returnTo and sends the browser to the provider', async () => {
176
+ renderRow(signin({ authorized: false }));
177
+ fireEvent.click(screen.getByRole('button', { name: 'Sign in' }));
178
+
179
+ await waitFor(() =>
180
+ expect(connectMock.startToolOAuth).toHaveBeenCalledWith('github', 'SIGNIN', {
181
+ returnTo: RETURN_TO,
182
+ }),
183
+ );
184
+ await waitFor(() =>
185
+ expect(navMock.navigateExternal).toHaveBeenCalledWith('https://provider.example/authorize'),
186
+ );
187
+ });
188
+
189
+ it('tells a non-writer the owner has not finished the setup', () => {
190
+ renderRow(signin({ adminConfigured: false }));
191
+ expect(
192
+ screen.getByText("The tool owner hasn't finished the sign-in setup yet."),
193
+ ).toBeInTheDocument();
194
+ expect(screen.getByText('Not set')).toBeInTheDocument();
195
+ expect(screen.queryByRole('button', { name: 'Sign in' })).toBeNull();
196
+ });
197
+
198
+ it('lets a writer provide the client secret for a manual provider', async () => {
199
+ const { onChanged } = renderRow(signin({ adminConfigured: false }), {
200
+ canWrite: true,
201
+ setupKind: 'oauth-manual',
202
+ });
203
+ fireEvent.click(screen.getByRole('button', { name: 'Set client secret' }));
204
+
205
+ const input = screen.getByLabelText('Client secret for SIGNIN');
206
+ expect(input).toHaveAttribute('type', 'password');
207
+ fireEvent.change(input, { target: { value: 'cs_live' } });
208
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
209
+
210
+ await waitFor(() =>
211
+ expect(secretsMock.setOAuthClientSecret).toHaveBeenCalledWith('github', 'SIGNIN', 'cs_live'),
212
+ );
213
+ await waitFor(() => expect(onChanged).toHaveBeenCalled());
214
+ });
215
+
216
+ it('offers a writer Replace client secret alongside Connected', () => {
217
+ renderRow(signin({ authorized: true }), { canWrite: true, setupKind: 'oauth-manual' });
218
+ expect(screen.getByRole('button', { name: 'Replace client secret' })).toBeInTheDocument();
219
+ });
220
+
221
+ it('never shows a client-secret affordance for oauth-auto, even to a writer', () => {
222
+ renderRow(signin({ authorized: true }), { canWrite: true, setupKind: 'oauth-auto' });
223
+ expect(screen.queryByRole('button', { name: 'Replace client secret' })).toBeNull();
224
+
225
+ renderRow(signin({ adminConfigured: false }), { canWrite: true, setupKind: 'oauth-auto' });
226
+ expect(screen.queryByRole('button', { name: 'Set client secret' })).toBeNull();
227
+ expect(screen.getAllByText('Not set').length).toBeGreaterThan(0);
228
+ });
229
+ });
230
+
231
+ describe('ToolVarRow: failures', () => {
232
+ it('reports a rejected write through onError and leaves the editor open', async () => {
233
+ secretsMock.setAdminVar.mockRejectedValue(new Error('Forbidden'));
234
+ const { onError, onChanged } = renderRow(variable({}), { canWrite: true });
235
+
236
+ fireEvent.click(screen.getByRole('button', { name: 'Set key' }));
237
+ fireEvent.change(screen.getByLabelText('Value for API_KEY'), { target: { value: 'x' } });
238
+ fireEvent.click(screen.getByRole('button', { name: 'Save' }));
239
+
240
+ await waitFor(() => expect(onError).toHaveBeenCalledWith('Forbidden'));
241
+ expect(onChanged).not.toHaveBeenCalled();
242
+ expect(screen.getByLabelText('Value for API_KEY')).toBeInTheDocument();
243
+ });
244
+
245
+ it('reports a refused sign-in start and re-enables the button', async () => {
246
+ connectMock.startToolOAuth.mockRejectedValue(
247
+ new Error("This tool's owner hasn't finished setting this up"),
248
+ );
249
+ const { onError } = renderRow(
250
+ variable({ name: 'SIGNIN', scope: 'user', oauth: true, adminConfigured: true }),
251
+ );
252
+
253
+ fireEvent.click(screen.getByRole('button', { name: 'Sign in' }));
254
+ await waitFor(() =>
255
+ expect(onError).toHaveBeenCalledWith("This tool's owner hasn't finished setting this up"),
256
+ );
257
+ expect(navMock.navigateExternal).not.toHaveBeenCalled();
258
+ await waitFor(() => expect(screen.getByRole('button', { name: 'Sign in' })).toBeEnabled());
259
+ });
260
+ });
@@ -0,0 +1,197 @@
1
+ import { describe, it, expect, vi, beforeEach } from 'vitest';
2
+ import { render, screen, waitFor } from '@testing-library/react';
3
+ import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
4
+ import type { ReactNode } from 'react';
5
+ import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
6
+ import {
7
+ WorkspaceContext,
8
+ type WorkspaceContextValue,
9
+ } from '../../workspace/state/workspace.context';
10
+ import { AdminContext } from '../../admin/state/admin.context';
11
+ import type { LibraryData } from '../hooks/useLibraryData';
12
+
13
+ /**
14
+ * The canonical /workspace item URLs, rendered INSIDE the library surface:
15
+ * dispatch is by URL shape (`isLibraryLocation` — the shell's rule), page
16
+ * resolution by catalog, and the catalog answering "not yet" holds the slot
17
+ * instead of surrendering the surface. The item pages themselves are mocked
18
+ * to markers; their behaviour lives in their own test files.
19
+ */
20
+
21
+ const dataMock = vi.hoisted(() => ({ useLibraryData: vi.fn() }));
22
+ vi.mock('../hooks/useLibraryData', () => ({ useLibraryData: dataMock.useLibraryData }));
23
+
24
+ vi.mock('../services/groups.api', () => ({
25
+ listGroups: vi.fn().mockResolvedValue([]),
26
+ listJoinRequests: vi.fn().mockResolvedValue([]),
27
+ }));
28
+
29
+ vi.mock('../components/skill-page/SkillPage', () => ({
30
+ SkillPage: ({ name, activeFile }: { name?: string; activeFile?: string }) => (
31
+ <div aria-label="skill-page">{`${name}::${activeFile}`}</div>
32
+ ),
33
+ }));
34
+ vi.mock('../components/tool-page/ToolPage', () => ({
35
+ ToolPage: ({ slug }: { slug?: string }) => <div aria-label="tool-page">{slug}</div>,
36
+ }));
37
+
38
+ import { LibraryRoutes } from '../routes/LibraryRoutes';
39
+ import { isLibraryLocation } from '../routes/library-paths';
40
+ import { withAuth } from './auth-harness';
41
+
42
+ const CATALOG: LibraryData = {
43
+ loading: false,
44
+ error: null,
45
+ skills: [
46
+ { name: 'create-sales-deck', description: '', path: 'Groups/Sales/create-sales-deck' },
47
+ ],
48
+ pendingSkills: [],
49
+ tools: [
50
+ {
51
+ slug: 'notion',
52
+ name: 'notion',
53
+ path: 'Groups/Support/notion.tool',
54
+ type: 'mcp',
55
+ setup: null,
56
+ canWrite: false,
57
+ variables: [],
58
+ },
59
+ ],
60
+ ownedSkills: new Set<string>(),
61
+ allowedToolsBySkill: new Map(),
62
+ crs: [],
63
+ myCrNumbers: new Set<number>(),
64
+ reload: vi.fn(),
65
+ };
66
+
67
+ const KB = 'knowledge-base';
68
+
69
+ function wrap(children: ReactNode) {
70
+ const adminValue = {
71
+ isAdmin: false,
72
+ unreadCount: 0,
73
+ lastSeen: null,
74
+ markSeen: vi.fn(),
75
+ refresh: vi.fn(),
76
+ rolesConfigCorrupted: false,
77
+ rolesConfigErrors: [],
78
+ runRolesRecovery: vi.fn(),
79
+ };
80
+ const workspaceValue = {
81
+ workspaceId: 'ws',
82
+ kbDirName: KB,
83
+ } as unknown as WorkspaceContextValue;
84
+ return (
85
+ <AdminContext.Provider value={adminValue}>
86
+ <WorkspaceContext.Provider value={workspaceValue}>
87
+ {withAuth(children)}
88
+ </WorkspaceContext.Provider>
89
+ </AdminContext.Provider>
90
+ );
91
+ }
92
+
93
+ function LocationProbe() {
94
+ const location = useLocation();
95
+ return <div aria-label="pathname">{location.pathname}</div>;
96
+ }
97
+
98
+ function renderAt(url: string) {
99
+ // The same two mounts the shell's CoreSurfaces gives this surface.
100
+ return render(
101
+ <MemoryRouter initialEntries={[url]}>
102
+ {wrap(
103
+ <Routes>
104
+ <Route path="/skills-and-tools/*" element={<LibraryRoutes />} />
105
+ <Route path="/workspace/*" element={<LibraryRoutes />} />
106
+ </Routes>,
107
+ )}
108
+ <LocationProbe />
109
+ </MemoryRouter>,
110
+ );
111
+ }
112
+
113
+ const itemUrl = (repoRel: string, branch = DEFAULT_BRANCH) =>
114
+ `/workspace/${encodeURIComponent(branch)}/${KB}/${repoRel
115
+ .split('/')
116
+ .map(encodeURIComponent)
117
+ .join('/')}`;
118
+
119
+ beforeEach(() => {
120
+ dataMock.useLibraryData.mockReturnValue(CATALOG);
121
+ });
122
+
123
+ describe('WorkspaceItemRoute', () => {
124
+ it("a skill file's URL renders the skill page on that file's tab, inside the library nav", async () => {
125
+ renderAt(itemUrl('Groups/Sales/create-sales-deck/reference/LESSONS.md'));
126
+ expect(await screen.findByLabelText('skill-page')).toHaveTextContent(
127
+ 'create-sales-deck::reference/LESSONS.md',
128
+ );
129
+ // The ONE library sidebar is on screen with it — same surface, not a copy.
130
+ expect(screen.getByRole('button', { name: /^All groups/ })).toBeInTheDocument();
131
+ });
132
+
133
+ it('a bare skill-folder URL opens SKILL.md', async () => {
134
+ renderAt(itemUrl('Groups/Sales/create-sales-deck'));
135
+ expect(await screen.findByLabelText('skill-page')).toHaveTextContent(
136
+ 'create-sales-deck::SKILL.md',
137
+ );
138
+ });
139
+
140
+ it("a `.tool` manual's URL renders the tool page", async () => {
141
+ renderAt(itemUrl('Groups/Support/notion.tool'));
142
+ expect(await screen.findByLabelText('tool-page')).toHaveTextContent('notion');
143
+ });
144
+
145
+ it('resolves a skill from the URL alone — a just-created skill needs no catalog', async () => {
146
+ // The regression this exists for: right after "create empty skill" the
147
+ // catalog reload hasn't landed. Resolution is structural (the folder name
148
+ // IS the skill id), so the page opens instantly anyway.
149
+ dataMock.useLibraryData.mockReturnValue({ ...CATALOG, loading: true, skills: [], tools: [] });
150
+ renderAt(itemUrl('Groups/Sales/brand-new-skill/SKILL.md'));
151
+ expect(await screen.findByLabelText('skill-page')).toHaveTextContent(
152
+ 'brand-new-skill::SKILL.md',
153
+ );
154
+ // …inside the library surface, never the Knowledge view.
155
+ expect(screen.getByRole('button', { name: /^All groups/ })).toBeInTheDocument();
156
+ });
157
+
158
+ it("a `.tool` URL falls back to the filename slug when the catalog hasn't loaded", async () => {
159
+ dataMock.useLibraryData.mockReturnValue({ ...CATALOG, loading: true, skills: [], tools: [] });
160
+ renderAt(itemUrl('Groups/Support/notion.tool'));
161
+ expect(await screen.findByLabelText('tool-page')).toHaveTextContent('notion');
162
+ });
163
+
164
+ it("a Groups path that is no item lands on its group's page", async () => {
165
+ renderAt(itemUrl('Groups/Sales/access.md'));
166
+ await waitFor(() =>
167
+ expect(screen.getByLabelText('pathname')).toHaveTextContent('/skills-and-tools/groups/Sales'),
168
+ );
169
+ });
170
+
171
+ it('a non-default branch never renders an item page', async () => {
172
+ renderAt(itemUrl('Groups/Sales/create-sales-deck/SKILL.md', 'razvan/some-draft'));
173
+ await waitFor(() =>
174
+ expect(screen.getByLabelText('pathname')).toHaveTextContent(/^\/skills-and-tools$/),
175
+ );
176
+ });
177
+ });
178
+
179
+ describe('isLibraryLocation — the surface rule', () => {
180
+ it.each([
181
+ ['/skills-and-tools', true],
182
+ ['/skills-and-tools/groups/Sales', true],
183
+ [itemUrl('Groups/Sales/create-sales-deck/SKILL.md'), true],
184
+ [itemUrl('Groups/Support/notion.tool'), true],
185
+ // KnowledgeBase paths are the Knowledge app's, whatever the file.
186
+ [`/workspace/${DEFAULT_BRANCH}/${KB}/KnowledgeBase/Handbook/Tone of voice.md`, false],
187
+ // Drafts review raw, in Knowledge — the library speaks the default branch.
188
+ [itemUrl('Groups/Sales/create-sales-deck/SKILL.md', 'razvan/draft'), false],
189
+ // Too shallow to name an item (`Groups/` itself, a group folder alone).
190
+ [`/workspace/${DEFAULT_BRANCH}/${KB}/Groups`, false],
191
+ [`/workspace/${DEFAULT_BRANCH}/${KB}/Groups/Sales`, false],
192
+ ['/workspace', false],
193
+ ['/secrets', false],
194
+ ])('%s → %s', (pathname, expected) => {
195
+ expect(isLibraryLocation(pathname)).toBe(expected);
196
+ });
197
+ });
@@ -0,0 +1,37 @@
1
+ import { vi } from 'vitest';
2
+ import type { ReactNode } from 'react';
3
+ import { AuthContext, type AuthContextValue } from '../../auth/state/auth.context';
4
+
5
+ /**
6
+ * The signed-in user, for tests that render a Library surface.
7
+ *
8
+ * The Library names a person's own space after them ("Juan's Group"), so the
9
+ * sidebar and the all-groups index now read `useAuth`. In production that is
10
+ * free — nothing under `CoreAppShell` renders before a user exists — but a
11
+ * test that mounts a page in isolation has no provider above it, and `useAuth`
12
+ * throws rather than returning null.
13
+ *
14
+ * One harness rather than a provider pasted into each suite: the display name
15
+ * is asserted in several files, and it should be one fact in one place.
16
+ */
17
+
18
+ /** The name every Library suite expects to see reflected back. */
19
+ export const TEST_USER_NAME = 'Juan Viera';
20
+
21
+ /** What `personalGroupName(TEST_USER_NAME)` produces — assert against this. */
22
+ export const TEST_PERSONAL_GROUP = "Juan's Group";
23
+
24
+ export function authValue(over: Partial<AuthContextValue> = {}): AuthContextValue {
25
+ return {
26
+ user: { id: 'u1', email: 'juan@bevel.software', name: TEST_USER_NAME },
27
+ token: 'test-token',
28
+ isLoading: false,
29
+ login: vi.fn(),
30
+ logout: vi.fn(),
31
+ ...over,
32
+ };
33
+ }
34
+
35
+ export function withAuth(children: ReactNode, over?: Partial<AuthContextValue>) {
36
+ return <AuthContext.Provider value={authValue(over)}>{children}</AuthContext.Provider>;
37
+ }
@@ -0,0 +1,48 @@
1
+ import { describe, it, expect, beforeEach } from 'vitest';
2
+ import { readOAuthFragment } from '../utils/oauth-fragment';
3
+
4
+ /**
5
+ * The fragment contract the backend callback speaks. The double-decode case is
6
+ * the one that matters: `URLSearchParams` already percent-decodes, so a second
7
+ * pass corrupts any provider message containing a literal `%`.
8
+ */
9
+ describe('readOAuthFragment', () => {
10
+ beforeEach(() => {
11
+ window.history.replaceState(null, '', '/skills-and-tools/tools/github');
12
+ });
13
+
14
+ function at(hash: string) {
15
+ window.history.replaceState(null, '', `/skills-and-tools/tools/github${hash}`);
16
+ return readOAuthFragment();
17
+ }
18
+
19
+ it('returns null when there is no fragment', () => {
20
+ expect(readOAuthFragment()).toBeNull();
21
+ });
22
+
23
+ it('reads a bare #authorized', () => {
24
+ expect(at('#authorized')).toEqual({ kind: 'authorized' });
25
+ });
26
+
27
+ it('reads #authorized=<id> the callback appends', () => {
28
+ expect(at('#authorized=sec_123')).toEqual({ kind: 'authorized' });
29
+ });
30
+
31
+ it('decodes an #error message exactly once', () => {
32
+ expect(at('#error=Something%20bad')).toEqual({ kind: 'error', message: 'Something bad' });
33
+ });
34
+
35
+ it('leaves a literal percent in an error message alone', () => {
36
+ // `%25` decodes to `%`. A second decodeURIComponent would then throw or
37
+ // mangle it — this is the regression the single-decode rule exists for.
38
+ expect(at('#error=100%25%20failed')).toEqual({ kind: 'error', message: '100% failed' });
39
+ });
40
+
41
+ it('falls back to a message when #error carries none', () => {
42
+ expect(at('#error=')).toEqual({ kind: 'error', message: 'Authorization failed.' });
43
+ });
44
+
45
+ it('ignores a fragment that carries neither key', () => {
46
+ expect(at('#section=connection')).toBeNull();
47
+ });
48
+ });