@bevel-software/platform-core-frontend 0.4.0 → 0.5.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +5 -3
- package/src/core/CoreAppShell.tsx +195 -56
- package/src/core/__tests__/AppChrome.test.tsx +125 -0
- package/src/core/__tests__/ShellRoutes.test.tsx +130 -95
- package/src/core/__tests__/bootstrap.test.ts +63 -0
- package/src/core/bootstrap.ts +73 -0
- package/src/core/events.ts +12 -0
- package/src/core/registry.ts +58 -9
- package/src/index.css +100 -11
- package/src/index.ts +24 -23
- package/src/lib/utils.ts +114 -138
- package/src/modules/access/__tests__/ManageAccessDialog.placement.test.tsx +281 -0
- package/src/modules/access/__tests__/ManageAccessDialog.test.tsx +166 -1
- package/src/modules/access/api.ts +49 -0
- package/src/modules/access/components/ManageAccessDialog.tsx +786 -481
- package/src/modules/access/hooks/useFileAccess.ts +1 -1
- package/src/modules/admin/__tests__/AdminRolesPage.suggest.test.tsx +86 -0
- package/src/modules/admin/__tests__/UserAccountsPage.test.tsx +172 -156
- package/src/modules/admin/__tests__/admin.unread.test.tsx +61 -0
- package/src/modules/admin/components/AdminRolesPage.tsx +44 -38
- package/src/modules/admin/components/RolesCorruptedBanner.tsx +11 -10
- package/src/modules/admin/components/UserAccountsPage.tsx +361 -353
- package/src/modules/admin/state/admin.context.tsx +15 -6
- package/src/modules/auth/components/AccountPage.tsx +11 -11
- package/src/modules/auth/components/LoginScreen.tsx +12 -12
- package/src/modules/auth/services/sso.ts +47 -1
- package/src/modules/change-requests/__tests__/ChangeRequestDialog.test.tsx +277 -0
- package/src/modules/change-requests/__tests__/author.test.ts +48 -0
- package/src/modules/change-requests/__tests__/conflict.test.ts +73 -0
- package/src/modules/change-requests/__tests__/diff.test.ts +134 -0
- package/src/modules/change-requests/__tests__/propose.test.ts +93 -0
- package/src/modules/change-requests/__tests__/useFileOnBranch.test.tsx +72 -0
- package/src/modules/change-requests/change-requests.css +22 -0
- package/src/modules/change-requests/components/ChangeBox.tsx +277 -0
- package/src/modules/change-requests/components/ChangeRequestDialog.tsx +713 -0
- package/src/modules/change-requests/components/ConflictHelp.tsx +47 -0
- package/src/modules/change-requests/components/CrFileTree.tsx +398 -0
- package/src/modules/change-requests/components/FileChangeBoxes.tsx +168 -0
- package/src/modules/change-requests/hooks/useApplyChangeRequest.ts +236 -0
- package/src/modules/change-requests/hooks/useCrFileDiffs.ts +79 -0
- package/src/modules/change-requests/hooks/useFileOnBranch.ts +80 -0
- package/src/modules/change-requests/services/change-requests.api.ts +45 -0
- package/src/modules/change-requests/services/propose.api.ts +162 -0
- package/src/modules/change-requests/utils/author.ts +47 -0
- package/src/modules/change-requests/utils/conflict.ts +38 -0
- package/src/modules/change-requests/utils/diff.ts +80 -0
- package/src/modules/git/__tests__/BranchSwitcher.test.tsx +27 -18
- package/src/modules/git/__tests__/FileHistoryPanel.test.tsx +36 -83
- package/src/modules/git/__tests__/PullNeededBanner.test.tsx +5 -5
- package/src/modules/git/__tests__/PullRequestsForMe.test.tsx +147 -0
- package/src/modules/git/__tests__/useAutoPullUpdates.test.tsx +2 -8
- package/src/modules/git/components/BranchSwitcher.tsx +68 -31
- package/src/modules/git/components/DiffView.tsx +4 -4
- package/src/modules/git/components/FileComparisonPanel.tsx +20 -20
- package/src/modules/git/components/FileHistoryPanel.tsx +71 -107
- package/src/modules/git/components/PullNeededBanner.tsx +6 -13
- package/src/modules/git/components/PullRequestsForMe.tsx +71 -36
- package/src/modules/git/components/UnifiedDiffView.tsx +4 -4
- package/src/modules/git/hooks/__tests__/useGitState.deleteBranch.test.tsx +2 -2
- package/src/modules/git/hooks/useGitState.ts +15 -14
- package/src/modules/git/services/__tests__/error-messages.test.ts +4 -4
- package/src/modules/git/services/error-messages.ts +7 -7
- package/src/modules/git/services/git.api.ts +17 -11
- package/src/modules/git/services/pr-prompts.ts +2 -2
- package/src/modules/git/state/git.context.ts +10 -1
- package/src/modules/layout/__tests__/SidebarFrameResponsive.test.tsx +224 -0
- package/src/modules/layout/__tests__/SidebarToggle.test.tsx +242 -0
- package/src/modules/layout/__tests__/breakpoints.test.ts +56 -0
- package/src/modules/layout/breakpoints.ts +6 -0
- package/src/modules/layout/components/AppLayout.tsx +17 -5
- package/src/modules/layout/components/DemoBanner.tsx +10 -1
- package/src/modules/layout/components/MaintenanceOverlay.tsx +104 -104
- package/src/modules/layout/components/MobileChatLayout.tsx +31 -26
- package/src/modules/layout/components/ResizableThreePaneLayout.tsx +59 -24
- package/src/modules/layout/components/SidebarFrame.tsx +317 -0
- package/src/modules/layout/components/SidebarToggle.tsx +86 -0
- package/src/modules/layout/components/SlideOverlay.tsx +1 -1
- package/src/modules/layout/components/__tests__/MobileChatLayout.test.tsx +40 -2
- package/src/modules/layout/components/__tests__/ResizableThreePaneLayout.test.tsx +19 -3
- package/src/modules/layout/state/sidebar.ts +200 -0
- package/src/modules/library/__tests__/AddToGroupDialog.test.tsx +313 -0
- package/src/modules/library/__tests__/ChangeRequestDock.test.tsx +84 -0
- package/src/modules/library/__tests__/GroupJoinRequests.test.tsx +178 -0
- package/src/modules/library/__tests__/GroupPage.test.tsx +479 -0
- package/src/modules/library/__tests__/GroupsIndexPage.test.tsx +283 -0
- package/src/modules/library/__tests__/GroupsSidebar.contextmenu.test.tsx +175 -0
- package/src/modules/library/__tests__/GroupsSidebar.locked.test.tsx +96 -0
- package/src/modules/library/__tests__/GroupsSidebar.test.tsx +142 -0
- package/src/modules/library/__tests__/GroupsSidebarMenu.test.tsx +142 -0
- package/src/modules/library/__tests__/LibraryCard.test.tsx +149 -0
- package/src/modules/library/__tests__/LibraryRoutes.test.tsx +378 -0
- package/src/modules/library/__tests__/LibrarySidebarMenu.test.tsx +347 -0
- package/src/modules/library/__tests__/LockedGroupView.test.tsx +203 -0
- package/src/modules/library/__tests__/NewGroupDialog.test.tsx +114 -0
- package/src/modules/library/__tests__/PersonalAddDialog.test.tsx +177 -0
- package/src/modules/library/__tests__/SkillPage.test.tsx +1063 -0
- package/src/modules/library/__tests__/ToolConnectionSection.test.tsx +259 -0
- package/src/modules/library/__tests__/ToolLogo.test.tsx +63 -0
- package/src/modules/library/__tests__/ToolPage.test.tsx +315 -0
- package/src/modules/library/__tests__/ToolSharePanel.test.tsx +36 -0
- package/src/modules/library/__tests__/ToolVarRow.test.tsx +260 -0
- package/src/modules/library/__tests__/WorkspaceItemRoute.test.tsx +197 -0
- package/src/modules/library/__tests__/auth-harness.tsx +37 -0
- package/src/modules/library/__tests__/oauth-fragment.test.ts +48 -0
- package/src/modules/library/__tests__/status.test.ts +210 -117
- package/src/modules/library/__tests__/useSkillDetail.test.tsx +102 -0
- package/src/modules/library/__tests__/useToolPage.test.tsx +146 -0
- package/src/modules/library/components/AccessRequestsBanner.tsx +101 -0
- package/src/modules/library/components/AddToGroupDialog.tsx +115 -0
- package/src/modules/library/components/ChangeRequestDock.tsx +71 -47
- package/src/modules/library/components/DeleteGroupDialog.tsx +87 -0
- package/src/modules/library/components/GroupIndexRow.tsx +63 -0
- package/src/modules/library/components/GroupJoinRequests.tsx +56 -0
- package/src/modules/library/components/GroupPage.tsx +373 -0
- package/src/modules/library/components/GroupsIndexPage.tsx +222 -0
- package/src/modules/library/components/GroupsSidebar.tsx +338 -0
- package/src/modules/library/components/GroupsSidebarMenu.tsx +160 -0
- package/src/modules/library/components/LibraryCard.tsx +153 -132
- package/src/modules/library/components/LibraryLayout.tsx +344 -0
- package/src/modules/library/components/LibraryPage.tsx +138 -254
- package/src/modules/library/components/LockGlyph.tsx +31 -0
- package/src/modules/library/components/LockedGroupView.tsx +159 -0
- package/src/modules/library/components/ManagedGroupRequests.tsx +70 -0
- package/src/modules/library/components/NewGroupDialog.tsx +112 -0
- package/src/modules/library/components/NewSkillPanel.tsx +151 -0
- package/src/modules/library/components/PageActions.tsx +156 -0
- package/src/modules/library/components/PendingSkillReview.tsx +63 -0
- package/src/modules/library/components/PersonalAddDialog.tsx +88 -0
- package/src/modules/library/components/PersonalGroupPage.tsx +125 -0
- package/src/modules/library/components/StatusDot.tsx +25 -0
- package/src/modules/library/components/ToolLogo.tsx +171 -0
- package/src/modules/library/components/group-page-parts.tsx +419 -0
- package/src/modules/library/components/skill-page/SkillFileEditor.tsx +134 -0
- package/src/modules/library/components/skill-page/SkillFilePane.tsx +117 -0
- package/src/modules/library/components/skill-page/SkillFileTabs.tsx +112 -0
- package/src/modules/library/components/skill-page/SkillPage.tsx +673 -0
- package/src/modules/library/components/skill-page/tab-ids.ts +33 -0
- package/src/modules/library/components/tool-page/ToolConnectionSection.tsx +175 -0
- package/src/modules/library/components/tool-page/ToolPage.tsx +228 -0
- package/src/modules/library/components/tool-page/ToolSharePanel.tsx +45 -0
- package/src/modules/library/components/tool-page/ToolVarRow.tsx +289 -0
- package/src/modules/library/hooks/useJoinRequests.ts +114 -0
- package/src/modules/library/hooks/useLibraryData.ts +134 -119
- package/src/modules/library/hooks/useSkillDetail.ts +119 -74
- package/src/modules/library/hooks/useToolPage.ts +145 -0
- package/src/modules/library/library.css +108 -320
- package/src/modules/library/routes/LibraryRoutes.tsx +134 -0
- package/src/modules/library/routes/WorkspaceItemRoute.tsx +74 -0
- package/src/modules/library/routes/library-paths.ts +191 -0
- package/src/modules/library/services/groups.api.ts +189 -0
- package/src/modules/library/services/library.api.ts +291 -164
- package/src/modules/library/services/tools.api.ts +60 -0
- package/src/modules/library/state/library-context.ts +22 -0
- package/src/modules/library/state/library-data.tsx +223 -0
- package/src/modules/library/state/toast.context.ts +32 -0
- package/src/modules/library/state/toast.tsx +84 -42
- package/src/modules/library/utils/clipboard.ts +33 -0
- package/src/modules/library/utils/group-summary.ts +68 -0
- package/src/modules/library/utils/names.ts +30 -0
- package/src/modules/library/utils/navigate-external.ts +15 -0
- package/src/modules/library/utils/oauth-fragment.ts +32 -0
- package/src/modules/library/utils/personal-group.ts +36 -0
- package/src/modules/library/utils/status.ts +199 -116
- package/src/modules/library/utils/toast-duration.ts +16 -0
- package/src/modules/onboarding/__tests__/onboarding.test.tsx +533 -0
- package/src/modules/onboarding/agent-clients.ts +48 -0
- package/src/modules/onboarding/components/ConnectAgentPill.tsx +133 -0
- package/src/modules/onboarding/components/RootLanding.tsx +54 -0
- package/src/modules/onboarding/components/WelcomePage.tsx +364 -0
- package/src/modules/onboarding/paths.ts +9 -0
- package/src/modules/onboarding/state/onboarding.ts +191 -0
- package/src/modules/pr/components/OpenChangeRequestDialog.tsx +10 -10
- package/src/modules/pr/services/pr-approvals.api.ts +19 -0
- package/src/modules/pr/services/pr-cancel.api.ts +11 -0
- package/src/modules/review/components/BinaryChangePlaceholder.tsx +3 -3
- package/src/modules/review/components/DiffViewer.tsx +4 -4
- package/src/modules/review/components/MarkdownDiffViewer.tsx +84 -26
- package/src/modules/review/components/ReviewFileRow.tsx +10 -10
- package/src/modules/review/components/ReviewPanel.tsx +49 -17
- package/src/modules/review/components/ReviewPanelSurface.tsx +1 -1
- package/src/modules/review/components/__tests__/MarkdownDiffViewer.test.tsx +122 -0
- package/src/modules/review/hooks/__tests__/useReviewState.test.ts +1 -1
- package/src/modules/secrets-vault/components/ConnectToolsPage.tsx +273 -171
- package/src/modules/secrets-vault/components/SecretsPage.tsx +313 -276
- package/src/modules/secrets-vault/components/ToolSecretsPanel.tsx +109 -92
- package/src/modules/secrets-vault/components/__tests__/SecretsPage.test.tsx +82 -51
- package/src/modules/secrets-vault/services/connect.api.ts +24 -3
- package/src/modules/settings/components/DeploymentPage.tsx +90 -0
- package/src/modules/settings/components/SettingsLayout.tsx +135 -0
- package/src/modules/settings/components/SettingsNav.tsx +114 -0
- package/src/modules/settings/components/__tests__/DeploymentPage.test.tsx +110 -0
- package/src/modules/settings/components/__tests__/SettingsLayout.test.tsx +249 -0
- package/src/modules/settings/settings-nav-items.tsx +166 -0
- package/src/modules/setup/__tests__/setup.test.tsx +540 -0
- package/src/modules/setup/components/SetupGate.tsx +67 -0
- package/src/modules/setup/components/SetupScreen.tsx +573 -0
- package/src/modules/setup/services/setup.api.ts +106 -0
- package/src/modules/setup/utils/git-host.ts +34 -0
- package/src/modules/toolbar/components/AppSwitcher.tsx +131 -108
- package/src/modules/toolbar/components/ExternalAgentAccessPage.tsx +548 -548
- package/src/modules/toolbar/components/ProfileMenu.tsx +294 -0
- package/src/modules/toolbar/components/Toolbar.tsx +56 -54
- package/src/modules/toolbar/components/__tests__/AppSwitcher.test.tsx +176 -122
- package/src/modules/toolbar/components/__tests__/Toolbar.test.tsx +252 -77
- package/src/modules/tools/ToolsExplorerPage.tsx +45 -40
- package/src/modules/workspace/__tests__/design-system-parity.test.ts +133 -0
- package/src/modules/workspace/__tests__/testFixtures.ts +2 -0
- package/src/modules/workspace/components/EditorTabs.tsx +82 -50
- package/src/modules/workspace/components/FileExplorer.tsx +1292 -1068
- package/src/modules/workspace/components/FilePaneCard.tsx +53 -0
- package/src/modules/workspace/components/FileRoute.tsx +89 -84
- package/src/modules/workspace/components/FileViewer.tsx +1312 -906
- package/src/modules/workspace/components/KbDocumentShell.tsx +138 -0
- package/src/modules/workspace/components/KbFileRail.tsx +128 -0
- package/src/modules/workspace/components/KbPageHeader.tsx +390 -0
- package/src/modules/workspace/components/__tests__/EditorTabs.test.tsx +87 -3
- package/src/modules/workspace/components/__tests__/FileExplorer.test.tsx +293 -39
- package/src/modules/workspace/components/__tests__/FileRoute.test.tsx +1 -16
- package/src/modules/workspace/components/__tests__/FileViewer.test.tsx +462 -44
- package/src/modules/workspace/components/__tests__/KbDocumentShell.test.tsx +84 -0
- package/src/modules/workspace/components/__tests__/KbFileRail.test.tsx +83 -0
- package/src/modules/workspace/components/__tests__/KbPageHeader.test.tsx +192 -0
- package/src/modules/workspace/components/renderers/CopyAnchorButton.tsx +64 -0
- package/src/modules/workspace/components/renderers/CsvRenderer.tsx +8 -8
- package/src/modules/workspace/components/renderers/DocxRenderer.tsx +18 -9
- package/src/modules/workspace/components/renderers/HtmlRenderer.tsx +14 -14
- package/src/modules/workspace/components/renderers/ImageRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/KbMarkdownView.tsx +31 -165
- package/src/modules/workspace/components/renderers/MarkdownRenderer.tsx +18 -5
- package/src/modules/workspace/components/renderers/MermaidDiagram.tsx +27 -10
- package/src/modules/workspace/components/renderers/PdfRenderer.tsx +2 -2
- package/src/modules/workspace/components/renderers/TextRenderer.tsx +11 -5
- package/src/modules/workspace/components/renderers/ToolForm.tsx +24 -24
- package/src/modules/workspace/components/renderers/ToolRenderer.tsx +27 -27
- package/src/modules/workspace/components/renderers/XlsxRenderer.tsx +11 -11
- package/src/modules/workspace/components/renderers/__tests__/DocxRenderer.test.tsx +66 -0
- package/src/modules/workspace/components/renderers/__tests__/KbMarkdownView.test.tsx +17 -1
- package/src/modules/workspace/components/renderers/__tests__/MarkdownRenderer.test.tsx +1 -1
- package/src/modules/workspace/components/renderers/__tests__/MermaidDiagram.test.tsx +58 -0
- package/src/modules/workspace/components/renderers/__tests__/lazyRenderer.test.tsx +68 -0
- package/src/modules/workspace/components/renderers/__tests__/rendererLayout.test.ts +64 -0
- package/src/modules/workspace/components/renderers/__tests__/sanitizeDocxHtml.test.ts +0 -0
- package/src/modules/workspace/components/renderers/chunk-boundary.tsx +71 -0
- package/src/modules/workspace/components/renderers/index.ts +78 -2
- package/src/modules/workspace/components/renderers/kbMarkdownPipeline.tsx +241 -0
- package/src/modules/workspace/components/renderers/lazyRenderer.tsx +59 -0
- package/src/modules/workspace/components/renderers/sanitizeDocxHtml.ts +91 -0
- package/src/modules/workspace/hooks/__tests__/useLinksOut.test.ts +59 -0
- package/src/modules/workspace/hooks/__tests__/useOpenChangeRequests.test.tsx +237 -0
- package/src/modules/workspace/hooks/__tests__/useWorkspaceState.test.tsx +185 -0
- package/src/modules/workspace/hooks/useAutoGrowTextarea.ts +30 -0
- package/src/modules/workspace/hooks/useLastCommit.ts +66 -0
- package/src/modules/workspace/hooks/useLinksOut.ts +56 -0
- package/src/modules/workspace/hooks/useOpenChangeRequests.ts +20 -0
- package/src/modules/workspace/hooks/useWorkspaceState.ts +123 -14
- package/src/modules/workspace/routing/__tests__/kb-routes.test.tsx +1 -1
- package/src/modules/workspace/services/workspace.api.ts +9 -2
- package/src/modules/workspace/state/open-change-requests.context.ts +35 -0
- package/src/modules/workspace/state/open-change-requests.tsx +185 -0
- package/src/modules/workspace/state/workspace.context.ts +9 -0
- package/src/modules/workspace/utils/__tests__/diff.test.ts +87 -0
- package/src/modules/workspace/utils/diff.ts +130 -53
- package/src/modules/workspace/utils/fileTree.ts +182 -179
- package/src/modules/workspace/workspace.css +28 -0
- package/src/shared/components/Badge.tsx +62 -0
- package/src/shared/components/Banner.tsx +58 -0
- package/src/shared/components/Button.tsx +90 -0
- package/src/shared/components/Dialog.tsx +6 -6
- package/src/shared/components/Field.tsx +45 -0
- package/src/shared/components/IconButton.tsx +74 -0
- package/src/shared/components/ListRow.tsx +96 -0
- package/src/shared/components/Menu.tsx +88 -0
- package/src/shared/components/PageShell.tsx +54 -51
- package/src/shared/components/Surface.tsx +86 -0
- package/src/shared/components/__tests__/primitives.test.tsx +333 -0
- package/src/shared/components/index.ts +48 -0
- package/src/shared/components/useDismissableMenu.ts +71 -0
- package/src/shared/theme/__tests__/accent-contrast.test.ts +84 -0
- package/src/shared/theme/index.css +12 -0
- package/src/shared/theme/measure.ts +64 -0
- package/src/shared/theme/shadows.css +34 -0
- package/src/shared/theme/tokens.css +193 -0
- package/src/test-setup.ts +9 -0
- package/src/modules/access/components/AccessRestrictedBanner.tsx +0 -31
- package/src/modules/access/components/NodeOwnersBanner.tsx +0 -30
- package/src/modules/git/__tests__/ProtectedBranchBanner.test.tsx +0 -82
- package/src/modules/git/components/ProtectedBranchBanner.tsx +0 -42
- package/src/modules/library/__tests__/DetailDialog.test.tsx +0 -200
- package/src/modules/library/__tests__/diff.test.ts +0 -62
- package/src/modules/library/__tests__/loadout.test.tsx +0 -72
- package/src/modules/library/components/CompareView.tsx +0 -357
- package/src/modules/library/components/DetailDialog.tsx +0 -566
- package/src/modules/library/components/GearIcon.tsx +0 -12
- package/src/modules/library/components/LoadoutSidebar.tsx +0 -156
- package/src/modules/library/components/StatusGem.tsx +0 -21
- package/src/modules/library/components/SuggestChange.tsx +0 -171
- package/src/modules/library/components/particles.ts +0 -50
- package/src/modules/library/state/loadout.tsx +0 -129
- package/src/modules/library/utils/diff.ts +0 -102
- package/src/modules/pr/__tests__/PrApprovalBadge.test.tsx +0 -93
- package/src/modules/pr/__tests__/PrCancelButton.test.tsx +0 -158
- package/src/modules/pr/__tests__/PrCancelConfirmDialog.test.tsx +0 -44
- package/src/modules/pr/__tests__/PrMergeButton.test.tsx +0 -360
- package/src/modules/pr/__tests__/bucketize-comments.test.ts +0 -85
- package/src/modules/pr/__tests__/parsePatch.test.ts +0 -104
- package/src/modules/pr/__tests__/usePrViewerState.test.ts +0 -72
- package/src/modules/pr/components/PrApprovalBadge.tsx +0 -80
- package/src/modules/pr/components/PrCancelButton.tsx +0 -99
- package/src/modules/pr/components/PrCancelConfirmDialog.tsx +0 -119
- package/src/modules/pr/components/PrCommentComposer.tsx +0 -92
- package/src/modules/pr/components/PrCommentThread.tsx +0 -168
- package/src/modules/pr/components/PrCommentsPanel.tsx +0 -143
- package/src/modules/pr/components/PrDiffPane.tsx +0 -425
- package/src/modules/pr/components/PrFileRow.tsx +0 -164
- package/src/modules/pr/components/PrFilesList.tsx +0 -53
- package/src/modules/pr/components/PrHeader.tsx +0 -45
- package/src/modules/pr/components/PrHeaderOverflowMenu.tsx +0 -58
- package/src/modules/pr/components/PrMergeButton.tsx +0 -268
- package/src/modules/pr/components/PrMergeConfirmDialog.tsx +0 -112
- package/src/modules/pr/components/PrRefreshFromTargetButton.tsx +0 -110
- package/src/modules/pr/components/PrViewer.tsx +0 -364
- package/src/modules/pr/hooks/usePrViewerState.ts +0 -150
- package/src/modules/pr/state/pr-viewer.context.ts +0 -34
- package/src/modules/pr/utils/bucketize-comments.ts +0 -55
- package/src/modules/pr/utils/parsePatch.ts +0 -57
- package/src/modules/toolbar/components/AdminMenu.tsx +0 -271
|
@@ -0,0 +1,200 @@
|
|
|
1
|
+
import { useSyncExternalStore } from 'react';
|
|
2
|
+
|
|
3
|
+
/**
|
|
4
|
+
* The app's ONE sidebar: how wide it is, and whether it is showing.
|
|
5
|
+
*
|
|
6
|
+
* Knowledge and Skills & Tools do not have a sidebar each. The prototype makes
|
|
7
|
+
* that literal — a single `<aside class="side">` (proto:1530) that two
|
|
8
|
+
* renderers fill (proto:2961, proto:3584) — and this store is the platform's
|
|
9
|
+
* version of the same claim. Drag it wider in Knowledge and it is wider in
|
|
10
|
+
* Skills, because it is the same nav in the same place holding a different
|
|
11
|
+
* list. Two independent widths would make switching apps move furniture.
|
|
12
|
+
*
|
|
13
|
+
* It lives in `layout` rather than beside either surface for the same reason
|
|
14
|
+
* `shared/theme/measure.ts` does: the measure belongs to neither.
|
|
15
|
+
*
|
|
16
|
+
* WIDTH persists, COLLAPSED does not, and the split is deliberate. A width is
|
|
17
|
+
* a preference — you set it once because your folder names are long, and
|
|
18
|
+
* having to redo that every morning would be the app forgetting something you
|
|
19
|
+
* told it. Hiding the nav is a "give me the page for a minute" gesture, so a
|
|
20
|
+
* reload brings it back rather than stranding you on a navless app hunting for
|
|
21
|
+
* the button that returns it.
|
|
22
|
+
*/
|
|
23
|
+
|
|
24
|
+
/** proto:4328-4329 — 212px default, and the range the drag is clamped to. */
|
|
25
|
+
export const SIDEBAR_DEFAULT_WIDTH = 212;
|
|
26
|
+
export const SIDEBAR_MIN_WIDTH = 180;
|
|
27
|
+
export const SIDEBAR_MAX_WIDTH = 460;
|
|
28
|
+
|
|
29
|
+
const WIDTH_STORAGE_KEY = 'bevel.sidebarWidth';
|
|
30
|
+
|
|
31
|
+
/**
|
|
32
|
+
* Hold a width inside the range above, rounded to a whole pixel. Every way a
|
|
33
|
+
* width can arrive — a drag, a stored value, a caller — goes through here, so
|
|
34
|
+
* there is no path by which the nav ends up too narrow to read or wide enough
|
|
35
|
+
* to crowd out the page.
|
|
36
|
+
*/
|
|
37
|
+
export const clampSidebarWidth = (w: number): number =>
|
|
38
|
+
Math.max(SIDEBAR_MIN_WIDTH, Math.min(SIDEBAR_MAX_WIDTH, Math.round(w)));
|
|
39
|
+
|
|
40
|
+
/**
|
|
41
|
+
* Storage is best-effort throughout: Safari's private mode throws on
|
|
42
|
+
* `localStorage` access, and a sidebar that cannot remember its width is a far
|
|
43
|
+
* better outcome than an app that will not boot.
|
|
44
|
+
*/
|
|
45
|
+
function readStoredWidth(): number {
|
|
46
|
+
try {
|
|
47
|
+
const raw = window.localStorage.getItem(WIDTH_STORAGE_KEY);
|
|
48
|
+
if (!raw) return SIDEBAR_DEFAULT_WIDTH;
|
|
49
|
+
const parsed = Number.parseInt(raw, 10);
|
|
50
|
+
// Clamped rather than trusted: the bounds may have changed since it was
|
|
51
|
+
// written, and a hand-edited value should not be able to hide the nav.
|
|
52
|
+
return Number.isFinite(parsed) ? clampSidebarWidth(parsed) : SIDEBAR_DEFAULT_WIDTH;
|
|
53
|
+
} catch {
|
|
54
|
+
return SIDEBAR_DEFAULT_WIDTH;
|
|
55
|
+
}
|
|
56
|
+
}
|
|
57
|
+
|
|
58
|
+
let collapsed = false;
|
|
59
|
+
let instant = false;
|
|
60
|
+
let narrow = false;
|
|
61
|
+
let width = typeof window === 'undefined' ? SIDEBAR_DEFAULT_WIDTH : readStoredWidth();
|
|
62
|
+
// One frozen object per state, so `useSyncExternalStore` can compare by
|
|
63
|
+
// identity. Returning a fresh `{ collapsed, width }` from the snapshot would
|
|
64
|
+
// re-render every subscriber on every unrelated store read, and React would
|
|
65
|
+
// (rightly) warn about an unstable snapshot.
|
|
66
|
+
let snapshot: SidebarState = { collapsed, width, instant, narrow };
|
|
67
|
+
|
|
68
|
+
export interface SidebarState {
|
|
69
|
+
collapsed: boolean;
|
|
70
|
+
width: number;
|
|
71
|
+
/**
|
|
72
|
+
* Whether the CURRENT collapsed value arrived without a gesture, and so must
|
|
73
|
+
* not be performed. Toggling the nav is something you did and deserves the
|
|
74
|
+
* 240ms; the welcome page hiding it for the length of a greeting is not, and
|
|
75
|
+
* animating that reads as the nav flinching on the way in and opening by
|
|
76
|
+
* itself on the way out.
|
|
77
|
+
*/
|
|
78
|
+
instant: boolean;
|
|
79
|
+
/**
|
|
80
|
+
* Whether the nav is currently presented as a modal drawer over the page
|
|
81
|
+
* rather than a column beside it.
|
|
82
|
+
*
|
|
83
|
+
* This is a viewport fact, but it lives in the store rather than being read
|
|
84
|
+
* off `matchMedia` at each use site because it must change in the SAME write
|
|
85
|
+
* as `collapsed` — see `setSidebarNarrow`.
|
|
86
|
+
*/
|
|
87
|
+
narrow: boolean;
|
|
88
|
+
}
|
|
89
|
+
|
|
90
|
+
const listeners = new Set<() => void>();
|
|
91
|
+
|
|
92
|
+
/**
|
|
93
|
+
* Publish the current values as a NEW frozen snapshot, then wake subscribers.
|
|
94
|
+
* Rebuilding the object here — rather than in the getter — is what lets
|
|
95
|
+
* `useSyncExternalStore` compare by identity: unchanged state keeps the same
|
|
96
|
+
* object, so a read never looks like a change.
|
|
97
|
+
*/
|
|
98
|
+
function emit(): void {
|
|
99
|
+
snapshot = { collapsed, width, instant, narrow };
|
|
100
|
+
listeners.forEach((l) => l());
|
|
101
|
+
}
|
|
102
|
+
|
|
103
|
+
/**
|
|
104
|
+
* The `useSyncExternalStore` half: register a listener and hand back its
|
|
105
|
+
* unsubscribe, so an unmounted component stops being notified.
|
|
106
|
+
*/
|
|
107
|
+
function subscribe(listener: () => void): () => void {
|
|
108
|
+
listeners.add(listener);
|
|
109
|
+
return () => listeners.delete(listener);
|
|
110
|
+
}
|
|
111
|
+
|
|
112
|
+
/** The toolbar button. A gesture, so it always animates. */
|
|
113
|
+
export function toggleSidebar(): void {
|
|
114
|
+
collapsed = !collapsed;
|
|
115
|
+
instant = false;
|
|
116
|
+
emit();
|
|
117
|
+
}
|
|
118
|
+
|
|
119
|
+
/**
|
|
120
|
+
* Direct set — the toolbar toggle's target, and how tests reset the module.
|
|
121
|
+
*
|
|
122
|
+
* @param instantly true when the change must not be performed: the nav simply
|
|
123
|
+
* is, or is not, in the next frame. `instant` rides along on the snapshot
|
|
124
|
+
* rather than being cleared on a timer, because the next change is what
|
|
125
|
+
* makes it stale — and every writer states its own intent.
|
|
126
|
+
*/
|
|
127
|
+
export function setSidebarCollapsed(value: boolean, instantly = false): void {
|
|
128
|
+
if (value === collapsed) return;
|
|
129
|
+
collapsed = value;
|
|
130
|
+
instant = instantly;
|
|
131
|
+
emit();
|
|
132
|
+
}
|
|
133
|
+
|
|
134
|
+
/**
|
|
135
|
+
* Report the viewport crossing the drawer breakpoint, and settle the nav to
|
|
136
|
+
* match: hidden on the way into a narrow layout, back beside the page on the
|
|
137
|
+
* way out.
|
|
138
|
+
*
|
|
139
|
+
* Crossings are the only thing this reacts to — repeating the current value is
|
|
140
|
+
* a no-op — so a nav the user reopened by hand at phone width stays open until
|
|
141
|
+
* the next crossing, and a desktop mount never has its collapsed state
|
|
142
|
+
* rewritten just because a frame mounted.
|
|
143
|
+
*
|
|
144
|
+
* Both fields move in ONE write on purpose. `narrow` is what tells a frame to
|
|
145
|
+
* present itself as a modal drawer, and `collapsed` is what decides whether it
|
|
146
|
+
* is showing; setting them separately would leave a render in between where a
|
|
147
|
+
* phone viewport still shows a full-width column shoving the page aside — and
|
|
148
|
+
* that render would open a focus trap on the way past.
|
|
149
|
+
*/
|
|
150
|
+
export function setSidebarNarrow(value: boolean): void {
|
|
151
|
+
if (value === narrow) return;
|
|
152
|
+
narrow = value;
|
|
153
|
+
collapsed = value;
|
|
154
|
+
instant = false;
|
|
155
|
+
emit();
|
|
156
|
+
}
|
|
157
|
+
|
|
158
|
+
/**
|
|
159
|
+
* @param persist false while a drag is in flight. A pointermove fires dozens
|
|
160
|
+
* of times a second and every write is synchronous; the committed width is
|
|
161
|
+
* what is worth remembering, so the drag writes on mouseup.
|
|
162
|
+
*/
|
|
163
|
+
export function setSidebarWidth(value: number, persist = true): void {
|
|
164
|
+
const next = clampSidebarWidth(value);
|
|
165
|
+
if (next === width) return;
|
|
166
|
+
width = next;
|
|
167
|
+
emit();
|
|
168
|
+
if (!persist) return;
|
|
169
|
+
try {
|
|
170
|
+
window.localStorage.setItem(WIDTH_STORAGE_KEY, String(next));
|
|
171
|
+
} catch {
|
|
172
|
+
/* see readStoredWidth */
|
|
173
|
+
}
|
|
174
|
+
}
|
|
175
|
+
|
|
176
|
+
/** Writes the current width without changing it — ends a drag. */
|
|
177
|
+
export function commitSidebarWidth(): void {
|
|
178
|
+
try {
|
|
179
|
+
window.localStorage.setItem(WIDTH_STORAGE_KEY, String(width));
|
|
180
|
+
} catch {
|
|
181
|
+
/* see readStoredWidth */
|
|
182
|
+
}
|
|
183
|
+
}
|
|
184
|
+
|
|
185
|
+
/** Subscribe a component to the sidebar's state. Re-renders only on a real change. */
|
|
186
|
+
export function useSidebar(): SidebarState {
|
|
187
|
+
return useSyncExternalStore(
|
|
188
|
+
subscribe,
|
|
189
|
+
() => snapshot,
|
|
190
|
+
// Server/prerender: the default, since there is no storage to read.
|
|
191
|
+
() => DEFAULT_SNAPSHOT,
|
|
192
|
+
);
|
|
193
|
+
}
|
|
194
|
+
|
|
195
|
+
const DEFAULT_SNAPSHOT: SidebarState = {
|
|
196
|
+
collapsed: false,
|
|
197
|
+
width: SIDEBAR_DEFAULT_WIDTH,
|
|
198
|
+
instant: false,
|
|
199
|
+
narrow: false,
|
|
200
|
+
};
|
|
@@ -0,0 +1,313 @@
|
|
|
1
|
+
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
|
|
2
|
+
import { DEFAULT_BRANCH } from '@bevel-software/platform-shared';
|
|
3
|
+
import { render, screen, fireEvent, waitFor } from '@testing-library/react';
|
|
4
|
+
import { MemoryRouter, Route, Routes, useLocation } from 'react-router-dom';
|
|
5
|
+
import {
|
|
6
|
+
WorkspaceContext,
|
|
7
|
+
type WorkspaceContextValue,
|
|
8
|
+
} from '../../workspace/state/workspace.context';
|
|
9
|
+
import { AdminContext, type AdminContextValue } from '../../admin/state/admin.context';
|
|
10
|
+
import { LibraryToastProvider } from '../state/toast';
|
|
11
|
+
import { withAuth } from './auth-harness';
|
|
12
|
+
|
|
13
|
+
/**
|
|
14
|
+
* The writer's "add something" dialog. The prompt is the product in its second
|
|
15
|
+
* half, so it is asserted character-for-character: it is pasted into an agent
|
|
16
|
+
* verbatim, and a drifting word changes what the agent does with it. The first
|
|
17
|
+
* half is now a real write rather than a link, so what is worth testing there
|
|
18
|
+
* is the path it composes and the two ways the name can be wrong.
|
|
19
|
+
*/
|
|
20
|
+
|
|
21
|
+
const apiMock = vi.hoisted(() => ({ createEmptySkill: vi.fn() }));
|
|
22
|
+
vi.mock('../services/library.api', async (importOriginal) => ({
|
|
23
|
+
...(await importOriginal<typeof import('../services/library.api')>()),
|
|
24
|
+
createEmptySkill: apiMock.createEmptySkill,
|
|
25
|
+
}));
|
|
26
|
+
|
|
27
|
+
import { AddToGroupDialog } from '../components/AddToGroupDialog';
|
|
28
|
+
|
|
29
|
+
const ADD_PROMPT =
|
|
30
|
+
'Help me build a new skill or tool and add it to the GTM group at Bevel. ' +
|
|
31
|
+
'I run it, so it goes in directly. No review step.';
|
|
32
|
+
|
|
33
|
+
function workspace(kbDirName: string | null) {
|
|
34
|
+
return { workspaceId: 'target-company-state', kbDirName } as unknown as WorkspaceContextValue;
|
|
35
|
+
}
|
|
36
|
+
|
|
37
|
+
function admin(isAdmin: boolean): AdminContextValue {
|
|
38
|
+
return {
|
|
39
|
+
isAdmin,
|
|
40
|
+
unreadCount: 0,
|
|
41
|
+
lastSeen: null,
|
|
42
|
+
markSeen: vi.fn(),
|
|
43
|
+
refresh: vi.fn(),
|
|
44
|
+
rolesConfigCorrupted: false,
|
|
45
|
+
rolesConfigErrors: [],
|
|
46
|
+
runRolesRecovery: vi.fn(),
|
|
47
|
+
};
|
|
48
|
+
}
|
|
49
|
+
|
|
50
|
+
function LocationProbe() {
|
|
51
|
+
const location = useLocation();
|
|
52
|
+
return (
|
|
53
|
+
<>
|
|
54
|
+
<div aria-label="href">{location.pathname}</div>
|
|
55
|
+
<div aria-label="router-state">{JSON.stringify(location.state)}</div>
|
|
56
|
+
</>
|
|
57
|
+
);
|
|
58
|
+
}
|
|
59
|
+
|
|
60
|
+
function renderDialog(
|
|
61
|
+
kbDirName: string | null = 'knowledge-base',
|
|
62
|
+
canWrite = true,
|
|
63
|
+
existingSkills: string[] = [],
|
|
64
|
+
isAdmin = true,
|
|
65
|
+
) {
|
|
66
|
+
const onClose = vi.fn();
|
|
67
|
+
render(
|
|
68
|
+
<MemoryRouter initialEntries={['/skills-and-tools/groups/GTM']}>
|
|
69
|
+
<AdminContext.Provider value={admin(isAdmin)}>
|
|
70
|
+
<WorkspaceContext.Provider value={workspace(kbDirName)}>
|
|
71
|
+
<LibraryToastProvider>
|
|
72
|
+
{withAuth(
|
|
73
|
+
<>
|
|
74
|
+
<Routes>
|
|
75
|
+
<Route
|
|
76
|
+
path="*"
|
|
77
|
+
element={
|
|
78
|
+
<AddToGroupDialog
|
|
79
|
+
name="GTM"
|
|
80
|
+
primaryPath="Groups/GTM"
|
|
81
|
+
canWrite={canWrite}
|
|
82
|
+
existingSkills={existingSkills}
|
|
83
|
+
onClose={onClose}
|
|
84
|
+
/>
|
|
85
|
+
}
|
|
86
|
+
/>
|
|
87
|
+
</Routes>
|
|
88
|
+
<LocationProbe />
|
|
89
|
+
</>,
|
|
90
|
+
)}
|
|
91
|
+
</LibraryToastProvider>
|
|
92
|
+
</WorkspaceContext.Provider>
|
|
93
|
+
</AdminContext.Provider>
|
|
94
|
+
</MemoryRouter>,
|
|
95
|
+
);
|
|
96
|
+
return {
|
|
97
|
+
onClose,
|
|
98
|
+
field: () => screen.getByRole('textbox', { name: 'Skill name' }),
|
|
99
|
+
create: () => screen.getByRole('button', { name: /^Create|Creating/ }),
|
|
100
|
+
href: () => screen.getByLabelText('href').textContent,
|
|
101
|
+
};
|
|
102
|
+
}
|
|
103
|
+
|
|
104
|
+
const writeText = vi.fn<(text: string) => Promise<void>>();
|
|
105
|
+
|
|
106
|
+
describe('AddToGroupDialog', () => {
|
|
107
|
+
beforeEach(() => {
|
|
108
|
+
writeText.mockReset();
|
|
109
|
+
writeText.mockResolvedValue(undefined);
|
|
110
|
+
apiMock.createEmptySkill.mockReset();
|
|
111
|
+
apiMock.createEmptySkill.mockResolvedValue({
|
|
112
|
+
repoRelativePath: 'Groups/GTM/weekly-report/SKILL.md',
|
|
113
|
+
workspacePath: 'knowledge-base/Groups/GTM/weekly-report/SKILL.md',
|
|
114
|
+
branch: 'target-company-state',
|
|
115
|
+
direct: true,
|
|
116
|
+
});
|
|
117
|
+
Object.defineProperty(navigator, 'clipboard', {
|
|
118
|
+
value: { writeText },
|
|
119
|
+
configurable: true,
|
|
120
|
+
});
|
|
121
|
+
});
|
|
122
|
+
|
|
123
|
+
afterEach(() => {
|
|
124
|
+
Reflect.deleteProperty(navigator, 'clipboard');
|
|
125
|
+
});
|
|
126
|
+
|
|
127
|
+
it('names the group in its title and its lede', () => {
|
|
128
|
+
renderDialog();
|
|
129
|
+
expect(screen.getByRole('heading', { name: 'Add a skill or tool to GTM' })).toBeInTheDocument();
|
|
130
|
+
expect(
|
|
131
|
+
screen.getByText(
|
|
132
|
+
'Two ways in. Either way it joins GTM. Everyone in the group gets it the next time their agent connects.',
|
|
133
|
+
),
|
|
134
|
+
).toBeInTheDocument();
|
|
135
|
+
});
|
|
136
|
+
|
|
137
|
+
it('copies the agent prompt verbatim and says so', async () => {
|
|
138
|
+
renderDialog();
|
|
139
|
+
expect(screen.getByText(ADD_PROMPT)).toBeInTheDocument();
|
|
140
|
+
fireEvent.click(screen.getByRole('button', { name: 'Copy prompt' }));
|
|
141
|
+
await waitFor(() => expect(writeText).toHaveBeenCalledWith(ADD_PROMPT));
|
|
142
|
+
expect(await screen.findByText('Prompt copied.')).toBeInTheDocument();
|
|
143
|
+
});
|
|
144
|
+
|
|
145
|
+
it('tells the truth when the clipboard is unavailable', async () => {
|
|
146
|
+
// What a non-secure context looks like: the API is simply not there.
|
|
147
|
+
Object.defineProperty(navigator, 'clipboard', { value: undefined, configurable: true });
|
|
148
|
+
renderDialog();
|
|
149
|
+
fireEvent.click(screen.getByRole('button', { name: 'Copy prompt' }));
|
|
150
|
+
expect(
|
|
151
|
+
await screen.findByText("Couldn't copy: select the prompt text instead."),
|
|
152
|
+
).toBeInTheDocument();
|
|
153
|
+
expect(screen.queryByText('Prompt copied.')).not.toBeInTheDocument();
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
it('closes from the footer', () => {
|
|
157
|
+
const { onClose } = renderDialog();
|
|
158
|
+
// Two controls are named "Close": the dialog chrome's X and the footer
|
|
159
|
+
// button. The footer one is last in the DOM.
|
|
160
|
+
const closes = screen.getAllByRole('button', { name: 'Close' });
|
|
161
|
+
fireEvent.click(closes[closes.length - 1]);
|
|
162
|
+
expect(onClose).toHaveBeenCalledTimes(1);
|
|
163
|
+
});
|
|
164
|
+
});
|
|
165
|
+
|
|
166
|
+
// ── the first door: a file, not a folder tour ──
|
|
167
|
+
// This half used to navigate to the group folder and leave the person there to
|
|
168
|
+
// work out that a skill is a folder with a SKILL.md in it. It now writes the
|
|
169
|
+
// file, so the assertions are about what gets written and where it opens.
|
|
170
|
+
describe('AddToGroupDialog: starting an empty SKILL.md', () => {
|
|
171
|
+
beforeEach(() => {
|
|
172
|
+
apiMock.createEmptySkill.mockReset();
|
|
173
|
+
apiMock.createEmptySkill.mockResolvedValue({
|
|
174
|
+
repoRelativePath: 'Groups/GTM/weekly-report/SKILL.md',
|
|
175
|
+
workspacePath: 'knowledge-base/Groups/GTM/weekly-report/SKILL.md',
|
|
176
|
+
branch: 'target-company-state',
|
|
177
|
+
direct: true,
|
|
178
|
+
});
|
|
179
|
+
});
|
|
180
|
+
|
|
181
|
+
it('will not create an unnamed skill', () => {
|
|
182
|
+
const { create } = renderDialog();
|
|
183
|
+
expect(create()).toBeDisabled();
|
|
184
|
+
});
|
|
185
|
+
|
|
186
|
+
it('creates it in the group folder, opens the file, and closes', async () => {
|
|
187
|
+
const { field, create, onClose, href } = renderDialog();
|
|
188
|
+
fireEvent.change(field(), { target: { value: ' weekly-report ' } });
|
|
189
|
+
fireEvent.click(create());
|
|
190
|
+
|
|
191
|
+
// Trimmed, addressed at the group's own folder, and carrying the writer
|
|
192
|
+
// verdict — the service decides direct-vs-change-request from it.
|
|
193
|
+
await waitFor(() =>
|
|
194
|
+
expect(apiMock.createEmptySkill).toHaveBeenCalledWith(
|
|
195
|
+
expect.objectContaining({
|
|
196
|
+
parentPath: 'Groups/GTM',
|
|
197
|
+
name: 'weekly-report',
|
|
198
|
+
canWrite: true,
|
|
199
|
+
}),
|
|
200
|
+
),
|
|
201
|
+
);
|
|
202
|
+
// Lands on the new skill's own LIBRARY page — never bounced to the
|
|
203
|
+
// Knowledge app — with the editor handed the open signal IN ROUTER
|
|
204
|
+
// STATE. Asserted by field, so a renamed or dropped flag fails here
|
|
205
|
+
// rather than silently landing on a read-only page.
|
|
206
|
+
await waitFor(() =>
|
|
207
|
+
// The canonical address: the new SKILL.md's own workspace URL.
|
|
208
|
+
expect(href()).toBe(`/workspace/${DEFAULT_BRANCH}/knowledge-base/Groups/GTM/weekly-report/SKILL.md`),
|
|
209
|
+
);
|
|
210
|
+
expect(screen.getByLabelText('router-state')).toHaveTextContent(
|
|
211
|
+
JSON.stringify({ startEditing: true }),
|
|
212
|
+
);
|
|
213
|
+
expect(onClose).toHaveBeenCalledTimes(1);
|
|
214
|
+
});
|
|
215
|
+
|
|
216
|
+
it('refuses a name that would create a nested folder', () => {
|
|
217
|
+
const { field, create } = renderDialog();
|
|
218
|
+
fireEvent.change(field(), { target: { value: 'GTM/weekly' } });
|
|
219
|
+
expect(screen.getByRole('alert')).toHaveTextContent('/');
|
|
220
|
+
expect(create()).toBeDisabled();
|
|
221
|
+
expect(apiMock.createEmptySkill).not.toHaveBeenCalled();
|
|
222
|
+
});
|
|
223
|
+
|
|
224
|
+
it('refuses a name another skill already holds, in any group', () => {
|
|
225
|
+
// A skill's id IS its name, and the backend's scan drops the second claimant
|
|
226
|
+
// outright — so this file would exist and never appear anywhere.
|
|
227
|
+
const { field, create } = renderDialog('knowledge-base', true, ['rfi', 'weekly-report']);
|
|
228
|
+
fireEvent.change(field(), { target: { value: 'Weekly-Report' } });
|
|
229
|
+
expect(screen.getByRole('alert')).toHaveTextContent('already exists');
|
|
230
|
+
expect(create()).toBeDisabled();
|
|
231
|
+
});
|
|
232
|
+
|
|
233
|
+
it('surfaces the backend refusal and stays open', async () => {
|
|
234
|
+
apiMock.createEmptySkill.mockRejectedValue(
|
|
235
|
+
new Error("You don't have permission to write to Groups/GTM"),
|
|
236
|
+
);
|
|
237
|
+
const { field, create, onClose } = renderDialog();
|
|
238
|
+
fireEvent.change(field(), { target: { value: 'weekly-report' } });
|
|
239
|
+
fireEvent.click(create());
|
|
240
|
+
|
|
241
|
+
expect(await screen.findByText(/don't have permission to write to Groups\/GTM/)).toBeInTheDocument();
|
|
242
|
+
expect(onClose).not.toHaveBeenCalled();
|
|
243
|
+
});
|
|
244
|
+
});
|
|
245
|
+
|
|
246
|
+
// ── one door, one varying clause ──
|
|
247
|
+
// The group page used to fork on `canWrite` into two different flows. It does
|
|
248
|
+
// not any more: everybody gets THIS dialog, and the only thing role changes is
|
|
249
|
+
// what the prompt says happens next — and, now, where the new file lands.
|
|
250
|
+
describe('AddToGroupDialog for an admin non-writer', () => {
|
|
251
|
+
it('offers the same dialog, and tells the truth about review', () => {
|
|
252
|
+
renderDialog('knowledge-base', false);
|
|
253
|
+
expect(
|
|
254
|
+
screen.getByText(/goes to GTM as a change request, and an owner reviews it/),
|
|
255
|
+
).toBeInTheDocument();
|
|
256
|
+
expect(screen.getByText(/send it to the group as a change request/)).toBeInTheDocument();
|
|
257
|
+
expect(screen.queryByText(/no review step/)).not.toBeInTheDocument();
|
|
258
|
+
});
|
|
259
|
+
|
|
260
|
+
it('still offers an admin both doors', () => {
|
|
261
|
+
renderDialog('knowledge-base', false);
|
|
262
|
+
expect(screen.getByRole('textbox', { name: 'Skill name' })).toBeInTheDocument();
|
|
263
|
+
expect(screen.getByRole('button', { name: 'Copy prompt' })).toBeInTheDocument();
|
|
264
|
+
});
|
|
265
|
+
|
|
266
|
+
it('passes the verdict down, so the file goes for review', async () => {
|
|
267
|
+
apiMock.createEmptySkill.mockResolvedValue({
|
|
268
|
+
repoRelativePath: 'Groups/GTM/weekly-report/SKILL.md',
|
|
269
|
+
workspacePath: 'knowledge-base/Groups/GTM/weekly-report/SKILL.md',
|
|
270
|
+
branch: 'suggestions/juan/weekly-report',
|
|
271
|
+
direct: false,
|
|
272
|
+
});
|
|
273
|
+
const { field, create, href } = renderDialog('knowledge-base', false);
|
|
274
|
+
fireEvent.change(field(), { target: { value: 'weekly-report' } });
|
|
275
|
+
fireEvent.click(create());
|
|
276
|
+
|
|
277
|
+
await waitFor(() =>
|
|
278
|
+
expect(apiMock.createEmptySkill).toHaveBeenCalledWith(
|
|
279
|
+
expect.objectContaining({ canWrite: false }),
|
|
280
|
+
),
|
|
281
|
+
);
|
|
282
|
+
// A proposal has no page yet, so the dialog does NOT navigate — the group
|
|
283
|
+
// page stays put, and the new skill appears on it as an "In review" card.
|
|
284
|
+
expect(await screen.findByText(/sent to the group's owners for review/)).toBeInTheDocument();
|
|
285
|
+
expect(href()).toBe('/skills-and-tools/groups/GTM');
|
|
286
|
+
});
|
|
287
|
+
});
|
|
288
|
+
|
|
289
|
+
describe('AddToGroupDialog for a non-admin', () => {
|
|
290
|
+
beforeEach(() => {
|
|
291
|
+
apiMock.createEmptySkill.mockClear();
|
|
292
|
+
});
|
|
293
|
+
|
|
294
|
+
it('removes empty skill creation even when the person can write the group', () => {
|
|
295
|
+
renderDialog('knowledge-base', true, [], false);
|
|
296
|
+
|
|
297
|
+
expect(screen.queryByText('Start an empty SKILL.md')).not.toBeInTheDocument();
|
|
298
|
+
expect(screen.queryByRole('textbox', { name: 'Skill name' })).not.toBeInTheDocument();
|
|
299
|
+
expect(screen.getByRole('button', { name: 'Copy prompt' })).toBeInTheDocument();
|
|
300
|
+
expect(screen.getByText(/add it to GTM for everyone in the group/)).toBeInTheDocument();
|
|
301
|
+
expect(screen.queryByText(/Two ways in/)).not.toBeInTheDocument();
|
|
302
|
+
});
|
|
303
|
+
|
|
304
|
+
it('keeps only the reviewed agent path when the person cannot write the group', () => {
|
|
305
|
+
renderDialog('knowledge-base', false, [], false);
|
|
306
|
+
|
|
307
|
+
expect(screen.queryByText('Start an empty SKILL.md')).not.toBeInTheDocument();
|
|
308
|
+
expect(screen.queryByRole('textbox', { name: 'Skill name' })).not.toBeInTheDocument();
|
|
309
|
+
expect(screen.getByText(/change request for an owner to review/)).toBeInTheDocument();
|
|
310
|
+
expect(screen.getByText(/send it to the group as a change request/)).toBeInTheDocument();
|
|
311
|
+
expect(apiMock.createEmptySkill).not.toHaveBeenCalled();
|
|
312
|
+
});
|
|
313
|
+
});
|
|
@@ -0,0 +1,84 @@
|
|
|
1
|
+
import { describe, it, expect } from 'vitest';
|
|
2
|
+
import { render, screen } from '@testing-library/react';
|
|
3
|
+
import userEvent from '@testing-library/user-event';
|
|
4
|
+
import type { PullRequestSummary } from '@bevel-software/platform-shared';
|
|
5
|
+
import { ChangeRequestDock } from '../components/ChangeRequestDock';
|
|
6
|
+
import { PageActions } from '../components/PageActions';
|
|
7
|
+
import { Dialog } from '../../../shared/components';
|
|
8
|
+
|
|
9
|
+
const CR = {
|
|
10
|
+
number: 7,
|
|
11
|
+
title: 'Tighten the refund wording',
|
|
12
|
+
author: { login: 'user-42ee38e1c062' },
|
|
13
|
+
appAuthor: { name: 'Olga' },
|
|
14
|
+
branch: 'cr/refund-wording',
|
|
15
|
+
} as unknown as PullRequestSummary;
|
|
16
|
+
|
|
17
|
+
/**
|
|
18
|
+
* The stacking band an element paints in, read off the Tailwind class it
|
|
19
|
+
* carries (`z-30`, `z-[60]`).
|
|
20
|
+
*
|
|
21
|
+
* Reading the class rather than a computed style is not a shortcut: happy-dom
|
|
22
|
+
* loads no stylesheet, and Tailwind emits nothing at test time, so the class
|
|
23
|
+
* IS the value — and it is exactly what a layering regression rewrites.
|
|
24
|
+
*/
|
|
25
|
+
function band(el: Element): number {
|
|
26
|
+
for (const cls of el.classList) {
|
|
27
|
+
const m = /^z-\[?(\d+)\]?$/.exec(cls);
|
|
28
|
+
if (m) return Number(m[1]);
|
|
29
|
+
}
|
|
30
|
+
throw new Error(`no z-index class on: ${el.className}`);
|
|
31
|
+
}
|
|
32
|
+
|
|
33
|
+
const dock = () => screen.getByRole('complementary', { name: /change requests for this skill/i });
|
|
34
|
+
|
|
35
|
+
/**
|
|
36
|
+
* WHICH BAND THE DOCK PAINTS IN.
|
|
37
|
+
*
|
|
38
|
+
* The dock is ambient — it sits beside the skill for as long as you are
|
|
39
|
+
* reading it — and nothing ambient may cover something the user just opened.
|
|
40
|
+
* It shipped at `z-55`, above both the anchored-dropdown band and the modal
|
|
41
|
+
* band, so opening the profile menu got you a list of change requests painted
|
|
42
|
+
* over it and a dialog fared no better.
|
|
43
|
+
*
|
|
44
|
+
* These assert the ORDER against the real components on the other side of it,
|
|
45
|
+
* not the literal number, so raising either band later can't quietly restore
|
|
46
|
+
* the bug.
|
|
47
|
+
*/
|
|
48
|
+
describe('ChangeRequestDock: stacking band', () => {
|
|
49
|
+
it('paints below the anchored-dropdown band, so an open menu is never covered', async () => {
|
|
50
|
+
const user = userEvent.setup();
|
|
51
|
+
render(
|
|
52
|
+
<>
|
|
53
|
+
<ChangeRequestDock crs={[CR]} onSelect={() => {}} />
|
|
54
|
+
<PageActions onAdd={() => {}} onCopyLink={async () => true} />
|
|
55
|
+
</>,
|
|
56
|
+
);
|
|
57
|
+
|
|
58
|
+
await user.click(screen.getByRole('button', { name: /more actions/i }));
|
|
59
|
+
const menu = screen.getByRole('menu', { name: /more actions/i }).parentElement!;
|
|
60
|
+
|
|
61
|
+
expect(band(dock())).toBeLessThan(band(menu));
|
|
62
|
+
});
|
|
63
|
+
|
|
64
|
+
it('paints below the modal band, so a dialog is never covered', () => {
|
|
65
|
+
render(
|
|
66
|
+
<>
|
|
67
|
+
<ChangeRequestDock crs={[CR]} onSelect={() => {}} />
|
|
68
|
+
<Dialog open title="Manage access" onClose={() => {}}>
|
|
69
|
+
<p>body</p>
|
|
70
|
+
</Dialog>
|
|
71
|
+
</>,
|
|
72
|
+
);
|
|
73
|
+
|
|
74
|
+
const scrim = screen.getByRole('dialog').parentElement!;
|
|
75
|
+
|
|
76
|
+
expect(band(dock())).toBeLessThan(band(scrim));
|
|
77
|
+
});
|
|
78
|
+
|
|
79
|
+
it('renders nothing when there is nothing to review', () => {
|
|
80
|
+
render(<ChangeRequestDock crs={[]} onSelect={() => {}} />);
|
|
81
|
+
|
|
82
|
+
expect(screen.queryByRole('complementary')).not.toBeInTheDocument();
|
|
83
|
+
});
|
|
84
|
+
});
|