@bevel-software/platform-core-backend 0.7.5 → 0.9.0

package/src/modules/workspace/__tests__/workspace.service.test.ts

@@ -437,6 +437,33 @@ describe('WorkspaceService — clone bootstrap & sibling reference', () => {
   });
 });
 
+describe('WorkspaceService.sweepOrphanedWorkspaces', () => {
+  let root: string;
+
+  beforeEach(async () => {
+    root = await mkTmpRoot();
+    // The fake `.git` in seedBranchWorkspace makes normalizeCloneTracking's
+    // git calls fail; that path only warns, which is noise here.
+    vi.spyOn(console, 'warn').mockImplementation(() => {});
+  });
+
+  afterEach(async () => {
+    vi.restoreAllMocks();
+    await fs.rm(root, { recursive: true, force: true });
+  });
+
+  it('removes the clone of a branch that is not in the known set', async () => {
+    const { workspaceId, workspaceDir } = await seedBranchWorkspace(root, 'target-company-state');
+    const svc = new WorkspaceService(root, 'https://github.com/Bevel-Software/knowledge-base.git', 'knowledge-base');
+    await svc.getOrCreateForBranch('target-company-state');
+
+    // The branch vanishes from the known set; the sweep reclaims its clone.
+    const { removed } = await svc.sweepOrphanedWorkspaces([]);
+    expect(removed).toContain(workspaceId);
+    await expect(fs.stat(workspaceDir)).rejects.toThrow();
+  });
+});
+
 describe('WorkspaceService.readAllKbFiles', () => {
   let root: string;
   let svc: WorkspaceService;

package/src/modules/workspace/bevel-ignore.ts

@@ -1,66 +1,66 @@
-import fs from 'node:fs/promises';
-import path from 'node:path';
-import ignore, { type Ignore } from 'ignore';
-
-/**
- * The ignore file's own name. Exported because the file-tree filter hides it
- * from non-admins, and both places must agree on the spelling.
- */
-export const IGNORE_FILENAME = '.bevelignore';
-
-/** One .bevelignore file's rules, scoped to the directory it lives in. */
-interface IgnoreLayer {
-  /** Absolute path of the directory where the .bevelignore lives. */
-  readonly root: string;
-  readonly matcher: Ignore;
-}
-
-/**
- * A hierarchical stack of `.bevelignore` rule sets.
- *
- * Each `.bevelignore` file applies to paths beneath the directory it lives in,
- * using standard gitignore syntax (negations, `**`, directory-only patterns, anchoring).
- * Deeper files combine with — and can override — rules from shallower files,
- * mirroring how git layers `.gitignore` files.
- */
-export class BevelIgnoreStack {
-  private constructor(private readonly layers: readonly IgnoreLayer[]) {}
-
-  static empty(): BevelIgnoreStack {
-    return new BevelIgnoreStack([]);
-  }
-
-  /**
-   * Return a new stack that additionally includes a `.bevelignore` from `dir`
-   * (if present). If no `.bevelignore` exists in `dir`, returns this stack unchanged.
-   */
-  async extendedWith(dir: string): Promise<BevelIgnoreStack> {
-    const file = path.join(dir, IGNORE_FILENAME);
-    let contents: string;
-    try {
-      contents = await fs.readFile(file, 'utf-8');
-    } catch {
-      return this;
-    }
-    const matcher = ignore().add(contents);
-    return new BevelIgnoreStack([...this.layers, { root: dir, matcher }]);
-  }
-
-  /**
-   * Whether the given entry should be hidden from the file tree.
-   * @param absolutePath absolute path of the entry
-   * @param isDirectory needed because gitignore patterns ending in `/` match directories only
-   */
-  isIgnored(absolutePath: string, isDirectory: boolean): boolean {
-    for (const layer of this.layers) {
-      const rel = path.relative(layer.root, absolutePath).replace(/\\/g, '/');
-      // Skip entries that aren't under this layer's root (shouldn't happen in normal
-      // recursion, but guards against absolute-path quirks on Windows).
-      if (!rel || rel.startsWith('..')) continue;
-      // Append trailing slash for directories so `foo/`-style rules match correctly.
-      const probe = isDirectory ? `${rel}/` : rel;
-      if (layer.matcher.ignores(probe)) return true;
-    }
-    return false;
-  }
-}
+import fs from 'node:fs/promises';
+import path from 'node:path';
+import ignore, { type Ignore } from 'ignore';
+
+/**
+ * The ignore file's own name. Exported because the file-tree filter hides it
+ * from non-admins, and both places must agree on the spelling.
+ */
+export const IGNORE_FILENAME = '.bevelignore';
+
+/** One .bevelignore file's rules, scoped to the directory it lives in. */
+interface IgnoreLayer {
+  /** Absolute path of the directory where the .bevelignore lives. */
+  readonly root: string;
+  readonly matcher: Ignore;
+}
+
+/**
+ * A hierarchical stack of `.bevelignore` rule sets.
+ *
+ * Each `.bevelignore` file applies to paths beneath the directory it lives in,
+ * using standard gitignore syntax (negations, `**`, directory-only patterns, anchoring).
+ * Deeper files combine with — and can override — rules from shallower files,
+ * mirroring how git layers `.gitignore` files.
+ */
+export class BevelIgnoreStack {
+  private constructor(private readonly layers: readonly IgnoreLayer[]) {}
+
+  static empty(): BevelIgnoreStack {
+    return new BevelIgnoreStack([]);
+  }
+
+  /**
+   * Return a new stack that additionally includes a `.bevelignore` from `dir`
+   * (if present). If no `.bevelignore` exists in `dir`, returns this stack unchanged.
+   */
+  async extendedWith(dir: string): Promise<BevelIgnoreStack> {
+    const file = path.join(dir, IGNORE_FILENAME);
+    let contents: string;
+    try {
+      contents = await fs.readFile(file, 'utf-8');
+    } catch {
+      return this;
+    }
+    const matcher = ignore().add(contents);
+    return new BevelIgnoreStack([...this.layers, { root: dir, matcher }]);
+  }
+
+  /**
+   * Whether the given entry should be hidden from the file tree.
+   * @param absolutePath absolute path of the entry
+   * @param isDirectory needed because gitignore patterns ending in `/` match directories only
+   */
+  isIgnored(absolutePath: string, isDirectory: boolean): boolean {
+    for (const layer of this.layers) {
+      const rel = path.relative(layer.root, absolutePath).replace(/\\/g, '/');
+      // Skip entries that aren't under this layer's root (shouldn't happen in normal
+      // recursion, but guards against absolute-path quirks on Windows).
+      if (!rel || rel.startsWith('..')) continue;
+      // Append trailing slash for directories so `foo/`-style rules match correctly.
+      const probe = isDirectory ? `${rel}/` : rel;
+      if (layer.matcher.ignores(probe)) return true;
+    }
+    return false;
+  }
+}

package/src/modules/workspace/session-sink.ts

@@ -1,25 +1,25 @@
-import { randomUUID } from 'node:crypto';
-
-/**
- * Port behind `start_session` (workspace.tools.ts): mints the session id an
- * external agent scopes its ontology boundary under. The workspace module owns
- * the port; WHAT backs the id is the composition root's choice:
- *
- * - Core default ({@link UuidSessionSink}): a bare random id — sufficient for
- *   the session-ontology gate, with no app-side session record.
- * - The enterprise app substitutes a sink that mints a REAL chat thread, so the
- *   same id also works end to end with `ask` (its sessionId IS a chat thread).
- *   See the `start_session` comment in workspace.tools.ts for why that
- *   unification matters.
- */
-export interface ISessionSink {
-  /** Mint a session id for an external agent run started at `startedAt`. */
-  createSession(userId: string, startedAt: Date): Promise<{ sessionId: string }>;
-}
-
-/** Core default: a bare random id — no app-side session record. */
-export class UuidSessionSink implements ISessionSink {
-  async createSession(): Promise<{ sessionId: string }> {
-    return { sessionId: randomUUID() };
-  }
-}
+import { randomUUID } from 'node:crypto';
+
+/**
+ * Port behind `start_session` (workspace.tools.ts): mints the session id an
+ * external agent scopes its ontology boundary under. The workspace module owns
+ * the port; WHAT backs the id is the composition root's choice:
+ *
+ * - Core default ({@link UuidSessionSink}): a bare random id — sufficient for
+ *   the session-ontology gate, with no app-side session record.
+ * - The enterprise app substitutes a sink that mints a REAL chat thread, so the
+ *   same id also works end to end with `ask` (its sessionId IS a chat thread).
+ *   See the `start_session` comment in workspace.tools.ts for why that
+ *   unification matters.
+ */
+export interface ISessionSink {
+  /** Mint a session id for an external agent run started at `startedAt`. */
+  createSession(userId: string, startedAt: Date): Promise<{ sessionId: string }>;
+}
+
+/** Core default: a bare random id — no app-side session record. */
+export class UuidSessionSink implements ISessionSink {
+  async createSession(): Promise<{ sessionId: string }> {
+    return { sessionId: randomUUID() };
+  }
+}