@bevel-software/platform-core-backend 0.25.2 → 0.27.0

package/src/modules/workspace/__tests__/workspace.tools.branch-errors.test.ts

@@ -9,6 +9,7 @@ import { afterEach, describe, expect, it } from 'vitest';
 import '@utcp/http'; // registers the http CallTemplate serializer + protocol
 import { UtcpManualSerializer } from '@utcp/sdk';
 import { HttpCallTemplateSerializer } from '@utcp/http';
+import { exampleArguments } from '@bevel-software/platform-mcp-core';
 import { CodeModeUtcpClient } from '../../code-mode/index.js';
 import { testKbContext } from '../../../__tests__/kb-context.js';
 import { NodeFs } from '../../kb-fs/node-fs.js';
@@ -167,7 +168,12 @@ describe('workspace tools — a branch that cannot be opened', () => {
         } as ToolAuth;
         next();
       },
-      createToolHandlerFactory(resolve),
+      // Wired as the composition root wires it, so a missing branch is
+      // answered before the tool runs, as it is in production.
+      createToolHandlerFactory(resolve, undefined, {
+        defaultBranch: () => 'target-company-state',
+        isMissing: (branch) => workspaces!.isBranchMissing(branch),
+      }),
       new SpillStore(spillRoot),
       new DocExtractService(docCacheDir),
       allowAll,
@@ -272,6 +278,24 @@ describe('workspace tools — a branch that cannot be opened', () => {
       });
     }
 
+    /**
+     * The platform's file tools keep the refusal they had: `read_file` is
+     * still `required`, answered the same sentence by the tool handler that
+     * now answers it for every tool that takes a branch.
+     */
+    it('read_file refuses a call without a branch as before', async () => {
+      const base = await start();
+
+      const res = await callTool(base, 'read_file', { path: 'knowledge-base/a.md' });
+
+      expect(res.status).toBe(400);
+      expect(res.body).toEqual({
+        kind: 'branch-required',
+        error: '`branch` is required: pass the branch (draft) you are working on.',
+      });
+      expect(await workspaceDirs()).toEqual([]);
+    });
+
     it('never writes `undefined` or `null` as a branch name into the answer', async () => {
       const base = await start();
 
@@ -407,6 +431,25 @@ describe('workspace tools — a branch that cannot be opened', () => {
     expect(await workspaceDirs()).toEqual([]);
   });
 
+  it('404s a branch that does not exist on every mounted tool that takes one, before the tool runs', async () => {
+    const base = await start({ source: 'internal', scope: 'write' });
+    const takesBranch = internalTools
+      .map((t) => ({ name: t.name, body: (t.inputs as { properties?: { body?: { required?: string[] } } }).properties?.body }))
+      .filter(({ body }) => (body?.required ?? []).includes('branch'))
+      // Resolves its own branch, and validates it itself first.
+      .filter(({ name }) => name !== 'execute_command');
+
+    for (const { name: tool, body } of takesBranch) {
+      // Every other argument the tool requires, so the call matches the tool
+      // and it is the branch, not a missing argument, that is refused.
+      const args = { ...exampleArguments(body), branch: 'nobody/never-made-this' };
+      const res = await callTool(base, tool, args);
+      expect(res.status, `${tool} must 404 a branch that does not exist`).toBe(404);
+      expect(res.body, tool).toMatchObject({ kind: 'branch-not-found', branch: 'nobody/never-made-this' });
+    }
+    expect(await workspaceDirs()).toEqual([]);
+  });
+
   it('410s a branch a listing showed us and origin no longer has', async () => {
     const base = await start();
     workspaces!.noteBranchesListed(['target-company-state', 'alice/draft']);