@bash-app/bash-common 30.424.0 → 30.427.0

package/src/utils/service/venueSettlementUtils.ts

@@ -1,5 +1,5 @@
 /**
- * Phase 2 of the unified-pricing roadmap — pure math for Venue F&B minimums
+ * Phase 2 of the unified-pricing roadmap. Pure math for Venue F&B minimums
  * and revenue share. Pure functions only (no Prisma / no fetches) so the
  * wizard, api validators, settlement worker, and offer-suggestion AI can all
  * share one source of truth.
@@ -34,7 +34,7 @@ export const REVENUE_SHARE_BASES = [
 ] as const;
 export type RevenueShareBasis = (typeof REVENUE_SHARE_BASES)[number];
 
-/** Internal helper — cents → non-negative rounded integer. */
+/** Internal helper. Cents → non-negative rounded integer. */
 function nonNegInt(value: number): number {
   if (!Number.isFinite(value) || value <= 0) return 0;
   return Math.round(value);
@@ -63,7 +63,7 @@ export interface ResolveFBMinimumInput {
  * is used. Returns `null` if neither produces a value.
  *
  * Callers that need timezone-aware day-of-week selection should pre-shift the
- * Date before passing it in — this function uses `Date.getDay()` directly.
+ * Date before passing it in. This function uses `Date.getDay()` directly.
  */
 export function resolveFBMinimumForDate(
   input: ResolveFBMinimumInput

package/src/utils/service/volunteerCompensationUtils.ts

@@ -1,5 +1,5 @@
 /**
- * Volunteer compensation — closed-loop BashPoints stipends + on-site perks.
+ * Volunteer compensation. Closed-loop BashPoints stipends + on-site perks.
  *
  * Volunteers are NOT employees or contractors. This util intentionally avoids
  * any USD rate / wage / per-attendee math, because crossing that line would
@@ -9,7 +9,7 @@
  *   - never cashed out,
  *   - never used to settle third-party USD invoices,
  *   - only redeemable against Bash-issued goods (tickets, BashPass upgrades,
- *     premium features) — see the closed-loop BP plan.
+ *     premium features). See the closed-loop BP plan.
  *
  * Pure functions only so the wizard, api validators, and help-center page
  * share one source of truth.
@@ -119,7 +119,7 @@ export function volunteerCompensationSummary(args: {
 }): string {
   switch (args.compensationType) {
     case "None":
-      return "Pure volunteer — no stipend or perks beyond appreciation.";
+      return "Pure volunteer. No stipend or perks beyond appreciation.";
     case "BashPointsStipend":
       return `${args.bashPointsStipend ?? 0} BashPoints per ${args.rateUnit ?? "shift"}.`;
     case "PerksOnly":

package/src/utils/slugUtils.ts

@@ -85,7 +85,7 @@ export function getPublicBashDetailPath(
 }
 
 /**
- * Path to Your Memories (private vault) for a bash — nested under bash detail
+ * Path to Your Memories (private vault) for a bash. Nested under bash detail
  * (`/bash/{id}-{slug}/memories`). Requires sign-in + eligibility; not a public
  * unauthenticated recap page.
  */

package/src/utils/ticketPrintPostageUtils.ts

@@ -1,10 +1,10 @@
 /**
  * Buyer-facing surcharge for physical ticket delivery (mail-to-buyer or venue
- * will-call), both fulfilled as individually-addressed Lob postcards — one
+ * will-call), both fulfilled as individually-addressed Lob postcards. One
  * ticket = one piece, same product used by Flyer Blast's addressed mail path.
  *
  * Reuses the Lob per-piece cost table from `lobFlyerUtils.ts` rather than
- * duplicating pricing — same "verify before production" caveat applies here.
+ * duplicating pricing. Same "verify before production" caveat applies here.
  */
 
 import { TicketDeliveryMethod, TicketPrintOrderStatus } from "@prisma/client";
@@ -21,7 +21,7 @@ export function ticketPrintSurchargeCentsPerPiece(size: LobPostcardSizeKey): num
 
 /**
  * Total buyer-facing surcharge (integer cents) for `quantity` physical ticket
- * pieces of the given size — used as the Stripe checkout line item amount.
+ * pieces of the given size. Used as the Stripe checkout line item amount.
  */
 export function ticketPrintSurchargeCentsForQuantity(
   size: LobPostcardSizeKey,
@@ -32,7 +32,7 @@ export function ticketPrintSurchargeCentsForQuantity(
 }
 
 /**
- * Buyer-facing badge copy for a ticket's physical delivery status — shared by
+ * Buyer-facing badge copy for a ticket's physical delivery status. Shared by
  * My Tickets and the ticket details view so both surfaces stay in sync.
  * `null`/`undefined` (Digital) means no badge should render.
  */
@@ -52,7 +52,7 @@ export function ticketDeliveryStatusLabel(
     return "Physical ticket cancelled";
   }
   if (status === TicketPrintOrderStatus.Failed) {
-    return "Physical ticket delivery failed — contact the host";
+    return "Physical ticket delivery failed. Contact the host";
   }
   if (deliveryMethod === TicketDeliveryMethod.VenueWillCall) {
     switch (status) {

package/src/utils/ticketTierSchedule.ts

@@ -1,5 +1,5 @@
 /**
- * Ticket tier release / expiry / sold-out schedule resolver — shared by API + bash-app.
+ * Ticket tier release / expiry / sold-out schedule resolver. Shared by API + bash-app.
  */
 
 import type { TicketTierAvailability } from "../definitions.js";
@@ -138,7 +138,7 @@ export function resolveTicketTierScheduleState(
   const publicAvailableAt = toDate(tier.publicAvailableAt);
   const inventory = ctx.availableInventory;
   const manualSoldOut = tier.isManuallySoldOut === true;
-  /** Only treat as inventory sold-out when callers supply a count — unknown ≠ zero. */
+  /** Only treat as inventory sold-out when callers supply a count. Unknown ≠ zero. */
   const soldOut =
     manualSoldOut || (inventory !== undefined && inventory <= 0);
   const preDisplay = normalizePreReleaseDisplay(tier.preReleaseDisplay);
@@ -357,7 +357,7 @@ export function validateTicketTierScheduleInput(
   if (start && availableAt && availableAt > start) {
     issues.push({
       field: "availableAt",
-      message: "Release is after the event start — double-check the time.",
+      message: "Release is after the event start. Double-check the time.",
       severity: "warn",
     });
   }
@@ -365,7 +365,7 @@ export function validateTicketTierScheduleInput(
   if (start && expiresAt && expiresAt > start) {
     issues.push({
       field: "expiresAt",
-      message: "Tier expires after the event starts — unusual but allowed.",
+      message: "Tier expires after the event starts. Unusual but allowed.",
       severity: "warn",
     });
   }

package/src/utils/trustScoreUtils.ts

@@ -65,7 +65,7 @@ function inverseRate(rate: number): number {
 }
 
 /**
- * Compute a 0–100 trust score from normalized component signals (0–1 each).
+ * Compute a 0 to 100 trust score from normalized component signals (0 to 1 each).
  */
 export function computeTrustScoreFromInputs(
   actorType: TrustScoreActorType,

package/src/utils/urlUtils.ts

@@ -30,7 +30,7 @@ function isLocalDevHostname(hostname: string): boolean {
  * Canonical frontend origin for share links, embeds, QR codes, etc.
  *
  * Browser-hostname-driven (NOT env-var driven) so the answer is correct in any
- * deployed environment — including ones where `process.env.ENVIRONMENT` /
+ * deployed environment. Including ones where `process.env.ENVIRONMENT` /
  * `BASH_ENV` aren't inlined into the bundle (Vite only inlines REACT_APP_* /
  * VITE_* / NODE_ENV / PUBLIC_URL). Previously this depended on `isProduction()`
  * and produced URLs like `https://bash.community:3000/bash/...` in production,
@@ -277,7 +277,7 @@ export function redirectToStripeWithTimeout(
  *
  * Browsers resolve `href="example.com"` as a **relative** URL (under the current path),
  * not `https://example.com`, so bare domains must be prefixed with `https://`.
- * Stores sometimes save Instagram as `@handle` instead of a full URL — those are mapped
+ * Stores sometimes save Instagram as `@handle` instead of a full URL. Those are mapped
  * to `https://www.instagram.com/{handle}/`.
  *
  * @returns `"#"` when the value is empty or unsafe (`javascript:`, `data:`).

package/src/utils/userUtils.ts

@@ -3,7 +3,7 @@ import { Gender, SocialEventCadence } from "@prisma/client";
 export const MAX_USER_NAME_CHANGES = 3 as const;
 
 /**
- * Minimum shape needed by `getDisplayGender` — accepts any object that has the
+ * Minimum shape needed by `getDisplayGender`. Accepts any object that has the
  * two relevant columns (e.g. `User`, `UserExt`, `PublicUser`, or a partial
  * select). The free-text `genderIdentity` is the source of truth for *display*
  * because it is user-self-described and may not map to a `Gender` enum value
@@ -20,7 +20,7 @@ export interface GenderDisplayUser {
  *
  * Precedence:
  *   1. `genderIdentity` (free-text self-description) when present and
- *      non-blank — wins over the enum so the user sees their own words.
+ *      non-blank. Wins over the enum so the user sees their own words.
  *   2. `gender` (enum) when present.
  *   3. `null` when neither is set.
  *
@@ -41,7 +41,7 @@ export function getDisplayGender(user: GenderDisplayUser): string | null {
 }
 
 /**
- * Plain labels for the social event cadence enum — used in Settings, the account
+ * Plain labels for the social event cadence enum. Used in Settings, the account
  * edit forms, and the host CRM filter where clarity beats personality.
  */
 export const SOCIAL_EVENT_CADENCE_LABELS: Record<SocialEventCadence, string> = {
@@ -53,7 +53,7 @@ export const SOCIAL_EVENT_CADENCE_LABELS: Record<SocialEventCadence, string> = {
 };
 
 /**
- * Promoter-voice labels for the public profile — friendlier phrasing of how often
+ * Promoter-voice labels for the public profile. Friendlier phrasing of how often
  * someone likes to go out. Falls back to the plain label when no flourish exists.
  */
 export const SOCIAL_EVENT_CADENCE_PROFILE_LABELS: Record<SocialEventCadence, string> = {

package/src/utils/venueLoyalty/__tests__/eligibilityUtils.test.ts

@@ -1,5 +1,5 @@
 /**
- * Pure eligibility evaluator — same logic runs on API + bash-app, so this
+ * Pure eligibility evaluator. Same logic runs on API + bash-app, so this
  * suite locks the truth table for both call sites.
  */
 import {

package/src/utils/venueLoyalty/__tests__/redemptionCodeUtils.test.ts

@@ -1,6 +1,6 @@
 /**
  * Pin the redemption code alphabet, length, normalization, and uniqueness
- * retry loop. Hosts type these codes from a phone — fat-finger characters
+ * retry loop. Hosts type these codes from a phone. Fat-finger characters
  * (I, O, 0, 1) must never appear.
  */
 import {

package/src/utils/venueLoyalty/redemptionCodeUtils.ts

@@ -5,7 +5,7 @@
  * ambiguous `I`, `O`, `0`, `1` so a host typing the code from a phone screen
  * doesn't fat-finger it. Collisions are scoped per-venue (see the unique
  * constraint on `VenueLoyaltyRedemption(venueId, redemptionCode)`), so the
- * 32^8 ≈ 1.1 trillion keyspace is enormous overkill — the retry loop in
+ * 32^8 ≈ 1.1 trillion keyspace is enormous overkill. The retry loop in
  * `generateUniqueRedemptionCode` exists to be defensive, not because we
  * expect contention.
  */
@@ -23,7 +23,7 @@ export function isValidRedemptionCodeShape(code: string): boolean {
 }
 
 /**
- * Normalize user input — uppercase, strip whitespace + dashes — before
+ * Normalize user input. Uppercase, strip whitespace + dashes. Before
  * validation or DB lookup. Lets us accept "ab12-cd34" from a phone keyboard.
  */
 export function normalizeRedemptionCode(input: string): string {
@@ -45,7 +45,7 @@ export function generateRedemptionCode(
 /**
  * Sample fresh codes until `existsInVenue(code)` returns false. Bounded to
  * `maxAttempts` so a misbehaving uniqueness probe can't spin forever. Throws
- * after exhausting attempts — caller should surface a 5xx, this would mean
+ * after exhausting attempts. Caller should surface a 5xx, this would mean
  * the keyspace is exhausted (impossible in practice) or the DB is unhealthy.
  */
 export async function generateUniqueRedemptionCode(

package/src/venueLoyaltyRedemption.ts

@@ -1,7 +1,7 @@
 /**
  * API shapes for venue loyalty perk offers + redemptions (guest claim / decline
  * / redeem / expire). All BashPoints movements through these flows ledger via
- * `CreditSourceType.VenueLoyaltyRedemption` — see
+ * `CreditSourceType.VenueLoyaltyRedemption`. See
  * `api/src/services/venueLoyaltyRedemptionService.ts`.
  */
 
@@ -179,7 +179,7 @@ export interface ClaimVenueLoyaltyResponse {
   /**
    * Convenience copy of `redemption.redemptionCode` so the success UI can
    * pull it without branching on null. Equals `null` only when the offer was
-   * free (bashPointsCost == null) — currently still issued for traceability.
+   * free (bashPointsCost == null). Currently still issued for traceability.
    */
   code: string;
   remainingBashPoints: number;

package/src/venueMatch.ts

@@ -48,7 +48,7 @@ export const VENUE_SUPPLY_LEAD_STAGES = {
 export type VenueSupplyLeadStage =
   (typeof VENUE_SUPPLY_LEAD_STAGES)[keyof typeof VENUE_SUPPLY_LEAD_STAGES];
 
-/** Admin display labels — single source for the pipeline UI + CSV export. */
+/** Admin display labels. Single source for the pipeline UI + CSV export. */
 export const VenueSupplyLeadStageLabel: Record<VenueSupplyLeadStage, string> = {
   Surfaced: "Surfaced",
   Prioritized: "Hot lead",
@@ -74,10 +74,10 @@ export const VENUE_SUPPLY_LEAD_REP_STAGES: VenueSupplyLeadStage[] = [
 /**
  * Structured intent extracted from the host's prompt + current event fields.
  * Persisted as `VenueMatchRun.intent` (Json column).
- * All fields nullable — the scorer omits weights for missing signals.
+ * All fields nullable. The scorer omits weights for missing signals.
  */
 export interface VenueMatchIntent {
-  /** e.g. "bachelor party", "baby shower" — free text, lowercased */
+  /** e.g. "bachelor party", "baby shower". Free text, lowercased */
   occasion: string | null;
   /** From amountOfGuests.expected or parsed from prompt */
   guestCount: number | null;
@@ -132,7 +132,7 @@ export interface VenueCandidateDisplay {
   capacity: number | null;
   distanceMiles: number | null;
   phone: string | null;
-  /** Marketplace only — deep link target */
+  /** Marketplace only. Deep link target */
   serviceDetailPath: string | null;
 }