@bash-app/bash-common 30.424.0 → 30.427.0

package/src/definitions.ts

@@ -43,11 +43,11 @@ import type { UtmFields } from "./utmAttribution.js";
 
 /**
  * Prisma's `index-browser` bundle (used by Vite in bash-app) omits some enums as runtime
- * values — importing them from `@prisma/client` yields `undefined` and crashes on first
+ * values. Importing them from `@prisma/client` yields `undefined` and crashes on first
  * property access. Incomplete Jest `@prisma/client` mocks hit the same landmine.
  * These mirrors match the Prisma schema / full client enum strings.
  *
- * "Also list as [complementary type]" — a one-time identity-field prefill copy
+ * "Also list as [complementary type]". A one-time identity-field prefill copy
  * (see Service.complementaryOfServiceId), not an ongoing synced link. Scoped to
  * the Vendors <-> EventServices pairing only (e.g. a food truck that vends
  * publicly at festivals and is also paid a flat fee at private weddings).
@@ -62,7 +62,7 @@ export type ComplementaryServiceSourceType = keyof typeof COMPLEMENTARY_SERVICE_
 export function isComplementaryServiceSourceType(
   serviceType: ServiceTypes
 ): serviceType is ComplementaryServiceSourceType {
-  // String compares — avoid ServiceTypes.* enum access (undefined in Vite's
+  // String compares. Avoid ServiceTypes.* enum access (undefined in Vite's
   // @prisma/client index-browser bundle).
   return serviceType === "Vendors" || serviceType === "EventServices";
 }
@@ -78,7 +78,7 @@ export function complementaryServiceTypeFor(
 }
 
 /**
- * Human-readable label for a ServiceTypes value — the raw enum ("EventServices")
+ * Human-readable label for a ServiceTypes value. The raw enum ("EventServices")
  * is not fit for display copy. Only covers the values COMPLEMENTARY_SERVICE_TYPE
  * can produce; extend as more callers need display labels for other types.
  */
@@ -108,7 +108,7 @@ export const ServiceBookingOfferStatus = {
     Expired: "Expired",
 } as const satisfies Record<ServiceBookingOfferStatusEnum, ServiceBookingOfferStatusEnum>;
 
-/** Mirrors Prisma YearsOfExperience — `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
+/** Mirrors Prisma YearsOfExperience. `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
 export const YearsOfExperience = {
     LessThanOneYear: "LessThanOneYear",
     OneToThreeYears: "OneToThreeYears",
@@ -118,7 +118,7 @@ export const YearsOfExperience = {
 
 export type YearsOfExperience = YearsOfExperienceEnum;
 
-/** Mirrors Prisma `GovIdRetentionPolicy` — `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
+/** Mirrors Prisma `GovIdRetentionPolicy`. `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
 export const GovIdRetentionPolicy = {
     ThirtyDays: "ThirtyDays",
     UntilIdExpires: "UntilIdExpires",
@@ -127,7 +127,7 @@ export const GovIdRetentionPolicy = {
 
 export type GovIdRetentionPolicy = GovIdRetentionPolicyEnum;
 
-/** Mirrors Prisma `AgePolicy` — `@prisma/client` browser bundle omits runtime enum exports. */
+/** Mirrors Prisma `AgePolicy`. `@prisma/client` browser bundle omits runtime enum exports. */
 export const AgePolicy = {
   AllAges: "AllAges",
   EighteenPlus: "EighteenPlus",
@@ -152,9 +152,9 @@ export function isIntroIntentId(value: string): value is IntroIntentId {
 }
 
 export const LOCUS_OF_CONTROL_OPTIONS = [
-  { id: "internal", label: "Internal — I shape my own outcomes" },
-  { id: "external", label: "External — circumstances shape outcomes" },
-  { id: "mixed", label: "Mixed — bit of both" },
+  { id: "internal", label: "Internal. I shape my own outcomes" },
+  { id: "external", label: "External. Circumstances shape outcomes" },
+  { id: "mixed", label: "Mixed. Bit of both" },
 ] as const;
 
 export type LocusOfControlId = (typeof LOCUS_OF_CONTROL_OPTIONS)[number]["id"];
@@ -193,7 +193,7 @@ export function personalityOverlapHint(
   b: string | null | undefined
 ): string | null {
   if (!a || !b || !hasSensingIntuitionOverlap(a, b)) return null;
-  return `You both picked ${a[1].toUpperCase()} — good icebreaker.`;
+  return `You both picked ${a[1].toUpperCase()}. Good icebreaker.`;
 }
 
 export function sharedIntroIntentHint(
@@ -228,7 +228,7 @@ export function isInterestExpressionMode(
 }
 
 export const INTROS_DISCLAIMER =
-  "Intros connects you only with people who have also explicitly opted in. Bash does not conduct background checks, verify identities beyond basic account registration, or screen users for any purpose. This feature supports platonic and professional connections only — romantic or sexual contact is a violation of our Community Guidelines. Always meet at the event, in public. Use the Report button if anyone makes you uncomfortable. By turning on Intros, you agree that Bash is not responsible for interactions between users.";
+  "Intros connects you only with people who have also explicitly opted in. Bash does not conduct background checks, verify identities beyond basic account registration, or screen users for any purpose. This feature supports platonic and professional connections only. Romantic or sexual contact is a violation of our Community Guidelines. Always meet at the event, in public. Use the Report button if anyone makes you uncomfortable. By turning on Intros, you agree that Bash is not responsible for interactions between users.";
 
 export const INTROS_DISCLAIMER_SHORT =
   "Bash does not background-check users. Meet at the event, in public. Romantic or sexual contact is prohibited. Bash is not responsible for interactions between users.";
@@ -251,7 +251,7 @@ export const STRIPE_API_TIMEOUT_MS = 15000 as const; // 15 seconds for API calls
 
 /**
  * Bash Ideas: default number of *registered* interests (price willingness + email) to hit auto-publish.
- * That is a “greenlight this concept” bar, not a forecast of door count — capacity and tickets are separate.
+ * That is a “greenlight this concept” bar, not a forecast of door count. Capacity and tickets are separate.
  * Likes and favorites stay out of this meter (cheap signal vs. commitment); revisit weighting after data.
  */
 export const DEFAULT_IDEA_INTEREST_THRESHOLD = 35 as const;
@@ -262,7 +262,7 @@ export const DEFAULT_IDEA_INTEREST_THRESHOLD = 35 as const;
  */
 export const DEFAULT_SHOW_GOING_COUNT_AFTER = 35 as const;
 
-/** Mirrors Prisma `BashPassTier` — `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
+/** Mirrors Prisma `BashPassTier`. `@prisma/client` browser/Jest bundles may omit runtime enum keys. */
 const BashPassTierValues = {
   LITE: "LITE",
   STANDARD: "STANDARD",
@@ -309,7 +309,7 @@ export const TICKET_PURCHASE_TYPE_BASHPOINTS = "BashPoints" as const;
 export const TICKET_PURCHASE_TYPE_FREE = "Free" as const;
 export const TICKET_PURCHASE_TYPE_COMP = "Comp" as const;
 export const TICKET_PURCHASE_TYPE_BASHPASS = "BashPass" as const;
-/** Unpaid reservation — pay at venue (Pay at Door). */
+/** Unpaid reservation. Pay at venue (Pay at Door). */
 export const TICKET_PURCHASE_TYPE_PAY_AT_DOOR = "PayAtDoor" as const;
 /** Cash collected at door (staff-marked). */
 export const TICKET_PURCHASE_TYPE_CASH = "Cash" as const;
@@ -663,7 +663,7 @@ export const BASH_DETAIL_URL_PATTERN = `/bash/$bashEventIdSlug` as const;
 /**
  * Bash event wizard major/substep indices. Must match `AppWizard.Step` /
  * `SubStep` child order in bash-app `BashEventWizard.tsx`. Deep links use
- * these names — do not hardcode `/major/sub` integers.
+ * these names. Do not hardcode `/major/sub` integers.
  */
 export const BASH_EVENT_WIZARD_MAJOR = {
   TEMPLATES: 0,
@@ -768,7 +768,7 @@ export const MAX_NUMBER_OF_TICKETS_PER_REQUEST_FOR_A_BASH_EVENT = 50 as const;
 /** Bash detail: tiers shown before "Show all N ticket options". */
 export const TICKET_TIERS_COLLAPSED_VISIBLE_COUNT = 5 as const;
 
-/** Per-event cap — keeps checkout UX readable and limits tier spam. */
+/** Per-event cap. Keeps checkout UX readable and limits tier spam. */
 export const MAX_TICKET_TIERS_PER_BASH_EVENT = 15 as const;
 
 export const MONTHS_PREVIOUS_THAT_STRIPE_ACCOUNTS_WILL_BE_SEARCHED_BY_EMAIL =
@@ -786,7 +786,7 @@ export const HTTP_CODE_GONE = 410 as const;
 export const ERR_UNAUTHORIZED_REQUEST =
   "Unauthorized to perform requested action. Have you logged in?" as const;
 export const ERR_SESSION_EXPIRED =
-  "Your session has expired — please refresh or log in again." as const;
+  "Your session has expired. Please refresh or log in again." as const;
 
 export const DEFAULT_PRISMA_TTL_SECONDS = 60 as const;
 export const PRISMA_MEDIA_TTL_SECONDS = 60 * 5; // 5 hours
@@ -831,7 +831,7 @@ export type FilterFields = {
   /// of the selected options.
   dietaryOptions: string[];
   /// Income brackets the host selected on `TargetAudience` (plus secondary).
-  /// Marketing / discovery only — same string values as `IncomeRange` enum.
+  /// Marketing / discovery only. Same string values as `IncomeRange` enum.
   incomeRange: string[];
   hasOpenTasks: boolean; // Boolean filter for events with open volunteer tasks
   acceptsBashPoints: boolean; // Boolean filter for events with BashPoints-priced tickets
@@ -857,7 +857,7 @@ export const EMPTY_FILTER_FIELDS: FilterFields = {
   ambashadorOnly: false,
 };
 
-/** Fresh filter state — use for `useState` / reset so nested arrays are not shared. */
+/** Fresh filter state. Use for `useState` / reset so nested arrays are not shared. */
 export function createEmptyFilterFields(): FilterFields {
   return {
     price: [],
@@ -1095,7 +1095,7 @@ export interface TicketTierAvailability {
   interestThreshold?: number; // target, UnlockWhenInterestReached
   ticketsSoldCount?: number; // current count, UnlockWhenTicketsSold
   ticketsSoldThreshold?: number; // target, UnlockWhenTicketsSold
-  isViewerEngaged?: boolean; // EngagedUsersOnly — undefined if not logged in
+  isViewerEngaged?: boolean; // EngagedUsersOnly. Undefined if not logged in
 }
 
 export interface AvailableTicketsForTicketTier {
@@ -1141,13 +1141,13 @@ export interface ApiResult<T, P extends ErrorDataType = ErrorDataType> {
    * (e.g. guest roster `depth`, ticket `refundMode`).
    */
   meta?: Record<string, unknown>;
-  /** PATCH group member / some RSVP endpoints — true when BashPoints RSVP bonus was newly awarded */
+  /** PATCH group member / some RSVP endpoints. True when BashPoints RSVP bonus was newly awarded */
   rsvpBonusAwarded?: boolean;
-  /** POST event task assign — true when volunteer guestlist invite was created */
+  /** POST event task assign. True when volunteer guestlist invite was created */
   addedToGuestlist?: boolean;
-  /** POST event task assign — true when FirstTaskTaken BashPoints were newly awarded */
+  /** POST event task assign. True when FirstTaskTaken BashPoints were newly awarded */
   taskBonusAwarded?: boolean;
-  /** POST /volunteer — true when first service profile bonus was newly awarded */
+  /** POST /volunteer. True when first service profile bonus was newly awarded */
   bonusAwarded?: boolean;
   status?: number;
   token?: string;
@@ -1188,11 +1188,11 @@ export function removeDataFromResult<
 }
 
 /**
- * Ticket Saver (inventory) — single user-facing line for sold-out / capacity during purchase flows.
+ * Ticket Saver (inventory). Single user-facing line for sold-out / capacity during purchase flows.
  * Pair with {@link ApiErrorType.NotEnoughTicketsAvailable} in API results and bash-app checkout.
  */
 export const TICKET_SAVER_USER_MESSAGE_NOT_ENOUGH_TICKETS =
-  "Could not complete purchase — not enough tickets left.";
+  "Could not complete purchase. Not enough tickets left.";
 
 /**
  * Payment succeeded in Stripe but tickets could not be issued (e.g. inventory). Refund was attempted automatically.
@@ -1220,7 +1220,7 @@ export enum ApiErrorType {
   payment_intent_creation_failed,
   /** Host requires waiver / custom terms; buyer did not attest acceptance */
   EventWaiverNotAccepted,
-  /** Bash is not Published/PreSale — ticket purchase and checkout creation are blocked */
+  /** Bash is not Published/PreSale. Ticket purchase and checkout creation are blocked */
   EventNotAcceptingPurchases,
 }
 
@@ -1278,7 +1278,7 @@ export interface StripeCreateBashEventTicketsCheckoutSessionArgs extends UtmFiel
   ticketListStr: string;
   promoCode?: string;
   
-  // Named ticket assignment — optional per-ticket attendee info
+  // Named ticket assignment. Optional per-ticket attendee info
   attendeeAssignments?: Array<{ fullName?: string; userId?: string; email?: string }>;
 
   // Mixed cart support (BashPoints + USD tickets)
@@ -1291,7 +1291,7 @@ export interface StripeCreateBashEventTicketsCheckoutSessionArgs extends UtmFiel
   // Attribution ref from URL (referral code or userId) - backend resolves to referrerId
   attributionRef?: string;
 
-  /** Required when the event has `waiverRequired` — buyer attested to host waiver/terms */
+  /** Required when the event has `waiverRequired`. Buyer attested to host waiver/terms */
   waiverAccepted?: boolean;
 
   /** EventGroup id when purchasing a group package for the crew */
@@ -1318,7 +1318,7 @@ export interface StripeCreateBashEventDonationCheckoutSessionArgs extends UtmFie
   currency: string;
   paymentMethodType: string;
   donationAmount: number;
-  /** Required for guest (unauthenticated) donation checkout — Stripe collects payment; we persist receipt to this email. */
+  /** Required for guest (unauthenticated) donation checkout. Stripe collects payment; we persist receipt to this email. */
   guestEmail?: string;
   guestFirstName?: string;
   guestLastName?: string;
@@ -1418,7 +1418,7 @@ export type StripeLinkingStatus = {
   hasOutstandingRequirements: boolean;
   paymentsEnabled: boolean;
   taxMonitoringEnabled: boolean;
-  /** Host account missing business_type or MCC — blocks Cash App eligibility. */
+  /** Host account missing business_type or MCC. Blocks Cash App eligibility. */
   missingBusinessProfileForCashApp?: boolean;
   cardPaymentsActive?: boolean;
   klarnaPaymentsActive?: boolean;
@@ -1543,7 +1543,7 @@ export { BracketType, ServiceBookingSettlementStatusLabel } from "./mirroredPris
 // Pattern matches BracketType in mirroredPrismaEnums.ts.
 
 /**
- * Mirrors Prisma `CompetitionPurpose` — distinguishes consumer contests
+ * Mirrors Prisma `CompetitionPurpose`. Distinguishes consumer contests
  * (vote/bracket/raffle) from ticket-sales promoter races.
  */
 export const CompetitionPurpose = {
@@ -1553,7 +1553,7 @@ export const CompetitionPurpose = {
 export type CompetitionPurpose = (typeof CompetitionPurpose)[keyof typeof CompetitionPurpose];
 
 /**
- * Mirrors Prisma `PromoterRewardMode` — how milestone rewards are calculated
+ * Mirrors Prisma `PromoterRewardMode`. How milestone rewards are calculated
  * in a PROMOTER competition.
  */
 export const PromoterRewardMode = {
@@ -1563,7 +1563,7 @@ export const PromoterRewardMode = {
 export type PromoterRewardMode = (typeof PromoterRewardMode)[keyof typeof PromoterRewardMode];
 
 /**
- * Mirrors Prisma `PromoterRecruitMode` — who can enroll as a promoter.
+ * Mirrors Prisma `PromoterRecruitMode`. Who can enroll as a promoter.
  */
 export const PromoterRecruitMode = {
   Public: "Public",
@@ -1573,7 +1573,7 @@ export const PromoterRecruitMode = {
 export type PromoterRecruitMode = (typeof PromoterRecruitMode)[keyof typeof PromoterRecruitMode];
 
 /**
- * Mirrors Prisma `PromoterRewardType` — category of reward a promoter can earn.
+ * Mirrors Prisma `PromoterRewardType`. Category of reward a promoter can earn.
  */
 export const PromoterRewardType = {
   CASH: "CASH",
@@ -1589,7 +1589,7 @@ export const PromoterRewardType = {
 export type PromoterRewardType = (typeof PromoterRewardType)[keyof typeof PromoterRewardType];
 
 /**
- * Mirrors Prisma `PromoterRewardStatus` — lifecycle state of a single earned reward.
+ * Mirrors Prisma `PromoterRewardStatus`. Lifecycle state of a single earned reward.
  */
 export const PromoterRewardStatus = {
   PENDING: "PENDING",
@@ -1599,7 +1599,7 @@ export const PromoterRewardStatus = {
 } as const;
 export type PromoterRewardStatus = (typeof PromoterRewardStatus)[keyof typeof PromoterRewardStatus];
 
-// Re-exported for backward compatibility during migration — see serviceTypeLabels.ts/targetAudienceLabels.ts
+// Re-exported for backward compatibility during migration. See serviceTypeLabels.ts/targetAudienceLabels.ts
 // for the canonical, consolidated source (following the BracketType precedent above).
 export { SERVICE_TYPE_LABELS } from "./serviceTypeLabels.js";
 export {
@@ -1859,8 +1859,8 @@ export const BashEventTypeToString: BashEventTypeToStringType = {
 
 /**
  * Positive-framed dietary accommodations a host can advertise on a bash and
- * guests can filter by on the homepage. Labels are intentionally upbeat —
- * "options available" rather than "free of" — and stay short enough for tag
+ * guests can filter by on the homepage. Labels are intentionally upbeat.
+ * "options available" rather than "free of". And stay short enough for tag
  * chips. See `DietaryOption` in `prisma/schema.prisma` for the canonical list.
  */
 export type DietaryOptionToStringType = {
@@ -1911,7 +1911,7 @@ export const DIETARY_OPTION_VALUES: ReadonlyArray<DietaryOption> = [
 ];
 
 /**
- * Guest-facing filter chips — everyday accommodations only.
+ * Guest-facing filter chips. Everyday accommodations only.
  * Religious, drink, and diet-trend tags stay on the host form / enum
  * so existing events keep their data, but they do not crowd the filter menu.
  */
@@ -2643,7 +2643,7 @@ export const DEFAULT_TEMPORARY_BADGES: Record<string, TemporaryBadge> = {
   firstBatchOwner: {
     id: "firstBatchOwner",
     name: "Bash First Batch Owner",
-    description: "Owns a Bash PowerPack 300 Founder's Edition — First Batch.",
+    description: "Owns a Bash PowerPack 300 Founder's Edition. First Batch.",
     imageUrl: "/badges/first-batch-owner.png",
     category: BadgeCategory.Special,
     isActive: true,

package/src/discoveryScope.ts

@@ -1,6 +1,6 @@
 /**
  * Geographic / importance scope for public discovery.
- * Orthogonal to `BashEventType` — a Fair can be Local or State.
+ * Orthogonal to `BashEventType`. A Fair can be Local or State.
  */
 
 export const DiscoveryScope = {
@@ -83,7 +83,7 @@ export function isNationalOrInternational(scope: DiscoveryScope): boolean {
 
 /**
  * Known touring / destination brands that are a hard signal for National.
- * Small allowlist — not a taxonomy.
+ * Small allowlist. Not a taxonomy.
  */
 export const NATIONAL_SCOPE_BRAND_PATTERN =
   /\b(insomniac|c3 presents|aeg presents|live nation|coachella|lollapalooza|bonnaroo|ultra miami|edc las vegas|edc vegas|burning man|sxsw|comic-?con|ces\b|super bowl|final four|wrestlemania)\b/i;

package/src/entertainmentNotableVenues.ts

@@ -132,6 +132,6 @@ export function formatNotableVenueEntryLine(
 ): string {
   const reasons = formatNotableVenueReasons(entry);
   const favorite = entry.isFavorite ? " ★" : "";
-  if (reasons) return `${entry.name}${favorite} — ${reasons}`;
+  if (reasons) return `${entry.name}${favorite}. ${reasons}`;
   return `${entry.name}${favorite}`;
 }