@bananapus/core-v6 0.0.15 → 0.0.17

package/test/PermissionEscalation.t.sol

@@ -1,7 +1,20 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBPermissions} from "../src/JBPermissions.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBPermissionsData} from "../src/structs/JBPermissionsData.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 
 /// @notice Tests for permission system correctness: ROOT restrictions, wildcard, boundary IDs, escalation prevention.
@@ -38,6 +51,7 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         jbPermissions()
             .setPermissionsFor(
                 projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 JBPermissionsData({operator: alice, projectId: uint64(projectId2), permissionIds: rootPerms})
             );
     }
@@ -175,13 +189,17 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
                 JBPermissions.JBPermissions_Unauthorized.selector,
                 projectOwner,
                 alice,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 uint64(projectId2),
                 JBPermissionIds.ROOT
             )
         );
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
     }
 
@@ -197,7 +215,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(alice);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
 
         // Verify Bob now has CASH_OUT_TOKENS
@@ -263,7 +284,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
 
         // Verify Bob has it
@@ -287,6 +311,7 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         jbPermissions()
             .setPermissionsFor(
                 projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: emptyPerms})
             );
 
@@ -317,7 +342,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
 
         bool hasPerm = jbPermissions()
@@ -357,7 +385,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.expectRevert(abi.encodeWithSelector(JBPermissions.JBPermissions_NoZeroPermission.selector));
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
     }
 
@@ -468,7 +499,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(pid), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(pid), permissionIds: perms})
             );
 
         // Charlie (no permission) tries to send payouts — should fail because ownerMustSendPayouts
@@ -539,7 +573,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms1})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms1})
             );
 
         assertTrue(
@@ -574,7 +611,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms2})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms2})
             );
 
         // Bob should only have MINT_TOKENS, not the previous ones
@@ -628,7 +668,10 @@ contract PermissionEscalation_Local is TestBaseWorkflow {
         vm.prank(projectOwner);
         jbPermissions()
             .setPermissionsFor(
-                projectOwner, JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
+                // forge-lint: disable-next-line(unsafe-typecast)
+                projectOwner,
+                // forge-lint: disable-next-line(unsafe-typecast)
+                JBPermissionsData({operator: bob, projectId: uint64(projectId2), permissionIds: perms})
             );
 
         // Call from trusted forwarder with Bob appended as sender

package/test/RulesetTransitions.t.sol

@@ -1,7 +1,18 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 import {ERC165, IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
@@ -255,6 +266,7 @@ contract RulesetTransitions_Local is TestBaseWorkflow {
         uint256[] memory tokensPerCycle = new uint256[](10);
         for (uint256 i = 0; i < 10; i++) {
             if (i > 0) vm.warp(block.timestamp + 1 days + 1);
+            // forge-lint: disable-next-line(unsafe-typecast)
             tokensPerCycle[i] = _payProject(pid, address(uint160(0x6000 + i)), 1 ether);
         }
 
@@ -660,6 +672,7 @@ contract RulesetTransitions_Local is TestBaseWorkflow {
 
 /// @notice Approval hook that approves after a configurable delay.
 contract DelayedApprovalHook is ERC165, IJBRulesetApprovalHook {
+    // forge-lint: disable-next-line(screaming-snake-case-immutable)
     uint256 public immutable approvalDelay;
 
     constructor(uint256 _approvalDelay) {
@@ -685,6 +698,7 @@ contract DelayedApprovalHook is ERC165, IJBRulesetApprovalHook {
 
 /// @notice Approval hook that always rejects.
 contract AlwaysRejectingHook is ERC165, IJBRulesetApprovalHook {
+    // forge-lint: disable-next-line(mixed-case-function)
     function DURATION() external pure override returns (uint256) {
         return 0;
     }

package/test/SplitLoopTests.t.sol

@@ -1,7 +1,22 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../src/interfaces/IJBSplitHook.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBSplitHookContext} from "../src/structs/JBSplitHookContext.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 import {ERC165, IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
@@ -120,7 +135,8 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
 
         JBCurrencyAmount[] memory payoutLimits = new JBCurrencyAmount[](1);
         payoutLimits[0] =
-            JBCurrencyAmount({amount: uint224(payoutLimit), currency: uint32(uint160(JBConstants.NATIVE_TOKEN))});
+        // forge-lint: disable-next-line(unsafe-typecast)
+        JBCurrencyAmount({amount: uint224(payoutLimit), currency: uint32(uint160(JBConstants.NATIVE_TOKEN))});
         JBFundAccessLimitGroup[] memory fundAccessLimitGroups = new JBFundAccessLimitGroup[](1);
         fundAccessLimitGroups[0] = JBFundAccessLimitGroup({
             terminal: address(jbMultiTerminal()),
@@ -186,12 +202,14 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
         projectA = _launchProjectWithSplitsAndPayoutLimit(dummySplits, 10 ether);
 
         // Now create B with split to A
+        // forge-lint: disable-next-line(unsafe-typecast)
         splitsB[0].projectId = uint64(projectA);
         projectB = _launchProjectWithSplitsAndPayoutLimit(splitsB, 10 ether);
 
         // Update A's splits to point to B
         (JBRuleset memory rulesetA,) = jbController().currentRulesetOf(projectA);
         JBSplitGroup[] memory newSplitGroupsA = new JBSplitGroup[](1);
+        // forge-lint: disable-next-line(unsafe-typecast)
         splitsA[0].projectId = uint64(projectB);
         newSplitGroupsA[0] = JBSplitGroup({groupId: uint256(uint160(JBConstants.NATIVE_TOKEN)), splits: splitsA});
         vm.prank(projectOwner);
@@ -372,6 +390,7 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
         uint256 pid = _launchProjectWithSplitsAndPayoutLimit(new JBSplit[](0), 10 ether);
 
         // Update splits to point to self
+        // forge-lint: disable-next-line(unsafe-typecast)
         splits[0].projectId = uint64(pid);
         (JBRuleset memory ruleset,) = jbController().currentRulesetOf(pid);
         JBSplitGroup[] memory newSplitGroups = new JBSplitGroup[](1);
@@ -404,12 +423,14 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
         uint256 numSplits = 200;
         JBSplit[] memory splits = new JBSplit[](numSplits);
 
+        // forge-lint: disable-next-line(unsafe-typecast)
         uint32 perSplitPercent = uint32(JBConstants.SPLITS_TOTAL_PERCENT / numSplits);
 
         for (uint256 i = 0; i < numSplits; i++) {
             splits[i] = JBSplit({
                 percent: perSplitPercent,
                 projectId: 0,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 beneficiary: payable(address(uint160(0x3000 + i))),
                 preferAddToBalance: false,
                 lockedUntil: 0,
@@ -452,6 +473,7 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
             splits[i] = JBSplit({
                 percent: oneThird,
                 projectId: 0,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 beneficiary: payable(address(uint160(0x4000 + i))),
                 preferAddToBalance: false,
                 lockedUntil: 0,
@@ -476,6 +498,7 @@ contract SplitLoopTests_Local is TestBaseWorkflow {
         // Check no rounding loss greater than 3 wei (one per split)
         uint256 totalPaidToSplits = 0;
         for (uint256 i = 0; i < 3; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             totalPaidToSplits += address(uint160(0x4000 + i)).balance;
         }
 

package/test/TestAccessToFunds.sol

@@ -1,8 +1,23 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
-import "@openzeppelin/contracts/utils/Address.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {MockERC20} from "./mock/MockERC20.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBPrices} from "../src/interfaces/IJBPrices.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 import {MockPriceFeed} from "./mock/MockPriceFeed.sol";
 import {MaliciousAllowanceBeneficiary, MaliciousPayoutBeneficiary} from "./mock/MockMaliciousBeneficiary.sol";