@bananapus/core-v6 0.0.15 → 0.0.17

package/test/TestRulesetQueuingStress.sol

@@ -1,7 +1,20 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBDeadline} from "../src/JBDeadline.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /// @notice Mock approval hook that always returns a configurable status.
 contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
@@ -350,6 +363,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     FOURTEEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))
@@ -544,6 +558,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
 
             _queueRuleset(
                 pid,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 uint48(originalStart + SEVEN_DAYS),
                 SEVEN_DAYS,
                 INITIAL_WEIGHT * 2,
@@ -563,6 +578,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
             // 1 second after first boundary -> should snap to second boundary.
             _queueRuleset(
                 pid,
+                // forge-lint: disable-next-line(unsafe-typecast)
                 uint48(originalStart + SEVEN_DAYS + 1),
                 SEVEN_DAYS,
                 INITIAL_WEIGHT * 2,
@@ -599,6 +615,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     SEVEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))
@@ -608,6 +625,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                 JBRuleset memory current = _rulesets.currentOf(pid);
                 assertEq(
                     current.weight,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     INITIAL_WEIGHT + uint112(i) * 100e18,
                     string.concat("Cycle ", vm.toString(i + 1), " weight mismatch")
                 );
@@ -765,6 +783,7 @@ contract MockApprovalHookConfigurable is IJBRulesetApprovalHook {
                     pid,
                     0,
                     SEVEN_DAYS,
+                    // forge-lint: disable-next-line(unsafe-typecast)
                     uint112(INITIAL_WEIGHT + uint112(i) * 100e18),
                     0,
                     IJBRulesetApprovalHook(address(0))

package/test/TestRulesetWeightCaching.sol

@@ -1,7 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 // A ruleset's weight can be cached to make larger intervals calculable while staying within the gas limit.
 contract TestRulesetWeightCaching_Local is TestBaseWorkflow {
@@ -47,130 +57,122 @@ contract TestRulesetWeightCaching_Local is TestBaseWorkflow {
     }
 
     /// Test that caching a ruleset's weight yields the same result as computing it.
+    /// @dev Bounded to 1,000 rulesets for CI speed. For full coverage (80,000), run:
+    ///      forge test --match-test testWeightCaching -vvv --fuzz-runs 8
     function testWeightCaching(uint256 _rulesetDiff) public {
-        // TODO temporarily removed for faster test suite
-        // // Bound to 8x the weight cut multiple cache threshold.
-        // _rulesetDiff = bound(_rulesetDiff, 0, 80000);
-
-        // // Keep references to the projects.
-        // uint256 _projectId1;
-        // uint256 _projectId2;
-
-        // // Package up the ruleset configuration.
-        // JBRulesetConfig[] memory _rulesetConfigurations = new JBRulesetConfig[](1);
-
-        // {
-        //     _rulesetConfigurations[0].mustStartAtOrAfter = 0;
-        //     _rulesetConfigurations[0].duration = _DURATION;
-        //     _rulesetConfigurations[0].weight = 1000 * 10 ** _WEIGHT_DECIMALS;
-        //     _rulesetConfigurations[0].weightCutPercent = _WEIGHT_CUT_PERCENT;
-        //     _rulesetConfigurations[0].approvalHook = IJBRulesetApprovalHook(address(0));
-        //     _rulesetConfigurations[0].metadata = _metadata;
-        //     _rulesetConfigurations[0].splitGroups = new JBSplitGroup[](0);
-        //     _rulesetConfigurations[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
-
-        //     // Create the project to test.
-        //     _projectId1 = _controller.launchProjectFor({
-        //         owner: _projectOwner,
-        //         projectUri: "myIPFSHash",
-        //         rulesetConfigurations: _rulesetConfigurations,
-        //         terminalConfigurations: new JBTerminalConfig[](0),
-        //         memo: ""
-        //     });
-
-        //     // Create the project to test.
-        //     _projectId2 = _controller.launchProjectFor({
-        //         owner: _projectOwner,
-        //         projectUri: "myIPFSHash",
-        //         rulesetConfigurations: _rulesetConfigurations,
-        //         terminalConfigurations: new JBTerminalConfig[](0),
-        //         memo: ""
-        //     });
-        // }
-
-        // // Keep a reference to the current rulesets.
-        // JBRuleset memory _ruleset1 = jbRulesets().currentOf(_projectId1);
-        // JBRuleset memory _ruleset2 = jbRulesets().currentOf(_projectId2);
-
-        // // Go a few rolled over rulesets into the future.
-        // vm.warp(block.timestamp + (_DURATION * 10));
-
-        // // Keep a reference to the amount of gas before the caching call.
-        // uint256 _gasBeforeCache = gasleft();
-
-        // // Cache the weight in the second project.
-        // _rulesets.updateRulesetWeightCache(_projectId2);
-
-        // // Keep a reference to the amout of gas spent on the call.
-        // uint256 _gasDiffCache = _gasBeforeCache - gasleft();
-
-        // // Make sure the difference is within the gas limit.
-        // assertLe(_gasDiffCache, _GAS_LIMIT);
-
-        // // Go many rolled over rulesets into the future.
-        // vm.warp(block.timestamp + (_DURATION * _rulesetDiff));
-
-        // // Cache the weight in the second project again.
-        // _rulesets.updateRulesetWeightCache(_projectId2);
-
-        // // Inherit the weight.
-        // _rulesetConfigurations[0].data.weight = 0;
-
-        // // Keep a reference to the amount of gas before the call.
-        // uint256 _gasBefore1 = gasleft();
-
-        // // Queue the ruleset.
-        // vm.startPrank(_projectOwner);
-        // _controller.queueRulesetsOf({
-        //     projectId: _projectId1,
-        //     rulesetConfigurations: _rulesetConfigurations,
-        //     memo: ""
-        // });
-
-        // // Keep a reference to the amout of gas spent on the call.
-        // uint256 _gasDiff1 = _gasBefore1 - gasleft();
-
-        // // Make sure the difference is within the gas limit.
-        // assertLe(_gasDiff1, _GAS_LIMIT);
-
-        // // Keep a reference to the amount of gas before the call.
-        // uint256 _gasBefore2 = gasleft();
-
-        // _controller.queueRulesetsOf({
-        //     projectId: _projectId2,
-        //     rulesetConfigurations: _rulesetConfigurations,
-        //     memo: ""
-        // });
-        // vm.stopPrank();
-
-        // // Keep a reference to the amout of gas spent on the call.
-        // uint256 _gasDiff2 = _gasBefore2 - gasleft();
-
-        // // Make sure the difference is within the gas limit.
-        // assertLe(_gasDiff2, _GAS_LIMIT);
-
-        // // Renew the reference to the current ruleset.
-        // _ruleset1 = jbRulesets().currentOf(_projectId1);
-        // _ruleset2 = jbRulesets().currentOf(_projectId2);
-
-        // // The cached call should have been cheaper.
-        // assertLe(_gasDiff2, _gasDiff1);
-
-        // // Make sure the rulesets have the same weight.
-        // assertEq(_ruleset1.weight, _ruleset2.weight);
-
-        // // Cache the weight in the second project again.
-        // _rulesets.updateRulesetWeightCache(_projectId2);
-
-        // // Go many rolled over rulesets into the future.
-        // vm.warp(block.timestamp + (_DURATION * _rulesetDiff));
-
-        // // Queue the ruleset.
-        // vm.prank(_projectOwner);
-        // _controller.queueRulesetsOf({
-        //     projectId: _projectId2,
-        //     rulesetConfigurations: _rulesetConfigurations,
-        //     memo: ""
-        // });
+        // Bound to a CI-friendly range. The cache threshold is 20,000 iterations;
+        // 1,000 is enough to exercise the caching path without extreme gas usage.
+        _rulesetDiff = bound(_rulesetDiff, 0, 1000);
+
+        // Keep references to the projects.
+        uint256 _projectId1;
+        uint256 _projectId2;
+
+        // Package up the ruleset configuration.
+        JBRulesetConfig[] memory _rulesetConfigurations = new JBRulesetConfig[](1);
+
+        {
+            _rulesetConfigurations[0].mustStartAtOrAfter = 0;
+            // forge-lint: disable-next-line(unsafe-typecast)
+            _rulesetConfigurations[0].duration = uint32(_DURATION); // safe: _DURATION = 1
+            _rulesetConfigurations[0].weight = uint112(1000 * 10 ** _WEIGHT_DECIMALS);
+            // forge-lint: disable-next-line(unsafe-typecast)
+            _rulesetConfigurations[0].weightCutPercent = uint32(_WEIGHT_CUT_PERCENT); // safe: _WEIGHT_CUT_PERCENT = 1
+            _rulesetConfigurations[0].approvalHook = IJBRulesetApprovalHook(address(0));
+            _rulesetConfigurations[0].metadata = _metadata;
+            _rulesetConfigurations[0].splitGroups = new JBSplitGroup[](0);
+            _rulesetConfigurations[0].fundAccessLimitGroups = new JBFundAccessLimitGroup[](0);
+
+            // Create the project to test.
+            _projectId1 = _controller.launchProjectFor({
+                owner: _projectOwner,
+                projectUri: "myIPFSHash",
+                rulesetConfigurations: _rulesetConfigurations,
+                terminalConfigurations: new JBTerminalConfig[](0),
+                memo: ""
+            });
+
+            // Create the project to test.
+            _projectId2 = _controller.launchProjectFor({
+                owner: _projectOwner,
+                projectUri: "myIPFSHash",
+                rulesetConfigurations: _rulesetConfigurations,
+                terminalConfigurations: new JBTerminalConfig[](0),
+                memo: ""
+            });
+        }
+
+        // Keep a reference to the current rulesets.
+        JBRuleset memory _ruleset1 = jbRulesets().currentOf(_projectId1);
+        JBRuleset memory _ruleset2 = jbRulesets().currentOf(_projectId2);
+
+        // Go a few rolled over rulesets into the future.
+        vm.warp(block.timestamp + (_DURATION * 10));
+
+        // Keep a reference to the amount of gas before the caching call.
+        uint256 _gasBeforeCache = gasleft();
+
+        // Cache the weight in the second project using the latest ruleset ID.
+        _rulesets.updateRulesetWeightCache(_projectId2, _rulesets.latestRulesetIdOf(_projectId2));
+
+        // Keep a reference to the amount of gas spent on the call.
+        uint256 _gasDiffCache = _gasBeforeCache - gasleft();
+
+        // Make sure the difference is within the gas limit.
+        assertLe(_gasDiffCache, _GAS_LIMIT);
+
+        // Go many rolled over rulesets into the future.
+        vm.warp(block.timestamp + (_DURATION * _rulesetDiff));
+
+        // Cache the weight in the second project again.
+        _rulesets.updateRulesetWeightCache(_projectId2, _rulesets.latestRulesetIdOf(_projectId2));
+
+        // Inherit the weight (weight=1 is the inherit sentinel in the current API).
+        _rulesetConfigurations[0].weight = 1;
+
+        // Keep a reference to the amount of gas before the call.
+        uint256 _gasBefore1 = gasleft();
+
+        // Queue the ruleset.
+        vm.startPrank(_projectOwner);
+        _controller.queueRulesetsOf({projectId: _projectId1, rulesetConfigurations: _rulesetConfigurations, memo: ""});
+
+        // Keep a reference to the amount of gas spent on the call.
+        uint256 _gasDiff1 = _gasBefore1 - gasleft();
+
+        // Make sure the difference is within the gas limit.
+        assertLe(_gasDiff1, _GAS_LIMIT);
+
+        // Keep a reference to the amount of gas before the call.
+        uint256 _gasBefore2 = gasleft();
+
+        _controller.queueRulesetsOf({projectId: _projectId2, rulesetConfigurations: _rulesetConfigurations, memo: ""});
+        vm.stopPrank();
+
+        // Keep a reference to the amount of gas spent on the call.
+        uint256 _gasDiff2 = _gasBefore2 - gasleft();
+
+        // Make sure the difference is within the gas limit.
+        assertLe(_gasDiff2, _GAS_LIMIT);
+
+        // Renew the reference to the current ruleset.
+        _ruleset1 = jbRulesets().currentOf(_projectId1);
+        _ruleset2 = jbRulesets().currentOf(_projectId2);
+
+        // The cached call should have been cheaper.
+        assertLe(_gasDiff2, _gasDiff1);
+
+        // Make sure the rulesets have the same weight.
+        assertEq(_ruleset1.weight, _ruleset2.weight);
+
+        // Cache the weight in the second project again.
+        _rulesets.updateRulesetWeightCache(_projectId2, _rulesets.latestRulesetIdOf(_projectId2));
+
+        // Go many rolled over rulesets into the future.
+        vm.warp(block.timestamp + (_DURATION * _rulesetDiff));
+
+        // Queue the ruleset.
+        vm.prank(_projectOwner);
+        _controller.queueRulesetsOf({projectId: _projectId2, rulesetConfigurations: _rulesetConfigurations, memo: ""});
     }
 }

package/test/TestSplits.sol

@@ -1,7 +1,27 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../src/interfaces/IJBDirectory.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../src/interfaces/IJBSplitHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBSplitGroupIds} from "../src/libraries/JBSplitGroupIds.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC20Metadata} from "@openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 
 contract TestSplits_Local is TestBaseWorkflow {
     IJBController private _controller;
@@ -304,6 +324,7 @@ contract TestSplits_Local is TestBaseWorkflow {
         // Set up a payout split recipient.
         _splits[0] = JBSplit({
             preferAddToBalance: false,
+            // forge-lint: disable-next-line(unsafe-typecast)
             percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT / _multiplier),
             projectId: 0,
             beneficiary: _splitsGuy,
@@ -314,6 +335,7 @@ contract TestSplits_Local is TestBaseWorkflow {
         // A dummy used to check that splits groups of "0" don't bypass payout limits.
         _splits[1] = JBSplit({
             preferAddToBalance: false,
+            // forge-lint: disable-next-line(unsafe-typecast)
             percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT / _multiplier),
             projectId: 0,
             beneficiary: _splitsGuy,

package/test/TestTerminalMigration.sol

@@ -1,7 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 /// @notice E2E test: Pay into terminal A -> migrate to terminal B -> verify balances, surplus, cash outs.
 contract TestTerminalMigration_Local is TestBaseWorkflow {

package/test/TestTokenFlow.sol

@@ -1,7 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBController} from "../src/JBController.sol";
+import {JBERC20} from "../src/JBERC20.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBToken} from "../src/interfaces/IJBToken.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {Clones} from "@openzeppelin/contracts/proxy/Clones.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
 
 // Launch project, issue token or set the token, mint token, burn token.
 contract TestTokenFlow_Local is TestBaseWorkflow {

package/test/TestWeightCacheStaleAfterRejection.sol

@@ -1,10 +1,24 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBApprovalStatus} from "../src/enums/JBApprovalStatus.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /// @notice Mock approval hook that ALWAYS rejects queued rulesets.
 contract AlwaysRejectApprovalHook is IJBRulesetApprovalHook {
+    // forge-lint: disable-next-line(mixed-case-function)
     function DURATION() external pure override returns (uint256) {
         return 0;
     }

package/test/WeirdTokenTests.t.sol

@@ -1,7 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBSplitHook} from "../src/interfaces/IJBSplitHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
 import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 
@@ -92,6 +104,7 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
         rulesetConfig[0].metadata = JBRulesetMetadata({
             reservedPercent: 0,
             cashOutTaxRate: 0,
+            // forge-lint: disable-next-line(unsafe-typecast)
             baseCurrency: uint32(uint160(token)),
             pausePay: false,
             pauseCreditTransfers: false,
@@ -115,6 +128,7 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
 
         JBTerminalConfig[] memory terminalConfigurations = new JBTerminalConfig[](1);
         JBAccountingContext[] memory tokensToAccept = new JBAccountingContext[](1);
+        // forge-lint: disable-next-line(unsafe-typecast)
         tokensToAccept[0] = JBAccountingContext({token: token, decimals: decimals, currency: uint32(uint160(token))});
         terminalConfigurations[0] =
             JBTerminalConfig({terminal: jbMultiTerminal(), accountingContextsToAccept: tokensToAccept});
@@ -161,6 +175,14 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
         // 1% fee: 1000e18 * 99/100 = 990e18
         uint256 expectedDelta = 990e18;
         assertEq(recordedBalance, expectedDelta, "Terminal should record delta amount for FOT tokens");
+
+        // INVARIANT: recorded balance <= actual token balance at all times.
+        uint256 actualTerminalBalance = fotToken.balanceOf(address(jbMultiTerminal()));
+        assertLe(
+            recordedBalance,
+            actualTerminalBalance,
+            "FOT: recorded balance must not exceed actual terminal token balance after pay"
+        );
     }
 
     // ═══════════════════════════════════════════════════════════════════
@@ -209,6 +231,16 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
 
         // Beneficiary receives less than reclaimAmount due to outbound fee
         assertLt(actualReceived, reclaimAmount, "FOT: beneficiary receives less than reclaimAmount on outbound");
+
+        // INVARIANT: recorded balance <= actual token balance after cash-out.
+        uint256 recordedBalanceAfterCashOut =
+            jbTerminalStore().balanceOf(address(jbMultiTerminal()), pid, address(fotToken));
+        uint256 actualTerminalBalanceAfterCashOut = fotToken.balanceOf(address(jbMultiTerminal()));
+        assertLe(
+            recordedBalanceAfterCashOut,
+            actualTerminalBalanceAfterCashOut,
+            "FOT: recorded balance must not exceed actual terminal token balance after cash-out"
+        );
     }
 
     // ═══════════════════════════════════════════════════════════════════
@@ -322,6 +354,17 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
         assertTrue(actualReceived > 0, "Split beneficiary should receive something");
         // The terminal sends a computed net amount, but the FOT tax reduces what arrives
         // This documents the information finding: FOT tokens cause split recipients to receive less
+
+        // INVARIANT: Terminal's recorded balance must never exceed actual token balance.
+        // With FOT tokens, the terminal may hold fewer tokens than recorded (inbound fee on pay).
+        // After a payout, the recorded balance should still be <= actual balance.
+        uint256 recordedBalance = jbTerminalStore().balanceOf(address(jbMultiTerminal()), pid, address(fotToken));
+        uint256 actualTerminalBalance = fotToken.balanceOf(address(jbMultiTerminal()));
+        assertLe(
+            recordedBalance,
+            actualTerminalBalance,
+            "FOT: recorded balance must not exceed actual terminal token balance after payout"
+        );
     }
 
     // ═══════════════════════════════════════════════════════════════════
@@ -560,6 +603,14 @@ contract WeirdTokenTests_Local is TestBaseWorkflow {
 
         // Balance should increase (delta accounting handles the fee)
         assertGt(recordedAfter, recordedBefore, "Balance should increase with addToBalance");
+
+        // INVARIANT: recorded balance <= actual token balance after addToBalance.
+        uint256 actualTerminalBalance = fotToken.balanceOf(address(jbMultiTerminal()));
+        assertLe(
+            recordedAfter,
+            actualTerminalBalance,
+            "FOT: recorded balance must not exceed actual terminal token balance after addToBalance"
+        );
     }
 
     // ═══════════════════════════════════════════════════════════════════
@@ -676,9 +727,11 @@ contract RebasingToken is ERC20 {
     function rebaseHolder(address target, int256 percent) external {
         uint256 balance = balanceOf(target);
         if (percent > 0) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             uint256 increase = (balance * uint256(percent)) / 100;
             _mint(target, increase);
         } else if (percent < 0) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             uint256 decrease = (balance * uint256(-percent)) / 100;
             if (decrease > 0 && decrease <= balance) {
                 _burn(target, decrease);

package/test/fork/TestChainlinkPriceFeedFork.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 
 import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";
 
@@ -68,6 +68,7 @@ contract TestChainlinkPriceFeedFork is Test {
         // Cross-check against raw latestRoundData.
         (, int256 rawPrice,,,) = AggregatorV3Interface(ETH_USD_FEED).latestRoundData();
         uint256 feedDecimals = AggregatorV3Interface(ETH_USD_FEED).decimals();
+        // forge-lint: disable-next-line(unsafe-typecast)
         uint256 expected18 = uint256(rawPrice) * 10 ** (18 - feedDecimals);
         assertEq(price18, expected18, "Price mismatch vs raw feed");
     }
@@ -85,15 +86,19 @@ contract TestChainlinkPriceFeedFork is Test {
 
         // Raw feed is 8 decimals — price8 should match it exactly.
         (, int256 rawPrice,,,) = AggregatorV3Interface(ETH_USD_FEED).latestRoundData();
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price8, uint256(rawPrice), "8-decimal mismatch");
 
         // 6 decimals = raw / 100 (truncated).
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price6, uint256(rawPrice) / 1e2, "6-decimal mismatch");
 
         // 18 decimals = raw * 1e10.
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price18, uint256(rawPrice) * 1e10, "18-decimal mismatch");
 
         // 27 decimals = raw * 1e19.
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(price27, uint256(rawPrice) * 1e19, "27-decimal mismatch");
     }