@bananapus/core-v6 0.0.14 → 0.0.16

package/test/invariants/RulesetsInvariant.t.sol

@@ -1,8 +1,18 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {RulesetsHandler} from "./handlers/RulesetsHandler.sol";
 
 /// @notice Invariant tests for JBRulesets cycling, weight decay, and monotonicity.

package/test/invariants/TerminalStoreInvariant.t.sol

@@ -1,8 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {TerminalStoreHandler} from "./handlers/TerminalStoreHandler.sol";
 import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
 

package/test/invariants/TokensInvariant.t.sol

@@ -1,8 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/StdInvariant.sol";
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {StdInvariant} from "forge-std/StdInvariant.sol";
+import {TestBaseWorkflow} from "../helpers/TestBaseWorkflow.sol";
+import {IJBRulesetApprovalHook} from "../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBToken} from "../../src/interfaces/IJBToken.sol";
+import {JBConstants} from "../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../src/structs/JBTerminalConfig.sol";
 import {TokensHandler} from "./handlers/TokensHandler.sol";
 
 /// @notice Invariant tests for JBTokens supply and balance consistency.

package/test/invariants/handlers/ComprehensiveHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
@@ -20,12 +20,19 @@ contract ComprehensiveHandler is Test {
     address public projectOwner;
 
     // Ghost variables for fund tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidIn;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAddedToBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAllowanceUsed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalanceLast;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalanceDecreased; // should always be 0
 
     // Track actors
@@ -34,15 +41,25 @@ contract ComprehensiveHandler is Test {
     uint256 public constant NUM_ACTORS = 5;
 
     // Operation counters for debugging
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayouts;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedTokens;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_useAllowance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_claimCredits;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_processHeldFees;
 
     constructor(
@@ -62,6 +79,7 @@ contract ComprehensiveHandler is Test {
 
         // Create actor addresses
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x2000 + i));
             actors.push(actor);
             isActor[actor] = true;

package/test/invariants/handlers/EconomicHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
@@ -25,25 +25,41 @@ contract EconomicHandler is Test {
     address public projectOwner;
 
     // Ghost variables for conservation tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidInC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAddedToBalanceA;
 
     // Fee project tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalance;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_feeProjectBalancePrev;
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_feeProjectBalanceDecreased;
 
     // Cross-project split tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_splitCascadeOccurred;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_projectBBalanceBeforeSplit;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_projectBBalanceAfterSplit;
 
     // Track actors
@@ -52,18 +68,31 @@ contract EconomicHandler is Test {
     uint256 public constant NUM_ACTORS = 10;
 
     // Operation counters
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_payC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOutC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsB;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayoutsC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedA;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReservedC;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
 
     // Per-actor tracking
@@ -90,6 +119,7 @@ contract EconomicHandler is Test {
         projectOwner = _projectOwner;
 
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x3000 + i));
             actors.push(actor);
             isActor[actor] = true;

package/test/invariants/handlers/Phase3Handler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {JBFees} from "../../../src/libraries/JBFees.sol";
 import {JBFee} from "../../../src/structs/JBFee.sol";
@@ -9,7 +9,6 @@ import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
 import {IJBController} from "../../../src/interfaces/IJBController.sol";
 import {IJBTokens} from "../../../src/interfaces/IJBTokens.sol";
-import {JBMultiTerminal} from "../../../src/JBMultiTerminal.sol";
 
 /// @title Phase3Handler
 /// @notice Stateful fuzzing handler with ghost variable tracking for strict invariant verification.
@@ -40,44 +39,73 @@ contract Phase3Handler is Test {
     // =========================================================================
 
     // Per-project total inflows/outflows
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalPaidIn;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalCashedOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalPaidOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalAllowanceUsed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalAddedToBalance;
 
     // Fee tracking (key innovation for strict invariants)
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalFeesDeducted;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalFeesSentToProject1;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalHeldFeeAmounts;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalReturnedFees;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalProcessedFees;
 
     // Per-actor tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address => mapping(uint256 => uint256)) public ghost_actorContributed;
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(address => mapping(uint256 => uint256)) public ghost_actorExtracted;
 
     // Token tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     mapping(uint256 => uint256) public ghost_totalReservesSent;
 
     // Global conservation
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_globalInflows;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_globalOutflows;
 
     // Operation counters
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_pay3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_cashOut3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendPayouts2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_useAllowance2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_sendReserved2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_processHeldFees2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceReturn2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_addToBalanceNoReturn2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_burnTokens3;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_claimCredits2;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public callCount_advanceTime;
 
     constructor(
@@ -100,6 +128,7 @@ contract Phase3Handler is Test {
         projectOwner = _projectOwner;
 
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x4000 + i));
             actors.push(actor);
         }

package/test/invariants/handlers/RulesetsHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBRulesets} from "../../../src/interfaces/IJBRulesets.sol";
 import {IJBController} from "../../../src/interfaces/IJBController.sol";
@@ -25,9 +25,13 @@ contract RulesetsHandler is Test {
     address public projectOwner;
 
     // Ghost: track the last observed cycle number and weight for monotonicity checks
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint48 public ghost_lastCycleNumber;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint112 public ghost_lastWeight;
+    // forge-lint: disable-next-line(mixed-case-variable)
     bool public ghost_hasLaunched;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_queueCount;
 
     constructor(IJBRulesets _rulesets, IJBController _controller, uint256 _projectId, address _projectOwner) {

package/test/invariants/handlers/TerminalStoreHandler.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBTerminalStore} from "../../../src/interfaces/IJBTerminalStore.sol";
@@ -20,9 +20,13 @@ contract TerminalStoreHandler is Test {
     address public projectOwner;
 
     // Ghost variables for fund tracking
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidIn;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalCashedOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalPaidOut;
+    // forge-lint: disable-next-line(mixed-case-variable)
     uint256 public ghost_totalAddedToBalance;
 
     // Track actors
@@ -47,6 +51,7 @@ contract TerminalStoreHandler is Test {
 
         // Create actor addresses
         for (uint256 i = 0; i < NUM_ACTORS; i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             address actor = address(uint160(0x1000 + i));
             actors.push(actor);
             isActor[actor] = true;

package/test/invariants/handlers/TokensHandler.sol

@@ -1,12 +1,11 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import "forge-std/Test.sol";
+import {Test} from "forge-std/Test.sol";
 import {JBConstants} from "../../../src/libraries/JBConstants.sol";
 import {IJBMultiTerminal} from "../../../src/interfaces/IJBMultiTerminal.sol";
 import {IJBController} from "../../../src/interfaces/IJBController.sol";
 import {IJBTokens} from "../../../src/interfaces/IJBTokens.sol";
-import {IJBToken} from "../../../src/interfaces/IJBToken.sol";
 
 /// @notice Handler contract for JBTokens invariant testing.
 /// @dev Drives mint, burn, claim, and transfer operations; tracks holders for sum-of-balances checks.

package/test/mock/ERC2771ForwarderMock.sol

@@ -22,7 +22,7 @@ contract ERC2771ForwarderMock is ERC2771Forwarder {
         return _hashTypedDataV4(
             keccak256(
                 abi.encode(
-                    _FORWARD_REQUEST_TYPEHASH,
+                    FORWARD_REQUEST_TYPEHASH,
                     request.from,
                     request.to,
                     request.value,

package/test/mock/MockERC20.sol

@@ -1,9 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
-
-import {ERC20, IERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
+import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
 
 contract MockERC20 is ERC20 {
     function decimals() public view virtual override returns (uint8) {

package/test/mock/MockMaliciousBeneficiary.sol

@@ -1,9 +1,9 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {Test} from "forge-std/Test.sol";
+import {JBTerminalStore} from "../../src/JBTerminalStore.sol";
 import {IJBMultiTerminal} from "../../src/interfaces/IJBMultiTerminal.sol";
-import {JBMultiTerminal} from "../../src/JBMultiTerminal.sol";
 import {JBConstants} from "../../src/libraries/JBConstants.sol";
 import {IERC721Receiver} from "@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol";
 

package/test/mock/MockMaliciousSplitHook.sol

@@ -1,7 +1,8 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {IJBSplitHook} from "../../src/interfaces/IJBSplitHook.sol";
+import {JBSplitHookContext} from "../../src/structs/JBSplitHookContext.sol";
 
 import {ERC165, IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 

package/test/mock/MockPriceFeed.sol

@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../helpers/TestBaseWorkflow.sol";
+import {IJBPriceFeed} from "../../src/interfaces/IJBPriceFeed.sol";
 
 contract MockPriceFeed is IJBPriceFeed {
     uint256 public fakePrice;

package/test/units/static/JBChainlinkV3PriceFeed/TestPriceFeed.sol

@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
 import {JBTest} from "../../../helpers/JBTest.sol";
 import {JBChainlinkV3PriceFeed} from "../../../../src/JBChainlinkV3PriceFeed.sol";
 import {AggregatorV3Interface} from "@chainlink/contracts/src/v0.8/shared/interfaces/AggregatorV3Interface.sol";

package/test/units/static/JBController/JBControllerSetup.sol

@@ -1,7 +1,16 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {IJBController} from "../../../../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {IJBFundAccessLimits} from "../../../../src/interfaces/IJBFundAccessLimits.sol";
+import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
+import {IJBPrices} from "../../../../src/interfaces/IJBPrices.sol";
+import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
+import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
+import {IJBSplits} from "../../../../src/interfaces/IJBSplits.sol";
+import {IJBTokens} from "../../../../src/interfaces/IJBTokens.sol";
 import {JBTest} from "../../../helpers/JBTest.sol";
 
 /*

package/test/units/static/JBController/TestBurnTokensOf.sol

@@ -1,7 +1,14 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {JBPermissioned} from "../../../../src/abstract/JBPermissioned.sol";
+import {IJBController} from "../../../../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
+import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
+import {IJBTokens} from "../../../../src/interfaces/IJBTokens.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestBurnTokensOf_Local is JBControllerSetup {

package/test/units/static/JBController/TestClaimTokensFor.sol

@@ -1,7 +1,10 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBPermissioned} from "../../../../src/abstract/JBPermissioned.sol";
+import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
+import {IJBTokens} from "../../../../src/interfaces/IJBTokens.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestClaimTokensFor_Local is JBControllerSetup {

package/test/units/static/JBController/TestDeployErc20For.sol

@@ -1,7 +1,12 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBPermissioned} from "../../../../src/abstract/JBPermissioned.sol";
+import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
+import {IJBToken} from "../../../../src/interfaces/IJBToken.sol";
+import {IJBTokens} from "../../../../src/interfaces/IJBTokens.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
+import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestDeployERC20For_Local is JBControllerSetup {
@@ -34,6 +39,7 @@ contract TestDeployERC20For_Local is JBControllerSetup {
     function test_WhenCallerIsPermissionedAndSaltIsNonZero() external {
         // it will deploy ERC20 and return IJBToken
 
+        // forge-lint: disable-next-line(unsafe-typecast)
         bytes32 _nonZeroSalt = bytes32("somesalt");
         bytes32 _encodedSalt = keccak256(abi.encodePacked(address(this), _nonZeroSalt));
 

package/test/units/static/JBController/TestLaunchProjectFor.sol

@@ -1,7 +1,27 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {IJBController} from "../../../../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {IJBFundAccessLimits} from "../../../../src/interfaces/IJBFundAccessLimits.sol";
+import {IJBProjects} from "../../../../src/interfaces/IJBProjects.sol";
+import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
+import {IJBSplitHook} from "../../../../src/interfaces/IJBSplitHook.sol";
+import {IJBSplits} from "../../../../src/interfaces/IJBSplits.sol";
+import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../../../../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../../../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
+import {JBSplit} from "../../../../src/structs/JBSplit.sol";
+import {JBSplitGroup} from "../../../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../../../src/structs/JBTerminalConfig.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestLaunchProjectFor_Local is JBControllerSetup {

package/test/units/static/JBController/TestLaunchRulesetsFor.sol

@@ -1,7 +1,27 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {JBPermissioned} from "../../../../src/abstract/JBPermissioned.sol";
+import {IJBController} from "../../../../src/interfaces/IJBController.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {IJBFundAccessLimits} from "../../../../src/interfaces/IJBFundAccessLimits.sol";
+import {IJBPermissions} from "../../../../src/interfaces/IJBPermissions.sol";
+import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
+import {IJBSplits} from "../../../../src/interfaces/IJBSplits.sol";
+import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBCurrencyAmount} from "../../../../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../../../../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../../../../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../../../../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../../../../src/structs/JBTerminalConfig.sol";
+import {JBPermissionIds} from "@bananapus/permission-ids-v6/src/JBPermissionIds.sol";
+import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestLaunchRulesetsFor_Local is JBControllerSetup {

package/test/units/static/JBController/TestMigrateController.sol

@@ -1,7 +1,16 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {StdStorage, stdStorage} from "forge-std/StdStorage.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {IJBMigratable} from "../../../../src/interfaces/IJBMigratable.sol";
+import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
+import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
+import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestMigrateController_Local is JBControllerSetup {

package/test/units/static/JBController/TestMintTokensOfUnits.sol

@@ -1,7 +1,16 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "../../../helpers/TestBaseWorkflow.sol";
+import {JBController} from "../../../../src/JBController.sol";
+import {IJBDirectory} from "../../../../src/interfaces/IJBDirectory.sol";
+import {IJBRulesetApprovalHook} from "../../../../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../../../../src/interfaces/IJBRulesets.sol";
+import {IJBTerminal} from "../../../../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../../../../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../../../../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBRuleset} from "../../../../src/structs/JBRuleset.sol";
+import {JBRulesetMetadata} from "../../../../src/structs/JBRulesetMetadata.sol";
+import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
 import {JBControllerSetup} from "./JBControllerSetup.sol";
 
 contract TestMintTokensOfUnits_Local is JBControllerSetup {