@bananapus/core-v6 0.0.14 → 0.0.16

package/test/TestCashOutHooks.sol

@@ -1,7 +1,28 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBCashOutHook} from "../src/interfaces/IJBCashOutHook.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesetDataHook} from "../src/interfaces/IJBRulesetDataHook.sol";
+import {IJBToken} from "../src/interfaces/IJBToken.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBRulesetMetadataResolver} from "../src/libraries/JBRulesetMetadataResolver.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBAfterCashOutRecordedContext} from "../src/structs/JBAfterCashOutRecordedContext.sol";
+import {JBCashOutHookSpecification} from "../src/structs/JBCashOutHookSpecification.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {JBTokenAmount} from "../src/structs/JBTokenAmount.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
+import {mul as UD60x18mul, unwrap as UD60x18unwrap, wrap as UD60x18wrap} from "@prb/math/src/UD60x18.sol";
 
 contract TestCashOutHooks_Local is TestBaseWorkflow {
     using JBRulesetMetadataResolver for JBRuleset;
@@ -149,18 +170,18 @@ contract TestCashOutHooks_Local is TestBaseWorkflow {
             projectId: _projectId,
             rulesetId: _ruleset.id,
             cashOutCount: _beneficiaryTokenBalance / 2,
-            reclaimedAmount: JBTokenAmount(
-                JBConstants.NATIVE_TOKEN,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                _halfPaid
-            ),
-            forwardedAmount: JBTokenAmount(
-                JBConstants.NATIVE_TOKEN,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                _halfPaid
-            ),
+            reclaimedAmount: JBTokenAmount({
+                token: JBConstants.NATIVE_TOKEN,
+                decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                value: _halfPaid
+            }),
+            forwardedAmount: JBTokenAmount({
+                token: JBConstants.NATIVE_TOKEN,
+                decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                value: _halfPaid
+            }),
             cashOutTaxRate: 0,
             beneficiary: payable(address(this)),
             hookMetadata: "",
@@ -263,18 +284,19 @@ contract TestCashOutHooks_Local is TestBaseWorkflow {
             projectId: _projectId,
             rulesetId: _ruleset.id,
             cashOutCount: _beneficiaryTokenBalance / 2,
-            reclaimedAmount: JBTokenAmount(
-                JBConstants.NATIVE_TOKEN,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                _beneficiaryAmount
-            ),
-            forwardedAmount: JBTokenAmount(
-                JBConstants.NATIVE_TOKEN,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
-                _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
-                _forwardedAmount
-            ),
+            reclaimedAmount: JBTokenAmount({
+                token: JBConstants.NATIVE_TOKEN,
+                decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                value: _beneficiaryAmount
+            }),
+            forwardedAmount: JBTokenAmount({
+                token: JBConstants.NATIVE_TOKEN,
+                decimals: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).decimals,
+                currency: _terminal.accountingContextForTokenOf(_projectId, JBConstants.NATIVE_TOKEN).currency,
+                value: _forwardedAmount
+            }),
+            // forge-lint: disable-next-line(unsafe-typecast)
             cashOutTaxRate: uint16(_customCashOutTaxRate),
             beneficiary: payable(address(this)),
             hookMetadata: "",

package/test/TestCashOutTimingEdge.sol

@@ -1,7 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {JBCashOuts} from "../src/libraries/JBCashOuts.sol";
 
 /// @notice Edge case tests for cross-ruleset cash outs and pending reserves inflation.

package/test/TestDurationUnderflow.sol

@@ -1,13 +1,25 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBRulesets} from "../src/JBRulesets.sol";
+import {IJBDirectory} from "../src/interfaces/IJBDirectory.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 /// @notice Harness that exposes the internal `_simulateCycledRulesetBasedOn` for direct testing.
 contract JBRulesetsHarness is JBRulesets {
     constructor(IJBDirectory directory) JBRulesets(directory) {}
 
     /// @notice Public wrapper for the internal function under test.
+    // forge-lint: disable-next-line(mixed-case-function)
     function exposed_simulateCycledRulesetBasedOn(
         uint256 projectId,
         JBRuleset memory baseRuleset,

package/test/TestFeeProcessingFailure.sol

@@ -1,7 +1,22 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBFees} from "../src/libraries/JBFees.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 /// @notice Tests for the fee processing try-catch path in JBMultiTerminal.
 /// Proves that when fee payment reverts, the fee amount is credited back to
@@ -153,9 +168,6 @@ contract TestFeeProcessingFailure_Local is TestBaseWorkflow {
         // For this test, verify the FeeReverted event is emitted when fee processing fails.
         // We'll manipulate the directory to return address(0) for fee project's terminal.
 
-        // Record balance before payout.
-        uint256 projectBalanceBefore = _store.balanceOf(address(_terminal), _projectId, JBConstants.NATIVE_TOKEN);
-
         // The fee is taken during sendPayoutsOf. Under normal conditions, it goes to project #1.
         // The _processFee try-catch handles failures gracefully.
         // We verify that the normal path works (fee is deducted from payout and sent to fee project).
@@ -168,8 +180,6 @@ contract TestFeeProcessingFailure_Local is TestBaseWorkflow {
             minTokensPaidOut: 0
         });
 
-        uint256 projectBalanceAfter = _store.balanceOf(address(_terminal), _projectId, JBConstants.NATIVE_TOKEN);
-
         // Fee was deducted from the payout — project balance is now only the surplus (if any).
         // The fee was 2.5% of the payout amount.
         uint256 feeAmount = JBFees.feeAmountFrom({amountBeforeFee: PAY_AMOUNT, feePercent: _terminal.FEE()});
@@ -178,7 +188,7 @@ contract TestFeeProcessingFailure_Local is TestBaseWorkflow {
 
     /// @notice Held fee processing: when fee payment reverts, the FeeReverted event is emitted
     /// and the fee amount is credited back to the project balance via _recordAddedBalanceFor.
-    function test_heldFeeProcessing_revert_refundsToProject() external {
+    function test_heldFeeProcessing_revert_refundsToProject() external view {
         // This test requires holdFees=true ruleset — we test the principle:
         // When _processFee's try block reverts, the catch block calls _recordAddedBalanceFor.
         // This returns the fee amount to the project's terminal store balance.

package/test/TestFees.sol

@@ -1,7 +1,20 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFee} from "../src/structs/JBFee.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 // Projects can be launched.
 contract TestFees_Local is TestBaseWorkflow {

package/test/TestInterfaceSupport.sol

@@ -1,10 +1,29 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBController} from "../src/JBController.sol";
+import {JBDeadline} from "../src/JBDeadline.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {JBProjects} from "../src/JBProjects.sol";
+import {IJBCashOutTerminal} from "../src/interfaces/IJBCashOutTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBFeeTerminal} from "../src/interfaces/IJBFeeTerminal.sol";
+import {IJBMigratable} from "../src/interfaces/IJBMigratable.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBPayoutTerminal} from "../src/interfaces/IJBPayoutTerminal.sol";
+import {IJBPermissioned} from "../src/interfaces/IJBPermissioned.sol";
+import {IJBPermitTerminal} from "../src/interfaces/IJBPermitTerminal.sol";
+import {IJBProjects} from "../src/interfaces/IJBProjects.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IERC721} from "@openzeppelin/contracts/token/ERC721/IERC721.sol";
+import {IERC721Metadata} from "@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol";
+import {IERC165} from "@openzeppelin/contracts/utils/introspection/ERC165.sol";
 
 /// Contracts are introspective about the interfaces they adhere to.
 contract TestEIP165_Local is TestBaseWorkflow {
+    // forge-lint: disable-next-line(screaming-snake-case-const)
     bytes4 private constant _notSupportedInterface = 0xffffffff;
 
     function testJBController() public view {

package/test/TestJBERC20Inheritance.sol

@@ -1,7 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBERC20} from "../src/JBERC20.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBToken} from "../src/interfaces/IJBToken.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 import {ERC20Votes} from "../src/JBERC20.sol";
 

package/test/TestLaunchProject.sol

@@ -1,7 +1,19 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesets} from "../src/interfaces/IJBRulesets.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 // Projects can be launched.
 contract TestLaunchProject_Local is TestBaseWorkflow {

package/test/TestMetaTx.sol

@@ -1,7 +1,21 @@
 // SPDX-License-Identifier: MIT
 pragma solidity >=0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBCashOutTerminal} from "../src/interfaces/IJBCashOutTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {mul as UD60x18mul, unwrap as UD60x18unwrap, wrap as UD60x18wrap} from "@prb/math/src/UD60x18.sol";
 import {ERC2771Forwarder} from "@openzeppelin/contracts/metatx/ERC2771Forwarder.sol";
 import {ERC2771ForwarderMock, ForwardRequest} from "./mock/ERC2771ForwarderMock.sol";
 

package/test/TestMetadataParserLib.sol

@@ -1,7 +1,9 @@
 // SPDX-License-Identifier: MIT
 pragma solidity 0.8.26;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {Test} from "forge-std/Test.sol";
+import {MetadataResolverHelper} from "./helpers/MetadataResolverHelper.sol";
+import {JBMetadataResolver} from "../src/libraries/JBMetadataResolver.sol";
 
 /**
  * @notice Test the `JBDelegateMetadata` library and helper contract.
@@ -62,9 +64,15 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](10);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(
-                bytes1(uint8(_i + 1)), uint32(69), bytes2(uint16(_i + 69)), bytes32(uint256(type(uint256).max))
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes1(uint8(_i + 1)),
+                uint32(69),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes2(uint16(_i + 69)),
+                bytes32(uint256(type(uint256).max))
             );
         }
 
@@ -95,6 +103,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(type(uint256).max - _i);
         }
@@ -122,7 +131,9 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
+            // forge-lint: disable-next-line(incorrect-shift)
             _datas[_i] = abi.encode(69 << _i * 20);
         }
 
@@ -133,6 +144,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
             uint256 _data = abi.decode(_dataParsed, (uint256));
 
             assertTrue(_found);
+            // forge-lint: disable-next-line(incorrect-shift)
             assertEq(_data, 69 << _i * 20);
         }
     }
@@ -148,6 +160,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(type(uint256).max - _i);
         }
@@ -166,6 +179,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(type(uint256).max - _i);
         }
@@ -199,9 +213,15 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](2);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(
-                bytes1(uint8(_i + 1)), uint32(69), bytes2(uint16(_i + 69)), bytes32(uint256(type(uint256).max))
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes1(uint8(_i + 1)),
+                uint32(69),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes2(uint16(_i + 69)),
+                bytes32(uint256(type(uint256).max))
             );
         }
 
@@ -210,6 +230,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes memory _modifiedMetadata = parser.addDataToMetadata(
             _metadata,
             bytes4(uint32(type(uint32).max)),
+            // forge-lint: disable-next-line(unsafe-typecast)
             abi.encode(bytes32(uint256(type(uint256).max)), bytes32(hex"123456"))
         );
 
@@ -218,6 +239,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
 
         assertTrue(_found);
         assertEq(bytes32(uint256(type(uint256).max)), _a);
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(bytes32(hex"123456"), _b);
 
         for (uint256 _i; _i < _ids.length; _i++) {
@@ -243,6 +265,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(_i * 4);
         }
@@ -304,6 +327,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         assertEq(_a, uint32(69));
         assertEq(_b, bytes32(uint256(type(uint256).max)));
 
+        // forge-lint: disable-next-line(unsafe-typecast)
         assertEq(uint256(bytes32(_modifiedMetadata)), _reserved);
     }
 
@@ -339,6 +363,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfIds);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
             _datas[_i] = abi.encode(_i * 4);
         }
@@ -383,6 +408,7 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](_numberOfMetadatas);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
         }
 
@@ -420,10 +446,17 @@ contract JBDelegateMetadataLib_Test_Local is Test {
         bytes[] memory _datas = new bytes[](10);
 
         for (uint256 _i; _i < _ids.length; _i++) {
+            // forge-lint: disable-next-line(unsafe-typecast)
             _ids[_i] = bytes4(uint32(_i + 1 * 1000));
 
+            // forge-lint: disable-next-line(unsafe-typecast)
             _datas[_i] = abi.encodePacked(
-                bytes1(uint8(_i + 1)), uint32(69), bytes2(uint16(_i + 69)), bytes32(uint256(type(uint256).max))
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes1(uint8(_i + 1)),
+                uint32(69),
+                // forge-lint: disable-next-line(unsafe-typecast)
+                bytes2(uint16(_i + 69)),
+                bytes32(uint256(type(uint256).max))
             );
         }
 

package/test/TestMigrationHeldFees.sol

@@ -1,7 +1,22 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFee} from "../src/structs/JBFee.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 /// @notice Confirms held fees are stranded when a terminal migrates.
 /// The migration calls addToBalanceOf with shouldReturnHeldFees: false,
@@ -144,11 +159,8 @@ contract TestMigrationHeldFees_Local is TestBaseWorkflow {
         assertGt(heldFees.length, 0, "Should have held fees after payout");
 
         // Step 3: Migrate balance to terminal2.
-        uint256 balanceBefore = _store.balanceOf(address(_terminal), _projectId, JBConstants.NATIVE_TOKEN);
-
         vm.prank(_projectOwner);
-        uint256 migrated =
-            _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, IJBTerminal(address(_terminal2)));
+        _terminal.migrateBalanceOf(_projectId, JBConstants.NATIVE_TOKEN, IJBTerminal(address(_terminal2)));
 
         // Step 4: Verify old terminal has no balance but still has held fees.
         uint256 balanceAfter = _store.balanceOf(address(_terminal), _projectId, JBConstants.NATIVE_TOKEN);
@@ -231,16 +243,10 @@ contract TestMigrationHeldFees_Local is TestBaseWorkflow {
         // Warp past holding period.
         vm.warp(block.timestamp + 28 days + 1);
 
-        // Fee project balance before attempting to process.
-        uint256 feeBalanceBefore = _store.balanceOf(address(_terminal), 1, JBConstants.NATIVE_TOKEN);
-
         // Try to process held fees — the fees still exist but the old terminal has no ETH.
         // The _processFee try-catch will catch the revert and credit the fee amount back to the project.
         _terminal.processHeldFeesOf(_projectId, JBConstants.NATIVE_TOKEN, 100);
 
-        // Fee project should NOT have received fees (old terminal had no ETH to transfer).
-        uint256 feeBalanceAfter = _store.balanceOf(address(_terminal), 1, JBConstants.NATIVE_TOKEN);
-
         // The fee processing attempted but the terminal has no actual ETH.
         // The _recordAddedBalanceFor in the catch block inflates the store balance
         // without actual funds — this is a phantom balance.

package/test/TestMintTokensOf.sol

@@ -1,7 +1,20 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {IJBRulesetDataHook} from "../src/interfaces/IJBRulesetDataHook.sol";
+import {IJBTerminal} from "../src/interfaces/IJBTerminal.sol";
+import {IJBTokens} from "../src/interfaces/IJBTokens.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRuleset} from "../src/structs/JBRuleset.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 
 contract TestMintTokensOf_Local is TestBaseWorkflow {
     uint8 private constant _WEIGHT_DECIMALS = 18;

package/test/TestMultiTokenSurplus.sol

@@ -1,7 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBMultiTerminal} from "../src/JBMultiTerminal.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
 import {MockPriceFeed} from "./mock/MockPriceFeed.sol";
 import {MockERC20} from "./mock/MockERC20.sol";
 
@@ -117,6 +127,7 @@ contract TestMultiTokenSurplus_Local is TestBaseWorkflow {
         vm.prank(_beneficiary);
         _usdc.approve(address(permit2()), usdcAmount);
         vm.prank(_beneficiary);
+        // forge-lint: disable-next-line(unsafe-typecast)
         permit2().approve(address(_usdc), address(_terminal), uint160(usdcAmount), type(uint48).max);
 
         vm.prank(_beneficiary);
@@ -145,6 +156,7 @@ contract TestMultiTokenSurplus_Local is TestBaseWorkflow {
         vm.prank(_beneficiary);
         _usdc.approve(address(permit2()), usdcAmount);
         vm.prank(_beneficiary);
+        // forge-lint: disable-next-line(unsafe-typecast)
         permit2().approve(address(_usdc), address(_terminal), uint160(usdcAmount), type(uint48).max);
 
         vm.prank(_beneficiary);
@@ -191,6 +203,7 @@ contract TestMultiTokenSurplus_Local is TestBaseWorkflow {
         vm.prank(_beneficiary);
         _usdc.approve(address(permit2()), usdcAmount);
         vm.prank(_beneficiary);
+        // forge-lint: disable-next-line(unsafe-typecast)
         permit2().approve(address(_usdc), address(_terminal), uint160(usdcAmount), type(uint48).max);
 
         vm.prank(_beneficiary);

package/test/TestMultipleAccessLimits.sol

@@ -1,12 +1,32 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.6;
 
-import /* {*} from */ "./helpers/TestBaseWorkflow.sol";
+import {TestBaseWorkflow} from "./helpers/TestBaseWorkflow.sol";
+import {JBFundAccessLimits} from "../src/JBFundAccessLimits.sol";
+import {JBTerminalStore} from "../src/JBTerminalStore.sol";
+import {JBTokens} from "../src/JBTokens.sol";
+import {IJBController} from "../src/interfaces/IJBController.sol";
+import {IJBMultiTerminal} from "../src/interfaces/IJBMultiTerminal.sol";
+import {IJBPriceFeed} from "../src/interfaces/IJBPriceFeed.sol";
+import {IJBPrices} from "../src/interfaces/IJBPrices.sol";
+import {IJBRulesetApprovalHook} from "../src/interfaces/IJBRulesetApprovalHook.sol";
+import {JBConstants} from "../src/libraries/JBConstants.sol";
+import {JBCurrencyIds} from "../src/libraries/JBCurrencyIds.sol";
+import {JBAccountingContext} from "../src/structs/JBAccountingContext.sol";
+import {JBCurrencyAmount} from "../src/structs/JBCurrencyAmount.sol";
+import {JBFundAccessLimitGroup} from "../src/structs/JBFundAccessLimitGroup.sol";
+import {JBRulesetConfig} from "../src/structs/JBRulesetConfig.sol";
+import {JBRulesetMetadata} from "../src/structs/JBRulesetMetadata.sol";
+import {JBSplitGroup} from "../src/structs/JBSplitGroup.sol";
+import {JBTerminalConfig} from "../src/structs/JBTerminalConfig.sol";
+import {mulDiv} from "@prb/math/src/Common.sol";
+import {mul as UD60x18mul, unwrap as UD60x18unwrap, wrap as UD60x18wrap} from "@prb/math/src/UD60x18.sol";
 import {MockPriceFeed} from "./mock/MockPriceFeed.sol";
 
 contract TestMultipleAccessLimits_Local is TestBaseWorkflow {
     uint32 private _nativeCurrency;
     IJBController private _controller;
+    // forge-lint: disable-next-line(mixed-case-variable)
     IJBMultiTerminal private __terminal;
     IJBPrices private _prices;
     JBTokens private _tokens;
@@ -225,6 +245,7 @@ contract TestMultipleAccessLimits_Local is TestBaseWorkflow {
         });
     }
 
+    // forge-lint: disable-next-line(mixed-case-variable)
     function testFuzzedInvalidAllowanceCurrencyOrdering(uint24 ALLOWCURRENCY) external {
         JBFundAccessLimitGroup[] memory _fundAccessLimitGroup = new JBFundAccessLimitGroup[](1);
         JBCurrencyAmount[] memory _payoutLimits = new JBCurrencyAmount[](1);
@@ -336,6 +357,7 @@ contract TestMultipleAccessLimits_Local is TestBaseWorkflow {
         uint224 _payoutLimit,
         uint224 _surplusAllowance,
         uint32 _payoutCurrency,
+        // forge-lint: disable-next-line(mixed-case-variable)
         uint32 ALLOWCURRENCY
     )
         external