@bananapus/721-hook-v6 0.0.42 → 0.0.45

package/test/unit/tierSplitRouting_Unit.t.sol

@@ -1,757 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJB721TiersHookStore} from "../../src/interfaces/IJB721TiersHookStore.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-import {IJBSplitHook} from "@bananapus/core-v6/src/interfaces/IJBSplitHook.sol";
-import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {IJBTerminal} from "@bananapus/core-v6/src/interfaces/IJBTerminal.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {JB721TiersHookFlags} from "../../src/structs/JB721TiersHookFlags.sol";
-import {ERC20} from "@openzeppelin/contracts/token/ERC20/ERC20.sol";
-
-contract MockERC20 is ERC20 {
-    constructor() ERC20("Mock Token", "MOCK") {}
-
-    function mint(address to, uint256 amount) external {
-        _mint(to, amount);
-    }
-}
-
-contract Test_TierSplitRouting is UnitTestSetup {
-    using stdStorage for StdStorage;
-
-    address alice = makeAddr("alice");
-    address bob = makeAddr("bob");
-
-    function setUp() public override {
-        super.setUp();
-        vm.etch(mockJBSplits, new bytes(0x69));
-    }
-
-    // Helper: build a tier config with splits.
-    function _tierConfigWithSplit(
-        uint104 price,
-        uint32 splitPercent
-    )
-        internal
-        pure
-        returns (JB721TierConfig memory config)
-    {
-        config.price = price;
-        config.initialSupply = uint32(100);
-        config.category = uint24(1);
-        config.encodedIPFSUri = bytes32(uint256(0x1234));
-        config.splitPercent = splitPercent;
-    }
-
-    // Helper: build payer metadata for tier IDs.
-    function _buildPayerMetadata(
-        address hookAddress,
-        uint16[] memory tierIdsToMint
-    )
-        internal
-        view
-        returns (bytes memory)
-    {
-        bytes[] memory data = new bytes[](1);
-        data[0] = abi.encode(false, tierIdsToMint);
-        bytes4[] memory ids = new bytes4[](1);
-        ids[0] = metadataHelper.getId("pay", hookAddress);
-        return metadataHelper.createMetadata(ids, data);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: beforePayRecordedWith calculates split amount
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_calculatesSplitAmount() public {
-        // Create hook with a default tier (no splits).
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 50% split directly to the hook's store.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 500_000_000); // 50%
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Build payer metadata requesting that tier.
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // Weight adjusted for 50% split: 10e18 * 0.5 = 5e18.
-        assertEq(weight, 5e18);
-        // Hook spec should forward 50% of 1 ETH = 0.5 ETH.
-        assertEq(specs.length, 1);
-        assertEq(specs[0].amount, 0.5 ether);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: no splitPercent means no forwarded amount
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_noSplitPercent_noForwardedAmount() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 0% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 0);
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // No split amount forwarded.
-        assertEq(specs[0].amount, 0);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: multiple tiers with different split percents
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_multipleTiersDifferentSplitPercents() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Tier 1: 1 ETH, 30% split. Tier 2: 2 ETH, 100% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](2);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 300_000_000);
-        tierConfigs[0].category = 1;
-        tierConfigs[1] = _tierConfigWithSplit(2 ether, 1_000_000_000);
-        tierConfigs[1].category = 2;
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](2);
-        mintIds[0] = uint16(tierIds[0]);
-        mintIds[1] = uint16(tierIds[1]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 3 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (, JBPayHookSpecification[] memory specs) = testHook.beforePayRecordedWith(context);
-
-        // Total split = 1 ETH * 30% + 2 ETH * 100% = 0.3 + 2.0 = 2.3 ETH.
-        assertEq(specs[0].amount, 2.3 ether);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: weight adjusted for splits
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_weightAdjustedForSplits() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 30% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 300_000_000); // 30%
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight,) = testHook.beforePayRecordedWith(context);
-
-        // Weight adjusted for 30% split: 10e18 * 0.7 = 7e18.
-        assertEq(weight, 7e18);
-    }
-
-    function test_beforePayRecorded_noSplitPercent_weightUnchanged() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 0% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 0);
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight,) = testHook.beforePayRecordedWith(context);
-
-        // No split = weight unchanged.
-        assertEq(weight, 10e18);
-    }
-
-    function test_beforePayRecorded_fullSplitPercent_weightZero() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 100% split, priced at full payment amount.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 1_000_000_000); // 100%
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight,) = testHook.beforePayRecordedWith(context);
-
-        // 100% split of full amount = weight 0.
-        assertEq(weight, 0);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: afterPayRecordedWith distributes to split beneficiary
-    // ──────────────────────────────────────────────
-
-    function test_afterPayRecorded_distributesToBeneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 50% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 500_000_000);
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Mock directory checks.
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-
-        // Mock splits: alice gets 100%.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(alice),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Build payer metadata.
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        // Build hook metadata (per-tier split breakdown from beforePayRecordedWith).
-        uint16[] memory splitTierIds = new uint16[](1);
-        splitTierIds[0] = uint16(tierIds[0]);
-        uint256[] memory splitAmounts = new uint256[](1);
-        splitAmounts[0] = 0.5 ether;
-
-        JBAfterPayRecordedContext memory payContext = JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            forwardedAmount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 0.5 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: abi.encode(beneficiary, beneficiary, abi.encode(splitTierIds, splitAmounts)),
-            payerMetadata: payerMetadata
-        });
-
-        uint256 aliceBalanceBefore = alice.balance;
-
-        vm.deal(mockTerminalAddress, 1 ether);
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith{value: 0.5 ether}(payContext);
-
-        // Alice should have received 0.5 ETH.
-        assertEq(alice.balance - aliceBalanceBefore, 0.5 ether);
-        // NFT should have been minted.
-        assertEq(testHook.balanceOf(beneficiary), 1);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: issueTokensForSplits flag gives full weight with partial splits
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_issueTokensForSplits_fullWeight() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Set the issueTokensForSplits flag.
-        vm.prank(address(testHook));
-        hookStore.recordFlags(
-            JB721TiersHookFlags({
-                noNewTiersWithReserves: false,
-                noNewTiersWithVotes: false,
-                noNewTiersWithOwnerMinting: false,
-                preventOverspending: false,
-                issueTokensForSplits: true
-            })
-        );
-
-        // Add a tier with 50% split.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 500_000_000); // 50%
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight,) = testHook.beforePayRecordedWith(context);
-
-        // Flag set — weight should be full despite 50% split.
-        assertEq(weight, 10e18);
-    }
-
-    // ──────────────────────────────────────────────
-    // Test: issueTokensForSplits flag gives full weight even when splits consume entire payment
-    // ──────────────────────────────────────────────
-
-    function test_beforePayRecorded_issueTokensForSplits_fullSplit_stillFullWeight() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Set the issueTokensForSplits flag.
-        vm.prank(address(testHook));
-        hookStore.recordFlags(
-            JB721TiersHookFlags({
-                noNewTiersWithReserves: false,
-                noNewTiersWithVotes: false,
-                noNewTiersWithOwnerMinting: false,
-                preventOverspending: false,
-                issueTokensForSplits: true
-            })
-        );
-
-        // Add a tier with 100% split, priced at full payment amount.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(1 ether, 1_000_000_000); // 100%
-        vm.prank(address(testHook));
-        uint256[] memory tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        bytes memory payerMetadata = _buildPayerMetadata(address(testHook), mintIds);
-
-        JBBeforePayRecordedContext memory context = JBBeforePayRecordedContext({
-            terminal: mockTerminalAddress,
-            payer: beneficiary,
-            amount: JBTokenAmount({
-                token: JBConstants.NATIVE_TOKEN,
-                value: 1 ether,
-                decimals: 18,
-                currency: uint32(uint160(JBConstants.NATIVE_TOKEN))
-            }),
-            projectId: projectId,
-            rulesetId: 0,
-            beneficiary: beneficiary,
-            weight: 10e18,
-            reservedPercent: 5000,
-            metadata: payerMetadata
-        });
-
-        (uint256 weight,) = testHook.beforePayRecordedWith(context);
-
-        // Flag set — weight should be full despite 100% split consuming entire payment.
-        assertEq(weight, 10e18);
-    }
-
-    // ──────────────────────────────────────────────
-    // ERC20 Tests: afterPayRecordedWith with ERC20 tokens
-    // ──────────────────────────────────────────────
-
-    /// @notice Helper: set up an ERC20 tier split test. Returns (hook, tierIds, mockToken).
-    // forge-lint: disable-next-line(mixed-case-function)
-    function _setupERC20TierSplit()
-        internal
-        returns (JB721TiersHook testHook, uint256[] memory tierIds, MockERC20 token)
-    {
-        // Deploy mock ERC20.
-        token = new MockERC20();
-
-        // Initialize hook with ERC20 currency (0 default tiers).
-        testHook = _initHookDefaultTiers(0, false, uint32(uint160(address(token))), 18);
-        IJB721TiersHookStore hookStore = testHook.STORE();
-
-        // Add a tier with 50% split, priced at 100 tokens.
-        JB721TierConfig[] memory tierConfigs = new JB721TierConfig[](1);
-        tierConfigs[0] = _tierConfigWithSplit(100, 500_000_000); // 50%
-        vm.prank(address(testHook));
-        tierIds = hookStore.recordAddTiers(tierConfigs);
-
-        // Mock directory checks.
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.isTerminalOf.selector, projectId, mockTerminalAddress),
-            abi.encode(true)
-        );
-    }
-
-    /// @notice Helper: build afterPayRecordedWith context for ERC20 payments.
-    // forge-lint: disable-next-line(mixed-case-function)
-    function _buildERC20PayContext(
-        JB721TiersHook testHook,
-        uint256[] memory tierIds,
-        address token,
-        uint256 payAmount,
-        uint256 forwardedAmount
-    )
-        internal
-        view
-        returns (JBAfterPayRecordedContext memory)
-    {
-        uint16[] memory mintIds = new uint16[](1);
-        mintIds[0] = uint16(tierIds[0]);
-        // Use METADATA_ID_TARGET (the original hook address) for metadata resolution.
-        bytes memory payerMetadata = _buildPayerMetadata(testHook.METADATA_ID_TARGET(), mintIds);
-
-        uint16[] memory splitTierIds = new uint16[](1);
-        splitTierIds[0] = uint16(tierIds[0]);
-        uint256[] memory splitAmounts = new uint256[](1);
-        splitAmounts[0] = forwardedAmount;
-
-        return JBAfterPayRecordedContext({
-            payer: beneficiary,
-            projectId: projectId,
-            rulesetId: 0,
-            // forge-lint: disable-next-line(unsafe-typecast)
-            amount: JBTokenAmount({token: token, value: payAmount, decimals: 18, currency: uint32(uint160(token))}),
-            forwardedAmount: JBTokenAmount({
-                // forge-lint: disable-next-line(unsafe-typecast)
-                token: token,
-                value: forwardedAmount,
-                decimals: 18,
-                // forge-lint: disable-next-line(unsafe-typecast)
-                currency: uint32(uint160(token))
-            }),
-            weight: 10e18,
-            newlyIssuedTokenCount: 0,
-            beneficiary: beneficiary,
-            hookMetadata: abi.encode(beneficiary, beneficiary, abi.encode(splitTierIds, splitAmounts)),
-            payerMetadata: payerMetadata
-        });
-    }
-
-    function test_afterPayRecorded_erc20_distributesToBeneficiary() public {
-        (JB721TiersHook testHook, uint256[] memory tierIds, MockERC20 token) = _setupERC20TierSplit();
-
-        // Mock splits: alice gets 100%.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(alice),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Give terminal the ERC20 tokens and approve the hook.
-        token.mint(mockTerminalAddress, 100);
-        vm.prank(mockTerminalAddress);
-        token.approve(address(testHook), 50);
-
-        JBAfterPayRecordedContext memory payContext = _buildERC20PayContext(testHook, tierIds, address(token), 100, 50);
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(payContext);
-
-        // Alice should have received 50 tokens.
-        assertEq(token.balanceOf(alice), 50);
-        // NFT should have been minted.
-        assertEq(testHook.balanceOf(beneficiary), 1);
-    }
-
-    function test_afterPayRecorded_erc20_splitToProject_addToBalance() public {
-        (JB721TiersHook testHook, uint256[] memory tierIds, MockERC20 token) = _setupERC20TierSplit();
-
-        // Target project for split.
-        uint256 targetProjectId = 99;
-        address targetTerminal = makeAddr("targetTerminal");
-        vm.etch(targetTerminal, new bytes(0x69));
-
-        // Mock splits: 100% to target project with preferAddToBalance.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            // forge-lint: disable-next-line(unsafe-typecast)
-            projectId: uint56(targetProjectId),
-            beneficiary: payable(address(0)),
-            preferAddToBalance: true,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Mock directory: target project's primary terminal.
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.primaryTerminalOf.selector, targetProjectId, address(token)),
-            abi.encode(targetTerminal)
-        );
-
-        // Mock the addToBalanceOf call on the target terminal.
-        vm.mockCall(targetTerminal, abi.encodeWithSelector(IJBTerminal.addToBalanceOf.selector), abi.encode());
-
-        // Give terminal the ERC20 tokens and approve the hook.
-        token.mint(mockTerminalAddress, 100);
-        vm.prank(mockTerminalAddress);
-        token.approve(address(testHook), 50);
-
-        JBAfterPayRecordedContext memory payContext = _buildERC20PayContext(testHook, tierIds, address(token), 100, 50);
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(payContext);
-
-        // Hook approved the target terminal (library calls forceApprove before addToBalanceOf).
-        // Mock terminal doesn't pull, so hook still holds the tokens. Verify approval was set.
-        assertGe(token.allowance(address(testHook), targetTerminal), 50);
-        assertEq(testHook.balanceOf(beneficiary), 1);
-    }
-
-    function test_afterPayRecorded_erc20_splitToProject_pay() public {
-        (JB721TiersHook testHook, uint256[] memory tierIds, MockERC20 token) = _setupERC20TierSplit();
-
-        uint256 targetProjectId = 99;
-        address targetTerminal = makeAddr("targetTerminal");
-        vm.etch(targetTerminal, new bytes(0x69));
-
-        // Mock splits: 100% to target project with preferAddToBalance = false (pay).
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            // forge-lint: disable-next-line(unsafe-typecast)
-            projectId: uint56(targetProjectId),
-            beneficiary: payable(alice),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Mock directory: target project's primary terminal.
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.primaryTerminalOf.selector, targetProjectId, address(token)),
-            abi.encode(targetTerminal)
-        );
-
-        // Mock the pay call on the target terminal.
-        vm.mockCall(targetTerminal, abi.encodeWithSelector(IJBTerminal.pay.selector), abi.encode(0));
-
-        // Give terminal the ERC20 tokens and approve the hook.
-        token.mint(mockTerminalAddress, 100);
-        vm.prank(mockTerminalAddress);
-        token.approve(address(testHook), 50);
-
-        JBAfterPayRecordedContext memory payContext = _buildERC20PayContext(testHook, tierIds, address(token), 100, 50);
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(payContext);
-
-        // Hook approved the target terminal (library calls forceApprove before pay).
-        assertGe(token.allowance(address(testHook), targetTerminal), 50);
-        assertEq(testHook.balanceOf(beneficiary), 1);
-    }
-
-    function test_afterPayRecorded_erc20_noBeneficiary_routesToProjectBalance() public {
-        (JB721TiersHook testHook, uint256[] memory tierIds, MockERC20 token) = _setupERC20TierSplit();
-
-        // Mock splits: no beneficiary and no projectId — leftover goes to project balance.
-        JBSplit[] memory splits = new JBSplit[](1);
-        splits[0] = JBSplit({
-            percent: uint32(JBConstants.SPLITS_TOTAL_PERCENT),
-            projectId: 0,
-            beneficiary: payable(address(0)),
-            preferAddToBalance: false,
-            lockedUntil: 0,
-            hook: IJBSplitHook(address(0))
-        });
-
-        uint256 groupId = uint256(uint160(address(testHook))) | (uint256(tierIds[0]) << 160);
-        mockAndExpect(
-            mockJBSplits, abi.encodeWithSelector(IJBSplits.splitsOf.selector, projectId, 0, groupId), abi.encode(splits)
-        );
-
-        // Mock the project's primary terminal for the leftover addToBalance.
-        address projectTerminal = makeAddr("projectTerminal");
-        vm.etch(projectTerminal, new bytes(0x69));
-        mockAndExpect(
-            address(mockJBDirectory),
-            abi.encodeWithSelector(IJBDirectory.primaryTerminalOf.selector, projectId, address(token)),
-            abi.encode(projectTerminal)
-        );
-
-        vm.mockCall(projectTerminal, abi.encodeWithSelector(IJBTerminal.addToBalanceOf.selector), abi.encode());
-
-        // Give terminal the ERC20 tokens and approve the hook.
-        token.mint(mockTerminalAddress, 100);
-        vm.prank(mockTerminalAddress);
-        token.approve(address(testHook), 50);
-
-        JBAfterPayRecordedContext memory payContext = _buildERC20PayContext(testHook, tierIds, address(token), 100, 50);
-
-        vm.prank(mockTerminalAddress);
-        testHook.afterPayRecordedWith(payContext);
-
-        // Hook approved the project terminal (library calls forceApprove before addToBalanceOf).
-        assertGe(token.allowance(address(testHook), projectTerminal), 50);
-        assertEq(testHook.balanceOf(beneficiary), 1);
-    }
-}