@bananapus/721-hook-v6 0.0.42 → 0.0.45

package/test/audit/ReserveSlotProtection.t.sol

@@ -1,273 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {Test} from "forge-std/Test.sol";
-import {JBSplit} from "@bananapus/core-v6/src/structs/JBSplit.sol";
-
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-import {JB721Tier} from "../../src/structs/JB721Tier.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-
-/// @notice Tests that paid mints cannot consume slots reserved for the reserve beneficiary.
-/// @dev Regression test for the vulnerability where `_numberOfPendingReservesFor` returns 0
-/// when `remainingSupply == 0` (sold-out early-return), allowing the post-decrement guard
-/// `0 < 0` to pass and permanently stealing reserved slots from the beneficiary.
-/// The fix uses `_numberOfPendingReservesForMintGuard` which omits the sold-out early-return.
-contract ReserveSlotProtection is Test {
-    JB721TiersHookStore internal store;
-
-    function setUp() public {
-        store = new JB721TiersHookStore();
-    }
-
-    /// @notice Proves the fix: a paid mint that would consume the last reserved slot reverts.
-    /// Scenario: tier with initialSupply=2, reserveFrequency=1 (1 reserve per paid mint).
-    /// After 1 paid mint, 1 slot remains but it's reserved. Second paid mint must revert.
-    /// Post-decrement trace: remaining goes 2->1, pending=ceil(1/1)=1, check 1<1 = false -> ok.
-    /// Second mint: remaining goes 1->0, _numberOfPendingReservesForMintGuard returns 2
-    /// (ceil(2/1)-0=2), check 0<2 -> true -> reverts.
-    function test_paidMintRevertsWhenOnlyReservedSlotsRemain() public {
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](1);
-        tiers[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 2,
-            votingUnits: 0,
-            reserveFrequency: 1,
-            reserveBeneficiary: address(0xBEEF),
-            encodedIPFSUri: bytes32(0),
-            category: 0,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        store.recordAddTiers(tiers);
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-
-        // First paid mint succeeds — uses 1 of 2 slots, leaving 1 for the pending reserve.
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Verify state: 1 remaining supply, 1 pending reserve.
-        JB721Tier memory tier = store.tierOf(address(this), 1, false);
-        assertEq(tier.remainingSupply, 1, "should have 1 slot remaining after first mint");
-        assertEq(store.numberOfPendingReservesFor(address(this), 1), 1, "should have 1 pending reserve");
-
-        // Second paid mint MUST revert — the only remaining slot belongs to the reserve beneficiary.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_InsufficientSupplyRemaining.selector, 1)
-        );
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-    }
-
-    /// @notice Proves that the reserve beneficiary can still mint their reserved slot after fix.
-    function test_reserveBeneficiaryCanMintAfterPaidSlotsExhausted() public {
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](1);
-        tiers[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 2,
-            votingUnits: 0,
-            reserveFrequency: 1,
-            reserveBeneficiary: address(0xBEEF),
-            encodedIPFSUri: bytes32(0),
-            category: 0,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        store.recordAddTiers(tiers);
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-
-        // First paid mint.
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Reserve beneficiary mints their entitled reserve.
-        uint256[] memory reserveTokenIds = store.recordMintReservesFor({tierId: 1, count: 1});
-        assertEq(reserveTokenIds.length, 1, "reserve beneficiary should get 1 token");
-
-        // After reserve mint, remaining supply is 0 and reserves are fulfilled.
-        JB721Tier memory tier = store.tierOf(address(this), 1, false);
-        assertEq(tier.remainingSupply, 0, "tier should be fully minted");
-        assertEq(store.numberOfReservesMintedFor(address(this), 1), 1, "1 reserve should be minted");
-    }
-
-    /// @notice Tests a larger tier: initialSupply=10, reserveFrequency=2.
-    /// With frequency=2, every 2 paid mints earn 1 reserve (rounded up).
-    /// Post-decrement analysis for the 7th mint:
-    ///   remaining goes 4->3, nonReserveMints=7, pending=ceil(7/2)-0=4.
-    ///   Check: 3 < 4 -> true -> reverts. Correct!
-    /// So mints 1-6 succeed, mint 7 reverts.
-    function test_largerTierReserveProtection() public {
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](1);
-        tiers[0] = JB721TierConfig({
-            price: 0.1 ether,
-            initialSupply: 10,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: address(0xCAFE),
-            encodedIPFSUri: bytes32(0),
-            category: 0,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        store.recordAddTiers(tiers);
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-
-        // Mint 6 paid NFTs. After 6 mints: remaining=4, pending=ceil(6/2)=3.
-        for (uint256 i; i < 6; i++) {
-            store.recordMint({amount: 0.1 ether, tierIds: tierIds, isOwnerMint: false});
-        }
-
-        JB721Tier memory tier = store.tierOf(address(this), 1, false);
-        assertEq(tier.remainingSupply, 4, "should have 4 remaining after 6 mints");
-        assertEq(store.numberOfPendingReservesFor(address(this), 1), 3, "should have 3 pending reserves");
-
-        // 7th paid mint should revert: after decrement, remaining=3, pending=ceil(7/2)=4. 3<4 -> reverts.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_InsufficientSupplyRemaining.selector, 1)
-        );
-        store.recordMint({amount: 0.1 ether, tierIds: tierIds, isOwnerMint: false});
-    }
-
-    /// @notice Verifies that when reserves are minted between paid mints, paid mints can continue.
-    /// initialSupply=4, reserveFrequency=1.
-    function test_paidMintsResumeAfterReservesMinted() public {
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](1);
-        tiers[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 4,
-            votingUnits: 0,
-            reserveFrequency: 1,
-            reserveBeneficiary: address(0xBEEF),
-            encodedIPFSUri: bytes32(0),
-            category: 0,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        store.recordAddTiers(tiers);
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-
-        // Paid mint 1: remaining 4->3, nonReserveMints=1, pending=ceil(1/1)=1. Check: 3<1? No. OK.
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Paid mint 2: remaining 3->2, nonReserveMints=2, pending=ceil(2/1)=2. Check: 2<2? No. OK.
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Paid mint 3: remaining 2->1, nonReserveMints=3, pending=ceil(3/1)=3. Check: 1<3? Yes! Revert.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_InsufficientSupplyRemaining.selector, 1)
-        );
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Mint 1 reserve — frees up a slot. Now reservesMinted=1.
-        store.recordMintReservesFor({tierId: 1, count: 1});
-
-        // State: remaining=1, reservesMinted=1, nonReserveMints=2.
-        // Paid mint attempt: remaining 1->0, nonReserveMints=3, pending=ceil(3/1)-1=2. Check: 0<2? Yes! Revert.
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_InsufficientSupplyRemaining.selector, 1)
-        );
-        store.recordMint({amount: 1 ether, tierIds: tierIds, isOwnerMint: false});
-
-        // Mint remaining reserve.
-        store.recordMintReservesFor({tierId: 1, count: 1});
-
-        // Tier fully minted — 0 remaining.
-        JB721Tier memory tier = store.tierOf(address(this), 1, false);
-        assertEq(tier.remainingSupply, 0, "tier should be fully minted");
-    }
-
-    /// @notice Without reserves, all NFTs in a tier should be mintable (no off-by-one).
-    function test_noReservesFullSupplyMintable() public {
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](1);
-        tiers[0] = JB721TierConfig({
-            price: 0.1 ether,
-            initialSupply: 5,
-            votingUnits: 0,
-            reserveFrequency: 0,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(0),
-            category: 0,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        store.recordAddTiers(tiers);
-
-        uint16[] memory tierIds = new uint16[](1);
-        tierIds[0] = 1;
-
-        // Mint all 5 — should succeed since no reserves to protect.
-        for (uint256 i; i < 5; i++) {
-            store.recordMint({amount: 0.1 ether, tierIds: tierIds, isOwnerMint: false});
-        }
-
-        JB721Tier memory tier = store.tierOf(address(this), 1, false);
-        assertEq(tier.remainingSupply, 0, "fully minted");
-
-        // 6th mint should revert (supply exhausted).
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_InsufficientSupplyRemaining.selector, 1)
-        );
-        store.recordMint({amount: 0.1 ether, tierIds: tierIds, isOwnerMint: false});
-    }
-}

package/test/audit/RetroactiveReserveBeneficiaryDilution.t.sol

@@ -1,149 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-// forge-lint: disable-next-line(unaliased-plain-import)
-import "../utils/UnitTestSetup.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {JBAfterPayRecordedContext} from "@bananapus/core-v6/src/structs/JBAfterPayRecordedContext.sol";
-import {JB721TierConfigFlags} from "../../src/structs/JB721TierConfigFlags.sol";
-import {JB721TiersHookStore} from "../../src/JB721TiersHookStore.sol";
-
-contract RetroactiveReserveBeneficiaryDilution is UnitTestSetup {
-    /// @notice Creating a tier with reserveFrequency > 0 but no beneficiary (tier-specific or default) now reverts,
-    /// preventing the phantom reserve scenario where a later default beneficiary retroactively inflates
-    /// totalCashOutWeight and dilutes existing holders.
-    function test_adjustTier_reverts_when_reserve_has_no_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory tier1 = new JB721TierConfig[](1);
-        tier1[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        vm.expectRevert(
-            abi.encodeWithSelector(JB721TiersHookStore.JB721TiersHookStore_MissingReserveBeneficiary.selector, 1)
-        );
-        testHook.adjustTiers(tier1, new uint256[](0));
-    }
-
-    /// @notice A tier with reserveFrequency > 0 succeeds when an explicit beneficiary is provided.
-    function test_adjustTier_succeeds_with_explicit_reserve_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        JB721TierConfig[] memory tier1 = new JB721TierConfig[](1);
-        tier1[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: owner,
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tier1, new uint256[](0));
-
-        assertEq(
-            testHook.STORE().reserveBeneficiaryOf(address(testHook), 1),
-            owner,
-            "tier-specific beneficiary should be set"
-        );
-    }
-
-    /// @notice A tier with reserveFrequency > 0 and no explicit beneficiary succeeds when a default beneficiary
-    /// was previously set by an earlier tier.
-    function test_adjustTier_succeeds_with_default_reserve_beneficiary() public {
-        ForTest_JB721TiersHook testHook = _initializeForTestHook(0);
-
-        // Add two tiers: first sets the default beneficiary, second relies on it.
-        JB721TierConfig[] memory tiers = new JB721TierConfig[](2);
-
-        // Tier 1: sets default beneficiary via useReserveBeneficiaryAsDefault.
-        tiers[0] = JB721TierConfig({
-            price: 1 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 2,
-            reserveBeneficiary: owner,
-            encodedIPFSUri: bytes32(uint256(0x1234)),
-            category: 1,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: true,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        // Tier 2: relies on the default beneficiary (no explicit one).
-        tiers[1] = JB721TierConfig({
-            price: 2 ether,
-            initialSupply: 100,
-            votingUnits: 0,
-            reserveFrequency: 3,
-            reserveBeneficiary: address(0),
-            encodedIPFSUri: bytes32(uint256(0x5678)),
-            category: 2,
-            discountPercent: 0,
-            flags: JB721TierConfigFlags({
-                allowOwnerMint: false,
-                useReserveBeneficiaryAsDefault: false,
-                transfersPausable: false,
-                useVotingUnits: false,
-                cantBeRemoved: false,
-                cantIncreaseDiscountPercent: false,
-                cantBuyWithCredits: false
-            }),
-            splitPercent: 0,
-            splits: new JBSplit[](0)
-        });
-
-        vm.prank(owner);
-        testHook.adjustTiers(tiers, new uint256[](0));
-
-        // Tier 2 should inherit the default beneficiary set by tier 1.
-        assertEq(
-            testHook.STORE().reserveBeneficiaryOf(address(testHook), 2),
-            owner,
-            "tier 2 should inherit default beneficiary"
-        );
-    }
-}

package/test/audit/SameCurrencyDecimalMismatch.t.sol

@@ -1,249 +0,0 @@
-// SPDX-License-Identifier: MIT
-pragma solidity 0.8.28;
-
-import {UnitTestSetup} from "../utils/UnitTestSetup.sol";
-import {IJB721TokenUriResolver} from "../../src/interfaces/IJB721TokenUriResolver.sol";
-import {IJBDirectory} from "@bananapus/core-v6/src/interfaces/IJBDirectory.sol";
-import {IJBPermissions} from "@bananapus/core-v6/src/interfaces/IJBPermissions.sol";
-import {IJBPrices} from "@bananapus/core-v6/src/interfaces/IJBPrices.sol";
-import {IJBRulesets} from "@bananapus/core-v6/src/interfaces/IJBRulesets.sol";
-import {IJBSplits} from "@bananapus/core-v6/src/interfaces/IJBSplits.sol";
-import {JBBeforePayRecordedContext} from "@bananapus/core-v6/src/structs/JBBeforePayRecordedContext.sol";
-import {JBPayHookSpecification} from "@bananapus/core-v6/src/structs/JBPayHookSpecification.sol";
-import {JBTokenAmount} from "@bananapus/core-v6/src/structs/JBTokenAmount.sol";
-import {JB721TiersHook} from "../../src/JB721TiersHook.sol";
-import {JB721CheckpointsDeployer} from "../../src/JB721CheckpointsDeployer.sol";
-import {IJB721CheckpointsDeployer} from "../../src/interfaces/IJB721CheckpointsDeployer.sol";
-import {JB721TierConfig} from "../../src/structs/JB721TierConfig.sol";
-import {JB721InitTiersConfig} from "../../src/structs/JB721InitTiersConfig.sol";
-import {JB721TiersHookFlags} from "../../src/structs/JB721TiersHookFlags.sol";
-
-/// @notice Regression test for: same-currency decimal mismatch in split forwarding.
-/// @dev When pricing decimals differ from payment decimals but the currency is the same,
-/// `convertAndCapSplitAmounts` must rescale split amounts before comparing to `amountValue`.
-/// Without the fix, split amounts stay in pricing decimals (e.g. 18), the cap comparison uses
-/// payment decimals (e.g. 6), and the cap clips the split to 100% of the payment.
-contract SameCurrencyDecimalMismatch is UnitTestSetup {
-    // Shared constants.
-    address constant MOCK_TOKEN = address(0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48);
-    // forge-lint: disable-next-line(unsafe-typecast)
-    uint32 constant CURRENCY = uint32(uint160(MOCK_TOKEN));
-
-    /// @notice Prove that a 50% split with same currency but different decimals (pricing=18, payment=6)
-    /// correctly forwards ~50% of the payment, not 100%.
-    function test_sameCurrency_differentDecimals_splitAmountScaledCorrectly() public {
-        // Deploy hook with PRICES=address(0), tier priced at 1e18 (18-decimal), 50% split.
-        JB721TiersHook testHook;
-        {
-            JB721TiersHook origin = new JB721TiersHook(
-                IJBDirectory(mockJBDirectory),
-                IJBPermissions(mockJBPermissions),
-                IJBPrices(address(0)),
-                IJBRulesets(mockJBRulesets),
-                store,
-                IJBSplits(mockJBSplits),
-                IJB721CheckpointsDeployer(address(new JB721CheckpointsDeployer())),
-                trustedForwarder
-            );
-            address hookAddr = makeAddr("hook18to6");
-            vm.etch(hookAddr, address(origin).code);
-            testHook = JB721TiersHook(hookAddr);
-        }
-
-        {
-            (JB721TierConfig[] memory tierConfigs,) = _createTiers(defaultTierConfig, 1);
-            tierConfigs[0].price = 1e18;
-            tierConfigs[0].splitPercent = 500_000_000; // 50%.
-            testHook.initialize(
-                projectId,
-                name,
-                symbol,
-                baseUri,
-                IJB721TokenUriResolver(mockTokenUriResolver),
-                contractUri,
-                JB721InitTiersConfig({tiers: tierConfigs, currency: CURRENCY, decimals: 18}),
-                JB721TiersHookFlags({
-                    preventOverspending: false,
-                    issueTokensForSplits: false,
-                    noNewTiersWithReserves: false,
-                    noNewTiersWithVotes: false,
-                    noNewTiersWithOwnerMinting: false
-                })
-            );
-        }
-
-        // Build payer metadata requesting tier 1.
-        bytes memory payerMetadata;
-        {
-            uint16[] memory tierIdsToMint = new uint16[](1);
-            tierIdsToMint[0] = 1;
-            bytes[] memory data = new bytes[](1);
-            data[0] = abi.encode(true, tierIdsToMint);
-            bytes4[] memory ids = new bytes4[](1);
-            ids[0] = metadataHelper.getId("pay", testHook.METADATA_ID_TARGET());
-            payerMetadata = metadataHelper.createMetadata(ids, data);
-        }
-
-        // Pay 1.0 token reported as 6 decimals (value = 1e6). Same currency, different decimals.
-        (uint256 weight, JBPayHookSpecification[] memory hookSpecs) = testHook.beforePayRecordedWith(
-            JBBeforePayRecordedContext({
-                terminal: mockTerminalAddress,
-                payer: beneficiary,
-                amount: JBTokenAmount({token: MOCK_TOKEN, value: 1e6, decimals: 6, currency: CURRENCY}),
-                projectId: projectId,
-                rulesetId: 0,
-                beneficiary: beneficiary,
-                weight: 10e18,
-                reservedPercent: 0,
-                metadata: payerMetadata
-            })
-        );
-
-        // Without the fix: split amount (5e17 in 18-decimal pricing) is compared to amountValue (1e6),
-        // causing the cap to clip it to 1e6 (100% of payment) and weight becomes 0.
-        // With the fix: split is rescaled to 5e5 (50% of 1e6) and weight is 5e18.
-        assertEq(hookSpecs[0].amount, 5e5, "split should be 50% of payment (5e5), not capped to 100%");
-        assertEq(weight, 5e18, "weight should be 50% (half goes to splits)");
-    }
-
-    /// @notice Sanity check: same currency AND same decimals — no rescaling needed.
-    function test_sameCurrency_sameDecimals_splitAmountUnchanged() public {
-        JB721TiersHook testHook;
-        {
-            JB721TiersHook origin = new JB721TiersHook(
-                IJBDirectory(mockJBDirectory),
-                IJBPermissions(mockJBPermissions),
-                IJBPrices(address(0)),
-                IJBRulesets(mockJBRulesets),
-                store,
-                IJBSplits(mockJBSplits),
-                IJB721CheckpointsDeployer(address(new JB721CheckpointsDeployer())),
-                trustedForwarder
-            );
-            address hookAddr = makeAddr("hook18to18");
-            vm.etch(hookAddr, address(origin).code);
-            testHook = JB721TiersHook(hookAddr);
-        }
-
-        {
-            (JB721TierConfig[] memory tierConfigs,) = _createTiers(defaultTierConfig, 1);
-            tierConfigs[0].price = 1e18;
-            tierConfigs[0].splitPercent = 500_000_000;
-            testHook.initialize(
-                projectId,
-                name,
-                symbol,
-                baseUri,
-                IJB721TokenUriResolver(mockTokenUriResolver),
-                contractUri,
-                JB721InitTiersConfig({tiers: tierConfigs, currency: CURRENCY, decimals: 18}),
-                JB721TiersHookFlags({
-                    preventOverspending: false,
-                    issueTokensForSplits: false,
-                    noNewTiersWithReserves: false,
-                    noNewTiersWithVotes: false,
-                    noNewTiersWithOwnerMinting: false
-                })
-            );
-        }
-
-        bytes memory payerMetadata;
-        {
-            uint16[] memory tierIdsToMint = new uint16[](1);
-            tierIdsToMint[0] = 1;
-            bytes[] memory data = new bytes[](1);
-            data[0] = abi.encode(true, tierIdsToMint);
-            bytes4[] memory ids = new bytes4[](1);
-            ids[0] = metadataHelper.getId("pay", testHook.METADATA_ID_TARGET());
-            payerMetadata = metadataHelper.createMetadata(ids, data);
-        }
-
-        (uint256 weight, JBPayHookSpecification[] memory hookSpecs) = testHook.beforePayRecordedWith(
-            JBBeforePayRecordedContext({
-                terminal: mockTerminalAddress,
-                payer: beneficiary,
-                amount: JBTokenAmount({token: MOCK_TOKEN, value: 1e18, decimals: 18, currency: CURRENCY}),
-                projectId: projectId,
-                rulesetId: 0,
-                beneficiary: beneficiary,
-                weight: 10e18,
-                reservedPercent: 0,
-                metadata: payerMetadata
-            })
-        );
-
-        assertEq(hookSpecs[0].amount, 5e17, "split should be 50% of payment");
-        assertEq(weight, 5e18, "weight should be 50%");
-    }
-
-    /// @notice Same currency, payment has MORE decimals than pricing (pricing=6, payment=18).
-    function test_sameCurrency_paymentMoreDecimals_splitScaledUp() public {
-        JB721TiersHook testHook;
-        {
-            JB721TiersHook origin = new JB721TiersHook(
-                IJBDirectory(mockJBDirectory),
-                IJBPermissions(mockJBPermissions),
-                IJBPrices(address(0)),
-                IJBRulesets(mockJBRulesets),
-                store,
-                IJBSplits(mockJBSplits),
-                IJB721CheckpointsDeployer(address(new JB721CheckpointsDeployer())),
-                trustedForwarder
-            );
-            address hookAddr = makeAddr("hook6to18");
-            vm.etch(hookAddr, address(origin).code);
-            testHook = JB721TiersHook(hookAddr);
-        }
-
-        {
-            (JB721TierConfig[] memory tierConfigs,) = _createTiers(defaultTierConfig, 1);
-            tierConfigs[0].price = 1e6; // 1.0 token in 6-decimal pricing.
-            tierConfigs[0].splitPercent = 500_000_000;
-            testHook.initialize(
-                projectId,
-                name,
-                symbol,
-                baseUri,
-                IJB721TokenUriResolver(mockTokenUriResolver),
-                contractUri,
-                JB721InitTiersConfig({tiers: tierConfigs, currency: CURRENCY, decimals: 6}),
-                JB721TiersHookFlags({
-                    preventOverspending: false,
-                    issueTokensForSplits: false,
-                    noNewTiersWithReserves: false,
-                    noNewTiersWithVotes: false,
-                    noNewTiersWithOwnerMinting: false
-                })
-            );
-        }
-
-        bytes memory payerMetadata;
-        {
-            uint16[] memory tierIdsToMint = new uint16[](1);
-            tierIdsToMint[0] = 1;
-            bytes[] memory data = new bytes[](1);
-            data[0] = abi.encode(true, tierIdsToMint);
-            bytes4[] memory ids = new bytes4[](1);
-            ids[0] = metadataHelper.getId("pay", testHook.METADATA_ID_TARGET());
-            payerMetadata = metadataHelper.createMetadata(ids, data);
-        }
-
-        (uint256 weight, JBPayHookSpecification[] memory hookSpecs) = testHook.beforePayRecordedWith(
-            JBBeforePayRecordedContext({
-                terminal: mockTerminalAddress,
-                payer: beneficiary,
-                amount: JBTokenAmount({token: MOCK_TOKEN, value: 1e18, decimals: 18, currency: CURRENCY}),
-                projectId: projectId,
-                rulesetId: 0,
-                beneficiary: beneficiary,
-                weight: 10e18,
-                reservedPercent: 0,
-                metadata: payerMetadata
-            })
-        );
-
-        // 50% of 1.0 token in 18-decimal payment = 5e17.
-        assertEq(hookSpecs[0].amount, 5e17, "split scaled up to 18-decimal payment");
-        assertEq(weight, 5e18, "weight should be 50%");
-    }
-}