@babylonjs/core 5.52.0 → 5.53.1

package/Engines/nativeEngine.d.ts

@@ -440,6 +440,7 @@ export declare class NativeEngine extends Engine {
         width: number;
         height: number;
     }, options: boolean | RenderTargetCreationOptions): RenderTargetWrapper;
+    updateRenderTargetTextureSampleCount(rtWrapper: RenderTargetWrapper, samples: number): number;
     updateTextureSamplingMode(samplingMode: number, texture: InternalTexture): void;
     bindFramebuffer(texture: RenderTargetWrapper, faceIndex?: number, requiredWidth?: number, requiredHeight?: number, forceFullscreenViewport?: boolean): void;
     unBindFramebuffer(texture: RenderTargetWrapper, disableGenerateMipMaps?: boolean, onBeforeUnbind?: () => void): void;

package/Engines/nativeEngine.js

@@ -1638,6 +1638,7 @@ export class NativeEngine extends Engine {
         let format = 5;
         let useSRGBBuffer = false;
         let samples = 1;
+        let label;
         if (options !== undefined && typeof options === "object") {
             generateMipMaps = !!options.generateMipMaps;
             type = options.type === undefined ? 0 : options.type;
@@ -1645,6 +1646,7 @@ export class NativeEngine extends Engine {
             format = options.format === undefined ? 5 : options.format;
             useSRGBBuffer = options.useSRGBBuffer === undefined ? false : options.useSRGBBuffer;
             samples = (_a = options.samples) !== null && _a !== void 0 ? _a : 1;
+            label = options.label;
         }
         else {
             generateMipMaps = !!options;
@@ -1686,23 +1688,24 @@ export class NativeEngine extends Engine {
         texture.samplingMode = samplingMode;
         texture.type = type;
         texture.format = format;
+        texture.label = label;
         this._internalTexturesCache.push(texture);
         return texture;
     }
     createRenderTargetTexture(size, options) {
-        var _a;
+        var _a, _b;
         const rtWrapper = this._createHardwareRenderTargetWrapper(false, false, size);
         let generateDepthBuffer = true;
         let generateStencilBuffer = false;
         let noColorAttachment = false;
         let colorAttachment = undefined;
-        //let samples = 1;
+        let samples = 1;
         if (options !== undefined && typeof options === "object") {
             generateDepthBuffer = (_a = options.generateDepthBuffer) !== null && _a !== void 0 ? _a : true;
             generateStencilBuffer = !!options.generateStencilBuffer;
             noColorAttachment = !!options.noColorAttachment;
             colorAttachment = options.colorAttachment;
-            //samples = options.samples ?? 1;
+            samples = (_b = options.samples) !== null && _b !== void 0 ? _b : 1;
         }
         const texture = colorAttachment || (noColorAttachment ? null : this._createInternalTexture(size, options, true, InternalTextureSource.RenderTarget));
         const width = size.width || size;
@@ -1712,10 +1715,18 @@ export class NativeEngine extends Engine {
         rtWrapper._generateDepthBuffer = generateDepthBuffer;
         rtWrapper._generateStencilBuffer = generateStencilBuffer;
         rtWrapper.setTextures(texture);
-        // TODO: handle this in native
-        //this.updateRenderTargetTextureSampleCount(rtWrapper, samples);
+        this.updateRenderTargetTextureSampleCount(rtWrapper, samples);
         return rtWrapper;
     }
+    // This function is being added for the sole purpose of overriding the ThinEngine version.  The reason
+    // for this is that the ThinEngine version of this function uses a WebGL2RenderingContext, which is not
+    // available in Babylon Native.  The return value is just a hard-coded value that is not used anywhere
+    // in Babylon Native's code.  This is effectively a hack/workaround so that Babylon Native doesn't crash
+    // This function should be updated once the maxMSAASamples is updated as well.
+    updateRenderTargetTextureSampleCount(rtWrapper, samples) {
+        // TODO: Implement this function once the maxMSAASamples is updated.
+        return 1;
+    }
     updateTextureSamplingMode(samplingMode, texture) {
         if (texture._hardwareTexture) {
             const filter = this._getNativeSamplingMode(samplingMode);