@babylonjs/core 5.2.0 → 5.5.0

package/Engines/webgpuEngine.js

@@ -675,8 +675,8 @@ var WebGPUEngine = /** @class */ (function (_super) {
             depthLoadOp: WebGPUConstants.LoadOp.Clear,
             depthStoreOp: WebGPUConstants.StoreOp.Store,
             stencilClearValue: this._clearStencilValue,
-            stencilLoadOp: WebGPUConstants.LoadOp.Clear,
-            stencilStoreOp: WebGPUConstants.StoreOp.Store,
+            stencilLoadOp: !this.isStencilEnable ? undefined : WebGPUConstants.LoadOp.Clear,
+            stencilStoreOp: !this.isStencilEnable ? undefined : WebGPUConstants.StoreOp.Store,
         };
         this._mainRenderPassWrapper.renderPassDescriptor = {
             colorAttachments: mainColorAttachments,
@@ -1952,8 +1952,13 @@ var WebGPUEngine = /** @class */ (function (_super) {
         if (hasAlpha === void 0) { hasAlpha = true; }
         if (flushRenderer === void 0) { flushRenderer = true; }
         var renderPassWrapper = this._rttRenderPassWrapper.renderPass ? this._rttRenderPassWrapper : this._mainRenderPassWrapper;
-        var gpuTexture = renderPassWrapper.colorAttachmentGPUTextures[0].underlyingResource;
-        var gpuTextureFormat = renderPassWrapper.colorAttachmentGPUTextures[0].format;
+        var hardwareTexture = renderPassWrapper.colorAttachmentGPUTextures[0];
+        if (!hardwareTexture) {
+            // we are calling readPixels for a render pass with no color texture bound
+            return Promise.resolve(new Uint8Array(0));
+        }
+        var gpuTexture = hardwareTexture.underlyingResource;
+        var gpuTextureFormat = hardwareTexture.format;
         if (!gpuTexture) {
             // we are calling readPixels before startMainRenderPass has been called and no RTT is bound, so swapChainTexture is not setup yet!
             return Promise.resolve(new Uint8Array(0));
@@ -2089,6 +2094,7 @@ var WebGPUEngine = /** @class */ (function (_super) {
         var gpuDepthStencilMSAATexture = gpuDepthStencilWrapper === null || gpuDepthStencilWrapper === void 0 ? void 0 : gpuDepthStencilWrapper.msaaTexture;
         var depthTextureView = gpuDepthStencilTexture === null || gpuDepthStencilTexture === void 0 ? void 0 : gpuDepthStencilTexture.createView(this._rttRenderPassWrapper.depthAttachmentViewDescriptor);
         var depthMSAATextureView = gpuDepthStencilMSAATexture === null || gpuDepthStencilMSAATexture === void 0 ? void 0 : gpuDepthStencilMSAATexture.createView(this._rttRenderPassWrapper.depthAttachmentViewDescriptor);
+        var depthTextureHasStencil = gpuDepthStencilWrapper ? WebGPUTextureHelper.HasStencilAspect(gpuDepthStencilWrapper.format) : false;
         var colorAttachments = [];
         if (this.useReverseDepthBuffer) {
             this.setDepthFunctionToGreaterOrEqual();
@@ -2126,18 +2132,23 @@ var WebGPUEngine = /** @class */ (function (_super) {
         else {
             // single render target
             var internalTexture = rtWrapper.texture;
-            var gpuWrapper = internalTexture._hardwareTexture;
-            var gpuTexture = gpuWrapper.underlyingResource;
-            var gpuMSAATexture = gpuWrapper.msaaTexture;
-            var colorTextureView = gpuTexture.createView(this._rttRenderPassWrapper.colorAttachmentViewDescriptor);
-            var colorMSAATextureView = gpuMSAATexture === null || gpuMSAATexture === void 0 ? void 0 : gpuMSAATexture.createView(this._rttRenderPassWrapper.colorAttachmentViewDescriptor);
-            colorAttachments.push({
-                view: colorMSAATextureView ? colorMSAATextureView : colorTextureView,
-                resolveTarget: gpuMSAATexture ? colorTextureView : undefined,
-                clearValue: mustClearColor ? clearColor : undefined,
-                loadOp: mustClearColor ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load,
-                storeOp: WebGPUConstants.StoreOp.Store,
-            });
+            if (internalTexture) {
+                var gpuWrapper = internalTexture._hardwareTexture;
+                var gpuTexture = gpuWrapper.underlyingResource;
+                var gpuMSAATexture = gpuWrapper.msaaTexture;
+                var colorTextureView = gpuTexture.createView(this._rttRenderPassWrapper.colorAttachmentViewDescriptor);
+                var colorMSAATextureView = gpuMSAATexture === null || gpuMSAATexture === void 0 ? void 0 : gpuMSAATexture.createView(this._rttRenderPassWrapper.colorAttachmentViewDescriptor);
+                colorAttachments.push({
+                    view: colorMSAATextureView ? colorMSAATextureView : colorTextureView,
+                    resolveTarget: gpuMSAATexture ? colorTextureView : undefined,
+                    clearValue: mustClearColor ? clearColor : undefined,
+                    loadOp: mustClearColor ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load,
+                    storeOp: WebGPUConstants.StoreOp.Store,
+                });
+            }
+            else {
+                colorAttachments.push(null);
+            }
         }
         (_a = this._debugPushGroup) === null || _a === void 0 ? void 0 : _a.call(this, "render target pass", 1);
         this._rttRenderPassWrapper.renderPassDescriptor = {
@@ -2149,8 +2160,12 @@ var WebGPUEngine = /** @class */ (function (_super) {
                     depthLoadOp: mustClearDepth ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load,
                     depthStoreOp: WebGPUConstants.StoreOp.Store,
                     stencilClearValue: rtWrapper._depthStencilTextureWithStencil && mustClearStencil ? this._clearStencilValue : undefined,
-                    stencilLoadOp: rtWrapper._depthStencilTextureWithStencil && mustClearStencil ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load,
-                    stencilStoreOp: WebGPUConstants.StoreOp.Store,
+                    stencilLoadOp: !depthTextureHasStencil
+                        ? undefined
+                        : rtWrapper._depthStencilTextureWithStencil && mustClearStencil
+                            ? WebGPUConstants.LoadOp.Clear
+                            : WebGPUConstants.LoadOp.Load,
+                    stencilStoreOp: !depthTextureHasStencil ? undefined : WebGPUConstants.StoreOp.Store,
                 }
                 : undefined,
             occlusionQuerySet: ((_b = this._occlusionQuery) === null || _b === void 0 ? void 0 : _b.hasQueries) ? this._occlusionQuery.querySet : undefined,
@@ -2177,10 +2192,10 @@ var WebGPUEngine = /** @class */ (function (_super) {
     };
     /** @hidden */
     WebGPUEngine.prototype._endRenderTargetRenderPass = function () {
-        var _a, _b, _c;
+        var _a, _b, _c, _d;
         if (this._currentRenderPass) {
-            var gpuWrapper = this._currentRenderTarget.texture._hardwareTexture;
-            if (!this._snapshotRendering.endRenderTargetPass(this._currentRenderPass, gpuWrapper) && !this.compatibilityMode) {
+            var gpuWrapper = (_a = this._currentRenderTarget.texture) === null || _a === void 0 ? void 0 : _a._hardwareTexture;
+            if (gpuWrapper && !this._snapshotRendering.endRenderTargetPass(this._currentRenderPass, gpuWrapper) && !this.compatibilityMode) {
                 this._bundleListRenderTarget.run(this._currentRenderPass);
                 this._bundleListRenderTarget.reset();
             }
@@ -2190,10 +2205,10 @@ var WebGPUEngine = /** @class */ (function (_super) {
                     this._count = 0;
                 }
                 if (!this._count || this._count < this.dbgVerboseLogsNumFrames) {
-                    console.log("frame #" + this._count + " - render target end pass - internalTexture.uniqueId=", (_b = (_a = this._currentRenderTarget) === null || _a === void 0 ? void 0 : _a.texture) === null || _b === void 0 ? void 0 : _b.uniqueId);
+                    console.log("frame #" + this._count + " - render target end pass - internalTexture.uniqueId=", (_c = (_b = this._currentRenderTarget) === null || _b === void 0 ? void 0 : _b.texture) === null || _c === void 0 ? void 0 : _c.uniqueId);
                 }
             }
-            (_c = this._debugPopGroup) === null || _c === void 0 ? void 0 : _c.call(this, 1);
+            (_d = this._debugPopGroup) === null || _d === void 0 ? void 0 : _d.call(this, 1);
             this._resetCurrentViewport(1);
             this._resetCurrentScissor(1);
             this._resetCurrentStencilRef(1);
@@ -2236,7 +2251,11 @@ var WebGPUEngine = /** @class */ (function (_super) {
             : undefined;
         this._mainRenderPassWrapper.renderPassDescriptor.depthStencilAttachment.depthLoadOp = mustClearDepth ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load;
         this._mainRenderPassWrapper.renderPassDescriptor.depthStencilAttachment.stencilClearValue = mustClearStencil ? this._clearStencilValue : undefined;
-        this._mainRenderPassWrapper.renderPassDescriptor.depthStencilAttachment.stencilLoadOp = mustClearStencil ? WebGPUConstants.LoadOp.Clear : WebGPUConstants.LoadOp.Load;
+        this._mainRenderPassWrapper.renderPassDescriptor.depthStencilAttachment.stencilLoadOp = !this.isStencilEnable
+            ? undefined
+            : mustClearStencil
+                ? WebGPUConstants.LoadOp.Clear
+                : WebGPUConstants.LoadOp.Load;
         this._mainRenderPassWrapper.renderPassDescriptor.occlusionQuerySet = ((_a = this._occlusionQuery) === null || _a === void 0 ? void 0 : _a.hasQueries) ? this._occlusionQuery.querySet : undefined;
         this._swapChainTexture = this._context.getCurrentTexture();
         this._mainRenderPassWrapper.colorAttachmentGPUTextures[0].set(this._swapChainTexture);
@@ -2311,17 +2330,13 @@ var WebGPUEngine = /** @class */ (function (_super) {
         if (lodLevel === void 0) { lodLevel = 0; }
         if (layer === void 0) { layer = 0; }
         var hardwareTexture = (_a = texture.texture) === null || _a === void 0 ? void 0 : _a._hardwareTexture;
-        if (!hardwareTexture) {
-            if (this.dbgSanityChecks) {
-                console.error("bindFramebuffer: Trying to bind a texture that does not have a hardware texture!", texture, hardwareTexture);
-            }
-            return;
-        }
         if (this._currentRenderTarget) {
             this.unBindFramebuffer(this._currentRenderTarget);
         }
         this._currentRenderTarget = texture;
-        hardwareTexture._currentLayer = texture.isCube ? layer * 6 + faceIndex : layer;
+        if (hardwareTexture) {
+            hardwareTexture._currentLayer = texture.isCube ? layer * 6 + faceIndex : layer;
+        }
         this._rttRenderPassWrapper.colorAttachmentGPUTextures[0] = hardwareTexture;
         this._rttRenderPassWrapper.depthTextureFormat = this._currentRenderTarget._depthStencilTexture
             ? WebGPUTextureHelper.GetWebGPUTextureFormat(-1, this._currentRenderTarget._depthStencilTexture.format)
@@ -2444,7 +2459,8 @@ var WebGPUEngine = /** @class */ (function (_super) {
      * @hidden
      */
     WebGPUEngine.prototype._setColorFormat = function (wrapper) {
-        var format = wrapper.colorAttachmentGPUTextures[0].format;
+        var _a, _b;
+        var format = (_b = (_a = wrapper.colorAttachmentGPUTextures[0]) === null || _a === void 0 ? void 0 : _a.format) !== null && _b !== void 0 ? _b : null;
         this._cacheRenderPipeline.setColorFormat(format);
         if (this._colorFormat === format) {
             return;