@babylonjs/core 5.15.0 → 5.17.0

package/scene.js

@@ -140,6 +140,7 @@ var Scene = /** @class */ (function (_super) {
         _this.onAfterRenderObservable = new Observable();
         /**
          * An event triggered after rendering the scene for an active camera (When scene.render is called this will be called after each camera)
+         * This is triggered for each "sub" camera in a Camera Rig unlike onAfterCameraRenderObservable
          */
         _this.onAfterRenderCameraObservable = new Observable();
         _this._onAfterRenderObserver = null;
@@ -170,6 +171,7 @@ var Scene = /** @class */ (function (_super) {
         _this._onBeforeCameraRenderObserver = null;
         /**
          * An event triggered after rendering a camera
+         * This is triggered for the full rig Camera only unlike onAfterRenderCameraObservable
          */
         _this.onAfterCameraRenderObservable = new Observable();
         _this._onAfterCameraRenderObserver = null;
@@ -1206,7 +1208,7 @@ var Scene = /** @class */ (function (_super) {
                 var component = _a[_i];
                 component.register();
             }
-            this._transientComponents = [];
+            this._transientComponents.length = 0;
         }
     };
     /**
@@ -1543,6 +1545,8 @@ var Scene = /** @class */ (function (_super) {
             if (!mesh.subMeshes || mesh.subMeshes.length === 0) {
                 continue;
             }
+            // Do not stop at the first encountered "unready" object as we want to ensure
+            // all materials are starting off their compilation in parallel.
             if (!mesh.isReady(true)) {
                 isReady = false;
                 continue;
@@ -1694,17 +1698,17 @@ var Scene = /** @class */ (function (_super) {
         }
     };
     /**
-     * @param data
-     * @hidden
+     * This function can help adding any object to the list of data awaited to be ready in order to check for a complete scene loading.
+     * @param data defines the object to wait for
      */
-    Scene.prototype._addPendingData = function (data) {
+    Scene.prototype.addPendingData = function (data) {
         this._pendingData.push(data);
     };
     /**
-     * @param data
-     * @hidden
+     * Remove a pending data from the loading list which has previously been added with addPendingData.
+     * @param data defines the object to remove from the pending list
      */
-    Scene.prototype._removePendingData = function (data) {
+    Scene.prototype.removePendingData = function (data) {
         var wasLoading = this.isLoading;
         var index = this._pendingData.indexOf(data);
         if (index !== -1) {
@@ -3401,7 +3405,9 @@ var Scene = /** @class */ (function (_super) {
                 rtt.onClearObservable.notifyObservers(this._engine);
             }
             else if (!rtt.skipInitialClear) {
-                this._engine.clear(rtt.clearColor || this.clearColor, !rtt._cleared, true, true);
+                if (this.autoClear) {
+                    this._engine.clear(rtt.clearColor || this.clearColor, !rtt._cleared, true, true);
+                }
                 rtt._cleared = true;
             }
         }
@@ -3802,6 +3808,8 @@ var Scene = /** @class */ (function (_super) {
             step.action(this._renderTargets);
         }
         // Multi-cameras?
+        // save current active camera, following calls will change it, discarding user settings
+        var activeCamera = this._activeCamera;
         if (this.activeCameras && this.activeCameras.length > 0) {
             for (var cameraIndex = 0; cameraIndex < this.activeCameras.length; cameraIndex++) {
                 this._processSubCameras(this.activeCameras[cameraIndex], cameraIndex > 0);
@@ -3813,6 +3821,7 @@ var Scene = /** @class */ (function (_super) {
             }
             this._processSubCameras(this.activeCamera, !!this.activeCamera.outputRenderTarget);
         }
+        this._activeCamera = activeCamera;
         // Intersection checks
         this._checkIntersections();
         // Executes the after render stage actions.
@@ -3833,7 +3842,7 @@ var Scene = /** @class */ (function (_super) {
                     data.dispose();
                 }
             }
-            this._toBeDisposed = [];
+            this._toBeDisposed.length = 0;
         }
         if (this.dumpNextRenderTargets) {
             this.dumpNextRenderTargets = false;
@@ -3872,9 +3881,9 @@ var Scene = /** @class */ (function (_super) {
         this.beforeRender = null;
         this.afterRender = null;
         this.metadata = null;
-        this.skeletons = [];
-        this.morphTargetManagers = [];
-        this._transientComponents = [];
+        this.skeletons.length = 0;
+        this.morphTargetManagers.length = 0;
+        this._transientComponents.length = 0;
         this._isReadyForMeshStage.clear();
         this._beforeEvaluateActiveMeshStage.clear();
         this._evaluateSubMeshStage.clear();
@@ -3916,14 +3925,14 @@ var Scene = /** @class */ (function (_super) {
         this._materialsRenderTargets.dispose();
         this._registeredForLateAnimationBindings.dispose();
         this._meshesForIntersections.dispose();
-        this._toBeDisposed = [];
+        this._toBeDisposed.length = 0;
         // Abort active requests
         var activeRequests = this._activeRequests.slice();
         for (var _i = 0, activeRequests_1 = activeRequests; _i < activeRequests_1.length; _i++) {
             var request = activeRequests_1[_i];
             request.abort();
         }
-        this._activeRequests = [];
+        this._activeRequests.length = 0;
         // Events
         this.onDisposeObservable.notifyObservers(this);
         this.onDisposeObservable.clear();