@azure-id/orc 1.9.2 → 2.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +722 -0
- package/README-id.md +56 -42
- package/README.md +58 -41
- package/bin/build-agents.js +125 -29
- package/bin/clear-logs.js +620 -0
- package/bin/cli.js +1873 -180
- package/bin/fix.js +459 -0
- package/bin/gotcha-import.js +1081 -0
- package/bin/gotcha.js +1566 -0
- package/bin/graph-query.js +1 -1
- package/bin/graph.js +717 -717
- package/bin/habit.js +1538 -0
- package/bin/mockrun-catalog.js +284 -276
- package/bin/onboarding-content.js +2 -1
- package/bin/pricing.json +28 -21
- package/bin/run-undo.js +398 -0
- package/bin/trace-write.js +869 -0
- package/bin/verify-contracts.js +627 -100
- package/bin/verify-package.js +68 -10
- package/bin/webui/api.js +151 -6
- package/bin/webui/app.html +239 -232
- package/bin/webui/css/00-tokens.css +110 -92
- package/bin/webui/css/04-motion.css +87 -0
- package/bin/webui/css/06-responsive.css +203 -178
- package/bin/webui/css/panels/behaviour.css +205 -0
- package/bin/webui/css/panels/hookui.css +79 -0
- package/bin/webui/fixtures/behaviour.js +562 -0
- package/bin/webui/fixtures/extra.js +9 -9
- package/bin/webui/fixtures/flow.js +81 -81
- package/bin/webui/fixtures/hookui.js +506 -431
- package/bin/webui/fixtures/index.js +66 -3
- package/bin/webui/fixtures/knowledge.js +9 -3
- package/bin/webui/fixtures/maintenance.js +123 -42
- package/bin/webui/fixtures/rules.js +1007 -1002
- package/bin/webui/fixtures/settings.js +6 -7
- package/bin/webui/fixtures/stats.js +25 -6
- package/bin/webui/fixtures/wait.js +98 -97
- package/bin/webui/i18n/en/behaviour.json +156 -0
- package/bin/webui/i18n/en/hookui.json +290 -194
- package/bin/webui/i18n/en/maintenance.json +71 -52
- package/bin/webui/i18n/en/nav.json +25 -24
- package/bin/webui/i18n/en/settings.json +60 -60
- package/bin/webui/i18n/en/tour.json +37 -35
- package/bin/webui/i18n/id/behaviour.json +156 -0
- package/bin/webui/i18n/id/hookui.json +290 -194
- package/bin/webui/i18n/id/maintenance.json +71 -52
- package/bin/webui/i18n/id/nav.json +25 -24
- package/bin/webui/i18n/id/settings.json +60 -60
- package/bin/webui/i18n/id/tour.json +37 -35
- package/bin/webui/js/01-i18n.js +155 -154
- package/bin/webui/js/05-banners.js +181 -172
- package/bin/webui/js/06-edit.js +193 -183
- package/bin/webui/js/90-tour.js +498 -494
- package/bin/webui/js/91-shortcuts.js +126 -126
- package/bin/webui/js/99-boot.js +121 -118
- package/bin/webui/js/panels/behaviour.js +1087 -0
- package/bin/webui/js/panels/hookui.js +2196 -1691
- package/bin/webui/js/panels/maintenance.js +336 -235
- package/bin/webui/js/panels/settings.js +726 -719
- package/mock-run/INDEX.md +110 -107
- package/mock-run/extra-slots.md +1 -1
- package/mock-run/gotcha-import.md +118 -0
- package/mock-run/habits.md +129 -0
- package/mock-run/orc-aftermath.md +392 -392
- package/mock-run/orc-budget.md +29 -33
- package/mock-run/orc-cli.md +200 -200
- package/mock-run/orc-explain.md +86 -86
- package/mock-run/orc-extra.md +389 -392
- package/mock-run/orc-fix.md +87 -0
- package/mock-run/orc-pattern.md +112 -112
- package/mock-run/orc-quick.md +6 -1
- package/mock-run/orc.md +157 -157
- package/package.json +1 -1
- package/templates/agents/MODEL-MAPPING.md +37 -34
- package/templates/agents/orc-advisor-opus-5-xhigh.md +1 -7
- package/templates/agents/orc-analyze-mini-opus-5-med.md +1 -6
- package/templates/agents/orc-analyze-mini-sonnet-5-high.md +2 -5
- package/templates/agents/{orc-claude-writer-opus-4-8-high.md → orc-claude-writer-opus-5-low.md} +48 -53
- package/templates/agents/orc-context-combiner-opus-5-high.md +1 -11
- package/templates/agents/orc-executor-haiku-4-5.md +14 -6
- package/templates/agents/orc-executor-opus-4-7-high.md +14 -6
- package/templates/agents/orc-executor-opus-4-7-med.md +14 -6
- package/templates/agents/orc-executor-opus-4-8-high.md +14 -6
- package/templates/agents/orc-executor-opus-5-high.md +14 -6
- package/templates/agents/orc-executor-opus-5-low.md +14 -6
- package/templates/agents/orc-executor-opus-5-med.md +14 -6
- package/templates/agents/orc-executor-sonnet-4-6-high.md +14 -6
- package/templates/agents/orc-executor-sonnet-4-6-med.md +14 -6
- package/templates/agents/orc-executor-sonnet-5-high.md +15 -7
- package/templates/agents/orc-executor-sonnet-5-low.md +155 -0
- package/templates/agents/orc-executor-sonnet-5-med.md +155 -0
- package/templates/agents/orc-graph-noter-sonnet-4-6-med.md +1 -10
- package/templates/agents/orc-judge-opus-5-xhigh.md +5 -9
- package/templates/agents/orc-learn-writer-opus-5-low.md +1 -7
- package/templates/agents/orc-pattern-codifier-opus-5-med.md +1 -8
- package/templates/agents/orc-pattern-codifier-sonnet-5-high.md +58 -63
- package/templates/agents/orc-planner-mini-opus-5-med.md +1 -4
- package/templates/agents/orc-planner-mini-sonnet-5-high.md +2 -3
- package/templates/agents/orc-planner-opus-5-med.md +1 -4
- package/templates/agents/orc-recon-opus-5-low.md +1 -8
- package/templates/agents/orc-recon-sonnet-4-6-med.md +1 -8
- package/templates/agents/orc-retro-opus-5-med.md +6 -8
- package/templates/agents/orc-retro-sonnet-5-high.md +7 -8
- package/templates/agents/orc-reviewer-opus-5-low.md +96 -0
- package/templates/agents/orc-scout-opus-5-low.md +1 -6
- package/templates/agents/orc-scout-sonnet-4-6-high.md +35 -39
- package/templates/agents/orc-system-analyst-opus-5-high.md +1 -6
- package/templates/agents/orc-test-author-opus-5-med.md +4 -5
- package/templates/agents/orc-trace-writer-haiku-4-5.md +3 -7
- package/templates/agents/orc-verifier-opus-5-med.md +16 -8
- package/templates/agents/{orc-wiki-scanner-opus-4-8-high.md → orc-wiki-scanner-opus-5-low.md} +74 -79
- package/templates/agents/orc-wiki-scanner-sonnet-5-high.md +97 -106
- package/templates/commands/orc-analyze.md +13 -21
- package/templates/commands/orc-fast.md +10 -15
- package/templates/commands/orc-fix.md +18 -0
- package/templates/commands/orc-poly.md +12 -21
- package/templates/commands/orc-pr-driver.md +11 -30
- package/templates/commands/orc-pr-setup.md +10 -31
- package/templates/commands/orc-route.md +11 -41
- package/templates/commands/orc-test.md +5 -60
- package/templates/commands/orc-wiki.md +64 -64
- package/templates/hooks/README.md +109 -7
- package/templates/hooks/orc-session-hook.js +339 -0
- package/templates/hooks/orc-statusline-render.js +317 -23
- package/templates/hooks/orc-statusline.js +165 -50
- package/templates/hooks/orc-subagent-line.js +23 -5
- package/templates/hooks/orc-weather-fetch.js +123 -0
- package/templates/skills/_shared/README.md +9 -0
- package/templates/skills/_shared/code-graph.md +47 -55
- package/templates/skills/_shared/config-precedence.md +3 -1
- package/templates/skills/_shared/extra-dispatch.md +78 -93
- package/templates/skills/_shared/gotchas.md +248 -177
- package/templates/skills/_shared/habits.md +101 -0
- package/templates/skills/_shared/lane-contract.md +84 -0
- package/templates/skills/_shared/opus5-only.md +14 -14
- package/templates/skills/_shared/phases/README.md +142 -83
- package/templates/skills/_shared/phases/analyst-gates.md +10 -21
- package/templates/skills/_shared/phases/execution.md +8 -14
- package/templates/skills/_shared/phases/house-rules.md +27 -32
- package/templates/skills/_shared/phases/intake.md +127 -133
- package/templates/skills/_shared/phases/mock-example.md +46 -56
- package/templates/skills/_shared/phases/plan-handoff.md +91 -97
- package/templates/skills/_shared/phases/planning.md +7 -17
- package/templates/skills/_shared/phases/preflight.md +19 -42
- package/templates/skills/_shared/phases/review.md +24 -28
- package/templates/skills/_shared/phases/rules.md +18 -42
- package/templates/skills/_shared/phases/scoring.md +55 -65
- package/templates/skills/_shared/phases/security-checklist.md +46 -50
- package/templates/skills/_shared/phases/security.md +45 -55
- package/templates/skills/_shared/phases/ship.md +6 -15
- package/templates/skills/_shared/phases/stop-resume.md +2 -5
- package/templates/skills/_shared/phases/summary.md +73 -48
- package/templates/skills/_shared/phases/testgen.md +41 -51
- package/templates/skills/_shared/phases/trace-verbs.md +447 -0
- package/templates/skills/_shared/phases/trace.md +66 -297
- package/templates/skills/_shared/phases/verify.md +62 -70
- package/templates/skills/_shared/phases/wave-grouping.md +128 -133
- package/templates/skills/_shared/phases/wiki-consult.md +10 -6
- package/templates/skills/_shared/read-ladder.md +2 -55
- package/templates/skills/_shared/return-validation.md +17 -70
- package/templates/skills/_shared/review-slice.md +106 -0
- package/templates/skills/_shared/smoke-gate.md +46 -28
- package/templates/skills/_shared/wait.md +1 -0
- package/templates/skills/context-combiner/SKILL.md +15 -44
- package/templates/skills/orc/README.md +2 -2
- package/templates/skills/orc/SKILL.md +35 -63
- package/templates/skills/orc/config.md +25 -27
- package/templates/skills/orc/examples/full-run-mock.md +2 -1
- package/templates/skills/orc/references/effort-and-mode.md +17 -17
- package/templates/skills/orc/references/pattern-gate.md +89 -89
- package/templates/skills/orc/references/phases/intake.md +41 -47
- package/templates/skills/orc/references/phases/integration.md +13 -19
- package/templates/skills/orc/references/preflight-report.md +11 -12
- package/templates/skills/orc/references/ultra-mode.md +9 -7
- package/templates/skills/orc/schemas/checkpoint.md +122 -122
- package/templates/skills/orc/subskills/orc-execution/SKILL.md +27 -73
- package/templates/skills/orc/subskills/orc-execution/core.md +12 -99
- package/templates/skills/orc/subskills/orc-execution/subagent.md +14 -13
- package/templates/skills/orc/subskills/orc-review-verify/SKILL.md +12 -53
- package/templates/skills/orc/subskills/orc-review-verify/core.md +52 -135
- package/templates/skills/orc/subskills/orc-review-verify/subagent.md +7 -7
- package/templates/skills/orc/subskills/orc-testgen/SKILL.md +11 -22
- package/templates/skills/orc/subskills/orc-testgen/core.md +20 -59
- package/templates/skills/orc/subskills/orc-testgen/subagent.md +7 -7
- package/templates/skills/orc-advisor/SKILL.md +56 -60
- package/templates/skills/orc-analyze/SKILL.md +33 -67
- package/templates/skills/orc-analyze/schemas/report-audit.md +2 -1
- package/templates/skills/orc-analyze/schemas/report-prose.md +2 -1
- package/templates/skills/orc-analyze-mini/SKILL.md +35 -70
- package/templates/skills/orc-claude/SKILL.md +14 -14
- package/templates/skills/orc-claude/examples/claude-run-mock.md +65 -65
- package/templates/skills/orc-diy/README.md +31 -0
- package/templates/skills/orc-diy/SKILL.md +27 -78
- package/templates/skills/orc-diy/references/blocks/pattern.md +18 -18
- package/templates/skills/orc-fast/SKILL.md +49 -75
- package/templates/skills/orc-fix/SKILL.md +110 -0
- package/templates/skills/orc-judge/SKILL.md +77 -82
- package/templates/skills/orc-mini/SKILL.md +64 -112
- package/templates/skills/orc-mini/examples/mini-run-mock.md +4 -2
- package/templates/skills/orc-pattern/SKILL.md +27 -48
- package/templates/skills/orc-poly/SKILL.md +32 -61
- package/templates/skills/orc-pr-driver/SKILL.md +25 -51
- package/templates/skills/orc-pr-driver/references/green-gate.md +113 -105
- package/templates/skills/orc-pr-setup/SKILL.md +20 -45
- package/templates/skills/orc-quick/README.md +44 -3
- package/templates/skills/orc-quick/SKILL.md +77 -108
- package/templates/skills/orc-quick/references/dispatch-gate.md +18 -6
- package/templates/skills/orc-quick/references/gh-mode.md +50 -1
- package/templates/skills/orc-quick/references/look.md +3 -1
- package/templates/skills/orc-retro/SKILL.md +20 -19
- package/templates/skills/orc-retro/examples/retro-mock.md +17 -17
- package/templates/skills/orc-route/SKILL.md +25 -45
- package/templates/skills/orc-test/SKILL.md +16 -37
- package/templates/skills/orc-verify/SKILL.md +14 -32
- package/templates/skills/orc-wait/SKILL.md +156 -163
- package/templates/skills/orc-wiki/README.md +325 -325
- package/templates/skills/orc-wiki/SKILL.md +195 -195
- package/templates/skills/orc-wiki/examples/wiki-run-mock.md +37 -37
- package/templates/skills/orc-wiki/references/extra.md +2 -2
- package/templates/skills/orc-wiki/references/partial-refresh.md +276 -271
- package/templates/skills/orc-wiki/references/phases/phase-0.md +2 -7
- package/templates/skills/orc-wiki/references/phases/phase-1.md +1 -6
- package/templates/skills/orc-wiki/references/phases/phase-2.md +4 -9
- package/templates/skills/orc-wiki/references/phases/phase-3.md +1 -6
- package/templates/skills/orc-wiki/references/phases/phase-3c.md +4 -8
- package/templates/agents/orc-claude-writer-opus-5-med.md +0 -55
- package/templates/agents/orc-reviewer-opus-5-med.md +0 -60
- package/templates/agents/orc-wiki-scanner-opus-5-med.md +0 -81
|
@@ -1,16 +1,6 @@
|
|
|
1
1
|
# Phase — Planning (id: `planning`)
|
|
2
2
|
|
|
3
|
-
> **Shared phase file
|
|
4
|
-
> this library at W13 when `orc-diy` became its second reader. A spine is loaded
|
|
5
|
-
> IN FULL when its skill activates; this is loaded when the phase fires, and most
|
|
6
|
-
> runs skip most phases.
|
|
7
|
-
>
|
|
8
|
-
> **Two layers, and a lane reads exactly one.** `full` is `/orc`'s procedure.
|
|
9
|
-
> `composed` is what `orc diy compile` stitches — the same phase expressed as
|
|
10
|
-
> `<!-- diy:when -->` variants over a composed flow, NOT a second copy of the
|
|
11
|
-
> procedure. Reading the wrong one is the failure `README.md` names: a lane
|
|
12
|
-
> doing a phase its product promise says it does differently.
|
|
13
|
-
> `orc lane phases <lane> --json` names the layer for each lane.
|
|
3
|
+
> **Shared phase file** — read when the phase fires. A lane reads ONE layer: `full` (`/orc`) or `composed` (the `<!-- diy:when -->` variants `orc diy compile` stitches). `orc lane phases <lane> --json` names it.
|
|
14
4
|
|
|
15
5
|
<!-- orc:layer full -->
|
|
16
6
|
|
|
@@ -21,7 +11,7 @@ resolved values of every config key this run will consume (ALWAYS `opus5_only`
|
|
|
21
11
|
proof `/orc-retro` audits that the run honored the config.
|
|
22
12
|
**Wiki consult (load `wiki-consult.md`;
|
|
23
13
|
always report — no tier is silent):** read the FRESH/AGING/STALE tier from
|
|
24
|
-
**`orc wiki status`** (
|
|
14
|
+
**`orc wiki status`** (deterministic; never hand-compute it from `wiki-meta.json`), pull the relevant pages (incl. cross-cutting maps like `orc-reference-api-surface`), apply
|
|
25
15
|
`code > fresh wiki > stale wiki (hints) > model priors`, emit
|
|
26
16
|
`WIKI-CONSULT <tier> :: docs=<pages>`, print the one-line tier report (every tier, `absent` included), and attribute per-dispatch too — `wiki:` on the `DISPATCH` line + a `wiki_used` return (wiki-consult.md Step 5). **Crosslink:** per wiki-consult.md, inject
|
|
27
17
|
the cached `.claude/orc/crosslink/needs.json` contract into any boundary-touching
|
|
@@ -44,17 +34,17 @@ facets. Also run `orc graph cochange <each candidate file> --if-enabled --json -
|
|
|
44
34
|
it answers "what else will I have to touch" from HISTORY, which a static edge
|
|
45
35
|
cannot see. Co-change is a HINT about people, never a dependency — exit 4 means
|
|
46
36
|
this file changes alone, which is an answer. Exit 3 or 4 → plan exactly as before.
|
|
47
|
-
**Pact / boundary / aftermath / wiki debt (
|
|
37
|
+
**Pact / boundary / aftermath / wiki debt (all CONSUMED here, never
|
|
48
38
|
written here):** probe `orc pact status --json` (`pact_gate`, default `warn`),
|
|
49
39
|
`orc boundary status --json` (`boundary_gate`, default `warn`), `orc wiki debt
|
|
50
40
|
--json`, and — only to decide whether the preflight's `after:` line fires at all —
|
|
51
41
|
`orc aftermath status --json`. Print each probe's own `line` VERBATIM; never
|
|
52
42
|
recount or re-word one. Gates: `../../orc-pact/references/gate.md` +
|
|
53
|
-
`../../orc-boundary/references/gate.md`. **Challenge (
|
|
43
|
+
`../../orc-boundary/references/gate.md`. **Challenge (`challenge_gate`,
|
|
54
44
|
default `warn`):** when the run's INPUT DOCUMENT has a cycle, print
|
|
55
45
|
`orc challenge status <slug> --json`'s `preflight_line` verbatim — building from
|
|
56
46
|
a document that has not passed its own review is worth one line. There is no
|
|
57
|
-
`block` mode (the `/orc-pact` precedent). **Extra (
|
|
47
|
+
`block` mode (the `/orc-pact` precedent). **Extra (`extra_enabled`) —
|
|
58
48
|
resolved HERE, announced HERE, never silent:** load `../extra-dispatch.md`;
|
|
59
49
|
per task run `orc extra resolve <score> --role executor --risk <n> --json`, and
|
|
60
50
|
before wave 1 settle its two pre-dispatch states, both PRINTED — a `needs_reping`
|
|
@@ -63,7 +53,7 @@ profile (re-ping; a STALE profile still routes) and a vaulted credential, which
|
|
|
63
53
|
Claude rather than stopping the run. **Preflight:** print the compact block per
|
|
64
54
|
`../../orc/references/preflight-report.md` once wiki + crosslink (+ pattern/waves) resolve.
|
|
65
55
|
|
|
66
|
-
Ask which planner: **Superpowers / OpenSpec / Requirement Planner / ORC
|
|
56
|
+
Ask which planner (H `orc.phase-1.planner`): **Superpowers / OpenSpec / Requirement Planner / ORC
|
|
67
57
|
(self)**. With an analyst requirement-spec present, the Requirement Planner
|
|
68
58
|
is the natural choice (consumes the spec; does NOT re-question scope); apply
|
|
69
59
|
the `git_head` staleness valve first (analyst-gates.md). Dispatch the planner
|
|
@@ -80,7 +70,7 @@ only input that does NOT proceed to Phase 2 (each repo builds later, in its own
|
|
|
80
70
|
`../../orc/schemas/planning-output.md` (per-task `declared_files` incl. tests,
|
|
81
71
|
`grounding[]`, `acceptance[]`, `requirements[]`, `spec_invariants[]`,
|
|
82
72
|
`depends_on`, `owns_area`, `spec_ref`, + a `coverage` echo, + `tdd_spec` —
|
|
83
|
-
TDD is ALWAYS ON in full orc/ultra but **SCOPED to what can actually fail
|
|
73
|
+
TDD is ALWAYS ON in full orc/ultra but **SCOPED to what can actually fail**: a `disposition` per entry (`new-surface | behavior-change | covered-by-existing | no-behavior | no-runner`) DERIVED from the planner's facets — constants/translations/file-splits get NO test, a cited `risk[]` is never scoped out, and a PAIRED task materializes it, never a Wave 0 (schema notes 7-8; gate check 5);
|
|
84
74
|
missing declared files → extract and confirm before leaving this phase.
|
|
85
75
|
|
|
86
76
|
**Phase 1 exit gate** (deterministic — full checks in analyst-gates.md; emit
|
|
@@ -1,14 +1,6 @@
|
|
|
1
1
|
# Phase — Preflight (id: `preflight`)
|
|
2
2
|
|
|
3
|
-
> **Library file.**
|
|
4
|
-
> sections that had independently converged on the same four steps in the same
|
|
5
|
-
> order. Layers: `core` (every lane with a silent preflight) and `full`
|
|
6
|
-
> (`/orc` and `/orc-ultra`, whose preflight also PRINTS a report).
|
|
7
|
-
>
|
|
8
|
-
> **What is NOT here:** the probes themselves. Which artifacts a lane probes, and
|
|
9
|
-
> which config keys it reads, are the lane's own — they are in the lane's spine
|
|
10
|
-
> and in `orc lane config <lane> --json`. This file is the SHAPE: the order, and
|
|
11
|
-
> the four rules that make the shape worth having.
|
|
3
|
+
> **Library file.** `core` = every lane with a silent preflight; `full` = `/orc` and `/orc-ultra`, which also PRINT a report. This file is the SHAPE; the probes and config keys are the lane's own (its spine and `orc lane config <lane> --json`).
|
|
12
4
|
|
|
13
5
|
<!-- orc:layer core -->
|
|
14
6
|
|
|
@@ -22,17 +14,17 @@ never a fifth step before step 2.
|
|
|
22
14
|
yourself. Print every line of `announce[]` VERBATIM — *a shadowed setting must
|
|
23
15
|
never be silent*, and a lane that resolves silently cannot tell the user why
|
|
24
16
|
the thing they configured did not happen. Precedence, gates, inertness and the
|
|
25
|
-
CLI-absent floor are all in `../config-precedence.md`.
|
|
17
|
+
CLI-absent floor are all in `../config-precedence.md`. **`habits{}` in the
|
|
18
|
+
answer → print `habits.line` and read `../habits.md` NOW**.
|
|
26
19
|
|
|
27
20
|
2. **Trace.** Write `log_dir/.current` = `run-<lane>-<slug>-<DDMMYY>-<HHMMSS>.txt`
|
|
28
21
|
AND `touch the trace file` of that name in the SAME step. **Both, or neither.**
|
|
29
|
-
|
|
30
|
-
dangling one — that split fifteen graded runs across two files each. The rest
|
|
31
|
-
of the protocol is `trace.md`.
|
|
22
|
+
The rest of the protocol is `trace.md`.
|
|
32
23
|
|
|
33
|
-
3. **Probes.**
|
|
34
|
-
|
|
35
|
-
|
|
24
|
+
3. **Probes.** Read each probe's answer from `probes{}` in the step-1 answer.
|
|
25
|
+
Run a probe yourself only when `probes{}` does not have it or its entry has
|
|
26
|
+
`error` — by `../detecting-artifacts.md`, **never a raw `find`** (`.claude/`
|
|
27
|
+
is hidden). Every probe is a documented exit-code contract, listed
|
|
36
28
|
once in `orc lane calls <lane>`. Treat a positive probe as the source of truth
|
|
37
29
|
and never second-guess it.
|
|
38
30
|
|
|
@@ -55,27 +47,12 @@ never a fifth step before step 2.
|
|
|
55
47
|
ledger yet, this is a first run"; `orc gotcha status` exit 1 is an empty
|
|
56
48
|
ledger. Say what it means, not that it failed.
|
|
57
49
|
|
|
58
|
-
## The rules line
|
|
50
|
+
## The rules line — printed by every lane that runs the `rules` phase
|
|
59
51
|
|
|
60
|
-
`orc rules slice --lane <lane> --json`
|
|
52
|
+
Print `probes["rules-slice"].line` (`orc rules slice --lane <lane> --json`) VERBATIM — both spellings and the override names are `./rules.md` §One assembler and §Precedence.
|
|
53
|
+
`/orc-doc` prints `house rules: …` from `orc doc rules` instead; the two surfaces never mix.
|
|
61
54
|
|
|
62
|
-
|
|
63
|
-
rules: ORC 65 (W 23 · C 22 · D 10 · U 10) · yours 9 lines (P0 4 · P1 2 · P2 3) · 1 override
|
|
64
|
-
rules: ORC 65 (W 23 · C 22 · D 10 · U 10) · yours none
|
|
65
|
-
```
|
|
66
|
-
|
|
67
|
-
**Both spellings are mandatory in their state.** `yours none` says the project
|
|
68
|
-
has not written its own rules — a different fact from the CLI failing to look,
|
|
69
|
-
and the line is what keeps the two apart. Never compute the counts here.
|
|
70
|
-
|
|
71
|
-
Where the lane's preflight prints a REPORT rather than a bare line, the report
|
|
72
|
-
names each override under it. An override the user cannot see is an override
|
|
73
|
-
they cannot audit. The rest of the mechanic is `./rules.md`.
|
|
74
|
-
|
|
75
|
-
`/orc-doc` prints `house rules: …` instead, from `orc doc rules`. The two
|
|
76
|
-
surfaces are different files and never mix.
|
|
77
|
-
|
|
78
|
-
## The usage line (v1.1.0) — printed whenever `usage_gate` is armed
|
|
55
|
+
## The usage line — printed whenever `usage_gate` is armed
|
|
79
56
|
|
|
80
57
|
`usage_gate` resolves in step 1 like any other key. When it is anything but
|
|
81
58
|
`off`, run `orc usage check --json` in step 3 and print ONE line:
|
|
@@ -97,14 +74,14 @@ and again at every gate it suppresses. The rest of the mechanic — the modes, t
|
|
|
97
74
|
hops, what `stop` and `wait` actually do — is `../wait.md`; this file only says
|
|
98
75
|
that the line is printed and when.
|
|
99
76
|
|
|
100
|
-
## The graph line
|
|
77
|
+
## The graph line — code-changing lanes only
|
|
101
78
|
|
|
102
|
-
`/orc`, `/orc-ultra`, `/orc-diy`, `/orc-mini`, `/orc-fast` and `/orc-quick`
|
|
103
|
-
`
|
|
104
|
-
dispatch — never skipped.
|
|
105
|
-
|
|
106
|
-
|
|
107
|
-
|
|
79
|
+
`/orc`, `/orc-ultra`, `/orc-diy`, `/orc-mini`, `/orc-fast` and `/orc-quick` print
|
|
80
|
+
`probes["graph-status"].line` (`off` included) in step 3, BEFORE the first
|
|
81
|
+
dispatch — never skipped. Run `orc graph status --if-enabled --heal --json --brief`
|
|
82
|
+
only when `heal_needed` is true (it builds or updates the graph, free). Put the
|
|
83
|
+
`trace` (`GRAPH-CONSULT …`) in the next packet as it is — never as a `GATE` line
|
|
84
|
+
in your own words. While the graph is
|
|
108
85
|
on, `orc lane config` prints the three graph steps in `announce[]` (`../code-graph.md`
|
|
109
86
|
§0). **The lane reads no `code_graph` key:** `--if-enabled`
|
|
110
87
|
makes the CLI decide, which is how `/orc-quick` takes part while its step 1 still
|
|
@@ -1,38 +1,32 @@
|
|
|
1
1
|
# Phase — Review (id: `review`)
|
|
2
2
|
|
|
3
|
-
> **Shared phase file
|
|
4
|
-
> this library at W13 when `orc-diy` became its second reader. A spine is loaded
|
|
5
|
-
> IN FULL when its skill activates; this is loaded when the phase fires, and most
|
|
6
|
-
> runs skip most phases.
|
|
7
|
-
>
|
|
8
|
-
> **Two layers, and a lane reads exactly one.** `full` is `/orc`'s procedure.
|
|
9
|
-
> `composed` is what `orc diy compile` stitches — the same phase expressed as
|
|
10
|
-
> `<!-- diy:when -->` variants over a composed flow, NOT a second copy of the
|
|
11
|
-
> procedure. Reading the wrong one is the failure `README.md` names: a lane
|
|
12
|
-
> doing a phase its product promise says it does differently.
|
|
13
|
-
> `orc lane phases <lane> --json` names the layer for each lane.
|
|
3
|
+
> **Shared phase file** — read when the phase fires. A lane reads ONE layer: `full` (`/orc`) or `composed` (the `<!-- diy:when -->` variants `orc diy compile` stitches). `orc lane phases <lane> --json` names it.
|
|
14
4
|
|
|
15
5
|
<!-- orc:layer full -->
|
|
16
6
|
|
|
17
7
|
## Review (load ../../orc/subskills/orc-review-verify/, spawned)
|
|
18
8
|
|
|
19
|
-
Emit `PHASE review start`.
|
|
20
|
-
|
|
9
|
+
Emit `PHASE review start`. **Build the slice from `../review-slice.md`** — its
|
|
10
|
+
§1 free check FIRST, then its §2 fields (with the graph on, `graph_changes` keeps
|
|
11
|
+
its rows: no `--brief` here). Superpowers path: its review skill incl. tests
|
|
12
|
+
(Sonnet 4.6 medium), then `../review-slice.md` §3 on its findings — no second
|
|
13
|
+
dispatch. OpenSpec/self path: review worker (Opus 5.5 low). Pass the resolved
|
|
21
14
|
`code_pattern` + its invariants + gate lines for the re-check
|
|
22
|
-
(pattern-gate.md); no resolved pattern → FIRST ask for one (paste/md/none).
|
|
15
|
+
(pattern-gate.md); no resolved pattern → FIRST ask for one (paste/md/none) (H `orc.phase-5.pattern-missing`).
|
|
23
16
|
FE tasks in run → pass `fe_rules[]` from `../../orc-pattern/references/` fe-a11y
|
|
24
|
-
+ fe-perf.
|
|
25
|
-
`orc graph changes --if-enabled --json` — the symbols THIS diff's hunks overlap,
|
|
26
|
-
each with its callers, its tests and a risk word that carries its own reason.
|
|
27
|
-
**This one read keeps its rows: no `--brief` here**, because the reviewer is
|
|
28
|
-
handed `symbols[].caller_files` and reads them. It
|
|
29
|
-
replaces a whole-file `orc graph impact` here: a file card reports every symbol in
|
|
30
|
-
a touched file, and a symbol nobody edited is not a finding. An unchanged caller of
|
|
31
|
-
a changed signature is a finding candidate, anchored like any other. Findings arrive on the **P0–P3 ladder** (invariant violation or
|
|
17
|
+
+ fe-perf. Findings arrive on the **P0–P3 ladder** (invariant violation or
|
|
32
18
|
unmet gate line = P0; every P0–P2 carries `file:line` + VERBATIM `quote`;
|
|
33
|
-
unanchored → P3).
|
|
34
|
-
|
|
35
|
-
|
|
19
|
+
unanchored → P3). Run `../review-slice.md` §3 (the after-filter) on the return.
|
|
20
|
+
**Disprove pass (R6, `/orc` and `/orc-ultra` ONLY):** a P0 or P1 left → dispatch
|
|
21
|
+
the SAME reviewer with `mode: disprove`, only those findings + their files; a
|
|
22
|
+
`keep: false` verdict → P3 with its `why`. Then apply hard rule 5 INCLUDING the
|
|
23
|
+
quote spot-check, per `group`: P0 →
|
|
24
|
+
auto-fix once · P1 → ask, then fix once · P2/P3 → record for Phase 7.
|
|
25
|
+
**Re-review (R9):** after a P0/P1 fix, dispatch the reviewer once more with
|
|
26
|
+
`previous_findings[]` (each with its outcome). It may raise a NEW finding only
|
|
27
|
+
on a line the fix changed. Its `gotcha_recorded` body → `orc gotcha add -`. Emit
|
|
28
|
+
`FINDING p0=<n> p1=<n> p2=<n> p3=<n> pre=<n> suppressed=<n> folded=<n>` on the
|
|
29
|
+
return (the tail = the §3 buckets), then `PHASE review end`. Outcomes: Phase 7.
|
|
36
30
|
|
|
37
31
|
<!-- /orc:layer -->
|
|
38
32
|
|
|
@@ -47,12 +41,14 @@ skipped by flow config") — never imply the work was reviewed.
|
|
|
47
41
|
<!-- diy:when review=on -->
|
|
48
42
|
Dispatch the reviewer exactly as the full lane does — follow the review half
|
|
49
43
|
of `.claude/skills/orc/subskills/orc-review-verify/SKILL.md` (reviewer agent
|
|
50
|
-
`orc-reviewer-opus-5-
|
|
51
|
-
locked rules, blocking and advisory findings both surfaced).
|
|
44
|
+
`orc-reviewer-opus-5-low`; findings ride the severity ladder from the
|
|
45
|
+
locked rules, blocking and advisory findings both surfaced). Build its slice
|
|
46
|
+
from `.claude/skills/_shared/review-slice.md` (§1 free check, §3 after-filter).
|
|
52
47
|
<!-- /diy:when -->
|
|
53
48
|
<!-- diy:when review=blocking-only -->
|
|
54
49
|
Dispatch the reviewer exactly as the full lane does — follow the review half
|
|
55
|
-
of `.claude/skills/orc/subskills/orc-review-verify/SKILL.md
|
|
50
|
+
of `.claude/skills/orc/subskills/orc-review-verify/SKILL.md`, with the slice
|
|
51
|
+
of `.claude/skills/_shared/review-slice.md` — but only
|
|
56
52
|
P0/P1 findings gate anything; P2/P3 findings are listed once in the summary
|
|
57
53
|
and never re-offered as fix-up tasks.
|
|
58
54
|
<!-- /diy:when -->
|
|
@@ -1,18 +1,6 @@
|
|
|
1
1
|
# Phase — Rules (id: `rules`)
|
|
2
2
|
|
|
3
|
-
> **Library file
|
|
4
|
-
> for the same reason `house-rules.md` is: it is a standing card injected
|
|
5
|
-
> VERBATIM into a slice, and a layered card would be a different card. What
|
|
6
|
-
> varies between lanes is DATA (which packs, whether a task is front-end), not
|
|
7
|
-
> prose. `orc lane phases <lane> --json` names the file and the layers to read.
|
|
8
|
-
>
|
|
9
|
-
> **What is NOT here:** the rules. They are `../rules/` — four packs, read-only,
|
|
10
|
-
> shipped. This file is the SHAPE: who assembles the card, where it sits in a
|
|
11
|
-
> slice, what comes back, and what the phase must never do.
|
|
12
|
-
>
|
|
13
|
-
> **`/orc-doc` does not run this phase.** That lane has its own ledger
|
|
14
|
-
> (`orc doc rules`) and its own frozen-per-document mechanic. Excluded means
|
|
15
|
-
> excluded, and `orc rules slice --lane orc-doc` refuses by name.
|
|
3
|
+
> **Library file**, `core` only (a standing card, like `house-rules.md`). The rules are in `../rules/`; this file is the SHAPE. **`/orc-doc` does not run this phase** — it has `orc doc rules`, and `orc rules slice --lane orc-doc` refuses by name.
|
|
16
4
|
|
|
17
5
|
<!-- orc:layer core -->
|
|
18
6
|
|
|
@@ -118,11 +106,8 @@ structural and safety rules.
|
|
|
118
106
|
A rule that asks for one of those comes back as `unsupported_request` and is
|
|
119
107
|
relayed as a gap. **Never a guessed compromise.**
|
|
120
108
|
|
|
121
|
-
|
|
122
|
-
|
|
123
|
-
validator that sometimes works is worse than none, because a clean pass then
|
|
124
|
-
means nothing. The agent is the only reader that can tell a content rule from a
|
|
125
|
-
structural one, so the agent is where the answer comes from.
|
|
109
|
+
The CLI declares this boundary and does not enforce it. The agent is the only
|
|
110
|
+
reader that can tell a content rule from a structural one.
|
|
126
111
|
|
|
127
112
|
## The free lint
|
|
128
113
|
|
|
@@ -144,29 +129,20 @@ An exemption is never silent either. The lint skips the rules packs themselves
|
|
|
144
129
|
(a rule that bans a word has to print that word to define it) and any file
|
|
145
130
|
marked `orc-rules-ignore-file`, and it reports the count of both.
|
|
146
131
|
|
|
147
|
-
##
|
|
148
|
-
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
156
|
-
|
|
157
|
-
|
|
158
|
-
|
|
159
|
-
|
|
160
|
-
|
|
161
|
-
|
|
162
|
-
worked examples come out, with the pack file named beside them. Measured
|
|
163
|
-
**13 874 → 5 838 chars** (~3 470 → ~1 460 tokens) with every HARD id still
|
|
164
|
-
present. The lane that gets it is the lane with the smallest tasks under the
|
|
165
|
-
largest fixed card, and the card is re-sent on every executor turn.
|
|
166
|
-
|
|
167
|
-
The answer says which form it is: `compact: true` in the JSON. A reader that
|
|
168
|
-
cannot tell a short card from a stripped one cannot trust either. `line` is
|
|
169
|
-
IDENTICAL in both forms — it counts the rules in force, and compacting changes
|
|
170
|
-
how a rule is written, never whether it applies.
|
|
132
|
+
## The COMPACT card
|
|
133
|
+
|
|
134
|
+
`orc-quick` gets the COMPACT form: every HARD rule keeps its id, its title and
|
|
135
|
+
its first line. `orc-mini` and `orc-fast` get it too, because `rules_card_compact`
|
|
136
|
+
is `on` by default since v2.0.2 (eval E4 passed, DE-17); `off` gives them the full
|
|
137
|
+
card. The CLI decides this, never the lane. The answer says `compact: true` in the JSON. `line` is IDENTICAL in
|
|
138
|
+
both forms.
|
|
139
|
+
|
|
140
|
+
## The LEARNED tier
|
|
141
|
+
|
|
142
|
+
With `habits` on, the card can carry **learned preferences** (commit, branch
|
|
143
|
+
and test-file naming, from `orc habit repo`). Each one rides only after your
|
|
144
|
+
yes. They sit BELOW your rules and ABOVE the ORC rules. A preference that no
|
|
145
|
+
longer matches 4 of the last 5 samples is `stale` and leaves the card. Under
|
|
146
|
+
`habits: off` the slice has no `learned` field and no byte of this tier.
|
|
171
147
|
|
|
172
148
|
<!-- /orc:layer -->
|
|
@@ -1,65 +1,55 @@
|
|
|
1
|
-
# Phase — Effort & scoring (id: `scoring`)
|
|
2
|
-
|
|
3
|
-
> **Shared phase file
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
**
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
|
|
49
|
-
|
|
50
|
-
|
|
51
|
-
|
|
52
|
-
|
|
53
|
-
|
|
54
|
-
|
|
55
|
-
|
|
56
|
-
{{score_table}}
|
|
57
|
-
<!-- /diy:when -->
|
|
58
|
-
<!-- diy:when scoring=off -->
|
|
59
|
-
Scoring is DISABLED in this flow. Skip the rubric entirely: EVERY execution
|
|
60
|
-
task dispatches to **{{fixed_executor}}**. Wave grouping, declared-files
|
|
61
|
-
conflict rules, and slice construction are unchanged — scoring off changes
|
|
62
|
-
model selection only, never scheduling.
|
|
63
|
-
<!-- /diy:when -->
|
|
64
|
-
|
|
65
|
-
<!-- /orc:layer -->
|
|
1
|
+
# Phase — Effort & scoring (id: `scoring`)
|
|
2
|
+
|
|
3
|
+
> **Shared phase file** — read when the phase fires. A lane reads ONE layer: `full` (`/orc`) or `composed` (the `<!-- diy:when -->` variants `orc diy compile` stitches). `orc lane phases <lane> --json` names it.
|
|
4
|
+
|
|
5
|
+
<!-- orc:layer full -->
|
|
6
|
+
|
|
7
|
+
## Effort, dispatch style, scoring (load ../../orc/references/effort-and-mode.md)
|
|
8
|
+
|
|
9
|
+
Emit `PHASE scoring start`. Refine effort; recommend **sequential** vs
|
|
10
|
+
**parallel** dispatch (worktrees for high-effort independent features) — user
|
|
11
|
+
confirms (H `orc.phase-2.execution`). Dispatch style is **intra-wave concurrency only**: waves are computed
|
|
12
|
+
regardless of style (sequential runs have waves too, see wave-grouping.md), so
|
|
13
|
+
the batch pause always binds to wave numbers. **Batch-pause schedule (deterministic, not a cadence hint):** the plan
|
|
14
|
+
has K waves — ask (H `orc.phase-2.pause`) "pause after every wave / every 2nd / run straight through?"
|
|
15
|
+
and SHOW the resulting stop list ("will pause after waves [list]"); a 2-wave
|
|
16
|
+
plan plainly offers "pause after wave 1". Store it as `pause_schedule`, recompute
|
|
17
|
+
each wave's `is_batch_pause` (last wave never pauses). **Facet-validation gate
|
|
18
|
+
(deterministic):** recompute `breadth` + `fan_in`/`fan_out` from the plan; a
|
|
19
|
+
mismatch or an uncited `risk` entry bounces the plan (grounding mechanics).
|
|
20
|
+
**Score every task** from its `facets` via the fixed formula, map to the model
|
|
21
|
+
ladder, show the facet vector + arithmetic table, and emit `SCORE task=<id>
|
|
22
|
+
score=<n> band=<band> model=<m> facets=<vector> :: <reason>` per task; a score
|
|
23
|
+
override needs a written reason (logged). **With `extra_enabled`** the table gains
|
|
24
|
+
a `via` column and its head can name TWO tables (effort-and-mode.md); a foreign
|
|
25
|
+
task's `SCORE` appends `via=extra:<profile>` and `model=` is the FOREIGN model id.
|
|
26
|
+
**Cited-risk hold-back (deterministic, beside the facet gate):** a foreign-routed
|
|
27
|
+
task with a non-empty `risk[]` is HELD BACK to its Claude band (`extra_risk_tasks`
|
|
28
|
+
defaults to `off`) and every one is LISTED with its cited risk — a silently
|
|
29
|
+
held-back task is indistinguishable from a forgotten one. Use the wiki's "Notes for planning" to sharpen
|
|
30
|
+
core/isolated + risk factors. **Tag each task's pattern domain+language**
|
|
31
|
+
(+ secondary `db: postgres`) per `../../orc/references/pattern-gate.md`. Ask: "Any
|
|
32
|
+
anticipated escalations, or run straight through?" Emit `PHASE scoring end`.
|
|
33
|
+
|
|
34
|
+
<!-- /orc:layer -->
|
|
35
|
+
|
|
36
|
+
<!-- orc:layer composed -->
|
|
37
|
+
|
|
38
|
+
## Phase: Task scoring → executor selection
|
|
39
|
+
|
|
40
|
+
<!-- diy:when scoring=on -->
|
|
41
|
+
Score each task 0–100 with the full lane's rubric (see the scoring section of
|
|
42
|
+
`.claude/skills/orc/SKILL.md`), then dispatch the executor agent from THIS
|
|
43
|
+
compiled table — it is already clipped to this flow's session tier; never
|
|
44
|
+
substitute a preset from `config.md`:
|
|
45
|
+
|
|
46
|
+
{{score_table}}
|
|
47
|
+
<!-- /diy:when -->
|
|
48
|
+
<!-- diy:when scoring=off -->
|
|
49
|
+
Scoring is DISABLED in this flow. Skip the rubric entirely: EVERY execution
|
|
50
|
+
task dispatches to **{{fixed_executor}}**. Wave grouping, declared-files
|
|
51
|
+
conflict rules, and slice construction are unchanged — scoring off changes
|
|
52
|
+
model selection only, never scheduling.
|
|
53
|
+
<!-- /diy:when -->
|
|
54
|
+
|
|
55
|
+
<!-- /orc:layer -->
|
|
@@ -1,50 +1,46 @@
|
|
|
1
|
-
# Phase — Security pass (id: `security-checklist`)
|
|
2
|
-
|
|
3
|
-
> **Library file
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
17
|
-
|
|
18
|
-
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
23
|
-
|
|
24
|
-
|
|
25
|
-
|
|
26
|
-
|
|
27
|
-
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
44
|
-
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
12. **Crypto misuse** — home-rolled hashing/encryption, weak algorithms (MD5,
|
|
48
|
-
SHA1 for passwords), missing salts, static IVs in the diff.
|
|
49
|
-
|
|
50
|
-
<!-- /orc:layer -->
|
|
1
|
+
# Phase — Security pass (id: `security-checklist`)
|
|
2
|
+
|
|
3
|
+
> **Library file** (`orc`, `orc-diy`), `core` only: an opt-in pass runs its checklist or does not run.
|
|
4
|
+
|
|
5
|
+
<!-- orc:layer core -->
|
|
6
|
+
## Reference — Security-Pass Checklist (Phase 5.5, opt-in)
|
|
7
|
+
|
|
8
|
+
Loaded ONLY when the Phase 5.5 security pass fires (config `security_review`
|
|
9
|
+
`on`/`ask` + a task scored ≥ 70 in the run). Passed to the reviewer as
|
|
10
|
+
`security_checklist[]` — the worker sweeps ONLY the run's changed files against
|
|
11
|
+
these items, wrapping Semgrep if it is already installed (never installing it).
|
|
12
|
+
|
|
13
|
+
Severity mapping (same P0–P3 ladder): an item the DIFF makes exploitable = P0 ·
|
|
14
|
+
a hardening gap on a touched path = P1 · defense-in-depth suggestions = P2/P3.
|
|
15
|
+
|
|
16
|
+
## Checklist (OWASP/STRIDE-derived, impact-ordered — the closed set; never extend ad hoc)
|
|
17
|
+
|
|
18
|
+
1. **Injection** — SQL/NoSQL/command/LDAP built from user input without
|
|
19
|
+
parameterization or a safe builder anywhere in the diff.
|
|
20
|
+
2. **Broken auth on new surface** — any new endpoint/route/handler reachable
|
|
21
|
+
without the auth check its siblings carry (spoofing).
|
|
22
|
+
3. **Broken authorization** — object/record access without an ownership or role
|
|
23
|
+
check (IDOR); privilege boundaries crossed by the new code (elevation).
|
|
24
|
+
4. **Secrets in code** — credentials, tokens, keys, or connection strings
|
|
25
|
+
hardcoded or logged; secrets reaching client bundles or responses
|
|
26
|
+
(information disclosure).
|
|
27
|
+
5. **Unvalidated input** — request bodies/params/headers/files used before
|
|
28
|
+
schema validation; mass-assignment of writable model fields (tampering).
|
|
29
|
+
6. **Injection into output** — XSS via unescaped user data in HTML/JS contexts;
|
|
30
|
+
unsafe redirects/headers from user input.
|
|
31
|
+
7. **Insecure data handling** — sensitive data stored/transmitted unencrypted,
|
|
32
|
+
PII in logs, cache keys/values leaking secrets.
|
|
33
|
+
8. **CSRF/replay on state changes** — new state-changing browser endpoints
|
|
34
|
+
without CSRF protection; missing idempotency where retries can double-apply
|
|
35
|
+
(repudiation/tampering).
|
|
36
|
+
9. **Resource exhaustion** — new unbounded loops/queries/uploads/allocations an
|
|
37
|
+
attacker controls (denial of service): missing pagination, no timeout, no
|
|
38
|
+
size cap.
|
|
39
|
+
10. **Dependency risk** — a newly added dependency that is unmaintained,
|
|
40
|
+
typosquat-suspicious, or pulled for something the stdlib/project already does.
|
|
41
|
+
11. **Error-path leaks** — stack traces, internal paths, or raw driver errors
|
|
42
|
+
surfaced to callers by the new error handling.
|
|
43
|
+
12. **Crypto misuse** — home-rolled hashing/encryption, weak algorithms (MD5,
|
|
44
|
+
SHA1 for passwords), missing salts, static IVs in the diff.
|
|
45
|
+
|
|
46
|
+
<!-- /orc:layer -->
|