@aztec/validator-client 0.0.1-commit.b655e406 → 0.0.1-commit.b9865e97

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (61) hide show
  1. package/README.md +325 -0
  2. package/dest/checkpoint_builder.d.ts +79 -0
  3. package/dest/checkpoint_builder.d.ts.map +1 -0
  4. package/dest/checkpoint_builder.js +251 -0
  5. package/dest/config.d.ts +1 -1
  6. package/dest/config.d.ts.map +1 -1
  7. package/dest/config.js +52 -13
  8. package/dest/duties/validation_service.d.ts +44 -16
  9. package/dest/duties/validation_service.d.ts.map +1 -1
  10. package/dest/duties/validation_service.js +104 -34
  11. package/dest/factory.d.ts +22 -11
  12. package/dest/factory.d.ts.map +1 -1
  13. package/dest/factory.js +11 -5
  14. package/dest/index.d.ts +3 -2
  15. package/dest/index.d.ts.map +1 -1
  16. package/dest/index.js +2 -1
  17. package/dest/key_store/ha_key_store.d.ts +99 -0
  18. package/dest/key_store/ha_key_store.d.ts.map +1 -0
  19. package/dest/key_store/ha_key_store.js +208 -0
  20. package/dest/key_store/index.d.ts +2 -1
  21. package/dest/key_store/index.d.ts.map +1 -1
  22. package/dest/key_store/index.js +1 -0
  23. package/dest/key_store/interface.d.ts +36 -6
  24. package/dest/key_store/interface.d.ts.map +1 -1
  25. package/dest/key_store/local_key_store.d.ts +10 -5
  26. package/dest/key_store/local_key_store.d.ts.map +1 -1
  27. package/dest/key_store/local_key_store.js +9 -5
  28. package/dest/key_store/node_keystore_adapter.d.ts +18 -5
  29. package/dest/key_store/node_keystore_adapter.d.ts.map +1 -1
  30. package/dest/key_store/node_keystore_adapter.js +18 -4
  31. package/dest/key_store/web3signer_key_store.d.ts +10 -11
  32. package/dest/key_store/web3signer_key_store.d.ts.map +1 -1
  33. package/dest/key_store/web3signer_key_store.js +9 -5
  34. package/dest/metrics.d.ts +16 -3
  35. package/dest/metrics.d.ts.map +1 -1
  36. package/dest/metrics.js +58 -30
  37. package/dest/proposal_handler.d.ts +134 -0
  38. package/dest/proposal_handler.d.ts.map +1 -0
  39. package/dest/proposal_handler.js +1072 -0
  40. package/dest/validator.d.ts +87 -24
  41. package/dest/validator.d.ts.map +1 -1
  42. package/dest/validator.js +520 -90
  43. package/package.json +24 -14
  44. package/src/checkpoint_builder.ts +417 -0
  45. package/src/config.ts +52 -11
  46. package/src/duties/validation_service.ts +170 -46
  47. package/src/factory.ts +37 -11
  48. package/src/index.ts +2 -1
  49. package/src/key_store/ha_key_store.ts +269 -0
  50. package/src/key_store/index.ts +1 -0
  51. package/src/key_store/interface.ts +44 -5
  52. package/src/key_store/local_key_store.ts +14 -5
  53. package/src/key_store/node_keystore_adapter.ts +28 -5
  54. package/src/key_store/web3signer_key_store.ts +18 -5
  55. package/src/metrics.ts +81 -33
  56. package/src/proposal_handler.ts +1161 -0
  57. package/src/validator.ts +739 -134
  58. package/dest/block_proposal_handler.d.ts +0 -52
  59. package/dest/block_proposal_handler.d.ts.map +0 -1
  60. package/dest/block_proposal_handler.js +0 -286
  61. package/src/block_proposal_handler.ts +0 -343
package/src/validator.ts CHANGED
@@ -1,43 +1,111 @@
1
+ import type { BlobClientInterface } from '@aztec/blob-client/client';
2
+ import { type Blob, getBlobsPerL1Block } from '@aztec/blob-lib';
1
3
  import type { EpochCache } from '@aztec/epoch-cache';
4
+ import { CheckpointNumber, EpochNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
5
+ import { Fr } from '@aztec/foundation/curves/bn254';
2
6
  import type { EthAddress } from '@aztec/foundation/eth-address';
3
7
  import type { Signature } from '@aztec/foundation/eth-signature';
4
- import { Fr } from '@aztec/foundation/fields';
5
- import { type Logger, createLogger } from '@aztec/foundation/log';
8
+ import { FifoSet } from '@aztec/foundation/fifo-set';
9
+ import { type LogData, type Logger, createLogger } from '@aztec/foundation/log';
6
10
  import { RunningPromise } from '@aztec/foundation/running-promise';
7
11
  import { sleep } from '@aztec/foundation/sleep';
8
12
  import { DateProvider } from '@aztec/foundation/timer';
9
13
  import type { KeystoreManager } from '@aztec/node-keystore';
10
- import type { P2P, PeerId, TxProvider } from '@aztec/p2p';
14
+ import type { DuplicateAttestationInfo, DuplicateProposalInfo, P2P, PeerId } from '@aztec/p2p';
11
15
  import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
12
- import { OffenseType, WANT_TO_SLASH_EVENT, type Watcher, type WatcherEmitter } from '@aztec/slasher';
16
+ import {
17
+ OffenseType,
18
+ WANT_TO_CLEAR_SLASH_EVENT,
19
+ WANT_TO_SLASH_EVENT,
20
+ type Watcher,
21
+ type WatcherEmitter,
22
+ getOffenseTypeName,
23
+ } from '@aztec/slasher';
13
24
  import type { AztecAddress } from '@aztec/stdlib/aztec-address';
14
- import type { CommitteeAttestationsAndSigners, L2BlockSource } from '@aztec/stdlib/block';
15
- import type { IFullNodeBlockBuilder, Validator, ValidatorClientFullConfig } from '@aztec/stdlib/interfaces/server';
25
+ import type { CommitteeAttestationsAndSigners, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
26
+ import type { CheckpointReexecutionTracker } from '@aztec/stdlib/checkpoint';
27
+ import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
28
+ import type {
29
+ ITxProvider,
30
+ Validator,
31
+ ValidatorClientFullConfig,
32
+ WorldStateSynchronizer,
33
+ } from '@aztec/stdlib/interfaces/server';
16
34
  import type { L1ToL2MessageSource } from '@aztec/stdlib/messaging';
17
- import type { BlockAttestation, BlockProposal, BlockProposalOptions } from '@aztec/stdlib/p2p';
35
+ import {
36
+ type BlockProposal,
37
+ type BlockProposalOptions,
38
+ type CheckpointAttestation,
39
+ CheckpointProposal,
40
+ type CheckpointProposalCore,
41
+ type CheckpointProposalOptions,
42
+ type CoordinationSignatureContext,
43
+ } from '@aztec/stdlib/p2p';
18
44
  import type { CheckpointHeader } from '@aztec/stdlib/rollup';
19
- import type { StateReference, Tx } from '@aztec/stdlib/tx';
45
+ import type { BlockHeader, Tx } from '@aztec/stdlib/tx';
20
46
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
21
47
  import { type TelemetryClient, type Tracer, getTelemetryClient } from '@aztec/telemetry-client';
48
+ import {
49
+ createHASigner,
50
+ createLocalSignerWithProtection,
51
+ createSignerFromSharedDb,
52
+ } from '@aztec/validator-ha-signer/factory';
53
+ import { DutyType, type SigningContext, type SlashingProtectionDatabase } from '@aztec/validator-ha-signer/types';
54
+ import type { ValidatorHASigner } from '@aztec/validator-ha-signer/validator-ha-signer';
22
55
 
23
56
  import { EventEmitter } from 'events';
24
57
  import type { TypedDataDefinition } from 'viem';
25
58
 
26
- import { BlockProposalHandler, type BlockProposalValidationFailureReason } from './block_proposal_handler.js';
59
+ import type { FullNodeCheckpointsBuilder } from './checkpoint_builder.js';
27
60
  import { ValidationService } from './duties/validation_service.js';
61
+ import { HAKeyStore } from './key_store/ha_key_store.js';
62
+ import type { ExtendedValidatorKeyStore } from './key_store/interface.js';
28
63
  import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
29
64
  import { ValidatorMetrics } from './metrics.js';
65
+ import {
66
+ type BlockProposalValidationFailureReason,
67
+ type CheckpointProposalValidationFailureReason,
68
+ type CheckpointProposalValidationFailureResult,
69
+ ProposalHandler,
70
+ } from './proposal_handler.js';
30
71
 
31
72
  // We maintain a set of proposers who have proposed invalid blocks.
32
73
  // Just cap the set to avoid unbounded growth.
33
74
  const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
75
+ const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
76
+ const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
77
+ const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
34
78
 
35
79
  // What errors from the block proposal handler result in slashing
36
80
  const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT: BlockProposalValidationFailureReason[] = [
37
81
  'state_mismatch',
38
82
  'failed_txs',
83
+ 'global_variables_mismatch',
84
+ 'invalid_proposal',
85
+ 'parent_block_wrong_slot',
86
+ 'in_hash_mismatch',
39
87
  ];
40
88
 
89
+ const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT: Record<CheckpointProposalValidationFailureReason, boolean> = {
90
+ // enabled
91
+ ['invalid_fee_asset_price_modifier']: true,
92
+ ['checkpoint_header_mismatch']: true,
93
+ // These late mismatches should normally be caught by earlier checks, but if reached after validating the local
94
+ // checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
95
+ ['archive_mismatch']: true,
96
+ ['out_hash_mismatch']: true,
97
+ ['no_blocks_for_slot']: true,
98
+ ['too_many_blocks_in_checkpoint']: true,
99
+ ['checkpoint_validation_failed']: true,
100
+ ['last_block_archive_mismatch']: true,
101
+
102
+ // disabled
103
+ ['invalid_signature']: false,
104
+ ['last_block_not_found']: false,
105
+ ['block_fetch_error']: false,
106
+ ['checkpoint_already_published']: false,
107
+ };
108
+
41
109
  /**
42
110
  * Validator Client
43
111
  */
@@ -45,37 +113,65 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
45
113
  public readonly tracer: Tracer;
46
114
  private validationService: ValidationService;
47
115
  private metrics: ValidatorMetrics;
48
-
116
+ private log: Logger;
49
117
  // Whether it has already registered handlers on the p2p client
50
118
  private hasRegisteredHandlers = false;
51
119
 
52
- // Used to check if we are sending the same proposal twice
53
- private previousProposal?: BlockProposal;
120
+ /** Tracks the last block proposal we created, to detect duplicate proposal attempts. */
121
+ private lastProposedBlock?: BlockProposal;
54
122
 
55
- private lastEpochForCommitteeUpdateLoop: bigint | undefined;
123
+ /** Tracks the last checkpoint proposal we created. */
124
+ private lastProposedCheckpoint?: CheckpointProposal;
125
+
126
+ private lastEpochForCommitteeUpdateLoop: EpochNumber | undefined;
56
127
  private epochCacheUpdateLoop: RunningPromise;
128
+ /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */
129
+ private lastAttestedEpochByAttester: Map<string, EpochNumber> = new Map();
130
+
131
+ private proposersOfInvalidBlocks = FifoSet.withLimit<string>(MAX_PROPOSERS_OF_INVALID_BLOCKS);
132
+ private slotsWithInvalidProposals = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
133
+ private invalidCheckpointProposalOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS);
134
+ private badAttestationOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_BAD_ATTESTATIONS);
135
+ private slotsWithProposalEquivocation = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
57
136
 
58
- private proposersOfInvalidBlocks: Set<string> = new Set();
137
+ /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */
138
+ private lastAttestedProposal?: CheckpointProposalCore;
59
139
 
60
140
  protected constructor(
61
- private keyStore: NodeKeystoreAdapter,
141
+ private keyStore: ExtendedValidatorKeyStore,
62
142
  private epochCache: EpochCache,
63
143
  private p2pClient: P2P,
64
- private blockProposalHandler: BlockProposalHandler,
144
+ private proposalHandler: ProposalHandler,
145
+ private blockSource: L2BlockSource,
146
+ private checkpointsBuilder: FullNodeCheckpointsBuilder,
147
+ private worldState: WorldStateSynchronizer,
148
+ private l1ToL2MessageSource: L1ToL2MessageSource,
65
149
  private config: ValidatorClientFullConfig,
150
+ private blobClient: BlobClientInterface,
151
+ private slashingProtectionSigner: ValidatorHASigner,
66
152
  private dateProvider: DateProvider = new DateProvider(),
67
153
  telemetry: TelemetryClient = getTelemetryClient(),
68
- private log = createLogger('validator'),
154
+ log = createLogger('validator'),
69
155
  ) {
70
156
  super();
157
+
158
+ // Create child logger with fisherman prefix if in fisherman mode
159
+ this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
160
+
71
161
  this.tracer = telemetry.getTracer('Validator');
72
162
  this.metrics = new ValidatorMetrics(telemetry);
73
163
 
74
- this.validationService = new ValidationService(keyStore, log.createChild('validation-service'));
164
+ this.validationService = new ValidationService(
165
+ keyStore,
166
+ this.getSignatureContext(),
167
+ this.log.createChild('validation-service'),
168
+ );
169
+ this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo) =>
170
+ this.handleInvalidCheckpointProposal(proposal, result, proposalInfo),
171
+ );
75
172
 
76
173
  // Refresh epoch cache every second to trigger alert if participation in committee changes
77
- this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), log, 1000);
78
-
174
+ this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
79
175
  const myAddresses = this.getValidatorAddresses();
80
176
  this.log.verbose(`Initialized validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
81
177
  }
@@ -112,6 +208,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
112
208
  this.log.trace(`No committee found for slot`);
113
209
  return;
114
210
  }
211
+ this.metrics.setCurrentEpoch(epoch);
115
212
  if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
116
213
  const me = this.getValidatorAddresses();
117
214
  const committeeSet = new Set(committee.map(v => v.toString()));
@@ -132,40 +229,91 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
132
229
  }
133
230
  }
134
231
 
135
- static new(
232
+ static async new(
136
233
  config: ValidatorClientFullConfig,
137
- blockBuilder: IFullNodeBlockBuilder,
234
+ checkpointsBuilder: FullNodeCheckpointsBuilder,
235
+ worldState: WorldStateSynchronizer,
138
236
  epochCache: EpochCache,
139
237
  p2pClient: P2P,
140
- blockSource: L2BlockSource,
238
+ blockSource: L2BlockSource & L2BlockSink,
141
239
  l1ToL2MessageSource: L1ToL2MessageSource,
142
- txProvider: TxProvider,
240
+ txProvider: ITxProvider,
143
241
  keyStoreManager: KeystoreManager,
242
+ blobClient: BlobClientInterface,
243
+ reexecutionTracker: CheckpointReexecutionTracker,
144
244
  dateProvider: DateProvider = new DateProvider(),
145
245
  telemetry: TelemetryClient = getTelemetryClient(),
246
+ slashingProtectionDb?: SlashingProtectionDatabase,
146
247
  ) {
147
248
  const metrics = new ValidatorMetrics(telemetry);
148
249
  const blockProposalValidator = new BlockProposalValidator(epochCache, {
149
250
  txsPermitted: !config.disableTransactions,
251
+ maxTxsPerBlock: config.validateMaxTxsPerBlock,
252
+ maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
253
+ skipSlotValidation: config.skipProposalSlotValidation,
254
+ signatureContext: {
255
+ chainId: config.l1ChainId,
256
+ rollupAddress: config.rollupAddress,
257
+ },
150
258
  });
151
- const blockProposalHandler = new BlockProposalHandler(
152
- blockBuilder,
259
+ const proposalHandler = new ProposalHandler(
260
+ checkpointsBuilder,
261
+ worldState,
153
262
  blockSource,
154
263
  l1ToL2MessageSource,
155
264
  txProvider,
156
265
  blockProposalValidator,
266
+ epochCache,
157
267
  config,
268
+ blobClient,
269
+ reexecutionTracker,
158
270
  metrics,
159
271
  dateProvider,
160
272
  telemetry,
273
+ undefined,
161
274
  );
162
275
 
276
+ const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
277
+ let slashingProtectionSigner: ValidatorHASigner;
278
+ if (slashingProtectionDb) {
279
+ // Shared database mode: use a pre-existing database (e.g. for testing HA setups).
280
+ ({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
281
+ telemetryClient: telemetry,
282
+ dateProvider,
283
+ }));
284
+ } else if (config.haSigningEnabled) {
285
+ // Multi-node HA mode: use PostgreSQL-backed distributed locking.
286
+ // If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
287
+ const haConfig = {
288
+ ...config,
289
+ maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000,
290
+ };
291
+ ({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
292
+ telemetryClient: telemetry,
293
+ dateProvider,
294
+ }));
295
+ } else {
296
+ // Single-node mode: use LMDB-backed local signing protection.
297
+ // This prevents double-signing if the node crashes and restarts mid-proposal.
298
+ ({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
299
+ telemetryClient: telemetry,
300
+ dateProvider,
301
+ }));
302
+ }
303
+ const validatorKeyStore: ExtendedValidatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
304
+
163
305
  const validator = new ValidatorClient(
164
- NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager),
306
+ validatorKeyStore,
165
307
  epochCache,
166
308
  p2pClient,
167
- blockProposalHandler,
309
+ proposalHandler,
310
+ blockSource,
311
+ checkpointsBuilder,
312
+ worldState,
313
+ l1ToL2MessageSource,
168
314
  config,
315
+ blobClient,
316
+ slashingProtectionSigner,
169
317
  dateProvider,
170
318
  telemetry,
171
319
  );
@@ -179,22 +327,19 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
179
327
  .filter(addr => !this.config.disabledValidators.some(disabled => disabled.equals(addr)));
180
328
  }
181
329
 
182
- public getBlockProposalHandler() {
183
- return this.blockProposalHandler;
330
+ public getProposalHandler() {
331
+ return this.proposalHandler;
184
332
  }
185
333
 
186
- // Proxy method for backwards compatibility with tests
187
- public reExecuteTransactions(
188
- proposal: BlockProposal,
189
- blockNumber: number,
190
- txs: any[],
191
- l1ToL2Messages: Fr[],
192
- ): Promise<any> {
193
- return this.blockProposalHandler.reexecuteTransactions(proposal, blockNumber, txs, l1ToL2Messages);
334
+ public signWithAddress(addr: EthAddress, msg: TypedDataDefinition, context: SigningContext) {
335
+ return this.keyStore.signTypedDataWithAddress(addr, msg, context);
194
336
  }
195
337
 
196
- public signWithAddress(addr: EthAddress, msg: TypedDataDefinition) {
197
- return this.keyStore.signTypedDataWithAddress(addr, msg);
338
+ private getSignatureContext(): CoordinationSignatureContext {
339
+ return {
340
+ chainId: this.config.l1ChainId,
341
+ rollupAddress: this.config.rollupAddress,
342
+ };
198
343
  }
199
344
 
200
345
  public getCoinbaseForAttestor(attestor: EthAddress): EthAddress {
@@ -209,8 +354,27 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
209
354
  return this.config;
210
355
  }
211
356
 
357
+ public hasProposalEquivocation(slotNumber: SlotNumber): boolean {
358
+ return this.slotsWithProposalEquivocation.has(slotNumber);
359
+ }
360
+
361
+ public hasInvalidProposals(slotNumber: SlotNumber): boolean {
362
+ return this.slotsWithInvalidProposals.has(slotNumber);
363
+ }
364
+
212
365
  public updateConfig(config: Partial<ValidatorClientFullConfig>) {
213
366
  this.config = { ...this.config, ...config };
367
+ this.proposalHandler.updateConfig(config);
368
+ }
369
+
370
+ public reloadKeystore(newManager: KeystoreManager): void {
371
+ const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
372
+ this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
373
+ this.validationService = new ValidationService(
374
+ this.keyStore,
375
+ this.getSignatureContext(),
376
+ this.log.createChild('validation-service'),
377
+ );
214
378
  }
215
379
 
216
380
  public async start() {
@@ -219,18 +383,15 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
219
383
  return;
220
384
  }
221
385
 
386
+ await this.keyStore.start();
387
+
222
388
  await this.registerHandlers();
223
389
 
224
390
  const myAddresses = this.getValidatorAddresses();
225
391
  const inCommittee = await this.epochCache.filterInCommittee('now', myAddresses);
392
+ this.log.info(`Started validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
226
393
  if (inCommittee.length > 0) {
227
- this.log.info(
228
- `Started validator with addresses in current validator committee: ${inCommittee
229
- .map(a => a.toString())
230
- .join(', ')}`,
231
- );
232
- } else {
233
- this.log.info(`Started validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
394
+ this.log.info(`Addresses in current validator committee: ${inCommittee.map(a => a.toString()).join(', ')}`);
234
395
  }
235
396
  this.epochCacheUpdateLoop.start();
236
397
 
@@ -239,6 +400,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
239
400
 
240
401
  public async stop() {
241
402
  await this.epochCacheUpdateLoop.stop();
403
+ await this.keyStore.stop();
242
404
  }
243
405
 
244
406
  /** Register handlers on the p2p client */
@@ -247,9 +409,33 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
247
409
  this.hasRegisteredHandlers = true;
248
410
  this.log.debug(`Registering validator handlers for p2p client`);
249
411
 
250
- const handler = (block: BlockProposal, proposalSender: PeerId): Promise<BlockAttestation[] | undefined> =>
251
- this.attestToProposal(block, proposalSender);
252
- this.p2pClient.registerBlockProposalHandler(handler);
412
+ // Block proposal handler - validates but does NOT attest (validators only attest to checkpoints)
413
+ const blockHandler = (block: BlockProposal, proposalSender: PeerId): Promise<boolean> =>
414
+ this.validateBlockProposal(block, proposalSender);
415
+ this.p2pClient.registerBlockProposalHandler(blockHandler);
416
+
417
+ // Checkpoint proposal handler - validates and creates attestations
418
+ // The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
419
+ // and processed separately via the block handler above.
420
+ const checkpointHandler = (
421
+ checkpoint: CheckpointProposalCore,
422
+ proposalSender: PeerId,
423
+ ): Promise<CheckpointAttestation[] | undefined> => this.attestToCheckpointProposal(checkpoint, proposalSender);
424
+ this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
425
+
426
+ // Duplicate proposal handler - triggers slashing for equivocation
427
+ this.p2pClient.registerDuplicateProposalCallback((info: DuplicateProposalInfo) => {
428
+ this.handleDuplicateProposal(info);
429
+ });
430
+
431
+ // Duplicate attestation handler - triggers slashing for attestation equivocation
432
+ this.p2pClient.registerDuplicateAttestationCallback((info: DuplicateAttestationInfo) => {
433
+ this.handleDuplicateAttestation(info);
434
+ });
435
+
436
+ this.p2pClient.registerCheckpointAttestationCallback((attestation: CheckpointAttestation) => {
437
+ this.handleCheckpointAttestation(attestation);
438
+ });
253
439
 
254
440
  const myAddresses = this.getValidatorAddresses();
255
441
  this.p2pClient.registerThisValidatorAddresses(myAddresses);
@@ -258,44 +444,53 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
258
444
  }
259
445
  }
260
446
 
261
- async attestToProposal(proposal: BlockProposal, proposalSender: PeerId): Promise<BlockAttestation[] | undefined> {
262
- const slotNumber = proposal.slotNumber.toBigInt();
447
+ /**
448
+ * Validate a block proposal from a peer.
449
+ * Note: Validators do NOT attest to individual blocks - attestations are only for checkpoint proposals.
450
+ * @returns true if the proposal is valid, false otherwise
451
+ */
452
+ async validateBlockProposal(proposal: BlockProposal, proposalSender: PeerId): Promise<boolean> {
453
+ const slotNumber = proposal.slotNumber;
454
+
455
+ // Note: During escape hatch, we still want to "validate" proposals for observability,
456
+ // but we intentionally reject them and disable slashing invalid block and attestation flow.
457
+ const escapeHatchOpen = await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber);
458
+
263
459
  const proposer = proposal.getSender();
264
460
 
265
461
  // Reject proposals with invalid signatures
266
462
  if (!proposer) {
267
- this.log.warn(`Received proposal with invalid signature for slot ${slotNumber}`);
268
- return undefined;
463
+ this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
464
+ return false;
269
465
  }
270
466
 
271
- // Check that I have any address in current committee before attesting
467
+ // Log self-proposals from HA peers (same validator key on different nodes)
468
+ if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
469
+ this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
470
+ proposer: proposer.toString(),
471
+ slotNumber,
472
+ });
473
+ }
474
+
475
+ // Check if we're in the committee (for metrics purposes)
272
476
  const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
273
477
  const partOfCommittee = inCommittee.length > 0;
274
478
 
275
479
  const proposalInfo = { ...proposal.toBlockInfo(), proposer: proposer.toString() };
276
- this.log.info(`Received proposal for slot ${slotNumber}`, {
480
+ this.log.info(`Received block proposal for slot ${slotNumber}`, {
277
481
  ...proposalInfo,
278
482
  txHashes: proposal.txHashes.map(t => t.toString()),
483
+ fishermanMode: this.config.fishermanMode || false,
279
484
  });
280
485
 
281
- // Reexecute txs if we are part of the committee so we can attest, or if slashing is enabled so we can slash
282
- // invalid proposals even when not in the committee, or if we are configured to always reexecute for monitoring purposes.
283
- const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals } = this.config;
284
- const shouldReexecute =
285
- (slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute) ||
286
- (partOfCommittee && validatorReexecute) ||
287
- alwaysReexecuteBlockProposals;
288
-
289
- const validationResult = await this.blockProposalHandler.handleBlockProposal(
290
- proposal,
291
- proposalSender,
292
- !!shouldReexecute,
293
- );
486
+ // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
487
+ const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
294
488
 
295
489
  if (!validationResult.isValid) {
296
- this.log.warn(`Proposal validation failed: ${validationResult.reason}`, proposalInfo);
297
-
298
490
  const reason = validationResult.reason || 'unknown';
491
+
492
+ this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
493
+
299
494
  // Classify failure reason: bad proposal vs node issue
300
495
  const badProposalReasons: BlockProposalValidationFailureReason[] = [
301
496
  'invalid_proposal',
@@ -308,34 +503,228 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
308
503
  if (badProposalReasons.includes(reason as BlockProposalValidationFailureReason)) {
309
504
  this.metrics.incFailedAttestationsBadProposal(1, reason, partOfCommittee);
310
505
  } else {
311
- // Node issues so we can't attest
506
+ // Node issues so we can't validate
312
507
  this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
313
508
  }
314
509
 
315
- // Slash invalid block proposals (can happen even when not in committee)
316
510
  if (
511
+ !escapeHatchOpen &&
317
512
  validationResult.reason &&
318
- SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) &&
319
- slashBroadcastedInvalidBlockPenalty > 0n
513
+ SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)
320
514
  ) {
321
- this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
515
+ this.log.info(`Detected invalid block proposal offense`, {
516
+ ...proposalInfo,
517
+ amount: this.config.slashBroadcastedInvalidBlockPenalty,
518
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL),
519
+ });
322
520
  this.slashInvalidBlock(proposal);
521
+ this.markInvalidProposalSlot(proposal.slotNumber);
323
522
  }
523
+ return false;
524
+ }
525
+
526
+ this.log.info(`Validated block proposal for slot ${slotNumber}`, {
527
+ ...proposalInfo,
528
+ inCommittee: partOfCommittee,
529
+ fishermanMode: this.config.fishermanMode || false,
530
+ escapeHatchOpen,
531
+ });
532
+
533
+ if (escapeHatchOpen) {
534
+ this.log.warn(`Escape hatch open for slot ${slotNumber}, rejecting block proposal`, proposalInfo);
535
+ return false;
536
+ }
537
+
538
+ return true;
539
+ }
540
+
541
+ /**
542
+ * Validate and attest to a checkpoint proposal from a peer.
543
+ * The proposal is received as CheckpointProposalCore (without lastBlock) since
544
+ * the lastBlock is extracted and processed separately via the block handler.
545
+ * @returns Checkpoint attestations if valid, undefined otherwise
546
+ */
547
+ async attestToCheckpointProposal(
548
+ proposal: CheckpointProposalCore,
549
+ _proposalSender: PeerId,
550
+ ): Promise<CheckpointAttestation[] | undefined> {
551
+ const proposalSlotNumber = proposal.slotNumber;
552
+ const proposer = proposal.getSender();
553
+
554
+ // If escape hatch is open for this slot's epoch, do not attest.
555
+ if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
556
+ this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
557
+ return undefined;
558
+ }
559
+
560
+ // Early-out for equivocation: refuses if we've already attested to a higher slot.
561
+ if (!this.shouldAttestToSlot(proposalSlotNumber)) {
562
+ return undefined;
563
+ }
564
+
565
+ // Ignore proposals from ourselves (may happen in HA setups)
566
+ if (proposer && this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
567
+ this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
568
+ proposer: proposer.toString(),
569
+ proposalSlotNumber,
570
+ });
324
571
  return undefined;
325
572
  }
326
573
 
574
+ // Check that I have any address in the committee where this checkpoint will land before attesting
575
+ const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
576
+ const partOfCommittee = inCommittee.length > 0;
577
+
578
+ const proposalInfo = {
579
+ proposalSlotNumber,
580
+ archive: proposal.archive.toString(),
581
+ proposer: proposer?.toString(),
582
+ };
583
+ this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
584
+ ...proposalInfo,
585
+ fishermanMode: this.config.fishermanMode || false,
586
+ });
587
+
588
+ // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
589
+ // Uses the cached result from the all-nodes callback if available (avoids double validation).
590
+ let checkpointNumber: CheckpointNumber;
591
+ if (this.config.skipCheckpointProposalValidation) {
592
+ this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
593
+ checkpointNumber = CheckpointNumber(0);
594
+ } else {
595
+ const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
596
+ if (!validationResult.isValid) {
597
+ this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
598
+ return undefined;
599
+ }
600
+ checkpointNumber = validationResult.checkpointNumber;
601
+ }
602
+
327
603
  // Check that I have any address in current committee before attesting
328
- if (!partOfCommittee) {
604
+ // In fisherman mode, we still create attestations for validation even if not in committee
605
+ if (!partOfCommittee && !this.config.fishermanMode) {
329
606
  this.log.verbose(`No validator in the current committee, skipping attestation`, proposalInfo);
330
607
  return undefined;
331
608
  }
332
609
 
333
610
  // Provided all of the above checks pass, we can attest to the proposal
334
- this.log.info(`Attesting to proposal for slot ${slotNumber}`, proposalInfo);
611
+ this.log.info(
612
+ `${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`,
613
+ {
614
+ ...proposalInfo,
615
+ inCommittee: partOfCommittee,
616
+ fishermanMode: this.config.fishermanMode || false,
617
+ },
618
+ );
619
+
335
620
  this.metrics.incSuccessfulAttestations(inCommittee.length);
336
621
 
337
- // If the above function does not throw an error, then we can attest to the proposal
338
- return this.createBlockAttestationsFromProposal(proposal, inCommittee);
622
+ // Track epoch participation per attester: count each (attester, epoch) pair at most once
623
+ const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
624
+ for (const attester of inCommittee) {
625
+ const key = attester.toString();
626
+ const lastEpoch = this.lastAttestedEpochByAttester.get(key);
627
+ if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
628
+ this.lastAttestedEpochByAttester.set(key, proposalEpoch);
629
+ this.metrics.incAttestedEpochCount(attester);
630
+ }
631
+ }
632
+
633
+ // Determine which validators should attest
634
+ let attestors: EthAddress[];
635
+ if (partOfCommittee) {
636
+ attestors = inCommittee;
637
+ } else if (this.config.fishermanMode) {
638
+ // In fisherman mode, create attestations for validation purposes even if not in committee. These won't be broadcast.
639
+ attestors = this.getValidatorAddresses();
640
+ } else {
641
+ attestors = [];
642
+ }
643
+
644
+ // Only create attestations if we have attestors
645
+ if (attestors.length === 0) {
646
+ return undefined;
647
+ }
648
+
649
+ if (this.config.fishermanMode) {
650
+ // bail out early and don't save attestations to the pool in fisherman mode
651
+ this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
652
+ ...proposalInfo,
653
+ attestors: attestors.map(a => a.toString()),
654
+ });
655
+ return undefined;
656
+ }
657
+
658
+ return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
659
+ }
660
+
661
+ /**
662
+ * Checks if we should attest to a slot based on equivocation prevention rules.
663
+ * @returns true if we should attest, false if we should skip
664
+ */
665
+ private shouldAttestToSlot(slotNumber: SlotNumber): boolean {
666
+ // If attestToEquivocatedProposals is true, always allow
667
+ if (this.config.attestToEquivocatedProposals) {
668
+ return true;
669
+ }
670
+
671
+ // Check if incoming slot is strictly greater than last attested
672
+ if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
673
+ this.log.warn(
674
+ `Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`,
675
+ );
676
+ return false;
677
+ }
678
+
679
+ return true;
680
+ }
681
+
682
+ private async createCheckpointAttestationsFromProposal(
683
+ proposal: CheckpointProposalCore,
684
+ attestors: EthAddress[] = [],
685
+ checkpointNumber: CheckpointNumber,
686
+ ): Promise<CheckpointAttestation[] | undefined> {
687
+ // Equivocation check: must happen right before signing to minimize the race window
688
+ if (!this.shouldAttestToSlot(proposal.slotNumber)) {
689
+ return undefined;
690
+ }
691
+
692
+ const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
693
+
694
+ // Track the proposal we attested to (to prevent equivocation)
695
+ this.lastAttestedProposal = proposal;
696
+
697
+ await this.p2pClient.addOwnCheckpointAttestations(attestations);
698
+ return attestations;
699
+ }
700
+
701
+ /**
702
+ * Uploads blobs for a checkpoint to the filestore (fire and forget).
703
+ */
704
+ protected async uploadBlobsForCheckpoint(proposal: CheckpointProposalCore, proposalInfo: LogData): Promise<void> {
705
+ try {
706
+ const lastBlockHeader = (await this.blockSource.getBlockData({ archive: proposal.archive }))?.header;
707
+ if (!lastBlockHeader) {
708
+ this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
709
+ return;
710
+ }
711
+
712
+ const blocks = await this.blockSource.getBlocksForSlot(proposal.slotNumber);
713
+ if (blocks.length === 0) {
714
+ this.log.warn(`No blocks found for blob upload`, proposalInfo);
715
+ return;
716
+ }
717
+
718
+ const blobFields = blocks.flatMap(b => b.toBlobFields());
719
+ const blobs: Blob[] = await getBlobsPerL1Block(blobFields);
720
+ await this.blobClient.sendBlobsToFilestore(blobs);
721
+ this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
722
+ ...proposalInfo,
723
+ numBlobs: blobs.length,
724
+ });
725
+ } catch (err) {
726
+ this.log.warn(`Failed to upload blobs for checkpoint: ${err}`, proposalInfo);
727
+ }
339
728
  }
340
729
 
341
730
  private slashInvalidBlock(proposal: BlockProposal) {
@@ -347,12 +736,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
347
736
  return;
348
737
  }
349
738
 
350
- // Trim the set if it's too big.
351
- if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
352
- // remove oldest proposer. `values` is guaranteed to be in insertion order.
353
- this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value!);
354
- }
355
-
356
739
  this.proposersOfInvalidBlocks.add(proposer.toString());
357
740
 
358
741
  this.emit(WANT_TO_SLASH_EVENT, [
@@ -360,34 +743,246 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
360
743
  validator: proposer,
361
744
  amount: this.config.slashBroadcastedInvalidBlockPenalty,
362
745
  offenseType: OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL,
363
- epochOrSlot: proposal.slotNumber.toBigInt(),
746
+ epochOrSlot: BigInt(proposal.slotNumber),
747
+ },
748
+ ]);
749
+ }
750
+
751
+ private handleInvalidCheckpointProposal(
752
+ proposal: CheckpointProposalCore,
753
+ result: CheckpointProposalValidationFailureResult,
754
+ proposalInfo: LogData,
755
+ ): void {
756
+ if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
757
+ return;
758
+ }
759
+
760
+ this.markInvalidProposalSlot(proposal.slotNumber);
761
+
762
+ if (this.slashInvalidCheckpointProposal(proposal)) {
763
+ this.log.info(`Detected invalid checkpoint proposal offense`, {
764
+ ...proposalInfo,
765
+ reason: result.reason,
766
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
767
+ offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL),
768
+ });
769
+ }
770
+ }
771
+
772
+ private slashInvalidCheckpointProposal(proposal: CheckpointProposalCore): boolean {
773
+ const proposer = proposal.getSender();
774
+ if (!proposer) {
775
+ this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
776
+ slotNumber: proposal.slotNumber,
777
+ archive: proposal.archive.toString(),
778
+ });
779
+ return false;
780
+ }
781
+
782
+ const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
783
+ const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
784
+ if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
785
+ return false;
786
+ }
787
+
788
+ this.emit(WANT_TO_SLASH_EVENT, [
789
+ {
790
+ validator: proposer,
791
+ amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
792
+ offenseType,
793
+ epochOrSlot: BigInt(proposal.slotNumber),
794
+ },
795
+ ]);
796
+ return true;
797
+ }
798
+
799
+ private markInvalidProposalSlot(slotNumber: SlotNumber): void {
800
+ this.slotsWithInvalidProposals.add(slotNumber);
801
+ }
802
+
803
+ private handleCheckpointAttestation(attestation: CheckpointAttestation): void {
804
+ const slotNumber = attestation.slotNumber;
805
+ if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
806
+ return;
807
+ }
808
+
809
+ const attester = attestation.getSender();
810
+ if (!attester) {
811
+ this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
812
+ slotNumber,
813
+ archive: attestation.archive.toString(),
814
+ });
815
+ return;
816
+ }
817
+
818
+ this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
819
+ }
820
+
821
+ private slashAttestedToInvalidCheckpointProposal(slotNumber: SlotNumber, attester: EthAddress): void {
822
+ const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
823
+ if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
824
+ return;
825
+ }
826
+
827
+ this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
828
+ attester: attester.toString(),
829
+ slotNumber,
830
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
831
+ offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL),
832
+ });
833
+
834
+ this.emit(WANT_TO_SLASH_EVENT, [
835
+ {
836
+ validator: attester,
837
+ amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
838
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
839
+ epochOrSlot: BigInt(slotNumber),
840
+ },
841
+ ]);
842
+ }
843
+
844
+ /**
845
+ * Handle detection of a duplicate proposal (equivocation).
846
+ * Emits a slash event when a proposer sends multiple proposals for the same position.
847
+ */
848
+ private handleDuplicateProposal(info: DuplicateProposalInfo): void {
849
+ const { slot, proposer, type } = info;
850
+ this.slotsWithProposalEquivocation.add(slot);
851
+
852
+ this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
853
+ proposer: proposer.toString(),
854
+ slot,
855
+ type,
856
+ amount: this.config.slashDuplicateProposalPenalty,
857
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL),
858
+ });
859
+
860
+ this.emit(WANT_TO_SLASH_EVENT, [
861
+ {
862
+ validator: proposer,
863
+ amount: this.config.slashDuplicateProposalPenalty,
864
+ offenseType: OffenseType.DUPLICATE_PROPOSAL,
865
+ epochOrSlot: BigInt(slot),
866
+ },
867
+ ]);
868
+
869
+ this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
870
+ {
871
+ offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
872
+ epochOrSlot: BigInt(slot),
873
+ },
874
+ ]);
875
+ }
876
+
877
+ /**
878
+ * Handle detection of a duplicate attestation (equivocation).
879
+ * Emits a slash event when an attester signs attestations for different proposals at the same slot.
880
+ */
881
+ private handleDuplicateAttestation(info: DuplicateAttestationInfo): void {
882
+ const { slot, attester } = info;
883
+
884
+ this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
885
+ attester: attester.toString(),
886
+ slot,
887
+ amount: this.config.slashDuplicateAttestationPenalty,
888
+ offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION),
889
+ });
890
+
891
+ this.emit(WANT_TO_SLASH_EVENT, [
892
+ {
893
+ validator: attester,
894
+ amount: this.config.slashDuplicateAttestationPenalty,
895
+ offenseType: OffenseType.DUPLICATE_ATTESTATION,
896
+ epochOrSlot: BigInt(slot),
364
897
  },
365
898
  ]);
366
899
  }
367
900
 
368
901
  async createBlockProposal(
369
- blockNumber: number,
370
- header: CheckpointHeader,
902
+ blockHeader: BlockHeader,
903
+ checkpointNumber: CheckpointNumber,
904
+ indexWithinCheckpoint: IndexWithinCheckpoint,
905
+ inHash: Fr,
371
906
  archive: Fr,
372
- stateReference: StateReference,
373
907
  txs: Tx[],
374
908
  proposerAddress: EthAddress | undefined,
375
- options: BlockProposalOptions,
376
- ): Promise<BlockProposal | undefined> {
377
- if (this.previousProposal?.slotNumber.equals(header.slotNumber)) {
378
- this.log.verbose(`Already made a proposal for the same slot, skipping proposal`);
379
- return Promise.resolve(undefined);
909
+ options: BlockProposalOptions = {},
910
+ ): Promise<BlockProposal> {
911
+ // Validate that we're not creating a proposal for an older or equal position
912
+ if (this.lastProposedBlock) {
913
+ const lastSlot = this.lastProposedBlock.slotNumber;
914
+ const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
915
+ const newSlot = blockHeader.globalVariables.slotNumber;
916
+
917
+ if (newSlot < lastSlot || (newSlot === lastSlot && indexWithinCheckpoint <= lastIndex)) {
918
+ throw new Error(
919
+ `Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` +
920
+ `already proposed block for slot ${lastSlot} index ${lastIndex}`,
921
+ );
922
+ }
380
923
  }
381
924
 
925
+ this.log.info(
926
+ `Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`,
927
+ );
382
928
  const newProposal = await this.validationService.createBlockProposal(
383
- header,
929
+ blockHeader,
930
+ checkpointNumber,
931
+ indexWithinCheckpoint,
932
+ inHash,
384
933
  archive,
385
- stateReference,
386
934
  txs,
387
935
  proposerAddress,
388
- { ...options, broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal },
936
+ {
937
+ ...options,
938
+ broadcastInvalidBlockProposal:
939
+ options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal,
940
+ },
941
+ );
942
+ this.lastProposedBlock = newProposal;
943
+ return newProposal;
944
+ }
945
+
946
+ async createCheckpointProposal(
947
+ checkpointHeader: CheckpointHeader,
948
+ archive: Fr,
949
+ checkpointNumber: CheckpointNumber,
950
+ feeAssetPriceModifier: bigint,
951
+ lastBlockProposal: BlockProposal | undefined,
952
+ proposerAddress: EthAddress | undefined,
953
+ options: CheckpointProposalOptions = {},
954
+ ): Promise<CheckpointProposal> {
955
+ // Validate that we're not creating a proposal for an older or equal slot
956
+ if (this.lastProposedCheckpoint) {
957
+ const lastSlot = this.lastProposedCheckpoint.slotNumber;
958
+ const newSlot = checkpointHeader.slotNumber;
959
+
960
+ if (newSlot <= lastSlot) {
961
+ throw new Error(
962
+ `Cannot create checkpoint proposal for slot ${newSlot}: ` +
963
+ `already proposed checkpoint for slot ${lastSlot}`,
964
+ );
965
+ }
966
+ }
967
+
968
+ this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
969
+ const newProposal = await this.validationService.createCheckpointProposal(
970
+ checkpointHeader,
971
+ archive,
972
+ checkpointNumber,
973
+ feeAssetPriceModifier,
974
+ lastBlockProposal,
975
+ proposerAddress,
976
+ options,
389
977
  );
390
- this.previousProposal = newProposal;
978
+ this.lastProposedCheckpoint = newProposal;
979
+ // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
980
+ // own proposals through `handleCheckpointProposal`, so without this call the proposer's
981
+ // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
982
+ // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
983
+ // be intentionally corrupted under test-only flags); from the proposer's local-view
984
+ // perspective the work it just completed is valid by definition.
985
+ this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
391
986
  return newProposal;
392
987
  }
393
988
 
@@ -398,20 +993,47 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
398
993
  async signAttestationsAndSigners(
399
994
  attestationsAndSigners: CommitteeAttestationsAndSigners,
400
995
  proposer: EthAddress,
996
+ slot: SlotNumber,
997
+ checkpointNumber: CheckpointNumber,
401
998
  ): Promise<Signature> {
402
- return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer);
999
+ return await this.validationService.signAttestationsAndSigners(
1000
+ attestationsAndSigners,
1001
+ proposer,
1002
+ slot,
1003
+ checkpointNumber,
1004
+ );
403
1005
  }
404
1006
 
405
- async collectOwnAttestations(proposal: BlockProposal): Promise<BlockAttestation[]> {
406
- const slot = proposal.payload.header.slotNumber.toBigInt();
1007
+ async collectOwnAttestations(
1008
+ proposal: CheckpointProposal,
1009
+ checkpointNumber: CheckpointNumber,
1010
+ ): Promise<CheckpointAttestation[]> {
1011
+ const slot = proposal.slotNumber;
407
1012
  const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
408
1013
  this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, { inCommittee });
409
- return this.createBlockAttestationsFromProposal(proposal, inCommittee);
1014
+ const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
1015
+
1016
+ if (!attestations) {
1017
+ return [];
1018
+ }
1019
+
1020
+ // We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
1021
+ // other nodes can see that our validators did attest to this block proposal, and do not slash us
1022
+ // due to inactivity for missed attestations.
1023
+ void this.p2pClient.broadcastCheckpointAttestations(attestations).catch(err => {
1024
+ this.log.error(`Failed to broadcast self-attestations for slot ${slot}`, err);
1025
+ });
1026
+ return attestations;
410
1027
  }
411
1028
 
412
- async collectAttestations(proposal: BlockProposal, required: number, deadline: Date): Promise<BlockAttestation[]> {
413
- // Wait and poll the p2pClient's attestation pool for this block until we have enough attestations
414
- const slot = proposal.payload.header.slotNumber.toBigInt();
1029
+ async collectAttestations(
1030
+ proposal: CheckpointProposal,
1031
+ required: number,
1032
+ deadline: Date,
1033
+ checkpointNumber: CheckpointNumber,
1034
+ ): Promise<CheckpointAttestation[]> {
1035
+ // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
1036
+ const slot = proposal.slotNumber;
415
1037
  this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
416
1038
 
417
1039
  if (+deadline < this.dateProvider.now()) {
@@ -421,33 +1043,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
421
1043
  throw new AttestationTimeoutError(0, required, slot);
422
1044
  }
423
1045
 
424
- await this.collectOwnAttestations(proposal);
1046
+ await this.collectOwnAttestations(proposal, checkpointNumber);
425
1047
 
426
- const proposalId = proposal.archive.toString();
1048
+ const proposalPayloadHash = proposal.getPayloadHash();
427
1049
  const myAddresses = this.getValidatorAddresses();
428
1050
 
429
- let attestations: BlockAttestation[] = [];
1051
+ let attestations: CheckpointAttestation[] = [];
430
1052
  while (true) {
431
- // Filter out attestations with a mismatching payload. This should NOT happen since we have verified
432
- // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
433
- const collectedAttestations = (await this.p2pClient.getAttestationsForSlot(slot, proposalId)).filter(
434
- attestation => {
435
- if (!attestation.payload.equals(proposal.payload)) {
436
- this.log.warn(
437
- `Received attestation for slot ${slot} with mismatched payload from ${attestation.getSender()?.toString()}`,
438
- { attestationPayload: attestation.payload, proposalPayload: proposal.payload },
439
- );
440
- return false;
441
- }
442
- return true;
443
- },
444
- );
1053
+ // The pool already filters by proposal payload hash; if any attestation slips through with a
1054
+ // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
1055
+ // events from libp2p_service.
1056
+ const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
445
1057
 
446
1058
  // Log new attestations we collected
447
1059
  const oldSenders = attestations.map(attestation => attestation.getSender());
448
1060
  for (const collected of collectedAttestations) {
449
1061
  const collectedSender = collected.getSender();
450
- // Skip attestations with invalid signatures
1062
+ // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
451
1063
  if (!collectedSender) {
452
1064
  this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
453
1065
  continue;
@@ -476,15 +1088,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
476
1088
  }
477
1089
  }
478
1090
 
479
- private async createBlockAttestationsFromProposal(
480
- proposal: BlockProposal,
481
- attestors: EthAddress[] = [],
482
- ): Promise<BlockAttestation[]> {
483
- const attestations = await this.validationService.attestToProposal(proposal, attestors);
484
- await this.p2pClient.addAttestations(attestations);
485
- return attestations;
486
- }
487
-
488
1091
  private async handleAuthRequest(peer: PeerId, msg: Buffer): Promise<Buffer> {
489
1092
  const authRequest = AuthRequest.fromBuffer(msg);
490
1093
  const statusMessage = await this.p2pClient.handleAuthRequestFromPeer(authRequest, peer).catch(_ => undefined);
@@ -503,7 +1106,9 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
503
1106
  }
504
1107
 
505
1108
  const payloadToSign = authRequest.getPayloadToSign();
506
- const signature = await this.keyStore.signMessageWithAddress(addressToUse, payloadToSign);
1109
+ // AUTH_REQUEST doesn't require HA protection - multiple signatures are safe
1110
+ const context: SigningContext = { dutyType: DutyType.AUTH_REQUEST };
1111
+ const signature = await this.keyStore.signMessageWithAddress(addressToUse, payloadToSign, context);
507
1112
  const authResponse = new AuthResponse(statusMessage, signature);
508
1113
  return authResponse.toBuffer();
509
1114
  }