@aztec/validator-client 0.0.1-commit.4d3c002 → 0.0.1-commit.4d9804df

package/dest/validator.js

@@ -1,29 +1,30 @@
 import { getBlobsPerL1Block } from '@aztec/blob-lib';
+import { CheckpointNumber } from '@aztec/foundation/branded-types';
+import { FifoSet } from '@aztec/foundation/fifo-set';
 import { createLogger } from '@aztec/foundation/log';
 import { RunningPromise } from '@aztec/foundation/running-promise';
 import { sleep } from '@aztec/foundation/sleep';
 import { DateProvider } from '@aztec/foundation/timer';
 import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
-import { OffenseType, WANT_TO_SLASH_EVENT } from '@aztec/slasher';
+import { OffenseType, WANT_TO_CLEAR_SLASH_EVENT, WANT_TO_SLASH_EVENT, getOffenseTypeName } from '@aztec/slasher';
 import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
+import { ConsensusTimetable } from '@aztec/stdlib/timetable';
 import { AttestationTimeoutError } from '@aztec/stdlib/validators';
 import { getTelemetryClient } from '@aztec/telemetry-client';
 import { createHASigner, createLocalSignerWithProtection, createSignerFromSharedDb } from '@aztec/validator-ha-signer/factory';
 import { DutyType } from '@aztec/validator-ha-signer/types';
 import { EventEmitter } from 'events';
+import { DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS } from './config.js';
 import { ValidationService } from './duties/validation_service.js';
 import { HAKeyStore } from './key_store/ha_key_store.js';
 import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
 import { ValidatorMetrics } from './metrics.js';
-import { ProposalHandler } from './proposal_handler.js';
+import { ProposalHandler, SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT, SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT } from './proposal_handler.js';
 // We maintain a set of proposers who have proposed invalid blocks.
 // Just cap the set to avoid unbounded growth.
 const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
-// What errors from the block proposal handler result in slashing
-const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
-    'state_mismatch',
-    'failed_txs'
-];
+const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
+const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
 /**
  * Validator Client
  */ export class ValidatorClient extends EventEmitter {
@@ -51,14 +52,18 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
     epochCacheUpdateLoop;
     /** Tracks the last epoch in which each attester successfully submitted at least one attestation. */ lastAttestedEpochByAttester;
     proposersOfInvalidBlocks;
+    invalidCheckpointProposalOffenseKeys;
+    oversizedProposalOffenseKeys;
+    badAttestationOffenseKeys;
     /** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */ lastAttestedProposal;
     constructor(keyStore, epochCache, p2pClient, proposalHandler, blockSource, checkpointsBuilder, worldState, l1ToL2MessageSource, config, blobClient, slashingProtectionSigner, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), log = createLogger('validator')){
-        super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = new Set();
+        super(), this.keyStore = keyStore, this.epochCache = epochCache, this.p2pClient = p2pClient, this.proposalHandler = proposalHandler, this.blockSource = blockSource, this.checkpointsBuilder = checkpointsBuilder, this.worldState = worldState, this.l1ToL2MessageSource = l1ToL2MessageSource, this.config = config, this.blobClient = blobClient, this.slashingProtectionSigner = slashingProtectionSigner, this.dateProvider = dateProvider, this.hasRegisteredHandlers = false, this.lastAttestedEpochByAttester = new Map(), this.proposersOfInvalidBlocks = FifoSet.withLimit(MAX_PROPOSERS_OF_INVALID_BLOCKS), this.invalidCheckpointProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.oversizedProposalOffenseKeys = FifoSet.withLimit(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS), this.badAttestationOffenseKeys = FifoSet.withLimit(MAX_TRACKED_BAD_ATTESTATIONS);
         // Create child logger with fisherman prefix if in fisherman mode
         this.log = config.fishermanMode ? log.createChild('[FISHERMAN]') : log;
         this.tracer = telemetry.getTracer('Validator');
         this.metrics = new ValidatorMetrics(telemetry);
-        this.validationService = new ValidationService(keyStore, this.log.createChild('validation-service'));
+        this.validationService = new ValidationService(keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
+        this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo)=>this.handleInvalidCheckpointProposal(proposal, result, proposalInfo));
         // Refresh epoch cache every second to trigger alert if participation in committee changes
         this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
         const myAddresses = this.getValidatorAddresses();
@@ -108,13 +113,24 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.error(`Error updating epoch committee`, err);
         }
     }
-    static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
+    static async new(config, checkpointsBuilder, worldState, epochCache, p2pClient, blockSource, l1ToL2MessageSource, txProvider, keyStoreManager, blobClient, reexecutionTracker, dateProvider = new DateProvider(), telemetry = getTelemetryClient(), slashingProtectionDb) {
         const metrics = new ValidatorMetrics(telemetry);
-        const blockProposalValidator = new BlockProposalValidator(epochCache, {
+        const consensusTimetable = new ConsensusTimetable({
+            l1Constants: epochCache.getL1Constants(),
+            blockDuration: config.blockDurationMs / 1000
+        });
+        const blockProposalValidator = new BlockProposalValidator(epochCache, consensusTimetable, {
             txsPermitted: !config.disableTransactions,
-            maxTxsPerBlock: config.validateMaxTxsPerBlock
+            maxTxsPerBlock: config.validateMaxTxsPerBlock,
+            maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
+            skipSlotValidation: config.skipProposalSlotValidation,
+            signatureContext: {
+                chainId: config.l1ChainId,
+                rollupAddress: config.rollupAddress
+            },
+            clockDisparityMs: config.maxGossipClockDisparityMs ?? DEFAULT_MAX_GOSSIP_CLOCK_DISPARITY_MS
         });
-        const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, config, blobClient, metrics, dateProvider, telemetry);
+        const proposalHandler = new ProposalHandler(checkpointsBuilder, worldState, blockSource, l1ToL2MessageSource, txProvider, blockProposalValidator, epochCache, consensusTimetable, config, blobClient, reexecutionTracker, metrics, dateProvider, telemetry, undefined);
         const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
         let slashingProtectionSigner;
         if (slashingProtectionDb) {
@@ -155,6 +171,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
     signWithAddress(addr, msg, context) {
         return this.keyStore.signTypedDataWithAddress(addr, msg, context);
     }
+    getSignatureContext() {
+        return {
+            chainId: this.config.l1ChainId,
+            rollupAddress: this.config.rollupAddress
+        };
+    }
     getCoinbaseForAttestor(attestor) {
         return this.keyStore.getCoinbaseAddress(attestor);
     }
@@ -164,16 +186,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
     getConfig() {
         return this.config;
     }
+    hasProposalEquivocation(slotNumber) {
+        return this.proposalHandler.hasProposalEquivocation(slotNumber);
+    }
+    hasInvalidProposals(slotNumber) {
+        return this.proposalHandler.hasInvalidProposals(slotNumber);
+    }
     updateConfig(config) {
         this.config = {
             ...this.config,
             ...config
         };
+        this.proposalHandler.updateConfig(config);
     }
     reloadKeystore(newManager) {
         const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
         this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
-        this.validationService = new ValidationService(this.keyStore, this.log.createChild('validation-service'));
+        this.validationService = new ValidationService(this.keyStore, this.getSignatureContext(), this.log.createChild('validation-service'));
     }
     async start() {
         if (this.epochCacheUpdateLoop.isRunning()) {
@@ -211,10 +240,17 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.p2pClient.registerDuplicateProposalCallback((info)=>{
                 this.handleDuplicateProposal(info);
             });
+            // Oversized proposal handler - triggers slashing for proposals beyond the per-checkpoint block limit
+            this.p2pClient.registerOversizedProposalCallback((info)=>{
+                this.handleOversizedProposal(info);
+            });
             // Duplicate attestation handler - triggers slashing for attestation equivocation
             this.p2pClient.registerDuplicateAttestationCallback((info)=>{
                 this.handleDuplicateAttestation(info);
             });
+            this.p2pClient.registerCheckpointAttestationCallback((attestation)=>{
+                this.handleCheckpointAttestation(attestation);
+            });
             const myAddresses = this.getValidatorAddresses();
             this.p2pClient.registerThisValidatorAddresses(myAddresses);
             await this.p2pClient.addReqRespSubProtocol(ReqRespSubProtocol.AUTH, this.handleAuthRequest.bind(this));
@@ -254,11 +290,8 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             txHashes: proposal.txHashes.map((t)=>t.toString()),
             fishermanMode: this.config.fishermanMode || false
         });
-        // Reexecute txs if we are part of the committee, or if slashing is enabled, or if we are configured to always reexecute.
-        // In fisherman mode, we always reexecute to validate proposals.
-        const { slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } = this.config;
-        const shouldReexecute = fishermanMode || slashBroadcastedInvalidBlockPenalty > 0n || partOfCommittee || alwaysReexecuteBlockProposals || this.blobClient.canUpload();
-        const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !!shouldReexecute && !escapeHatchOpen);
+        // Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
+        const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
         if (!validationResult.isValid) {
             const reason = validationResult.reason || 'unknown';
             this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
@@ -276,10 +309,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
                 // Node issues so we can't validate
                 this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
             }
-            // Slash invalid block proposals (can happen even when not in committee)
-            if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason) && slashBroadcastedInvalidBlockPenalty > 0n) {
-                this.log.warn(`Slashing proposer for invalid block proposal`, proposalInfo);
+            if (!escapeHatchOpen && validationResult.reason && SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)) {
+                this.log.info(`Detected invalid block proposal offense`, {
+                    ...proposalInfo,
+                    amount: this.config.slashBroadcastedInvalidBlockPenalty,
+                    offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL)
+                });
                 this.slashInvalidBlock(proposal);
+                this.markInvalidProposalSlot(proposal.slotNumber);
             }
             return false;
         }
@@ -308,9 +345,13 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
             return undefined;
         }
+        // Early-out for equivocation: refuses if we've already attested to a higher slot.
+        if (!this.shouldAttestToSlot(proposalSlotNumber)) {
+            return undefined;
+        }
         // Ignore proposals from ourselves (may happen in HA setups)
         if (proposer && this.getValidatorAddresses().some((addr)=>addr.equals(proposer))) {
-            this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
+            this.log.debug(`Not attesting to block proposal from self for slot ${proposalSlotNumber}`, {
                 proposer: proposer.toString(),
                 proposalSlotNumber
             });
@@ -330,14 +371,17 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         });
         // Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
         // Uses the cached result from the all-nodes callback if available (avoids double validation).
+        let checkpointNumber;
         if (this.config.skipCheckpointProposalValidation) {
             this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
+            checkpointNumber = CheckpointNumber(0);
         } else {
             const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
             if (!validationResult.isValid) {
                 this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
                 return undefined;
             }
+            checkpointNumber = validationResult.checkpointNumber;
         }
         // Check that I have any address in current committee before attesting
         // In fisherman mode, we still create attestations for validation even if not in committee
@@ -384,7 +428,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             });
             return undefined;
         }
-        return await this.createCheckpointAttestationsFromProposal(proposal, attestors);
+        return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
     }
     /**
    * Checks if we should attest to a slot based on equivocation prevention rules.
@@ -401,12 +445,12 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         }
         return true;
     }
-    async createCheckpointAttestationsFromProposal(proposal, attestors = []) {
+    async createCheckpointAttestationsFromProposal(proposal, attestors = [], checkpointNumber) {
         // Equivocation check: must happen right before signing to minimize the race window
         if (!this.shouldAttestToSlot(proposal.slotNumber)) {
             return undefined;
         }
-        const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors);
+        const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
         // Track the proposal we attested to (to prevent equivocation)
         this.lastAttestedProposal = proposal;
         await this.p2pClient.addOwnCheckpointAttestations(attestations);
@@ -416,7 +460,9 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
    * Uploads blobs for a checkpoint to the filestore (fire and forget).
    */ async uploadBlobsForCheckpoint(proposal, proposalInfo) {
         try {
-            const lastBlockHeader = await this.blockSource.getBlockHeaderByArchive(proposal.archive);
+            const lastBlockHeader = (await this.blockSource.getBlockData({
+                archive: proposal.archive
+            }))?.header;
             if (!lastBlockHeader) {
                 this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
                 return;
@@ -444,11 +490,6 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.warn(`Cannot slash proposal with invalid signature`);
             return;
         }
-        // Trim the set if it's too big.
-        if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
-            // remove oldest proposer. `values` is guaranteed to be in insertion order.
-            this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value);
-        }
         this.proposersOfInvalidBlocks.add(proposer.toString());
         this.emit(WANT_TO_SLASH_EVENT, [
             {
@@ -459,17 +500,122 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         ]);
     }
+    handleInvalidCheckpointProposal(proposal, result, proposalInfo) {
+        if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
+            return;
+        }
+        // The slot is already marked invalid by the all-nodes checkpoint handler that invokes this callback,
+        // so we only emit the proposer slash event here.
+        if (this.slashInvalidCheckpointProposal(proposal)) {
+            this.log.info(`Detected invalid checkpoint proposal offense`, {
+                ...proposalInfo,
+                reason: result.reason,
+                amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
+                offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL)
+            });
+        }
+    }
+    slashInvalidCheckpointProposal(proposal) {
+        const proposer = proposal.getSender();
+        if (!proposer) {
+            this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
+                slotNumber: proposal.slotNumber,
+                archive: proposal.archive.toString()
+            });
+            return false;
+        }
+        const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
+        const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
+        if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
+            return false;
+        }
+        this.emit(WANT_TO_SLASH_EVENT, [
+            {
+                validator: proposer,
+                amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
+                offenseType,
+                epochOrSlot: BigInt(proposal.slotNumber)
+            }
+        ]);
+        return true;
+    }
+    markInvalidProposalSlot(slotNumber) {
+        this.proposalHandler.markInvalidProposalSlot(slotNumber);
+    }
+    handleCheckpointAttestation(attestation) {
+        const slotNumber = attestation.slotNumber;
+        if (!this.proposalHandler.hasInvalidProposals(slotNumber) || this.proposalHandler.hasProposalEquivocation(slotNumber)) {
+            return;
+        }
+        const attester = attestation.getSender();
+        if (!attester) {
+            this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
+                slotNumber,
+                archive: attestation.archive.toString()
+            });
+            return;
+        }
+        this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
+    }
+    slashAttestedToInvalidCheckpointProposal(slotNumber, attester) {
+        const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
+        if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
+            return;
+        }
+        this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
+            attester: attester.toString(),
+            slotNumber,
+            amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
+            offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL)
+        });
+        this.emit(WANT_TO_SLASH_EVENT, [
+            {
+                validator: attester,
+                amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
+                offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
+                epochOrSlot: BigInt(slotNumber)
+            }
+        ]);
+    }
+    /**
+   * Handle detection of an oversized block proposal: one whose index within its checkpoint lands at or
+   * beyond the consensus per-checkpoint block limit. A single signed proposal at an illegal index is
+   * self-contained evidence, so emit an invalid-block-proposal slash event for the proposer, deduped per
+   * (proposer, slot) since the p2p layer reports every oversized proposal it stores.
+   */ handleOversizedProposal(info) {
+        const { slot, proposer } = info;
+        const offenseType = OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL;
+        if (!this.oversizedProposalOffenseKeys.addIfAbsent(`${proposer.toString()}:${offenseType}:${slot}`)) {
+            return;
+        }
+        this.log.info(`Detected oversized block proposal offense from ${proposer.toString()} at slot ${slot}`, {
+            proposer: proposer.toString(),
+            slot,
+            amount: this.config.slashBroadcastedInvalidBlockPenalty,
+            offenseType: getOffenseTypeName(offenseType)
+        });
+        this.emit(WANT_TO_SLASH_EVENT, [
+            {
+                validator: proposer,
+                amount: this.config.slashBroadcastedInvalidBlockPenalty,
+                offenseType,
+                epochOrSlot: BigInt(slot)
+            }
+        ]);
+    }
     /**
    * Handle detection of a duplicate proposal (equivocation).
    * Emits a slash event when a proposer sends multiple proposals for the same position.
    */ handleDuplicateProposal(info) {
         const { slot, proposer, type } = info;
-        this.log.warn(`Triggering slash event for duplicate ${type} proposal from ${proposer.toString()} at slot ${slot}`, {
+        this.proposalHandler.markProposalEquivocation(slot);
+        this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
             proposer: proposer.toString(),
             slot,
-            type
+            type,
+            amount: this.config.slashDuplicateProposalPenalty,
+            offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL)
         });
-        // Emit slash event
         this.emit(WANT_TO_SLASH_EVENT, [
             {
                 validator: proposer,
@@ -478,15 +624,23 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
                 epochOrSlot: BigInt(slot)
             }
         ]);
+        this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
+            {
+                offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
+                epochOrSlot: BigInt(slot)
+            }
+        ]);
     }
     /**
    * Handle detection of a duplicate attestation (equivocation).
    * Emits a slash event when an attester signs attestations for different proposals at the same slot.
    */ handleDuplicateAttestation(info) {
         const { slot, attester } = info;
-        this.log.warn(`Triggering slash event for duplicate attestation from ${attester.toString()} at slot ${slot}`, {
+        this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
             attester: attester.toString(),
-            slot
+            slot,
+            amount: this.config.slashDuplicateAttestationPenalty,
+            offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION)
         });
         this.emit(WANT_TO_SLASH_EVENT, [
             {
@@ -497,7 +651,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         ]);
     }
-    async createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
+    async createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, options = {}) {
         // Validate that we're not creating a proposal for an older or equal position
         if (this.lastProposedBlock) {
             const lastSlot = this.lastProposedBlock.slotNumber;
@@ -508,14 +662,14 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         }
         this.log.info(`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`);
-        const newProposal = await this.validationService.createBlockProposal(blockHeader, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
+        const newProposal = await this.validationService.createBlockProposal(blockHeader, checkpointNumber, indexWithinCheckpoint, inHash, archive, txs, proposerAddress, {
             ...options,
-            broadcastInvalidBlockProposal: this.config.broadcastInvalidBlockProposal
+            broadcastInvalidBlockProposal: options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal
         });
         this.lastProposedBlock = newProposal;
         return newProposal;
     }
-    async createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options = {}) {
+    async createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options = {}) {
         // Validate that we're not creating a proposal for an older or equal slot
         if (this.lastProposedCheckpoint) {
             const lastSlot = this.lastProposedCheckpoint.slotNumber;
@@ -525,23 +679,30 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             }
         }
         this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
-        const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, feeAssetPriceModifier, lastBlockInfo, proposerAddress, options);
+        const newProposal = await this.validationService.createCheckpointProposal(checkpointHeader, archive, checkpointNumber, feeAssetPriceModifier, lastBlockProposal, proposerAddress, options);
         this.lastProposedCheckpoint = newProposal;
+        // Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
+        // own proposals through `handleCheckpointProposal`, so without this call the proposer's
+        // sentinel would see no outcome for slots it proposed and would mis-attribute itself as
+        // inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
+        // be intentionally corrupted under test-only flags); from the proposer's local-view
+        // perspective the work it just completed is valid by definition.
+        this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
         return newProposal;
     }
     async broadcastBlockProposal(proposal) {
         await this.p2pClient.broadcastProposal(proposal);
     }
-    async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber) {
-        return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, blockNumber);
+    async signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber) {
+        return await this.validationService.signAttestationsAndSigners(attestationsAndSigners, proposer, slot, checkpointNumber);
     }
-    async collectOwnAttestations(proposal) {
+    async collectOwnAttestations(proposal, checkpointNumber) {
         const slot = proposal.slotNumber;
         const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
         this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, {
             inCommittee
         });
-        const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee);
+        const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
         if (!attestations) {
             return [];
         }
@@ -553,7 +714,7 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
         });
         return attestations;
     }
-    async collectAttestations(proposal, required, deadline) {
+    async collectAttestations(proposal, required, deadline, checkpointNumber) {
         // Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
         const slot = proposal.slotNumber;
         this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
@@ -561,28 +722,20 @@ const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT = [
             this.log.error(`Deadline ${deadline.toISOString()} for collecting ${required} attestations for slot ${slot} is in the past`);
             throw new AttestationTimeoutError(0, required, slot);
         }
-        await this.collectOwnAttestations(proposal);
-        const proposalId = proposal.archive.toString();
+        await this.collectOwnAttestations(proposal, checkpointNumber);
+        const proposalPayloadHash = proposal.getPayloadHash();
         const myAddresses = this.getValidatorAddresses();
         let attestations = [];
         while(true){
-            // Filter out attestations with a mismatching archive. This should NOT happen since we have verified
-            // the proposer signature (ie our own) before accepting the attestation into the pool via the p2p client.
-            const collectedAttestations = (await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalId)).filter((attestation)=>{
-                if (!attestation.archive.equals(proposal.archive)) {
-                    this.log.warn(`Received attestation for slot ${slot} with mismatched archive from ${attestation.getSender()?.toString()}`, {
-                        attestationArchive: attestation.archive.toString(),
-                        proposalArchive: proposal.archive.toString()
-                    });
-                    return false;
-                }
-                return true;
-            });
+            // The pool already filters by proposal payload hash; if any attestation slips through with a
+            // mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
+            // events from libp2p_service.
+            const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
             // Log new attestations we collected
             const oldSenders = attestations.map((attestation)=>attestation.getSender());
             for (const collected of collectedAttestations){
                 const collectedSender = collected.getSender();
-                // Skip attestations with invalid signatures
+                // Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
                 if (!collectedSender) {
                     this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
                     continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aztec/validator-client",
-  "version": "0.0.1-commit.4d3c002",
+  "version": "0.0.1-commit.4d9804df",
   "main": "dest/index.js",
   "type": "module",
   "exports": {
@@ -64,30 +64,30 @@
     ]
   },
   "dependencies": {
-    "@aztec/blob-client": "0.0.1-commit.4d3c002",
-    "@aztec/blob-lib": "0.0.1-commit.4d3c002",
-    "@aztec/constants": "0.0.1-commit.4d3c002",
-    "@aztec/epoch-cache": "0.0.1-commit.4d3c002",
-    "@aztec/ethereum": "0.0.1-commit.4d3c002",
-    "@aztec/foundation": "0.0.1-commit.4d3c002",
-    "@aztec/node-keystore": "0.0.1-commit.4d3c002",
-    "@aztec/noir-protocol-circuits-types": "0.0.1-commit.4d3c002",
-    "@aztec/p2p": "0.0.1-commit.4d3c002",
-    "@aztec/protocol-contracts": "0.0.1-commit.4d3c002",
-    "@aztec/prover-client": "0.0.1-commit.4d3c002",
-    "@aztec/simulator": "0.0.1-commit.4d3c002",
-    "@aztec/slasher": "0.0.1-commit.4d3c002",
-    "@aztec/stdlib": "0.0.1-commit.4d3c002",
-    "@aztec/telemetry-client": "0.0.1-commit.4d3c002",
-    "@aztec/validator-ha-signer": "0.0.1-commit.4d3c002",
+    "@aztec/blob-client": "0.0.1-commit.4d9804df",
+    "@aztec/blob-lib": "0.0.1-commit.4d9804df",
+    "@aztec/constants": "0.0.1-commit.4d9804df",
+    "@aztec/epoch-cache": "0.0.1-commit.4d9804df",
+    "@aztec/ethereum": "0.0.1-commit.4d9804df",
+    "@aztec/foundation": "0.0.1-commit.4d9804df",
+    "@aztec/node-keystore": "0.0.1-commit.4d9804df",
+    "@aztec/noir-protocol-circuits-types": "0.0.1-commit.4d9804df",
+    "@aztec/p2p": "0.0.1-commit.4d9804df",
+    "@aztec/protocol-contracts": "0.0.1-commit.4d9804df",
+    "@aztec/prover-client": "0.0.1-commit.4d9804df",
+    "@aztec/simulator": "0.0.1-commit.4d9804df",
+    "@aztec/slasher": "0.0.1-commit.4d9804df",
+    "@aztec/stdlib": "0.0.1-commit.4d9804df",
+    "@aztec/telemetry-client": "0.0.1-commit.4d9804df",
+    "@aztec/validator-ha-signer": "0.0.1-commit.4d9804df",
     "koa": "^2.16.1",
     "koa-router": "^13.1.1",
     "tslib": "^2.4.0",
     "viem": "npm:@aztec/viem@2.38.2"
   },
   "devDependencies": {
-    "@aztec/archiver": "0.0.1-commit.4d3c002",
-    "@aztec/world-state": "0.0.1-commit.4d3c002",
+    "@aztec/archiver": "0.0.1-commit.4d9804df",
+    "@aztec/world-state": "0.0.1-commit.4d9804df",
     "@electric-sql/pglite": "^0.3.14",
     "@jest/globals": "^30.0.0",
     "@types/jest": "^30.0.0",

package/src/checkpoint_builder.ts

@@ -9,6 +9,7 @@ import { DateProvider, elapsed } from '@aztec/foundation/timer';
 import { createTxValidatorForBlockBuilding, getDefaultAllowedSetupFunctions } from '@aztec/p2p/msg_validators';
 import { LightweightCheckpointBuilder } from '@aztec/prover-client/light';
 import {
+  type AvmSimulator,
   GuardedMerkleTreeOperations,
   PublicContractsDB,
   PublicProcessor,
@@ -57,6 +58,7 @@ export class CheckpointBuilder implements ICheckpointBlockBuilder {
     private contractDataSource: ContractDataSource,
     private dateProvider: DateProvider,
     private telemetryClient: TelemetryClient,
+    private avmSimulator: AvmSimulator,
     bindings?: LoggerBindings,
     private debugLogStore: DebugLogStore = new NullDebugLogStore(),
   ) {
@@ -219,10 +221,12 @@ export class CheckpointBuilder implements ICheckpointBlockBuilder {
     if (opts.isBuildingProposal) {
       const remainingBlocks = Math.max(1, opts.maxBlocksPerCheckpoint - existingBlocks.length);
       const multiplier = opts.perBlockAllocationMultiplier;
+      // DA gas and blob fields use a higher multiplier so the largest contract class deploy fits a block.
+      const daMultiplier = opts.perBlockDAAllocationMultiplier ?? multiplier;
 
       cappedL2Gas = Math.min(cappedL2Gas, Math.ceil((remainingMana / remainingBlocks) * multiplier));
-      cappedDAGas = Math.min(cappedDAGas, Math.ceil((remainingDAGas / remainingBlocks) * multiplier));
-      cappedBlobFields = Math.min(cappedBlobFields, Math.ceil((maxBlobFieldsForTxs / remainingBlocks) * multiplier));
+      cappedDAGas = Math.min(cappedDAGas, Math.ceil((remainingDAGas / remainingBlocks) * daMultiplier));
+      cappedBlobFields = Math.min(cappedBlobFields, Math.ceil((maxBlobFieldsForTxs / remainingBlocks) * daMultiplier));
       cappedMaxTransactions = Math.min(cappedMaxTransactions, Math.ceil((remainingTxs / remainingBlocks) * multiplier));
     }
 
@@ -241,16 +245,18 @@ export class CheckpointBuilder implements ICheckpointBlockBuilder {
     const contractsDB = this.contractsDB;
     const guardedFork = new GuardedMerkleTreeOperations(fork);
 
-    const collectDebugLogs = this.debugLogStore.isEnabled;
-
     const bindings = this.log.getBindings();
+    // Extract the WSDB fork ID so the C++ AVM can modify the same fork in-place; the simulator reads
+    // contract data from `contractsDB`, scoped to this fork for the duration of each simulation.
+    const wsdbForkId = fork.getRevision().forkId;
     const publicTxSimulator = createPublicTxSimulatorForBlockBuilding(
-      guardedFork,
-      contractsDB,
+      this.avmSimulator,
       globalVariables,
+      contractsDB,
+      wsdbForkId,
       this.telemetryClient,
       bindings,
-      collectDebugLogs,
+      this.debugLogStore?.isEnabled ?? false,
     );
 
     const processor = new PublicProcessor(
@@ -289,6 +295,7 @@ export class FullNodeCheckpointsBuilder implements ICheckpointsBuilder {
     private worldState: WorldStateSynchronizer,
     private contractDataSource: ContractDataSource,
     private dateProvider: DateProvider,
+    private avmSimulator: AvmSimulator,
     private telemetryClient: TelemetryClient = getTelemetryClient(),
     private debugLogStore: DebugLogStore = new NullDebugLogStore(),
   ) {
@@ -344,6 +351,7 @@ export class FullNodeCheckpointsBuilder implements ICheckpointsBuilder {
       this.contractDataSource,
       this.dateProvider,
       this.telemetryClient,
+      this.avmSimulator,
       bindings,
       this.debugLogStore,
     );
@@ -405,6 +413,7 @@ export class FullNodeCheckpointsBuilder implements ICheckpointsBuilder {
       this.contractDataSource,
       this.dateProvider,
       this.telemetryClient,
+      this.avmSimulator,
       bindings,
       this.debugLogStore,
     );