@aztec/validator-client 0.0.1-commit.03f7ef2 → 0.0.1-commit.04d373f
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +325 -0
- package/dest/checkpoint_builder.d.ts +79 -0
- package/dest/checkpoint_builder.d.ts.map +1 -0
- package/dest/checkpoint_builder.js +251 -0
- package/dest/config.d.ts +1 -1
- package/dest/config.d.ts.map +1 -1
- package/dest/config.js +48 -14
- package/dest/duties/validation_service.d.ts +43 -15
- package/dest/duties/validation_service.d.ts.map +1 -1
- package/dest/duties/validation_service.js +101 -30
- package/dest/factory.d.ts +22 -13
- package/dest/factory.d.ts.map +1 -1
- package/dest/factory.js +11 -5
- package/dest/index.d.ts +3 -2
- package/dest/index.d.ts.map +1 -1
- package/dest/index.js +2 -1
- package/dest/key_store/ha_key_store.d.ts +99 -0
- package/dest/key_store/ha_key_store.d.ts.map +1 -0
- package/dest/key_store/ha_key_store.js +208 -0
- package/dest/key_store/index.d.ts +2 -1
- package/dest/key_store/index.d.ts.map +1 -1
- package/dest/key_store/index.js +1 -0
- package/dest/key_store/interface.d.ts +36 -6
- package/dest/key_store/interface.d.ts.map +1 -1
- package/dest/key_store/local_key_store.d.ts +10 -5
- package/dest/key_store/local_key_store.d.ts.map +1 -1
- package/dest/key_store/local_key_store.js +8 -4
- package/dest/key_store/node_keystore_adapter.d.ts +18 -5
- package/dest/key_store/node_keystore_adapter.d.ts.map +1 -1
- package/dest/key_store/node_keystore_adapter.js +18 -4
- package/dest/key_store/web3signer_key_store.d.ts +10 -5
- package/dest/key_store/web3signer_key_store.d.ts.map +1 -1
- package/dest/key_store/web3signer_key_store.js +8 -4
- package/dest/metrics.d.ts +16 -3
- package/dest/metrics.d.ts.map +1 -1
- package/dest/metrics.js +58 -30
- package/dest/proposal_handler.d.ts +135 -0
- package/dest/proposal_handler.d.ts.map +1 -0
- package/dest/proposal_handler.js +1111 -0
- package/dest/validator.d.ts +85 -26
- package/dest/validator.d.ts.map +1 -1
- package/dest/validator.js +475 -105
- package/package.json +21 -13
- package/src/checkpoint_builder.ts +417 -0
- package/src/config.ts +47 -12
- package/src/duties/validation_service.ts +167 -40
- package/src/factory.ts +37 -14
- package/src/index.ts +2 -1
- package/src/key_store/ha_key_store.ts +269 -0
- package/src/key_store/index.ts +1 -0
- package/src/key_store/interface.ts +44 -5
- package/src/key_store/local_key_store.ts +13 -4
- package/src/key_store/node_keystore_adapter.ts +27 -4
- package/src/key_store/web3signer_key_store.ts +17 -4
- package/src/metrics.ts +81 -33
- package/src/proposal_handler.ts +1207 -0
- package/src/validator.ts +692 -160
- package/dest/block_proposal_handler.d.ts +0 -53
- package/dest/block_proposal_handler.d.ts.map +0 -1
- package/dest/block_proposal_handler.js +0 -290
- package/src/block_proposal_handler.ts +0 -346
package/src/validator.ts
CHANGED
|
@@ -1,46 +1,111 @@
|
|
|
1
|
-
import type {
|
|
2
|
-
import { getBlobsPerL1Block } from '@aztec/blob-lib';
|
|
1
|
+
import type { BlobClientInterface } from '@aztec/blob-client/client';
|
|
2
|
+
import { type Blob, getBlobsPerL1Block } from '@aztec/blob-lib';
|
|
3
3
|
import type { EpochCache } from '@aztec/epoch-cache';
|
|
4
|
-
import {
|
|
4
|
+
import { CheckpointNumber, EpochNumber, IndexWithinCheckpoint, SlotNumber } from '@aztec/foundation/branded-types';
|
|
5
5
|
import { Fr } from '@aztec/foundation/curves/bn254';
|
|
6
6
|
import type { EthAddress } from '@aztec/foundation/eth-address';
|
|
7
7
|
import type { Signature } from '@aztec/foundation/eth-signature';
|
|
8
|
-
import {
|
|
8
|
+
import { FifoSet } from '@aztec/foundation/fifo-set';
|
|
9
|
+
import { type LogData, type Logger, createLogger } from '@aztec/foundation/log';
|
|
9
10
|
import { RunningPromise } from '@aztec/foundation/running-promise';
|
|
10
11
|
import { sleep } from '@aztec/foundation/sleep';
|
|
11
12
|
import { DateProvider } from '@aztec/foundation/timer';
|
|
12
13
|
import type { KeystoreManager } from '@aztec/node-keystore';
|
|
13
|
-
import type { P2P, PeerId
|
|
14
|
+
import type { DuplicateAttestationInfo, DuplicateProposalInfo, P2P, PeerId } from '@aztec/p2p';
|
|
14
15
|
import { AuthRequest, AuthResponse, BlockProposalValidator, ReqRespSubProtocol } from '@aztec/p2p';
|
|
15
|
-
import {
|
|
16
|
+
import {
|
|
17
|
+
OffenseType,
|
|
18
|
+
WANT_TO_CLEAR_SLASH_EVENT,
|
|
19
|
+
WANT_TO_SLASH_EVENT,
|
|
20
|
+
type Watcher,
|
|
21
|
+
type WatcherEmitter,
|
|
22
|
+
getOffenseTypeName,
|
|
23
|
+
} from '@aztec/slasher';
|
|
16
24
|
import type { AztecAddress } from '@aztec/stdlib/aztec-address';
|
|
17
|
-
import type { CommitteeAttestationsAndSigners, L2BlockSource } from '@aztec/stdlib/block';
|
|
18
|
-
import type {
|
|
25
|
+
import type { CommitteeAttestationsAndSigners, L2BlockSink, L2BlockSource } from '@aztec/stdlib/block';
|
|
26
|
+
import type { CheckpointReexecutionTracker } from '@aztec/stdlib/checkpoint';
|
|
27
|
+
import { getEpochAtSlot } from '@aztec/stdlib/epoch-helpers';
|
|
28
|
+
import type {
|
|
29
|
+
ITxProvider,
|
|
30
|
+
Validator,
|
|
31
|
+
ValidatorClientFullConfig,
|
|
32
|
+
WorldStateSynchronizer,
|
|
33
|
+
} from '@aztec/stdlib/interfaces/server';
|
|
19
34
|
import type { L1ToL2MessageSource } from '@aztec/stdlib/messaging';
|
|
20
|
-
import
|
|
35
|
+
import {
|
|
36
|
+
type BlockProposal,
|
|
37
|
+
type BlockProposalOptions,
|
|
38
|
+
type CheckpointAttestation,
|
|
39
|
+
CheckpointProposal,
|
|
40
|
+
type CheckpointProposalCore,
|
|
41
|
+
type CheckpointProposalOptions,
|
|
42
|
+
type CoordinationSignatureContext,
|
|
43
|
+
} from '@aztec/stdlib/p2p';
|
|
21
44
|
import type { CheckpointHeader } from '@aztec/stdlib/rollup';
|
|
22
|
-
import type { Tx } from '@aztec/stdlib/tx';
|
|
45
|
+
import type { BlockHeader, Tx } from '@aztec/stdlib/tx';
|
|
23
46
|
import { AttestationTimeoutError } from '@aztec/stdlib/validators';
|
|
24
47
|
import { type TelemetryClient, type Tracer, getTelemetryClient } from '@aztec/telemetry-client';
|
|
48
|
+
import {
|
|
49
|
+
createHASigner,
|
|
50
|
+
createLocalSignerWithProtection,
|
|
51
|
+
createSignerFromSharedDb,
|
|
52
|
+
} from '@aztec/validator-ha-signer/factory';
|
|
53
|
+
import { DutyType, type SigningContext, type SlashingProtectionDatabase } from '@aztec/validator-ha-signer/types';
|
|
54
|
+
import type { ValidatorHASigner } from '@aztec/validator-ha-signer/validator-ha-signer';
|
|
25
55
|
|
|
26
56
|
import { EventEmitter } from 'events';
|
|
27
57
|
import type { TypedDataDefinition } from 'viem';
|
|
28
58
|
|
|
29
|
-
import {
|
|
59
|
+
import type { FullNodeCheckpointsBuilder } from './checkpoint_builder.js';
|
|
30
60
|
import { ValidationService } from './duties/validation_service.js';
|
|
61
|
+
import { HAKeyStore } from './key_store/ha_key_store.js';
|
|
62
|
+
import type { ExtendedValidatorKeyStore } from './key_store/interface.js';
|
|
31
63
|
import { NodeKeystoreAdapter } from './key_store/node_keystore_adapter.js';
|
|
32
64
|
import { ValidatorMetrics } from './metrics.js';
|
|
65
|
+
import {
|
|
66
|
+
type BlockProposalValidationFailureReason,
|
|
67
|
+
type CheckpointProposalValidationFailureReason,
|
|
68
|
+
type CheckpointProposalValidationFailureResult,
|
|
69
|
+
ProposalHandler,
|
|
70
|
+
} from './proposal_handler.js';
|
|
33
71
|
|
|
34
72
|
// We maintain a set of proposers who have proposed invalid blocks.
|
|
35
73
|
// Just cap the set to avoid unbounded growth.
|
|
36
74
|
const MAX_PROPOSERS_OF_INVALID_BLOCKS = 1000;
|
|
75
|
+
const MAX_TRACKED_INVALID_PROPOSAL_SLOTS = 1000;
|
|
76
|
+
const MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS = 1000;
|
|
77
|
+
const MAX_TRACKED_BAD_ATTESTATIONS = 10_000;
|
|
37
78
|
|
|
38
79
|
// What errors from the block proposal handler result in slashing
|
|
39
80
|
const SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT: BlockProposalValidationFailureReason[] = [
|
|
40
81
|
'state_mismatch',
|
|
41
82
|
'failed_txs',
|
|
83
|
+
'global_variables_mismatch',
|
|
84
|
+
'invalid_proposal',
|
|
85
|
+
'parent_block_wrong_slot',
|
|
86
|
+
'in_hash_mismatch',
|
|
42
87
|
];
|
|
43
88
|
|
|
89
|
+
const SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT: Record<CheckpointProposalValidationFailureReason, boolean> = {
|
|
90
|
+
// enabled
|
|
91
|
+
['invalid_fee_asset_price_modifier']: true,
|
|
92
|
+
['checkpoint_header_mismatch']: true,
|
|
93
|
+
// These late mismatches should normally be caught by earlier checks, but if reached after validating the local
|
|
94
|
+
// checkpoint inputs, the proposer-signed payload disagrees with deterministic recomputation.
|
|
95
|
+
['archive_mismatch']: true,
|
|
96
|
+
['out_hash_mismatch']: true,
|
|
97
|
+
['no_blocks_for_slot']: true,
|
|
98
|
+
['too_many_blocks_in_checkpoint']: true,
|
|
99
|
+
['checkpoint_validation_failed']: true,
|
|
100
|
+
['last_block_archive_mismatch']: true,
|
|
101
|
+
|
|
102
|
+
// disabled
|
|
103
|
+
['invalid_signature']: false,
|
|
104
|
+
['last_block_not_found']: false,
|
|
105
|
+
['block_fetch_error']: false,
|
|
106
|
+
['checkpoint_already_published']: false,
|
|
107
|
+
};
|
|
108
|
+
|
|
44
109
|
/**
|
|
45
110
|
* Validator Client
|
|
46
111
|
*/
|
|
@@ -49,25 +114,41 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
49
114
|
private validationService: ValidationService;
|
|
50
115
|
private metrics: ValidatorMetrics;
|
|
51
116
|
private log: Logger;
|
|
52
|
-
|
|
53
117
|
// Whether it has already registered handlers on the p2p client
|
|
54
118
|
private hasRegisteredHandlers = false;
|
|
55
119
|
|
|
56
|
-
|
|
57
|
-
private
|
|
120
|
+
/** Tracks the last block proposal we created, to detect duplicate proposal attempts. */
|
|
121
|
+
private lastProposedBlock?: BlockProposal;
|
|
122
|
+
|
|
123
|
+
/** Tracks the last checkpoint proposal we created. */
|
|
124
|
+
private lastProposedCheckpoint?: CheckpointProposal;
|
|
58
125
|
|
|
59
126
|
private lastEpochForCommitteeUpdateLoop: EpochNumber | undefined;
|
|
60
127
|
private epochCacheUpdateLoop: RunningPromise;
|
|
128
|
+
/** Tracks the last epoch in which each attester successfully submitted at least one attestation. */
|
|
129
|
+
private lastAttestedEpochByAttester: Map<string, EpochNumber> = new Map();
|
|
130
|
+
|
|
131
|
+
private proposersOfInvalidBlocks = FifoSet.withLimit<string>(MAX_PROPOSERS_OF_INVALID_BLOCKS);
|
|
132
|
+
private slotsWithInvalidProposals = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
|
|
133
|
+
private invalidCheckpointProposalOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_INVALID_CHECKPOINT_PROPOSALS);
|
|
134
|
+
private badAttestationOffenseKeys = FifoSet.withLimit<string>(MAX_TRACKED_BAD_ATTESTATIONS);
|
|
135
|
+
private slotsWithProposalEquivocation = FifoSet.withLimit<SlotNumber>(MAX_TRACKED_INVALID_PROPOSAL_SLOTS);
|
|
61
136
|
|
|
62
|
-
|
|
137
|
+
/** Tracks the last checkpoint proposal we attested to, to prevent equivocation. */
|
|
138
|
+
private lastAttestedProposal?: CheckpointProposalCore;
|
|
63
139
|
|
|
64
140
|
protected constructor(
|
|
65
|
-
private keyStore:
|
|
141
|
+
private keyStore: ExtendedValidatorKeyStore,
|
|
66
142
|
private epochCache: EpochCache,
|
|
67
143
|
private p2pClient: P2P,
|
|
68
|
-
private
|
|
144
|
+
private proposalHandler: ProposalHandler,
|
|
145
|
+
private blockSource: L2BlockSource,
|
|
146
|
+
private checkpointsBuilder: FullNodeCheckpointsBuilder,
|
|
147
|
+
private worldState: WorldStateSynchronizer,
|
|
148
|
+
private l1ToL2MessageSource: L1ToL2MessageSource,
|
|
69
149
|
private config: ValidatorClientFullConfig,
|
|
70
|
-
private
|
|
150
|
+
private blobClient: BlobClientInterface,
|
|
151
|
+
private slashingProtectionSigner: ValidatorHASigner,
|
|
71
152
|
private dateProvider: DateProvider = new DateProvider(),
|
|
72
153
|
telemetry: TelemetryClient = getTelemetryClient(),
|
|
73
154
|
log = createLogger('validator'),
|
|
@@ -80,11 +161,17 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
80
161
|
this.tracer = telemetry.getTracer('Validator');
|
|
81
162
|
this.metrics = new ValidatorMetrics(telemetry);
|
|
82
163
|
|
|
83
|
-
this.validationService = new ValidationService(
|
|
164
|
+
this.validationService = new ValidationService(
|
|
165
|
+
keyStore,
|
|
166
|
+
this.getSignatureContext(),
|
|
167
|
+
this.log.createChild('validation-service'),
|
|
168
|
+
);
|
|
169
|
+
this.proposalHandler.setCheckpointProposalValidationFailureCallback((proposal, result, proposalInfo) =>
|
|
170
|
+
this.handleInvalidCheckpointProposal(proposal, result, proposalInfo),
|
|
171
|
+
);
|
|
84
172
|
|
|
85
173
|
// Refresh epoch cache every second to trigger alert if participation in committee changes
|
|
86
174
|
this.epochCacheUpdateLoop = new RunningPromise(this.handleEpochCommitteeUpdate.bind(this), this.log, 1000);
|
|
87
|
-
|
|
88
175
|
const myAddresses = this.getValidatorAddresses();
|
|
89
176
|
this.log.verbose(`Initialized validator with addresses: ${myAddresses.map(a => a.toString()).join(', ')}`);
|
|
90
177
|
}
|
|
@@ -121,6 +208,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
121
208
|
this.log.trace(`No committee found for slot`);
|
|
122
209
|
return;
|
|
123
210
|
}
|
|
211
|
+
this.metrics.setCurrentEpoch(epoch);
|
|
124
212
|
if (epoch !== this.lastEpochForCommitteeUpdateLoop) {
|
|
125
213
|
const me = this.getValidatorAddresses();
|
|
126
214
|
const committeeSet = new Set(committee.map(v => v.toString()));
|
|
@@ -141,42 +229,91 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
141
229
|
}
|
|
142
230
|
}
|
|
143
231
|
|
|
144
|
-
static new(
|
|
232
|
+
static async new(
|
|
145
233
|
config: ValidatorClientFullConfig,
|
|
146
|
-
|
|
234
|
+
checkpointsBuilder: FullNodeCheckpointsBuilder,
|
|
235
|
+
worldState: WorldStateSynchronizer,
|
|
147
236
|
epochCache: EpochCache,
|
|
148
237
|
p2pClient: P2P,
|
|
149
|
-
blockSource: L2BlockSource,
|
|
238
|
+
blockSource: L2BlockSource & L2BlockSink,
|
|
150
239
|
l1ToL2MessageSource: L1ToL2MessageSource,
|
|
151
|
-
txProvider:
|
|
240
|
+
txProvider: ITxProvider,
|
|
152
241
|
keyStoreManager: KeystoreManager,
|
|
153
|
-
|
|
242
|
+
blobClient: BlobClientInterface,
|
|
243
|
+
reexecutionTracker: CheckpointReexecutionTracker,
|
|
154
244
|
dateProvider: DateProvider = new DateProvider(),
|
|
155
245
|
telemetry: TelemetryClient = getTelemetryClient(),
|
|
246
|
+
slashingProtectionDb?: SlashingProtectionDatabase,
|
|
156
247
|
) {
|
|
157
248
|
const metrics = new ValidatorMetrics(telemetry);
|
|
158
249
|
const blockProposalValidator = new BlockProposalValidator(epochCache, {
|
|
159
250
|
txsPermitted: !config.disableTransactions,
|
|
251
|
+
maxTxsPerBlock: config.validateMaxTxsPerBlock,
|
|
252
|
+
maxBlocksPerCheckpoint: config.maxBlocksPerCheckpoint,
|
|
253
|
+
skipSlotValidation: config.skipProposalSlotValidation,
|
|
254
|
+
signatureContext: {
|
|
255
|
+
chainId: config.l1ChainId,
|
|
256
|
+
rollupAddress: config.rollupAddress,
|
|
257
|
+
},
|
|
160
258
|
});
|
|
161
|
-
const
|
|
162
|
-
|
|
259
|
+
const proposalHandler = new ProposalHandler(
|
|
260
|
+
checkpointsBuilder,
|
|
261
|
+
worldState,
|
|
163
262
|
blockSource,
|
|
164
263
|
l1ToL2MessageSource,
|
|
165
264
|
txProvider,
|
|
166
265
|
blockProposalValidator,
|
|
266
|
+
epochCache,
|
|
167
267
|
config,
|
|
268
|
+
blobClient,
|
|
269
|
+
reexecutionTracker,
|
|
168
270
|
metrics,
|
|
169
271
|
dateProvider,
|
|
170
272
|
telemetry,
|
|
273
|
+
undefined,
|
|
171
274
|
);
|
|
172
275
|
|
|
276
|
+
const nodeKeystoreAdapter = NodeKeystoreAdapter.fromKeyStoreManager(keyStoreManager);
|
|
277
|
+
let slashingProtectionSigner: ValidatorHASigner;
|
|
278
|
+
if (slashingProtectionDb) {
|
|
279
|
+
// Shared database mode: use a pre-existing database (e.g. for testing HA setups).
|
|
280
|
+
({ signer: slashingProtectionSigner } = createSignerFromSharedDb(slashingProtectionDb, config, {
|
|
281
|
+
telemetryClient: telemetry,
|
|
282
|
+
dateProvider,
|
|
283
|
+
}));
|
|
284
|
+
} else if (config.haSigningEnabled) {
|
|
285
|
+
// Multi-node HA mode: use PostgreSQL-backed distributed locking.
|
|
286
|
+
// If maxStuckDutiesAgeMs is not explicitly set, compute it from Aztec slot duration
|
|
287
|
+
const haConfig = {
|
|
288
|
+
...config,
|
|
289
|
+
maxStuckDutiesAgeMs: config.maxStuckDutiesAgeMs ?? epochCache.getL1Constants().slotDuration * 2 * 1000,
|
|
290
|
+
};
|
|
291
|
+
({ signer: slashingProtectionSigner } = await createHASigner(haConfig, {
|
|
292
|
+
telemetryClient: telemetry,
|
|
293
|
+
dateProvider,
|
|
294
|
+
}));
|
|
295
|
+
} else {
|
|
296
|
+
// Single-node mode: use LMDB-backed local signing protection.
|
|
297
|
+
// This prevents double-signing if the node crashes and restarts mid-proposal.
|
|
298
|
+
({ signer: slashingProtectionSigner } = await createLocalSignerWithProtection(config, {
|
|
299
|
+
telemetryClient: telemetry,
|
|
300
|
+
dateProvider,
|
|
301
|
+
}));
|
|
302
|
+
}
|
|
303
|
+
const validatorKeyStore: ExtendedValidatorKeyStore = new HAKeyStore(nodeKeystoreAdapter, slashingProtectionSigner);
|
|
304
|
+
|
|
173
305
|
const validator = new ValidatorClient(
|
|
174
|
-
|
|
306
|
+
validatorKeyStore,
|
|
175
307
|
epochCache,
|
|
176
308
|
p2pClient,
|
|
177
|
-
|
|
309
|
+
proposalHandler,
|
|
310
|
+
blockSource,
|
|
311
|
+
checkpointsBuilder,
|
|
312
|
+
worldState,
|
|
313
|
+
l1ToL2MessageSource,
|
|
178
314
|
config,
|
|
179
|
-
|
|
315
|
+
blobClient,
|
|
316
|
+
slashingProtectionSigner,
|
|
180
317
|
dateProvider,
|
|
181
318
|
telemetry,
|
|
182
319
|
);
|
|
@@ -190,22 +327,19 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
190
327
|
.filter(addr => !this.config.disabledValidators.some(disabled => disabled.equals(addr)));
|
|
191
328
|
}
|
|
192
329
|
|
|
193
|
-
public
|
|
194
|
-
return this.
|
|
330
|
+
public getProposalHandler() {
|
|
331
|
+
return this.proposalHandler;
|
|
195
332
|
}
|
|
196
333
|
|
|
197
|
-
|
|
198
|
-
|
|
199
|
-
proposal: BlockProposal,
|
|
200
|
-
blockNumber: BlockNumber,
|
|
201
|
-
txs: any[],
|
|
202
|
-
l1ToL2Messages: Fr[],
|
|
203
|
-
): Promise<any> {
|
|
204
|
-
return this.blockProposalHandler.reexecuteTransactions(proposal, blockNumber, txs, l1ToL2Messages);
|
|
334
|
+
public signWithAddress(addr: EthAddress, msg: TypedDataDefinition, context: SigningContext) {
|
|
335
|
+
return this.keyStore.signTypedDataWithAddress(addr, msg, context);
|
|
205
336
|
}
|
|
206
337
|
|
|
207
|
-
|
|
208
|
-
return
|
|
338
|
+
private getSignatureContext(): CoordinationSignatureContext {
|
|
339
|
+
return {
|
|
340
|
+
chainId: this.config.l1ChainId,
|
|
341
|
+
rollupAddress: this.config.rollupAddress,
|
|
342
|
+
};
|
|
209
343
|
}
|
|
210
344
|
|
|
211
345
|
public getCoinbaseForAttestor(attestor: EthAddress): EthAddress {
|
|
@@ -220,8 +354,27 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
220
354
|
return this.config;
|
|
221
355
|
}
|
|
222
356
|
|
|
357
|
+
public hasProposalEquivocation(slotNumber: SlotNumber): boolean {
|
|
358
|
+
return this.slotsWithProposalEquivocation.has(slotNumber);
|
|
359
|
+
}
|
|
360
|
+
|
|
361
|
+
public hasInvalidProposals(slotNumber: SlotNumber): boolean {
|
|
362
|
+
return this.slotsWithInvalidProposals.has(slotNumber);
|
|
363
|
+
}
|
|
364
|
+
|
|
223
365
|
public updateConfig(config: Partial<ValidatorClientFullConfig>) {
|
|
224
366
|
this.config = { ...this.config, ...config };
|
|
367
|
+
this.proposalHandler.updateConfig(config);
|
|
368
|
+
}
|
|
369
|
+
|
|
370
|
+
public reloadKeystore(newManager: KeystoreManager): void {
|
|
371
|
+
const newAdapter = NodeKeystoreAdapter.fromKeyStoreManager(newManager);
|
|
372
|
+
this.keyStore = new HAKeyStore(newAdapter, this.slashingProtectionSigner);
|
|
373
|
+
this.validationService = new ValidationService(
|
|
374
|
+
this.keyStore,
|
|
375
|
+
this.getSignatureContext(),
|
|
376
|
+
this.log.createChild('validation-service'),
|
|
377
|
+
);
|
|
225
378
|
}
|
|
226
379
|
|
|
227
380
|
public async start() {
|
|
@@ -230,6 +383,8 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
230
383
|
return;
|
|
231
384
|
}
|
|
232
385
|
|
|
386
|
+
await this.keyStore.start();
|
|
387
|
+
|
|
233
388
|
await this.registerHandlers();
|
|
234
389
|
|
|
235
390
|
const myAddresses = this.getValidatorAddresses();
|
|
@@ -245,6 +400,7 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
245
400
|
|
|
246
401
|
public async stop() {
|
|
247
402
|
await this.epochCacheUpdateLoop.stop();
|
|
403
|
+
await this.keyStore.stop();
|
|
248
404
|
}
|
|
249
405
|
|
|
250
406
|
/** Register handlers on the p2p client */
|
|
@@ -253,9 +409,33 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
253
409
|
this.hasRegisteredHandlers = true;
|
|
254
410
|
this.log.debug(`Registering validator handlers for p2p client`);
|
|
255
411
|
|
|
256
|
-
|
|
257
|
-
|
|
258
|
-
|
|
412
|
+
// Block proposal handler - validates but does NOT attest (validators only attest to checkpoints)
|
|
413
|
+
const blockHandler = (block: BlockProposal, proposalSender: PeerId): Promise<boolean> =>
|
|
414
|
+
this.validateBlockProposal(block, proposalSender);
|
|
415
|
+
this.p2pClient.registerBlockProposalHandler(blockHandler);
|
|
416
|
+
|
|
417
|
+
// Checkpoint proposal handler - validates and creates attestations
|
|
418
|
+
// The checkpoint is received as CheckpointProposalCore since the lastBlock is extracted
|
|
419
|
+
// and processed separately via the block handler above.
|
|
420
|
+
const checkpointHandler = (
|
|
421
|
+
checkpoint: CheckpointProposalCore,
|
|
422
|
+
proposalSender: PeerId,
|
|
423
|
+
): Promise<CheckpointAttestation[] | undefined> => this.attestToCheckpointProposal(checkpoint, proposalSender);
|
|
424
|
+
this.p2pClient.registerValidatorCheckpointProposalHandler(checkpointHandler);
|
|
425
|
+
|
|
426
|
+
// Duplicate proposal handler - triggers slashing for equivocation
|
|
427
|
+
this.p2pClient.registerDuplicateProposalCallback((info: DuplicateProposalInfo) => {
|
|
428
|
+
this.handleDuplicateProposal(info);
|
|
429
|
+
});
|
|
430
|
+
|
|
431
|
+
// Duplicate attestation handler - triggers slashing for attestation equivocation
|
|
432
|
+
this.p2pClient.registerDuplicateAttestationCallback((info: DuplicateAttestationInfo) => {
|
|
433
|
+
this.handleDuplicateAttestation(info);
|
|
434
|
+
});
|
|
435
|
+
|
|
436
|
+
this.p2pClient.registerCheckpointAttestationCallback((attestation: CheckpointAttestation) => {
|
|
437
|
+
this.handleCheckpointAttestation(attestation);
|
|
438
|
+
});
|
|
259
439
|
|
|
260
440
|
const myAddresses = this.getValidatorAddresses();
|
|
261
441
|
this.p2pClient.registerThisValidatorAddresses(myAddresses);
|
|
@@ -264,49 +444,53 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
264
444
|
}
|
|
265
445
|
}
|
|
266
446
|
|
|
267
|
-
|
|
447
|
+
/**
|
|
448
|
+
* Validate a block proposal from a peer.
|
|
449
|
+
* Note: Validators do NOT attest to individual blocks - attestations are only for checkpoint proposals.
|
|
450
|
+
* @returns true if the proposal is valid, false otherwise
|
|
451
|
+
*/
|
|
452
|
+
async validateBlockProposal(proposal: BlockProposal, proposalSender: PeerId): Promise<boolean> {
|
|
268
453
|
const slotNumber = proposal.slotNumber;
|
|
454
|
+
|
|
455
|
+
// Note: During escape hatch, we still want to "validate" proposals for observability,
|
|
456
|
+
// but we intentionally reject them and disable slashing invalid block and attestation flow.
|
|
457
|
+
const escapeHatchOpen = await this.epochCache.isEscapeHatchOpenAtSlot(slotNumber);
|
|
458
|
+
|
|
269
459
|
const proposer = proposal.getSender();
|
|
270
460
|
|
|
271
461
|
// Reject proposals with invalid signatures
|
|
272
462
|
if (!proposer) {
|
|
273
|
-
this.log.warn(`Received proposal with invalid signature for slot ${slotNumber}`);
|
|
274
|
-
return
|
|
463
|
+
this.log.warn(`Received block proposal with invalid signature for slot ${slotNumber}`);
|
|
464
|
+
return false;
|
|
275
465
|
}
|
|
276
466
|
|
|
277
|
-
//
|
|
467
|
+
// Log self-proposals from HA peers (same validator key on different nodes)
|
|
468
|
+
if (this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
|
|
469
|
+
this.log.verbose(`Processing block proposal from HA peer for slot ${slotNumber}`, {
|
|
470
|
+
proposer: proposer.toString(),
|
|
471
|
+
slotNumber,
|
|
472
|
+
});
|
|
473
|
+
}
|
|
474
|
+
|
|
475
|
+
// Check if we're in the committee (for metrics purposes)
|
|
278
476
|
const inCommittee = await this.epochCache.filterInCommittee(slotNumber, this.getValidatorAddresses());
|
|
279
477
|
const partOfCommittee = inCommittee.length > 0;
|
|
280
478
|
|
|
281
479
|
const proposalInfo = { ...proposal.toBlockInfo(), proposer: proposer.toString() };
|
|
282
|
-
this.log.info(`Received proposal for slot ${slotNumber}`, {
|
|
480
|
+
this.log.info(`Received block proposal for slot ${slotNumber}`, {
|
|
283
481
|
...proposalInfo,
|
|
284
482
|
txHashes: proposal.txHashes.map(t => t.toString()),
|
|
285
483
|
fishermanMode: this.config.fishermanMode || false,
|
|
286
484
|
});
|
|
287
485
|
|
|
288
|
-
// Reexecute
|
|
289
|
-
|
|
290
|
-
// In fisherman mode, we always reexecute to validate proposals.
|
|
291
|
-
const { validatorReexecute, slashBroadcastedInvalidBlockPenalty, alwaysReexecuteBlockProposals, fishermanMode } =
|
|
292
|
-
this.config;
|
|
293
|
-
const shouldReexecute =
|
|
294
|
-
fishermanMode ||
|
|
295
|
-
(slashBroadcastedInvalidBlockPenalty > 0n && validatorReexecute) ||
|
|
296
|
-
(partOfCommittee && validatorReexecute) ||
|
|
297
|
-
alwaysReexecuteBlockProposals ||
|
|
298
|
-
this.fileStoreBlobUploadClient;
|
|
299
|
-
|
|
300
|
-
const validationResult = await this.blockProposalHandler.handleBlockProposal(
|
|
301
|
-
proposal,
|
|
302
|
-
proposalSender,
|
|
303
|
-
!!shouldReexecute,
|
|
304
|
-
);
|
|
486
|
+
// Reexecute outside the escape hatch so slashing observers can detect invalid proposals even when penalties are 0.
|
|
487
|
+
const validationResult = await this.proposalHandler.handleBlockProposal(proposal, proposalSender, !escapeHatchOpen);
|
|
305
488
|
|
|
306
489
|
if (!validationResult.isValid) {
|
|
307
|
-
this.log.warn(`Proposal validation failed: ${validationResult.reason}`, proposalInfo);
|
|
308
|
-
|
|
309
490
|
const reason = validationResult.reason || 'unknown';
|
|
491
|
+
|
|
492
|
+
this.log.warn(`Block proposal validation failed: ${reason}`, proposalInfo);
|
|
493
|
+
|
|
310
494
|
// Classify failure reason: bad proposal vs node issue
|
|
311
495
|
const badProposalReasons: BlockProposalValidationFailureReason[] = [
|
|
312
496
|
'invalid_proposal',
|
|
@@ -319,22 +503,103 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
319
503
|
if (badProposalReasons.includes(reason as BlockProposalValidationFailureReason)) {
|
|
320
504
|
this.metrics.incFailedAttestationsBadProposal(1, reason, partOfCommittee);
|
|
321
505
|
} else {
|
|
322
|
-
// Node issues so we can't
|
|
506
|
+
// Node issues so we can't validate
|
|
323
507
|
this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
|
|
324
508
|
}
|
|
325
509
|
|
|
326
|
-
// Slash invalid block proposals (can happen even when not in committee)
|
|
327
510
|
if (
|
|
511
|
+
!escapeHatchOpen &&
|
|
328
512
|
validationResult.reason &&
|
|
329
|
-
SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)
|
|
330
|
-
slashBroadcastedInvalidBlockPenalty > 0n
|
|
513
|
+
SLASHABLE_BLOCK_PROPOSAL_VALIDATION_RESULT.includes(validationResult.reason)
|
|
331
514
|
) {
|
|
332
|
-
this.log.
|
|
515
|
+
this.log.info(`Detected invalid block proposal offense`, {
|
|
516
|
+
...proposalInfo,
|
|
517
|
+
amount: this.config.slashBroadcastedInvalidBlockPenalty,
|
|
518
|
+
offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_BLOCK_PROPOSAL),
|
|
519
|
+
});
|
|
333
520
|
this.slashInvalidBlock(proposal);
|
|
521
|
+
this.markInvalidProposalSlot(proposal.slotNumber);
|
|
334
522
|
}
|
|
523
|
+
return false;
|
|
524
|
+
}
|
|
525
|
+
|
|
526
|
+
this.log.info(`Validated block proposal for slot ${slotNumber}`, {
|
|
527
|
+
...proposalInfo,
|
|
528
|
+
inCommittee: partOfCommittee,
|
|
529
|
+
fishermanMode: this.config.fishermanMode || false,
|
|
530
|
+
escapeHatchOpen,
|
|
531
|
+
});
|
|
532
|
+
|
|
533
|
+
if (escapeHatchOpen) {
|
|
534
|
+
this.log.warn(`Escape hatch open for slot ${slotNumber}, rejecting block proposal`, proposalInfo);
|
|
535
|
+
return false;
|
|
536
|
+
}
|
|
537
|
+
|
|
538
|
+
return true;
|
|
539
|
+
}
|
|
540
|
+
|
|
541
|
+
/**
|
|
542
|
+
* Validate and attest to a checkpoint proposal from a peer.
|
|
543
|
+
* The proposal is received as CheckpointProposalCore (without lastBlock) since
|
|
544
|
+
* the lastBlock is extracted and processed separately via the block handler.
|
|
545
|
+
* @returns Checkpoint attestations if valid, undefined otherwise
|
|
546
|
+
*/
|
|
547
|
+
async attestToCheckpointProposal(
|
|
548
|
+
proposal: CheckpointProposalCore,
|
|
549
|
+
_proposalSender: PeerId,
|
|
550
|
+
): Promise<CheckpointAttestation[] | undefined> {
|
|
551
|
+
const proposalSlotNumber = proposal.slotNumber;
|
|
552
|
+
const proposer = proposal.getSender();
|
|
553
|
+
|
|
554
|
+
// If escape hatch is open for this slot's epoch, do not attest.
|
|
555
|
+
if (await this.epochCache.isEscapeHatchOpenAtSlot(proposalSlotNumber)) {
|
|
556
|
+
this.log.warn(`Escape hatch open for slot ${proposalSlotNumber}, skipping checkpoint attestation handling`);
|
|
335
557
|
return undefined;
|
|
336
558
|
}
|
|
337
559
|
|
|
560
|
+
// Early-out for equivocation: refuses if we've already attested to a higher slot.
|
|
561
|
+
if (!this.shouldAttestToSlot(proposalSlotNumber)) {
|
|
562
|
+
return undefined;
|
|
563
|
+
}
|
|
564
|
+
|
|
565
|
+
// Ignore proposals from ourselves (may happen in HA setups)
|
|
566
|
+
if (proposer && this.getValidatorAddresses().some(addr => addr.equals(proposer))) {
|
|
567
|
+
this.log.debug(`Ignoring block proposal from self for slot ${proposalSlotNumber}`, {
|
|
568
|
+
proposer: proposer.toString(),
|
|
569
|
+
proposalSlotNumber,
|
|
570
|
+
});
|
|
571
|
+
return undefined;
|
|
572
|
+
}
|
|
573
|
+
|
|
574
|
+
// Check that I have any address in the committee where this checkpoint will land before attesting
|
|
575
|
+
const inCommittee = await this.epochCache.filterInCommittee(proposalSlotNumber, this.getValidatorAddresses());
|
|
576
|
+
const partOfCommittee = inCommittee.length > 0;
|
|
577
|
+
|
|
578
|
+
const proposalInfo = {
|
|
579
|
+
proposalSlotNumber,
|
|
580
|
+
archive: proposal.archive.toString(),
|
|
581
|
+
proposer: proposer?.toString(),
|
|
582
|
+
};
|
|
583
|
+
this.log.info(`Received checkpoint proposal for slot ${proposalSlotNumber}`, {
|
|
584
|
+
...proposalInfo,
|
|
585
|
+
fishermanMode: this.config.fishermanMode || false,
|
|
586
|
+
});
|
|
587
|
+
|
|
588
|
+
// Validate the checkpoint proposal before attesting (unless skipCheckpointProposalValidation is set).
|
|
589
|
+
// Uses the cached result from the all-nodes callback if available (avoids double validation).
|
|
590
|
+
let checkpointNumber: CheckpointNumber;
|
|
591
|
+
if (this.config.skipCheckpointProposalValidation) {
|
|
592
|
+
this.log.warn(`Skipping checkpoint proposal validation for slot ${proposalSlotNumber}`, proposalInfo);
|
|
593
|
+
checkpointNumber = CheckpointNumber(0);
|
|
594
|
+
} else {
|
|
595
|
+
const validationResult = await this.proposalHandler.handleCheckpointProposal(proposal, proposalInfo);
|
|
596
|
+
if (!validationResult.isValid) {
|
|
597
|
+
this.log.warn(`Checkpoint proposal validation failed: ${validationResult.reason}`, proposalInfo);
|
|
598
|
+
return undefined;
|
|
599
|
+
}
|
|
600
|
+
checkpointNumber = validationResult.checkpointNumber;
|
|
601
|
+
}
|
|
602
|
+
|
|
338
603
|
// Check that I have any address in current committee before attesting
|
|
339
604
|
// In fisherman mode, we still create attestations for validation even if not in committee
|
|
340
605
|
if (!partOfCommittee && !this.config.fishermanMode) {
|
|
@@ -343,29 +608,28 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
343
608
|
}
|
|
344
609
|
|
|
345
610
|
// Provided all of the above checks pass, we can attest to the proposal
|
|
346
|
-
this.log.info(
|
|
347
|
-
|
|
348
|
-
|
|
349
|
-
|
|
350
|
-
|
|
611
|
+
this.log.info(
|
|
612
|
+
`${partOfCommittee ? 'Attesting to' : 'Validated'} checkpoint proposal for slot ${proposalSlotNumber}`,
|
|
613
|
+
{
|
|
614
|
+
...proposalInfo,
|
|
615
|
+
inCommittee: partOfCommittee,
|
|
616
|
+
fishermanMode: this.config.fishermanMode || false,
|
|
617
|
+
},
|
|
618
|
+
);
|
|
351
619
|
|
|
352
620
|
this.metrics.incSuccessfulAttestations(inCommittee.length);
|
|
353
621
|
|
|
354
|
-
//
|
|
355
|
-
|
|
356
|
-
|
|
357
|
-
|
|
358
|
-
|
|
359
|
-
|
|
360
|
-
|
|
361
|
-
|
|
362
|
-
|
|
363
|
-
this.log.warn(`Failed to upload blobs from re-execution`, err);
|
|
364
|
-
}
|
|
365
|
-
});
|
|
622
|
+
// Track epoch participation per attester: count each (attester, epoch) pair at most once
|
|
623
|
+
const proposalEpoch = getEpochAtSlot(proposalSlotNumber, this.epochCache.getL1Constants());
|
|
624
|
+
for (const attester of inCommittee) {
|
|
625
|
+
const key = attester.toString();
|
|
626
|
+
const lastEpoch = this.lastAttestedEpochByAttester.get(key);
|
|
627
|
+
if (lastEpoch === undefined || proposalEpoch > lastEpoch) {
|
|
628
|
+
this.lastAttestedEpochByAttester.set(key, proposalEpoch);
|
|
629
|
+
this.metrics.incAttestedEpochCount(attester);
|
|
630
|
+
}
|
|
366
631
|
}
|
|
367
632
|
|
|
368
|
-
// If the above function does not throw an error, then we can attest to the proposal
|
|
369
633
|
// Determine which validators should attest
|
|
370
634
|
let attestors: EthAddress[];
|
|
371
635
|
if (partOfCommittee) {
|
|
@@ -384,13 +648,83 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
384
648
|
|
|
385
649
|
if (this.config.fishermanMode) {
|
|
386
650
|
// bail out early and don't save attestations to the pool in fisherman mode
|
|
387
|
-
this.log.info(`Creating attestations for
|
|
651
|
+
this.log.info(`Creating checkpoint attestations for slot ${proposalSlotNumber}`, {
|
|
388
652
|
...proposalInfo,
|
|
389
653
|
attestors: attestors.map(a => a.toString()),
|
|
390
654
|
});
|
|
391
655
|
return undefined;
|
|
392
656
|
}
|
|
393
|
-
|
|
657
|
+
|
|
658
|
+
return await this.createCheckpointAttestationsFromProposal(proposal, attestors, checkpointNumber);
|
|
659
|
+
}
|
|
660
|
+
|
|
661
|
+
/**
|
|
662
|
+
* Checks if we should attest to a slot based on equivocation prevention rules.
|
|
663
|
+
* @returns true if we should attest, false if we should skip
|
|
664
|
+
*/
|
|
665
|
+
private shouldAttestToSlot(slotNumber: SlotNumber): boolean {
|
|
666
|
+
// If attestToEquivocatedProposals is true, always allow
|
|
667
|
+
if (this.config.attestToEquivocatedProposals) {
|
|
668
|
+
return true;
|
|
669
|
+
}
|
|
670
|
+
|
|
671
|
+
// Check if incoming slot is strictly greater than last attested
|
|
672
|
+
if (this.lastAttestedProposal && slotNumber <= this.lastAttestedProposal.slotNumber) {
|
|
673
|
+
this.log.warn(
|
|
674
|
+
`Refusing to process a proposal for slot ${slotNumber} given we already attested to a proposal for slot ${this.lastAttestedProposal.slotNumber}`,
|
|
675
|
+
);
|
|
676
|
+
return false;
|
|
677
|
+
}
|
|
678
|
+
|
|
679
|
+
return true;
|
|
680
|
+
}
|
|
681
|
+
|
|
682
|
+
private async createCheckpointAttestationsFromProposal(
|
|
683
|
+
proposal: CheckpointProposalCore,
|
|
684
|
+
attestors: EthAddress[] = [],
|
|
685
|
+
checkpointNumber: CheckpointNumber,
|
|
686
|
+
): Promise<CheckpointAttestation[] | undefined> {
|
|
687
|
+
// Equivocation check: must happen right before signing to minimize the race window
|
|
688
|
+
if (!this.shouldAttestToSlot(proposal.slotNumber)) {
|
|
689
|
+
return undefined;
|
|
690
|
+
}
|
|
691
|
+
|
|
692
|
+
const attestations = await this.validationService.attestToCheckpointProposal(proposal, attestors, checkpointNumber);
|
|
693
|
+
|
|
694
|
+
// Track the proposal we attested to (to prevent equivocation)
|
|
695
|
+
this.lastAttestedProposal = proposal;
|
|
696
|
+
|
|
697
|
+
await this.p2pClient.addOwnCheckpointAttestations(attestations);
|
|
698
|
+
return attestations;
|
|
699
|
+
}
|
|
700
|
+
|
|
701
|
+
/**
|
|
702
|
+
* Uploads blobs for a checkpoint to the filestore (fire and forget).
|
|
703
|
+
*/
|
|
704
|
+
protected async uploadBlobsForCheckpoint(proposal: CheckpointProposalCore, proposalInfo: LogData): Promise<void> {
|
|
705
|
+
try {
|
|
706
|
+
const lastBlockHeader = (await this.blockSource.getBlockData({ archive: proposal.archive }))?.header;
|
|
707
|
+
if (!lastBlockHeader) {
|
|
708
|
+
this.log.warn(`Failed to get last block header for blob upload`, proposalInfo);
|
|
709
|
+
return;
|
|
710
|
+
}
|
|
711
|
+
|
|
712
|
+
const blocks = await this.blockSource.getBlocksForSlot(proposal.slotNumber);
|
|
713
|
+
if (blocks.length === 0) {
|
|
714
|
+
this.log.warn(`No blocks found for blob upload`, proposalInfo);
|
|
715
|
+
return;
|
|
716
|
+
}
|
|
717
|
+
|
|
718
|
+
const blobFields = blocks.flatMap(b => b.toBlobFields());
|
|
719
|
+
const blobs: Blob[] = await getBlobsPerL1Block(blobFields);
|
|
720
|
+
await this.blobClient.sendBlobsToFilestore(blobs);
|
|
721
|
+
this.log.debug(`Uploaded ${blobs.length} blobs to filestore for checkpoint at slot ${proposal.slotNumber}`, {
|
|
722
|
+
...proposalInfo,
|
|
723
|
+
numBlobs: blobs.length,
|
|
724
|
+
});
|
|
725
|
+
} catch (err) {
|
|
726
|
+
this.log.warn(`Failed to upload blobs for checkpoint: ${err}`, proposalInfo);
|
|
727
|
+
}
|
|
394
728
|
}
|
|
395
729
|
|
|
396
730
|
private slashInvalidBlock(proposal: BlockProposal) {
|
|
@@ -402,12 +736,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
402
736
|
return;
|
|
403
737
|
}
|
|
404
738
|
|
|
405
|
-
// Trim the set if it's too big.
|
|
406
|
-
if (this.proposersOfInvalidBlocks.size > MAX_PROPOSERS_OF_INVALID_BLOCKS) {
|
|
407
|
-
// remove oldest proposer. `values` is guaranteed to be in insertion order.
|
|
408
|
-
this.proposersOfInvalidBlocks.delete(this.proposersOfInvalidBlocks.values().next().value!);
|
|
409
|
-
}
|
|
410
|
-
|
|
411
739
|
this.proposersOfInvalidBlocks.add(proposer.toString());
|
|
412
740
|
|
|
413
741
|
this.emit(WANT_TO_SLASH_EVENT, [
|
|
@@ -420,40 +748,242 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
420
748
|
]);
|
|
421
749
|
}
|
|
422
750
|
|
|
423
|
-
|
|
751
|
+
private handleInvalidCheckpointProposal(
|
|
752
|
+
proposal: CheckpointProposalCore,
|
|
753
|
+
result: CheckpointProposalValidationFailureResult,
|
|
754
|
+
proposalInfo: LogData,
|
|
755
|
+
): void {
|
|
756
|
+
if (!SLASHABLE_CHECKPOINT_PROPOSAL_VALIDATION_RESULT[result.reason]) {
|
|
757
|
+
return;
|
|
758
|
+
}
|
|
759
|
+
|
|
760
|
+
this.markInvalidProposalSlot(proposal.slotNumber);
|
|
761
|
+
|
|
762
|
+
if (this.slashInvalidCheckpointProposal(proposal)) {
|
|
763
|
+
this.log.info(`Detected invalid checkpoint proposal offense`, {
|
|
764
|
+
...proposalInfo,
|
|
765
|
+
reason: result.reason,
|
|
766
|
+
amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
|
|
767
|
+
offenseType: getOffenseTypeName(OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL),
|
|
768
|
+
});
|
|
769
|
+
}
|
|
770
|
+
}
|
|
771
|
+
|
|
772
|
+
private slashInvalidCheckpointProposal(proposal: CheckpointProposalCore): boolean {
|
|
773
|
+
const proposer = proposal.getSender();
|
|
774
|
+
if (!proposer) {
|
|
775
|
+
this.log.warn(`Cannot slash checkpoint proposal with invalid signature`, {
|
|
776
|
+
slotNumber: proposal.slotNumber,
|
|
777
|
+
archive: proposal.archive.toString(),
|
|
778
|
+
});
|
|
779
|
+
return false;
|
|
780
|
+
}
|
|
781
|
+
|
|
782
|
+
const offenseType = OffenseType.BROADCASTED_INVALID_CHECKPOINT_PROPOSAL;
|
|
783
|
+
const offenseKey = `${proposer.toString()}:${offenseType}:${proposal.slotNumber}`;
|
|
784
|
+
if (!this.invalidCheckpointProposalOffenseKeys.addIfAbsent(offenseKey)) {
|
|
785
|
+
return false;
|
|
786
|
+
}
|
|
787
|
+
|
|
788
|
+
this.emit(WANT_TO_SLASH_EVENT, [
|
|
789
|
+
{
|
|
790
|
+
validator: proposer,
|
|
791
|
+
amount: this.config.slashBroadcastedInvalidCheckpointProposalPenalty,
|
|
792
|
+
offenseType,
|
|
793
|
+
epochOrSlot: BigInt(proposal.slotNumber),
|
|
794
|
+
},
|
|
795
|
+
]);
|
|
796
|
+
return true;
|
|
797
|
+
}
|
|
798
|
+
|
|
799
|
+
private markInvalidProposalSlot(slotNumber: SlotNumber): void {
|
|
800
|
+
this.slotsWithInvalidProposals.add(slotNumber);
|
|
801
|
+
}
|
|
802
|
+
|
|
803
|
+
private handleCheckpointAttestation(attestation: CheckpointAttestation): void {
|
|
804
|
+
const slotNumber = attestation.slotNumber;
|
|
805
|
+
if (!this.slotsWithInvalidProposals.has(slotNumber) || this.slotsWithProposalEquivocation.has(slotNumber)) {
|
|
806
|
+
return;
|
|
807
|
+
}
|
|
808
|
+
|
|
809
|
+
const attester = attestation.getSender();
|
|
810
|
+
if (!attester) {
|
|
811
|
+
this.log.warn(`Cannot slash checkpoint attestation with invalid signature`, {
|
|
812
|
+
slotNumber,
|
|
813
|
+
archive: attestation.archive.toString(),
|
|
814
|
+
});
|
|
815
|
+
return;
|
|
816
|
+
}
|
|
817
|
+
|
|
818
|
+
this.slashAttestedToInvalidCheckpointProposal(slotNumber, attester);
|
|
819
|
+
}
|
|
820
|
+
|
|
821
|
+
private slashAttestedToInvalidCheckpointProposal(slotNumber: SlotNumber, attester: EthAddress): void {
|
|
822
|
+
const offenseKey = `${attester.toString()}:${OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL}:${slotNumber}`;
|
|
823
|
+
if (!this.badAttestationOffenseKeys.addIfAbsent(offenseKey)) {
|
|
824
|
+
return;
|
|
825
|
+
}
|
|
826
|
+
|
|
827
|
+
this.log.info(`Detected attestation to invalid checkpoint proposal offense`, {
|
|
828
|
+
attester: attester.toString(),
|
|
829
|
+
slotNumber,
|
|
830
|
+
amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
|
|
831
|
+
offenseType: getOffenseTypeName(OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL),
|
|
832
|
+
});
|
|
833
|
+
|
|
834
|
+
this.emit(WANT_TO_SLASH_EVENT, [
|
|
835
|
+
{
|
|
836
|
+
validator: attester,
|
|
837
|
+
amount: this.config.slashAttestInvalidCheckpointProposalPenalty,
|
|
838
|
+
offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
|
|
839
|
+
epochOrSlot: BigInt(slotNumber),
|
|
840
|
+
},
|
|
841
|
+
]);
|
|
842
|
+
}
|
|
843
|
+
|
|
844
|
+
/**
|
|
845
|
+
* Handle detection of a duplicate proposal (equivocation).
|
|
846
|
+
* Emits a slash event when a proposer sends multiple proposals for the same position.
|
|
847
|
+
*/
|
|
848
|
+
private handleDuplicateProposal(info: DuplicateProposalInfo): void {
|
|
849
|
+
const { slot, proposer, type } = info;
|
|
850
|
+
this.slotsWithProposalEquivocation.add(slot);
|
|
851
|
+
|
|
852
|
+
this.log.info(`Detected duplicate ${type} proposal offense from ${proposer.toString()} at slot ${slot}`, {
|
|
853
|
+
proposer: proposer.toString(),
|
|
854
|
+
slot,
|
|
855
|
+
type,
|
|
856
|
+
amount: this.config.slashDuplicateProposalPenalty,
|
|
857
|
+
offenseType: getOffenseTypeName(OffenseType.DUPLICATE_PROPOSAL),
|
|
858
|
+
});
|
|
859
|
+
|
|
860
|
+
this.emit(WANT_TO_SLASH_EVENT, [
|
|
861
|
+
{
|
|
862
|
+
validator: proposer,
|
|
863
|
+
amount: this.config.slashDuplicateProposalPenalty,
|
|
864
|
+
offenseType: OffenseType.DUPLICATE_PROPOSAL,
|
|
865
|
+
epochOrSlot: BigInt(slot),
|
|
866
|
+
},
|
|
867
|
+
]);
|
|
868
|
+
|
|
869
|
+
this.emit(WANT_TO_CLEAR_SLASH_EVENT, [
|
|
870
|
+
{
|
|
871
|
+
offenseType: OffenseType.ATTESTED_TO_INVALID_CHECKPOINT_PROPOSAL,
|
|
872
|
+
epochOrSlot: BigInt(slot),
|
|
873
|
+
},
|
|
874
|
+
]);
|
|
875
|
+
}
|
|
876
|
+
|
|
877
|
+
/**
|
|
878
|
+
* Handle detection of a duplicate attestation (equivocation).
|
|
879
|
+
* Emits a slash event when an attester signs attestations for different proposals at the same slot.
|
|
880
|
+
*/
|
|
881
|
+
private handleDuplicateAttestation(info: DuplicateAttestationInfo): void {
|
|
882
|
+
const { slot, attester } = info;
|
|
883
|
+
|
|
884
|
+
this.log.info(`Detected duplicate attestation offense from ${attester.toString()} at slot ${slot}`, {
|
|
885
|
+
attester: attester.toString(),
|
|
886
|
+
slot,
|
|
887
|
+
amount: this.config.slashDuplicateAttestationPenalty,
|
|
888
|
+
offenseType: getOffenseTypeName(OffenseType.DUPLICATE_ATTESTATION),
|
|
889
|
+
});
|
|
890
|
+
|
|
891
|
+
this.emit(WANT_TO_SLASH_EVENT, [
|
|
892
|
+
{
|
|
893
|
+
validator: attester,
|
|
894
|
+
amount: this.config.slashDuplicateAttestationPenalty,
|
|
895
|
+
offenseType: OffenseType.DUPLICATE_ATTESTATION,
|
|
896
|
+
epochOrSlot: BigInt(slot),
|
|
897
|
+
},
|
|
898
|
+
]);
|
|
899
|
+
}
|
|
900
|
+
|
|
424
901
|
async createBlockProposal(
|
|
425
|
-
|
|
426
|
-
|
|
902
|
+
blockHeader: BlockHeader,
|
|
903
|
+
checkpointNumber: CheckpointNumber,
|
|
904
|
+
indexWithinCheckpoint: IndexWithinCheckpoint,
|
|
905
|
+
inHash: Fr,
|
|
427
906
|
archive: Fr,
|
|
428
907
|
txs: Tx[],
|
|
429
908
|
proposerAddress: EthAddress | undefined,
|
|
430
|
-
options: BlockProposalOptions,
|
|
909
|
+
options: BlockProposalOptions = {},
|
|
431
910
|
): Promise<BlockProposal> {
|
|
432
|
-
//
|
|
433
|
-
|
|
434
|
-
|
|
435
|
-
|
|
436
|
-
|
|
437
|
-
|
|
438
|
-
|
|
439
|
-
|
|
440
|
-
|
|
441
|
-
|
|
442
|
-
|
|
443
|
-
|
|
911
|
+
// Validate that we're not creating a proposal for an older or equal position
|
|
912
|
+
if (this.lastProposedBlock) {
|
|
913
|
+
const lastSlot = this.lastProposedBlock.slotNumber;
|
|
914
|
+
const lastIndex = this.lastProposedBlock.indexWithinCheckpoint;
|
|
915
|
+
const newSlot = blockHeader.globalVariables.slotNumber;
|
|
916
|
+
|
|
917
|
+
if (newSlot < lastSlot || (newSlot === lastSlot && indexWithinCheckpoint <= lastIndex)) {
|
|
918
|
+
throw new Error(
|
|
919
|
+
`Cannot create block proposal for slot ${newSlot} index ${indexWithinCheckpoint}: ` +
|
|
920
|
+
`already proposed block for slot ${lastSlot} index ${lastIndex}`,
|
|
921
|
+
);
|
|
922
|
+
}
|
|
923
|
+
}
|
|
924
|
+
|
|
925
|
+
this.log.info(
|
|
926
|
+
`Assembling block proposal for block ${blockHeader.globalVariables.blockNumber} slot ${blockHeader.globalVariables.slotNumber}`,
|
|
927
|
+
);
|
|
928
|
+
const newProposal = await this.validationService.createBlockProposal(
|
|
929
|
+
blockHeader,
|
|
930
|
+
checkpointNumber,
|
|
931
|
+
indexWithinCheckpoint,
|
|
932
|
+
inHash,
|
|
933
|
+
archive,
|
|
934
|
+
txs,
|
|
935
|
+
proposerAddress,
|
|
936
|
+
{
|
|
937
|
+
...options,
|
|
938
|
+
broadcastInvalidBlockProposal:
|
|
939
|
+
options.broadcastInvalidBlockProposal || this.config.broadcastInvalidBlockProposal,
|
|
940
|
+
},
|
|
941
|
+
);
|
|
942
|
+
this.lastProposedBlock = newProposal;
|
|
444
943
|
return newProposal;
|
|
445
944
|
}
|
|
446
945
|
|
|
447
|
-
|
|
448
|
-
|
|
449
|
-
header: CheckpointHeader,
|
|
946
|
+
async createCheckpointProposal(
|
|
947
|
+
checkpointHeader: CheckpointHeader,
|
|
450
948
|
archive: Fr,
|
|
451
|
-
|
|
949
|
+
checkpointNumber: CheckpointNumber,
|
|
950
|
+
feeAssetPriceModifier: bigint,
|
|
951
|
+
lastBlockProposal: BlockProposal | undefined,
|
|
452
952
|
proposerAddress: EthAddress | undefined,
|
|
453
|
-
options:
|
|
454
|
-
): Promise<
|
|
455
|
-
|
|
456
|
-
|
|
953
|
+
options: CheckpointProposalOptions = {},
|
|
954
|
+
): Promise<CheckpointProposal> {
|
|
955
|
+
// Validate that we're not creating a proposal for an older or equal slot
|
|
956
|
+
if (this.lastProposedCheckpoint) {
|
|
957
|
+
const lastSlot = this.lastProposedCheckpoint.slotNumber;
|
|
958
|
+
const newSlot = checkpointHeader.slotNumber;
|
|
959
|
+
|
|
960
|
+
if (newSlot <= lastSlot) {
|
|
961
|
+
throw new Error(
|
|
962
|
+
`Cannot create checkpoint proposal for slot ${newSlot}: ` +
|
|
963
|
+
`already proposed checkpoint for slot ${lastSlot}`,
|
|
964
|
+
);
|
|
965
|
+
}
|
|
966
|
+
}
|
|
967
|
+
|
|
968
|
+
this.log.info(`Assembling checkpoint proposal for slot ${checkpointHeader.slotNumber}`);
|
|
969
|
+
const newProposal = await this.validationService.createCheckpointProposal(
|
|
970
|
+
checkpointHeader,
|
|
971
|
+
archive,
|
|
972
|
+
checkpointNumber,
|
|
973
|
+
feeAssetPriceModifier,
|
|
974
|
+
lastBlockProposal,
|
|
975
|
+
proposerAddress,
|
|
976
|
+
options,
|
|
977
|
+
);
|
|
978
|
+
this.lastProposedCheckpoint = newProposal;
|
|
979
|
+
// Self-record this slot's outcome on the re-execution tracker. Proposers don't run their
|
|
980
|
+
// own proposals through `handleCheckpointProposal`, so without this call the proposer's
|
|
981
|
+
// sentinel would see no outcome for slots it proposed and would mis-attribute itself as
|
|
982
|
+
// inactive. We pass the locally-computed `archive` (not `newProposal.archive`, which may
|
|
983
|
+
// be intentionally corrupted under test-only flags); from the proposer's local-view
|
|
984
|
+
// perspective the work it just completed is valid by definition.
|
|
985
|
+
this.proposalHandler.recordOwnCheckpointProposalAsValid(checkpointHeader.slotNumber, archive, checkpointNumber);
|
|
986
|
+
return newProposal;
|
|
457
987
|
}
|
|
458
988
|
|
|
459
989
|
async broadcastBlockProposal(proposal: BlockProposal): Promise<void> {
|
|
@@ -463,28 +993,47 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
463
993
|
async signAttestationsAndSigners(
|
|
464
994
|
attestationsAndSigners: CommitteeAttestationsAndSigners,
|
|
465
995
|
proposer: EthAddress,
|
|
996
|
+
slot: SlotNumber,
|
|
997
|
+
checkpointNumber: CheckpointNumber,
|
|
466
998
|
): Promise<Signature> {
|
|
467
|
-
return await this.validationService.signAttestationsAndSigners(
|
|
999
|
+
return await this.validationService.signAttestationsAndSigners(
|
|
1000
|
+
attestationsAndSigners,
|
|
1001
|
+
proposer,
|
|
1002
|
+
slot,
|
|
1003
|
+
checkpointNumber,
|
|
1004
|
+
);
|
|
468
1005
|
}
|
|
469
1006
|
|
|
470
|
-
async collectOwnAttestations(
|
|
471
|
-
|
|
1007
|
+
async collectOwnAttestations(
|
|
1008
|
+
proposal: CheckpointProposal,
|
|
1009
|
+
checkpointNumber: CheckpointNumber,
|
|
1010
|
+
): Promise<CheckpointAttestation[]> {
|
|
1011
|
+
const slot = proposal.slotNumber;
|
|
472
1012
|
const inCommittee = await this.epochCache.filterInCommittee(slot, this.getValidatorAddresses());
|
|
473
1013
|
this.log.debug(`Collecting ${inCommittee.length} self-attestations for slot ${slot}`, { inCommittee });
|
|
474
|
-
const attestations = await this.
|
|
1014
|
+
const attestations = await this.createCheckpointAttestationsFromProposal(proposal, inCommittee, checkpointNumber);
|
|
1015
|
+
|
|
1016
|
+
if (!attestations) {
|
|
1017
|
+
return [];
|
|
1018
|
+
}
|
|
475
1019
|
|
|
476
1020
|
// We broadcast our own attestations to our peers so, in case our block does not get mined on L1,
|
|
477
1021
|
// other nodes can see that our validators did attest to this block proposal, and do not slash us
|
|
478
1022
|
// due to inactivity for missed attestations.
|
|
479
|
-
void this.p2pClient.
|
|
1023
|
+
void this.p2pClient.broadcastCheckpointAttestations(attestations).catch(err => {
|
|
480
1024
|
this.log.error(`Failed to broadcast self-attestations for slot ${slot}`, err);
|
|
481
1025
|
});
|
|
482
1026
|
return attestations;
|
|
483
1027
|
}
|
|
484
1028
|
|
|
485
|
-
async collectAttestations(
|
|
486
|
-
|
|
487
|
-
|
|
1029
|
+
async collectAttestations(
|
|
1030
|
+
proposal: CheckpointProposal,
|
|
1031
|
+
required: number,
|
|
1032
|
+
deadline: Date,
|
|
1033
|
+
checkpointNumber: CheckpointNumber,
|
|
1034
|
+
): Promise<CheckpointAttestation[]> {
|
|
1035
|
+
// Wait and poll the p2pClient's attestation pool for this checkpoint until we have enough attestations
|
|
1036
|
+
const slot = proposal.slotNumber;
|
|
488
1037
|
this.log.debug(`Collecting ${required} attestations for slot ${slot} with deadline ${deadline.toISOString()}`);
|
|
489
1038
|
|
|
490
1039
|
if (+deadline < this.dateProvider.now()) {
|
|
@@ -494,33 +1043,23 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
494
1043
|
throw new AttestationTimeoutError(0, required, slot);
|
|
495
1044
|
}
|
|
496
1045
|
|
|
497
|
-
await this.collectOwnAttestations(proposal);
|
|
1046
|
+
await this.collectOwnAttestations(proposal, checkpointNumber);
|
|
498
1047
|
|
|
499
|
-
const
|
|
1048
|
+
const proposalPayloadHash = proposal.getPayloadHash();
|
|
500
1049
|
const myAddresses = this.getValidatorAddresses();
|
|
501
1050
|
|
|
502
|
-
let attestations:
|
|
1051
|
+
let attestations: CheckpointAttestation[] = [];
|
|
503
1052
|
while (true) {
|
|
504
|
-
//
|
|
505
|
-
//
|
|
506
|
-
|
|
507
|
-
|
|
508
|
-
if (!attestation.payload.equals(proposal.payload)) {
|
|
509
|
-
this.log.warn(
|
|
510
|
-
`Received attestation for slot ${slot} with mismatched payload from ${attestation.getSender()?.toString()}`,
|
|
511
|
-
{ attestationPayload: attestation.payload, proposalPayload: proposal.payload },
|
|
512
|
-
);
|
|
513
|
-
return false;
|
|
514
|
-
}
|
|
515
|
-
return true;
|
|
516
|
-
},
|
|
517
|
-
);
|
|
1053
|
+
// The pool already filters by proposal payload hash; if any attestation slips through with a
|
|
1054
|
+
// mismatched payload hash, drop it defensively. Equivocations are emitted as separate slash
|
|
1055
|
+
// events from libp2p_service.
|
|
1056
|
+
const collectedAttestations = await this.p2pClient.getCheckpointAttestationsForSlot(slot, proposalPayloadHash);
|
|
518
1057
|
|
|
519
1058
|
// Log new attestations we collected
|
|
520
1059
|
const oldSenders = attestations.map(attestation => attestation.getSender());
|
|
521
1060
|
for (const collected of collectedAttestations) {
|
|
522
1061
|
const collectedSender = collected.getSender();
|
|
523
|
-
// Skip attestations with invalid signatures
|
|
1062
|
+
// Skip attestations with invalid signatures. Should not happen as we don't add invalid attestations to our pool.
|
|
524
1063
|
if (!collectedSender) {
|
|
525
1064
|
this.log.warn(`Skipping attestation with invalid signature for slot ${slot}`);
|
|
526
1065
|
continue;
|
|
@@ -549,15 +1088,6 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
549
1088
|
}
|
|
550
1089
|
}
|
|
551
1090
|
|
|
552
|
-
private async createBlockAttestationsFromProposal(
|
|
553
|
-
proposal: BlockProposal,
|
|
554
|
-
attestors: EthAddress[] = [],
|
|
555
|
-
): Promise<BlockAttestation[]> {
|
|
556
|
-
const attestations = await this.validationService.attestToProposal(proposal, attestors);
|
|
557
|
-
await this.p2pClient.addAttestations(attestations);
|
|
558
|
-
return attestations;
|
|
559
|
-
}
|
|
560
|
-
|
|
561
1091
|
private async handleAuthRequest(peer: PeerId, msg: Buffer): Promise<Buffer> {
|
|
562
1092
|
const authRequest = AuthRequest.fromBuffer(msg);
|
|
563
1093
|
const statusMessage = await this.p2pClient.handleAuthRequestFromPeer(authRequest, peer).catch(_ => undefined);
|
|
@@ -576,7 +1106,9 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
|
|
|
576
1106
|
}
|
|
577
1107
|
|
|
578
1108
|
const payloadToSign = authRequest.getPayloadToSign();
|
|
579
|
-
|
|
1109
|
+
// AUTH_REQUEST doesn't require HA protection - multiple signatures are safe
|
|
1110
|
+
const context: SigningContext = { dutyType: DutyType.AUTH_REQUEST };
|
|
1111
|
+
const signature = await this.keyStore.signMessageWithAddress(addressToUse, payloadToSign, context);
|
|
580
1112
|
const authResponse = new AuthResponse(statusMessage, signature);
|
|
581
1113
|
return authResponse.toBuffer();
|
|
582
1114
|
}
|