@aztec/simulator 0.0.1-commit.f504929 → 0.0.1-commit.f5a9928

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (110) hide show
  1. package/dest/client.d.ts +1 -3
  2. package/dest/client.d.ts.map +1 -1
  3. package/dest/client.js +0 -2
  4. package/dest/private/acvm_wasm.d.ts +1 -1
  5. package/dest/private/acvm_wasm.d.ts.map +1 -1
  6. package/dest/private/acvm_wasm.js +3 -1
  7. package/dest/private/circuit_recording/circuit_recorder.d.ts +36 -23
  8. package/dest/private/circuit_recording/circuit_recorder.d.ts.map +1 -1
  9. package/dest/private/circuit_recording/circuit_recorder.js +65 -69
  10. package/dest/private/circuit_recording/file_circuit_recorder.d.ts +7 -19
  11. package/dest/private/circuit_recording/file_circuit_recorder.d.ts.map +1 -1
  12. package/dest/private/circuit_recording/file_circuit_recorder.js +38 -42
  13. package/dest/private/circuit_recording/simulator_recorder_wrapper.d.ts +1 -1
  14. package/dest/private/circuit_recording/simulator_recorder_wrapper.d.ts.map +1 -1
  15. package/dest/private/circuit_recording/simulator_recorder_wrapper.js +11 -14
  16. package/dest/public/avm/avm_simulator.js +1 -1
  17. package/dest/public/avm/calldata.d.ts +1 -1
  18. package/dest/public/avm/calldata.d.ts.map +1 -1
  19. package/dest/public/avm/calldata.js +3 -2
  20. package/dest/public/avm/fixtures/base_avm_simulation_tester.d.ts +2 -1
  21. package/dest/public/avm/fixtures/base_avm_simulation_tester.d.ts.map +1 -1
  22. package/dest/public/avm/fixtures/base_avm_simulation_tester.js +18 -3
  23. package/dest/public/avm/fixtures/utils.d.ts +1 -1
  24. package/dest/public/avm/fixtures/utils.d.ts.map +1 -1
  25. package/dest/public/avm/fixtures/utils.js +4 -1
  26. package/dest/public/avm/opcodes/contract.d.ts +3 -2
  27. package/dest/public/avm/opcodes/contract.d.ts.map +1 -1
  28. package/dest/public/avm/opcodes/contract.js +5 -1
  29. package/dest/public/avm/opcodes/ec_add.d.ts +2 -4
  30. package/dest/public/avm/opcodes/ec_add.d.ts.map +1 -1
  31. package/dest/public/avm/opcodes/ec_add.js +13 -27
  32. package/dest/public/contracts_db_checkpoint.d.ts +2 -2
  33. package/dest/public/contracts_db_checkpoint.d.ts.map +1 -1
  34. package/dest/public/contracts_db_checkpoint.js +1 -1
  35. package/dest/public/fixtures/amm_test.js +2 -2
  36. package/dest/public/fixtures/bulk_test.d.ts +1 -1
  37. package/dest/public/fixtures/bulk_test.d.ts.map +1 -1
  38. package/dest/public/fixtures/bulk_test.js +33 -6
  39. package/dest/public/fixtures/custom_bytecode_tester.d.ts +1 -1
  40. package/dest/public/fixtures/custom_bytecode_tester.d.ts.map +1 -1
  41. package/dest/public/fixtures/custom_bytecode_tester.js +2 -2
  42. package/dest/public/fixtures/custom_bytecode_tests.d.ts +8 -1
  43. package/dest/public/fixtures/custom_bytecode_tests.d.ts.map +1 -1
  44. package/dest/public/fixtures/custom_bytecode_tests.js +91 -2
  45. package/dest/public/fixtures/opcode_spammer.d.ts +1 -1
  46. package/dest/public/fixtures/opcode_spammer.d.ts.map +1 -1
  47. package/dest/public/fixtures/opcode_spammer.js +2 -10
  48. package/dest/public/fixtures/public_tx_simulation_tester.d.ts +6 -5
  49. package/dest/public/fixtures/public_tx_simulation_tester.d.ts.map +1 -1
  50. package/dest/public/fixtures/public_tx_simulation_tester.js +11 -9
  51. package/dest/public/fixtures/token_test.js +3 -3
  52. package/dest/public/fixtures/utils.d.ts +2 -2
  53. package/dest/public/fixtures/utils.d.ts.map +1 -1
  54. package/dest/public/fixtures/utils.js +17 -16
  55. package/dest/public/hinting_db_sources.d.ts +4 -4
  56. package/dest/public/hinting_db_sources.d.ts.map +1 -1
  57. package/dest/public/hinting_db_sources.js +7 -6
  58. package/dest/public/public_db_sources.d.ts +6 -3
  59. package/dest/public/public_db_sources.d.ts.map +1 -1
  60. package/dest/public/public_db_sources.js +16 -10
  61. package/dest/public/public_processor/guarded_merkle_tree.d.ts +4 -4
  62. package/dest/public/public_processor/guarded_merkle_tree.d.ts.map +1 -1
  63. package/dest/public/public_processor/guarded_merkle_tree.js +4 -4
  64. package/dest/public/public_processor/public_processor.d.ts +5 -4
  65. package/dest/public/public_processor/public_processor.d.ts.map +1 -1
  66. package/dest/public/public_processor/public_processor.js +107 -63
  67. package/dest/public/public_processor/public_processor_metrics.d.ts +4 -1
  68. package/dest/public/public_processor/public_processor_metrics.d.ts.map +1 -1
  69. package/dest/public/public_processor/public_processor_metrics.js +8 -0
  70. package/dest/public/public_tx_simulator/contract_provider_for_cpp.d.ts +1 -1
  71. package/dest/public/public_tx_simulator/contract_provider_for_cpp.d.ts.map +1 -1
  72. package/dest/public/public_tx_simulator/contract_provider_for_cpp.js +5 -4
  73. package/dest/public/public_tx_simulator/public_tx_context.d.ts +7 -3
  74. package/dest/public/public_tx_simulator/public_tx_context.d.ts.map +1 -1
  75. package/dest/public/public_tx_simulator/public_tx_context.js +8 -10
  76. package/dest/public/public_tx_simulator/public_tx_simulator.d.ts +6 -2
  77. package/dest/public/public_tx_simulator/public_tx_simulator.d.ts.map +1 -1
  78. package/dest/public/public_tx_simulator/public_tx_simulator.js +12 -7
  79. package/dest/public/state_manager/state_manager.js +1 -1
  80. package/package.json +16 -16
  81. package/src/client.ts +0 -2
  82. package/src/private/acvm_wasm.ts +4 -1
  83. package/src/private/circuit_recording/circuit_recorder.ts +84 -78
  84. package/src/private/circuit_recording/file_circuit_recorder.ts +38 -48
  85. package/src/private/circuit_recording/simulator_recorder_wrapper.ts +9 -15
  86. package/src/public/avm/avm_simulator.ts +1 -1
  87. package/src/public/avm/calldata.ts +3 -2
  88. package/src/public/avm/fixtures/base_avm_simulation_tester.ts +23 -3
  89. package/src/public/avm/fixtures/utils.ts +4 -1
  90. package/src/public/avm/opcodes/contract.ts +5 -1
  91. package/src/public/avm/opcodes/ec_add.ts +12 -31
  92. package/src/public/avm/opcodes/external_calls.ts +1 -1
  93. package/src/public/contracts_db_checkpoint.ts +1 -1
  94. package/src/public/fixtures/amm_test.ts +2 -2
  95. package/src/public/fixtures/bulk_test.ts +31 -6
  96. package/src/public/fixtures/custom_bytecode_tester.ts +2 -2
  97. package/src/public/fixtures/custom_bytecode_tests.ts +209 -2
  98. package/src/public/fixtures/opcode_spammer.ts +4 -8
  99. package/src/public/fixtures/public_tx_simulation_tester.ts +21 -12
  100. package/src/public/fixtures/token_test.ts +3 -3
  101. package/src/public/fixtures/utils.ts +19 -20
  102. package/src/public/hinting_db_sources.ts +9 -6
  103. package/src/public/public_db_sources.ts +21 -14
  104. package/src/public/public_processor/guarded_merkle_tree.ts +5 -5
  105. package/src/public/public_processor/public_processor.ts +138 -77
  106. package/src/public/public_processor/public_processor_metrics.ts +12 -0
  107. package/src/public/public_tx_simulator/contract_provider_for_cpp.ts +5 -4
  108. package/src/public/public_tx_simulator/public_tx_context.ts +8 -10
  109. package/src/public/public_tx_simulator/public_tx_simulator.ts +11 -7
  110. package/src/public/state_manager/state_manager.ts +1 -1
@@ -3,11 +3,13 @@ import type { Logger } from '@aztec/foundation/log';
3
3
  import fs from 'fs/promises';
4
4
  import path from 'path';
5
5
 
6
- import type { ACVMWitness } from '../acvm/acvm_types.js';
7
6
  import { CircuitRecorder, type CircuitRecording } from './circuit_recorder.js';
8
7
 
8
+ /** Per-recording file state, keyed by recording so concurrent/nested executions don't share it. */
9
+ type RecordingFileState = { filePath: string; isFirstCall: boolean };
10
+
9
11
  export class FileCircuitRecorder extends CircuitRecorder {
10
- declare recording?: CircuitRecording & { filePath: string; isFirstCall: boolean };
12
+ readonly #fileState = new WeakMap<CircuitRecording, RecordingFileState>();
11
13
 
12
14
  constructor(
13
15
  private readonly recordDir: string,
@@ -16,16 +18,9 @@ export class FileCircuitRecorder extends CircuitRecorder {
16
18
  super(logger);
17
19
  }
18
20
 
19
- override async start(
20
- input: ACVMWitness,
21
- circuitBytecode: Buffer,
22
- circuitName: string,
23
- functionName: string = 'main',
24
- ) {
25
- await super.start(input, circuitBytecode, circuitName, functionName);
26
-
21
+ protected override async onStart(recording: CircuitRecording): Promise<void> {
27
22
  const recordingStringWithoutClosingBracket = JSON.stringify(
28
- { ...this.recording, isFirstCall: undefined, parent: undefined, oracleCalls: undefined, filePath: undefined },
23
+ { ...recording, parent: undefined, oracleCalls: undefined },
29
24
  null,
30
25
  2,
31
26
  ).slice(0, -2);
@@ -45,13 +40,13 @@ export class FileCircuitRecorder extends CircuitRecorder {
45
40
  }
46
41
  }
47
42
 
48
- this.recording!.isFirstCall = true;
49
- this.recording!.filePath = await FileCircuitRecorder.#computeFilePathAndStoreInitialRecording(
43
+ const filePath = await FileCircuitRecorder.#computeFilePathAndStoreInitialRecording(
50
44
  this.recordDir,
51
- this.recording!.circuitName,
52
- this.recording!.functionName,
45
+ recording.circuitName,
46
+ recording.functionName,
53
47
  recordingStringWithoutClosingBracket,
54
48
  );
49
+ this.#fileState.set(recording, { filePath, isFirstCall: true });
55
50
  }
56
51
 
57
52
  /**
@@ -95,53 +90,48 @@ export class FileCircuitRecorder extends CircuitRecorder {
95
90
  * @param inputs - Input arguments
96
91
  * @param outputs - Output results
97
92
  */
98
- override async recordCall(name: string, inputs: unknown[], outputs: unknown, time: number, stackDepth: number) {
99
- const entry = await super.recordCall(name, inputs, outputs, time, stackDepth);
100
- try {
101
- const prefix = this.recording!.isFirstCall ? ' ' : ' ,';
102
- this.recording!.isFirstCall = false;
103
- await fs.appendFile(this.recording!.filePath, prefix + JSON.stringify(entry) + '\n');
104
- } catch (err) {
105
- this.logger.error('Failed to log circuit call', { error: err });
93
+ override async recordCall(name: string, inputs: unknown[], outputs: unknown, time: number) {
94
+ const entry = await super.recordCall(name, inputs, outputs, time);
95
+ const recording = this.currentRecording();
96
+ const state = recording && this.#fileState.get(recording);
97
+ if (state) {
98
+ try {
99
+ const prefix = state.isFirstCall ? ' ' : ' ,';
100
+ state.isFirstCall = false;
101
+ await fs.appendFile(state.filePath, prefix + JSON.stringify(entry) + '\n');
102
+ } catch (err) {
103
+ this.logger.error('Failed to log circuit call', { error: err });
104
+ }
106
105
  }
107
106
  return entry;
108
107
  }
109
108
 
110
- /**
111
- * Finalizes the recording file by adding closing brackets. Without calling this method, the recording file is
112
- * incomplete and it fails to parse.
113
- */
114
- override async finish(): Promise<CircuitRecording> {
115
- // Finish sets the recording to undefined if we are at the topmost circuit,
116
- // so we save the current file path before that
117
- const filePath = this.recording!.filePath;
118
- const result = await super.finish();
109
+ /** Closes the recording file with the trailing brackets so the JSON parses. */
110
+ protected override async onFinish(recording: CircuitRecording): Promise<void> {
111
+ const state = this.#fileState.get(recording);
112
+ if (!state) {
113
+ return;
114
+ }
119
115
  try {
120
- await fs.appendFile(filePath, ' ]\n}\n');
116
+ await fs.appendFile(state.filePath, ' ]\n}\n');
121
117
  } catch (err) {
122
118
  this.logger.error('Failed to finalize recording file', { error: err });
123
119
  }
124
- return result!;
125
120
  }
126
121
 
127
- /**
128
- * Finalizes the recording file by adding the error and closing brackets. Without calling this method or `finish`,
129
- * the recording file is incomplete and it fails to parse.
130
- * @param error - The error that occurred during circuit execution
131
- */
132
- override async finishWithError(error: unknown): Promise<CircuitRecording> {
133
- // Finish sets the recording to undefined if we are at the topmost circuit,
134
- // so we save the current file path before that
135
- const filePath = this.recording!.filePath;
136
- const result = await super.finishWithError(error);
122
+ /** Closes the recording file with the execution error and trailing brackets so the JSON parses. */
123
+ protected override async onError(recording: CircuitRecording, error: unknown): Promise<void> {
124
+ const state = this.#fileState.get(recording);
125
+ if (!state) {
126
+ return;
127
+ }
137
128
  try {
138
- await fs.appendFile(filePath, ' ],\n');
139
- await fs.appendFile(filePath, ` "error": ${JSON.stringify(error)}\n`);
140
- await fs.appendFile(filePath, '}\n');
129
+ await fs.appendFile(state.filePath, ' ],\n');
130
+ await fs.appendFile(state.filePath, ` "error": ${JSON.stringify(error)}\n`);
131
+ await fs.appendFile(state.filePath, '}\n');
141
132
  } catch (err) {
142
133
  this.logger.error('Failed to finalize recording file with error', { error: err });
143
134
  }
144
- return result!;
145
135
  }
146
136
  }
147
137
 
@@ -58,24 +58,18 @@ export class SimulatorRecorderWrapper implements CircuitSimulator {
58
58
  functionName: string,
59
59
  callback: C,
60
60
  ): Promise<T> {
61
- // Start recording circuit execution
62
- await this.recorder.start(input, bytecode, contractName, functionName);
63
-
64
- // If callback was provided, we wrap it in a circuit recorder callback wrapper
61
+ // If a callback was provided, we wrap it so that its oracle calls are recorded. The wrapped callback reads the
62
+ // active recording lazily, so it picks up the recording opened by record() below.
65
63
  const wrappedCallback = this.recorder.wrapCallback(callback);
66
- let result: T;
67
- try {
68
- result = await simulateFn(wrappedCallback as C);
69
- } catch (error) {
70
- // If an error occurs, we finalize the recording file with the error
71
- await this.recorder.finishWithError(error);
72
- throw error;
73
- }
74
64
 
75
- // Witness generation is complete so we finish the circuit recorder
76
- const recording = await this.recorder.finish();
65
+ // record() opens a recording for this circuit, runs the simulation within it, and finalizes it. A simulation
66
+ // failure is re-thrown unchanged, so recorder bookkeeping never masks the underlying error.
67
+ const { result, recording } = await this.recorder.record(
68
+ { input, bytecode, circuitName: contractName, functionName },
69
+ () => simulateFn(wrappedCallback as C),
70
+ );
77
71
 
78
- (result as ACIRExecutionResult).oracles = recording.oracleCalls?.reduce(
72
+ (result as ACIRExecutionResult).oracles = recording.oracleCalls.reduce(
79
73
  (acc, { time, name }) => {
80
74
  if (!acc[name]) {
81
75
  acc[name] = { times: [] };
@@ -63,7 +63,7 @@ export class AvmSimulator implements AvmSimulatorInterface {
63
63
  public static async build(context: AvmContext): Promise<AvmSimulator> {
64
64
  const simulator = new AvmSimulator(context);
65
65
  const fnName = await context.persistableState.getPublicFunctionDebugName(context.environment);
66
- simulator.log = createLogger(`simulator:avm(f:${fnName})`);
66
+ simulator.log = createLogger(`simulator:avm(f:${fnName.slice(0, 128)})`);
67
67
 
68
68
  return simulator;
69
69
  }
@@ -33,13 +33,14 @@ export class LazyReaderMemory implements LazyReader {
33
33
  }
34
34
 
35
35
  public slice(start: number, end: number): Fr[] {
36
- const clampedEnd = Math.min(end, this.size);
36
+ const clampedEnd = Math.min(end, this.size, TaggedMemory.MAX_MEMORY_SIZE - this.offset);
37
37
  const length = Math.max(0, clampedEnd - start);
38
38
  return this.memory.getSlice(this.offset + start, length).map(word => word.toFr());
39
39
  }
40
40
 
41
41
  public readAll(): Fr[] {
42
- return this.memory.getSlice(this.offset, this.size).map(word => word.toFr());
42
+ const size = Math.min(this.size, TaggedMemory.MAX_MEMORY_SIZE - this.offset);
43
+ return this.memory.getSlice(this.offset, size).map(word => word.toFr());
43
44
  }
44
45
 
45
46
  public length(): number {
@@ -2,9 +2,10 @@ import { CONTRACT_INSTANCE_REGISTRY_CONTRACT_ADDRESS } from '@aztec/constants';
2
2
  import { Fr } from '@aztec/foundation/curves/bn254';
3
3
  import { createLogger } from '@aztec/foundation/log';
4
4
  import { ProtocolContractAddress } from '@aztec/protocol-contracts';
5
- import { getCanonicalAuthRegistry } from '@aztec/protocol-contracts/auth-registry';
5
+ import { getCanonicalClassRegistry } from '@aztec/protocol-contracts/class-registry';
6
6
  import { computeFeePayerBalanceStorageSlot, getCanonicalFeeJuice } from '@aztec/protocol-contracts/fee-juice';
7
7
  import { getCanonicalInstanceRegistry } from '@aztec/protocol-contracts/instance-registry';
8
+ import { getStandardAuthRegistry } from '@aztec/standard-contracts/auth-registry';
8
9
  import type { ContractArtifact } from '@aztec/stdlib/abi';
9
10
  import { PublicDataWrite } from '@aztec/stdlib/avm';
10
11
  import { AztecAddress } from '@aztec/stdlib/aztec-address';
@@ -91,7 +92,7 @@ export abstract class BaseAvmSimulationTester {
91
92
  }
92
93
 
93
94
  async registerAuthContract(): Promise<ContractInstanceWithAddress> {
94
- const authRegistry = await getCanonicalAuthRegistry();
95
+ const authRegistry = await getStandardAuthRegistry();
95
96
  const authRegistryContractClassPublic = {
96
97
  ...authRegistry.contractClass,
97
98
  privateFunctions: [],
@@ -102,9 +103,28 @@ export abstract class BaseAvmSimulationTester {
102
103
  authRegistryContractClassPublic,
103
104
  authRegistry.instance,
104
105
  );
106
+ // AuthRegistry is a standard contract (not a protocol contract), so the AVM enforces a
107
+ // deployment-nullifier check on every instance retrieval. Insert the nullifier here so
108
+ // calls to AuthRegistry don't EXCEPTIONAL_HALT during simulation.
109
+ await this.insertContractAddressNullifier(authRegistry.instance.address);
105
110
  return authRegistry.instance;
106
111
  }
107
112
 
113
+ async registerClassRegistryContract(): Promise<ContractInstanceWithAddress> {
114
+ const classRegistry = await getCanonicalClassRegistry();
115
+ const classRegistryContractClassPublic = {
116
+ ...classRegistry.contractClass,
117
+ privateFunctions: [],
118
+ utilityFunctions: [],
119
+ };
120
+ await this.contractDataSource.addNewContract(
121
+ classRegistry.artifact,
122
+ classRegistryContractClassPublic,
123
+ classRegistry.instance,
124
+ );
125
+ return classRegistry.instance;
126
+ }
127
+
108
128
  async registerInstanceRegistryContract(): Promise<ContractInstanceWithAddress> {
109
129
  const instanceRegistry = await getCanonicalInstanceRegistry();
110
130
  const instanceRegistryContractClassPublic = {
@@ -129,7 +149,7 @@ export abstract class BaseAvmSimulationTester {
129
149
 
130
150
  private async insertContractAddressNullifier(contractAddress: AztecAddress) {
131
151
  const contractAddressNullifier = await siloNullifier(
132
- AztecAddress.fromNumber(CONTRACT_INSTANCE_REGISTRY_CONTRACT_ADDRESS),
152
+ AztecAddress.fromNumberUnsafe(CONTRACT_INSTANCE_REGISTRY_CONTRACT_ADDRESS),
133
153
  contractAddress.toField(),
134
154
  );
135
155
  await this.merkleTrees.sequentialInsert(MerkleTreeId.NULLIFIER_TREE, [contractAddressNullifier.toBuffer()]);
@@ -128,22 +128,25 @@ export async function createContractClassAndInstance(
128
128
  const constructorAbi = getContractFunctionAbi('constructor', contractArtifact);
129
129
  const { publicKeys } = await deriveKeys(new Fr(seed));
130
130
  const initializationHash = await computeInitializationHash(constructorAbi, constructorArgs);
131
+ const immutablesHash = new Fr(seed + 1);
131
132
  const contractInstance =
132
133
  originalContractClassId === undefined
133
134
  ? await makeContractInstanceFromClassId(contractClass.id, seed, {
134
135
  deployer,
135
136
  initializationHash,
137
+ immutablesHash,
136
138
  publicKeys,
137
139
  })
138
140
  : await makeContractInstanceFromClassId(originalContractClassId, seed, {
139
141
  deployer,
140
142
  initializationHash,
141
143
  currentClassId: contractClass.id,
144
+ immutablesHash,
142
145
  publicKeys,
143
146
  });
144
147
 
145
148
  const contractAddressNullifier = await siloNullifier(
146
- AztecAddress.fromNumber(CONTRACT_INSTANCE_REGISTRY_CONTRACT_ADDRESS),
149
+ AztecAddress.fromNumberUnsafe(CONTRACT_INSTANCE_REGISTRY_CONTRACT_ADDRESS),
147
150
  contractInstance.address.toField(),
148
151
  );
149
152
 
@@ -9,6 +9,7 @@ export enum ContractInstanceMember {
9
9
  DEPLOYER,
10
10
  CLASS_ID,
11
11
  INIT_HASH,
12
+ IMMUTABLES_HASH,
12
13
  }
13
14
 
14
15
  export class GetContractInstance extends Instruction {
@@ -41,7 +42,7 @@ export class GetContractInstance extends Instruction {
41
42
  );
42
43
 
43
44
  if (!(this.memberEnum in ContractInstanceMember)) {
44
- throw new InstructionExecutionError(`Invalid GETCONSTRACTINSTANCE member enum ${this.memberEnum}`);
45
+ throw new InstructionExecutionError(`Invalid GETCONTRACTINSTANCE member enum ${this.memberEnum}`);
45
46
  }
46
47
 
47
48
  const operands = [this.addressOffset, this.dstOffset];
@@ -64,6 +65,9 @@ export class GetContractInstance extends Instruction {
64
65
  case ContractInstanceMember.INIT_HASH:
65
66
  memberValue = new Field(instance.initializationHash);
66
67
  break;
68
+ case ContractInstanceMember.IMMUTABLES_HASH:
69
+ memberValue = new Field(instance.immutablesHash);
70
+ break;
67
71
  }
68
72
  }
69
73
 
@@ -2,7 +2,7 @@ import { Grumpkin } from '@aztec/foundation/crypto/grumpkin';
2
2
  import { Point } from '@aztec/foundation/curves/grumpkin';
3
3
 
4
4
  import type { AvmContext } from '../avm_context.js';
5
- import { Field, TypeTag, Uint1 } from '../avm_memory_types.js';
5
+ import { Field, TypeTag } from '../avm_memory_types.js';
6
6
  import { EcAddPointNotOnCurveError } from '../errors.js';
7
7
  import { Opcode, OperandType } from '../serialization/instruction_serialization.js';
8
8
  import { Addressing } from './addressing_mode.js';
@@ -18,10 +18,8 @@ export class EcAdd extends Instruction {
18
18
  OperandType.UINT16, // indirect
19
19
  OperandType.UINT16, // p1X
20
20
  OperandType.UINT16, // p1Y
21
- OperandType.UINT16, // p1IsInfinite
22
21
  OperandType.UINT16, // p2X
23
22
  OperandType.UINT16, // p2Y
24
- OperandType.UINT16, // p2IsInfinite
25
23
  OperandType.UINT16, // dst
26
24
  ];
27
25
 
@@ -29,10 +27,8 @@ export class EcAdd extends Instruction {
29
27
  private addressingMode: number,
30
28
  private p1XOffset: number,
31
29
  private p1YOffset: number,
32
- private p1IsInfiniteOffset: number,
33
30
  private p2XOffset: number,
34
31
  private p2YOffset: number,
35
- private p2IsInfiniteOffset: number,
36
32
  private dstOffset: number,
37
33
  ) {
38
34
  super();
@@ -46,51 +42,38 @@ export class EcAdd extends Instruction {
46
42
  this.baseGasCost(addressing.indirectOperandsCount(), addressing.relativeOperandsCount()),
47
43
  );
48
44
 
49
- const operands = [
50
- this.p1XOffset,
51
- this.p1YOffset,
52
- this.p1IsInfiniteOffset,
53
- this.p2XOffset,
54
- this.p2YOffset,
55
- this.p2IsInfiniteOffset,
56
- this.dstOffset,
57
- ];
58
- const [p1XOffset, p1YOffset, p1IsInfiniteOffset, p2XOffset, p2YOffset, p2IsInfiniteOffset, dstOffset] =
59
- addressing.resolve(operands, memory);
45
+ const operands = [this.p1XOffset, this.p1YOffset, this.p2XOffset, this.p2YOffset, this.dstOffset];
46
+ const [p1XOffset, p1YOffset, p2XOffset, p2YOffset, dstOffset] = addressing.resolve(operands, memory);
60
47
 
61
48
  memory.checkTags(TypeTag.FIELD, p1XOffset, p1YOffset, p2XOffset, p2YOffset);
62
- memory.checkTags(TypeTag.UINT1, p1IsInfiniteOffset, p2IsInfiniteOffset);
63
49
 
64
50
  const p1X = memory.get(p1XOffset);
65
51
  const p1Y = memory.get(p1YOffset);
66
- const p1IsInfinite = memory.get(p1IsInfiniteOffset).toNumber() === 1;
67
- const p1 = new Point(p1X.toFr(), p1Y.toFr(), p1IsInfinite);
68
- if (!p1.isOnGrumpkin()) {
52
+ const p1 = new Point(p1X.toFr(), p1Y.toFr());
53
+ if (!p1.isOnCurve()) {
69
54
  throw new EcAddPointNotOnCurveError(/*pointIndex=*/ 1, p1);
70
55
  }
71
56
 
72
57
  const p2X = memory.get(p2XOffset);
73
58
  const p2Y = memory.get(p2YOffset);
74
- // unused. Point doesn't store this information
75
- const p2IsInfinite = memory.get(p2IsInfiniteOffset).toNumber() === 1;
76
- const p2 = new Point(p2X.toFr(), p2Y.toFr(), p2IsInfinite);
77
- if (!p2.isOnGrumpkin()) {
59
+ const p2 = new Point(p2X.toFr(), p2Y.toFr());
60
+ if (!p2.isOnCurve()) {
78
61
  throw new EcAddPointNotOnCurveError(/*pointIndex=*/ 2, p2);
79
62
  }
80
63
 
81
64
  let dest;
82
- if (p1IsInfinite && p2IsInfinite) {
83
- dest = Point.ZERO;
84
- } else if (p1IsInfinite) {
65
+ if (p1.isInfinite && p2.isInfinite) {
66
+ dest = Point.INFINITY;
67
+ } else if (p1.isInfinite) {
85
68
  dest = p2;
86
- } else if (p2IsInfinite) {
69
+ } else if (p2.isInfinite) {
87
70
  dest = p1;
88
71
  } else {
89
72
  // TS<>BB ecc add communication is broken for points that add up to infinity.
90
73
  // However, here we know that both points are on the curve, and that none is infinity
91
74
  // so we can check for the case where you add p + (-p) = infinity.
92
75
  if (p1.x.equals(p2.x) && !p1.y.equals(p2.y)) {
93
- dest = Point.ZERO;
76
+ dest = Point.INFINITY;
94
77
  } else {
95
78
  dest = await Grumpkin.add(p1, p2);
96
79
  }
@@ -99,7 +82,5 @@ export class EcAdd extends Instruction {
99
82
  // Important to use setSlice() and not set() in the two following statements as
100
83
  // this checks that the offsets lie within memory range.
101
84
  memory.setSlice(dstOffset, [new Field(dest.x), new Field(dest.y)]);
102
- // Check representation of infinity for grumpkin
103
- memory.setSlice(dstOffset + 2, [new Uint1(dest.equals(Point.ZERO) ? 1 : 0)]);
104
85
  }
105
86
  }
@@ -14,8 +14,8 @@ abstract class ExternalCall extends Instruction {
14
14
  OperandType.UINT16, // L2 gas offset
15
15
  OperandType.UINT16, // DA gas offset
16
16
  OperandType.UINT16, // Address offset
17
- OperandType.UINT16, // Args offset
18
17
  OperandType.UINT16, // Args size offset
18
+ OperandType.UINT16, // Args offset
19
19
  ];
20
20
 
21
21
  constructor(
@@ -31,7 +31,7 @@ export class ContractsDbCheckpoint {
31
31
  return this.bytecodeCommitments.get(classId.toString());
32
32
  }
33
33
 
34
- public deepCopy(): ContractsDbCheckpoint {
34
+ public fork(): ContractsDbCheckpoint {
35
35
  const copy = new ContractsDbCheckpoint();
36
36
  this.instances.forEach((value, key) => copy.instances.set(key, value));
37
37
  this.classes.forEach((value, key) => copy.classes.set(key, value));
@@ -25,8 +25,8 @@ export async function ammTest(
25
25
  ) {
26
26
  const timer = new Timer();
27
27
 
28
- const admin = AztecAddress.fromNumber(42);
29
- const sender = AztecAddress.fromNumber(111);
28
+ const admin = AztecAddress.fromNumberUnsafe(42);
29
+ const sender = AztecAddress.fromNumberUnsafe(111);
30
30
 
31
31
  logger.debug(`Deploying tokens`);
32
32
  const token0 = await setUpToken(tester, tokenArtifact, admin, expectToBeTrue, /*seed=*/ 0);
@@ -13,7 +13,7 @@ export async function bulkTest(
13
13
  ) {
14
14
  const timer = new Timer();
15
15
 
16
- const deployer = AztecAddress.fromNumber(42);
16
+ const deployer = AztecAddress.fromNumberUnsafe(42);
17
17
  const avmTestContract = await tester.registerAndDeployContract(
18
18
  /*constructorArgs=*/ [],
19
19
  deployer,
@@ -25,14 +25,26 @@ export async function bulkTest(
25
25
  // Register multiple different protocol contracts (to ensure we don't dedup bytecode hashing events):
26
26
  await tester.registerAuthContract();
27
27
  await tester.registerInstanceRegistryContract();
28
+ await tester.registerClassRegistryContract();
28
29
 
29
30
  // Get a deployed contract instance to pass to the contract
30
31
  // for it to use as "expected" values when testing contract instance retrieval.
31
32
  const expectContractInstance = avmTestContract;
32
33
  const argsField = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(x => new Fr(x));
33
- const argsU8 = [1, 2, 3, 4, 5, 6, 7, 8].map(x => new Fr(x));
34
- argsU8.push(new Fr(2n ** 128n + 9n)); // Trigger truncation from large (> 128 bits) value (canonical decomposition event)
35
- argsU8.push(new Fr(2n ** 125n + 10n)); // Trigger truncation from small (< 128 bits) value (no canonical decomposition event)
34
+ const argsU8 = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(x => new Fr(x));
35
+ // Pinned grumpkin-Poseidon2 Schnorr signature (mirrors the C++ `pinned_test_vector_large`
36
+ // and noir-lang/schnorr v0.4.0's `pinned_vector_large`). Passing these in as calldata
37
+ // (rather than baking them into Noir as constants) keeps MSM + Poseidon2 from being folded
38
+ // by the Noir compiler.
39
+ const schnorrInputs = [
40
+ Fr.fromHexString('0x065812e335a97c2108ea8cf4ccfe2f9dd6b117a0714f5e18461575be93f61da6'), // pubkey.x
41
+ Fr.fromHexString('0x1a915003e8ec534f9a15d926a7ded478e178468ccc4f28e236e67450a55ac622'), // pubkey.y
42
+ Fr.fromHexString('0xf3bc3b7147acb9c621fd9f72dbf15ffa'), // sig_s.lo
43
+ Fr.fromHexString('0x08599f379f0301dfefdbd0272554454d'), // sig_s.hi
44
+ Fr.fromHexString('0x97065383ebbbd76620398792bd259bc2'), // sig_e.lo
45
+ Fr.fromHexString('0x2ceaee87f45b7a417f0ffb05451a8c92'), // sig_e.hi
46
+ Fr.fromHexString('0x0123456789abcdef0fedcba9876543210123456789abcdef0fedcba987654321'), // message
47
+ ];
36
48
  const args = [
37
49
  argsField,
38
50
  argsU8,
@@ -40,6 +52,8 @@ export async function bulkTest(
40
52
  /*expectedDeployer=*/ expectContractInstance.deployer,
41
53
  /*expectedClassId=*/ expectContractInstance.currentContractClassId,
42
54
  /*expectedInitializationHash=*/ expectContractInstance.initializationHash,
55
+ /*expectedImmutablesHash=*/ expectContractInstance.immutablesHash,
56
+ /*schnorrInputs=*/ schnorrInputs,
43
57
  /*skip_strictly_limited_side_effects=*/ false,
44
58
  ];
45
59
 
@@ -62,7 +76,7 @@ export async function bulkTest(
62
76
  {
63
77
  address: avmTestContract.address,
64
78
  fnName: 'assert_calldata_copy',
65
- args: [argsField.slice(3), /* with_selector: */ true],
79
+ args: [argsField.slice(0, 3), /* with_selector: */ true],
66
80
  },
67
81
  {
68
82
  address: avmTestContract.address,
@@ -100,7 +114,7 @@ export async function megaBulkTest(
100
114
  ) {
101
115
  const timer = new Timer();
102
116
 
103
- const deployer = AztecAddress.fromNumber(42);
117
+ const deployer = AztecAddress.fromNumberUnsafe(42);
104
118
  const avmTestContract = await tester.registerAndDeployContract(
105
119
  /*constructorArgs=*/ [],
106
120
  deployer,
@@ -123,6 +137,15 @@ export async function megaBulkTest(
123
137
  //const argsField7 = [15, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(x => new Fr(x));
124
138
  //const argsField8 = [17, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(x => new Fr(x));
125
139
  const argsU8 = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10].map(x => new Fr(x));
140
+ const schnorrInputs = [
141
+ Fr.fromHexString('0x065812e335a97c2108ea8cf4ccfe2f9dd6b117a0714f5e18461575be93f61da6'), // pubkey.x
142
+ Fr.fromHexString('0x1a915003e8ec534f9a15d926a7ded478e178468ccc4f28e236e67450a55ac622'), // pubkey.y
143
+ Fr.fromHexString('0xf3bc3b7147acb9c621fd9f72dbf15ffa'), // sig_s.lo
144
+ Fr.fromHexString('0x08599f379f0301dfefdbd0272554454d'), // sig_s.hi
145
+ Fr.fromHexString('0x97065383ebbbd76620398792bd259bc2'), // sig_e.lo
146
+ Fr.fromHexString('0x2ceaee87f45b7a417f0ffb05451a8c92'), // sig_e.hi
147
+ Fr.fromHexString('0x0123456789abcdef0fedcba9876543210123456789abcdef0fedcba987654321'), // message
148
+ ];
126
149
  const genArgs = (argsField: Fr[]) => [
127
150
  argsField,
128
151
  argsU8,
@@ -130,6 +153,8 @@ export async function megaBulkTest(
130
153
  /*expectedDeployer=*/ expectContractInstance.deployer.toField(),
131
154
  /*expectedClassId=*/ expectContractInstance.currentContractClassId.toField(),
132
155
  /*expectedInitializationHash=*/ expectContractInstance.initializationHash.toField(),
156
+ /*expectedImmutablesHash=*/ expectContractInstance.immutablesHash.toField(),
157
+ /*schnorrInputs=*/ schnorrInputs,
133
158
  // Must skip strictly limited side effects (logs, messages) so we can spam the bulk test several times.
134
159
  /*skip_strictly_limited_side_effects=*/ true,
135
160
  ];
@@ -17,7 +17,7 @@ export async function deployCustomBytecode(
17
17
  bytecode: Buffer,
18
18
  tester: PublicTxSimulationTester,
19
19
  contractName: string = 'CustomBytecodeContract',
20
- deployer: AztecAddress = AztecAddress.fromNumber(42),
20
+ deployer: AztecAddress = AztecAddress.fromNumberUnsafe(42),
21
21
  ): Promise<ContractInstanceWithAddress> {
22
22
  const contractArtifact = emptyContractArtifact();
23
23
  contractArtifact.name = contractName;
@@ -75,7 +75,7 @@ export async function deployAndExecuteCustomBytecode(
75
75
  tester: PublicTxSimulationTester,
76
76
  txLabel: string = 'CustomBytecodeTest',
77
77
  contractName: string = 'CustomBytecodeContract',
78
- deployer: AztecAddress = AztecAddress.fromNumber(42),
78
+ deployer: AztecAddress = AztecAddress.fromNumberUnsafe(42),
79
79
  calldata: any[] = [],
80
80
  ): Promise<PublicTxResult> {
81
81
  const testContract = await deployCustomBytecode(bytecode, tester, contractName, deployer);