@aztec/sequencer-client 0.0.1-commit.fffb133c → 0.0.1-dev

package/dest/sequencer/checkpoint_proposal_job.js

@@ -436,20 +436,21 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
     return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
 }
 var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
-import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
-import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
-import { BlockNumber } from '@aztec/foundation/branded-types';
+import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
 import { randomInt } from '@aztec/foundation/crypto/random';
-import { Signature } from '@aztec/foundation/eth-signature';
+import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
 import { filter } from '@aztec/foundation/iterator';
+import { createLogger } from '@aztec/foundation/log';
 import { sleep, sleepUntil } from '@aztec/foundation/sleep';
 import { Timer } from '@aztec/foundation/timer';
-import { unfreeze } from '@aztec/foundation/types';
+import { isErrorClass, unfreeze } from '@aztec/foundation/types';
 import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
+import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
 import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
 import { Gas } from '@aztec/stdlib/gas';
+import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
 import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
-import { orderAttestations } from '@aztec/stdlib/p2p';
+import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
 import { AttestationTimeoutError } from '@aztec/stdlib/validators';
 import { Attributes, trackSpan } from '@aztec/telemetry-client';
 import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validator-ha-signer/errors';
@@ -495,7 +496,6 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
     metrics;
     eventEmitter;
     setStateFn;
-    log;
     tracer;
     static{
         ({ e: [_initProto] } = _apply_decs_2203_r(this, [
@@ -541,8 +541,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             ]
         ], []));
     }
+    log;
     constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
-    proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, log, tracer){
+    proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
         this.epoch = epoch;
         this.slot = slot;
         this.checkpointNumber = checkpointNumber;
@@ -568,9 +569,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         this.metrics = metrics;
         this.eventEmitter = eventEmitter;
         this.setStateFn = setStateFn;
-        this.log = log;
         this.tracer = tracer;
         _initProto(this);
+        this.log = createLogger('sequencer:checkpoint-proposal', {
+            ...bindings,
+            instanceId: `slot-${slot}`
+        });
     }
     /**
    * Executes the checkpoint proposal job.
@@ -585,7 +589,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
         await Promise.all(votesPromises);
         if (checkpoint) {
-            this.metrics.recordBlockProposalSuccess();
+            this.metrics.recordCheckpointProposalSuccess();
         }
         // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
         if (this.config.fishermanMode) {
@@ -635,13 +639,14 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
                 const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
                 // Collect the out hashes of all the checkpoints before this one in the same epoch
-                const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter((c)=>c.number < this.checkpointNumber);
-                const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
+                const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.epoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
+                // Get the fee asset price modifier from the oracle
+                const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
                 const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
                     closeDelayMs: 12_000
-                }), false);
+                }), true);
                 // Create checkpoint builder for the entire slot
-                const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(this.checkpointNumber, checkpointGlobalVariables, l1ToL2Messages, previousCheckpointOutHashes, fork);
+                const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(this.checkpointNumber, checkpointGlobalVariables, feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, this.log.getBindings());
                 // Options for the validator client when creating block and checkpoint proposals
                 const blockProposalOptions = {
                     publishFullTxs: !!this.config.publishTxsWithProposals,
@@ -653,6 +658,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 };
                 let blocksInCheckpoint = [];
                 let blockPendingBroadcast = undefined;
+                const checkpointBuildTimer = new Timer();
                 try {
                     // Main loop: build blocks for the checkpoint
                     const result = await this.buildBlocksForCheckpoint(checkpointBuilder, checkpointGlobalVariables.timestamp, inHash, blockProposalOptions);
@@ -662,19 +668,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                     // These errors are expected in HA mode, so we yield and let another HA node handle the slot
                     // The only distinction between the 2 errors is SlashingProtectionError throws when the payload is different,
                     // which is normal for block building (may have picked different txs)
-                    if (err instanceof DutyAlreadySignedError) {
-                        this.log.info(`Checkpoint proposal for slot ${this.slot} already signed by another HA node, yielding`, {
-                            slot: this.slot,
-                            signedByNode: err.signedByNode
-                        });
-                        return undefined;
-                    }
-                    if (err instanceof SlashingProtectionError) {
-                        this.log.info(`Checkpoint proposal for slot ${this.slot} blocked by slashing protection, yielding`, {
-                            slot: this.slot,
-                            existingMessageHash: err.existingMessageHash,
-                            attemptedMessageHash: err.attemptedMessageHash
-                        });
+                    if (this.handleHASigningError(err, 'Block proposal')) {
                         return undefined;
                     }
                     throw err;
@@ -688,10 +682,37 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                     });
                     return undefined;
                 }
+                const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
+                if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
+                    this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
+                        slot: this.slot,
+                        blocksBuilt: blocksInCheckpoint.length,
+                        minBlocksForCheckpoint
+                    });
+                    return undefined;
+                }
                 // Assemble and broadcast the checkpoint proposal, including the last block that was not
                 // broadcasted yet, and wait to collect the committee attestations.
                 this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
                 const checkpoint = await checkpointBuilder.completeCheckpoint();
+                // Final validation: per-block limits are only checked if the operator set them explicitly.
+                // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
+                try {
+                    validateCheckpoint(checkpoint, {
+                        rollupManaLimit: this.l1Constants.rollupManaLimit,
+                        maxL2BlockGas: this.config.maxL2BlockGas,
+                        maxDABlockGas: this.config.maxDABlockGas,
+                        maxTxsPerBlock: this.config.maxTxsPerBlock,
+                        maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
+                    });
+                } catch (err) {
+                    this.log.error(`Built an invalid checkpoint at slot ${this.slot} (skipping proposal)`, err, {
+                        checkpoint: checkpoint.header.toInspect()
+                    });
+                    return undefined;
+                }
+                // Record checkpoint-level build metrics
+                this.metrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
                 // Do not collect attestations nor publish to L1 in fisherman mode
                 if (this.config.fishermanMode) {
                     this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
@@ -702,14 +723,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                     this.metrics.recordCheckpointSuccess();
                     return checkpoint;
                 }
-                // Include the block pending broadcast in the checkpoint proposal if any
-                const lastBlock = blockPendingBroadcast && {
-                    blockHeader: blockPendingBroadcast.block.header,
-                    indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
-                    txs: blockPendingBroadcast.txs
-                };
                 // Create the checkpoint proposal and broadcast it
-                const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, lastBlock, this.proposer, checkpointProposalOptions);
+                const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
                 const blockProposedAt = this.dateProvider.now();
                 await this.p2pClient.broadcastCheckpointProposal(proposal);
                 this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
@@ -723,20 +738,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                     attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
                 } catch (err) {
                     // We shouldn't really get here since we yield to another HA node
-                    // as soon as we see these errors when creating block proposals.
-                    if (err instanceof DutyAlreadySignedError) {
-                        this.log.info(`Attestations signature for slot ${this.slot} already signed by another HA node, yielding`, {
-                            slot: this.slot,
-                            signedByNode: err.signedByNode
-                        });
-                        return undefined;
-                    }
-                    if (err instanceof SlashingProtectionError) {
-                        this.log.info(`Attestations signature for slot ${this.slot} blocked by slashing protection, yielding`, {
-                            slot: this.slot,
-                            existingMessageHash: err.existingMessageHash,
-                            attemptedMessageHash: err.attemptedMessageHash
-                        });
+                    // as soon as we see these errors when creating block or checkpoint proposals.
+                    if (this.handleHASigningError(err, 'Attestations signature')) {
                         return undefined;
                     }
                     throw err;
@@ -746,6 +749,14 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 const aztecSlotDuration = this.l1Constants.slotDuration;
                 const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
                 const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
+                // If we have been configured to potentially skip publishing checkpoint then roll the dice here
+                if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
+                    const result = Math.max(0, randomInt(100));
+                    if (result < this.config.skipPublishingCheckpointsPercent) {
+                        this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${result}`);
+                        return checkpoint;
+                    }
+                }
                 await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
                     txTimeoutAt,
                     forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
@@ -755,7 +766,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 env.error = e;
                 env.hasError = true;
             } finally{
-                _ts_dispose_resources(env);
+                const result = _ts_dispose_resources(env);
+                if (result) await result;
             }
         } catch (err) {
             if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
@@ -772,19 +784,18 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         const blocksInCheckpoint = [];
         const txHashesAlreadyIncluded = new Set();
         const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
-        // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
-        let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
+        const slot = this.slot;
         // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
         let blockPendingBroadcast = undefined;
         while(true){
             const blocksBuilt = blocksInCheckpoint.length;
-            const indexWithinCheckpoint = blocksBuilt;
+            const indexWithinCheckpoint = IndexWithinCheckpoint(blocksBuilt);
             const blockNumber = BlockNumber(initialBlockNumber + blocksBuilt);
             const secondsIntoSlot = this.getSecondsIntoSlot();
             const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
             if (!timingInfo.canStart) {
                 this.log.debug(`Not enough time left in slot to start another block`, {
-                    slot: this.slot,
+                    slot,
                     blocksBuilt,
                     secondsIntoSlot
                 });
@@ -799,62 +810,52 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
                 blockNumber,
                 indexWithinCheckpoint,
-                txHashesAlreadyIncluded,
-                remainingBlobFields
+                txHashesAlreadyIncluded
             });
-            if (!buildResult && timingInfo.isLastBlock) {
-                break;
-            } else if (!buildResult && timingInfo.deadline !== undefined) {
-                // But if there is still time for more blocks, wait until the next subslot and try again
+            // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
+            if ('failure' in buildResult) {
+                // If this was the last subslot, or we're running with a single block per slot, we're done
+                if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
+                    break;
+                }
+                // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
                 await this.waitUntilNextSubslot(timingInfo.deadline);
                 continue;
-            } else if (!buildResult) {
-                break;
-            } else if ('error' in buildResult) {
-                // If there was an error building the block, just exit the loop and give up the rest of the slot
+            }
+            // If there was an error building the block, we just exit the loop and give up the rest of the slot.
+            // We don't want to risk building more blocks if something went wrong.
+            if ('error' in buildResult) {
                 if (!(buildResult.error instanceof SequencerInterruptedError)) {
-                    this.log.warn(`Halting block building for slot ${this.slot}`, {
-                        slot: this.slot,
+                    this.log.warn(`Halting block building for slot ${slot}`, {
+                        slot,
                         blocksBuilt,
                         error: buildResult.error
                     });
                 }
                 break;
             }
-            const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
+            const { block, usedTxs } = buildResult;
             blocksInCheckpoint.push(block);
-            // Update remaining blob fields for the next block
-            remainingBlobFields = newRemainingBlobFields;
-            // Sync the proposed block to the archiver to make it available
-            // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
-            // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
-            // Fire and forget - don't block the critical path, but log errors
-            this.syncProposedBlockToArchiver(block).catch((err)=>{
-                this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
-                    blockNumber: block.number,
-                    err
-                });
-            });
             usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
-            // If this is the last block, exit the loop now so we start collecting attestations
+            // Sign the block proposal. This will throw if HA signing fails.
+            const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
+            // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
+            // so we avoid polluting our archive with a block that would fail.
+            // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
+            // If this throws, we abort the entire checkpoint.
+            await this.syncProposedBlockToArchiver(block);
+            // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
             if (timingInfo.isLastBlock) {
-                this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
-                    slot: this.slot,
+                this.log.verbose(`Completed final block ${blockNumber} for slot ${slot}`, {
+                    slot,
                     blockNumber,
                     blocksBuilt
                 });
-                blockPendingBroadcast = {
-                    block,
-                    txs: usedTxs
-                };
+                blockPendingBroadcast = proposal;
                 break;
             }
-            // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
-            // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
-            if (!this.config.fishermanMode) {
-                const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
-                await this.p2pClient.broadcastProposal(proposal);
-            }
+            // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
+            proposal && await this.p2pClient.broadcastProposal(proposal);
             // Wait until the next block's start time
             await this.waitUntilNextSubslot(timingInfo.deadline);
         }
@@ -867,6 +868,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             blockPendingBroadcast
         };
     }
+    /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
+        if (this.config.fishermanMode) {
+            this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
+            return Promise.resolve(undefined);
+        }
+        return this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
+    }
     /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
         this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
         this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
@@ -875,15 +883,14 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         await this.waitUntilTimeInSlot(nextSubslotStart);
     }
     /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
-        const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded, remainingBlobFields } = opts;
+        const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
         this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
             ...checkpointBuilder.getConstantData(),
             ...opts
         });
         try {
             // Wait until we have enough txs to build the block
-            const minTxs = this.config.minTxsPerBlock;
-            const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
+            const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
             if (!canStartBuilding) {
                 this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
                     blockNumber,
@@ -896,62 +903,66 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                     slot: this.slot
                 });
                 this.metrics.recordBlockProposalFailed('insufficient_txs');
-                return undefined;
+                return {
+                    failure: 'insufficient-txs'
+                };
             }
             // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
             // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
-            const pendingTxs = filter(this.p2pClient.iteratePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
+            const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
             this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
                 slot: this.slot,
                 blockNumber,
                 indexWithinCheckpoint
             });
             this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
-            // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
-            const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
-            const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
+            // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
+            // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
+            // minValidTxs is passed into the builder so it can reject the block *before* updating state.
+            const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
             const blockBuilderOptions = {
                 maxTransactions: this.config.maxTxsPerBlock,
-                maxBlockSize: this.config.maxBlockSizeInBytes,
-                maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
-                maxBlobFields: maxBlobFieldsForTxs,
-                deadline: buildDeadline
+                maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
+                deadline: buildDeadline,
+                isBuildingProposal: true,
+                minValidTxs,
+                maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
+                perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
             };
-            // Actually build the block by executing txs
-            const workTimer = new Timer();
-            const { publicGas, block, publicProcessorDuration, numTxs, blockBuildingTimer, usedTxs, failedTxs, usedTxBlobFields } = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
-            const blockBuildDuration = workTimer.ms();
+            // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
+            // if the number of successfully processed txs is below minValidTxs, ensuring state is not
+            // updated for blocks that will be discarded.
+            const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
             // If any txs failed during execution, drop them from the mempool so we don't pick them up again
-            await this.dropFailedTxsFromP2P(failedTxs);
-            // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
-            // too long, then we may not get to minTxsPerBlock after executing public functions.
-            const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
-            if (!forceCreate && numTxs < minValidTxs) {
-                this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed (got ${numTxs} but required ${minValidTxs})`, {
+            await this.dropFailedTxsFromP2P(buildResult.failedTxs);
+            if (buildResult.status === 'insufficient-valid-txs') {
+                this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
                     slot: this.slot,
                     blockNumber,
-                    numTxs,
-                    indexWithinCheckpoint
+                    numTxs: buildResult.processedCount,
+                    indexWithinCheckpoint,
+                    minValidTxs
                 });
-                this.eventEmitter.emit('block-tx-count-check-failed', {
-                    minTxs: minValidTxs,
-                    availableTxs: numTxs,
+                this.eventEmitter.emit('block-build-failed', {
+                    reason: `Insufficient valid txs`,
                     slot: this.slot
                 });
                 this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
-                return undefined;
+                return {
+                    failure: 'insufficient-valid-txs'
+                };
             }
             // Block creation succeeded, emit stats and metrics
+            const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
             const blockStats = {
                 eventName: 'l2-block-built',
                 duration: blockBuildDuration,
                 publicProcessDuration: publicProcessorDuration,
-                rollupCircuitsDuration: blockBuildingTimer.ms(),
                 ...block.getStats()
             };
             const blockHash = await block.hash();
             const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
-            const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
+            const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
             this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
                 blockHash,
                 txHashes,
@@ -962,11 +973,10 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 blockNumber: block.number,
                 slot: this.slot
             });
-            this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
+            this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe());
             return {
                 block,
-                usedTxs,
-                remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields
+                usedTxs
             };
         } catch (err) {
             this.eventEmitter.emit('block-build-failed', {
@@ -984,9 +994,31 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             };
         }
     }
+    /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
+        try {
+            const workTimer = new Timer();
+            const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
+            const blockBuildDuration = workTimer.ms();
+            return {
+                ...result,
+                blockBuildDuration,
+                status: 'success'
+            };
+        } catch (err) {
+            if (isErrorClass(err, InsufficientValidTxsError)) {
+                return {
+                    failedTxs: err.failedTxs,
+                    processedCount: err.processedCount,
+                    status: 'insufficient-valid-txs'
+                };
+            }
+            throw err;
+        }
+    }
     /** Waits until minTxs are available on the pool for building a block. */ async waitForMinTxs(opts) {
-        const minTxs = this.config.minTxsPerBlock;
         const { indexWithinCheckpoint, blockNumber, buildDeadline, forceCreate } = opts;
+        // We only allow a block with 0 txs in the first block of the checkpoint
+        const minTxs = indexWithinCheckpoint > 0 && this.config.minTxsPerBlock === 0 ? 1 : this.config.minTxsPerBlock;
         // Deadline is undefined if we are not enforcing the timetable, meaning we'll exit immediately when out of time
         const startBuildingDeadline = buildDeadline ? new Date(buildDeadline.getTime() - this.timetable.minExecutionTime * 1000) : undefined;
         let availableTxs = await this.p2pClient.getPendingTxCount();
@@ -996,7 +1028,8 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
                 return {
                     canStartBuilding: false,
-                    availableTxs: availableTxs
+                    availableTxs,
+                    minTxs
                 };
             }
             // Wait a bit before checking again
@@ -1006,12 +1039,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 slot: this.slot,
                 indexWithinCheckpoint
             });
-            await sleep(TXS_POLLING_MS);
+            await this.waitForTxsPollingInterval();
             availableTxs = await this.p2pClient.getPendingTxCount();
         }
         return {
             canStartBuilding: true,
-            availableTxs
+            availableTxs,
+            minTxs
         };
     }
     /**
@@ -1041,17 +1075,23 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
         }
         const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT) : this.l1Constants.slotDuration;
-        const attestationDeadline = new Date(this.dateProvider.now() + attestationTimeAllowed * 1000);
+        const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
         this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
         const collectAttestationsTimer = new Timer();
         let collectedAttestationsCount = 0;
         try {
             const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
             collectedAttestationsCount = attestations.length;
+            // Trim attestations to minimum required to save L1 calldata gas
+            const localAddresses = this.validatorClient.getValidatorAddresses();
+            const trimmed = trimAttestations(attestations, numberOfRequiredAttestations, this.attestorAddress, localAddresses);
+            if (trimmed.length < attestations.length) {
+                this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
+            }
             // Rollup contract requires that the signatures are provided in the order of the committee
-            const sorted = orderAttestations(attestations, committee);
+            const sorted = orderAttestations(trimmed, committee);
             // Manipulate the attestations if we've been configured to do so
-            if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
+            if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.shuffleAttestationOrdering) {
                 return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
             }
             return new CommitteeAttestationsAndSigners(sorted);
@@ -1068,7 +1108,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         // Compute the proposer index in the committee, since we dont want to tweak it.
         // Otherwise, the L1 rollup contract will reject the block outright.
         const proposerIndex = Number(this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)));
-        if (this.config.injectFakeAttestation) {
+        if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation) {
             // Find non-empty attestations that are not from the proposer
             const nonProposerIndices = [];
             for(let i = 0; i < attestations.length; i++){
@@ -1078,8 +1118,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
             }
             if (nonProposerIndices.length > 0) {
                 const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
-                this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
-                unfreeze(attestations[targetIndex]).signature = Signature.random();
+                if (this.config.injectHighSValueAttestation) {
+                    this.log.warn(`Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
+                    unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
+                } else if (this.config.injectUnrecoverableSignatureAttestation) {
+                    this.log.warn(`Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
+                    unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
+                } else {
+                    this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
+                    unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
+                }
             }
             return new CommitteeAttestationsAndSigners(attestations);
         }
@@ -1108,14 +1156,18 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
         const failedTxData = failedTxs.map((fail)=>fail.tx);
         const failedTxHashes = failedTxData.map((tx)=>tx.getTxHash());
         this.log.verbose(`Dropping failed txs ${failedTxHashes.join(', ')}`);
-        await this.p2pClient.deleteTxs(failedTxHashes);
+        await this.p2pClient.handleFailedExecution(failedTxHashes);
     }
     /**
    * Adds the proposed block to the archiver so it's available via P2P.
    * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
    * would never receive its own block without this explicit sync.
+   *
+   * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
+   * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
+   * whenever the real proposer's block arrives from L1.
    */ async syncProposedBlockToArchiver(block) {
-        if (this.config.skipPushProposedBlocksToArchiver !== false) {
+        if (this.config.skipPushProposedBlocksToArchiver !== false || this.config.fishermanMode) {
             this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
                 blockNumber: block.number,
                 slot: block.header.globalVariables.slotNumber
@@ -1143,15 +1195,38 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
                 slot: this.slot,
                 feeAnalysisId: feeAnalysis?.id
             });
-            this.metrics.recordBlockProposalFailed('block_build_failed');
+            this.metrics.recordCheckpointProposalFailed('block_build_failed');
         }
         this.publisher.clearPendingRequests();
     }
+    /**
+   * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
+   */ handleHASigningError(err, errorContext) {
+        if (err instanceof DutyAlreadySignedError) {
+            this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
+                slot: this.slot,
+                signedByNode: err.signedByNode
+            });
+            return true;
+        }
+        if (err instanceof SlashingProtectionError) {
+            this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
+                slot: this.slot,
+                existingMessageHash: err.existingMessageHash,
+                attemptedMessageHash: err.attemptedMessageHash
+            });
+            return true;
+        }
+        return false;
+    }
     /** Waits until a specific time within the current slot */ async waitUntilTimeInSlot(targetSecondsIntoSlot) {
         const slotStartTimestamp = this.getSlotStartBuildTimestamp();
         const targetTimestamp = slotStartTimestamp + targetSecondsIntoSlot;
         await sleepUntil(new Date(targetTimestamp * 1000), this.dateProvider.nowAsDate());
     }
+    /** Waits the polling interval for transactions. Extracted for test overriding. */ async waitForTxsPollingInterval() {
+        await sleep(TXS_POLLING_MS);
+    }
     getSlotStartBuildTimestamp() {
         return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
     }