@aztec/sequencer-client 0.0.1-commit.0c875d939 → 0.0.1-commit.0dc957cde

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (99) hide show
  1. package/dest/client/sequencer-client.d.ts +17 -7
  2. package/dest/client/sequencer-client.d.ts.map +1 -1
  3. package/dest/client/sequencer-client.js +63 -30
  4. package/dest/config.d.ts +26 -6
  5. package/dest/config.d.ts.map +1 -1
  6. package/dest/config.js +49 -29
  7. package/dest/global_variable_builder/fee_predictor.d.ts +37 -0
  8. package/dest/global_variable_builder/fee_predictor.d.ts.map +1 -0
  9. package/dest/global_variable_builder/fee_predictor.js +128 -0
  10. package/dest/global_variable_builder/fee_provider.d.ts +21 -0
  11. package/dest/global_variable_builder/fee_provider.d.ts.map +1 -0
  12. package/dest/global_variable_builder/fee_provider.js +58 -0
  13. package/dest/global_variable_builder/global_builder.d.ts +15 -16
  14. package/dest/global_variable_builder/global_builder.d.ts.map +1 -1
  15. package/dest/global_variable_builder/global_builder.js +16 -50
  16. package/dest/global_variable_builder/index.d.ts +4 -2
  17. package/dest/global_variable_builder/index.d.ts.map +1 -1
  18. package/dest/global_variable_builder/index.js +2 -0
  19. package/dest/publisher/config.d.ts +47 -17
  20. package/dest/publisher/config.d.ts.map +1 -1
  21. package/dest/publisher/config.js +121 -42
  22. package/dest/publisher/index.d.ts +2 -1
  23. package/dest/publisher/index.d.ts.map +1 -1
  24. package/dest/publisher/l1_tx_failed_store/factory.d.ts +11 -0
  25. package/dest/publisher/l1_tx_failed_store/factory.d.ts.map +1 -0
  26. package/dest/publisher/l1_tx_failed_store/factory.js +22 -0
  27. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts +58 -0
  28. package/dest/publisher/l1_tx_failed_store/failed_tx_store.d.ts.map +1 -0
  29. package/dest/publisher/l1_tx_failed_store/failed_tx_store.js +1 -0
  30. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts +15 -0
  31. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.d.ts.map +1 -0
  32. package/dest/publisher/l1_tx_failed_store/file_store_failed_tx_store.js +34 -0
  33. package/dest/publisher/l1_tx_failed_store/index.d.ts +4 -0
  34. package/dest/publisher/l1_tx_failed_store/index.d.ts.map +1 -0
  35. package/dest/publisher/l1_tx_failed_store/index.js +2 -0
  36. package/dest/publisher/sequencer-publisher-factory.d.ts +11 -5
  37. package/dest/publisher/sequencer-publisher-factory.d.ts.map +1 -1
  38. package/dest/publisher/sequencer-publisher-factory.js +27 -3
  39. package/dest/publisher/sequencer-publisher.d.ts +68 -48
  40. package/dest/publisher/sequencer-publisher.d.ts.map +1 -1
  41. package/dest/publisher/sequencer-publisher.js +419 -135
  42. package/dest/sequencer/chain_state_overrides.d.ts +25 -0
  43. package/dest/sequencer/chain_state_overrides.d.ts.map +1 -0
  44. package/dest/sequencer/chain_state_overrides.js +39 -0
  45. package/dest/sequencer/checkpoint_proposal_job.d.ts +40 -10
  46. package/dest/sequencer/checkpoint_proposal_job.d.ts.map +1 -1
  47. package/dest/sequencer/checkpoint_proposal_job.js +522 -212
  48. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts +34 -0
  49. package/dest/sequencer/checkpoint_proposal_job_metrics.d.ts.map +1 -0
  50. package/dest/sequencer/checkpoint_proposal_job_metrics.js +72 -0
  51. package/dest/sequencer/checkpoint_voter.d.ts +1 -2
  52. package/dest/sequencer/checkpoint_voter.d.ts.map +1 -1
  53. package/dest/sequencer/checkpoint_voter.js +2 -5
  54. package/dest/sequencer/events.d.ts +7 -1
  55. package/dest/sequencer/events.d.ts.map +1 -1
  56. package/dest/sequencer/metrics.d.ts +18 -8
  57. package/dest/sequencer/metrics.d.ts.map +1 -1
  58. package/dest/sequencer/metrics.js +85 -21
  59. package/dest/sequencer/sequencer.d.ts +43 -17
  60. package/dest/sequencer/sequencer.d.ts.map +1 -1
  61. package/dest/sequencer/sequencer.js +158 -97
  62. package/dest/sequencer/timetable.d.ts +17 -3
  63. package/dest/sequencer/timetable.d.ts.map +1 -1
  64. package/dest/sequencer/timetable.js +51 -43
  65. package/dest/sequencer/types.d.ts +2 -2
  66. package/dest/sequencer/types.d.ts.map +1 -1
  67. package/dest/test/index.d.ts +3 -5
  68. package/dest/test/index.d.ts.map +1 -1
  69. package/dest/test/mock_checkpoint_builder.d.ts +7 -9
  70. package/dest/test/mock_checkpoint_builder.d.ts.map +1 -1
  71. package/dest/test/mock_checkpoint_builder.js +39 -30
  72. package/package.json +27 -28
  73. package/src/client/sequencer-client.ts +81 -30
  74. package/src/config.ts +61 -35
  75. package/src/global_variable_builder/README.md +44 -0
  76. package/src/global_variable_builder/fee_predictor.ts +172 -0
  77. package/src/global_variable_builder/fee_provider.ts +75 -0
  78. package/src/global_variable_builder/global_builder.ts +27 -63
  79. package/src/global_variable_builder/index.ts +3 -1
  80. package/src/publisher/config.ts +157 -45
  81. package/src/publisher/index.ts +3 -0
  82. package/src/publisher/l1_tx_failed_store/factory.ts +32 -0
  83. package/src/publisher/l1_tx_failed_store/failed_tx_store.ts +57 -0
  84. package/src/publisher/l1_tx_failed_store/file_store_failed_tx_store.ts +46 -0
  85. package/src/publisher/l1_tx_failed_store/index.ts +3 -0
  86. package/src/publisher/sequencer-publisher-factory.ts +38 -9
  87. package/src/publisher/sequencer-publisher.ts +472 -193
  88. package/src/sequencer/README.md +83 -13
  89. package/src/sequencer/chain_state_overrides.ts +87 -0
  90. package/src/sequencer/checkpoint_proposal_job.ts +665 -234
  91. package/src/sequencer/checkpoint_proposal_job_metrics.ts +128 -0
  92. package/src/sequencer/checkpoint_voter.ts +1 -12
  93. package/src/sequencer/events.ts +6 -1
  94. package/src/sequencer/metrics.ts +100 -26
  95. package/src/sequencer/sequencer.ts +227 -109
  96. package/src/sequencer/timetable.ts +64 -52
  97. package/src/sequencer/types.ts +1 -1
  98. package/src/test/index.ts +2 -4
  99. package/src/test/mock_checkpoint_builder.ts +51 -48
@@ -436,25 +436,26 @@ function _apply_decs_2203_r(targetClass, memberDecs, classDecs, parentClass) {
436
436
  return (_apply_decs_2203_r = applyDecs2203RFactory())(targetClass, memberDecs, classDecs, parentClass);
437
437
  }
438
438
  var _dec, _dec1, _dec2, _dec3, _dec4, _dec5, _dec6, _dec7, _initProto;
439
- import { NUM_CHECKPOINT_END_MARKER_FIELDS, getNumBlockEndBlobFields } from '@aztec/blob-lib/encoding';
440
- import { BLOBS_PER_CHECKPOINT, FIELDS_PER_BLOB } from '@aztec/constants';
441
- import { BlockNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
439
+ import { BlockNumber, CheckpointNumber, IndexWithinCheckpoint } from '@aztec/foundation/branded-types';
442
440
  import { randomInt } from '@aztec/foundation/crypto/random';
443
- import { Signature } from '@aztec/foundation/eth-signature';
441
+ import { flipSignature, generateRecoverableSignature, generateUnrecoverableSignature } from '@aztec/foundation/crypto/secp256k1-signer';
444
442
  import { filter } from '@aztec/foundation/iterator';
445
443
  import { createLogger } from '@aztec/foundation/log';
444
+ import { retryUntil } from '@aztec/foundation/retry';
446
445
  import { sleep, sleepUntil } from '@aztec/foundation/sleep';
447
446
  import { Timer } from '@aztec/foundation/timer';
448
447
  import { isErrorClass, unfreeze } from '@aztec/foundation/types';
449
448
  import { CommitteeAttestationsAndSigners, MaliciousCommitteeAttestationsAndSigners } from '@aztec/stdlib/block';
450
- import { getSlotStartBuildTimestamp } from '@aztec/stdlib/epoch-helpers';
449
+ import { validateCheckpoint } from '@aztec/stdlib/checkpoint';
450
+ import { computeQuorum, getSlotStartBuildTimestamp, getTimestampForSlot } from '@aztec/stdlib/epoch-helpers';
451
451
  import { Gas } from '@aztec/stdlib/gas';
452
- import { NoValidTxsError } from '@aztec/stdlib/interfaces/server';
452
+ import { InsufficientValidTxsError } from '@aztec/stdlib/interfaces/server';
453
453
  import { computeInHashFromL1ToL2Messages } from '@aztec/stdlib/messaging';
454
- import { orderAttestations } from '@aztec/stdlib/p2p';
454
+ import { orderAttestations, trimAttestations } from '@aztec/stdlib/p2p';
455
455
  import { AttestationTimeoutError } from '@aztec/stdlib/validators';
456
456
  import { Attributes, trackSpan } from '@aztec/telemetry-client';
457
457
  import { DutyAlreadySignedError, SlashingProtectionError } from '@aztec/validator-ha-signer/errors';
458
+ import { buildPipelinedParentSimulationOverridesPlan, buildSubmissionSimulationOverridesPlan } from './chain_state_overrides.js';
458
459
  import { CheckpointVoter } from './checkpoint_voter.js';
459
460
  import { SequencerInterruptedError } from './errors.js';
460
461
  import { SequencerState } from './utils.js';
@@ -463,7 +464,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
463
464
  return {
464
465
  // nullish operator needed for tests
465
466
  [Attributes.COINBASE]: this.validatorClient.getCoinbaseForAttestor(this.attestorAddress)?.toString(),
466
- [Attributes.SLOT_NUMBER]: this.slot
467
+ [Attributes.SLOT_NUMBER]: this.targetSlot
467
468
  };
468
469
  }), _dec2 = trackSpan('CheckpointProposalJob.buildBlocksForCheckpoint'), _dec3 = trackSpan('CheckpointProposalJob.waitUntilNextSubslot'), _dec4 = trackSpan('CheckpointProposalJob.buildSingleBlock'), _dec5 = trackSpan('CheckpointProposalJob.waitForMinTxs'), _dec6 = trackSpan('CheckpointProposalJob.waitForAttestations'), _dec7 = trackSpan('CheckpointProposalJob.waitUntilTimeInSlot');
469
470
  /**
@@ -472,8 +473,9 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
472
473
  * as well as enqueueing votes for slashing and governance proposals. This class is created from
473
474
  * the Sequencer once the check for being the proposer for the slot has succeeded.
474
475
  */ export class CheckpointProposalJob {
475
- epoch;
476
- slot;
476
+ slotNow;
477
+ targetSlot;
478
+ targetEpoch;
477
479
  checkpointNumber;
478
480
  syncedToBlockNumber;
479
481
  proposer;
@@ -495,9 +497,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
495
497
  epochCache;
496
498
  dateProvider;
497
499
  metrics;
500
+ checkpointMetrics;
498
501
  eventEmitter;
499
502
  setStateFn;
500
503
  tracer;
504
+ proposedCheckpointData;
501
505
  static{
502
506
  ({ e: [_initProto] } = _apply_decs_2203_r(this, [
503
507
  [
@@ -543,10 +547,13 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
543
547
  ], []));
544
548
  }
545
549
  log;
546
- constructor(epoch, slot, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
547
- proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, eventEmitter, setStateFn, tracer, bindings){
548
- this.epoch = epoch;
549
- this.slot = slot;
550
+ /** Tracks the fire-and-forget L1 submission promise so it can be awaited during shutdown. */ pendingL1Submission;
551
+ /** Pipelined parent chain state used while building and later submitting this checkpoint. */ pipelinedParentSimulationOverridesPlan;
552
+ constructor(slotNow, targetSlot, targetEpoch, checkpointNumber, syncedToBlockNumber, // TODO(palla/mbps): Can we remove the proposer in favor of attestorAddress? Need to check fisherman-node flows.
553
+ proposer, publisher, attestorAddress, invalidateCheckpoint, validatorClient, globalsBuilder, p2pClient, worldState, l1ToL2MessageSource, l2BlockSource, checkpointsBuilder, blockSink, l1Constants, config, timetable, slasherClient, epochCache, dateProvider, metrics, checkpointMetrics, eventEmitter, setStateFn, tracer, bindings, proposedCheckpointData){
554
+ this.slotNow = slotNow;
555
+ this.targetSlot = targetSlot;
556
+ this.targetEpoch = targetEpoch;
550
557
  this.checkpointNumber = checkpointNumber;
551
558
  this.syncedToBlockNumber = syncedToBlockNumber;
552
559
  this.proposer = proposer;
@@ -568,52 +575,261 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
568
575
  this.epochCache = epochCache;
569
576
  this.dateProvider = dateProvider;
570
577
  this.metrics = metrics;
578
+ this.checkpointMetrics = checkpointMetrics;
571
579
  this.eventEmitter = eventEmitter;
572
580
  this.setStateFn = setStateFn;
573
581
  this.tracer = tracer;
582
+ this.proposedCheckpointData = proposedCheckpointData;
574
583
  _initProto(this);
575
584
  this.log = createLogger('sequencer:checkpoint-proposal', {
576
585
  ...bindings,
577
- instanceId: `slot-${slot}`
586
+ instanceId: `slot-${this.slotNow}`
578
587
  });
579
588
  }
589
+ /** Awaits the pending L1 submission if one is in progress. Call during shutdown. */ async awaitPendingSubmission() {
590
+ this.log.info('Awaiting pending L1 payload submission');
591
+ await this.pendingL1Submission;
592
+ }
580
593
  /**
581
594
  * Executes the checkpoint proposal job.
582
- * Returns the published checkpoint if successful, undefined otherwise.
595
+ * Builds blocks, assembles checkpoint, and broadcasts the proposal (blocking).
596
+ * Attestation collection, signing, and L1 submission are backgrounded so the
597
+ * work loop can return to IDLE immediately for consecutive slot proposals.
598
+ * Returns the built checkpoint if successful, undefined otherwise.
583
599
  */ async execute() {
584
600
  // Enqueue governance and slashing votes (returns promises that will be awaited later)
585
601
  // In fisherman mode, we simulate slashing but don't actually publish to L1
586
602
  // These are constant for the whole slot, so we only enqueue them once
587
- const votesPromises = new CheckpointVoter(this.slot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
588
- // Build and propose the checkpoint. This will enqueue the request on the publisher if a checkpoint is built.
589
- const checkpoint = await this.proposeCheckpoint();
590
- // Wait until the voting promises have resolved, so all requests are enqueued (not sent)
591
- await Promise.all(votesPromises);
592
- if (checkpoint) {
593
- this.metrics.recordBlockProposalSuccess();
603
+ const votesPromises = new CheckpointVoter(this.targetSlot, this.publisher, this.attestorAddress, this.validatorClient, this.slasherClient, this.l1Constants, this.config, this.metrics, this.log).enqueueVotes();
604
+ // Build blocks, assemble checkpoint, and broadcast proposal (BLOCKING).
605
+ // Returns after broadcast — attestation collection is deferred.
606
+ const broadcast = await this.proposeCheckpoint();
607
+ if (!broadcast) {
608
+ await Promise.all(votesPromises);
609
+ // Still submit votes even without a checkpoint
610
+ if (!this.config.fishermanMode) {
611
+ this.pendingL1Submission = this.publisher.sendRequestsAt(this.dateProvider.nowAsDate()).then(()=>{});
612
+ }
613
+ return undefined;
594
614
  }
615
+ const { checkpoint } = broadcast;
616
+ this.metrics.recordCheckpointProposalSuccess();
595
617
  // Do not post anything to L1 if we are fishermen, but do perform L1 fee analysis
596
618
  if (this.config.fishermanMode) {
597
619
  await this.handleCheckpointEndAsFisherman(checkpoint);
620
+ return checkpoint;
621
+ }
622
+ // Background the attestation → signing → L1 pipeline so the work loop is unblocked
623
+ this.pendingL1Submission = this.waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises);
624
+ // Return the built checkpoint immediately — the work loop is now unblocked
625
+ return checkpoint;
626
+ }
627
+ /**
628
+ * Background pipeline: collects attestations, signs them, enqueues the checkpoint, and submits to L1.
629
+ * Runs as a fire-and-forget task stored in `pendingL1Submission` so the work loop is unblocked.
630
+ */ async waitForAttestationsAndEnqueueSubmissionAsync(broadcast, votesPromises) {
631
+ const { checkpoint } = broadcast;
632
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
633
+ try {
634
+ // Wait for all votes actions, enqueued at the beginning, to resolve
635
+ await Promise.all(votesPromises);
636
+ // Try to collect attestations from the committee
637
+ const signedAttestations = await this.getSignedCommitteeAttestations(broadcast);
638
+ // If pipelining, wait for the previous checkpoint to land on L1 before submitting,
639
+ // so we can check it matches the proposed checkpoint we used as parent, and has valid attestations.
640
+ if (signedAttestations && (!isPipelining || await this.waitForValidParentCheckpointOnL1())) {
641
+ await this.enqueueCheckpointForSubmission({
642
+ checkpoint,
643
+ ...signedAttestations
644
+ });
645
+ }
646
+ // If we failed to collect attestations, at least check if we need to issue an invalidation
647
+ // Note that if we are not pipelining, we enqueued the invalidation at the beginning
648
+ if (!signedAttestations && isPipelining && await this.waitForSyncedL2SlotNumber(this.slotNow)) {
649
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
650
+ if (!validationStatus.valid) {
651
+ this.log.warn(`Checkpoint ${validationStatus.checkpoint.checkpointNumber} has invalid attestations, enqueuing invalidation in spite of attestation collection failure`, {
652
+ checkpoint: validationStatus.checkpoint,
653
+ reason: validationStatus.reason
654
+ });
655
+ await this.enqueueInvalidation(validationStatus);
656
+ }
657
+ }
658
+ // Send whatever was enqueued: votes + (propose | invalidation | nothing).
659
+ // Compute the earliest time to submit: pipeline slot start when pipelining, now otherwise.
660
+ const submitAfter = isPipelining ? new Date(Number(getTimestampForSlot(this.targetSlot, this.l1Constants)) * 1000) : new Date(this.dateProvider.now());
661
+ const l1Response = await this.publisher.sendRequestsAt(submitAfter);
662
+ const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
663
+ if (proposedAction) {
664
+ this.eventEmitter.emit('checkpoint-published', {
665
+ checkpoint: this.checkpointNumber,
666
+ slot: this.targetSlot
667
+ });
668
+ const coinbase = checkpoint.header.coinbase;
669
+ await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
670
+ } else {
671
+ this.eventEmitter.emit('checkpoint-publish-failed', {
672
+ ...l1Response,
673
+ slot: this.targetSlot
674
+ });
675
+ if (isPipelining) {
676
+ this.metrics.recordPipelineDiscard();
677
+ }
678
+ }
679
+ } catch (err) {
680
+ if (err instanceof SequencerInterruptedError) {
681
+ return;
682
+ }
683
+ this.log.error(`Background attestation/L1 pipeline failed for slot ${this.targetSlot}`, err);
684
+ this.eventEmitter.emit('checkpoint-publish-failed', {
685
+ slot: this.targetSlot
686
+ });
687
+ if (isPipelining) {
688
+ this.metrics.recordPipelineDiscard();
689
+ }
690
+ }
691
+ }
692
+ /** Enqueues the checkpoint for L1 submission. Called after pipeline sleep in execute(). */ async enqueueCheckpointForSubmission(result) {
693
+ const { checkpoint, attestations, attestationsSignature } = result;
694
+ this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.targetSlot);
695
+ const aztecSlotDuration = this.l1Constants.slotDuration;
696
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
697
+ const txTimeoutAt = new Date((submissionSlotStart + aztecSlotDuration) * 1000);
698
+ // If we have been configured to potentially skip publishing checkpoint then roll the dice here
699
+ if (this.config.skipPublishingCheckpointsPercent !== undefined && this.config.skipPublishingCheckpointsPercent > 0) {
700
+ const roll = Math.max(0, randomInt(100));
701
+ if (roll < this.config.skipPublishingCheckpointsPercent) {
702
+ this.log.warn(`Skipping publishing proposal for checkpoint ${checkpoint.number}. Configured percentage: ${this.config.skipPublishingCheckpointsPercent}, generated value: ${roll}`);
703
+ return;
704
+ }
705
+ }
706
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
707
+ const submissionSimulationOverridesPlan = buildSubmissionSimulationOverridesPlan({
708
+ pipelinedParentPlan: this.pipelinedParentSimulationOverridesPlan,
709
+ invalidateToPendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber,
710
+ lastArchiveRoot: checkpoint.header.lastArchiveRoot,
711
+ pipeliningEnabled: isPipelining
712
+ });
713
+ await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
714
+ txTimeoutAt,
715
+ ...submissionSimulationOverridesPlan ? {
716
+ simulationOverridesPlan: submissionSimulationOverridesPlan
717
+ } : {}
718
+ });
719
+ }
720
+ /**
721
+ * Wait until the archiver syncs past the given L2 slot number.
722
+ * The deadline is the end of `this.targetSlot`, beyond which any pipelined work would miss its
723
+ * L1 submission window and is no longer useful.
724
+ */ async waitForSyncedL2SlotNumber(waitForSlot) {
725
+ const targetSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
726
+ const targetSlotEndMs = (targetSlotStart + this.l1Constants.slotDuration) * 1000;
727
+ const syncDelayTolerance = this.l1Constants.ethereumSlotDuration * 2 * 1000;
728
+ const timeoutSeconds = Math.max(0.1, (targetSlotEndMs + syncDelayTolerance - this.dateProvider.now()) / 1000);
729
+ try {
730
+ return await retryUntil(async ()=>{
731
+ const syncedSlot = await this.l2BlockSource.getSyncedL2SlotNumber();
732
+ return syncedSlot !== undefined && syncedSlot >= waitForSlot;
733
+ }, `archiver sync past slot ${waitForSlot}`, timeoutSeconds, 0.2);
734
+ } catch {
735
+ this.log.warn(`Archiver did not sync L1 past slot ${waitForSlot} before slot ${this.targetSlot} expired, discarding pipelined work`, {
736
+ checkpointNumber: this.checkpointNumber
737
+ });
738
+ this.emitPipelinedCheckpointDiscarded('archiver-sync-timeout');
739
+ return false;
740
+ }
741
+ }
742
+ /**
743
+ * Waits for the parent checkpoint to land on L1 before submitting a pipelined checkpoint.
744
+ * Polls until the archiver has synced L1 past the parent's slot, then verifies:
745
+ * - If we built on a proposed parent: it must have landed on L1 with matching hash and valid attestations.
746
+ * - If we built without a proposed parent: no new checkpoint must have appeared for that slot.
747
+ * If the parent has invalid attestations, enqueues an invalidation. Returns whether to proceed with the proposal.
748
+ */ async waitForValidParentCheckpointOnL1() {
749
+ const parentCheckpointNumber = CheckpointNumber(this.checkpointNumber - 1);
750
+ // Wait until archiver has synced L1 past the parent's slot (slotNow)
751
+ if (!await this.waitForSyncedL2SlotNumber(this.slotNow)) {
752
+ return false;
753
+ }
754
+ const tips = await this.l2BlockSource.getL2Tips();
755
+ const checkpointedNumber = tips.checkpointed.checkpoint.number;
756
+ // We built on top of a proposed checkpoint. Verify it landed on L1 as expected.
757
+ if (this.proposedCheckpointData) {
758
+ // After syncing from L1 we see the chain tip has invalid attestations. This means the parent checkpoint was posted
759
+ // with invalid attestations, or it built on top of something with invalid attestations and didnt invalidate them.
760
+ // Either way, we thought our parent would be valid, so we have to throw away our work. But at least we'll try and
761
+ // invalidate on L1 so we clean up the chain for the next proposer. And we'll slash them, but that's handled elsewhere.
762
+ const validationStatus = await this.l2BlockSource.getPendingChainValidationStatus();
763
+ if (!validationStatus.valid) {
764
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} has invalid attestations, discarding pipelined work`, {
765
+ checkpointNumber: this.checkpointNumber,
766
+ reason: validationStatus.reason
767
+ });
768
+ this.emitPipelinedCheckpointDiscarded('parent-invalid-attestations');
769
+ await this.enqueueInvalidation(validationStatus);
770
+ return false;
771
+ }
772
+ // The pending chain is valid. But did the parent checkpoint land on L1 at all?
773
+ if (checkpointedNumber < parentCheckpointNumber) {
774
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} did not land on L1, discarding pipelined work`, {
775
+ checkpointNumber: this.checkpointNumber,
776
+ checkpointedNumber
777
+ });
778
+ this.emitPipelinedCheckpointDiscarded('parent-not-on-l1');
779
+ return false;
780
+ }
781
+ // It landed. But is it the one we were expecting?
782
+ const expectedHash = this.proposedCheckpointData.header.hash().toString();
783
+ if (tips.checkpointed.checkpoint.hash !== expectedHash) {
784
+ this.log.warn(`Parent checkpoint ${parentCheckpointNumber} hash mismatch on L1, discarding pipelined work`, {
785
+ checkpointNumber: this.checkpointNumber,
786
+ expectedHash,
787
+ actualHash: tips.checkpointed.checkpoint.hash
788
+ });
789
+ this.emitPipelinedCheckpointDiscarded('parent-hash-mismatch');
790
+ return false;
791
+ }
792
+ return true;
793
+ } else {
794
+ // We didn't see a proposed checkpoint at build time, so we built on checkpointed parent from two slots ago.
795
+ // But if a new checkpoint for the previous slot appeared on L1 in the meantime, our checkpoint assumed the wrong parent,
796
+ // so we have to discard our work. This can happen if we're somehow cut off from p2p and fail to see the checkpoint
797
+ // proposal for the previous slot.
798
+ if (checkpointedNumber > parentCheckpointNumber) {
799
+ this.log.warn(`Unexpected checkpoint ${checkpointedNumber} landed on L1 after we built on top of parent ${parentCheckpointNumber}, discarding pipelined work`, {
800
+ checkpointNumber: this.checkpointNumber,
801
+ checkpointedNumber
802
+ });
803
+ this.emitPipelinedCheckpointDiscarded('unexpected-parent-appeared');
804
+ return false;
805
+ }
806
+ return true;
807
+ }
808
+ }
809
+ /** Emits the pipelined-checkpoint-discarded event and records the metric. */ emitPipelinedCheckpointDiscarded(reason) {
810
+ this.metrics.recordPipelineParentCheckpointMismatch(reason);
811
+ this.eventEmitter.emit('pipelined-checkpoint-discarded', {
812
+ slot: this.targetSlot,
813
+ checkpointNumber: this.checkpointNumber,
814
+ reason
815
+ });
816
+ }
817
+ /** Simulates and enqueues an invalidation request for the invalid parent checkpoint. */ async enqueueInvalidation(validationStatus) {
818
+ if (this.config.skipInvalidateBlockAsProposer) {
819
+ this.log.warn(`Skipping checkpoint invalidation as proposer due to test configuration`);
598
820
  return;
599
821
  }
600
- // Then send everything to L1
601
- const l1Response = await this.publisher.sendRequests();
602
- const proposedAction = l1Response?.successfulActions.find((a)=>a === 'propose');
603
- if (proposedAction) {
604
- this.eventEmitter.emit('checkpoint-published', {
605
- checkpoint: this.checkpointNumber,
606
- slot: this.slot
822
+ const invalidateRequest = await this.publisher.simulateInvalidateCheckpoint(validationStatus);
823
+ if (invalidateRequest) {
824
+ const submissionSlotStart = Number(getTimestampForSlot(this.targetSlot, this.l1Constants));
825
+ const txTimeoutAt = new Date((submissionSlotStart + this.l1Constants.slotDuration) * 1000);
826
+ this.publisher.enqueueInvalidateCheckpoint(invalidateRequest, {
827
+ txTimeoutAt
607
828
  });
608
- const coinbase = checkpoint?.header.coinbase;
609
- await this.metrics.incFilledSlot(this.publisher.getSenderAddress().toString(), coinbase);
610
- return checkpoint;
611
- } else if (checkpoint) {
612
- this.eventEmitter.emit('checkpoint-publish-failed', {
613
- ...l1Response,
614
- slot: this.slot
829
+ } else {
830
+ this.log.info(`Invalidation simulation returned undefined, checkpoint may have been removed already`, {
831
+ checkpointNumber: this.checkpointNumber
615
832
  });
616
- return undefined;
617
833
  }
618
834
  }
619
835
  async proposeCheckpoint() {
@@ -624,29 +840,53 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
624
840
  hasError: false
625
841
  };
626
842
  try {
843
+ const now = this.dateProvider.now();
844
+ if (this.epochCache.isProposerPipeliningEnabled() && this.proposedCheckpointData) {
845
+ // Measure against the wall-clock slot whose build window we are currently using.
846
+ // In pipelining mode `targetSlot` is intentionally one slot ahead, which makes the
847
+ // target-slot boundary a full slot away from the actual build start time.
848
+ const slotBoundaryMs = Number(getTimestampForSlot(this.slotNow, this.l1Constants)) * 1000;
849
+ this.checkpointMetrics.recordPipelinedCheckpointBuildStartOffsetFromSlotBoundary(now - slotBoundaryMs);
850
+ }
851
+ this.checkpointMetrics.startCheckpointTiming(now);
627
852
  // Get operator configured coinbase and fee recipient for this attestor
628
853
  const coinbase = this.validatorClient.getCoinbaseForAttestor(this.attestorAddress);
629
854
  const feeRecipient = this.validatorClient.getFeeRecipientForAttestor(this.attestorAddress);
630
855
  // Start the checkpoint
631
- this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.slot);
632
- this.metrics.incOpenSlot(this.slot, this.proposer?.toString() ?? 'unknown');
856
+ this.setStateFn(SequencerState.INITIALIZING_CHECKPOINT, this.targetSlot);
857
+ this.log.info(`Starting checkpoint proposal`, {
858
+ buildSlot: this.slotNow,
859
+ submissionSlot: this.targetSlot,
860
+ pipelining: this.epochCache.isProposerPipeliningEnabled(),
861
+ proposer: this.proposer?.toString(),
862
+ coinbase: coinbase.toString()
863
+ });
864
+ this.metrics.incOpenSlot(this.targetSlot, this.proposer?.toString() ?? 'unknown');
633
865
  // Enqueues checkpoint invalidation (constant for the whole slot)
634
866
  if (this.invalidateCheckpoint && !this.config.skipInvalidateBlockAsProposer) {
635
867
  this.publisher.enqueueInvalidateCheckpoint(this.invalidateCheckpoint);
636
868
  }
637
- // Create checkpoint builder for the slot
638
- const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.slot);
869
+ // Create checkpoint builder for the slot.
870
+ // When pipelining, force the proposed checkpoint number and fee header to our parent so the
871
+ // fee computation sees the same chain tip that L1 will see once the previous pipelined checkpoint lands.
872
+ const isPipelining = this.epochCache.isProposerPipeliningEnabled();
873
+ this.pipelinedParentSimulationOverridesPlan = isPipelining ? await buildPipelinedParentSimulationOverridesPlan({
874
+ checkpointNumber: this.checkpointNumber,
875
+ proposedCheckpointData: this.proposedCheckpointData,
876
+ rollup: this.publisher.rollupContract,
877
+ log: this.log
878
+ }) : undefined;
879
+ const checkpointGlobalVariables = await this.globalsBuilder.buildCheckpointGlobalVariables(coinbase, feeRecipient, this.targetSlot, this.pipelinedParentSimulationOverridesPlan);
639
880
  // Collect L1 to L2 messages for the checkpoint and compute their hash
640
881
  const l1ToL2Messages = await this.l1ToL2MessageSource.getL1ToL2Messages(this.checkpointNumber);
641
882
  const inHash = computeInHashFromL1ToL2Messages(l1ToL2Messages);
642
883
  // Collect the out hashes of all the checkpoints before this one in the same epoch
643
- const previousCheckpoints = (await this.l2BlockSource.getCheckpointsForEpoch(this.epoch)).filter((c)=>c.number < this.checkpointNumber);
644
- const previousCheckpointOutHashes = previousCheckpoints.map((c)=>c.getCheckpointOutHash());
884
+ const previousCheckpointOutHashes = (await this.l2BlockSource.getCheckpointsDataForEpoch(this.targetEpoch)).filter((c)=>c.checkpointNumber < this.checkpointNumber).map((c)=>c.checkpointOutHash);
645
885
  // Get the fee asset price modifier from the oracle
646
886
  const feeAssetPriceModifier = await this.publisher.getFeeAssetPriceModifier();
647
887
  const fork = _ts_add_disposable_resource(env, await this.worldState.fork(this.syncedToBlockNumber, {
648
888
  closeDelayMs: 12_000
649
- }), false);
889
+ }), true);
650
890
  // Create checkpoint builder for the entire slot
651
891
  const checkpointBuilder = await this.checkpointsBuilder.startCheckpoint(this.checkpointNumber, checkpointGlobalVariables, feeAssetPriceModifier, l1ToL2Messages, previousCheckpointOutHashes, fork, this.log.getBindings());
652
892
  // Options for the validator client when creating block and checkpoint proposals
@@ -660,6 +900,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
660
900
  };
661
901
  let blocksInCheckpoint = [];
662
902
  let blockPendingBroadcast = undefined;
903
+ const checkpointBuildTimer = new Timer();
663
904
  try {
664
905
  // Main loop: build blocks for the checkpoint
665
906
  const result = await this.buildBlocksForCheckpoint(checkpointBuilder, checkpointGlobalVariables.timestamp, inHash, blockProposalOptions);
@@ -675,77 +916,84 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
675
916
  throw err;
676
917
  }
677
918
  if (blocksInCheckpoint.length === 0) {
678
- this.log.warn(`No blocks were built for slot ${this.slot}`, {
679
- slot: this.slot
919
+ this.log.warn(`No blocks were built for slot ${this.targetSlot}`, {
920
+ slot: this.targetSlot
680
921
  });
681
922
  this.eventEmitter.emit('checkpoint-empty', {
682
- slot: this.slot
923
+ slot: this.targetSlot
924
+ });
925
+ return undefined;
926
+ }
927
+ const minBlocksForCheckpoint = this.config.minBlocksForCheckpoint;
928
+ if (minBlocksForCheckpoint !== undefined && blocksInCheckpoint.length < minBlocksForCheckpoint) {
929
+ this.log.warn(`Checkpoint has fewer blocks than minimum (${blocksInCheckpoint.length} < ${minBlocksForCheckpoint}), skipping proposal`, {
930
+ slot: this.targetSlot,
931
+ blocksBuilt: blocksInCheckpoint.length,
932
+ minBlocksForCheckpoint
683
933
  });
684
934
  return undefined;
685
935
  }
686
936
  // Assemble and broadcast the checkpoint proposal, including the last block that was not
687
937
  // broadcasted yet, and wait to collect the committee attestations.
688
- this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.slot);
938
+ this.setStateFn(SequencerState.ASSEMBLING_CHECKPOINT, this.targetSlot);
689
939
  const checkpoint = await checkpointBuilder.completeCheckpoint();
690
- // Do not collect attestations nor publish to L1 in fisherman mode
940
+ // Final validation: per-block limits are only checked if the operator set them explicitly.
941
+ // Otherwise, checkpoint-level budgets were already enforced by the redistribution logic.
942
+ try {
943
+ validateCheckpoint(checkpoint, {
944
+ rollupManaLimit: this.l1Constants.rollupManaLimit,
945
+ maxL2BlockGas: this.config.maxL2BlockGas,
946
+ maxDABlockGas: this.config.maxDABlockGas,
947
+ maxTxsPerBlock: this.config.maxTxsPerBlock,
948
+ maxTxsPerCheckpoint: this.config.maxTxsPerCheckpoint
949
+ });
950
+ } catch (err) {
951
+ this.log.error(`Built an invalid checkpoint at slot ${this.slotNow} (skipping proposal)`, err, {
952
+ checkpoint: checkpoint.header.toInspect()
953
+ });
954
+ return undefined;
955
+ }
956
+ // Record checkpoint-level build metrics
957
+ this.checkpointMetrics.recordCheckpointBuild(checkpointBuildTimer.ms(), blocksInCheckpoint.length, checkpoint.getStats().txCount, Number(checkpoint.header.totalManaUsed.toBigInt()));
958
+ // In fisherman mode, return the checkpoint without broadcasting or collecting attestations
691
959
  if (this.config.fishermanMode) {
692
- this.log.info(`Built checkpoint for slot ${this.slot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
693
- slot: this.slot,
960
+ this.log.info(`Built checkpoint for slot ${this.targetSlot} with ${blocksInCheckpoint.length} blocks. ` + `Skipping proposal in fisherman mode.`, {
961
+ slot: this.targetSlot,
694
962
  checkpoint: checkpoint.header.toInspect(),
695
963
  blocksBuilt: blocksInCheckpoint.length
696
964
  });
697
965
  this.metrics.recordCheckpointSuccess();
698
- return checkpoint;
966
+ // Return a broadcast result with a dummy proposal — fisherman mode skips attestation collection
967
+ return {
968
+ checkpoint,
969
+ proposal: undefined,
970
+ blockProposedAt: this.dateProvider.now()
971
+ };
699
972
  }
700
- // Include the block pending broadcast in the checkpoint proposal if any
701
- const lastBlock = blockPendingBroadcast && {
702
- blockHeader: blockPendingBroadcast.block.header,
703
- indexWithinCheckpoint: blockPendingBroadcast.block.indexWithinCheckpoint,
704
- txs: blockPendingBroadcast.txs
705
- };
706
973
  // Create the checkpoint proposal and broadcast it
707
- const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, feeAssetPriceModifier, lastBlock, this.proposer, checkpointProposalOptions);
974
+ const proposal = await this.validatorClient.createCheckpointProposal(checkpoint.header, checkpoint.archive.root, this.checkpointNumber, feeAssetPriceModifier, blockPendingBroadcast, this.proposer, checkpointProposalOptions);
708
975
  const blockProposedAt = this.dateProvider.now();
709
976
  await this.p2pClient.broadcastCheckpointProposal(proposal);
710
- this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.slot);
711
- const attestations = await this.waitForAttestations(proposal);
712
- const blockAttestedAt = this.dateProvider.now();
713
- this.metrics.recordCheckpointAttestationDelay(blockAttestedAt - blockProposedAt);
714
- // Proposer must sign over the attestations before pushing them to L1
715
- const signer = this.proposer ?? this.publisher.getSenderAddress();
716
- let attestationsSignature;
717
- try {
718
- attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.slot, this.checkpointNumber);
719
- } catch (err) {
720
- // We shouldn't really get here since we yield to another HA node
721
- // as soon as we see these errors when creating block or checkpoint proposals.
722
- if (this.handleHASigningError(err, 'Attestations signature')) {
723
- return undefined;
724
- }
725
- throw err;
726
- }
727
- // Enqueue publishing the checkpoint to L1
728
- this.setStateFn(SequencerState.PUBLISHING_CHECKPOINT, this.slot);
729
- const aztecSlotDuration = this.l1Constants.slotDuration;
730
- const slotStartBuildTimestamp = this.getSlotStartBuildTimestamp();
731
- const txTimeoutAt = new Date((slotStartBuildTimestamp + aztecSlotDuration) * 1000);
732
- await this.publisher.enqueueProposeCheckpoint(checkpoint, attestations, attestationsSignature, {
733
- txTimeoutAt,
734
- forcePendingCheckpointNumber: this.invalidateCheckpoint?.forcePendingCheckpointNumber
735
- });
736
- return checkpoint;
977
+ this.checkpointMetrics.noteCheckpointBroadcast(this.dateProvider.now());
978
+ // Return immediately after broadcast — attestation collection happens in the background
979
+ return {
980
+ checkpoint,
981
+ proposal,
982
+ blockProposedAt
983
+ };
737
984
  } catch (e) {
738
985
  env.error = e;
739
986
  env.hasError = true;
740
987
  } finally{
741
- _ts_dispose_resources(env);
988
+ const result = _ts_dispose_resources(env);
989
+ if (result) await result;
742
990
  }
743
991
  } catch (err) {
744
992
  if (err && (err instanceof DutyAlreadySignedError || err instanceof SlashingProtectionError)) {
745
993
  // swallow this error. It's already been logged by a function deeper in the stack
746
994
  return undefined;
747
995
  }
748
- this.log.error(`Error building checkpoint at slot ${this.slot}`, err);
996
+ this.log.error(`Error building checkpoint at slot ${this.targetSlot}`, err);
749
997
  return undefined;
750
998
  }
751
999
  }
@@ -755,8 +1003,6 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
755
1003
  const blocksInCheckpoint = [];
756
1004
  const txHashesAlreadyIncluded = new Set();
757
1005
  const initialBlockNumber = BlockNumber(this.syncedToBlockNumber + 1);
758
- // Remaining blob fields available for blocks (checkpoint end marker already subtracted)
759
- let remainingBlobFields = BLOBS_PER_CHECKPOINT * FIELDS_PER_BLOB - NUM_CHECKPOINT_END_MARKER_FIELDS;
760
1006
  // Last block in the checkpoint will usually be flagged as pending broadcast, so we send it along with the checkpoint proposal
761
1007
  let blockPendingBroadcast = undefined;
762
1008
  while(true){
@@ -767,7 +1013,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
767
1013
  const timingInfo = this.timetable.canStartNextBlock(secondsIntoSlot);
768
1014
  if (!timingInfo.canStart) {
769
1015
  this.log.debug(`Not enough time left in slot to start another block`, {
770
- slot: this.slot,
1016
+ slot: this.targetSlot,
771
1017
  blocksBuilt,
772
1018
  secondsIntoSlot
773
1019
  });
@@ -782,68 +1028,61 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
782
1028
  buildDeadline: timingInfo.deadline ? new Date((this.getSlotStartBuildTimestamp() + timingInfo.deadline) * 1000) : undefined,
783
1029
  blockNumber,
784
1030
  indexWithinCheckpoint,
785
- txHashesAlreadyIncluded,
786
- remainingBlobFields
1031
+ txHashesAlreadyIncluded
787
1032
  });
788
- // TODO(palla/mbps): Review these conditions. We may want to keep trying in some scenarios.
789
- if (!buildResult && timingInfo.isLastBlock) {
790
- break;
791
- } else if (!buildResult && timingInfo.deadline !== undefined) {
792
- // But if there is still time for more blocks, wait until the next subslot and try again
1033
+ // If we failed to build the block due to insufficient txs, we try again if there is still time left in the slot
1034
+ if ('failure' in buildResult) {
1035
+ // If this was the last subslot, or we're running with a single block per slot, we're done
1036
+ if (timingInfo.isLastBlock || timingInfo.deadline === undefined) {
1037
+ break;
1038
+ }
1039
+ // Otherwise, if there is still time for more blocks, we wait until the next subslot and try again
793
1040
  await this.waitUntilNextSubslot(timingInfo.deadline);
794
1041
  continue;
795
- } else if (!buildResult) {
796
- break;
797
- } else if ('error' in buildResult) {
798
- // If there was an error building the block, just exit the loop and give up the rest of the slot
1042
+ }
1043
+ // If there was an error building the block, we just exit the loop and give up the rest of the slot.
1044
+ // We don't want to risk building more blocks if something went wrong.
1045
+ if ('error' in buildResult) {
799
1046
  if (!(buildResult.error instanceof SequencerInterruptedError)) {
800
- this.log.warn(`Halting block building for slot ${this.slot}`, {
801
- slot: this.slot,
1047
+ this.log.warn(`Halting block building for slot ${this.targetSlot}`, {
1048
+ slot: this.targetSlot,
802
1049
  blocksBuilt,
803
1050
  error: buildResult.error
804
1051
  });
805
1052
  }
806
1053
  break;
807
1054
  }
808
- const { block, usedTxs, remainingBlobFields: newRemainingBlobFields } = buildResult;
809
- blocksInCheckpoint.push(block);
810
- // Update remaining blob fields for the next block
811
- remainingBlobFields = newRemainingBlobFields;
812
- // Sync the proposed block to the archiver to make it available
813
- // Note that the checkpoint builder uses its own fork so it should not need to wait for this syncing
814
- // Eventually we should refactor the checkpoint builder to not need a separate long-lived fork
815
- // Fire and forget - don't block the critical path, but log errors
816
- this.syncProposedBlockToArchiver(block).catch((err)=>{
817
- this.log.error(`Failed to sync proposed block ${block.number} to archiver`, {
818
- blockNumber: block.number,
819
- err
820
- });
1055
+ const { block, usedTxs } = buildResult;
1056
+ this.checkpointMetrics.noteCheckpointBlockBuilt(this.dateProvider.now(), {
1057
+ isFirstBlock: blocksBuilt === 0,
1058
+ isLastBlock: timingInfo.isLastBlock
821
1059
  });
1060
+ blocksInCheckpoint.push(block);
822
1061
  usedTxs.forEach((tx)=>txHashesAlreadyIncluded.add(tx.txHash.toString()));
823
- // If this is the last block, exit the loop now so we start collecting attestations
1062
+ // Sign the block proposal. This will throw if HA signing fails.
1063
+ const proposal = await this.createBlockProposal(block, inHash, usedTxs, blockProposalOptions);
1064
+ // Sync the proposed block to the archiver to make it available, only after we've managed to sign the proposal,
1065
+ // so we avoid polluting our archive with a block that would fail.
1066
+ // We wait for the sync to succeed, as this helps catch consistency errors, even if it means we lose some time for block-building.
1067
+ // If this throws, we abort the entire checkpoint.
1068
+ await this.syncProposedBlockToArchiver(block);
1069
+ // If this is the last block, do not broadcast it, since it will be included in the checkpoint proposal.
824
1070
  if (timingInfo.isLastBlock) {
825
- this.log.verbose(`Completed final block ${blockNumber} for slot ${this.slot}`, {
826
- slot: this.slot,
1071
+ this.log.verbose(`Completed final block ${blockNumber} for slot ${this.targetSlot}`, {
1072
+ slot: this.targetSlot,
827
1073
  blockNumber,
828
1074
  blocksBuilt
829
1075
  });
830
- blockPendingBroadcast = {
831
- block,
832
- txs: usedTxs
833
- };
1076
+ blockPendingBroadcast = proposal;
834
1077
  break;
835
1078
  }
836
- // For non-last blocks, broadcast the block proposal (unless we're in fisherman mode)
837
- // If the block is the last one, we'll broadcast it along with the checkpoint at the end of the loop
838
- if (!this.config.fishermanMode) {
839
- const proposal = await this.validatorClient.createBlockProposal(block.header, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
840
- await this.p2pClient.broadcastProposal(proposal);
841
- }
1079
+ // Once we have a signed proposal and the archiver agreed with our proposed block, then we broadcast it.
1080
+ proposal && await this.p2pClient.broadcastProposal(proposal);
842
1081
  // Wait until the next block's start time
843
1082
  await this.waitUntilNextSubslot(timingInfo.deadline);
844
1083
  }
845
- this.log.verbose(`Block building loop completed for slot ${this.slot}`, {
846
- slot: this.slot,
1084
+ this.log.verbose(`Block building loop completed for slot ${this.targetSlot}`, {
1085
+ slot: this.targetSlot,
847
1086
  blocksBuilt: blocksInCheckpoint.length
848
1087
  });
849
1088
  return {
@@ -851,82 +1090,92 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
851
1090
  blockPendingBroadcast
852
1091
  };
853
1092
  }
1093
+ /** Creates a block proposal for a given block via the validator client (unless in fisherman mode) */ createBlockProposal(block, inHash, usedTxs, blockProposalOptions) {
1094
+ if (this.config.fishermanMode) {
1095
+ this.log.info(`Skipping block proposal for block ${block.number} in fisherman mode`);
1096
+ return Promise.resolve(undefined);
1097
+ }
1098
+ return this.validatorClient.createBlockProposal(block.header, this.checkpointNumber, block.indexWithinCheckpoint, inHash, block.archive.root, usedTxs, this.proposer, blockProposalOptions);
1099
+ }
854
1100
  /** Sleeps until it is time to produce the next block in the slot */ async waitUntilNextSubslot(nextSubslotStart) {
855
- this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.slot);
1101
+ this.setStateFn(SequencerState.WAITING_UNTIL_NEXT_BLOCK, this.targetSlot);
856
1102
  this.log.verbose(`Waiting until time for the next block at ${nextSubslotStart}s into slot`, {
857
- slot: this.slot
1103
+ slot: this.targetSlot
858
1104
  });
859
1105
  await this.waitUntilTimeInSlot(nextSubslotStart);
860
1106
  }
861
1107
  /** Builds a single block. Called from the main block building loop. */ async buildSingleBlock(checkpointBuilder, opts) {
862
- const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded, remainingBlobFields } = opts;
863
- this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.slot}`, {
1108
+ const { blockTimestamp, forceCreate, blockNumber, indexWithinCheckpoint, buildDeadline, txHashesAlreadyIncluded } = opts;
1109
+ this.log.verbose(`Preparing block ${blockNumber} index ${indexWithinCheckpoint} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot}`, {
864
1110
  ...checkpointBuilder.getConstantData(),
865
1111
  ...opts
866
1112
  });
867
1113
  try {
868
1114
  // Wait until we have enough txs to build the block
869
- const minTxs = this.config.minTxsPerBlock;
870
- const { availableTxs, canStartBuilding } = await this.waitForMinTxs(opts);
1115
+ const { availableTxs, canStartBuilding, minTxs } = await this.waitForMinTxs(opts);
871
1116
  if (!canStartBuilding) {
872
- this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (got ${availableTxs} txs but needs ${minTxs})`, {
1117
+ this.log.warn(`Not enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (got ${availableTxs} txs but needs ${minTxs})`, {
873
1118
  blockNumber,
874
- slot: this.slot,
1119
+ slot: this.targetSlot,
875
1120
  indexWithinCheckpoint
876
1121
  });
877
1122
  this.eventEmitter.emit('block-tx-count-check-failed', {
878
1123
  minTxs,
879
1124
  availableTxs,
880
- slot: this.slot
1125
+ slot: this.targetSlot
881
1126
  });
882
1127
  this.metrics.recordBlockProposalFailed('insufficient_txs');
883
- return undefined;
1128
+ return {
1129
+ failure: 'insufficient-txs'
1130
+ };
884
1131
  }
885
1132
  // Create iterator to pending txs. We filter out txs already included in previous blocks in the checkpoint
886
1133
  // just in case p2p failed to sync the provisional block and didn't get to remove those txs from the mempool yet.
887
1134
  const pendingTxs = filter(this.p2pClient.iterateEligiblePendingTxs(), (tx)=>!txHashesAlreadyIncluded.has(tx.txHash.toString()));
888
- this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.slot} with ${availableTxs} available txs`, {
889
- slot: this.slot,
1135
+ this.log.debug(`Building block ${blockNumber} at index ${indexWithinCheckpoint} for slot ${this.targetSlot} with ${availableTxs} available txs`, {
1136
+ slot: this.targetSlot,
890
1137
  blockNumber,
891
1138
  indexWithinCheckpoint
892
1139
  });
893
- this.setStateFn(SequencerState.CREATING_BLOCK, this.slot);
894
- // Calculate blob fields limit for txs (remaining capacity - this block's end overhead)
895
- const blockEndOverhead = getNumBlockEndBlobFields(indexWithinCheckpoint === 0);
896
- const maxBlobFieldsForTxs = remainingBlobFields - blockEndOverhead;
1140
+ this.setStateFn(SequencerState.CREATING_BLOCK, this.targetSlot);
1141
+ // Per-block limits are operator overrides (from SEQ_MAX_L2_BLOCK_GAS etc.) further capped
1142
+ // by remaining checkpoint-level budgets inside CheckpointBuilder before each block is built.
1143
+ // minValidTxs is passed into the builder so it can reject the block *before* updating state.
1144
+ const minValidTxs = forceCreate ? 0 : this.config.minValidTxsPerBlock ?? minTxs;
897
1145
  const blockBuilderOptions = {
898
1146
  maxTransactions: this.config.maxTxsPerBlock,
899
- maxBlockSize: this.config.maxBlockSizeInBytes,
900
- maxBlockGas: new Gas(this.config.maxDABlockGas, this.config.maxL2BlockGas),
901
- maxBlobFields: maxBlobFieldsForTxs,
902
- deadline: buildDeadline
1147
+ maxBlockGas: this.config.maxL2BlockGas !== undefined || this.config.maxDABlockGas !== undefined ? new Gas(this.config.maxDABlockGas ?? Infinity, this.config.maxL2BlockGas ?? Infinity) : undefined,
1148
+ deadline: buildDeadline,
1149
+ isBuildingProposal: true,
1150
+ minValidTxs,
1151
+ maxBlocksPerCheckpoint: this.timetable.maxNumberOfBlocks,
1152
+ perBlockAllocationMultiplier: this.config.perBlockAllocationMultiplier
903
1153
  };
904
- // Actually build the block by executing txs
1154
+ // Actually build the block by executing txs. The builder throws InsufficientValidTxsError
1155
+ // if the number of successfully processed txs is below minValidTxs, ensuring state is not
1156
+ // updated for blocks that will be discarded.
905
1157
  const buildResult = await this.buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
906
1158
  // If any txs failed during execution, drop them from the mempool so we don't pick them up again
907
1159
  await this.dropFailedTxsFromP2P(buildResult.failedTxs);
908
- // Check if we have created a block with enough txs. If there were invalid txs in the pool, or if execution took
909
- // too long, then we may not get to minTxsPerBlock after executing public functions.
910
- const minValidTxs = this.config.minValidTxsPerBlock ?? minTxs;
911
- const numTxs = buildResult.status === 'no-valid-txs' ? 0 : buildResult.numTxs;
912
- if (buildResult.status === 'no-valid-txs' || !forceCreate && numTxs < minValidTxs) {
913
- this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.slot} has too few valid txs to be proposed`, {
914
- slot: this.slot,
1160
+ if (buildResult.status === 'insufficient-valid-txs') {
1161
+ this.log.warn(`Block ${blockNumber} at index ${indexWithinCheckpoint} on slot ${this.targetSlot} has too few valid txs to be proposed`, {
1162
+ slot: this.targetSlot,
915
1163
  blockNumber,
916
- numTxs,
1164
+ numTxs: buildResult.processedCount,
917
1165
  indexWithinCheckpoint,
918
- minValidTxs,
919
- buildResult: buildResult.status
1166
+ minValidTxs
920
1167
  });
921
1168
  this.eventEmitter.emit('block-build-failed', {
922
1169
  reason: `Insufficient valid txs`,
923
- slot: this.slot
1170
+ slot: this.targetSlot
924
1171
  });
925
1172
  this.metrics.recordBlockProposalFailed('insufficient_valid_txs');
926
- return undefined;
1173
+ return {
1174
+ failure: 'insufficient-valid-txs'
1175
+ };
927
1176
  }
928
1177
  // Block creation succeeded, emit stats and metrics
929
- const { publicGas, block, publicProcessorDuration, usedTxs, usedTxBlobFields, blockBuildDuration } = buildResult;
1178
+ const { block, publicProcessorDuration, usedTxs, blockBuildDuration, numTxs } = buildResult;
930
1179
  const blockStats = {
931
1180
  eventName: 'l2-block-built',
932
1181
  duration: blockBuildDuration,
@@ -935,31 +1184,33 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
935
1184
  };
936
1185
  const blockHash = await block.hash();
937
1186
  const txHashes = block.body.txEffects.map((tx)=>tx.txHash);
938
- const manaPerSec = publicGas.l2Gas / (blockBuildDuration / 1000);
939
- this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.slot} with ${numTxs} txs`, {
1187
+ const manaPerSec = block.header.totalManaUsed.toNumberUnsafe() / (blockBuildDuration / 1000);
1188
+ this.log.info(`Built block ${block.number} at checkpoint ${this.checkpointNumber} for slot ${this.targetSlot} with ${numTxs} txs`, {
940
1189
  blockHash,
941
1190
  txHashes,
942
1191
  manaPerSec,
943
1192
  ...blockStats
944
1193
  });
1194
+ // `slot` is the target/submission slot (may be one ahead when pipelining),
1195
+ // `buildSlot` is the wall-clock slot during which the block was actually built.
945
1196
  this.eventEmitter.emit('block-proposed', {
946
1197
  blockNumber: block.number,
947
- slot: this.slot
1198
+ slot: this.targetSlot,
1199
+ buildSlot: this.slotNow
948
1200
  });
949
- this.metrics.recordBuiltBlock(blockBuildDuration, publicGas.l2Gas);
1201
+ this.metrics.recordBuiltBlock(blockBuildDuration, block.header.totalManaUsed.toNumberUnsafe(), this.targetSlot);
950
1202
  return {
951
1203
  block,
952
- usedTxs,
953
- remainingBlobFields: maxBlobFieldsForTxs - usedTxBlobFields
1204
+ usedTxs
954
1205
  };
955
1206
  } catch (err) {
956
1207
  this.eventEmitter.emit('block-build-failed', {
957
1208
  reason: err.message,
958
- slot: this.slot
1209
+ slot: this.targetSlot
959
1210
  });
960
1211
  this.log.error(`Error building block`, err, {
961
1212
  blockNumber,
962
- slot: this.slot
1213
+ slot: this.targetSlot
963
1214
  });
964
1215
  this.metrics.recordBlockProposalFailed(err.name || 'unknown_error');
965
1216
  this.metrics.recordFailedBlock();
@@ -968,7 +1219,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
968
1219
  };
969
1220
  }
970
1221
  }
971
- /** Uses the checkpoint builder to build a block, catching specific txs */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
1222
+ /** Uses the checkpoint builder to build a block, catching InsufficientValidTxsError. */ async buildSingleBlockWithCheckpointBuilder(checkpointBuilder, pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions) {
972
1223
  try {
973
1224
  const workTimer = new Timer();
974
1225
  const result = await checkpointBuilder.buildBlock(pendingTxs, blockNumber, blockTimestamp, blockBuilderOptions);
@@ -979,10 +1230,11 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
979
1230
  status: 'success'
980
1231
  };
981
1232
  } catch (err) {
982
- if (isErrorClass(err, NoValidTxsError)) {
1233
+ if (isErrorClass(err, InsufficientValidTxsError)) {
983
1234
  return {
984
1235
  failedTxs: err.failedTxs,
985
- status: 'no-valid-txs'
1236
+ processedCount: err.processedCount,
1237
+ status: 'insufficient-valid-txs'
986
1238
  };
987
1239
  }
988
1240
  throw err;
@@ -1001,14 +1253,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1001
1253
  if (startBuildingDeadline === undefined || now >= startBuildingDeadline) {
1002
1254
  return {
1003
1255
  canStartBuilding: false,
1004
- availableTxs: availableTxs
1256
+ availableTxs,
1257
+ minTxs
1005
1258
  };
1006
1259
  }
1007
1260
  // Wait a bit before checking again
1008
- this.setStateFn(SequencerState.WAITING_FOR_TXS, this.slot);
1009
- this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.slot} (have ${availableTxs} but need ${minTxs})`, {
1261
+ this.setStateFn(SequencerState.WAITING_FOR_TXS, this.targetSlot);
1262
+ this.log.verbose(`Waiting for enough txs to build block ${blockNumber} at index ${indexWithinCheckpoint} in slot ${this.targetSlot} (have ${availableTxs} but need ${minTxs})`, {
1010
1263
  blockNumber,
1011
- slot: this.slot,
1264
+ slot: this.targetSlot,
1012
1265
  indexWithinCheckpoint
1013
1266
  });
1014
1267
  await this.waitForTxsPollingInterval();
@@ -1016,9 +1269,34 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1016
1269
  }
1017
1270
  return {
1018
1271
  canStartBuilding: true,
1019
- availableTxs
1272
+ availableTxs,
1273
+ minTxs
1020
1274
  };
1021
1275
  }
1276
+ async getSignedCommitteeAttestations(broadcast) {
1277
+ const { proposal, blockProposedAt } = broadcast;
1278
+ this.setStateFn(SequencerState.COLLECTING_ATTESTATIONS, this.targetSlot);
1279
+ const attestations = await this.waitForAttestations(proposal);
1280
+ if (!attestations) {
1281
+ return undefined;
1282
+ }
1283
+ this.checkpointMetrics.recordCheckpointAttestationDelay(this.dateProvider.now() - blockProposedAt);
1284
+ // Proposer must sign over the attestations before pushing them to L1
1285
+ const signer = this.proposer ?? this.publisher.getSenderAddress();
1286
+ try {
1287
+ const attestationsSignature = await this.validatorClient.signAttestationsAndSigners(attestations, signer, this.targetSlot, this.checkpointNumber);
1288
+ return {
1289
+ attestations,
1290
+ attestationsSignature
1291
+ };
1292
+ } catch (err) {
1293
+ if (this.handleHASigningError(err, 'Attestations signature')) {
1294
+ return;
1295
+ }
1296
+ this.log.error(`Error signing attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1297
+ return undefined;
1298
+ }
1299
+ }
1022
1300
  /**
1023
1301
  * Waits for enough attestations to be collected via p2p.
1024
1302
  * This is run after all blocks for the checkpoint have been built.
@@ -1039,32 +1317,41 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1039
1317
  committee
1040
1318
  });
1041
1319
  }
1042
- const numberOfRequiredAttestations = Math.floor(committee.length * 2 / 3) + 1;
1320
+ const numberOfRequiredAttestations = computeQuorum(committee.length);
1043
1321
  if (this.config.skipCollectingAttestations) {
1044
1322
  this.log.warn('Skipping attestation collection as per config (attesting with own keys only)');
1045
- const attestations = await this.validatorClient?.collectOwnAttestations(proposal);
1323
+ const attestations = await this.validatorClient?.collectOwnAttestations(proposal, this.checkpointNumber);
1046
1324
  return new CommitteeAttestationsAndSigners(orderAttestations(attestations ?? [], committee));
1047
1325
  }
1048
- const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getMaxAllowedTime(SequencerState.PUBLISHING_CHECKPOINT) : this.l1Constants.slotDuration;
1326
+ const attestationTimeAllowed = this.config.enforceTimeTable ? this.timetable.getCheckpointAttestationDeadline() : this.l1Constants.slotDuration;
1049
1327
  const attestationDeadline = new Date((this.getSlotStartBuildTimestamp() + attestationTimeAllowed) * 1000);
1050
1328
  this.metrics.recordRequiredAttestations(numberOfRequiredAttestations, attestationTimeAllowed);
1051
1329
  const collectAttestationsTimer = new Timer();
1052
1330
  let collectedAttestationsCount = 0;
1053
1331
  try {
1054
- const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline);
1332
+ const attestations = await this.validatorClient.collectAttestations(proposal, numberOfRequiredAttestations, attestationDeadline, this.checkpointNumber);
1055
1333
  collectedAttestationsCount = attestations.length;
1334
+ // Trim attestations to minimum required to save L1 calldata gas
1335
+ const localAddresses = this.validatorClient.getValidatorAddresses();
1336
+ const trimmed = trimAttestations(attestations, numberOfRequiredAttestations, this.attestorAddress, localAddresses);
1337
+ if (trimmed.length < attestations.length) {
1338
+ this.log.debug(`Trimmed attestations from ${attestations.length} to ${trimmed.length} for L1 submission`);
1339
+ }
1056
1340
  // Rollup contract requires that the signatures are provided in the order of the committee
1057
- const sorted = orderAttestations(attestations, committee);
1341
+ const sorted = orderAttestations(trimmed, committee);
1058
1342
  // Manipulate the attestations if we've been configured to do so
1059
- if (this.config.injectFakeAttestation || this.config.shuffleAttestationOrdering) {
1343
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation || this.config.shuffleAttestationOrdering) {
1060
1344
  return this.manipulateAttestations(proposal.slotNumber, epoch, seed, committee, sorted);
1061
1345
  }
1062
1346
  return new CommitteeAttestationsAndSigners(sorted);
1063
1347
  } catch (err) {
1064
1348
  if (err && err instanceof AttestationTimeoutError) {
1065
1349
  collectedAttestationsCount = err.collectedCount;
1350
+ this.log.error(`Timeout while waiting for attestations for checkpoint proposal at slot ${proposal.slotNumber} (collected ${collectedAttestationsCount}/${numberOfRequiredAttestations})`, err);
1351
+ } else {
1352
+ this.log.error(`Error collecting attestations for checkpoint proposal at slot ${proposal.slotNumber}`, err);
1066
1353
  }
1067
- throw err;
1354
+ return undefined;
1068
1355
  } finally{
1069
1356
  this.metrics.recordCollectedAttestations(collectedAttestationsCount, collectAttestationsTimer.ms());
1070
1357
  }
@@ -1073,7 +1360,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1073
1360
  // Compute the proposer index in the committee, since we dont want to tweak it.
1074
1361
  // Otherwise, the L1 rollup contract will reject the block outright.
1075
1362
  const proposerIndex = Number(this.epochCache.computeProposerIndex(slotNumber, epoch, seed, BigInt(committee.length)));
1076
- if (this.config.injectFakeAttestation) {
1363
+ if (this.config.injectFakeAttestation || this.config.injectHighSValueAttestation || this.config.injectUnrecoverableSignatureAttestation) {
1077
1364
  // Find non-empty attestations that are not from the proposer
1078
1365
  const nonProposerIndices = [];
1079
1366
  for(let i = 0; i < attestations.length; i++){
@@ -1083,8 +1370,16 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1083
1370
  }
1084
1371
  if (nonProposerIndices.length > 0) {
1085
1372
  const targetIndex = nonProposerIndices[randomInt(nonProposerIndices.length)];
1086
- this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1087
- unfreeze(attestations[targetIndex]).signature = Signature.random();
1373
+ if (this.config.injectHighSValueAttestation) {
1374
+ this.log.warn(`Injecting high-s value attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1375
+ unfreeze(attestations[targetIndex]).signature = flipSignature(attestations[targetIndex].signature);
1376
+ } else if (this.config.injectUnrecoverableSignatureAttestation) {
1377
+ this.log.warn(`Injecting unrecoverable signature attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1378
+ unfreeze(attestations[targetIndex]).signature = generateUnrecoverableSignature();
1379
+ } else {
1380
+ this.log.warn(`Injecting fake attestation in checkpoint for slot ${slotNumber} at index ${targetIndex}`);
1381
+ unfreeze(attestations[targetIndex]).signature = generateRecoverableSignature();
1382
+ }
1088
1383
  }
1089
1384
  return new CommitteeAttestationsAndSigners(attestations);
1090
1385
  }
@@ -1093,14 +1388,25 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1093
1388
  const shuffled = [
1094
1389
  ...attestations
1095
1390
  ];
1096
- const [i, j] = [
1097
- (proposerIndex + 1) % shuffled.length,
1098
- (proposerIndex + 2) % shuffled.length
1099
- ];
1100
- const valueI = shuffled[i];
1101
- const valueJ = shuffled[j];
1102
- shuffled[i] = valueJ;
1103
- shuffled[j] = valueI;
1391
+ // Find two non-proposer positions that both have non-empty signatures to swap.
1392
+ // This ensures the bitmap doesn't change, so the MaliciousCommitteeAttestationsAndSigners
1393
+ // signers array stays correctly aligned with L1's committee reconstruction.
1394
+ const swappable = [];
1395
+ for(let k = 0; k < shuffled.length; k++){
1396
+ if (!shuffled[k].signature.isEmpty() && k !== proposerIndex) {
1397
+ swappable.push(k);
1398
+ }
1399
+ }
1400
+ if (swappable.length >= 2) {
1401
+ const [i, j] = [
1402
+ swappable[0],
1403
+ swappable[1]
1404
+ ];
1405
+ [shuffled[i], shuffled[j]] = [
1406
+ shuffled[j],
1407
+ shuffled[i]
1408
+ ];
1409
+ }
1104
1410
  const signers = new CommitteeAttestationsAndSigners(attestations).getSigners();
1105
1411
  return new MaliciousCommitteeAttestationsAndSigners(shuffled, signers);
1106
1412
  }
@@ -1119,8 +1425,12 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1119
1425
  * Adds the proposed block to the archiver so it's available via P2P.
1120
1426
  * Gossip doesn't echo messages back to the sender, so the proposer's archiver/world-state
1121
1427
  * would never receive its own block without this explicit sync.
1428
+ *
1429
+ * In fisherman mode we skip this push: the fisherman builds blocks locally for validation
1430
+ * and fee analysis only, and pushing them to the archiver causes spurious reorg cascades
1431
+ * whenever the real proposer's block arrives from L1.
1122
1432
  */ async syncProposedBlockToArchiver(block) {
1123
- if (this.config.skipPushProposedBlocksToArchiver !== false) {
1433
+ if (this.config.skipPushProposedBlocksToArchiver || this.config.fishermanMode) {
1124
1434
  this.log.warn(`Skipping push of proposed block ${block.number} to archiver`, {
1125
1435
  blockNumber: block.number,
1126
1436
  slot: block.header.globalVariables.slotNumber
@@ -1136,19 +1446,19 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1136
1446
  /** Runs fee analysis and logs checkpoint outcome as fisherman */ async handleCheckpointEndAsFisherman(checkpoint) {
1137
1447
  // Perform L1 fee analysis before clearing requests
1138
1448
  // The callback is invoked asynchronously after the next block is mined
1139
- const feeAnalysis = await this.publisher.analyzeL1Fees(this.slot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1449
+ const feeAnalysis = await this.publisher.analyzeL1Fees(this.targetSlot, (analysis)=>this.metrics.recordFishermanFeeAnalysis(analysis));
1140
1450
  if (checkpoint) {
1141
- this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.slot}`, {
1451
+ this.log.info(`Validation checkpoint building SUCCEEDED for slot ${this.targetSlot}`, {
1142
1452
  ...checkpoint.toCheckpointInfo(),
1143
1453
  ...checkpoint.getStats(),
1144
1454
  feeAnalysisId: feeAnalysis?.id
1145
1455
  });
1146
1456
  } else {
1147
- this.log.warn(`Validation block building FAILED for slot ${this.slot}`, {
1148
- slot: this.slot,
1457
+ this.log.warn(`Validation block building FAILED for slot ${this.targetSlot}`, {
1458
+ slot: this.targetSlot,
1149
1459
  feeAnalysisId: feeAnalysis?.id
1150
1460
  });
1151
- this.metrics.recordBlockProposalFailed('block_build_failed');
1461
+ this.metrics.recordCheckpointProposalFailed('block_build_failed');
1152
1462
  }
1153
1463
  this.publisher.clearPendingRequests();
1154
1464
  }
@@ -1156,15 +1466,15 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1156
1466
  * Helper to handle HA double-signing errors. Returns true if the error was handled (caller should yield).
1157
1467
  */ handleHASigningError(err, errorContext) {
1158
1468
  if (err instanceof DutyAlreadySignedError) {
1159
- this.log.info(`${errorContext} for slot ${this.slot} already signed by another HA node, yielding`, {
1160
- slot: this.slot,
1469
+ this.log.info(`${errorContext} for slot ${this.targetSlot} already signed by another HA node, yielding`, {
1470
+ slot: this.targetSlot,
1161
1471
  signedByNode: err.signedByNode
1162
1472
  });
1163
1473
  return true;
1164
1474
  }
1165
1475
  if (err instanceof SlashingProtectionError) {
1166
- this.log.info(`${errorContext} for slot ${this.slot} blocked by slashing protection, yielding`, {
1167
- slot: this.slot,
1476
+ this.log.info(`${errorContext} for slot ${this.targetSlot} blocked by slashing protection, yielding`, {
1477
+ slot: this.targetSlot,
1168
1478
  existingMessageHash: err.existingMessageHash,
1169
1479
  attemptedMessageHash: err.attemptedMessageHash
1170
1480
  });
@@ -1181,7 +1491,7 @@ _dec = trackSpan('CheckpointProposalJob.execute'), _dec1 = trackSpan('Checkpoint
1181
1491
  await sleep(TXS_POLLING_MS);
1182
1492
  }
1183
1493
  getSlotStartBuildTimestamp() {
1184
- return getSlotStartBuildTimestamp(this.slot, this.l1Constants);
1494
+ return getSlotStartBuildTimestamp(this.slotNow, this.l1Constants);
1185
1495
  }
1186
1496
  getSecondsIntoSlot() {
1187
1497
  const slotStartTimestamp = this.getSlotStartBuildTimestamp();