@aztec/p2p 0.0.1-commit.f2ce05ee → 0.0.1-commit.f5a9928

package/dest/services/peer-manager/peer_scoring.js

@@ -1,5 +1,6 @@
 import { median } from '@aztec/foundation/collection';
 import { createLogger } from '@aztec/foundation/log';
+import { DateProvider } from '@aztec/foundation/timer';
 import { PeerErrorSeverity } from '@aztec/stdlib/p2p';
 import { Attributes, Metrics, createUpDownCounterWithDefault, getTelemetryClient } from '@aztec/telemetry-client';
 /**
@@ -39,15 +40,31 @@ export var PeerScoreState = /*#__PURE__*/ function(PeerScoreState) {
  */ // TODO: move into config / constants
 const MIN_SCORE_BEFORE_BAN = -100;
 const MIN_SCORE_BEFORE_DISCONNECT = -50;
+const SCORE_CLEANUP_THRESHOLD = 0.1;
 export class PeerScoring {
-    logger = createLogger('p2p:peer-scoring');
-    scores = new Map();
-    lastUpdateTime = new Map();
-    decayInterval = 1000 * 60;
-    decayFactor = 0.9;
+    dateProvider;
+    logger;
+    scores;
+    lastUpdateTime;
+    decayInterval;
+    decayFactor;
     peerPenalties;
     peerStateCounter;
-    constructor(config, telemetry = getTelemetryClient()){
+    /** Active bans, keyed by peer id. Held in memory only, so they are cleared on restart. */ bannedPeers;
+    /**
+   * How long a peer remains banned once its score crosses MIN_SCORE_BEFORE_BAN. While banned, the
+   * peer's ban score is returned by getScore regardless of decay, so it cannot recover its way out
+   * of the ban early. After the ban expires the live (decayed) score takes over again.
+   */ banDurationMs;
+    constructor(config, telemetry = getTelemetryClient(), dateProvider = new DateProvider()){
+        this.dateProvider = dateProvider;
+        this.logger = createLogger('p2p:peer-scoring');
+        this.scores = new Map();
+        this.lastUpdateTime = new Map();
+        this.decayInterval = 1000 * 60;
+        this.decayFactor = 0.9;
+        this.bannedPeers = new Map();
+        this.banDurationMs = config.peerBanDurationSeconds * 1000;
         const orderedValues = config.peerPenaltyValues?.sort((a, b)=>a - b);
         this.peerPenalties = {
             [PeerErrorSeverity.HighToleranceError]: orderedValues?.[0] ?? DefaultPeerPenalties[PeerErrorSeverity.HighToleranceError],
@@ -71,7 +88,7 @@ export class PeerScoring {
         return newScore;
     }
     updateScore(peerId, scoreDelta) {
-        const currentTime = Date.now();
+        const currentTime = this.dateProvider.now();
         const lastUpdate = this.lastUpdateTime.get(peerId) || currentTime;
         const timePassed = currentTime - lastUpdate;
         const decayPeriods = Math.floor(timePassed / this.decayInterval);
@@ -82,26 +99,93 @@ export class PeerScoring {
         currentScore += scoreDelta;
         this.scores.set(peerId, currentScore);
         this.lastUpdateTime.set(peerId, currentTime);
+        this.maybeBanPeer(peerId, currentScore);
         return currentScore;
     }
+    /**
+   * Records a ban for a peer whose score has crossed the ban threshold, with an expiry banDurationMs
+   * in the future. No-op if the score is above the threshold or the peer is already serving an active
+   * ban (an existing ban is not extended; the original window stands). A previously expired ban does
+   * not block a fresh one — getActiveBanScore prunes it first.
+   */ maybeBanPeer(peerId, score) {
+        if (score >= MIN_SCORE_BEFORE_BAN || this.getActiveBanScore(peerId) !== undefined) {
+            return;
+        }
+        const record = {
+            score,
+            expiry: this.dateProvider.now() + this.banDurationMs
+        };
+        this.bannedPeers.set(peerId, record);
+        this.logger.verbose(`Banning peer ${peerId} until ${new Date(record.expiry).toISOString()}`, {
+            peerId,
+            score,
+            expiry: record.expiry
+        });
+    }
     decayAllScores() {
-        const currentTime = Date.now();
+        const currentTime = this.dateProvider.now();
         for (const [peerId, lastUpdate] of this.lastUpdateTime.entries()){
             const timePassed = currentTime - lastUpdate;
             const decayPeriods = Math.floor(timePassed / this.decayInterval);
             if (decayPeriods > 0) {
                 let score = this.scores.get(peerId) || 0;
                 score *= Math.pow(this.decayFactor, decayPeriods);
-                this.scores.set(peerId, score);
-                this.lastUpdateTime.set(peerId, currentTime);
+                if (Math.abs(score) < SCORE_CLEANUP_THRESHOLD) {
+                    this.scores.delete(peerId);
+                    this.lastUpdateTime.delete(peerId);
+                } else {
+                    this.scores.set(peerId, score);
+                    this.lastUpdateTime.set(peerId, currentTime);
+                }
             }
         }
     }
+    /**
+   * Removes bans whose window has elapsed. Expired bans are otherwise only pruned lazily when their
+   * peer's score is next queried, so a banned peer that disconnects and is never queried again would
+   * linger in the map. Called periodically (per heartbeat) to bound the ban map's size.
+   */ pruneExpiredBans() {
+        const now = this.dateProvider.now();
+        const expired = [
+            ...this.bannedPeers.entries()
+        ].filter(([, ban])=>ban.expiry <= now).map(([peerId])=>peerId);
+        for (const peerId of expired){
+            this.bannedPeers.delete(peerId);
+        }
+    }
+    /** Resets all peer scores. Useful for benchmarks to prevent cross-case contamination. */ resetAllScores() {
+        this.scores.clear();
+        this.lastUpdateTime.clear();
+        this.bannedPeers.clear();
+    }
+    removePeer(peerId) {
+        this.scores.delete(peerId);
+        this.lastUpdateTime.delete(peerId);
+    }
+    /**
+   * The single source of truth for whether a peer is banned. Returns the ban score while the ban is
+   * active, or undefined if the peer is not banned. A ban that has expired is lazily lifted before
+   * returning undefined, so callers never see a stale ban.
+   */ getActiveBanScore(peerId) {
+        const ban = this.bannedPeers.get(peerId);
+        if (ban === undefined) {
+            return undefined;
+        }
+        if (ban.expiry > this.dateProvider.now()) {
+            return ban.score;
+        }
+        // Ban expired: lift it so the peer can recover.
+        this.bannedPeers.delete(peerId);
+        return undefined;
+    }
     getScore(peerId) {
-        return this.scores.get(peerId) || 0;
+        // While a ban is active its ban score is returned regardless of how the live score has decayed,
+        // so the peer stays banned for the full duration.
+        return this.getActiveBanScore(peerId) ?? this.scores.get(peerId) ?? 0;
     }
     getScoreState(peerId) {
-        // TODO(#11329): permanently store banned peers?
+        // A banned peer stays banned for the full ban duration regardless of score decay (see getScore /
+        // maybeBanPeer), rather than silently recovering once its decayed score is cleaned up.
         const score = this.getScore(peerId);
         if (score < MIN_SCORE_BEFORE_BAN) {
             return 0;
@@ -117,7 +201,12 @@ export class PeerScoring {
             disconnect: 0,
             banned: 0
         };
-        for (const peerId of this.scores.keys()){
+        // Include banned peers whose live score may have been decayed away but whose ban is still active.
+        const peerIds = new Set([
+            ...this.scores.keys(),
+            ...this.bannedPeers.keys()
+        ]);
+        for (const peerId of peerIds){
             const state = this.getScoreState(peerId);
             switch(state){
                 case 2:

package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts

@@ -1,27 +1,26 @@
 import { type Logger } from '@aztec/foundation/log';
 import { DateProvider } from '@aztec/foundation/timer';
-import { Tx, TxHash } from '@aztec/stdlib/tx';
+import { Tx } from '@aztec/stdlib/tx';
 import type { PeerId } from '@libp2p/interface';
+import type { IRequestTracker } from '../../tx_collection/request_tracker.js';
 import { type BlockTxsSource } from '.././protocols/index.js';
 import type { BatchTxRequesterLibP2PService, BatchTxRequesterOptions } from './interface.js';
 export declare class BatchTxRequester {
+    private readonly requestTracker;
     private readonly blockTxsSource;
     private readonly pinnedPeer;
-    private readonly timeoutMs;
     private readonly p2pService;
     private readonly logger;
-    private readonly dateProvider;
     private readonly opts;
     private readonly peers;
     private readonly txsMetadata;
-    private readonly deadline;
     private readonly smartRequesterSemaphore;
     private readonly txQueue;
     private readonly txValidator;
     private readonly smartParallelWorkerCount;
     private readonly dumbParallelWorkerCount;
     private readonly txBatchSize;
-    constructor(missingTxs: TxHash[], blockTxsSource: BlockTxsSource, pinnedPeer: PeerId | undefined, timeoutMs: number, p2pService: BatchTxRequesterLibP2PService, logger?: Logger, dateProvider?: DateProvider, opts?: BatchTxRequesterOptions);
+    constructor(requestTracker: IRequestTracker, blockTxsSource: BlockTxsSource, pinnedPeer: PeerId | undefined, p2pService: BatchTxRequesterLibP2PService, logger?: Logger, dateProvider?: DateProvider, opts?: BatchTxRequesterOptions);
     run(): AsyncGenerator<Tx, Tx | undefined, unknown>;
     static collectAllTxs(generator: AsyncGenerator<Tx, Tx | undefined, unknown>): Promise<Tx[]>;
     private pinnedPeerRequester;
@@ -34,14 +33,12 @@ export declare class BatchTxRequester {
     private handleSuccessResponseFromPeer;
     private handleReceivedTxs;
     private decideIfPeerIsSmart;
-    private isBlockResponseValid;
     private peerHasSomeTxsWeAreMissing;
     private markTxsPeerHas;
     private extractHashesPeerHasFromResponse;
     private makeRoundRobinIndexer;
-    private fetchedAllTxs;
     private shouldStop;
     private unlockSmartRequesterSemaphores;
     private sleepClampedToDeadline;
 }
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmF0Y2hfdHhfcmVxdWVzdGVyLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi8uLi9zcmMvc2VydmljZXMvcmVxcmVzcC9iYXRjaC10eC1yZXF1ZXN0ZXIvYmF0Y2hfdHhfcmVxdWVzdGVyLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUVBLE9BQU8sRUFBRSxLQUFLLE1BQU0sRUFBZ0IsTUFBTSx1QkFBdUIsQ0FBQztBQUdsRSxPQUFPLEVBQUUsWUFBWSxFQUFrQixNQUFNLHlCQUF5QixDQUFDO0FBRXZFLE9BQU8sRUFBRSxFQUFFLEVBQVcsTUFBTSxFQUFFLE1BQU0sa0JBQWtCLENBQUM7QUFFdkQsT0FBTyxLQUFLLEVBQUUsTUFBTSxFQUFFLE1BQU0sbUJBQW1CLENBQUM7QUFJaEQsT0FBTyxFQUFxQyxLQUFLLGNBQWMsRUFBRSxNQUFNLHlCQUF5QixDQUFDO0FBUWpHLE9BQU8sS0FBSyxFQUFFLDZCQUE2QixFQUFFLHVCQUF1QixFQUF5QixNQUFNLGdCQUFnQixDQUFDO0FBc0JwSCxxQkFBYSxnQkFBZ0I7SUFDM0IsT0FBTyxDQUFDLFFBQVEsQ0FBQyxjQUFjLENBQWlCO0lBQ2hELE9BQU8sQ0FBQyxRQUFRLENBQUMsVUFBVSxDQUFxQjtJQUNoRCxPQUFPLENBQUMsUUFBUSxDQUFDLFNBQVMsQ0FBUztJQUNuQyxPQUFPLENBQUMsUUFBUSxDQUFDLFVBQVUsQ0FBZ0M7SUFDM0QsT0FBTyxDQUFDLFFBQVEsQ0FBQyxNQUFNLENBQVM7SUFDaEMsT0FBTyxDQUFDLFFBQVEsQ0FBQyxZQUFZLENBQWU7SUFDNUMsT0FBTyxDQUFDLFFBQVEsQ0FBQyxJQUFJLENBQTBCO0lBQy9DLE9BQU8sQ0FBQyxRQUFRLENBQUMsS0FBSyxDQUFrQjtJQUN4QyxPQUFPLENBQUMsUUFBUSxDQUFDLFdBQVcsQ0FBd0I7SUFDcEQsT0FBTyxDQUFDLFFBQVEsQ0FBQyxRQUFRLENBQVM7SUFDbEMsT0FBTyxDQUFDLFFBQVEsQ0FBQyx1QkFBdUIsQ0FBYTtJQUNyRCxPQUFPLENBQUMsUUFBUSxDQUFDLE9BQU8sQ0FBc0I7SUFDOUMsT0FBTyxDQUFDLFFBQVEsQ0FBQyxXQUFXLENBQTJCO0lBQ3ZELE9BQU8sQ0FBQyxRQUFRLENBQUMsd0JBQXdCLENBQVM7SUFDbEQsT0FBTyxDQUFDLFFBQVEsQ0FBQyx1QkFBdUIsQ0FBUztJQUNqRCxPQUFPLENBQUMsUUFBUSxDQUFDLFdBQVcsQ0FBUztJQUVyQyxZQUNFLFVBQVUsRUFBRSxNQUFNLEVBQUUsRUFDcEIsY0FBYyxFQUFFLGNBQWMsRUFDOUIsVUFBVSxFQUFFLE1BQU0sR0FBRyxTQUFTLEVBQzlCLFNBQVMsRUFBRSxNQUFNLEVBQ2pCLFVBQVUsRUFBRSw2QkFBNkIsRUFDekMsTUFBTSxDQUFDLEVBQUUsTUFBTSxFQUNmLFlBQVksQ0FBQyxFQUFFLFlBQVksRUFDM0IsSUFBSSxDQUFDLEVBQUUsdUJBQXVCLEVBbUMvQjtJQUthLEdBQUcsSUFBSSxjQUFjLENBQUMsRUFBRSxFQUFFLEVBQUUsR0FBRyxTQUFTLEVBQUUsT0FBTyxDQUFDLENBNkMvRDtJQUtELE9BQW9CLGFBQWEsQ0FBQyxTQUFTLEVBQUUsY0FBYyxDQUFDLEVBQUUsRUFBRSxFQUFFLEdBQUcsU0FBUyxFQUFFLE9BQU8sQ0FBQyxHQUFHLE9BQU8sQ0FBQyxFQUFFLEVBQUUsQ0FBQyxDQVN2RztZQVVhLG1CQUFtQjtZQWtEbkIsYUFBYTtZQXlEYixjQUFjO1lBZ0RkLGNBQWM7WUF3Q2QsZUFBZTtZQWtGZixjQUFjO0lBbUM1QixPQUFPLENBQUMsMEJBQTBCO1lBaUJwQiw2QkFBNkI7WUFZN0IsaUJBQWlCO0lBcUQvQixPQUFPLENBQUMsbUJBQW1CO0lBa0MzQixPQUFPLENBQUMsb0JBQW9CO0lBTTVCLE9BQU8sQ0FBQywwQkFBMEI7SUFLbEMsT0FBTyxDQUFDLGNBQWM7SUFNdEIsT0FBTyxDQUFDLGdDQUFnQztJQWdCeEMsT0FBTyxDQUFDLHFCQUFxQjtJQXVCN0IsT0FBTyxDQUFDLGFBQWE7SUFhckIsT0FBTyxDQUFDLFVBQVU7SUFhbEIsT0FBTyxDQUFDLDhCQUE4QjtZQVV4QixzQkFBc0I7Q0FPckMifQ==
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmF0Y2hfdHhfcmVxdWVzdGVyLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi8uLi9zcmMvc2VydmljZXMvcmVxcmVzcC9iYXRjaC10eC1yZXF1ZXN0ZXIvYmF0Y2hfdHhfcmVxdWVzdGVyLnRzIl0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiJBQUNBLE9BQU8sRUFBRSxLQUFLLE1BQU0sRUFBZ0IsTUFBTSx1QkFBdUIsQ0FBQztBQUdsRSxPQUFPLEVBQUUsWUFBWSxFQUFFLE1BQU0seUJBQXlCLENBQUM7QUFFdkQsT0FBTyxFQUFFLEVBQUUsRUFBcUMsTUFBTSxrQkFBa0IsQ0FBQztBQUV6RSxPQUFPLEtBQUssRUFBRSxNQUFNLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUdoRCxPQUFPLEtBQUssRUFBRSxlQUFlLEVBQUUsTUFBTSx3Q0FBd0MsQ0FBQztBQUU5RSxPQUFPLEVBQXFDLEtBQUssY0FBYyxFQUFFLE1BQU0seUJBQXlCLENBQUM7QUFRakcsT0FBTyxLQUFLLEVBQUUsNkJBQTZCLEVBQUUsdUJBQXVCLEVBQXlCLE1BQU0sZ0JBQWdCLENBQUM7QUFzQnBILHFCQUFhLGdCQUFnQjtJQUMzQixPQUFPLENBQUMsUUFBUSxDQUFDLGNBQWMsQ0FBa0I7SUFDakQsT0FBTyxDQUFDLFFBQVEsQ0FBQyxjQUFjLENBQWlCO0lBQ2hELE9BQU8sQ0FBQyxRQUFRLENBQUMsVUFBVSxDQUFxQjtJQUNoRCxPQUFPLENBQUMsUUFBUSxDQUFDLFVBQVUsQ0FBZ0M7SUFDM0QsT0FBTyxDQUFDLFFBQVEsQ0FBQyxNQUFNLENBQVM7SUFDaEMsT0FBTyxDQUFDLFFBQVEsQ0FBQyxJQUFJLENBQTBCO0lBQy9DLE9BQU8sQ0FBQyxRQUFRLENBQUMsS0FBSyxDQUFrQjtJQUN4QyxPQUFPLENBQUMsUUFBUSxDQUFDLFdBQVcsQ0FBd0I7SUFDcEQsT0FBTyxDQUFDLFFBQVEsQ0FBQyx1QkFBdUIsQ0FBYTtJQUNyRCxPQUFPLENBQUMsUUFBUSxDQUFDLE9BQU8sQ0FBc0I7SUFDOUMsT0FBTyxDQUFDLFFBQVEsQ0FBQyxXQUFXLENBQWM7SUFDMUMsT0FBTyxDQUFDLFFBQVEsQ0FBQyx3QkFBd0IsQ0FBUztJQUNsRCxPQUFPLENBQUMsUUFBUSxDQUFDLHVCQUF1QixDQUFTO0lBQ2pELE9BQU8sQ0FBQyxRQUFRLENBQUMsV0FBVyxDQUFTO0lBRXJDLFlBQ0UsY0FBYyxFQUFFLGVBQWUsRUFDL0IsY0FBYyxFQUFFLGNBQWMsRUFDOUIsVUFBVSxFQUFFLE1BQU0sR0FBRyxTQUFTLEVBQzlCLFVBQVUsRUFBRSw2QkFBNkIsRUFDekMsTUFBTSxDQUFDLEVBQUUsTUFBTSxFQUNmLFlBQVksQ0FBQyxFQUFFLFlBQVksRUFDM0IsSUFBSSxDQUFDLEVBQUUsdUJBQXVCLEVBK0IvQjtJQUthLEdBQUcsSUFBSSxjQUFjLENBQUMsRUFBRSxFQUFFLEVBQUUsR0FBRyxTQUFTLEVBQUUsT0FBTyxDQUFDLENBbUMvRDtJQUtELE9BQW9CLGFBQWEsQ0FBQyxTQUFTLEVBQUUsY0FBYyxDQUFDLEVBQUUsRUFBRSxFQUFFLEdBQUcsU0FBUyxFQUFFLE9BQU8sQ0FBQyxHQUFHLE9BQU8sQ0FBQyxFQUFFLEVBQUUsQ0FBQyxDQVN2RztZQVVhLG1CQUFtQjtZQWtEbkIsYUFBYTtZQWtEYixjQUFjO1lBZ0RkLGNBQWM7WUErQmQsZUFBZTtZQTRFZixjQUFjO0lBNkM1QixPQUFPLENBQUMsMEJBQTBCO1lBc0JwQiw2QkFBNkI7WUFZN0IsaUJBQWlCO0lBd0QvQixPQUFPLENBQUMsbUJBQW1CO0lBZ0MzQixPQUFPLENBQUMsMEJBQTBCO0lBUWxDLE9BQU8sQ0FBQyxjQUFjO0lBTXRCLE9BQU8sQ0FBQyxnQ0FBZ0M7SUFVeEMsT0FBTyxDQUFDLHFCQUFxQjtJQXdCN0IsT0FBTyxDQUFDLFVBQVU7SUFZbEIsT0FBTyxDQUFDLDhCQUE4QjtZQVV4QixzQkFBc0I7Q0FNckMifQ==

package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"batch_tx_requester.d.ts","sourceRoot":"","sources":["../../../../src/services/reqresp/batch-tx-requester/batch_tx_requester.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAGlE,OAAO,EAAE,YAAY,EAAkB,MAAM,yBAAyB,CAAC;AAEvE,OAAO,EAAE,EAAE,EAAW,MAAM,EAAE,MAAM,kBAAkB,CAAC;AAEvD,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,mBAAmB,CAAC;AAIhD,OAAO,EAAqC,KAAK,cAAc,EAAE,MAAM,yBAAyB,CAAC;AAQjG,OAAO,KAAK,EAAE,6BAA6B,EAAE,uBAAuB,EAAyB,MAAM,gBAAgB,CAAC;AAsBpH,qBAAa,gBAAgB;IAC3B,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAiB;IAChD,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAqB;IAChD,OAAO,CAAC,QAAQ,CAAC,SAAS,CAAS;IACnC,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAgC;IAC3D,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAS;IAChC,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAe;IAC5C,OAAO,CAAC,QAAQ,CAAC,IAAI,CAA0B;IAC/C,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAkB;IACxC,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAwB;IACpD,OAAO,CAAC,QAAQ,CAAC,QAAQ,CAAS;IAClC,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAa;IACrD,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAsB;IAC9C,OAAO,CAAC,QAAQ,CAAC,WAAW,CAA2B;IACvD,OAAO,CAAC,QAAQ,CAAC,wBAAwB,CAAS;IAClD,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAS;IACjD,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAS;IAErC,YACE,UAAU,EAAE,MAAM,EAAE,EACpB,cAAc,EAAE,cAAc,EAC9B,UAAU,EAAE,MAAM,GAAG,SAAS,EAC9B,SAAS,EAAE,MAAM,EACjB,UAAU,EAAE,6BAA6B,EACzC,MAAM,CAAC,EAAE,MAAM,EACf,YAAY,CAAC,EAAE,YAAY,EAC3B,IAAI,CAAC,EAAE,uBAAuB,EAmC/B;IAKa,GAAG,IAAI,cAAc,CAAC,EAAE,EAAE,EAAE,GAAG,SAAS,EAAE,OAAO,CAAC,CA6C/D;IAKD,OAAoB,aAAa,CAAC,SAAS,EAAE,cAAc,CAAC,EAAE,EAAE,EAAE,GAAG,SAAS,EAAE,OAAO,CAAC,GAAG,OAAO,CAAC,EAAE,EAAE,CAAC,CASvG;YAUa,mBAAmB;YAkDnB,aAAa;YAyDb,cAAc;YAgDd,cAAc;YAwCd,eAAe;YAkFf,cAAc;IAmC5B,OAAO,CAAC,0BAA0B;YAiBpB,6BAA6B;YAY7B,iBAAiB;IAqD/B,OAAO,CAAC,mBAAmB;IAkC3B,OAAO,CAAC,oBAAoB;IAM5B,OAAO,CAAC,0BAA0B;IAKlC,OAAO,CAAC,cAAc;IAMtB,OAAO,CAAC,gCAAgC;IAgBxC,OAAO,CAAC,qBAAqB;IAuB7B,OAAO,CAAC,aAAa;IAarB,OAAO,CAAC,UAAU;IAalB,OAAO,CAAC,8BAA8B;YAUxB,sBAAsB;CAOrC"}
+{"version":3,"file":"batch_tx_requester.d.ts","sourceRoot":"","sources":["../../../../src/services/reqresp/batch-tx-requester/batch_tx_requester.ts"],"names":[],"mappings":"AACA,OAAO,EAAE,KAAK,MAAM,EAAgB,MAAM,uBAAuB,CAAC;AAGlE,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAEvD,OAAO,EAAE,EAAE,EAAqC,MAAM,kBAAkB,CAAC;AAEzE,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,mBAAmB,CAAC;AAGhD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,wCAAwC,CAAC;AAE9E,OAAO,EAAqC,KAAK,cAAc,EAAE,MAAM,yBAAyB,CAAC;AAQjG,OAAO,KAAK,EAAE,6BAA6B,EAAE,uBAAuB,EAAyB,MAAM,gBAAgB,CAAC;AAsBpH,qBAAa,gBAAgB;IAC3B,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAkB;IACjD,OAAO,CAAC,QAAQ,CAAC,cAAc,CAAiB;IAChD,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAqB;IAChD,OAAO,CAAC,QAAQ,CAAC,UAAU,CAAgC;IAC3D,OAAO,CAAC,QAAQ,CAAC,MAAM,CAAS;IAChC,OAAO,CAAC,QAAQ,CAAC,IAAI,CAA0B;IAC/C,OAAO,CAAC,QAAQ,CAAC,KAAK,CAAkB;IACxC,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAwB;IACpD,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAa;IACrD,OAAO,CAAC,QAAQ,CAAC,OAAO,CAAsB;IAC9C,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAc;IAC1C,OAAO,CAAC,QAAQ,CAAC,wBAAwB,CAAS;IAClD,OAAO,CAAC,QAAQ,CAAC,uBAAuB,CAAS;IACjD,OAAO,CAAC,QAAQ,CAAC,WAAW,CAAS;IAErC,YACE,cAAc,EAAE,eAAe,EAC/B,cAAc,EAAE,cAAc,EAC9B,UAAU,EAAE,MAAM,GAAG,SAAS,EAC9B,UAAU,EAAE,6BAA6B,EACzC,MAAM,CAAC,EAAE,MAAM,EACf,YAAY,CAAC,EAAE,YAAY,EAC3B,IAAI,CAAC,EAAE,uBAAuB,EA+B/B;IAKa,GAAG,IAAI,cAAc,CAAC,EAAE,EAAE,EAAE,GAAG,SAAS,EAAE,OAAO,CAAC,CAmC/D;IAKD,OAAoB,aAAa,CAAC,SAAS,EAAE,cAAc,CAAC,EAAE,EAAE,EAAE,GAAG,SAAS,EAAE,OAAO,CAAC,GAAG,OAAO,CAAC,EAAE,EAAE,CAAC,CASvG;YAUa,mBAAmB;YAkDnB,aAAa;YAkDb,cAAc;YAgDd,cAAc;YA+Bd,eAAe;YA4Ef,cAAc;IA6C5B,OAAO,CAAC,0BAA0B;YAsBpB,6BAA6B;YAY7B,iBAAiB;IAwD/B,OAAO,CAAC,mBAAmB;IAgC3B,OAAO,CAAC,0BAA0B;IAQlC,OAAO,CAAC,cAAc;IAMtB,OAAO,CAAC,gCAAgC;IAUxC,OAAO,CAAC,qBAAqB;IAwB7B,OAAO,CAAC,UAAU;IAYlB,OAAO,CAAC,8BAA8B;YAUxB,sBAAsB;CAMrC"}

package/dest/services/reqresp/batch-tx-requester/batch_tx_requester.js

@@ -1,19 +1,18 @@
 import { chunkWrapAround } from '@aztec/foundation/collection';
-import { TimeoutError } from '@aztec/foundation/error';
 import { createLogger } from '@aztec/foundation/log';
 import { FifoMemoryQueue, Semaphore } from '@aztec/foundation/queue';
 import { sleep } from '@aztec/foundation/sleep';
-import { DateProvider, executeTimeout } from '@aztec/foundation/timer';
+import { DateProvider } from '@aztec/foundation/timer';
 import { PeerErrorSeverity } from '@aztec/stdlib/p2p';
 import { TxHash } from '@aztec/stdlib/tx';
-import { peerIdFromString } from '@libp2p/peer-id';
+import { strict as assert } from 'assert';
 import { ReqRespSubProtocol } from '.././interface.js';
 import { BlockTxsRequest, BlockTxsResponse } from '.././protocols/index.js';
 import { ReqRespStatus } from '.././status.js';
 import { DEFAULT_BATCH_TX_REQUESTER_BAD_PEER_THRESHOLD, DEFAULT_BATCH_TX_REQUESTER_DUMB_PARALLEL_WORKER_COUNT, DEFAULT_BATCH_TX_REQUESTER_SMART_PARALLEL_WORKER_COUNT, DEFAULT_BATCH_TX_REQUESTER_TX_BATCH_SIZE } from './config.js';
-import { MissingTxMetadata, MissingTxMetadataCollection } from './missing_txs.js';
+import { MissingTxMetadataCollection } from './missing_txs.js';
 import { PeerCollection } from './peer_collection.js';
-import { BatchRequestTxValidator } from './tx_validator.js';
+import { createBatchRequestTxValidator } from './tx_validator.js';
 /*
  * Tries to fetch all missing transaction until deadline is hit.
  * Transactions are yield by calling run*() method
@@ -31,83 +30,64 @@ import { BatchRequestTxValidator } from './tx_validator.js';
  * - Bad peer:
  *    - Is the peer which was unable to send us successful response N times in a row
  * */ export class BatchTxRequester {
+    requestTracker;
     blockTxsSource;
     pinnedPeer;
-    timeoutMs;
     p2pService;
     logger;
-    dateProvider;
     opts;
     peers;
     txsMetadata;
-    deadline;
     smartRequesterSemaphore;
     txQueue;
     txValidator;
     smartParallelWorkerCount;
     dumbParallelWorkerCount;
     txBatchSize;
-    constructor(missingTxs, blockTxsSource, pinnedPeer, timeoutMs, p2pService, logger, dateProvider, opts){
+    constructor(requestTracker, blockTxsSource, pinnedPeer, p2pService, logger, dateProvider, opts){
+        this.requestTracker = requestTracker;
         this.blockTxsSource = blockTxsSource;
         this.pinnedPeer = pinnedPeer;
-        this.timeoutMs = timeoutMs;
         this.p2pService = p2pService;
         this.logger = logger ?? createLogger('p2p:reqresp_batch');
-        this.dateProvider = dateProvider ?? new DateProvider();
         this.opts = opts ?? {};
         this.smartParallelWorkerCount = this.opts.smartParallelWorkerCount ?? DEFAULT_BATCH_TX_REQUESTER_SMART_PARALLEL_WORKER_COUNT;
         this.dumbParallelWorkerCount = this.opts.dumbParallelWorkerCount ?? DEFAULT_BATCH_TX_REQUESTER_DUMB_PARALLEL_WORKER_COUNT;
         this.txBatchSize = this.opts.txBatchSize ?? DEFAULT_BATCH_TX_REQUESTER_TX_BATCH_SIZE;
-        this.deadline = this.dateProvider.now() + this.timeoutMs;
         this.txQueue = new FifoMemoryQueue(this.logger);
-        this.txValidator = this.opts.txValidator ?? new BatchRequestTxValidator(this.p2pService.txValidatorConfig);
+        this.txValidator = this.opts.txValidator ?? createBatchRequestTxValidator(this.p2pService.txValidatorConfig);
         if (this.opts.peerCollection) {
             this.peers = this.opts.peerCollection;
         } else {
-            const initialPeers = this.p2pService.connectionSampler.getPeerListSortedByConnectionCountAsc();
             const badPeerThreshold = this.opts.badPeerThreshold ?? DEFAULT_BATCH_TX_REQUESTER_BAD_PEER_THRESHOLD;
-            this.peers = new PeerCollection(initialPeers, this.pinnedPeer, this.dateProvider, badPeerThreshold, this.p2pService.peerScoring);
+            this.peers = new PeerCollection(this.p2pService.connectionSampler, this.pinnedPeer, dateProvider ?? new DateProvider(), badPeerThreshold, this.p2pService.peerScoring);
         }
-        const entries = missingTxs.map((h)=>[
-                h.toString(),
-                new MissingTxMetadata(h)
-            ]);
-        this.txsMetadata = new MissingTxMetadataCollection(entries, this.txBatchSize);
+        this.txsMetadata = new MissingTxMetadataCollection(requestTracker, this.txBatchSize);
         this.smartRequesterSemaphore = this.opts.semaphore ?? new Semaphore(0);
     }
     /*
-   * Fetches all missing transactions and yields them  one by one
+   * Fetches all missing transactions and yields them one by one
    * */ async *run() {
-        // Our timeout is represented in milliseconds but queue expects seconds
-        // We also want to make sure we wait at least 1 second in case of very low timeouts
-        const timeoutQueueAfter = Math.max(Math.ceil(this.timeoutMs / 1_000), 1);
         try {
             if (this.txsMetadata.getMissingTxHashes().size === 0) {
                 return undefined;
             }
-            // Start workers in background
-            const workersPromise = executeTimeout(()=>Promise.allSettled([
-                    this.smartRequester(),
-                    this.dumbRequester(),
-                    this.pinnedPeerRequester()
-                ]), this.timeoutMs).finally(()=>{
+            // Start workers in background. Workers stop themselves via requestTracker.checkCancelled().
+            const workersPromise = Promise.allSettled([
+                this.smartRequester(),
+                this.dumbRequester(),
+                this.pinnedPeerRequester()
+            ]).finally(()=>{
                 this.txQueue.end();
             });
+            // Yield txs as workers put them on the queue. The queue's end() drains remaining items
+            // before returning null, so we don't lose any txs.
             while(true){
-                const tx = await this.txQueue.get(timeoutQueueAfter);
-                // null indicates that the queue has ended
+                const tx = await this.txQueue.get();
                 if (tx === null) {
                     break;
                 }
                 yield tx;
-                if (this.shouldStop()) {
-                    // Drain queue before ending
-                    let remaining;
-                    while((remaining = this.txQueue.getImmediate()) !== undefined){
-                        yield remaining;
-                    }
-                    break;
-                }
             }
             this.unlockSmartRequesterSemaphores();
             await workersPromise;
@@ -181,7 +161,6 @@ import { BatchRequestTxValidator } from './tx_validator.js';
     /*
    * Starts dumb worker loops
    * */ async dumbRequester() {
-        const nextPeerIndex = this.makeRoundRobinIndexer();
         const nextBatchIndex = this.makeRoundRobinIndexer();
         // Chunk missing tx hashes into batches of txBatchSize, wrapping around to ensure no peer gets less than txBatchSize
         const txChunks = ()=>{
@@ -209,15 +188,10 @@ import { BatchRequestTxValidator } from './tx_validator.js';
                 txs
             };
         };
-        const nextPeer = ()=>{
-            const peers = this.peers.getDumbPeersToQuery();
-            const idx = nextPeerIndex(()=>peers.length);
-            return idx === undefined ? undefined : peerIdFromString(peers[idx]);
-        };
-        const workerCount = Math.min(this.dumbParallelWorkerCount, this.peers.getAllPeers().size);
+        const workerCount = this.dumbParallelWorkerCount;
         const workers = Array.from({
             length: workerCount
-        }, (_, index)=>this.dumbWorkerLoop(nextPeer, makeRequest, index + 1));
+        }, (_, index)=>this.dumbWorkerLoop(this.peers.nextDumbPeerToQuery.bind(this.peers), makeRequest, index + 1));
         await Promise.allSettled(workers);
     }
     /*
@@ -261,12 +235,6 @@ import { BatchRequestTxValidator } from './tx_validator.js';
     /*
    * Starts smart worker loops
    * */ async smartRequester() {
-        const nextPeerIndex = this.makeRoundRobinIndexer();
-        const nextPeer = ()=>{
-            const peers = this.peers.getSmartPeersToQuery();
-            const idx = nextPeerIndex(()=>peers.length);
-            return idx === undefined ? undefined : peerIdFromString(peers[idx]);
-        };
         const makeRequest = (pid)=>{
             const txs = this.txsMetadata.getTxsToRequestFromThePeer(pid);
             const blockRequest = BlockTxsRequest.fromTxsSourceAndMissingTxs(this.blockTxsSource, txs);
@@ -279,8 +247,8 @@ import { BatchRequestTxValidator } from './tx_validator.js';
             };
         };
         const workers = Array.from({
-            length: Math.min(this.smartParallelWorkerCount, this.peers.getAllPeers().size)
-        }, (_, index)=>this.smartWorkerLoop(nextPeer, makeRequest, index + 1));
+            length: this.smartParallelWorkerCount
+        }, (_, index)=>this.smartWorkerLoop(this.peers.nextSmartPeerToQuery.bind(this.peers), makeRequest, index + 1));
         await Promise.allSettled(workers);
     }
     /*
@@ -298,35 +266,40 @@ import { BatchRequestTxValidator } from './tx_validator.js';
    * */ async smartWorkerLoop(pickNextPeer, request, workerIndex) {
         try {
             this.logger.trace(`Smart worker ${workerIndex} started`);
-            await executeTimeout((_)=>this.smartRequesterSemaphore.acquire(), this.timeoutMs);
+            await Promise.race([
+                this.smartRequesterSemaphore.acquire(),
+                this.requestTracker.cancellationToken
+            ]);
+            if (this.requestTracker.checkCancelled()) {
+                return;
+            }
             this.logger.trace(`Smart worker ${workerIndex} acquired semaphore`);
             while(!this.shouldStop()){
                 const peerId = pickNextPeer();
                 const weRanOutOfPeersToQuery = peerId === undefined;
                 if (weRanOutOfPeersToQuery) {
                     this.logger.debug(`Worker loop smart: No more peers to query`);
-                    // If there are no more dumb peers to query then none of our peers can become smart,
-                    // thus we can simply exit this worker
-                    const noMoreDumbPeersToQuery = this.peers.getDumbPeersToQuery().length === 0;
-                    if (noMoreDumbPeersToQuery) {
-                        // These might be either smart peers that will get unblocked after _some time_
-                        const nextSmartPeerDelay = this.peers.getNextSmartPeerAvailabilityDelayMs();
-                        const thereAreSomeRateLimitedSmartPeers = nextSmartPeerDelay !== undefined;
-                        if (thereAreSomeRateLimitedSmartPeers) {
-                            await this.sleepClampedToDeadline(nextSmartPeerDelay);
-                            continue;
-                        }
-                        this.logger.debug(`Worker loop smart: No more smart peers to query killing ${workerIndex}`);
-                        break;
+                    // If we have rate limited peers wait for them.
+                    const nextSmartPeerDelay = this.peers.getNextSmartPeerAvailabilityDelayMs();
+                    const thereAreSomeRateLimitedSmartPeers = nextSmartPeerDelay !== undefined;
+                    if (thereAreSomeRateLimitedSmartPeers) {
+                        await this.sleepClampedToDeadline(nextSmartPeerDelay);
+                        continue;
                     }
-                    // Otherwise there are still some dumb peers that could become smart.
                     // We end up here when all known smart peers became temporarily unavailable via combination of
                     // (bad, in-flight, or rate-limited) or in some weird scenario all current smart peers turn bad which is permanent
-                    // but dumb peers still exist that could become smart.
+                    // but there are dumb peers that could be promoted
+                    // or new peer can join as dumb and be promoted later
                     //
                     // When a dumb peer responds with valid txIndices, it gets
                     // promoted to smart and releases the semaphore, waking this worker.
-                    await executeTimeout((_)=>this.smartRequesterSemaphore.acquire(), this.timeoutMs);
+                    await Promise.race([
+                        this.smartRequesterSemaphore.acquire(),
+                        this.requestTracker.cancellationToken
+                    ]);
+                    if (this.requestTracker.checkCancelled()) {
+                        break;
+                    }
                     this.logger.debug(`Worker loop smart: acquired next smart peer`);
                     continue;
                 }
@@ -349,11 +322,7 @@ import { BatchRequestTxValidator } from './tx_validator.js';
                 });
             }
         } catch (err) {
-            if (err instanceof TimeoutError) {
-                this.logger.debug(`Smart worker ${workerIndex} timed out waiting for semaphore`);
-            } else {
-                this.logger.error(`Smart worker ${workerIndex} encountered an error: ${err}`);
-            }
+            this.logger.error(`Smart worker ${workerIndex} encountered an error: ${err}`);
         } finally{
             this.logger.debug(`Smart worker ${workerIndex} finished`);
         }
@@ -373,6 +342,13 @@ import { BatchRequestTxValidator } from './tx_validator.js';
                 return;
             }
             const blockResponse = BlockTxsResponse.fromBuffer(response.data);
+            // Validate response. Peers will be penalised by the validator if they send invalid response.
+            const isValid = await this.p2pService.validateRequestedBlockTxsConsistency(request, blockResponse, peerId);
+            if (!isValid) {
+                this.logger.debug(`Peer ${peerId.toString()} sent invalid response`);
+                this.handleFailResponseFromPeer(peerId, ReqRespStatus.INTERNAL_ERROR);
+                return;
+            }
             await this.handleSuccessResponseFromPeer(peerId, blockResponse);
         } catch (err) {
             this.logger.error(`Failed to get valid response from peer ${peerId.toString()}: ${err.message}`, {
@@ -388,16 +364,23 @@ import { BatchRequestTxValidator } from './tx_validator.js';
    * Handles failed response form the peer
    * There are 3 scenarios
    * - RATE_LIMIT_EXCEEDED: We mark this and don't query this peer again for some_time
+   * - INTERNAL_ERROR: We use this to cover cases where the request-response consistency validation fails.
    * - FAILURE and UNKNOWN: We penalise this, if peer has been penalised this way N times they are not queried again
    *   this implies we will query these peers couple of more times and give them a chance to "redeem" themselves before completely ignoring them
    */ handleFailResponseFromPeer(peerId, responseStatus) {
-        //TODO: Should we ban these peers?
-        if (responseStatus === ReqRespStatus.FAILURE || responseStatus === ReqRespStatus.UNKNOWN) {
-            this.peers.penalisePeer(peerId, PeerErrorSeverity.HighToleranceError);
-            return;
-        }
-        if (responseStatus === ReqRespStatus.RATE_LIMIT_EXCEEDED) {
-            this.peers.markPeerRateLimitExceeded(peerId);
+        switch(responseStatus){
+            case ReqRespStatus.RATE_LIMIT_EXCEEDED:
+                this.peers.markPeerRateLimitExceeded(peerId);
+                return;
+            case ReqRespStatus.INTERNAL_ERROR:
+                this.peers.markPeerDumb(peerId);
+                this.txsMetadata.clearPeerData(peerId);
+                return;
+            default:
+                this.peers.penalisePeer(peerId, PeerErrorSeverity.HighToleranceError);
+                this.peers.markPeerDumb(peerId);
+                this.txsMetadata.clearPeerData(peerId);
+                return;
         }
     }
     /*
@@ -413,16 +396,16 @@ import { BatchRequestTxValidator } from './tx_validator.js';
    * Handles received txs.
    * Transactions are validated and then put on async queue
    * to be yielded by main running loop
-   * */ async handleReceivedTxs(peerId, txs) {
+   */ async handleReceivedTxs(peerId, txs) {
         const newTxs = txs.filter((tx)=>!this.txsMetadata.alreadyFetched(tx.txHash));
         if (newTxs.length === 0) {
             return;
         }
-        //TODO: this validation can be slow, maybe spawn worker just for validation
+        // TODO: this validation can be slow, maybe spawn worker just for validation
         // We could use the async queue for communication.
         const validationResults = await Promise.allSettled(newTxs.map(async (tx)=>({
                 tx,
-                isValid: (await this.txValidator.validateRequestedTx(tx)).result === 'valid'
+                isValid: (await this.txValidator.validateTx(tx)).result === 'valid'
             })));
         let hasInvalidTx = false;
         validationResults.forEach((result)=>{
@@ -435,6 +418,9 @@ import { BatchRequestTxValidator } from './tx_validator.js';
             }
         });
         if (hasInvalidTx) {
+            this.logger.warn(`Penalizing peer ${peerId.toString()} for sending invalid transactions in batch response`, {
+                peerId
+            });
             this.peers.penalisePeer(peerId, PeerErrorSeverity.LowToleranceError);
         } else {
             // If we have received successful response from the peer, they have "redeemed" themselves and not considered bad anymore
@@ -462,10 +448,10 @@ import { BatchRequestTxValidator } from './tx_validator.js';
         if (smartPeersAreDisabled) {
             return;
         }
-        // If block response is invalid we still want to query this peer in the future
-        // Because they sent successful response, so they might become smart peer in the future
-        // Or send us needed txs
-        if (!this.isBlockResponseValid(response)) {
+        // If the peer doesn't have the block, we mark them as dumb.
+        if (!response.peerHasBlock()) {
+            this.peers.markPeerDumb(peerId);
+            this.txsMetadata.clearPeerData(peerId);
             return;
         }
         // We mark peer as "smart" only if they have some txs we are missing
@@ -477,16 +463,12 @@ import { BatchRequestTxValidator } from './tx_validator.js';
         this.peers.markPeerSmart(peerId);
         this.markTxsPeerHas(peerId, response);
         // Unblock smart workers
-        if (this.peers.getSmartPeersToQuery().length <= this.smartParallelWorkerCount) {
-            this.smartRequesterSemaphore.release();
-        }
-    }
-    isBlockResponseValid(response) {
-        const archiveRootsMatch = this.blockTxsSource.archive.toString() === response.archiveRoot.toString();
-        const peerHasSomeTxsFromProposal = !response.txIndices.isEmpty();
-        return archiveRootsMatch && peerHasSomeTxsFromProposal;
+        this.smartRequesterSemaphore.release();
     }
     peerHasSomeTxsWeAreMissing(_peerId, response) {
+        if (response.txIndices.isEmpty()) {
+            return false;
+        }
         const txsPeerHas = new Set(this.extractHashesPeerHasFromResponse(response).map((h)=>h.toString()));
         return this.txsMetadata.getMissingTxHashes().intersection(txsPeerHas).size > 0;
     }
@@ -496,14 +478,9 @@ import { BatchRequestTxValidator } from './tx_validator.js';
         this.txsMetadata.markPeerHas(peerId, txsPeerHas);
     }
     extractHashesPeerHasFromResponse(response) {
-        const hashes = [];
-        const indicesOfHashesPeerHas = new Set(response.txIndices.getTrueIndices());
-        this.blockTxsSource.txHashes.forEach((hash, idx)=>{
-            if (indicesOfHashesPeerHas.has(idx)) {
-                hashes.push(hash);
-            }
-        });
-        return hashes;
+        // Should already have been validated, but just in case.
+        assert(response.txIndices.getLength() === this.blockTxsSource.txHashes.length);
+        return response.txIndices.getTrueIndices().map((idx)=>this.blockTxsSource.txHashes[idx]);
     }
     /*
    * Helper function to crate round robin indexer -
@@ -527,23 +504,12 @@ import { BatchRequestTxValidator } from './tx_validator.js';
         };
     }
     /*
-   * @returns true if all missing txs have been fetched */ fetchedAllTxs() {
-        return Array.from(this.txsMetadata.values()).every((tx)=>tx.fetched);
-    }
-    /*
-   * Checks if the BatchTxRequester should stop fetching missing txs
-   * Conditions for stopping are:
-   * - There have been no missing transactions to start with
-   * - All transactions have been fetched
-   * - The deadline has been hit (no more time to fetch)
-   * - This process has been cancelled via abortSignal
-   *
-   * @returns true if BatchTxRequester should stop, otherwise false*/ shouldStop() {
-        const aborted = this.opts.abortSignal?.aborted ?? false;
-        if (aborted) {
+   * Checks if the BatchTxRequester should stop fetching missing txs.
+   * Delegates to requestTracker which covers: deadline hit, all txs fetched, or external cancellation. */ shouldStop() {
+        if (this.requestTracker.checkCancelled()) {
             this.unlockSmartRequesterSemaphores();
         }
-        return aborted || this.txsMetadata.size === 0 || this.fetchedAllTxs() || this.dateProvider.now() > this.deadline;
+        return this.requestTracker.checkCancelled();
     }
     /*
    * Helper function which unlocks all smart requester semaphores
@@ -557,10 +523,12 @@ import { BatchRequestTxValidator } from './tx_validator.js';
    * Sleeps for the given duration, but clamped to the deadline.
    * This ensures we don't sleep past the deadline.
    * */ async sleepClampedToDeadline(durationMs) {
-        const remaining = this.deadline - this.dateProvider.now();
-        const thereIsTimeRemaining = remaining > 0;
-        if (thereIsTimeRemaining) {
-            await sleep(Math.min(durationMs, remaining));
+        if (this.requestTracker.checkCancelled()) {
+            return;
         }
+        await Promise.race([
+            sleep(durationMs),
+            this.requestTracker.cancellationToken
+        ]);
     }
 }