@aztec/p2p 0.0.1-commit.7cf39cb55 → 0.0.1-commit.7ffbba4

package/dest/mem_pools/tx_pool_v2/tx_pool_v2_impl.js

@@ -6,7 +6,8 @@ import { DatabasePublicStateSource } from '@aztec/stdlib/trees';
 import { Tx, TxHash } from '@aztec/stdlib/tx';
 import { TxArchive } from './archive/index.js';
 import { DeletedPool } from './deleted_pool.js';
-import { EvictionManager, FeePayerBalanceEvictionRule, FeePayerBalancePreAddRule, InvalidTxsAfterMiningRule, InvalidTxsAfterReorgRule, LowPriorityEvictionRule, LowPriorityPreAddRule, NullifierConflictRule } from './eviction/index.js';
+import { EvictionManager, FeePayerBalanceEvictionRule, FeePayerBalancePreAddRule, InvalidTxsAfterMiningRule, InvalidTxsAfterReorgRule, LowPriorityEvictionRule, LowPriorityPreAddRule, NullifierConflictRule, TxPoolRejectionCode } from './eviction/index.js';
+import { TxPoolV2Instrumentation } from './instrumentation.js';
 import { DEFAULT_TX_POOL_V2_CONFIG } from './interfaces.js';
 import { buildTxMetaData, checkNullifierConflict } from './tx_metadata.js';
 import { TxPoolIndices } from './tx_pool_indices.js';
@@ -30,9 +31,11 @@ import { TxPoolIndices } from './tx_pool_indices.js';
     #deletedPool;
     #evictionManager;
     #dateProvider;
+    #instrumentation;
+    #evictedTxHashes = new Set();
     #log;
     #callbacks;
-    constructor(store, archiveStore, deps, callbacks, config = {}, dateProvider, log){
+    constructor(store, archiveStore, deps, callbacks, telemetry, config = {}, dateProvider, log){
         this.#store = store;
         this.#txsDB = store.openMap('txs');
         this.#l2BlockSource = deps.l2BlockSource;
@@ -45,6 +48,7 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         this.#archive = new TxArchive(archiveStore, this.#config.archivedTxLimit, log);
         this.#deletedPool = new DeletedPool(store, this.#txsDB, log);
         this.#dateProvider = dateProvider;
+        this.#instrumentation = new TxPoolV2Instrumentation(telemetry, ()=>this.#indices.getTotalMetadataBytes());
         this.#log = log;
         this.#callbacks = callbacks;
         // Setup eviction manager with rules
@@ -122,8 +126,35 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const accepted = [];
         const ignored = [];
         const rejected = [];
+        const errors = new Map();
         const acceptedPending = new Set();
+        // Phase 1: Pre-compute all throwable I/O outside the transaction.
+        // If any pre-computation throws, the entire call fails before mutations happen.
+        const precomputed = new Map();
+        const validator = await this.#createTxValidator();
+        for (const tx of txs){
+            const txHash = tx.getTxHash();
+            const txHashStr = txHash.toString();
+            const meta = await buildTxMetaData(tx);
+            const minedBlockId = await this.#getMinedBlockId(txHash);
+            // Validate non-mined txs (mined and pre-protected txs bypass validation inside the transaction)
+            let isValid = true;
+            if (!minedBlockId) {
+                isValid = await this.#validateMeta(meta, validator);
+            }
+            precomputed.set(txHashStr, {
+                meta,
+                minedBlockId,
+                isValid
+            });
+        }
+        // Phase 2: Apply mutations inside the transaction using only pre-computed results,
+        // in-memory reads, and buffered DB writes. Nothing here can throw an unhandled exception.
         const poolAccess = this.#createPreAddPoolAccess();
+        const preAddContext = opts.feeComparisonOnly !== undefined ? {
+            feeComparisonOnly: opts.feeComparisonOnly,
+            priceBumpPercentage: this.#config.priceBumpPercentage
+        } : undefined;
         await this.#store.transactionAsync(async ()=>{
             for (const tx of txs){
                 const txHash = tx.getTxHash();
@@ -133,85 +164,112 @@ import { TxPoolIndices } from './tx_pool_indices.js';
                     ignored.push(txHash);
                     continue;
                 }
-                // Check mined status first (applies to all paths)
-                const minedBlockId = await this.#getMinedBlockId(txHash);
+                const { meta, minedBlockId, isValid } = precomputed.get(txHashStr);
                 const preProtectedSlot = this.#indices.getProtectionSlot(txHashStr);
                 if (minedBlockId) {
                     // Already mined - add directly (protection already set if pre-protected)
                     await this.#addTx(tx, {
                         mined: minedBlockId
-                    }, opts);
+                    }, opts, meta);
                     accepted.push(txHash);
                 } else if (preProtectedSlot !== undefined) {
                     // Pre-protected and not mined - add as protected (bypass validation)
                     await this.#addTx(tx, {
                         protected: preProtectedSlot
-                    }, opts);
+                    }, opts, meta);
                     accepted.push(txHash);
+                } else if (!isValid) {
+                    // Failed pre-computed validation
+                    rejected.push(txHash);
                 } else {
-                    // Regular pending tx - validate and run pre-add rules
-                    const result = await this.#tryAddRegularPendingTx(tx, opts, poolAccess, acceptedPending, ignored);
+                    // Regular pending tx - run pre-add rules using pre-computed metadata
+                    const result = await this.#tryAddRegularPendingTx(tx, meta, opts, poolAccess, acceptedPending, ignored, errors, preAddContext);
                     if (result.status === 'accepted') {
                         acceptedPending.add(txHashStr);
-                    } else if (result.status === 'rejected') {
-                        rejected.push(txHash);
                     } else {
                         ignored.push(txHash);
                     }
                 }
             }
+            // Run post-add eviction rules for pending txs (inside transaction for atomicity)
+            if (acceptedPending.size > 0) {
+                const feePayers = Array.from(acceptedPending).map((txHash)=>this.#indices.getMetadata(txHash).feePayer);
+                const uniqueFeePayers = new Set(feePayers);
+                await this.#evictionManager.evictAfterNewTxs(Array.from(acceptedPending), [
+                    ...uniqueFeePayers
+                ]);
+            }
         });
         // Build final accepted list for pending txs (excludes intra-batch evictions)
         for (const txHashStr of acceptedPending){
             accepted.push(TxHash.fromString(txHashStr));
         }
-        // Run post-add eviction rules for pending txs
-        if (acceptedPending.size > 0) {
-            const feePayers = Array.from(acceptedPending).map((txHash)=>this.#indices.getMetadata(txHash).feePayer);
-            const uniqueFeePayers = new Set(feePayers);
-            await this.#evictionManager.evictAfterNewTxs(Array.from(acceptedPending), [
-                ...uniqueFeePayers
-            ]);
+        // Record metrics
+        if (ignored.length > 0) {
+            this.#instrumentation.recordIgnored(ignored.length);
+        }
+        if (rejected.length > 0) {
+            this.#instrumentation.recordRejected(rejected.length);
         }
         return {
             accepted,
             ignored,
-            rejected
+            rejected,
+            ...errors.size > 0 ? {
+                errors
+            } : {}
         };
     }
-    /** Validates and adds a regular pending tx. Returns status. */ async #tryAddRegularPendingTx(tx, opts, poolAccess, acceptedPending, ignored) {
-        const txHash = tx.getTxHash();
-        const txHashStr = txHash.toString();
-        // Build metadata and validate using metadata
-        const meta = await buildTxMetaData(tx);
-        if (!await this.#validateMeta(meta)) {
-            return {
-                status: 'rejected'
-            };
-        }
+    /** Adds a validated pending tx, running pre-add rules and evicting conflicts. */ async #tryAddRegularPendingTx(tx, precomputedMeta, opts, poolAccess, acceptedPending, ignored, errors, preAddContext) {
+        const txHashStr = tx.getTxHash().toString();
         // Run pre-add rules
-        const preAddResult = await this.#evictionManager.runPreAddRules(meta, poolAccess);
+        const preAddResult = await this.#evictionManager.runPreAddRules(precomputedMeta, poolAccess, preAddContext);
         if (preAddResult.shouldIgnore) {
-            this.#log.debug(`Ignoring tx ${txHashStr}: ${preAddResult.reason}`);
+            this.#log.debug(`Ignoring tx ${txHashStr}: ${preAddResult.reason?.message ?? 'unknown reason'}`);
+            if (preAddResult.reason && preAddResult.reason.code !== TxPoolRejectionCode.INTERNAL_ERROR) {
+                errors.set(txHashStr, preAddResult.reason);
+            }
             return {
                 status: 'ignored'
             };
         }
-        // Evict conflicts
-        for (const evictHashStr of preAddResult.txHashesToEvict){
-            await this.#deleteTx(evictHashStr);
-            this.#log.debug(`Evicted tx ${evictHashStr} due to higher-fee tx ${txHashStr}`, {
-                evictedTxHash: evictHashStr,
-                replacementTxHash: txHashStr
-            });
-            if (acceptedPending.has(evictHashStr)) {
-                // Evicted tx was from this batch - mark as ignored in result
-                acceptedPending.delete(evictHashStr);
-                ignored.push(TxHash.fromString(evictHashStr));
+        // Evict conflicts, grouped by rule name for metrics
+        if (preAddResult.evictions && preAddResult.evictions.length > 0) {
+            const byReason = new Map();
+            for (const { txHash: evictHash, reason } of preAddResult.evictions){
+                const group = byReason.get(reason);
+                if (group) {
+                    group.push(evictHash);
+                } else {
+                    byReason.set(reason, [
+                        evictHash
+                    ]);
+                }
+            }
+            for (const [reason, hashes] of byReason){
+                await this.#evictTxs(hashes, reason);
+            }
+            for (const evictHashStr of preAddResult.txHashesToEvict){
+                this.#log.debug(`Evicted tx ${evictHashStr} due to higher-fee tx ${txHashStr}`, {
+                    evictedTxHash: evictHashStr,
+                    replacementTxHash: txHashStr
+                });
+                if (acceptedPending.has(evictHashStr)) {
+                    // Evicted tx was from this batch - mark as ignored in result
+                    acceptedPending.delete(evictHashStr);
+                    ignored.push(TxHash.fromString(evictHashStr));
+                }
             }
         }
+        // Randomly drop the transaction for testing purposes (report as accepted so it propagates)
+        if (this.#config.dropTransactionsProbability > 0 && Math.random() < this.#config.dropTransactionsProbability) {
+            this.#log.debug(`Dropping tx ${txHashStr} (simulated drop for testing)`);
+            return {
+                status: 'accepted'
+            };
+        }
         // Add the transaction
-        await this.#addTx(tx, 'pending', opts);
+        await this.#addTx(tx, 'pending', opts, precomputedMeta);
         return {
             status: 'accepted'
         };
@@ -222,13 +280,8 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         if (this.#indices.has(txHashStr)) {
             return 'ignored';
         }
-        // Build metadata and validate using metadata
+        // Build metadata and check pre-add rules
         const meta = await buildTxMetaData(tx);
-        const validationResult = await this.#validateMeta(meta, undefined, 'can add pending');
-        if (validationResult !== true) {
-            return 'rejected';
-        }
-        // Use pre-add rules
         const poolAccess = this.#createPreAddPoolAccess();
         const preAddResult = await this.#evictionManager.runPreAddRules(meta, poolAccess);
         return preAddResult.shouldIgnore ? 'ignored' : 'accepted';
@@ -264,20 +317,53 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             }
         });
     }
-    protectTxs(txHashes, block) {
+    async protectTxs(txHashes, block) {
         const slotNumber = block.globalVariables.slotNumber;
         const missing = [];
-        for (const txHash of txHashes){
-            const txHashStr = txHash.toString();
-            if (this.#indices.has(txHashStr)) {
-                // Update protection for existing tx
-                this.#indices.updateProtection(txHashStr, slotNumber);
-            } else {
-                // Pre-record protection for tx we don't have yet
-                this.#indices.setProtection(txHashStr, slotNumber);
-                missing.push(txHash);
+        let softDeletedHits = 0;
+        let missingPreviouslyEvicted = 0;
+        await this.#store.transactionAsync(async ()=>{
+            for (const txHash of txHashes){
+                const txHashStr = txHash.toString();
+                if (this.#indices.has(txHashStr)) {
+                    // Update protection for existing tx
+                    this.#indices.updateProtection(txHashStr, slotNumber);
+                } else if (this.#deletedPool.isSoftDeleted(txHashStr)) {
+                    // Resurrect soft-deleted tx as protected
+                    const buffer = await this.#txsDB.getAsync(txHashStr);
+                    if (buffer) {
+                        const tx = Tx.fromBuffer(buffer);
+                        await this.#addTx(tx, {
+                            protected: slotNumber
+                        });
+                        softDeletedHits++;
+                    } else {
+                        // Data missing despite soft-delete flag — treat as truly missing
+                        this.#indices.setProtection(txHashStr, slotNumber);
+                        missing.push(txHash);
+                    }
+                } else {
+                    // Truly missing — pre-record protection for tx we don't have yet
+                    this.#indices.setProtection(txHashStr, slotNumber);
+                    missing.push(txHash);
+                    if (this.#evictedTxHashes.has(txHashStr)) {
+                        missingPreviouslyEvicted++;
+                    }
+                }
             }
+        });
+        // Record metrics
+        if (softDeletedHits > 0) {
+            this.#instrumentation.recordSoftDeletedHits(softDeletedHits);
+        }
+        if (missing.length > 0) {
+            this.#log.debug(`protectTxs missing tx hashes: ${missing.map((h)=>h.toString()).join(', ')}`);
+            this.#instrumentation.recordMissingOnProtect(missing.length);
+        }
+        if (missingPreviouslyEvicted > 0) {
+            this.#instrumentation.recordMissingPreviouslyEvicted(missingPreviouslyEvicted);
         }
+        this.#log.info(`Protected ${txHashes.length} txs, missing: ${missing.length}, soft-deleted hits: ${softDeletedHits}`);
         return missing;
     }
     async addMinedTxs(txs, block, opts) {
@@ -316,47 +402,53 @@ import { TxPoolIndices } from './tx_pool_indices.js';
                 found.push(meta);
             }
         }
-        // Step 4: Mark txs as mined (only those we have in the pool)
-        for (const meta of found){
-            this.#indices.markAsMined(meta, blockId);
-            await this.#deletedPool.clearIfMinedHigher(meta.txHash, blockId.number);
+        await this.#store.transactionAsync(async ()=>{
+            // Step 4: Mark txs as mined (only those we have in the pool)
+            for (const meta of found){
+                this.#indices.markAsMined(meta, blockId);
+                await this.#deletedPool.clearIfMinedHigher(meta.txHash, blockId.number);
+            }
+            // Step 5: Run post-event eviction rules (inside transaction for atomicity)
+            await this.#evictionManager.evictAfterNewBlock(block.header, nullifiers, feePayers);
+        });
+        if (found.length > 0) {
+            this.#callbacks.onTxsMined(found.map((m)=>m.txHash));
         }
-        // Step 5: Run eviction rules (remove pending txs with conflicting nullifiers/expired timestamps)
-        await this.#evictionManager.evictAfterNewBlock(block.header, nullifiers, feePayers);
         this.#log.info(`Marked ${found.length} txs as mined in block ${blockId.number}`);
     }
     async prepareForSlot(slotNumber) {
-        // Step 0: Clean up slot-deleted txs from previous slots
-        await this.#deletedPool.cleanupSlotDeleted(slotNumber);
-        // Step 1: Find expired protected txs
-        const expiredProtected = this.#indices.findExpiredProtectedTxs(slotNumber);
-        // Step 2: Clear protection for all expired entries (including those without metadata)
-        this.#indices.clearProtection(expiredProtected);
-        // Step 3: Filter to only txs that have metadata and are not mined
-        const txsToRestore = this.#indices.filterRestorable(expiredProtected);
-        if (txsToRestore.length === 0) {
-            return;
-        }
-        this.#log.info(`Preparing for slot ${slotNumber}: unprotecting ${txsToRestore.length} txs`);
-        // Step 4: Validate for pending pool
-        const { valid, invalid } = await this.#revalidateMetadata(txsToRestore, 'during prepareForSlot');
-        // Step 5: Resolve nullifier conflicts and add winners to pending indices
-        const { added, toEvict } = this.#applyNullifierConflictResolution(valid);
-        // Step 6: Delete invalid and evicted txs
-        await this.#deleteTxsBatch([
-            ...invalid,
-            ...toEvict
-        ]);
-        // Step 7: Run eviction rules (enforce pool size limit)
-        if (added.length > 0) {
-            const feePayers = added.map((meta)=>meta.feePayer);
-            const uniqueFeePayers = new Set(feePayers);
-            await this.#evictionManager.evictAfterNewTxs(added.map((m)=>m.txHash), [
-                ...uniqueFeePayers
-            ]);
-        }
+        await this.#store.transactionAsync(async ()=>{
+            // Step 0: Clean up slot-deleted txs from previous slots
+            await this.#deletedPool.cleanupSlotDeleted(slotNumber);
+            // Step 1: Find expired protected txs
+            const expiredProtected = this.#indices.findExpiredProtectedTxs(slotNumber);
+            // Step 2: Clear protection for all expired entries (including those without metadata)
+            this.#indices.clearProtection(expiredProtected);
+            // Step 3: Filter to only txs that have metadata and are not mined
+            const txsToRestore = this.#indices.filterRestorable(expiredProtected);
+            if (txsToRestore.length === 0) {
+                this.#log.debug(`Preparing for slot ${slotNumber}, no txs to unprotect`);
+                return;
+            }
+            this.#log.info(`Preparing for slot ${slotNumber}: unprotecting ${txsToRestore.length} txs`);
+            // Step 4: Validate for pending pool
+            const { valid, invalid } = await this.#revalidateMetadata(txsToRestore, 'during prepareForSlot');
+            // Step 5: Resolve nullifier conflicts and add winners to pending indices
+            const { added, toEvict } = this.#applyNullifierConflictResolution(valid);
+            // Step 6: Delete invalid txs and evict conflict losers
+            await this.#deleteTxsBatch(invalid);
+            await this.#evictTxs(toEvict, 'NullifierConflict');
+            // Step 7: Run eviction rules (enforce pool size limit)
+            if (added.length > 0) {
+                const feePayers = added.map((meta)=>meta.feePayer);
+                const uniqueFeePayers = new Set(feePayers);
+                await this.#evictionManager.evictAfterNewTxs(added.map((m)=>m.txHash), [
+                    ...uniqueFeePayers
+                ]);
+            }
+        });
     }
-    async handlePrunedBlocks(latestBlock) {
+    async handlePrunedBlocks(latestBlock, options) {
         // Step 1: Find transactions mined after the prune point
         const txsToUnmine = this.#indices.findTxsMinedAfter(latestBlock.number);
         if (txsToUnmine.length === 0) {
@@ -364,40 +456,48 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             return;
         }
         this.#log.info(`Handling prune to block ${latestBlock.number}: un-mining ${txsToUnmine.length} txs`);
-        // Step 2: Mark ALL un-mined txs with their original mined block number
-        // This ensures they get soft-deleted if removed later, and only hard-deleted
-        // when their original mined block is finalized
-        await this.#deletedPool.markFromPrunedBlock(txsToUnmine.map((m)=>({
-                txHash: m.txHash,
-                minedAtBlock: BlockNumber(m.minedL2BlockId.number)
-            })));
-        // Step 3: Unmine - clear mined status from metadata
-        for (const meta of txsToUnmine){
-            this.#indices.markAsUnmined(meta);
-        }
-        // Step 4: Filter out protected txs (they'll be handled by prepareForSlot)
-        const unprotectedTxs = this.#indices.filterUnprotected(txsToUnmine);
-        // Step 4: Validate for pending pool
-        const { valid, invalid } = await this.#revalidateMetadata(unprotectedTxs, 'during handlePrunedBlocks');
-        // Step 6: Resolve nullifier conflicts and add winners to pending indices
-        const { toEvict } = this.#applyNullifierConflictResolution(valid);
-        // Step 7: Delete invalid and evicted txs
-        await this.#deleteTxsBatch([
-            ...invalid,
-            ...toEvict
-        ]);
-        this.#log.info(`Handled prune to block ${latestBlock.number}: ${valid.length} txs restored to pending, ${invalid.length} invalid, ${toEvict.length} evicted due to nullifier conflicts`, {
-            txHashesRestored: valid.map((m)=>m.txHash),
-            txHashesInvalid: invalid,
-            txHashesEvicted: toEvict
+        await this.#store.transactionAsync(async ()=>{
+            // Step 2: Mark ALL un-mined txs with their original mined block number
+            // This ensures they get soft-deleted if removed later, and only hard-deleted
+            // when their original mined block is finalized
+            await this.#deletedPool.markFromPrunedBlock(txsToUnmine.map((m)=>({
+                    txHash: m.txHash,
+                    minedAtBlock: BlockNumber(m.minedL2BlockId.number)
+                })));
+            // Step 3: Unmine - clear mined status from metadata
+            for (const meta of txsToUnmine){
+                this.#indices.markAsUnmined(meta);
+            }
+            // If deleteAllTxs is set (epoch prune), delete all un-mined txs and return early
+            if (options?.deleteAllTxs) {
+                const allTxHashes = txsToUnmine.map((m)=>m.txHash);
+                await this.#deleteTxsBatch(allTxHashes);
+                this.#log.info(`Handled prune to block ${latestBlock.number} with deleteAllTxs: deleted ${allTxHashes.length} txs`);
+                return;
+            }
+            // Step 4: Filter out protected txs (they'll be handled by prepareForSlot)
+            const unprotectedTxs = this.#indices.filterUnprotected(txsToUnmine);
+            // Step 5: Validate for pending pool
+            const { valid, invalid } = await this.#revalidateMetadata(unprotectedTxs, 'during handlePrunedBlocks');
+            // Step 6: Resolve nullifier conflicts and add winners to pending indices
+            const { toEvict } = this.#applyNullifierConflictResolution(valid);
+            // Step 7: Delete invalid txs and evict conflict losers
+            await this.#deleteTxsBatch(invalid);
+            await this.#evictTxs(toEvict, 'NullifierConflict');
+            this.#log.info(`Handled prune to block ${latestBlock.number}: ${valid.length} txs restored to pending, ${invalid.length} invalid, ${toEvict.length} evicted due to nullifier conflicts`, {
+                txHashesRestored: valid.map((m)=>m.txHash),
+                txHashesInvalid: invalid,
+                txHashesEvicted: toEvict
+            });
+            // Step 8: Run eviction rules for ALL pending txs (not just restored ones)
+            // This handles cases like existing pending txs with invalid fee payer balances
+            await this.#evictionManager.evictAfterChainPrune(latestBlock.number);
         });
-        // Step 8: Run eviction rules for ALL pending txs (not just restored ones)
-        // This handles cases like existing pending txs with invalid fee payer balances
-        await this.#evictionManager.evictAfterChainPrune(latestBlock.number);
     }
     async handleFailedExecution(txHashes) {
-        // Delete failed txs
-        await this.#deleteTxsBatch(txHashes.map((h)=>h.toString()));
+        await this.#store.transactionAsync(async ()=>{
+            await this.#deleteTxsBatch(txHashes.map((h)=>h.toString()));
+        });
         this.#log.info(`Deleted ${txHashes.length} failed txs`, {
             txHashes: txHashes.map((h)=>h.toString())
         });
@@ -406,24 +506,26 @@ import { TxPoolIndices } from './tx_pool_indices.js';
         const blockNumber = block.globalVariables.blockNumber;
         // Step 1: Find mined txs at or before finalized block
         const minedTxsToFinalize = this.#indices.findTxsMinedAtOrBefore(blockNumber);
-        // Step 2: Collect mined txs for archiving (before deletion)
-        const txsToArchive = [];
-        if (this.#archive.isEnabled()) {
-            for (const txHashStr of minedTxsToFinalize){
-                const buffer = await this.#txsDB.getAsync(txHashStr);
-                if (buffer) {
-                    txsToArchive.push(Tx.fromBuffer(buffer));
+        await this.#store.transactionAsync(async ()=>{
+            // Step 2: Collect mined txs for archiving (before deletion)
+            const txsToArchive = [];
+            if (this.#archive.isEnabled()) {
+                for (const txHashStr of minedTxsToFinalize){
+                    const buffer = await this.#txsDB.getAsync(txHashStr);
+                    if (buffer) {
+                        txsToArchive.push(Tx.fromBuffer(buffer));
+                    }
                 }
             }
-        }
-        // Step 3: Delete mined txs from active pool
-        await this.#deleteTxsBatch(minedTxsToFinalize);
-        // Step 4: Finalize soft-deleted txs
-        await this.#deletedPool.finalizeBlock(blockNumber);
-        // Step 5: Archive mined txs
-        if (txsToArchive.length > 0) {
-            await this.#archive.archiveTxs(txsToArchive);
-        }
+            // Step 3: Delete mined txs from active pool
+            await this.#deleteTxsBatch(minedTxsToFinalize);
+            // Step 4: Finalize soft-deleted txs
+            await this.#deletedPool.finalizeBlock(blockNumber);
+            // Step 5: Archive mined txs
+            if (txsToArchive.length > 0) {
+                await this.#archive.archiveTxs(txsToArchive);
+            }
+        });
         if (minedTxsToFinalize.length > 0) {
             this.#log.info(`Finalized ${minedTxsToFinalize.length} mined txs from blocks up to ${blockNumber}`, {
                 txHashes: minedTxsToFinalize
@@ -528,7 +630,10 @@ import { TxPoolIndices } from './tx_pool_indices.js';
     }
     // === Metrics ===
     countTxs() {
-        return this.#indices.countTxs();
+        return {
+            ...this.#indices.countTxs(),
+            softDeleted: this.#deletedPool.getSoftDeletedCount()
+        };
     }
     // ============================================================================
     // PRIVATE HELPERS - Transaction Management
@@ -536,9 +641,9 @@ import { TxPoolIndices } from './tx_pool_indices.js';
     /**
    * Adds a new transaction to the pool with the specified state.
    * Emits onTxsAdded callback immediately after DB write.
-   */ async #addTx(tx, state, opts = {}) {
+   */ async #addTx(tx, state, opts = {}, precomputedMeta) {
         const txHashStr = tx.getTxHash().toString();
-        const meta = await buildTxMetaData(tx);
+        const meta = precomputedMeta ?? await buildTxMetaData(tx);
         meta.receivedAt = this.#dateProvider.now();
         await this.#txsDB.set(txHashStr, tx.toBuffer());
         await this.#deletedPool.clearSoftDeleted(txHashStr);
@@ -554,9 +659,11 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             this.#indices.addMined(meta);
         }
         const stateStr = typeof state === 'string' ? state : Object.keys(state)[0];
-        this.#log.verbose(`Added ${stateStr} tx ${txHashStr}`, {
+        this.#log.debug(`Added tx ${txHashStr} as ${stateStr}`, {
             eventName: 'tx-added-to-pool',
-            state: stateStr
+            txHash: txHashStr,
+            state: stateStr,
+            source: opts.source
         });
         return meta;
     }
@@ -579,6 +686,28 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             await this.#deleteTx(txHashStr);
         }
     }
+    /** Evicts transactions: records eviction metric with reason, caches hashes, then deletes. */ async #evictTxs(txHashes, reason) {
+        if (txHashes.length === 0) {
+            return;
+        }
+        this.#instrumentation.recordEvictions(txHashes.length, reason);
+        for (const txHashStr of txHashes){
+            this.#log.debug(`Evicting tx ${txHashStr}`, {
+                txHash: txHashStr,
+                reason
+            });
+            this.#addToEvictedCache(txHashStr);
+        }
+        await this.#deleteTxsBatch(txHashes);
+    }
+    /** Adds a tx hash to the bounded evicted cache, evicting the oldest entry if at capacity. */ #addToEvictedCache(txHashStr) {
+        if (this.#evictedTxHashes.size >= this.#config.evictedTxCacheSize) {
+            // FIFO eviction: remove the first (oldest) entry
+            const oldest = this.#evictedTxHashes.values().next().value;
+            this.#evictedTxHashes.delete(oldest);
+        }
+        this.#evictedTxHashes.add(txHashStr);
+    }
     // ============================================================================
     // PRIVATE HELPERS - Validation & Conflict Resolution
     // ============================================================================
@@ -717,7 +846,7 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             if (preAddResult.shouldIgnore) {
                 // Transaction rejected - mark for deletion from DB
                 rejected.push(meta.txHash);
-                this.#log.debug(`Rejected tx ${meta.txHash} during rebuild: ${preAddResult.reason}`);
+                this.#log.debug(`Rejected tx ${meta.txHash} during rebuild: ${preAddResult.reason?.message ?? 'unknown reason'}`);
                 continue;
             }
             // Evict any conflicting txs identified by pre-add rules
@@ -753,7 +882,7 @@ import { TxPoolIndices } from './tx_pool_indices.js';
             getFeePayerPendingTxs: (feePayer)=>this.#indices.getFeePayerPendingTxs(feePayer),
             getPendingTxCount: ()=>this.#indices.getPendingTxCount(),
             getLowestPriorityPending: (limit)=>this.#indices.getLowestPriorityPending(limit),
-            deleteTxs: (txHashes)=>this.#deleteTxsBatch(txHashes)
+            deleteTxs: (txHashes, reason)=>this.#evictTxs(txHashes, reason ?? 'unknown')
         };
     }
     #createPreAddPoolAccess() {

package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts

@@ -1,9 +1,11 @@
 import type { EpochCacheInterface } from '@aztec/epoch-cache';
-import type { BlockProposal, P2PValidator } from '@aztec/stdlib/p2p';
-import { ProposalValidator } from '../proposal_validator/proposal_validator.js';
-export declare class BlockProposalValidator extends ProposalValidator<BlockProposal> implements P2PValidator<BlockProposal> {
+import type { BlockProposal, P2PValidator, ValidationResult } from '@aztec/stdlib/p2p';
+export declare class BlockProposalValidator implements P2PValidator<BlockProposal> {
+    private proposalValidator;
     constructor(epochCache: EpochCacheInterface, opts: {
         txsPermitted: boolean;
+        maxTxsPerBlock?: number;
     });
+    validate(proposal: BlockProposal): Promise<ValidationResult>;
 }
-//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmxvY2tfcHJvcG9zYWxfdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvcHJvcG9zYWxfdmFsaWRhdG9yL2Jsb2NrX3Byb3Bvc2FsX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBQzlELE9BQU8sS0FBSyxFQUFFLGFBQWEsRUFBRSxZQUFZLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUVyRSxPQUFPLEVBQUUsaUJBQWlCLEVBQUUsTUFBTSw2Q0FBNkMsQ0FBQztBQUVoRixxQkFBYSxzQkFBdUIsU0FBUSxpQkFBaUIsQ0FBQyxhQUFhLENBQUUsWUFBVyxZQUFZLENBQUMsYUFBYSxDQUFDO0lBQ2pILFlBQVksVUFBVSxFQUFFLG1CQUFtQixFQUFFLElBQUksRUFBRTtRQUFFLFlBQVksRUFBRSxPQUFPLENBQUE7S0FBRSxFQUUzRTtDQUNGIn0=
+//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYmxvY2tfcHJvcG9zYWxfdmFsaWRhdG9yLmQudHMiLCJzb3VyY2VSb290IjoiIiwic291cmNlcyI6WyIuLi8uLi8uLi9zcmMvbXNnX3ZhbGlkYXRvcnMvcHJvcG9zYWxfdmFsaWRhdG9yL2Jsb2NrX3Byb3Bvc2FsX3ZhbGlkYXRvci50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQSxPQUFPLEtBQUssRUFBRSxtQkFBbUIsRUFBRSxNQUFNLG9CQUFvQixDQUFDO0FBQzlELE9BQU8sS0FBSyxFQUFFLGFBQWEsRUFBRSxZQUFZLEVBQUUsZ0JBQWdCLEVBQUUsTUFBTSxtQkFBbUIsQ0FBQztBQUl2RixxQkFBYSxzQkFBdUIsWUFBVyxZQUFZLENBQUMsYUFBYSxDQUFDO0lBQ3hFLE9BQU8sQ0FBQyxpQkFBaUIsQ0FBb0I7SUFFN0MsWUFBWSxVQUFVLEVBQUUsbUJBQW1CLEVBQUUsSUFBSSxFQUFFO1FBQUUsWUFBWSxFQUFFLE9BQU8sQ0FBQztRQUFDLGNBQWMsQ0FBQyxFQUFFLE1BQU0sQ0FBQTtLQUFFLEVBRXBHO0lBRUssUUFBUSxDQUFDLFFBQVEsRUFBRSxhQUFhLEdBQUcsT0FBTyxDQUFDLGdCQUFnQixDQUFDLENBTWpFO0NBQ0YifQ==

package/dest/msg_validators/proposal_validator/block_proposal_validator.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"block_proposal_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/proposal_validator/block_proposal_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,KAAK,EAAE,aAAa,EAAE,YAAY,EAAE,MAAM,mBAAmB,CAAC;AAErE,OAAO,EAAE,iBAAiB,EAAE,MAAM,6CAA6C,CAAC;AAEhF,qBAAa,sBAAuB,SAAQ,iBAAiB,CAAC,aAAa,CAAE,YAAW,YAAY,CAAC,aAAa,CAAC;IACjH,YAAY,UAAU,EAAE,mBAAmB,EAAE,IAAI,EAAE;QAAE,YAAY,EAAE,OAAO,CAAA;KAAE,EAE3E;CACF"}
+{"version":3,"file":"block_proposal_validator.d.ts","sourceRoot":"","sources":["../../../src/msg_validators/proposal_validator/block_proposal_validator.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,mBAAmB,EAAE,MAAM,oBAAoB,CAAC;AAC9D,OAAO,KAAK,EAAE,aAAa,EAAE,YAAY,EAAE,gBAAgB,EAAE,MAAM,mBAAmB,CAAC;AAIvF,qBAAa,sBAAuB,YAAW,YAAY,CAAC,aAAa,CAAC;IACxE,OAAO,CAAC,iBAAiB,CAAoB;IAE7C,YAAY,UAAU,EAAE,mBAAmB,EAAE,IAAI,EAAE;QAAE,YAAY,EAAE,OAAO,CAAC;QAAC,cAAc,CAAC,EAAE,MAAM,CAAA;KAAE,EAEpG;IAEK,QAAQ,CAAC,QAAQ,EAAE,aAAa,GAAG,OAAO,CAAC,gBAAgB,CAAC,CAMjE;CACF"}

package/dest/msg_validators/proposal_validator/block_proposal_validator.js

@@ -1,6 +1,14 @@
 import { ProposalValidator } from '../proposal_validator/proposal_validator.js';
-export class BlockProposalValidator extends ProposalValidator {
+export class BlockProposalValidator {
+    proposalValidator;
     constructor(epochCache, opts){
-        super(epochCache, opts, 'p2p:block_proposal_validator');
+        this.proposalValidator = new ProposalValidator(epochCache, opts, 'p2p:block_proposal_validator');
+    }
+    async validate(proposal) {
+        const headerResult = await this.proposalValidator.validate(proposal);
+        if (headerResult.result !== 'accept') {
+            return headerResult;
+        }
+        return this.proposalValidator.validateTxs(proposal);
     }
 }